Re: Migrate Sauce Labs user used in CI testing from snay to cordova

2020-08-31 Thread Jan Piotrowski
You might go slow on this - somewhere in the back of my head I have _something_ why we did not follow through with this in the past but I can not figure out what it was, sorry :/ Hopefully it is nothing and will just work. J Am So., 30. Aug. 2020 um 19:55 Uhr schrieb Tim Brust : > Hi there, >

Re: 💡Cordova as a monorepo - ??

2020-08-28 Thread Jan Piotrowski
> and it would help us to keep the issues and discussions all in one place. I would challenge you actually want that. To be able to properly work on one plugin, you would need to have labelled all issues and PRs and then filter all views for that. In my experience this only makes sense for closel

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-18 Thread Jan Piotrowski
+1 Am Di., 18. Aug. 2020 um 08:31 Uhr schrieb Tim Brust : > +1 > > Sent from my iPhone > > > On 18. Aug 2020, at 8:22 AM, Dave Alden wrote: > > > > +1 > > > >> On Tue, 18 Aug 2020, 05:47 Bryan Ellis, wrote: > >> > >> This vote is only for the purpose of unarchive and remove the > deprecation >

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-device-motion

2020-08-18 Thread Jan Piotrowski
+1 Am Di., 18. Aug. 2020 um 06:59 Uhr schrieb Norman Breau < nor...@normanbreau.com>: > 1+ > > Norman Breau > Software Developer > > nor...@normanbreau.com ( > https://link.getmailspring.com/link/26afd337-8d43-4f5e-9b5d-b565ffb5f...@getmailspring.com/0?redirect=mailto%3Anorman%40normanbreau.com&r

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-device-orientation

2020-08-18 Thread Jan Piotrowski
+1 Am Di., 18. Aug. 2020 um 08:46 Uhr schrieb Dave Alden < d...@workingedge.co.uk>: > +1 > > On Tue, 18 Aug 2020, 05:47 Bryan Ellis, wrote: > > > This vote is only for the purpose of unarchive and remove the deprecation > > status for the plugin of: > > > > cordova-plugin-device-orientation >

Re: [PROPOSAL] Enable Probot Apps to Improve Issue Tracker

2020-04-17 Thread Jan Piotrowski
I think in the past we also got pushback from INFRA on using bots via apps because of access to data etc (similar to CI services etc). Not sure if that changed in the last few months. J Am Fr., 17. Apr. 2020 um 13:44 Uhr schrieb Niklas Merz : > > I think I have to agree there. > > I would vote -0

Re: Team page on Cordova website

2020-04-02 Thread Jan Piotrowski
There are existing tools that do what you suggest Raphael, mostly to put contributors into READMEs of projects but I am sure that could be abused to put it into a Markdown file that is included in the docs. Apache also has a site that lists all PMC members etc (that I think uses some AJAX + a JSON

Re: [GitHub] [cordova-eslint] raphinesse opened a new pull request #10: feat: make base rules stricter & closer to semistandard

2019-11-10 Thread Jan Piotrowski
This repository is misconfigured, these emails should probably go to the commits mailing list and not dev. (Yep, the default in the infra tool is not optimal here) J Am Fr., 8. Nov. 2019 um 21:05 Uhr schrieb GitBox : > raphinesse opened a new pull request #10: feat: make base rules stricter & >

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

2019-08-13 Thread Jan Piotrowski
agree now? > Or should I create a new thread to discuss it again? > > > El jue., 23 ago. 2018 a las 16:24, Jan Piotrowski () > escribió: > > > Here is the PR on GitHub templates, our usage of them and actual > > drafts for all templates: > > https://github.com/apac

Re: [DISCUSS] Replacing ADB usage in favour for using BundleTools

2019-08-12 Thread Jan Piotrowski
Sounds great. Historically we always had trouble when Google decided to replace/deprecate/change any of the tools in the build toolchain, so keeping up to date what is the tool of the week sounds like a good idea. Important to consider is the availability of that tool for older Android versions, o

Re: [Cordova dev] info needed label

2019-07-30 Thread Jan Piotrowski
Chris Brody wrote: > > > > I am now changing the "query" labels back to "question", though under > > protest. I did already check that the new "info-needed" label is used > > where it looked appropriate. But I don't see what documentation &

Re: Android - App Bundle Support

2019-07-30 Thread Jan Piotrowski
+1 on #1, #2 and #3 - just don't forget to create the issue that makes sure #3 will be taken care of later. J Am Di., 30. Juli 2019 um 14:10 Uhr schrieb Norman Breau : > > Hello devs! > > I am writing to gather feedback on the new feature to support building > the new android packaging format: an

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-07-30 Thread Jan Piotrowski
make this release this week? > > On Fri, Jul 5, 2019 at 9:50 AM Tim Brust > wrote: > > > > For the lazy ppl, here is the diff: > > https://github.com/apache/cordova-windows/compare/7.0.0...master > > Go for it Jan! :) > > > > On Thu, Jul 4, 2019 at 5:5

Re: [Cordova dev] info needed label

2019-07-30 Thread Jan Piotrowski
. Juli 2019 um 08:20 Uhr schrieb Jan Piotrowski : > > Chris, it has been over a week. What is the state of undoing the label > and documentation changes? > > -J > > Am Mi., 17. Juli 2019 um 20:08 Uhr schrieb Jan Piotrowski > : > > > > By renaming the label, you als

Re: [Cordova dev] info needed label

2019-07-23 Thread Jan Piotrowski
Chris, it has been over a week. What is the state of undoing the label and documentation changes? -J Am Mi., 17. Juli 2019 um 20:08 Uhr schrieb Jan Piotrowski : > > By renaming the label, you also renamed it for all existing issues. > Now many labels that were just questions of users (

Re: [ANNOUNCEMENT] Plugin Releases

2019-07-22 Thread Jan Piotrowski
We had to roll back a misinformed change in cordova-plugin-wkwebview-engine, so we have another bugfix release: - cordova-plugin-wkwebview-engine@1.2.1 Am Do., 11. Juli 2019 um 18:02 Uhr schrieb Jan Piotrowski : > > And finally the rest of the plugins: > > - cordova-plugi

Re: [VOTE] cordova-plugin-wkwebview-engine Bugfix Release

2019-07-22 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Jesse MacFadyen * Bryan Ellis * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am Mo., 22. Juli 2019 um 19:51 Uhr schrieb Jesse : > > +1 > > - coho verfify-archive > - check

[VOTE] cordova-plugin-wkwebview-engine Bugfix Release

2019-07-20 Thread Jan Piotrowski
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-wkwebview-engine-1.2.1/ The packages were published from t

[DISCUSS] cordova-plugin-wkwebview-engine Bugfix Release

2019-07-17 Thread Jan Piotrowski
Does anyone have any reason to delay a cordova-plugin-wkwebview-engine release? There is an ugly bug via one of the PRs that was merged that needs to be undone: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/105 https://github.com/apache/cordova-plugin-wkwebview-engine/pull/45 Re

Re: [Cordova dev] info needed label

2019-07-17 Thread Jan Piotrowski
By renaming the label, you also renamed it for all existing issues. Now many labels that were just questions of users (both open and closed) indicate that info is needed - which might be true or not. Please undo all renaming of labels, both to `info-needed` and `query`. Please undo the changes to

Re: [Cordova dev] info needed label

2019-07-16 Thread Jan Piotrowski
Yeah, that was wrong. - "question" classifies an issue into a category: bug, feature, enhancement, support, discussion, question - "info-needed" is just a tag similar to "invalid" or "has-pr" Please stop rolling this out to other repositories. Please revert the change to the "Default labels" list

Re: [Cordova dev] info needed label

2019-07-15 Thread Jan Piotrowski
The nice thing about missing process is that one can do whatever one wants ;) +1 Bonus points if you add it to https://github.com/apache/cordova-contribute/blob/master/github-labels.md#custom-labels and give it a nice vibrant color. Am Mo., 15. Juli 2019 um 23:18 Uhr schrieb Darryl Pogue : > > +

Re: [ANNOUNCEMENT] Plugin Releases

2019-07-11 Thread Jan Piotrowski
to those and there are no massive problems, I will link to it here. Am Di., 2. Juli 2019 um 20:24 Uhr schrieb Jan Piotrowski : > > We have just released an update to many of our plugins: > > - cordova-plugin-battery-status@2.0.3 > - cordova-plugin-device@2.0.3 > - cordova-pl

Re: [VOTE] (More) Plugins (patch) releases

2019-07-11 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Brian Ellis * Tim Brust * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am Do., 11. Juli 2019 um 08:54 Uhr schrieb Bryan Ellis : > > +1 > > * Confirmed the sigs & hashes w

Re: [VOTE] Plugins (minor) releases

2019-07-11 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Jesse MacFadyen * Tim Brust * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am Mo., 8. Juli 2019 um 09:15 Uhr schrieb Jesse : > > +1 > > - CI is green > - reviewed changes

[DISCUSS] Cordova Windows Release 7.1.0

2019-07-04 Thread Jan Piotrowski
Does anyone have any reason to delay a cordova-windows platform release? Any outstanding patches to land? If not, I will start the release soon. (CI is currently red, so this will require some investigation.) - To unsubscribe, e

[ANNOUNCEMENT] Plugin Releases

2019-07-02 Thread Jan Piotrowski
We have just released an update to many of our plugins: - cordova-plugin-battery-status@2.0.3 - cordova-plugin-device@2.0.3 - cordova-plugin-dialogs@2.0.2 - cordova-plugin-media-capture@3.0.3 - cordova-plugin-network-information@2.0.2 - cordova-plugin-screen-orientation@3.0.2 - cordova-plugin-spla

Re: [VOTE] Plugins (patch) releases

2019-07-02 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Tim Brust * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am Do., 27. Juni 2019 um 16:09 Uhr schrieb Tim Brust : > > I vote +1 *for each plugin*: > * CI is green fo

Re: [VOTE] cordova-plugin-device Release 2.0.3

2019-07-02 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Tim Brust * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am Do., 27. Juni 2019 um 15:42 Uhr schrieb Tim Brust : > > I vote +1: > * CI is green for release tag > *

Re: [VOTE] cordova-plugin-splashscreen Release 5.0.3

2019-07-02 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Tim Brust * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am Do., 27. Juni 2019 um 15:47 Uhr schrieb Tim Brust : > > I vote +1: > * CI is green for release tag > *

Re: [VOTE] cordova-plugin-vibration Release 3.1.1

2019-07-02 Thread Jan Piotrowski
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Tim Brust * Jan Piotrowski Negative Binding Votes: 0 The vote has passed. Thanks everyone! Am So., 23. Juni 2019 um 10:28 Uhr schrieb Bryan Ellis : > > +1 > > * Confirmed sigs & hashes w

Re: [VOTE] Plugins (minor) releases

2019-06-28 Thread Jan Piotrowski
Small correction: The package on dist/dev for inappbrowser was published from this corresponding git tag: cordova-plugin-inappbrowser: 3.1.0 (1cb4be15b8) -J Am Fr., 28. Juni 2019 um 14:50 Uhr schrieb Jan Piotrowski : > > Please review and vote on the release of these plugins release

Re: [VOTE] Cordova-Electron 1.1.0 Release

2019-06-28 Thread Jan Piotrowski
+1 - CI is green - Changes make sense - I could successfully build an app with it Am Fr., 28. Juni 2019 um 15:25 Uhr schrieb Tim Brust : > > I vote +1: > * CI is green for release tag > * coho verify-archive ✅ > * coho check-license ✅ > * npm audit ✅ > * npm test ✅ > > On Fri, Jun 28, 2019 at 6:1

[VOTE] (More) Plugins (patch) releases

2019-06-28 Thread Jan Piotrowski
Please review and vote on the release of these plugins releases by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-file-6.0.2/ https://dist.apache.org/repos/dist/dev/cordov

[VOTE] Plugins (minor) releases

2019-06-28 Thread Jan Piotrowski
Please review and vote on the release of these plugins releases by replying to this email (and keep discussion on the DISCUSS thread) Two of these minor updates are comparably big, see their release notes: https://github.com/apache/cordova-plugin-camera/blob/master/RELEASENOTES.md#410-jun-27-2019

Re: [VOTE] cordova-plugin-device Release 2.0.3

2019-06-19 Thread Jan Piotrowski
Note that the dist/dev link shows the correct link, but links to a wrong URL. This is the correct one: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-device-2.0.3/ -J Am Sa., 15. Juni 2019 um 00:40 Uhr schrieb Jan Piotrowski : > > Please review and vote on the release o

[VOTE] Plugins (patch) releases

2019-06-19 Thread Jan Piotrowski
Please review and vote on the release of these plugins releases by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-dialogs-2.0.2/ https://dist.apache.org/repos/dist/dev/cor

[VOTE] cordova-plugin-device Release 2.0.3

2019-06-14 Thread Jan Piotrowski
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-device-2.0.3/

Re: [VOTE] cordova-common@3.2.0 tools release

2019-06-12 Thread Jan Piotrowski
+1 Changes since 3.1.0 look good. (Waiting for CI to turn green on release commit though.) Am Mi., 12. Juni 2019 um 10:59 Uhr schrieb Chris Brody < chris.br...@gmail.com>: > Please review and vote on this cordova-common@3.2.0 tools release by > replying to this email (and keep discussion on the

Release Process: patch vs. minor bump on release

2019-05-26 Thread Jan Piotrowski
Hi all, in the last few days I spent quite a lot of time trying to write an abstracted release process documentation for all our different components (as a base for some automation). During that, I discovered that we actually have 2 very different release processes. It boils down to these two var

Re: Plugins and Node.js versions

2019-05-17 Thread Jan Piotrowski
t; On Thu, May 16, 2019 at 2:16 PM Jan Piotrowski wrote: > > > None of the plugins have a `hooks` directory or anything else that > > looks similar. > > > > Is anyone aware of any script in the plugin repositories that is > > executed on the developer side? > >

Re: Plugins and Node.js versions

2019-05-16 Thread Jan Piotrowski
Mai 2019 um 10:03 Uhr schrieb Jan Piotrowski < > piotrow...@gmail.com>: > > > Currently our plugin CI uses the same version of Node.js as Tooling > > and Platforms, until recently 4.2 and now 6. > > > > But if I am not mistaken, our plugins do not contain any script

[DISCUSS] coho: Change the default folder it works on

2019-05-16 Thread Jan Piotrowski
While rewriting the plugin release documentation, I stumbled over the way coho chooses the directory where it does its changes. As this is probably just because of historical reasons, I suggest we change the way it works: https://github.com/apache/cordova-coho/issues/238 Is there any reason to ke

[VOTE] cordova-plugin-vibration Release 3.1.1

2019-05-16 Thread Jan Piotrowski
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-vibration%2381/ The packages were published from their cor

Re: [DISCUSS] Remove all documentation translations

2019-05-16 Thread Jan Piotrowski
I would say "No" to 1) and 3) - we can get rid of the code and deactivate that account. 2) and 4) definitely need their own mailing list thread with their own reasoning. -J Am Do., 16. Mai 2019 um 07:19 Uhr schrieb Dmitry Blotsky : > > Ok, if that’s reality, then it’s reality. Then, if we’re on

Plugins and Node.js versions

2019-05-11 Thread Jan Piotrowski
Currently our plugin CI uses the same version of Node.js as Tooling and Platforms, until recently 4.2 and now 6. But if I am not mistaken, our plugins do not contain any scripts that are executed on the developer machine, only JavaScript files that are run inside the app or native code. So it does

Re: Plugin CI: Updates to OS/versions

2019-05-10 Thread Jan Piotrowski
ve to investigate and fix - or remove the CI builds where appropriate (e.g. testing on browsers where the Browser platform is not even supported). I am still quite happy with the success rate, 9 success vs. 6 fail is better than I expected. Best, Jan Am Mi., 24. Apr. 2019 um 17:27 Uhr schrieb Jan P

Re: [DISCUSS] non-global Cordova installs

2019-05-10 Thread Jan Piotrowski
While that is correct, nvm-windows indeed had problems with npx not working after it was first added to node - so Julio's was indeed true in the past. Luckily it was fixed, so even we lowly Windows users now can use npx. Am Fr., 10. Mai 2019 um 09:48 Uhr schrieb Oliver Salzburg : > > npx ships wit

Re: [DISCUSS] non-global Cordova installs

2019-05-10 Thread Jan Piotrowski
Afaik nvm-windows also supports npx for quite some time [1], with 1.1.7 it works for every new-ish node I installed. [1] https://github.com/coreybutler/nvm-windows/commit/ce756027a816042ed41c3ee60b18d0ebc2599c2b Am Fr., 10. Mai 2019 um 02:09 Uhr schrieb julio cesar sanchez : > > npx is included

Re: [DISCUSS] Plugin Releases

2019-05-09 Thread Jan Piotrowski
lugins at the same time again, so this is not a solution. Ideas? Best, Jan Am Mi., 8. Mai 2019 um 20:11 Uhr schrieb Jan Piotrowski : > > This is now being tracked in https://github.com/apache/cordova/issues/104 > > Am Mo., 6. Mai 2019 um 12:19 Uhr schrieb Jan Piotrowski > : &

[VOTE] cordova-plugin-splashscreen Release 5.0.3

2019-05-09 Thread Jan Piotrowski
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/splash20190509/ The packages were published from their corresponding git

Re: [DISCUSS] Plugin Releases

2019-05-08 Thread Jan Piotrowski
This is now being tracked in https://github.com/apache/cordova/issues/104 Am Mo., 6. Mai 2019 um 12:19 Uhr schrieb Jan Piotrowski : > > Does anyone have any reasons to delay Cordova Plugins releases? > If not, I will start the releases tomorrow. > > > Cordova Paramedic is s

[DISCUSS] Plugin Releases

2019-05-06 Thread Jan Piotrowski
Does anyone have any reasons to delay Cordova Plugins releases? If not, I will start the releases tomorrow. Cordova Paramedic is soon [1] in a state where we can start rolling out its CI configuration to our plugin repositories. This will enable us to evaluate the state of a plugin repository aga

What is in a platform?

2019-05-02 Thread Jan Piotrowski
Imagine I want to create a new Cordova platform. What documentation should I read? Which repositories can help me? I see https://github.com/apache/cordova-test-platform exists, but is this complete and current? What functionality should I implement first? Is there a way to "fake" a platform until

Re: Native (C#, C++) UI plugins for Cordova Windows?

2019-05-02 Thread Jan Piotrowski
Which is all nice and interesting but absolutely unrelated to this thread's topic and my initial question. Please stop moving threads offtopic and create your own mailing list thread if you want to talk about something. Thanks. Am Do., 2. Mai 2019 um 00:31 Uhr schrieb Chris Brody : > > Is it poss

Re: Native (C#, C++) UI plugins for Cordova Windows?

2019-05-01 Thread Jan Piotrowski
ing from the cordova.js and the bridge would have to change, and > every plugin would need to be rewritten. > > Cheers, > Jesse > > @purplecabbage > risingj.com > > > On Wed, May 1, 2019 at 1:03 PM Jan Piotrowski wrote: > > > For Cordova iOS and Cordova And

Native (C#, C++) UI plugins for Cordova Windows?

2019-05-01 Thread Jan Piotrowski
For Cordova iOS and Cordova Android it is possible to create plugins that create native UI on top of your app - you just include the libraries in your plugin and execute their API. Example for Android InAppBrowser: https://github.com/apache/cordova-plugin-inappbrowser/blob/a162bd90764e7b3c6a5f8b2f

Re: Plugin CI: Updates to OS/versions

2019-04-24 Thread Jan Piotrowski
. Apr. 2019 um 14:08 Uhr schrieb Jan Piotrowski : > > Hi, > > in the last few days I have been working on fixing and updating the CI > configuration of our plugins, so they actually work with Cordova CLI 9 > and are tested on all relevant OS versions via SauceLabs. > > You mi

Re: [VOTE] cordova-ios 5.0.1 release

2019-04-22 Thread Jan Piotrowski
+1 * CI is green * Diff makes sense * release branch looks right Am Fr., 19. Apr. 2019 um 02:53 Uhr schrieb Bryan Ellis : > > +1 > > * Verified archive signatures & hashes with `coho verify-archive` > * Verified tags SHA with `coho verify-tags` > * Re-created npm package to validate matching rele

Plugin CI: Updates to OS/versions

2019-04-15 Thread Jan Piotrowski
Hi, in the last few days I have been working on fixing and updating the CI configuration of our plugins, so they actually work with Cordova CLI 9 and are tested on all relevant OS versions via SauceLabs. You might know that our plugin tests are run via cordova-paramedic, which means that the CI c

Re: [DISCUSS] Cordova Doc Release

2019-03-18 Thread Jan Piotrowski
es, as Jan said, we only need to merge and it will be released. > > On Mon, Mar 18, 2019 at 6:22 PM Jan Piotrowski wrote: > > > As Julio noticed, there is no release process for docs - what is > > merged is deployed. > > > > But yes, Cordova Android is missing

Re: [DISCUSS] Cordova Doc Release

2019-03-18 Thread Jan Piotrowski
As Julio noticed, there is no release process for docs - what is merged is deployed. But yes, Cordova Android is missing the new API levels and probably some documentation on the new features. -J Am Mo., 18. März 2019 um 09:43 Uhr schrieb julio cesar sanchez : > > I don’t think the docs follow

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Jan Piotrowski
The PR is marked as Work in Progress. If you want it to get reviewed and merged you should remove that. Am Fr., 15. März 2019 um 13:18 Uhr schrieb Oliver Salzburg : > > I really think we should get #680[1] merged before the release. > > It should be good in a moment. > > [1]: https://github.com/ap

Re: [VOTE] Cordova-Windows 7.0.0 Release

2019-03-05 Thread Jan Piotrowski
+1 - CI is green - changes make sense Am Di., 5. März 2019 um 10:33 Uhr schrieb Jesse : > > +1 > > - Ran coho verify-archive > - CI was green > > > @purplecabbage > risingj.com > > > On Mon, Mar 4, 2019 at 11:54 PM Bryan Ellis wrote: > > > Please review and vote on this Windows Release v7.0.0 >

Re: [VOTE] Cordova-Electron 1.0.1 Patch Release

2019-03-05 Thread Jan Piotrowski
+1 * CI is green * changes make sense Am Di., 5. März 2019 um 07:14 Uhr schrieb Ken Naito : > > +1 > > * coho verify-archive OK > * coho verify-tags OK (except for confirming signature owner) > * The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI tests. > > > Note that I added >

Re: [VOTE] Cordova-Android 8.0.0 Release

2019-02-14 Thread Jan Piotrowski
+1 RELEASENOTES.md is missing the 7.1.x releases because they weren't merged back from the release branch, but that does not block the release and can just be fixed on master now. - installed the platform with current CLI and added a few plugins - build and ran an app on an Nexus 5 - CI is green,

Re: [DISCUSS] Cordova-Android Release

2019-02-08 Thread Jan Piotrowski
. 2019 um 12:30 Uhr schrieb julio cesar sanchez : > > Unless we find a way of enabling/disabling Android X support, it's going to > be a breaking change for all plugins using using the old way, so we can't > do that in a 8.1 release > > El vie., 8 feb. 2019 a las 12:03,

Re: [DISCUSS] Cordova-Android Release

2019-02-08 Thread Jan Piotrowski
ties file supposed to be managed by the user > > > > > somehow? > > > > > > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody > > > > > () > > > > > escribió: > > > > > > > > > > > I a

Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread Jan Piotrowski
Is this a new bug introduced by the new code that would be released? If not, there is no reason to stop a release of that (good) code. As soon as a fix for this bug is available, we can release it as a follow up release (patch, minor, major - whatever appropriate). -J Am Fr., 18. Jan. 2019 um 13:

Re: Contribution Newbie

2019-01-10 Thread Jan Piotrowski
Hey Martina, what areas are you most interested in? Code or documentation? What is your experience with JS software, besides writing Cordova apps? If you are looking for a way to contribute with comparatively little setup: We have a big backlog of Pull Requests for core plugins. Those usually nee

Re: Latest cordova-android version not in maven repository

2018-12-17 Thread Jan Piotrowski
Any reason you skipped this documented release step? https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#android-only-uploading-to-bintray > Also can someone explain the use case for publishing on Maven? Cordova Android is made available via Bintray/Maven so it ca

Re: [New Feature] Change WebSettings of the WebView by config file

2018-12-12 Thread Jan Piotrowski
not. > > I think we should agree before any issue is created. > > > El lun., 10 dic. 2018 a las 17:54, Chris Brody () > > escribió: > > > And you can find Cordova email archive in: > > https://lists.apache.org/list.html?dev@cordova.apache.org > > On Mon, Dec

Re: [New Feature] Change WebSettings of the WebView by config file

2018-12-10 Thread Jan Piotrowski
gt; I think this should be possible with preference tags in the config.xml, we > > should be able to read them and set those values to true or false, being > > the default the current one so it's not a breaking change. > > > El jue., 6 dic. 2018 a las 16:45, Jan Piotrowsk

Mass PR creation support

2018-12-07 Thread Jan Piotrowski
Hi. For several open tasks (e.g. updating `package.json` across many repos, distributing the GitHub Issue and PR templates, updating the plugin CI configuration) we will have to change files in many repositories and then create a PR (which means the changes have to be applied in a new branch or ev

Re: Nomination for a new chair for Apache Cordova

2018-12-07 Thread Jan Piotrowski
+1 Thanks to you both! Am Fr., 7. Dez. 2018 um 10:05 Uhr schrieb julio cesar sanchez : > > +1 > > And thanks to you for all this years and to him for taking over > > El El vie, 7 dic 2018 a las 8:02, Toplak Daniel > escribió: > > > Hello Shazron, > > > > thank you for your hard work the last few

Re: [New Feature] Change WebSettings of the WebView by config file

2018-12-06 Thread Jan Piotrowski
> I read through the other threads. [...] Please reply to questions from other threads in these threads instead of interlinking two discussions that are about related, but different things. Thanks. -J Am Do., 6. Dez. 2018 um 16:16 Uhr schrieb Chris Brody : > > > After a few questions about ch

Re: [New Feature] Change WebSettings of the WebView by config file

2018-12-06 Thread Jan Piotrowski
What other use cases besides `setAllowFileAccess` do you see here? -J Am Do., 6. Dez. 2018 um 14:36 Uhr schrieb MALEYRIE Stephane (AIM Services) : > > Hello, > > After a few questions about changing an attribute of the WebSettings of the > WebView (setAllowFileAccess) here : > https://lists.apa

Re: [dev] Cordova-Android Gradle improvements?

2018-12-04 Thread Jan Piotrowski
Aside: By definition WIP (Work in Progress) pull requests should not be reviewed. If someone ignores that, I think it is fair to dismiss all the reviews without further comment. -J Am Di., 4. Dez. 2018 um 19:16 Uhr schrieb Chris Brody : > > By "user-defined Gradle files" I meant what someone can p

Re: [PRs] "Deprecation and Archiving Policy"

2018-12-04 Thread Jan Piotrowski
um 17:51 Uhr schrieb Jan Piotrowski : > > I just finished revising my PRs regarding the deprecation and > archiving of repositories. Finishing this is needed to actually be > able to go ahead and vote on the archival of the first repositories. > > 1. First one is a general "De

Re: How to disable in Android Webview, the WebSettings attributes "AllowFileAccess" in cordova-android ?

2018-12-04 Thread Jan Piotrowski
Hi Stéphane, there is a newer version of cordova-android available: 7.x.x - currently 7.1.4. That means that we, the volunteer development team, won't do any more updates to the 6.x branch. So even if we implement any new features here, they will only get released for 7.x. Any particular reason wh

[PR] "Create a Minimal Reproduction Repository or Sample"

2018-11-30 Thread Jan Piotrowski
Another PR that I polished a bit and is ready for feedback and reviews: "Create a Minimal Reproduction Repository or Sample" PR: https://github.com/apache/cordova-contribute/pull/6 Preview: https://github.com/apache/cordova-contribute/blob/0a582edd0857353ff8790cbe5e6560bbcb72e7a7/create-reproduct

[PRs] "Deprecation and Archiving Policy"

2018-11-30 Thread Jan Piotrowski
I just finished revising my PRs regarding the deprecation and archiving of repositories. Finishing this is needed to actually be able to go ahead and vote on the archival of the first repositories. 1. First one is a general "Deprecation and Archiving Policy" that would be available on our website

Re: [dev] Cordova config.xml vs package.json?

2018-11-29 Thread Jan Piotrowski
It is important to note here to the casual observer, that of course not _all_ configuration will be moved to package.json - only the stuff that fits there better. Darryl explained that above, this is mainly about moving the "dependency" definitions right now - the rest will stay unchanged. -J Am D

Re: What is the status of plugreg?

2018-11-27 Thread Jan Piotrowski
Even more context: https://cordova.apache.org/announcements/2015/04/21/plugins-release-and-move-to-npm.html Am Di., 27. Nov. 2018 um 23:21 Uhr schrieb Jan Piotrowski : > > You probably refer to the "Cordova Plugin Registry": > > * https://cordova.apache.org/news/2013/10/21

Re: What is the status of plugreg?

2018-11-27 Thread Jan Piotrowski
You probably refer to the "Cordova Plugin Registry": * https://cordova.apache.org/news/2013/10/21/cordova-registry.html ✞ https://cordova.apache.org/news/2015/09/08/cpr-readonly.html -J Am Di., 27. Nov. 2018 um 23:17 Uhr schrieb Darryl Pogue : > > plugreg was a 3rd party website displaying stats

Re: cordova-mobile-spec / Mobile Spec

2018-11-26 Thread Jan Piotrowski
n then merge them. Thanks. -J Am Sa., 24. Nov. 2018 um 12:29 Uhr schrieb Jan Piotrowski : > > After spending some time with it, I think I have a rough idea: > > `Mobile Spec` has 3 parts: > > 1. The main folder is a Cordova app "template" (`config.xml` and > `www

Re: cordova-mobile-spec / Mobile Spec

2018-11-24 Thread Jan Piotrowski
t I learned and will create several PRs that I will announce here when done. -J Am Fr., 23. Nov. 2018 um 19:37 Uhr schrieb Jan Piotrowski : > > Some historical context: > https://phonegap.com/blog/2009/11/04/mobile-spec-is-here/ > (original at > http://web.archive.org/web/20120428

Re: [DISCUSS] cordova-android@7.1.4 accelerated hotfix release coming

2018-11-24 Thread Jan Piotrowski
in https://github.com/apache/cordova/issues/54 > > On Fri, Nov 23, 2018 at 6:33 AM Jan Piotrowski > > wrote: > > > > > > Great, please also update mobilespec documentation on how to use this > > > - that really needs some refreshing. > > > Am Fr.,

Re: cordova-mobile-spec / Mobile Spec

2018-11-23 Thread Jan Piotrowski
://www.feedhenry.com/extending-cordova-mobile-spec-tester-app-cloud/ Am Fr., 23. Nov. 2018 um 19:20 Uhr schrieb Jan Piotrowski : > > Hey Cordova veterans, > > We are currently looking into improving the platform testing, release > and voting process (to avoid issues like the broken plugi

cordova-mobile-spec / Mobile Spec

2018-11-23 Thread Jan Piotrowski
Hey Cordova veterans, We are currently looking into improving the platform testing, release and voting process (to avoid issues like the broken plugins in cordova-android 7.1.3) in https://github.com/apache/cordova/issues/54 There we stumbled over mobile-spec as another form of testing the app. P

Re: [VOTE] cordova-android@7.1.4 accelerated hotfix release

2018-11-23 Thread Jan Piotrowski
+1 for both * Created and started hello world app * Confirmed hello world app also starts with `cordova-plugin-inappbrowser` and `cordova-plugin-local-notification` installed * Windows/AppVeyor CI is red for the tagged commit (because of AppVeyor infrastructure things, see https://github.com/apach

Re: [DISCUSS] cordova-android@7.1.4 accelerated hotfix release coming

2018-11-23 Thread Jan Piotrowski
ce. I was able to get > most of the "automatic" mobilespec tests to succeed, but selecting 1 > plugin at a time to run the tests on. I will go ahead with the patch > release now. > On Thu, Nov 22, 2018 at 5:37 PM Jan Piotrowski wrote: > > > > I created https://github.c

Re: [DISCUSS] cordova-android@7.1.4 accelerated hotfix release coming

2018-11-22 Thread Jan Piotrowski
> El El jue, 22 nov 2018 a las 23:12, Jan Piotrowski > escribió: > > > No reason to slow down the release process - anyone can do that for > > themselves and -1 the release vote if it shows a problem. > > Am Do., 22. Nov. 2018 um 20:55 Uhr schrieb Chris Brody < > >

Re: [DISCUSS] cordova-android@7.1.4 accelerated hotfix release coming

2018-11-22 Thread Jan Piotrowski
No reason to slow down the release process - anyone can do that for themselves and -1 the release vote if it shows a problem. Am Do., 22. Nov. 2018 um 20:55 Uhr schrieb Chris Brody : > > I can look into that tomorrow. It would definitely delay the release, > unless someone else wants to pick this u

Re: cordova-android@7.1.3 patch release?

2018-11-15 Thread Jan Piotrowski
#555 links to PRs and issues randomly - I have no idea what is going on there. Please update the PR description to link to the Pull Requests whose changes are included in this PR (and optionally the issue those are solving). -J Am Do., 15. Nov. 2018 um 14:00 Uhr schrieb Chris Brody : > > Changes a

Re: Facing issue in testing release process of Cordova platforms

2018-11-01 Thread Jan Piotrowski
me breaking changes in platform but just curious to resolve this issue as > we may encounter this error anytime in future. > > Let me know your thoughts. > > On Wed, Oct 31, 2018 at 11:07 PM Jan Piotrowski > wrote: > > > Gandhi, what exactly did you do until now? Do you

Re: Facing issue in testing release process of Cordova platforms

2018-10-31 Thread Jan Piotrowski
Gandhi, what exactly did you do until now? Do you have a checkout of all the Cordova repos created with coho? Please reply with the exact command you are running and error/output you are getting. J Am Sa., 27. Okt. 2018 um 11:02 Uhr schrieb gandhi rajan : > > Hi Raphinesse, Thanks for the Jasmine

Re: plugins release?

2018-10-31 Thread Jan Piotrowski
Julio, I would be happy to pair with you on some plugin releases. As you already noticed, the release processes via coho need some serious work now that we are on GitHub issues instead of JIRA, so we have some additional work ahead of us. First step would be to identify which plugin to start with

Re: [VOTE] cordova-lib@8.1.1 tools patch release

2018-10-03 Thread Jan Piotrowski
I vote +1: - Ran `coho verify-tags -g` with the tag string from above - Confirmed sigs & hashes with `coho verify-archive` - Checked that the changes in the 8.1.x branch should do what the "release issue" and changelog says - Checked out 8.1.x branch and successfully ran `npm t` (and observed 1 fa

83 Plugin Pull Requests are ready for review!

2018-10-03 Thread Jan Piotrowski
Hi interested people. I spent the last few days unblocking pull requests for our plugin repositories. This meant fixing our test configuration, fixing some specific problems of our test infrastructure and in general making sure that PRs with failing tests were fixed and rerun. The result: 83 pull

  1   2   3   >