Re: Review Request 15461: config_parser - handle duplicates with children and text when merging

2013-11-12 Thread Jeffrey Heifetz
- Jeffrey Heifetz On Nov. 12, 2013, 8:22 p.m., Bryan Higgins wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15461

Re: Releases! Plugins + Tooling

2013-10-24 Thread Jeffrey Heifetz
I¹d like to update all the BlackBerry plugins with dependencies to point to the registry now that our plugins are there before this release. On 10/24/2013, 2:26 PM, Steven Gill stevengil...@gmail.com wrote: I am planning on doing some releases today Plugins:

Re: Releases! Plugins + Tooling

2013-10-24 Thread Jeffrey Heifetz
, 2013 at 2:47 PM, Jeffrey Heifetz jheif...@blackberry.comwrote: I¹d like to update all the BlackBerry plugins with dependencies to point to the registry now that our plugins are there before this release. On 10/24/2013, 2:26 PM, Steven Gill stevengil...@gmail.com wrote: I am planning

Re: Cordova Issue Workflow

2013-10-22 Thread Jeffrey Heifetz
I thought that if an issue is assigned it means nothing but if it's marked as in progress then someone is working on it.‎ There are still components with default assignees I thought. Sent from my BlackBerry 10 smartphone on the Rogers network. Original Message From: Andrew Grieve Sent:

Re: Platforms Meet-up @ Waterloo

2013-10-21 Thread Jeffrey Heifetz
I'm not sure if I'll make it for the hacking, but I'm going to try and make it for the social event. On 13-10-21 4:12 PM, Andrew Grieve agri...@chromium.org wrote: Please tell me if this list is wrong: Attending: Joe, Shaz, Anis, Bryan Higgins, Gorkem, Carlos I'll start a private thread with

Re: reviewboard .reviewboardrc and TRACKING_BRANCH = 'origin/dev' ?

2013-10-16 Thread Jeffrey Heifetz
You can use the review board by uploading a diff so you don't technically need the reviewboard.rc. Sent from my BlackBerry 10 smartphone. Original Message From: Carlos Santana Sent: Wednesday, October 16, 2013 2:41 AM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org Subject: Re:

Re: Review Request 14621: Fix plugin JS installation during cordova prepare

2013-10-15 Thread Jeffrey Heifetz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14621/#review27033 --- Ship it! Ship It! - Jeffrey Heifetz On Oct. 12, 2013, 2:45 a.m

Re: Review Request 14621: Fix plugin JS installation during cordova prepare

2013-10-11 Thread Jeffrey Heifetz
the weekend. - Jeffrey Heifetz On Oct. 12, 2013, 2:45 a.m., Ian Clelland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14621

Re: Review Request 14376: Update cli prepare to make platform config.xml a build artifact

2013-10-02 Thread Jeffrey Heifetz
91697e9 src/metadata/wp8_parser.js 8dc121b src/prepare.js b6928b9 Diff: https://reviews.apache.org/r/14376/diff/ Testing --- Tested and Working for BlackBerry use cases Thanks, Jeffrey Heifetz

Re: Review Request 14446: [CB-4749]: Display proper error if cordova prepare run not in project dir.

2013-10-02 Thread Jeffrey Heifetz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14446/#review26616 --- Ship it! Ship It! - Jeffrey Heifetz On Oct. 2, 2013, 5:54 p.m

Re: PSA: watch for stipped [CB-####] from patch subject line when using git am

2013-10-02 Thread Jeffrey Heifetz
Is that the reason that commit that was just pushed had the wrong issue # ? On 13-10-02 2:35 PM, Michal Mocny mmo...@google.com wrote: As I just discovered, git has a bug where it will strip the leading [CB-] when using git am to apply a patch made with git format-patch. Details here: [1].

Re: Tagging 3.1.0 today?

2013-10-01 Thread Jeffrey Heifetz
Since I believe Lorin is away, I have tagged the release for blackberry. On 13-10-01 1:01 PM, Marcel Kinard cmarc...@gmail.com wrote: If any platform owners don't have time to do this today, let me know how I can help. On Oct 1, 2013, at 11:11 AM, Andrew Grieve agri...@chromium.org wrote: I

Re: Plugman Release

2013-10-01 Thread Jeffrey Heifetz
It seems as though there is no cordova-cli 3.1.x branch, does this mean we always release off of master? There is a bug I found where element tree needs to be bumped to the same version as plugman to support namespace xml elements and I'd like to know where to push this. Thanks, Jeff On

Re: Tagging 3.1.0 today?

2013-10-01 Thread Jeffrey Heifetz
David Kemp's buoldbot found a bug in cli from the plugman bump. I have a fix upcoming Sent from my BlackBerry 10 smartphone on the Rogers network. From: Andrew Grieve Sent: Tuesday, October 1, 2013 5:47 PM To: dev Reply To: dev@cordova.apache.org Subject: Re: Tagging 3.1.0 today? On Tue, Oct

Re: Tagging 3.1.0 today?

2013-09-30 Thread Jeffrey Heifetz
BlackBerry10 needs a commit into CordovaJS for 3.1 as well. (Does this mean all platforms must be updated?) On 13-09-30 1:38 PM, Shazron shaz...@gmail.com wrote: iOS has a bug fix that is not in RC1 (but in the 3.1.x branch) related to the Keyboard preferences in iOS 7 (visual bug). This is why

Re: 3.1 Release

2013-09-19 Thread Jeffrey Heifetz
I can take the responsibility of tagging BlackBerry. Could you send me the wiki with instructions ? From: Andrew Grieve agri...@chromium.orgmailto:agri...@chromium.org Date: Thursday, 19 September, 2013 10:40 AM To: dev dev@cordova.apache.orgmailto:dev@cordova.apache.org, Jeffrey Heifetz jheif

Re: config.xml as a build artifact for less suffering and easier upgrades

2013-09-16 Thread Jeffrey Heifetz
board ? On 13-09-12 2:13 PM, Michal Mocny mmo...@chromium.org wrote: Thats awesome, looking forward to it! On Thu, Sep 12, 2013 at 10:22 AM, Jeffrey Heifetz jheif...@blackberry.comwrote: Yup I'm on the same page with you Michal, and I believe Braden as well. I'm sorry I should have said so

Re: config.xml as a build artifact for less suffering and easier upgrades

2013-09-12 Thread Jeffrey Heifetz
suggest that the last word; the file whose changes are added last, is the app config.xml. This allows the user the power to override any default or setting from a plugin. Braden On Wed, Sep 11, 2013 at 2:16 PM, Jeffrey Heifetz jheif...@blackberry.com wrote: I'd like to clarify the changes

Re: config.xml as a build artifact for less suffering and easier upgrades

2013-09-11 Thread Jeffrey Heifetz
will of course implement it the way Braden proposed it though. On 13-09-10 1:58 PM, Jeffrey Heifetz jheif...@blackberry.com wrote: Issue Created - https://issues.apache.org/jira/browse/CB-4774 On 13-09-10 9:30 AM, Tommy-Carlos Williams to...@devgeeks.org wrote: Then colour me excited! +1

Re: config.xml as a build artifact for less suffering and easier upgrades

2013-09-10 Thread Jeffrey Heifetz
Issue Created - https://issues.apache.org/jira/browse/CB-4774 On 13-09-10 9:30 AM, Tommy-Carlos Williams to...@devgeeks.org wrote: Then colour me excited! +1 On 10/09/2013, at 11:27 PM, Andrew Grieve agri...@chromium.org wrote: On Mon, Sep 9, 2013 at 7:37 PM, Tommy-Carlos Williams

Re: Non-Git Plugin Dependencies

2013-09-09 Thread Jeffrey Heifetz
. If you want a git relative path then url = . and for file-system relative url != . and does not have :// Does this seem correct to everyone? Does anyone have any strong opinions one way or the other? On 13-09-04 4:18 PM, Jeffrey Heifetz jheif...@blackberry.com wrote: While I believe we could

Re: Non-Git Plugin Dependencies

2013-09-04 Thread Jeffrey Heifetz
. Conceptually, I'm not sure why the syntax for (2) shouldn't do what you request when the url for the original plugin was a local path? Maybe just a bug? -Michal On Tue, Sep 3, 2013 at 9:38 PM, Jeffrey Heifetz jheif...@blackberry.comwrote: We were working

Non-Git Plugin Dependencies

2013-09-03 Thread Jeffrey Heifetz
We were working on a redistribution of Cordova that included some plugins and ran into a use-case not covered by the current plugin spec.[1] Currently there are two ways to specify a dependency 1. Using a combination of url, commit and subdir which plugman will use to clone down a repo and

Re: PROPOSAL: node.js all the script things

2013-08-26 Thread Jeffrey Heifetz
We've been doing all our scripts in node and have yet to find a better route than .bat scripts that call in. So I'm interested if anyone knows of one. Sent from my BlackBerry 10 smartphone on the Rogers network. From: Benn Mapes Sent: Monday, August 26, 2013 5:53 PM To: dev@cordova.apache.org

Re: Dependency wildcards

2013-07-31 Thread Jeffrey Heifetz
I would think '*' is an invalid subdir On 13-07-31 3:26 AM, Filip Maj f...@adobe.com wrote: Im pretty sure that can be removed entirely or set to .. On 7/30/13 6:49 PM, Jesse purplecabb...@gmail.com wrote: What is the point of the wildcard in the dependency tag of plugin.xml ? I have an issue

Re: WP8 'Plugin interface' and 'Splash screen' support

2013-07-31 Thread Jeffrey Heifetz
BlackBerry10 supports both Media and SplashScreen but not Globalization On 13-07-31 9:52 AM, Michael Sierra msie...@adobe.com wrote: I can see another couple of problems that need to be fixed. Please take a moment to review this table for any platform you're particularly familiar with. Thanks,

Plugman Integration Tests

2013-07-24 Thread Jeffrey Heifetz
I recently added some end to end testing into the plugman tests run via npm test and on some machines these can take a while to run (Fil is saying 10s timeouts are being hit). While I know mocking these things can speed up the tests, I personally feel like they are more valuable as integration

Re: blackberry10 build

2013-07-20 Thread Jeffrey Heifetz
You haw no signing key provided so it's skipping debug token generation. You need to either add a key store pass value to your %home%/.cordova/blackberry10.json or use the platform level cordova/run script with -k and your key store pass. Sent from my BlackBerry 10 smartphone on the Rogers

Is a config.xml without an author valid?

2013-07-16 Thread Jeffrey Heifetz
When the config.xml for mobile-spec was re-written recently the author element was removed and I'm just wondering if this is valid. In the BlackBerry implementation we've always required one and I'm wondering if this behaviour is wrong, or if I should add one to mobile-spec. Thanks, Jeff

Re: CLI's master2

2013-07-09 Thread Jeffrey Heifetz
of it On Tue, Jul 9, 2013 at 4:26 PM, Jeffrey Heifetz jheif...@blackberry.comwrote: Sent from my BlackBerry 10 smartphone on the Rogers network. From: Michal Mocny Sent: Thursday, July 4, 2013 1:19 PM To: dev Reply To: dev@cordova.apache.org Subject: Re: CLI's master2 If master

Re: Jake woes

2013-06-21 Thread Jeffrey Heifetz
+1 Sent from my BlackBerry 10 smartphone on the Rogers network. From: Bryan Higgins Sent: Friday, June 21, 2013 9:39 AM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org Subject: Re: Jake woes +1 On Fri, Jun 21, 2013 at 7:11 AM, Lucas Holmquist lholm...@redhat.comwrote: +1 On Jun

Re: Opinions Needed: Platform specific features and mobilespec tests

2013-06-20 Thread Jeffrey Heifetz
+1 On 13-06-20 9:06 AM, Andrew Grieve agri...@chromium.org wrote: Definitely torn on this one. On one hand, if there are features implemented on some platforms that should be implemented on others than having them fail is a constant reminder that your platform needs to implement the missing

Re: Cordova.js now at 2.9.0rc1 for real

2013-06-19 Thread Jeffrey Heifetz
I've been seeing similar issues with Jake since I've upgraded my node and it is definitely related to Jake failing with dependencies. I have yet to find the real root cause. On 13-06-18 8:27 PM, Andrew Grieve agri...@chromium.org wrote: As both Jesse and Shaz pointed out, I ran coho to update

Re: Whitelist and Wildcards

2013-06-18 Thread Jeffrey Heifetz
On BlackBerry10 we use the subdomains attribute and this seems compliant with the spec [1] 1. http://www.w3.org/TR/widgets-access/#attributes On 13-06-17 7:20 PM, Shazron shaz...@gmail.com wrote: iOS doesn't use the subdomains attribute, relying on the wildcard in the origin attribute only.

Re: 2.9.0rc1 this coming monday??

2013-06-17 Thread Jeffrey Heifetz
Yep, all BB10 work is being tracked in JIRA. Check out CB-3797, CB-3799 On 13-06-17 1:26 PM, Filip Maj f...@adobe.com wrote: Good stuff Bryan, is this being tracked on issues anywhere? I'd like to refer other issues (CLI) to this feature you're speaking of. On 6/17/13 10:18 AM, Bryan Higgins

Re: Cordova vs Company workflow

2013-06-05 Thread Jeffrey Heifetz
I also think there's value in having some time between posting a diff/commit/pull request to the issue and committing to master to allow some discussion. On 13-06-05 2:25 PM, Lorin Beer lorin.beer@gmail.com wrote: Yes, putting a comment on the issue itself should be sufficient. If you're

Re: Baby Grieve

2013-05-31 Thread Jeffrey Heifetz
Congratulations, all the best to you and your family. From: Andrew Grieve agri...@chromium.orgmailto:agri...@chromium.org Reply-To: dev@cordova.apache.orgmailto:dev@cordova.apache.org dev@cordova.apache.orgmailto:dev@cordova.apache.org Date: Friday, 31 May, 2013 10:00 AM To: dev

Re: Cordova CLI merge, new branch, INFRA ticket

2013-05-29 Thread Jeffrey Heifetz
I'd go with tangled history over forced re-clone. On 13-05-29 11:00 AM, Braden Shepherdson bra...@chromium.org wrote: I'll keep this thread up to date with INFRA's responses. I asked INFRA about options and their implications. These are the four options I described, after I was informed that

Re: Cordova BlackBerry project structure

2013-05-14 Thread Jeffrey Heifetz
If bin is top level, it requires a non-standard first parameter to distinguish sub-platform. I know this is the same as the old way, but it's very unique to the BlackBerry implementation. Perhaps if this just routed to sub platform bin scripts it would be ideal. Sent from my BlackBerry 10

Re: plugman/cli and blackberry

2013-05-10 Thread Jeffrey Heifetz
There will be a pull request coming, its just running through testing atm https://github.com/blackberry/cordova-plugman/pull/2. I expect to re-target this to apache in the coming hours. On 13-05-10 1:52 PM, Filip Maj f...@adobe.com wrote: Only issue I see is that source-file support was removed

Re: blackberry 10 migration

2013-05-06 Thread Jeffrey Heifetz
What about plugman and cli? Sent from my BlackBerry 10 smartphone on the Rogers network. From: Lorin Beer Sent: Monday, May 6, 2013 7:04 PM To: dev Reply To: dev@cordova.apache.org Subject: Re: blackberry 10 migration ok, we'll pull the code from Blackberry/Blackberry-Cordova and

Re: plug man and lib-file tags

2013-05-03 Thread Jeffrey Heifetz
add a `target` attribute to it to satisfy BB's needs. On 5/3/13 12:07 PM, Jeffrey Heifetz jheif...@blackberry.com wrote: While implementing the BlackBerry10 platform updates in plugman I've noticed that the lib-file tags have been removed. I wanted to know if this was a conscious decision and if so

Re: plug man and lib-file tags

2013-05-03 Thread Jeffrey Heifetz
. Perhaps an `architecture` or `arch` attribute? Would the SOs have to be placed in a specific location (and can/would that location need to be customized based on the library?). On 5/3/13 12:19 PM, Jeffrey Heifetz jheif...@blackberry.com wrote: If you feel framework is a better choice I'm fine

Re: Naming: cordova-2.8.0.js -- cordova.js

2013-05-01 Thread Jeffrey Heifetz
Tl;dr I'd like to propose a different but similar solution based on the evolution of WebWorks. That we automatically inject cordova.js into a specific place in the app (say the root since thats where cordova_plugins is) and then the developer simply adds a script tag to the correct location

Re: plugman + plugin spec final q's

2013-04-17 Thread Jeffrey Heifetz
Coming back to Braden's suggestion of specifying a url and id for plugin dependency, I think this is the correct route, and would go further to suggest the url is optional. I do not believe we should inherently tie plugin dependency to the exact source. Thats why we have a discovery system and

Re: plugman + plugin spec final q's

2013-04-17 Thread Jeffrey Heifetz
, Jeffrey Heifetz jheif...@blackberry.com wrote: Coming back to Braden's suggestion of specifying a url and id for plugin dependency, I think this is the correct route, and would go further to suggest the url is optional. I do not believe we should inherently tie plugin dependency to the exact source

Re: plugman + plugin spec final q's

2013-04-17 Thread Jeffrey Heifetz
, mapping to native strings representing specific features/permissions. `system` attribute is optional and false by default. Only used by BlackBerry for certain system-level permissions. I think this satisfies our use cases. Thoughts/comments welcome. On 4/17/13 11:07 AM, Jeffrey Heifetz jheif

Re: Migrating plugin to feature

2013-04-17 Thread Jeffrey Heifetz
+1 On 13-04-17 4:14 PM, Joe Bowser bows...@gmail.com wrote: +1 for deprecate now, remove 3.0 On Wed, Apr 17, 2013 at 12:15 PM, Shazron shaz...@gmail.com wrote: +1 for deprecate now, remove 3.0 On Wed, Apr 17, 2013 at 10:00 AM, Filip Maj f...@adobe.com wrote: My vote is to set up

Re: BlackBerry BB10 Repos on GitHub

2013-04-15 Thread Jeffrey Heifetz
, which I would encourage you to chime in on. On Mon, Apr 15, 2013 at 9:09 AM, Jeffrey Heifetz jheif...@blackberry.comwrote: So now that the code has been out for a bit we'd like to start talking about getting the code into the 2.7 release. There are no longer any hacks or hoops

Re: docs.cordova.io == 404

2013-04-03 Thread Jeffrey Heifetz
Same here. Maybe it's type coercion Sent from my BlackBerry 10 smartphone. From: Filip Maj Sent: Wednesday, April 3, 2013 11:38 PM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org Subject: Re: docs.cordova.io == 404 Works for me? On 4/3/13 11:35 PM, Andrew Grieve

Re: [cordova-cli] - check_req's should move into the platforms.

2013-03-22 Thread Jeffrey Heifetz
+1 On 13-03-22 1:32 PM, Anis KADRI anis.ka...@gmail.com wrote: +1 On Fri, Mar 22, 2013 at 10:29 AM, Brian LeRoux b...@brian.io wrote: Propose we add ./bin/check_requirements to each platforms in 2.7 timeframe so as to remove that logic from the cordova-cli tool.

Re: Platform-level command line scripts ;)

2013-03-22 Thread Jeffrey Heifetz
I like this solution to platform scripts, the only addition I would add is that if the platform allows multiple targets, perhaps it could be possible to set a default one that would be used instead of the timeout to first one (although I suppose that makes first entry inherent default). Sent

Re: [Plugins] Changes to plugman

2013-03-20 Thread Jeffrey Heifetz
+11 I really like the plan On 13-03-20 10:23 AM, Andrew Grieve agri...@chromium.org wrote: Read through FUTURE.md. Like it! Sounds amazing! Great work guys! On Tue, Mar 19, 2013 at 5:02 PM, Filip Maj f...@adobe.com wrote: For those unaware, cordova-plugman [1] is a tool under active

Re: Platform-level command line scripts

2013-03-20 Thread Jeffrey Heifetz
While we're discussing the platform level scripts, should we also attempt to standardize the arguments that can be passed in as well? On 13-03-20 6:19 AM, Brian LeRoux b...@brian.io wrote: Fil: yes I like the easy wins you describe. Anis: agree on harder wins. The `emulate` cmd should require a

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Jeffrey Heifetz
Actually I'm lucky enough to be heading down to join in on the fun, looking forward to meeting all of you. On 2013-02-27, at 6:26 PM, Al Harding wrote: Awesome! We've got a room booked at Adobe SF with projector, camera, beer, so we can loop anyone in who is remote. Look forward to meeting

Re: Proposition to split cordova-blackberry into two separate plugins

2013-02-22 Thread Jeffrey Heifetz
. Can you be more precise and explain exactly what you envision this new repo to contain, and specifically why it can't come as a pull request to the existing repo/codebase? On Tue, Feb 19, 2013 at 5:47 PM, Jeffrey Heifetz jheif...@rim.com wrote: Sharzon, sorry I have no clue when BB10

Proposition to split cordova-blackberry into two separate plugins

2013-02-19 Thread Jeffrey Heifetz
With all this talk of re-organizing cordova plugins we here at BlackBerry (RIM no more) have been discussing better alleging ourselves with the approach by splitting our existing cordova-blackberry platform into two separate platforms. (I saw a similar call here as well

Re: Free ApacheCon (Committer) Ticket

2013-02-18 Thread Jeffrey Heifetz
Any responses? Also does it include the sprints as well? Sent from my BlackBerry 10 smartphone. From: Brent Lintner Sent: Friday, February 15, 2013 12:43 PM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org Subject: Free ApacheCon (Committer) Ticket Hey all, I have (discounted)