Re: [Discuss] Cordova-common release

2015-09-25 Thread Mark Koudritsky
Separate modules are tempting, but I think they'll make the release process much harder. On Fri, Sep 25, 2015 at 11:40 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > I tend to agree w/ Carlos here, but from practical side it might be very > hard to maintain and release such a

Re: Experimenting with API for cordova tooling

2015-04-24 Thread Mark Koudritsky
, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Should we move this docs to cordova-discuss instead -https://github.com/cordova/cordova-discuss ? On 4/24/15, 4:02 PM, Mark Koudritsky kam...@google.com wrote: I'm back from ApacheCon and vacation. Very glad to see some enthusiasm about

Experimenting with API for cordova tooling

2015-04-10 Thread Mark Koudritsky
From today's hangout discussion, here are the links to our experiments with using cordova tooling via API rather than CLI. It is loosely based on my older experiments here https://github.com/kamrik/CordovaGulpTemplate But his time there is a separate wrapper that exposes a more object oriented

Re: [DISCUSS] Cordova TOOLS release - 4.3.1

2015-04-07 Thread Mark Koudritsky
+1 for a quick tools release. On Tue, Apr 7, 2015 at 12:34 PM, Steven Gill stevengil...@gmail.com wrote: Yeah, android 4.0 would be minor bump for cli according to our versioning strategy. So it could be 5.1.0. It would be nice to include it in 5 though so it can jump on the visibility 5

Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release (attempt 2)

2015-03-31 Thread Mark Koudritsky
iclell...@chromium.org wrote: On 30 Mar 2015 4:52 pm, Mark Koudritsky kam...@google.com wrote: Another quick option for now: we can pin hello-world version in cordova-lib's package.json to 3.8.0 which doesn't use the whitelist plugin. Later, when we release the tools

Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release (attempt 2)

2015-03-30 Thread Mark Koudritsky
Looks like this breaks on cordova-android 3.7.1 (currently latest released) cordova-app-hello-world requires the whitelist plugin whitelist plugin depends on cordova-android 4.0 via the engine tag engine name=cordova-android version==4.0.0-dev / The resulting error message is Plugin doesn't

Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release (attempt 2)

2015-03-30 Thread Mark Koudritsky
by publishing either app-hello-world or plugin-whitelist until we release a version of tools that is pinned to the new hello-world. On Mon, Mar 30, 2015 at 3:40 PM, Mark Koudritsky kam...@google.com wrote: Looks like this breaks on cordova-android 3.7.1 (currently latest released

Re: [DISCUSS] Cordova App Hello World Release 3.9.0

2015-03-23 Thread Mark Koudritsky
+1 The code that uses NPM version of cordova-app-hello-world in cordova-lib is currently on a branch https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json. Should we merge it now to start using the npm version of hello world? On Mon, Mar 23, 2015 at 3:20

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)

2015-03-13 Thread Mark Koudritsky
+1 Built and ran on - Android 5.0.2 on Nexus 7 - iOS simulator On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)

2015-03-13 Thread Mark Koudritsky
+1 Built and ran the app on iOS simulator and Android on Nexus 7. On Fri, Mar 13, 2015 at 10:41 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I vote +1 * Verified that app can be built and ran (android, windows, wp8) Thx! Sergey -Original Message- From: Steven Gill

Consolidating platform specific code from different places in cordova-lib

2015-03-10 Thread Mark Koudritsky
I've created a pull request with changes across cordova-lib that should make it much easier to consolidate the platform specific code in cordova-lib to reduce duplication and maybe eventually move this code to the platforms repos. https://github.com/apache/cordova-lib/pull/183 Feedback is

Re: CLI installation from master

2015-02-27 Thread Mark Koudritsky
Yes, the instructions look correct. If you dan't need to use the `plugman` command, you don't need cordova-plugman. On Fri, Feb 27, 2015 at 12:21 AM, Toda, Shingo shin...@fast.au.fujitsu.com wrote: Hi devs I read through this document to know how I can install CLI from cloned cordova-cli.

Re: Cordova/PhoneGap Local Install

2015-01-21 Thread Mark Koudritsky
The best known example of how to use local installs of command line tools is probably Grunt, a globally installed binary will always look for and invoke a local installation. I'm also experimenting with a Gulp based workflow for Cordova which uses local installs of cordova-lib and

Re: Usage of jscs JSHint in Cordova

2015-01-21 Thread Mark Koudritsky
I added he jscs file in cordova-lib some time ago but didn't enforce it in npm test because that required more work in the code to get rid of the remaining style errors. Would be glad if someone invests the effort to make the code comply with the current (or modified) rules. Similar story for the

Re: Usage of jscs JSHint in Cordova

2015-01-21 Thread Mark Koudritsky
to the filesystem root until it finds a config file (unless you set configurations differently). Given that it's incredibly hard to get consensus on different IDE preferences, I would shy away from any IDE specific benefits/problems. +1 -Original Message- From: Mark Koudritsky [mailto:kam

Re: MobileSpec for testing cordova-lib@rc

2015-01-09 Thread Mark Koudritsky
, Mark Koudritsky kam...@google.com wrote: +1 for publishing plugins to npm We will need to come up with a good naming convention so that translating from plugin id to npm package name would be trivial. Preferably with some stable prefix (like cordova_plugin_) so

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Mark Koudritsky
from npm instead of cordova plugins registry. Thoughts? On Thu, Jan 8, 2015 at 1:09 PM, Mark Koudritsky kam...@google.com wrote: On Thu, Jan 8, 2015 at 3:47 PM, Michal Mocny mmo...@chromium.org wrote: If we add node_modules to search path, will we be able to adjust which versions

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Mark Koudritsky
On Thu, Jan 8, 2015 at 3:47 PM, Michal Mocny mmo...@chromium.org wrote: If we add node_modules to search path, will we be able to adjust which versions of platforms/plugins it uses just by modifying package.json? Since platforms can be added by path. You can replace platforms = ['android']

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Mark Koudritsky
Josh, thanks for the suggestion. Added it here https://github.com/kamrik/cordova-test-rc/commit/d3a1abeda45357c4cf32b28e6e63cc269d7d3bda as process.env.HOME = path.join(__dirname, 'home'); On Thu, Jan 8, 2015 at 2:19 PM, Josh Soref jso...@blackberry.com wrote: Mark Koudritsky wrote: Trying

Re: [Vote] Tools Release Jan 6, 2015

2015-01-07 Thread Mark Koudritsky
+1 Tests: - npm install -g cordova@rc - Built and ran the default HelloWorld app on Android - ran coho verify-tags On Wed, Jan 7, 2015 at 4:27 PM, Andrew Grieve agri...@chromium.org wrote: +1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho

Re: Cordova-lib failing on master (stopping release)

2015-01-06 Thread Mark Koudritsky
This commit https://github.com/apache/cordova-lib/commit/b2e33f55e98f23116066f47f9b6ea5b49474d95c passed on both AppVeyor https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.333 and Travis https://travis-ci.org/apache/cordova-lib/builds/45818232

Re: minSdkVersion conflict

2014-12-08 Thread Mark Koudritsky
If you you add this line to cordova project config.xml preference name=android-minSdkVersion value=14 / It should set the same value in AndroidManifest.xml during prepare. The code that deals with it is in cordova-lib/src/cordova/metadata/android_parser.js starting at line 259 On Mon, Dec 8,

Re: plugins supported on cordova-browser platform?

2014-12-01 Thread Mark Koudritsky
If you browse all the plugins in the registry http://plugins.cordova.io/#/viewAll and then click on Filter by Platform, you can se those that have a browser tag in their plugin.xml Also this Jira issue has all the plugins that need some work for browser platform as sub-tasks

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
On Thu, Nov 13, 2014 at 10:06 AM, Ray Camden rayca...@adobe.com wrote: Mark, question about this: To update your tools: npm install -g cordova npm install -g plugman To be clear, a Œregular¹ user doesn¹t need to update plugman, right? At present the plugman npm package contains only

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
Thanks for testing everyone, sending out an official results email soon. Josh thanks for the fixes in blog post. I've merged them in. The blog post pull request also contains a change https://github.com/jsoref/cordova-apache-blog-posts/commit/b4e8c325ba2f6f1357dbe1770db735d15bf79986 to the win

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
The vote has now closed. The results are: Positive Binding Votes: 3 - Parashuram Narasimhan - Sergey Grebnov - Mark Koudritsky Negative Binding Votes: 0 The vote has passed. On Thu, Nov 13, 2014 at 3:06 PM, Mark Koudritsky kam...@google.com wrote: Thanks for testing everyone, sending

[ANNOUNCEMENT] Tools Release

2014-11-13 Thread Mark Koudritsky
New cordova tools released: cordova@4.1.2 (the Cordova CLI) plugman@0.22.16 cordova-lib@4.1.2 cordova-js@3.7.2 You can view the release blog post at http://cordova.apache.org/news/2014/11/13/tools-release.html

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
Ok, just published it all. Thanks for help and support. Another question, for blog post the instructions look as follows: cd cordova-website rake build svn st svn add blah.blah.blah svn commit -m $JIRA Published blog post for tools release. The `svn st` shows a bunch of stuff I had no intention

Re: [VOTE] Tools Release, take 3

2014-11-12 Thread Mark Koudritsky
Please also review the updated blog post: https://github.com/cordova/apache-blog-posts/blob/master/2014-11-10-tools-release.md

[VOTE] Tools Release, take 3

2014-11-12 Thread Mark Koudritsky
Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-7988 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ And to npm under @rc tag To test them out you can use: npm -g uninstall cordova

Re: plugin.xml config-file for json files

2014-11-11 Thread Mark Koudritsky
I was just having similar thoughts about getting info from the plugin to *.gradle files. Another option for JSON would be to bundle a JSON file with the same structure as manifest.webapp and have the FirefoxOS build script merge this file into manifest.webapp as one of the first steps. This will

Re: [Urgent] Windows platform build issue due to expired certificate

2014-11-11 Thread Mark Koudritsky
If this will be windows and wp 3.7.1, I'll update the tools release candidates tomorrow. On Tue, Nov 11, 2014 at 3:48 PM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: As a result of this certificate expiry, Cordova-windows for all users is currently broken. Cordova

Re: [VOTE] Tools Release, take 2

2014-11-11 Thread Mark Koudritsky
with target keys and version flags. • Checked the release notes. Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Monday, November 10, 2014 3:31 PM To: dev@cordova.apache.org Subject: [VOTE] Tools Release, take 2 Please review and vote

Re: Review: Tools Release blog post

2014-11-10 Thread Mark Koudritsky
released so that there's a version that uses the new cordova-lib? It seems odd that it's in the announcement, but missing from the releasenotes. On Fri Nov 07 2014 at 5:22:51 PM Mark Koudritsky kam...@google.com wrote: Please review and send PRs! https://github.com/kamrik/apache-blog-posts

Re: Review: Tools Release blog post

2014-11-10 Thread Mark Koudritsky
-3.7.0.html On Nov 7, 2014, at 5:22 PM, Mark Koudritsky kam...@google.com wrote: Please review and send PRs! https://github.com/kamrik/apache-blog-posts/blob/master/2014-11-10-tools-release.md

Re: [VOTE] Tools Release

2014-11-10 Thread Mark Koudritsky
;, version: 3.7.0, subdirectory: windows }, What's your opinion, is it critical for release? Thanks, Maria -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Saturday, November 8, 2014 01:17 To: dev@cordova.apache.org

Re: [VOTE] Tools Release

2014-11-10 Thread Mark Koudritsky
not to the latest email last time. https://github.com/apache/cordova-lib/pull/118/ Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Monday, November 10, 2014 9:14 AM To: dev@cordova.apache.org Subject: Re: [VOTE] Tools Release Yep, the hash

[VOTE] Tools Release, take 2

2014-11-10 Thread Mark Koudritsky
Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-7988 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ And to npm under @rc tag To test them out you can use: npm -g uninstall cordova

Re: [VOTE] Tools Release

2014-11-10 Thread Mark Koudritsky
, it should be fairly quick as long as we are using release branches (which we are doing according to release doc). On Mon, Nov 10, 2014 at 2:16 PM, Mark Koudritsky kam...@google.com wrote: This vote is cancelled. Blocking issue https://issues.apache.org/jira/browse/CB-8000 Will post a new vote

Re: [ANNOUNCE] Cordova-iOS, Cordova-Windows, Cordova-wp8 3.7.0 released

2014-11-07 Thread Mark Koudritsky
Awesome! Starting a tools release. On Thu, Nov 6, 2014 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote: http://cordova.apache.org/announcements/2014/11/06/cordova-wp-windows-3.7.0.html http://cordova.apache.org/announcements/2014/11/06/cordova-ios-3.7.0.html Lets get that tools release

Re: [DISCUSS] Tools Release

2014-11-07 Thread Mark Koudritsky
The platforms are out, starting the tools release process.​

Re: [DISCUSS] Tools Release

2014-11-07 Thread Mark Koudritsky
Yup, started the process thinking it will be 4.0.1, changing to 4.1.0 and restarting. For the release process in general, it looks like it would be useful to decide on the intended version names very early in the process and send out the intended version names as part of the DISCUSS email, so

[VOTE] Tools Release

2014-11-07 Thread Mark Koudritsky
Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-7988 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ And to npm under @rc tag To test them out you can use: npm -g uninstall cordova

Review: Tools Release blog post

2014-11-07 Thread Mark Koudritsky
Please review and send PRs! https://github.com/kamrik/apache-blog-posts/blob/master/2014-11-10-tools-release.md

Re: [DISCUSS] Tools Release

2014-11-07 Thread Mark Koudritsky
PM, Mark Koudritsky kam...@google.com wrote: For the release process in general, it looks like it would be useful to decide on the intended version names very early in the process and send out the intended version names as part of the DISCUSS email, so that this can also

Re: Questions re: plugin variables

2014-11-05 Thread Mark Koudritsky
Variables should to be provided when adding the plugin E.g: cordova plugin add org.some.plugin --variable API_KEY=some_value Example of a plugin that uses variables: http://plugins.cordova.io/#/package/com.phonegap.plugins.facebookconnect Relevant places in the code in cordova-lib: Where

Re: [DISCUSS] Tools Release

2014-10-31 Thread Mark Koudritsky
PM, Shazron shaz...@gmail.com wrote: That patch I talked about was merged in. cordova-ios is out for vote. On Thu, Oct 30, 2014 at 8:06 AM, Mark Koudritsky kam...@google.com wrote: On Wed, Oct 29, 2014 at 6:40 PM, Shazron shaz...@gmail.com wrote: Mark, this patch is important

Re: [DISCUSS] Tools Release

2014-10-30 Thread Mark Koudritsky
On Wed, Oct 29, 2014 at 6:40 PM, Shazron shaz...@gmail.com wrote: Mark, this patch is important for us to get pulled in: https://github.com/apache/cordova-lib/pull/116 The patch looks good to me. I haven't branched yet, just merge it in if everything else is ok with it. On Wed, Oct 29,

[DISCUSS] Tools Release

2014-10-29 Thread Mark Koudritsky
I would like to start a tools release. Any outstanding patches to land? Thoughts? - Mark

Re: Node Hook?

2014-09-22 Thread Mark Koudritsky
Looks like cordova couldn't find where node is on your system. On Windows cordova is doing some hackish magic to deal with shebang lines. The code for this magic is in extractSheBangInterpreter https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/hooker.js#L87. Not sure, but

Re: [Vote] Tools Release 3.6.3-0.2.13

2014-09-19 Thread Mark Koudritsky
I vote +1​ - Verified signatures and hashes - installed rc via npm - created, built and ran an android project on OS X

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Mark Koudritsky
I suggest that: - The shrinkwrap exist in git at all times, not just during the release process. -1 for that. Having shrinkwrap at all times will result in postponed discovery of incompatibilities with newer versions (which are usually trickier than shrinkwrap problems) until you nuke

Re: [DISCUSS] continuous build and release process

2014-09-18 Thread Mark Koudritsky
+1 for release branches, reverting version bumps feels really awkward +1 for more continuous integration. And just to make sure more people are aware of it, there is this buildbot running some CI http://108.170.217.131:8010/waterfall A half baked idea for a more automated release process: Talking

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Mark Koudritsky
Mark, I want to understand better your statement resulted in a great deal of confusion for contributors. Can you give more details about that. One simple case I had myself was when debugging a suspected problem with one of dependencies and wasting several hours to only discover that the

Re: Time to Update the Who's Who!

2014-08-28 Thread Mark Koudritsky
Can't edit the wiki as well, could you please add me. The username is kamrik. Thanks. On Thu, Aug 28, 2014 at 9:59 AM, Carlos Santana csantan...@gmail.com wrote: Piotr I added Mozilla and you two under it. Let me know your username on the Wiki and I can add you as contributor to do edits.

Re: continuous integration woze

2014-08-22 Thread Mark Koudritsky
wrote: I agree. My personal philosophy is generally to treat warnings as errors. On Aug 21, 2014, at 9:27 AM, Mark Koudritsky kam...@google.com wrote: If some tests are too strict or too flaky, we can and should fix or remove them altogether. I don't believe

Re: continuous integration woze

2014-08-21 Thread Mark Koudritsky
If some tests are too strict or too flaky, we can and should fix or remove them altogether. I don't believe there is any value in warnings, they will accumulate and then people will largely ignore them. There are also tests running or real devices here: http://ci.cordova.io/

Re: continuous integration woze

2014-08-20 Thread Mark Koudritsky
AFAIK Travis only supplies a binary pass/fail status, so there is no such thing as a warning. A Travis check for pull request doesn't mark the entire build on master as failed, only that pull request. So there is no need to panic and drop everything and fix the build, instead just fix the build by

Re: [Discuss] 3.6.0 Release

2014-08-19 Thread Mark Koudritsky
npm info cordova-blackberry10--- 404 npm info cordova-blackberry--- OK cli is looking for blackberry10 as npm name but it's blckberry. I think the altplatform: 'blackberry' in platforms.js can solve this.

Re: Hangout link?

2014-08-19 Thread Mark Koudritsky
It was a rare case where we finished on time :) (at about 17:10 EDT) On Tue, Aug 19, 2014 at 5:50 PM, Archana Naik naik.arch...@gmail.com wrote: Is hangout still going on? Can someone post the link? Thanks Archana

Re: Cordova Plugin Registry iOS frameworks

2014-08-18 Thread Mark Koudritsky
Plugins are published using npm publish. As far as I understood, npm does not include symlinks by design [1] when packing a package. So I'm not sure about how we could start including symlinks while still using npm packages as distribution method. [1] https://github.com/npm/npm/issues/3310 On

Re: cordova plugin save

2014-08-18 Thread Mark Koudritsky
In order to keep the plugins as project deps in package.json we need to sort out some details of treating plugins as npm packages first: 1) Plugins don't currently have package.json files, and list their deps in plugin.xml. 2) Are we ok with loosing the possibility of specifying platform specific

Re: Cordova workflows based on build systems / task runners

2014-08-18 Thread Mark Koudritsky
talk!? ;) -Michal On Wed, Aug 13, 2014 at 6:18 PM, Mark Koudritsky kam...@google.com wrote: Hi all, Inspired by several recent conversations on this mailing list I've been thinking about a Cordova workflow based on some build system

Re: platform switches for Windows Universal Apps

2014-08-15 Thread Mark Koudritsky
, 2014, at 6:20 AM, Mark Koudritsky kam...@google.com wrote: My 2 cents: - I prefer phone over handset as I don't like those overly dry formal names that got heavily overloaded with years but still give a false sense of better specificity. - --store is a very counter intuitive

Re: [Vote] Tools Release for Android 3.5.1

2014-08-12 Thread Mark Koudritsky
+1 - Installed from archives https://dist.apache.org/repos/dist/dev/cordova/CB-7267/ - Built a test app on OSX and ran it on Android (Nexus 7 with KitKat). On Tue, Aug 12, 2014 at 12:31 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: +1 * Verified archives * Performed

Re: platform switches for Windows Universal Apps

2014-08-08 Thread Mark Koudritsky
My 2 cents: - I prefer phone over handset as I don't like those overly dry formal names that got heavily overloaded with years but still give a false sense of better specificity. - --store is a very counter intuitive name for desktop apps for someone not exposed to the new Windows

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Mark Koudritsky
discuss what styles we want to use beforehand, I am open to it. On Thu, Jul 31, 2014 at 7:34 PM, Mark Koudritsky kam...@google.com wrote: Just opened a pull request with an experimental JSCS config. Would be glad to get some feedback about this. My goal is to eventually run JSCS together

Re: missing documentation and missing major version bump

2014-07-31 Thread Mark Koudritsky
Thanks for updating the help, Josh. On Thu, Jul 31, 2014 at 11:16 AM, Josh Soref jso...@blackberry.com wrote: This is now done. I only documented run initially because I didn't really want to think through the code (prepare is an interesting odd case) and I knew it applied to run. On

Experimenting with JSCS + JSHint in cordova-lib

2014-07-31 Thread Mark Koudritsky
Just opened a pull request with an experimental JSCS config. Would be glad to get some feedback about this. My goal is to eventually run JSCS together with JSHint as part of `npm test`. This is a relatively liberal config that doesn't generate too many warnings with the existing code.

Re: missing documentation and missing major version bump

2014-07-30 Thread Mark Koudritsky
On Wed, Jul 30, 2014 at 1:46 AM, Carlos Santana csantan...@gmail.com wrote: Yep Michal I agree to update cli to pass down extra parameters to platform scripts like it used. this allow for greater flexibility in platform scripts and no hardcoded platform concerns in cli. No need to remove nopt

Re: missing documentation and missing major version bump

2014-07-30 Thread Mark Koudritsky
the parsing of arguments using - or -- or for now if extraplatformargs contain position args they will get what they expect. On Wed, Jul 30, 2014 at 10:24 AM, Mark Koudritsky kam...@google.com wrote: On Wed, Jul 30, 2014 at 1:46 AM, Carlos Santana csantan...@gmail.com wrote: Yep Michal I

Re: missing documentation and missing major version bump

2014-07-30 Thread Mark Koudritsky
So that's how it works today on the release version with a magic --space all the stuff to pass down at the end of the cordova cli command? Yes, since this commit https://github.com/apache/cordova-cli/commit/b5b4a14a2f8bdf43fcf098884ea70af109d596a2 (included in the currently released version)

Re: missing documentation and missing major version bump

2014-07-30 Thread Mark Koudritsky
I'll add to the docs for other commands. prepare actually does receive those extra args but it doesn't call any platform scripts, so there is nobody to pass them along to. create doesn't call any platform scripts as well, the subsequent platform add does, but allowing extra args to cordova

Re: missing documentation and missing major version bump

2014-07-30 Thread Mark Koudritsky
On Wed, Jul 30, 2014 at 12:50 PM, Carlos Santana csantan...@gmail.com wrote: For the prepare I was thinking hooks. Does all hooks receive all the command line arguments including the extra ones? Yes, it receives the entire command line string, like this execOpts.env.CORDOVA_CMDLINE =

Re: missing documentation and missing major version bump

2014-07-30 Thread Mark Koudritsky
I think the concern was more of using current default name HelloCordova.pbxproj this will always be the name of the project, unless you really, really know what you are doing and want to change it you can specify in cli, shell script, or in config.xml name project=changetothisappname/name

Re: --usegit / --usenpm

2014-07-25 Thread Mark Koudritsky
The last git message you copied (CB-7002) is the first commit after branching off the last tools release at that time platforms were donwloaded from git by default. The usegit commit came later. The corresponding commit in cordova-lib is 71c380a CB-7100: Use npm based lazy-load by default looks

Re: Proposal: remove platform versions from platfroms.js

2014-07-23 Thread Mark Koudritsky
Currently WebWorks ships specific versions of things. If we had shipped unpinned versions of stuff, then eventually we would have created projects which our UI wouldn't have recognized as valid (because, they e.g. Didn't have a .cordova, or a hooks, or a merges or whichever things we had

Re: Proposal: remove platform versions from platfroms.js

2014-07-23 Thread Mark Koudritsky
Part of the discussion is release flexibility vs predictability. My main problem is that currently we have neither. By default CLI downloads pinned versions of platforms but latest versions of plugins. Changing the concept of corodva project to something managed by npm is an interesting idea but

Proposal: remove platform versions from platfroms.js

2014-07-22 Thread Mark Koudritsky
Currently a release of our cli tools always downloads the same version of platform files which is hard-coded incordova/platforms.js https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/platforms.js. This makes it impossible to release new versions of platforms that would be

Re: Add build status to github

2014-07-21 Thread Mark Koudritsky
: Mark Koudritsky [mailto:kam...@google.com] Sent: Friday, July 18, 2014 11:13 PM To: dev@cordova.apache.org Subject: Re: Add build status to github I didn't. I guess we also need to provide the INFRA people with some short instructions on how to enable this on the AppVeyor site. On Fri, Jul

Re: Add build status to github

2014-07-21 Thread Mark Koudritsky
Travis builds are up and running here https://travis-ci.org/apache/cordova-lib/builds For AppVeyor there is some problem (might be permissions, details in INFRA-8066 https://issues.apache.org/jira/browse/INFRA-8066). Sergey, did you have to check some special check boxes on AppVeyor to make the

Re: Add build status to github

2014-07-21 Thread Mark Koudritsky
It works now! Added AppVeyor badge to README. Thanks to Daniel Gruno from the Apache INFRA team.

Re: Add build status to github

2014-07-18 Thread Mark Koudritsky
The test failure on Travis is in plugman/install spec. It seems to only happen with a fresh checkout, once you run the test second time, it works ok. I was bitten by this before. Maybe something with bad management of temp dirs. I'll investigate. For now just removing that spec file fixes the

Re: Add build status to github

2014-07-18 Thread Mark Koudritsky
? @purplecabbage risingj.com On Fri, Jul 18, 2014 at 11:36 AM, Mark Koudritsky kam...@google.com wrote: The test failure on Travis is in plugman/install spec. It seems to only happen with a fresh checkout, once you run the test second time, it works ok. I was bitten by this before. Maybe something

Re: Add build status to github

2014-07-17 Thread Mark Koudritsky
...@microsoft.com wrote: We would need both right? For covering Windows and Linux platforms for lib to build/run. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Tuesday, July 15, 2014 7:55 AM To: dev@cordova.apache.org Subject: Re: Add build

Re: Add build status to github

2014-07-15 Thread Mark Koudritsky
Ok, let's ask here. Does anybody have any strong preferences for either AppVeyor or TravisCI or both for cordova-lib? note, this is only about running npm test in cordova-lib.

Re: Add build status to github

2014-07-14 Thread Mark Koudritsky
think is that Travic-CI is the most safe option for other platforms/repos since they already proved to be a good solution for many open source companies. Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Friday, July 4, 2014 6:57 AM

Re: Tools release blog post review

2014-07-10 Thread Mark Koudritsky
--browserify --project [PROJECT] --plugin [PLUGIN] --platform [ios|android] cordova-cli support will come in a future release On Wed, Jul 9, 2014 at 9:33 PM, Mark Koudritsky kam...@google.com wrote: Anis, could you please write a bullet/paragraph about browserify? I don't

Re: Tools release blog post review

2014-07-10 Thread Mark Koudritsky
Ok, added Michal's wording with the one line instruction from Anis. Publishing it.​

Re: Tools release blog post review

2014-07-10 Thread Mark Koudritsky
Published. The site diff was way larger than it should've been (mostly white space related diff). Any site building settings I missed? On Thu, Jul 10, 2014 at 5:24 PM, Mark Koudritsky kam...@google.com wrote: Ok, added Michal's wording with the one line instruction from Anis. Publishing it.​

Tools release blog post review

2014-07-09 Thread Mark Koudritsky
Please review the blog post for yesterdays tools release: https://github.com/kamrik/for_review/blob/master/2014-07-09-tools-release.md

Re: Tools release blog post review

2014-07-09 Thread Mark Koudritsky
Even had that in my first draft, but we talked about it briefly and felt like it's not so good to highlight stuff behind an --experimental flag. Which means it might be time for it to graduate from --experimental for the next release. What do others think about it?

Re: Tools release blog post review

2014-07-09 Thread Mark Koudritsky
Added save/restore to notable changes in the post, PTAL. https://github.com/kamrik/for_review/blob/master/2014-07-09-tools-release.md On Wed, Jul 9, 2014 at 7:25 PM, Josh Soref jso...@blackberry.com wrote: ‎I'd like to spend a bit of time playing with it before it graduates. Currently I'm

Re: Tools release blog post review

2014-07-09 Thread Mark Koudritsky
Anis, could you please write a bullet/paragraph about browserify? I don't understand it sufficiently to write about it. - Changed `update` to `install` - Added link to Gorkem's post. Thanks for the comments.

Re: [VOTE] Tools Release

2014-07-08 Thread Mark Koudritsky
This went slowly, but we got 3 votes now, declaring this vote as passed and publishing this release. On Mon, Jul 7, 2014 at 10:32 AM, Michal Mocny mmo...@chromium.org wrote: Well, I took a look at the CI, which is currently red but wasn't recently and covered an overlap of patches here. It

[RESULT] [VOTE] Tools Release

2014-07-08 Thread Mark Koudritsky
The vote has now closed. The results are: Positive Binding Votes: 3 Mark Koudritsky Andrew Grieve Michal Mocny Negative Binding Votes: None Other Votes: None The vote has passed. On Tue, Jul 8, 2014 at 11:26 AM, Mark Koudritsky kam...@google.com wrote: This went slowly, but we got 3 votes

Re: [RESULT] [VOTE] Tools Release

2014-07-08 Thread Mark Koudritsky
Published to dist/ and npm. On Tue, Jul 8, 2014 at 11:28 AM, Mark Koudritsky kam...@google.com wrote: The vote has now closed. The results are: Positive Binding Votes: 3 Mark Koudritsky Andrew Grieve Michal Mocny Negative Binding Votes: None Other Votes: None The vote has passed

Re: [VOTE] Tools Release

2014-07-03 Thread Mark Koudritsky
cordova serve was broken in this version. I'm canceling this vote, cherry-picking the fix https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=86f097f to this release branch of cordova-lib, repackaging it and will open a new vote thread.

[VOTE] Tools Release

2014-07-03 Thread Mark Koudritsky
Please review and vote on this Tools Release. This is from branches with some patches applied: - revert windows universal app support - fix cordova serve Branches are cli: rb_3.5.0-0.2.6, lib: rb_0.21.6 (rb for release branch) Release issue: https://issues.apache.org/jira/browse/CB-7002 Both

Re: npm test jasmine reporter issue

2014-07-03 Thread Mark Koudritsky
For cordova-cli I've temporarily pinned jasmine at an older version https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=2f9228d581ba9469ea10eead194089c3c377b89c until this bug is fixed. cordova-lib seems to use the global version of jasmine, so if you see the error, install the

  1   2   3   >