GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/85
[fxos] update __format__ to match pathsPrefix
Noticed this while implementing new functionality on PG dev app. The
filesystem prefix should match what we have in
[pathsPrefix](https
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/27#issuecomment-58387188
Looks good, r+.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/19#discussion_r1747
--- Diff: src/firefoxos/NetworkProxy.js ---
@@ -34,8 +34,16 @@ module.exports = {
getConnectionInfo: function
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/19
Fix network information type exception on fxos 2
`navigator.connection` got removed from fxos 2, causing the plugin to crash
when loading. Fixed by returning `UNKNOWN
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17386903
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17386918
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17386923
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17391733
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/77#issuecomment-53460632
This looks good, thanks for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-lib/pull/74
Make author url optional
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rodms10/cordova-lib author-node
Alternatively you can review
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/69
Overwrite existing file on getFile when create is true
Realized that this is the expected behavior when playing with the [phonegap
developer
app](https://github.com/phonegap/phonegap
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/5#issuecomment-51946435
This has been fixed in
https://github.com/apache/cordova-firefoxos/commit/20def3b060620e71113d8fa8c6cd671fb6ca2504.
---
If your project is set up for it, you
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/58#issuecomment-51946902
Thanks for the fix! @zalun should take a look. (may take some time, he's on
vacation).
---
If your project is set up for it, you can reply
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/21
[fxos] Remove cordova version
It's unused after [CB-5105](https://issues.apache.org/jira/browse/CB-5105).
You can merge this pull request into a Git repository by running:
$ git
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/20#issuecomment-51228619
License audit passes now r+.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/21
[fxos] Remove hardcoded cordova version
There doesn't seem to be a need to hardcode cordova version. It causes
plugins that require a higher versions to fail to install for firefoxos
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-js/pull/76
[fxos] Remove hardcoded cordova version
There doesn't seem to be a need to hardcode cordova version. It causes
plugins that require a higher versions to fail to install for firefoxos.
You can
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/19
Fixing error on new CLI/LIB: cp: no such file or directory
On latest versions of CLI and LIB a `cp: no such file or directory` error
was being displayed on the console after adding
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/18#discussion_r15496568
--- Diff: bin/templates/project/cordova/clean.bat ---
@@ -0,0 +1,27 @@
+:: Licensed to the Apache Software Foundation (ASF) under one
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/18#issuecomment-50414282
Looks great, thanks again! r+ @zalun, good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/66
Remove unsupported paths from requestAllPaths
As per @zalun's review comment at
https://github.com/apache/cordova-plugin-file/pull/64#discussion_r15390363
You can merge this pull
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/36#issuecomment-50075467
Did you see an adding proxy for FileTransfer as well? Make sure you have
file and file-transfer from my branches. Looks like you have file
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/64#discussion_r15371710
--- Diff: src/firefoxos/FileProxy.js ---
@@ -54,6 +53,32 @@ QUIRKS:
var DIR_SEPARATOR = '/';
var DIR_OPEN_BOUND
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/18#issuecomment-49783283
It would be better to call the node clean script instead of duplicating the
clean code. Our [build.bat
script](https://github.com/apache/cordova-firefoxos/blob
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/36
FirefoxOS initial implementation
Using system XHR for transfers. Requires last version of file plugin. Basic
test app at https://github.com/rodms10/check-file-transfer
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/64
[FxOS] Support for resolve URI, request all paths and local app directory.
Updated file plugin in preparation for file-transfer plugin implementation.
Main change is support
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/18#issuecomment-49261707
Thanks! I'll test tomorrow, need to setup a windows machine.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14948514
--- Diff: plugin.xml ---
@@ -70,6 +70,20 @@
/js-module
/platform
+!-- firefoxos --
+platform
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14954668
--- Diff: www/firefoxos/locales/get_files.sh ---
@@ -0,0 +1,8 @@
+while read line
--- End diff --
This file can
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14955009
--- Diff: doc/index.md ---
@@ -194,6 +197,11 @@ options:
- The `formatLength` option supports only `short` and `full` values
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#issuecomment-49076136
With the race condition fix it loads fine for me, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14900988
--- Diff: plugin.xml ---
@@ -70,6 +70,20 @@
/js-module
/platform
+!-- firefoxos --
+platform
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14901564
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -0,0 +1,214 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14902768
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -0,0 +1,214 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14903106
--- Diff: doc/index.md ---
@@ -194,6 +197,11 @@ options:
- The `formatLength` option supports only `short` and `full` values
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14903135
--- Diff: doc/index.md ---
@@ -194,6 +197,11 @@ options:
- The `formatLength` option supports only `short` and `full` values
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/51#issuecomment-48760923
Looks good. r+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14799288
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -0,0 +1,217 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14799326
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -0,0 +1,217 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14800066
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -0,0 +1,217 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14800265
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -0,0 +1,217 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation
Github user rodms10 closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47561643
Code looks good to me too. @zalun, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133
The pull request looks fine to me. My only suggestion would be to leave a
comment explaining that initialization must happen after cordova.js
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377111
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/49#issuecomment-47590172
Tested it, works fine. Just a minor nit on whitespaces. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/49#issuecomment-47591641
r+! @zalun, good to merge by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/17
Update Readme
New instructions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rodms10/cordova-firefoxos updateReadme
Alternatively
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/17#issuecomment-47286219
This fixes CB-6893.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/15
CB-7016 - zip created by build has unecessary ./ folder on all files
Issue reported on IRC. @zalun, can you take a look?
You can merge this pull request into a Git repository by running
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-47009869
Looks good, thanks for working on this @marti1125! r+ @zalun, can you merge
this?
---
If your project is set up for it, you can reply to this email and have
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/16
cordova.js needs to be copied to platform www
The [new icon PR](https://github.com/apache/cordova-firefoxos/pull/12)
introduced icon files inside the `platform_www` folder. Because
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46071557
Glad it wasn't needed. I'll do some testing and let you know. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/26#issuecomment-45930663
Yeah, the priorities are pretty messy right now. Currently content in
`config.xml` takes precedence on all manifest properties, except two:
`permissions` and `icons
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/13#discussion_r13606326
--- Diff: bin/lib/create.js ---
@@ -63,7 +63,11 @@ exports.createProject =
function(project_path,package_name,project_name){
shjs.cp
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/13#issuecomment-45644096
Nice work @marti1125! Thanks again for working on this. The `cp: no such
file or directory` error comes from
[firefoxos_parser.js](https://github.com/apache
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/13#issuecomment-45661222
Thanks for updating the comment, r+. @zalun, can you please merge? This
fixes CB-5692.
---
If your project is set up for it, you can reply to this email
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/5#issuecomment-45662171
The meeet misspelling is still there, but the line with Creating Firefox
OS project was removed. @rixrix can you rebase this change?
---
If your project is set
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/2#issuecomment-45662595
Changes to `cordova.js` should be made in [cordova-js
repo](https://github.com/apache/cordova-js/blob/master/src/cordova.js)
---
If your project is set up
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-lib/pull/26
CB-6895 Add more config properties into manifest
Added `fullscreen`, `orientation` and `launch_path` to the manifest. Plus
clean up and indentation. @zalun, can you take a look?
You can merge
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45422272
I'm seeing Removing unused template as a change in this PR instead of
coming from apache:master. Did you cherry pick that change? You'd need to do
something
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/12#discussion_r13504727
--- Diff: .gitignore ---
@@ -1 +1,2 @@
.DS_Store
+node_modules/
--- End diff --
Please remove this line. I can't find
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/12#discussion_r13504812
--- Diff: bin/lib/create.js ---
@@ -67,7 +67,7 @@ exports.createProject =
function(project_path,package_name,project_name){
shjs.cp
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45371763
Thanks for working on this! Can you address the review comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/13#issuecomment-45388123
I think you must go through crowdin for translation, [see the
wiki](http://wiki.apache.org/cordova/CordovaTranslations). @ldeluca can
probably
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45392401
Can you pull from master and rebase your branch? I still don't see the
changes from the [clean up
PR](https://github.com/apache/cordova-firefoxos/pull/11
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13399892
--- Diff: doc/index.md ---
@@ -99,6 +100,39 @@ instance, or the system browser.
var ref = window.open('http://apache.org
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400162
--- Diff: src/firefoxos/InAppBrowserProxy.js ---
@@ -47,10 +47,34 @@ var IABExecs = {
open: function (win, lose, args
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400634
--- Diff: doc/index.md ---
@@ -99,6 +100,39 @@ instance, or the system browser.
var ref = window.open('http://apache.org
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/8#issuecomment-45033265
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/15
Adds Firefox OS version
Gets firefox os version based on UA string. Pull request on behalf of
@JasonWeathersby, looks good to me.
You can merge this pull request into a Git
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/46
Adding permission info
Adding auto-permissions config. @zalun, please take a look.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/47
Initial implementation for Firefox OS
Implemented File System API on top of indexedDB, based on [this
shim](https://github.com/ebidel/idb.filesystem.js).
I wrote a jasmine test
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/64#issuecomment-43237152
Reviewed in https://github.com/mozilla-cordova/cordova-mobile-spec/pull/3,
good to go. r+
---
If your project is set up for it, you can reply to this email
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/62#issuecomment-42570763
Looks great, thanks for addressing the nits! r+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/6#issuecomment-43166120
I tested this and it's needed for `build` to work on windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/9
Simplifies build for firefoxos
The build was looking for index.html and manifest.webapp in the merges
folder. Removed this requirement. Also no need for debug vs release, now it
always
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-43013866
Firefox OS did not change, once this is merged I'll file a bug for us to
add the functionality there too.
---
If your project is set up for it, you can
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/8
Remove unused elements from defaults.xml
The values in defaults.xml were unnecessary and were overwriting values in
the platform defaults.xml.
You can merge this pull request into a Git
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-cli/pull/175
Fix cordova help
`cordova help` is throwing as it's looking for the `./help` module in the
`cordova-lib` module path.
You can merge this pull request into a Git repository by running
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/61
Replace innerText with more standard textContent
This fixes manual battery test on Firefox OS. `textContent` is supported by
[IE9+ and all other
browsers](https://developer.mozilla.org
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/17
CB-5416 - Adding support for auto-managing permissions
With [CB-5416](https://github.com/apache/cordova-cli/pull/168) merged into
cordova-cli, we can have plugins automatically
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/9#issuecomment-42079997
This can be closed, merged already: see
44005034004559bb798f402b4ef177f5f70167d8
---
If your project is set up for it, you can reply
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/6#issuecomment-42080099
Fixed in commit 44005034004559bb798f402b4ef177f5f70167d8
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodms10 closed the pull request at:
https://github.com/apache/cordova-cli/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-cli/pull/168#issuecomment-41935687
Merged, commits b4febd7c102fcfcb30774d894bab824de9e0bfd3
b454946c26454e74b047d5352c2d490ae3232d54 and
5835a02e877b0b78a30fd0edc989c4b7d93afdd5.
---
If your
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/11
CB-5611 firefoxos: battery-status plugin
Initial implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mozilla
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/11#issuecomment-41964304
Awesome, thanks @rixrix! I did some testing before creating this Pull
Request, but some extra eyes are always welcome. Thanks for the original code
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/29
Auto-managing permissions
With [CB-5416](https://github.com/apache/cordova-cli/pull/168) merged, we
can have plugins automatically set the permissions in the manifest.
You can
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/56
Fixing firefoxos spec
Added firefoxos platform and fixed cordova-incl.js to work on firefoxos.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-cli/pull/168
[CB-5416] - FirefoxOS - Need to auto generate manifest.webapp with
appropriate plugin permissions
Adds logic to firefoxos_parser to generate manifest permissions based on
config.xml.
You
91 matches
Mail list logo
