Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-12 Thread Michal Mocny
Perfect. Thanks Steve. On Mon, Mar 9, 2015 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote: Release steps: https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md I will have to run through a release to see if I got it all right. Okay, I'm going to

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-09 Thread Steven Gill
Release steps: https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md I will have to run through a release to see if I got it all right. Okay, I'm going to merge the copy-from-app-hello-world branch into master and start a vote thread! Lets hold off on merging

RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-06 Thread Nikhil Khandelwal
Thanks for making the change to make it compatible. I took a brief look at your changes and they look good. Thanks, Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Friday, March 6, 2015 1:12 PM To: Steven Gill Cc: Michal

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-06 Thread Michal Mocny
I wanted to originally, but you can --copy-from a www/ only (no config.xml), and then we need a template. If I change cordova-lib to depend on app-hello-world then we can remove it. Another reason to do so. -Michal On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve agri...@chromium.org wrote:

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-06 Thread Michal Mocny
Updated as described. Now you no longer need to use the branch of cordova-cli, so I'm pretty sure this is 100% compat. Huzzah. On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny mmo...@chromium.org wrote: I wanted to originally, but you can --copy-from a www/ only (no config.xml), and then we

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-06 Thread Steven Gill
Sure. I can make the changes to release process + coho for it. I imagine it won't be released often, so it might be best give app-hello-world its own release process instead of tying it into tools, platforms or plugins release. On Mar 6, 2015 1:04 PM, Michal Mocny mmo...@chromium.org wrote:

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-06 Thread Michal Mocny
Agreed. Everything is upstream on the branch. The package.json wasn't fully thought out, so please peak at it. Ping me if you need anything, I'll rebase cordova-lib and move to master when you are done. Thanks Steve. On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill stevengil...@gmail.com wrote:

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Michal Mocny
Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Michal Mocny
The current breaking change is that you cannot create a new project using cordova-lib directly, without providing a project template to import from. cordova-cli works as it always has, and will provide the app-hello-world as a default if you do not use --copy-from / --link-to. However, writing

RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Nikhil Khandelwal
Michal: I'm new to this area - can you please elaborate why this change could potentially break downstream distributions? IS there an API change? -Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Thursday, March 5, 2015 1:12

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Andrew Grieve
Can we move the config.xml template out of cordova-lib/templates and into app-hello-world as a part of this? On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny mmo...@chromium.org wrote: The current breaking change is that you cannot create a new project using cordova-lib directly, without providing

RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-04 Thread Nikhil Khandelwal
I like moving this to npm because Apache Git as a distribution mechanism for the hello world app has been less reliable than desirable in the past. Thanks, Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Tuesday, March 3,

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-03 Thread Jesse
+1 Does this affect the ability to use an individual platform? ie. cordova-ios/bin/create ... Will platform create scripts need to change? @purplecabbage risingj.com On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny mmo...@google.com wrote: This came up in the context of whitelist discussion,

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-03 Thread Steven Gill
+1. So on board with this. I'll take a look at your Jira issue later on today. On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny mmo...@google.com wrote: This came up in the context of whitelist discussion, but wanted to bring it to everyones attention. JIRA:

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-03 Thread Michal Mocny
Jesse, I think not. The platform scripts just copy the bundled www/ (its already included with the platform). This is only for the top-level project www/ of a cordova-cli project. I guess, though, that we could consider changing the platform create scripts to import config.xml's, since they

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-03 Thread Michal Mocny
Pushed first attempt to remote branches: - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world - https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world Cleaning up cordova-lib is strictly required, though I think we should still take the opportunity to