[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-219530078 @purplecabbage , could you please file a JIRA issue for what you've encountered ? I just did the same for the issues I just mentioned:

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-219521656 @purplecabbage , I can't repro this with git-bash shell on Win10 because I'm running into another issue: https://github.com/nodejs/node/issues/3006 The

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-219496280 I am using windows 10, but I typically use the git-bash shell which may be why we aren't seeing the same things. @purplecabbage

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-219495292 @purplecabbage, I didn't create a JIRA issue to track the telemetry work, I should have. My bad. I've tested this on MAC(El Capitan) and Windows10, but couldn't

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-219493551 @omefire Can you please take a look into this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-219189021 Was there ever a specific Jira issue for adding telemetry? I don't see it. I think we need to revisit some of the output/prompt formatting, here is what I

[GitHub] cordova-cli pull request: Telemetry

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218861698 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63066803 --- Diff: src/telemetry.js --- @@ -0,0 +1,122 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63066442 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63066156 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218834713 Sounds good to me to proceed then, it was a random idea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63065751 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218826259 I first wanted to go that route, but I then realized doing it in CLI minimizes polluting LIB for a functionality that's not intended to be used by downstream

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63056874 --- Diff: src/telemetry.js --- @@ -0,0 +1,122 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63056532 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218808479 Other CLIs that use lib (as a lib) would not want this code. Off by default is interesting, but I think this is cleaner, and it's done. > On May 12,

[GitHub] cordova-cli pull request: Telemetry

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218715695 I have one question, maybe I missed it in discussion why is this implemented in CLI and not LIB I think it make more sense to implement in the top level

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218664005 ping ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62932451 --- Diff: doc/cordova.txt --- @@ -5,6 +5,8 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62895769 --- Diff: doc/cordova.txt --- @@ -21,7 +23,7 @@ Project Commands run Run project

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62894363 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62882068 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62880886 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62870553 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62777073 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62768428 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62767415 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62766681 --- Diff: doc/cordova.txt --- @@ -23,6 +23,12 @@ Project Commands serve .. Run project with a local webserver

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62765915 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62759764 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62758588 --- Diff: spec/cli.spec.js --- @@ -50,19 +56,34 @@ describe("cordova cli", function () { beforeEach(function () { });

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62758273 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218299896 Related: https://github.com/apache/cordova-docs/pull/599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62710076 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62709210 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708834 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708649 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708496 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708439 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62707187 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62705738 --- Diff: spec/cli.spec.js --- @@ -50,19 +56,34 @@ describe("cordova cli", function () { beforeEach(function () { });

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62705505 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62705209 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62704961 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62704887 --- Diff: doc/cordova.txt --- @@ -23,6 +23,12 @@ Project Commands serve .. Run project with a local webserver

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62704632 --- Diff: doc/cordova.txt --- @@ -43,4 +49,7 @@ Examples cordova-cli requirements android cordova-cli build android --verbose

Re: [GitHub] cordova-cli pull request: Telemetry

+1 @purplecabbage risingj.com On Mon, May 9, 2016 at 5:08 PM, stevengill wrote: > Github user stevengill commented on the pull request: > > https://github.com/apache/cordova-cli/pull/247#issuecomment-218025705 > > LGTM!! > > > --- > If your project is set up for

[GitHub] cordova-cli pull request: Telemetry

Github user stevengill commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218025705 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-cli pull request: Telemetry

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-217944908 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-217747793 This code relies on the insight package: https://www.npmjs.com/package/insight However, due to a bug within insight, when the command prompt timeout expires,

[GitHub] cordova-cli pull request: Telemetry

GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/247 Telemetry Work In Progress... You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-cli Telemetry Alternatively you can review