[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-208401173 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-11 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59224471 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-208400534 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-208353356 @omefire, addressed your notes and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-11 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59195085 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

2016-04-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-208311472 The config file transformations are already handled during both plugin add/rm and prepare. Consider the following code:

[GitHub] cordova-lib pull request: [CB-11062] Add --recursive option to git...

2016-04-11 Thread jfrumar
GitHub user jfrumar opened a pull request: https://github.com/apache/cordova-lib/pull/424 [CB-11062] Add --recursive option to git clone command Support cordova plugins that make use of git submodules. ref: https://issues.apache.org/jira/browse/CB-11062 You can merge this

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-207640986 Yes, I'm aware he is removing npm cache completely. This fix is still valuable in the interim till Steve completes the fetch work. --- If your project is set up

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

2016-04-08 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-207527874 This code is pretty hard to follow. I don't mean your changes, but plugin installation overall is more complex than I expected. How do these changes

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-207526774 I think Steve is addressing this in his changes to fetch. Cc: @stevengill --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59051171 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-08 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59039160 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59037903 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-08 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59029064 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59018183 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

2016-04-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-207411302 @jasongin, @nikhilkh, please take a look when you have a chance --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

2016-04-08 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/423 CB-11022 Improve performance of `cordova plugin add` command This addresses [CB-11022](https://issues.apache.org/jira/browse/CB-11022) and dramaticaly reduces time required for plugin

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59007596 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-08 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-207354240 LGTM! except for a minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-08 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59003112 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-07 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-lib/pull/422 CB-10770 Remove cache-min when adding platforms You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib cache-min

[GitHub] cordova-lib pull request: CB-9434: Adding a ToDO. 'cordova run' sh...

2016-04-06 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10975 Allow plugin path to be relativ...

2016-04-06 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/421 CB-10975 Allow plugin path to be relative to current directory JIRA: [CB-10975](https://issues.apache.org/jira/browse/CB-10975) You can merge this pull request into a Git repository

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2016-04-05 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-206015614 Closing this as not relevant anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-205924214 @vladimir-kotikov taking a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-04-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-205453861 @omefire, ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-03-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-203895099 @omefire, could you please take a look. Also, duplicating comment in JIRA, could you please explain, why we don't fail in case of plugin restore

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

2016-03-31 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/420 CB-10921 Emit warning in case of plugin restoration failure This PR adds a warning if plugin restore failed due to some reason. See

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/408#issuecomment-203470641 This has been integrated as a part of #414, closing --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-10981 Remove cordova-common from bund...

2016-03-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/419 CB-10981 Remove cordova-common from bundled dependencies Since cordova-common has been released to NPM we do not need to bundle it into cordova-lib release packages. See

[GitHub] cordova-lib pull request: CB-10833 Deduplicate platform-agnostic c...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10833 Deduplicate platform-agnostic c...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/414#issuecomment-203459332 @omefire, @daserge, thanks for reviewing. Rebased and going to merge --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-10833 Deduplicate platform-agnostic c...

2016-03-30 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/414#discussion_r57860731 --- Diff: cordova-common/src/PluginManager.js --- @@ -0,0 +1,148 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-202818205 @csantanapr, i merged a bit different change, which uses `preparePlatforms` method instead of `prepare` .It is a subset of `prepare` but doesn't include

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10908 - Add a plugin with the --save ...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/418#issuecomment-202768180 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/418#issuecomment-202764912 Addressed, thanks @vladimir-kotikov, please take a look when you have a moment. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57676830 --- Diff: cordova-common/spec/events.spec.js --- @@ -0,0 +1,30 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-28 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57673750 --- Diff: cordova-common/spec/events.spec.js --- @@ -0,0 +1,30 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-28 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57673594 --- Diff: cordova-common/src/events.js --- @@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter) { if (!(eventEmitter

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57634233 --- Diff: cordova-common/spec/events.spec.js --- @@ -0,0 +1,30 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57634064 --- Diff: cordova-common/src/events.js --- @@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter) { if

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57632693 --- Diff: cordova-common/src/events.js --- @@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter) { if

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/417#discussion_r57614805 --- Diff: cordova-common/spec/util/xml-helpers.spec.js --- @@ -207,6 +207,16 @@ describe('xml-helpers', function(){

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/417#issuecomment-202528558 LGTM. Didn't have a time to test it but making `name` a singleton definitely makes sense. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-28 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/418 CB-10940 Can't add Android platform from path Added a corresponding test for events.forwardEventsTo [Jira issue](https://issues.apache.org/jira/browse/CB-10940) You can merge this

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-26 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/417 CB-10965 xml helper allows multiple instances to be merge in config.xml @vladimir-kotikov I this is the real fix on duplicate names ending up in final config.xml triggering the unwanted

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-26 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201937380 @vladimir-kotikov yes lets fix this in cordova-lib to get a fix in CLI 6.1.1, but I agree with you that problem should also be fix in iOS The root of

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201929790 @csantanapr, this LGTM and i believe it would solve the problem, but I think the real problem is in cordova-ios `prepare` method - when you change app's

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-26 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201893339 @riknoll @vladimir-kotikov I found a way to skip prepare hooks on first prepare call. made the change I rebase, please review again --- If your project is set

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-26 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201881251 @riknoll I don't think is big deal if prepare hooks twice, I will look to see if there is a way to call first prepare without hooks --- If your project is set

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-25 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201642371 Does running prepare twice have any impact on the hooks that fire? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-25 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/416 CB-10961 Error when adding ios platform and plugin declare in config.xml @vladimir-kotikov can you review This other commit

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-22 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-199661470 Plugman PR adding --fetch flag support https://github.com/apache/cordova-plugman/pull/87 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10775: cordova-ios update fix:

2016-03-20 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/413 CB-10775: cordova-ios update fix: When handling the `cordova platform update ios@4.1.0`, cordova-ios deletes the folder project_path/platform/ios/project_name/Plugins, thereby

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-20 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197555600 The truncated AppVeyor message says "AppVeyor was unable to build non-mergeable pull request", which is odd since there are no conflicts (as reported by Github)

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197549676 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-19 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/412#issuecomment-197550412 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/411 CB-10694 - Platform-specific configuration preferences don't override global settings Includes jasmine test. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-19 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/412 CB-9264 - Duplicate entries in config.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-9264 Alternatively you

[GitHub] cordova-lib pull request: CB-10822 CB-10833 Deduplicate platform-a...

2016-03-19 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/414 CB-10822 CB-10833 Deduplicate platform-agnostic code You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-19 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/412#issuecomment-197559090 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197557719 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10775: cordova-ios update fix:

2016-03-19 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/413#issuecomment-198065158 Occasionally, there is this issue that pops up: ``` cp: no such file or directory: /Users/omefire/Projects/tt/platforms/ios/Hello Cordova/.gitignore

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/412#issuecomment-197606599 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197556043 Yeah, that is weird. Probably not an issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-10908 - Add a plugin with the --save ...

2016-03-19 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/415 CB-10908 - Add a plugin with the --save flag clubbers data that is wr… - Reload the config.xml before writing the saved plugin You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: CB-10775: cordova-ios update fix:

2016-03-19 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/413 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197558977 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10775: cordova-ios update fix:

2016-03-19 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/413#issuecomment-198046291 @stevengill to review. Keep in mind, I'm still carrying out some tests on iOS & Android to make sure everything works well. --- If your project is set up for

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197554211 What's up with the Appveyor build on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-197159034 still working on integrating it into the template work, but will add it soon to the pr. On Tue, Mar 15, 2016 at 8:00 PM, Carlos Santana

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-197128552 @stevengill the npm install portion is reverted now, I will take a look at your PR for npm fetch on how is handling the template fetching and npm install. ---

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-197123180 @stevengill oops good catch, that npm install portion was not suppose to be there, I was just experimenting, only the top portion for the sub dir. I

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-197038950 I don't think you should be running npm install carlos. This code doesn't even check if npm exists before trying to run it. I recommend you leaving the

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-15 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/409#issuecomment-196941258 JIRA is [CB-10880](https://issues.apache.org/jira/browse/CB-10880). Merging now --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/409#issuecomment-196928076 Let's get it in! I just resolved another JIRA filed because this was causing some confusion. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-196831845 @vladimir-kotikov thanks for the review I will check on those --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-196699443 LGTM apart from two minor nitpicks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/410#discussion_r56123679 --- Diff: cordova-lib/src/cordova/create.js --- @@ -220,8 +220,22 @@ function create(dir, optionalId, optionalName, cfg) { }

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/410#discussion_r56122825 --- Diff: cordova-lib/src/cordova/create.js --- @@ -220,8 +220,22 @@ function create(dir, optionalId, optionalName, cfg) { }

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-14 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/409#issuecomment-196541926 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-196399690 @stevengill @vladimir-kotikov could you review this when you have chance. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-10808 **CLI** Should handle templates...

2016-03-14 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/410 CB-10808 **CLI** Should handle templates with files located in sub directory Refer to [CB-1080](https://issues.apache.org/jira/browse/CB-10808) for more info You can merge this pull

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-11 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/409#issuecomment-195631599 I'll create a JIRA later (Apache JIRA seems to be down right now). @stevengill please review when you have a moment. --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-11 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/409 Remove plugin pinning As discussed on the dev list You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib remove-pinning

[GitHub] cordova-lib pull request: Fall back to platform's default orientat...

2016-03-11 Thread mmrko
Github user mmrko closed the pull request at: https://github.com/apache/cordova-lib/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

2016-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

2016-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

2016-03-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/408#issuecomment-194806460 The related changes for cordova android can be found here: https://github.com/apache/cordova-android/compare/master...MSOpenTech:CB-10822?expand=1 --- If

<    5   6   7   8   9   10   11   12   13   14   >