Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/420#issuecomment-208401173
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/420#issuecomment-208353356
@omefire, addressed your notes and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59195085
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59039160
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59037903
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59029064
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59018183
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/420#issuecomment-207354240
LGTM! except for a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59003112
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/420#issuecomment-205924214
@vladimir-kotikov taking a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/420#issuecomment-205453861
@omefire, ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/420#issuecomment-203895099
@omefire, could you please take a look.
Also, duplicating comment in JIRA, could you please explain, why we don't
fail in case of plugin restore failure
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/420
CB-10921 Emit warning in case of plugin restoration failure
This PR adds a warning if plugin restore failed due to some reason. See
[CB-10921](https://issues.apache.org/jira/browse/CB-
14 matches
Mail list logo
