Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220658702
My suggestion was to separate editing and inserting altogether. Continue to
have a `config-file` tag that works exactly like before for adding things to
XML, and ha
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220647997
I'd like to clear up some confusion I have on adding attributes.
Before, we had decided on going with this syntax where the child elements
of config-file tag would
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220467601
I think that the issue might be that we need to separate inserting child
elements and editing existing ones. Something like this:
```xml
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220440531
@riknoll Vladimir is correct, there is no mechanism for either yet.
I think warnings are good, but does that mean the plugins that get
installed first get fir
Github user ktop commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/432#discussion_r63922339
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -116,6 +117,13 @@ function preparePlatforms (platformList, projectRoot,
options) {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220386776
@vladimir-kotikov yep, my thought's exactly! We definitely need to handle
plugins conflicting with each other because any bugs caused by those conflicts
would likel
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220254686
I think there is no mechanism for resolving conflicts, as there was no need
for it before.
One idea on how to deal w/ conflicts is to fail by defau
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220179183
@ktop I have a couple questions. First, do we have a plan for dealing with
plugins that have conflicting attribute edits? For example, if plugin A has
this in its p
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/432#discussion_r63604254
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -116,6 +117,13 @@ function preparePlatforms (platformList, projectRoot,
options) {
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-219188296
Yeah, same here. I think anyone who is working from master and using npm
link(s) is bunked for a bit.
@purplecabbage
risingj.com
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-219075301
@ktop, @stevengill my environment seems to be in a bad state. I've got
problems with cordova-fetch and the new telemetry stuff I'm working through.
Right now when
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-218824969
@stevengill it was working pretty good last I checked. With the config.xml
stuff in it should be ready to go. I've earmarked some time tomorrow to do my
testing. c
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-218623029
How close is this to being able to merge in? @macdonst
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-217972581
@macdonst I've added the implementation for config-file to config.xml just
to get it working, but I do think it should be refactored
(cordova-common/src/ConfigChanges/
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-217228255
@ktop thanks for the hint about running `cordova-coho/coho npm-link`. Once
I did I was able to get your code to run. It seems to be working pretty good to
me. So I
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216629805
@macdonst @purplecabbage
On my other machine (Mac), I see the same behavior that you both were
seeing. I was able to fix it by doing a `cordova-coho/coho npm-link`
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216543951
@purplecabbage
My workspace is working off of the master branches with the tools npm
linked.
I modified the plugin.xml of cordova-plugin-device and added
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216424469
@ktop Can you provide the steps you used to verify that this is working
please?
What I did was create a new project, and added the cordova-plugin-devi
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216386608
I too am seeing @macdonst 's issue.
```
...
```
---
If your project is set up for it, you can repl
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464
@ktop @riknoll yeah, config.xml should be part of this. Anything in
config.xml should trump whatever is specified in the plugin.xml. If we do modes
then default mo
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215892244
I would put the mode flag as out-of-scope for now, we can re-asses later if
need be.
I could not get this to work, can you please post instructions fo
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215866756
@ktop config-file wasn't in config.xml before, but we wanted to add it
because the number of config.xml attributes that just edit various native xml
files is gettin
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823
@macdonst
I had Edna test the first time around before I opened the PR and she was
able to get it working, so that is weird that it is adding a new element for
yo
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215811240
@ktop Yeah, I have the `attr="true"` in my plugin.xml and it still gets
added instead of merged.
```
```
I'm not s
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215478064
## [Current coverage][cc-pull] is **79.60%**
> Merging [#432][cc-pull] into [master][cc-base-branch] will increase
coverage by **-0.49%**
```diff
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213530432
If we can modify existing attributes, and then the plugin gets removed, the
modified attribute will also get removed. I don't think there is a way to
revert it back to
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213519895
@ktop I did a quick test of this with one of my existing apps and it does
add the following lines to AndroidManifest.xml:
```
```
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/432
CB-11023 Add attribute through config-file tag
Add functionality to be able to add attributes to xml files through
config-file tag.
Syntax:
Able to add multiple attributes to multipl
28 matches
Mail list logo
