Re: Android: activityResultKeepRunning

2014-11-05 Thread Andrew Grieve
Created an issue with proposed changes: https://issues.apache.org/jira/browse/CB-7947. Let's move discussion there. On Tue, Oct 21, 2014 at 12:03 PM, Andrew Grieve wrote: > I don't think there's even been an issue opened for it. Seems like maybe > the proper thing to do here though, is to move t

Re: Android: activityResultKeepRunning

2014-10-21 Thread Andrew Grieve
I don't think there's even been an issue opened for it. Seems like maybe the proper thing to do here though, is to move the pause/resumeTimers logic into CordovaActivity since they apply to all webviews. On Thu, Oct 16, 2014 at 2:29 PM, Joe Bowser wrote: > So, what's going on with this? Did this

Re: Android: activityResultKeepRunning

2014-10-16 Thread Joe Bowser
So, what's going on with this? Did this land in any release of Cordova? On Fri, Sep 12, 2014 at 12:24 PM, Joe Bowser wrote: > > > On Fri, Sep 12, 2014 at 10:34 AM, Archana Naik > wrote: > >> We have tested this behavior and in fact AmazonWebView which was and is >> always based on chromium, we

Re: Android: activityResultKeepRunning

2014-09-12 Thread Joe Bowser
On Fri, Sep 12, 2014 at 10:34 AM, Archana Naik wrote: > We have tested this behavior and in fact AmazonWebView which was and is > always based on chromium, we recommend to pause/resume timers in order to > manage resources. > So, it works on the Amazon Chromium build? The more things change, th

Re: Android: activityResultKeepRunning

2014-09-12 Thread Joe Bowser
On Fri, Sep 12, 2014 at 10:21 AM, Andrew Grieve wrote: > On Fri, Sep 12, 2014 at 1:02 PM, Joe Bowser wrote: > > After testing this again for sanity, we should probably kill this option. > > I don't like it (in fact I hate it), but resumeTimers doesn't actually > > resume the timers on KitKat, a

Re: Android: activityResultKeepRunning

2014-09-12 Thread Archana Naik
We have tested this behavior and in fact AmazonWebView which was and is always based on chromium, we recommend to pause/resume timers in order to manage resources. On Fri, Sep 12, 2014 at 10:21 AM, Andrew Grieve wrote: > On Fri, Sep 12, 2014 at 1:02 PM, Joe Bowser wrote: > > After testing this

Re: Android: activityResultKeepRunning

2014-09-12 Thread Andrew Grieve
On Fri, Sep 12, 2014 at 1:02 PM, Joe Bowser wrote: > After testing this again for sanity, we should probably kill this option. > I don't like it (in fact I hate it), but resumeTimers doesn't actually > resume the timers on KitKat, and since other browsers may not even support > this, we have to a

Re: Android: activityResultKeepRunning

2014-09-12 Thread Joe Bowser
After testing this again for sanity, we should probably kill this option. I don't like it (in fact I hate it), but resumeTimers doesn't actually resume the timers on KitKat, and since other browsers may not even support this, we have to add a bunch of buggy Javascript that will be prone to breakin

Re: Android: activityResultKeepRunning

2014-09-12 Thread Ian Clelland
The patch that they applied was actually taken from the Cordova-crosswalk-engine plugin, so in this case, they're keeping up with us :) And yeah, once we get this all sorted out, it should be documented. On Fri, Sep 12, 2014 at 1:55 AM, Andrey Kurdumov wrote: > Hi, > > I periodically check how

Re: Android: activityResultKeepRunning

2014-09-11 Thread Andrey Kurdumov
Hi, I periodically check how Crosswalk engine developed and seen that they land functionality which you are discussing today/yesterday https://github.com/crosswalk-project/crosswalk-cordova-android/pull/136 Maybe there make sense keep compatibility with them too. Or at least if timers would be pa

Re: Android: activityResultKeepRunning

2014-09-11 Thread Andrew Grieve
I guess I can see the value of providing a safety option for "pause my app in the background", but in general I think it's better practice to not pause forcefully, and instead have apps listen to the "pause" event, and stop battery-draining activity there instead. So... let's keep the option in, an

Re: Android: activityResultKeepRunning

2014-09-10 Thread Tommy Williams
Big -1 for breaking current background behaviour. Or am I misunderstanding? On 11 Sep 2014 10:34, "Joe Bowser" wrote: > Pausing timers means that the JS isn't running in the background at all. > This now means that the Javascript is running constantly, regardless of > whether it's an event.

Re: Android: activityResultKeepRunning

2014-09-10 Thread Joe Bowser
Pausing timers means that the JS isn't running in the background at all. This now means that the Javascript is running constantly, regardless of whether it's an event. This means that setInterval is still running. This could break people's applications. On Wed, Sep 10, 2014 at 5:29 PM, Andrew G

Re: Android: activityResultKeepRunning

2014-09-10 Thread Andrew Grieve
Getting off track here a bit. Here's what I'm suggesting with my original email: https://github.com/agrieve/cordova-android/compare/apache:4.0.x...no_disable_timers?expand=1 I was further asking if there was any use in ever pausing timers (aka, removing the KeepRunning preference). On Wed, Sep

Re: Android: activityResultKeepRunning

2014-09-10 Thread Brian LeRoux
I consider 4 a release branch. Merge in tested green lit code to your hearts desire but 4.0 is definitely not a feature. It should be always in a releasable state. On Sep 10, 2014 1:53 PM, "Michal Mocny" wrote: > Question is, do you consider the fact that bugs are introduced & discovered > (possi

Re: Android: activityResultKeepRunning

2014-09-10 Thread Joe Bowser
On Wed, Sep 10, 2014 at 1:46 PM, Michal Mocny wrote: > Question is, do you consider the fact that bugs are introduced & discovered > (possibly with pain) a sign that the system is broken, or a sign that the > system is working? > Given when they are discovered (right before release), I consider

Re: Android: activityResultKeepRunning

2014-09-10 Thread Michal Mocny
Question is, do you consider the fact that bugs are introduced & discovered (possibly with pain) a sign that the system is broken, or a sign that the system is working? I sense that Andrew worries that if work has to land on a feature branch of this feature branch, it won't get eyeballs. I sense

Re: Android: activityResultKeepRunning

2014-09-10 Thread Joe Bowser
I think this needs to be thought through more, and I'm extremely wary when you say this is a single commit, especially based on the last couple of months and how long it took 3.6 to go through. Given that we have people travelling halfway across the planet who intend to show people their work in l

Re: Android: activityResultKeepRunning

2014-09-10 Thread Andrew Grieve
I don't think there'd be much value in that. It'll be a single commit that almost entirely just deletes lines. What do you think about the never auto-pausing on backgrounding? or about auto-pausing when intent sending? On Wed, Sep 10, 2014 at 12:32 PM, Joe Bowser wrote: > Can you put this on its

Re: Android: activityResultKeepRunning

2014-09-10 Thread Joe Bowser
Can you put this on its own branch before it lands in 4.0.x? That'd be awesome! On Tue, Sep 9, 2014 at 5:32 PM, Andrew Grieve wrote: > For cordova-android 4.0, I'd like to go as far as just deleting the > "KeepRunning" . > > Apps get a "pause" event when they are backgrounded, and they can do >

Re: Android: activityResultKeepRunning

2014-09-09 Thread Andrew Grieve
For cordova-android 4.0, I'd like to go as far as just deleting the "KeepRunning" . Apps get a "pause" event when they are backgrounded, and they can do any pause-type logic there (e.g. unlisten to accelerometer events or pausing audio). Any strong objections? On Tue, Sep 9, 2014 at 4:27 PM, And

Android: activityResultKeepRunning

2014-09-09 Thread Andrew Grieve
Commit description: If multitasking is turned on (keepRunning=true), then temporarily disable it when starting a new activity that returns a result - such as camera. https://github.com/apache/cordova-android/commit/26adfb634651196106fb5b66f15eecb535a06d82 Bryce / anyone - clues as to *why* we'd w