Re: Review Request 15775: Add --src --link to cordova create

2013-12-23 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ --- (Updated Dec. 23, 2013, 6:26 p.m.) Review request for cordova. Changes

Re: Review Request 15775: Add --src --link to cordova create

2013-12-23 Thread Andrew Grieve
Merged. On Mon, Dec 23, 2013 at 1:26 PM, Mark Koudritsky kam...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ Review request for cordova. By Mark Koudritsky. *Updated Dec. 23, 2013, 6:26 p.m.* Changes Removed

Re: Review Request 15775: Add --src --link to cordova create

2013-12-20 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ --- (Updated Dec. 20, 2013, 4:51 p.m.) Review request for cordova. Changes

Re: Review Request 15775: Add --src --link to cordova create

2013-12-20 Thread Andrew Grieve
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review30753 --- src/config_parser.js

Re: Review Request 15775: Add --src --link to cordova create

2013-12-20 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review30757 --- src/create.js https://reviews.apache.org/r/15775/#comment58868

Re: Review Request 15775: Add --src --link to cordova create

2013-12-13 Thread Mark Koudritsky
This line moved to line 155. We first need to figure out whether the www dir will be a real dir or a symlink. Yeah, I eventually found it, but my point is that it was lost. Also, could you delay the other mkdir's to the later point so that readers see they're related? I'm not asking

Re: Review Request 15775: Add --src --link to cordova create

2013-12-13 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ --- (Updated Dec. 13, 2013, 7:30 p.m.) Review request for cordova. Changes

Re: Review Request 15775: Add --src --link to cordova create

2013-12-12 Thread Josh Soref
Mark wrote: https://reviews.apache.org/r/15775/ --link was a boolean before, now it accepts a path, so it's either --src=path or --link=path. Added a check in config_parser to make sure we are looking at an xml file that looks like Cordova config.xml to avoid overwriting some unrelated config.xml

Re: Review Request 15775: Add --src --link to cordova create

2013-11-29 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ --- (Updated Nov. 29, 2013, 4:55 p.m.) Review request for cordova. Changes

Re: Review Request 15775: Add --src --link to cordova create

2013-11-22 Thread Ian Clelland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review29288 --- The code looks good -- I think we probably need a couple of unit

Review Request 15775: Add --src --link to cordova create

2013-11-21 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ --- Review request for cordova. Summary (updated) - Add --src