jbonofre opened a new pull request, #161:
URL: https://github.com/apache/creadur-rat/pull/161
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1376539769
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787054660
Would it be possible to add a test for the newly created behaviour? (apart
from the changelog entry ;))
I guess that the docs need to be updated, too:
*
https://github.com/a
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787127829
@ottlinger good points. Let me update the PR accordingly. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Claudenw commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377861349
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377878696
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787582488
I will rebase and update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378419481
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files
Claudenw commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378464274
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files
ottlinger commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1379361410
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the file
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792037119
Please make sure to rebase as changes came in via
https://github.com/apache/creadur-rat/pull/163/files - thanks.
--
This is an automated message from the Apache Git Service.
To resp
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792040351
I will but I need time : we have been hit by the storm and no electricity
for now :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Claudenw commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792545538
I have a re based branch of JB's work. If you want I can submit that.
On Fri, Nov 3, 2023, 09:29 JB Onofré ***@***.***> wrote:
> I will but I need time : we have been hit
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1793374793
I should be back online today. So I will tackle that. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1801828395
I'm back :) I'm rebasing and fixing conflict. I will update the PR very soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1813992339
Back on Rat 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1395449313
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1819439807
Rebase done, I'm adding tests now as requested by @ottlinger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Claudenw commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1819489325
Looks very good to me (LVGTM?) . I await the tests with baited breath -- No
I did not eat the worms.
--
This is an automated message from the Apache Git Service.
To respond to t
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1820642992
@Claudenw @ottlinger I added a couple of simple tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1825853933
@ottlinger I think we are good about this one. Can you please take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
ottlinger commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1405287731
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -75,17 +75,17 @@ java -jar
apache-rat/target/apache-rat-${project.version}.jar
+---
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826461291
I'll add the changelog entry upon merging - thanks again for your
contribution @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826572550
@ottlinger should I update `RELEASE_NOTES.txt` ? I thought it's updated just
at release time.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1405327832
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -75,17 +75,17 @@ java -jar
apache-rat/target/apache-rat-${project.version}.jar
+
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1405328109
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -75,17 +75,17 @@ java -jar
apache-rat/target/apache-rat-${project.version}.jar
+
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826819609
> @ottlinger should I update `RELEASE_NOTES.txt` ? I thought it's updated
just at release time.
The txt file is generated, while the actual changelog is
src/changes/changes.xml
ottlinger merged PR #161:
URL: https://github.com/apache/creadur-rat/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.ap
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826846100
Thanks again for this contribution @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
29 matches
Mail list logo
