Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581905166 ## apache-rat-core/src/main/java/org/apache/rat/Defaults.java: ## @@ -57,6 +62,10 @@ public class Defaults { public static final String

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581905166 ## apache-rat-core/src/main/java/org/apache/rat/Defaults.java: ## @@ -57,6 +62,10 @@ public class Defaults { public static final String

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906050 ## apache-rat-core/src/main/java/org/apache/rat/Defaults.java: ## @@ -57,6 +62,10 @@ public class Defaults { public static final String

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906153 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -452,11 +452,11 @@ private static IReportable getDirectory(String baseDirectory,

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906451 ## apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java: ## @@ -179,31 +177,31 @@ public boolean isDryRun() { /** * @return The

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906646 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/ClaimStatistic.java: ## @@ -57,45 +58,71 @@ public int getCounter(Counter counter) { return

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906606 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/ClaimStatistic.java: ## @@ -57,45 +58,71 @@ public int getCounter(Counter counter) { return

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906723 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/ClaimStatistic.java: ## @@ -57,45 +58,71 @@ public int getCounter(Counter counter) { return

[jira] [Created] (WHISKER-25) Unable to update to latest ASF parent v32 due to dependency change

2024-04-27 Thread Philipp Ottlinger (Jira)
Philipp Ottlinger created WHISKER-25: Summary: Unable to update to latest ASF parent v32 due to dependency change Key: WHISKER-25 URL: https://issues.apache.org/jira/browse/WHISKER-25 Project:

Re: [PR] WHISKER-25: Bump org.apache:apache from 31 to 32 [creadur-whisker]

2024-04-27 Thread via GitHub
ottlinger commented on PR #142: URL: https://github.com/apache/creadur-whisker/pull/142#issuecomment-2081196280 Seems to be a dependency problem with v2/v3 of commons-lang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
Claudenw commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1582025702 ## apache-rat-core/src/main/java/org/apache/rat/Defaults.java: ## @@ -57,6 +62,10 @@ public class Defaults { public static final String

Re: [PR] TENTACLES-19: Bump org.apache:apache from 31 to 32 [creadur-tentacles]

2024-04-27 Thread via GitHub
ottlinger commented on PR #119: URL: https://github.com/apache/creadur-tentacles/pull/119#issuecomment-2081191802 Problem seems to be related to velocity dependency that pulls in commons-v2, while new ASF parent sets v3 as default version. -- This is an automated message from the Apache

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-04-27 Thread via GitHub
Claudenw commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1582025702 ## apache-rat-core/src/main/java/org/apache/rat/Defaults.java: ## @@ -57,6 +62,10 @@ public class Defaults { public static final String

[jira] [Updated] (RAT-147) binary guesser design improvement

2024-04-27 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/RAT-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-147: -- Fix Version/s: 0.17 > binary guesser design improvement > - > >

[jira] [Updated] (RAT-211) Generated rat-output.xml must be well-formed, even if BinaryGuesser fails

2024-04-27 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/RAT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-211: -- Fix Version/s: 0.17 > Generated rat-output.xml must be well-formed, even if BinaryGuesser fails >

[jira] [Updated] (RAT-150) RAT should use Apache Tika to simply guess ignored [application/X] file types and focus on the [text/Y] family as a sensible default

2024-04-27 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/RAT-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-150: -- Fix Version/s: 0.17 > RAT should use Apache Tika to simply guess ignored [application/X] file

[jira] [Commented] (RAT-246) .gitignore in parent dir not honored

2024-04-27 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/RAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841538#comment-17841538 ] Philipp Ottlinger commented on RAT-246: --- [~basinilya] did you find the opportunity to verify if the

[jira] [Commented] (RAT-301) Rat check file identification error,java files with Chinese characters are recognized as binary files

2024-04-27 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/RAT-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841539#comment-17841539 ] Philipp Ottlinger commented on RAT-301: --- [~claude] would you mind adding