Re: Some questions about the in CORS filter

2011-12-06 Thread Sergey Beryozkin
Hi Benson On 05/12/11 16:11, Benson Margulies wrote: I translate Anne's answer just now as follows: To return information to the client, it has to be 2xx. So in the success case, it has to be 2xx. If it fails, we can do whatever we prefer: 2xx and no CORS headers or 4xx. I'm with you on a 4xx.

Some questions about the in CORS filter

2011-12-05 Thread Sergey Beryozkin
Hi Benson, all At the moment the in CORS filter returns 'null' during a preflight check, whenever some check fails, which means that most likely an HTTP status code will be returned to do with failure at the selection algorithm stage, but that status code may not necessarily to be the one

Re: Some questions about the in CORS filter

2011-12-05 Thread Benson Margulies
On Mon, Dec 5, 2011 at 7:15 AM, Sergey Beryozkin sberyoz...@gmail.com wrote: Hi Benson, all At the moment the in CORS filter returns 'null' during a preflight check, whenever some check fails, which means that most likely an HTTP status code will be returned to do with failure at the

Re: Some questions about the in CORS filter

2011-12-05 Thread Sergey Beryozkin
On 05/12/11 13:23, Benson Margulies wrote: On Mon, Dec 5, 2011 at 7:15 AM, Sergey Beryozkinsberyoz...@gmail.com wrote: Hi Benson, all At the moment the in CORS filter returns 'null' during a preflight check, whenever some check fails, which means that most likely an HTTP status code will be

Re: Some questions about the in CORS filter

2011-12-05 Thread Benson Margulies
On Mon, Dec 5, 2011 at 10:15 AM, Sergey Beryozkin sberyoz...@gmail.com wrote: On 05/12/11 13:23, Benson Margulies wrote: On Mon, Dec 5, 2011 at 7:15 AM, Sergey Beryozkinsberyoz...@gmail.com  wrote: Hi Benson, all At the moment the in CORS filter returns 'null' during a preflight check,

Re: Some questions about the in CORS filter

2011-12-05 Thread Sergey Beryozkin
Hi On 05/12/11 15:15, Sergey Beryozkin wrote: On 05/12/11 13:23, Benson Margulies wrote: On Mon, Dec 5, 2011 at 7:15 AM, Sergey Beryozkinsberyoz...@gmail.com wrote: Hi Benson, all At the moment the in CORS filter returns 'null' during a preflight check, whenever some check fails, which means

Re: Some questions about the in CORS filter

2011-12-05 Thread Sergey Beryozkin
Hi On 05/12/11 15:39, Benson Margulies wrote: On Mon, Dec 5, 2011 at 10:15 AM, Sergey Beryozkinsberyoz...@gmail.com wrote: On 05/12/11 13:23, Benson Margulies wrote: On Mon, Dec 5, 2011 at 7:15 AM, Sergey Beryozkinsberyoz...@gmail.com wrote: Hi Benson, all At the moment the in CORS

Re: Some questions about the in CORS filter

2011-12-05 Thread Sergey Beryozkin
The filter returns Response.ok().build() in the end of the preflight check, which indeed will let the out CORS filter to finalize the preflight response but in cases where the preflight check was not good then I believe a random HTTP error status will be returned depending on where the selection

Re: Some questions about the in CORS filter

2011-12-05 Thread Sergey Beryozkin
On 05/12/11 16:00, Benson Margulies wrote: On Mon, Dec 5, 2011 at 10:42 AM, Sergey Beryozkinsberyoz...@gmail.com wrote: Hi On 05/12/11 15:15, Sergey Beryozkin wrote: On 05/12/11 13:23, Benson Margulies wrote: On Mon, Dec 5, 2011 at 7:15 AM, Sergey Beryozkinsberyoz...@gmail.com wrote: Hi

Re: Some questions about the in CORS filter

2011-12-05 Thread Benson Margulies
At some point, we're going to need to try some experiments with a browser and make sure that whatever it is we've done actually works. Unfortunately, htmlunit doesn't have this client side yet (I'm working on a patch). I suppose I should read the source of Chromium or something, unless you beat me

Re: Some questions about the in CORS filter

2011-12-05 Thread Benson Margulies
I translate Anne's answer just now as follows: To return information to the client, it has to be 2xx. So in the success case, it has to be 2xx. If it fails, we can do whatever we prefer: 2xx and no CORS headers or 4xx. I'm with you on a 4xx.