Re: [VOTE] DataSketches-memory RC1

2019-07-25 Thread leerho
This last issue wrt GPG, if it still remains, will be added to the "Release process follow-ups" thread started by Kenn. On Thu, Jul 25, 2019 at 11:12 AM Furkan KAMACI wrote: > Hi Lee, > > Could you start a separate email thread for this issue? > > Kind Regards, > Furkan KAMACI > > On Tue, Jul 2

Re: [VOTE] DataSketches-memory RC1

2019-07-25 Thread Furkan KAMACI
Hi Lee, Could you start a separate email thread for this issue? Kind Regards, Furkan KAMACI On Tue, Jul 23, 2019 at 11:34 PM leerho wrote: > I guess I could just do the signing using gpg directly from a script. ... > Easier than trying to get Maven to work :( > > > On Tue, Jul 23, 2019 at 1:2

Re: [VOTE] DataSketches-memory RC1

2019-07-23 Thread leerho
I guess I could just do the signing using gpg directly from a script. ... Easier than trying to get Maven to work :( On Tue, Jul 23, 2019 at 1:29 PM leerho wrote: > I am doing that, but I don't know how to call it from the command line. Do > you know? > I am using one from Beam 2.4.0 (before t

Re: [VOTE] DataSketches-memory RC1

2019-07-23 Thread leerho
I am doing that, but I don't know how to call it from the command line. Do you know? I am using one from Beam 2.4.0 (before they moved to Gradle) sign org.apache.maven.plugins maven-gpg-plugin ${maven-gpg-plugin.v

Re: [VOTE] DataSketches-memory RC1

2019-07-23 Thread Furkan KAMACI
Hi Leerho, Yes, Druid does not specify gpg plugin. It is better to create a sign profile for it. Kind Regards, Furkan KAMACI On Tue, Jul 23, 2019 at 11:10 PM leerho wrote: > Correction: Druid does NOT specify the gpg plugin. I will put it in a > "sign" profile like beam has it. > > On Tue, Ju

Re: [VOTE] DataSketches-memory RC1

2019-07-23 Thread leerho
Correction: Druid does NOT specify the gpg plugin. I will put it in a "sign" profile like beam has it. On Tue, Jul 23, 2019 at 12:36 PM leerho wrote: > Hi, > Before I submit another RC, I want to understand what is causing your GPG > problems. I have studied the POM files from Druid, Beam: 2.4

Re: [VOTE] DataSketches-memory RC1

2019-07-23 Thread leerho
Hi, Before I submit another RC, I want to understand what is causing your GPG problems. I have studied the POM files from Druid, Beam: 2.4, Pinot, and Dubbo. They each handle the GPG plugin differently: - Druid has it configured in the section like I have it. - Beam puts it into a special

Re: [VOTE] DataSketches-memory RC1

2019-07-23 Thread Furkan KAMACI
Hi, It correctly checks whether gpg is running or not. However, gpg problem is still persists. We should move it into another profile. Kind Regards, Furkan KAMACI On Tue, Jul 23, 2019 at 3:57 AM leerho wrote: > Did that fix the GPG issue? > > Thanks for the Pinot suggestion, I will study it.

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
Did that fix the GPG issue? Thanks for the Pinot suggestion, I will study it. I have also been studying Druid and Beam for examples, but they both are quite complex deployments. Thank you!! Lee. On Mon, Jul 22, 2019 at 4:39 PM Furkan KAMACI wrote: > Hi Leerho, > > To confirm gpg is running: >

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread Furkan KAMACI
Hi Leerho, To confirm gpg is running: env | grep gpg instead of env | grep GPG On the other hand, such plugin seems to be at another profile as you say or signing could be handled in some other way. Could you check this pom files as an example: https://github.com/apache/incubator-druid/blob/m

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
Oh, the GPG problem could be that you need to start the GPG agent in your terminal at the very start, like this: # start gpg-agent in this env eval $(gpg-agent --daemon) # To confirm that the GPG agent is running: env | grep GPG However, I don't think the GPG plug-in should be in the main POM, i

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
I understand the [self-equals] error ... it is a false positive, which I can eliminate with an annotation. I don't understand the GPG plugin issue. On Mon, Jul 22, 2019 at 1:30 PM Furkan KAMACI wrote: > Hi Leerho, > > For the people who get same error, I've deleted related version from ~/.m

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread Furkan KAMACI
Hi Leerho, For the people who get same error, I've deleted related version from ~/.m2 folder and installed the project code. Current situation: 1) I get an error: Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:1.6:sign (sign-release-artifacts) on project datasketches-memory: Ex

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
Ok. I withdraw this RC1 and will resubmit an RC2 that should pass the strict test as well. This should take less than an hour. Lee. On Mon, Jul 22, 2019 at 1:09 PM leerho wrote: > Ah yes. It turns out that the strict profile detects a false positive and > fails :(.And there is no way t

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
Ah yes. It turns out that the strict profile detects a false positive and fails :(.And there is no way to suppress that false positive with annotation. At line 100 in XxHash64Test.java, the multiplication (0x9C90005B8000L * 2) is intentionally meant to overflow. The strict test, however, c

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
Odd. Maven-jar-plugin 3.1.2 clearly exists on Maven Central: https://search.maven.org/search?q=g:org.apache.maven.plugins%20AND%20a:maven-jar-plugin&core=gav . Overriding the Apache Parent Pom is always an option and should work (At least it does for me.). But sometimes when I experience problem

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread Furkan KAMACI
Hi Leerho, Thanks for the links! I cannot compile the source code. I get that error: Plugin org.apache.maven.plugins:maven-jar-plugin:3.1.2 or one of its dependencies could not be resolved: Failure to find org.apache.maven.plugins:maven-jar-plugin:jar:3.1.2 in https://repo.maven.apache.org/maven

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
If you are interested, the documentation for the DataSketches Memory component is part of the website. Specifically: - https://datasketches.github.io/docs/Memory/MemoryPackage.html - https://datasketches.github.io/docs/Memory/MemoryPerformance.html Lee. On Mon, Jul 22, 2019 at 10:28 AM leerho w

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread Furkan KAMACI
Seems that there was a problem at GitHub. It works now! On Mon, Jul 22, 2019 at 8:28 PM leerho wrote: > A 500 error is a malformed link or some internal GitHub server error > I don't get that error when just clicking on the link. > > When exactly are you getting that error message? > > > >

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread leerho
A 500 error is a malformed link or some internal GitHub server error I don't get that error when just clicking on the link. When exactly are you getting that error message? On Mon, Jul 22, 2019 at 9:08 AM Furkan KAMACI wrote: > Hi Leerho, > > GitHub throws a 500 error for this link: > >

Re: [VOTE] DataSketches-memory RC1

2019-07-22 Thread Furkan KAMACI
Hi Leerho, GitHub throws a 500 error for this link: https://github.com/apache/incubator-datasketches-memory is that usual? Kind Regards, Furkan KAMACI On Sun, Jul 21, 2019 at 9:33 PM leerho wrote: > Note also that when running the test suite, you might get the following > message: > > SLF4J:

Re: [VOTE] DataSketches-memory RC1

2019-07-21 Thread leerho
Note also that when running the test suite, you might get the following message: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. This i

Re: [VOTE] DataSketches-memory RC1

2019-07-20 Thread leerho
The DataSketches-memory component is pure Java and is structured as a Maven project. You must compile using JDK 8. The simplest way is to import the unzipped code into Eclipse or equivalent IDE as a Maven Project. There is one run-time dependency and, of course, a number of test and Maven plugin

Re: [VOTE] DataSketches-memory RC1

2019-07-19 Thread Liang Chen
Hi Please provide the build guide, how to compile source code. Regards Liang leerho 于2019年7月20日周六 上午10:05写道: > Hello Apache DataSketches Community, > > 1. This is a call for vote to release Apache DataSketches-memory version: > 1.0.0-incubating-RC1 > > NOTE 1: This is one component of the Dat

[VOTE] DataSketches-memory RC1

2019-07-19 Thread leerho
Hello Apache DataSketches Community, 1. This is a call for vote to release Apache DataSketches-memory version: 1.0.0-incubating-RC1 NOTE 1: This is one component of the DataSketches library which needs to be released first as other repositories have a dependency on this one. Once this is release