Re: Renaming @ViewRef config property?

2013-10-03 Thread Romain Manni-Bucau
I didnt use viewref enough to say but typically it is boring to need to write name in configproperty each time while you know what it is. Moreover for viewref, config doesnt sound really right, metadata or marker sounds as right as config depending where you are coming from. Well this doesnt hold

Re: ViewConfig does not work as expected (nested @Folder, @Secured)

2013-10-03 Thread Gerhard Petracek
hi thomas, @"Duplicated config for the same folder": can you please provide a test (like [1]) which illustrates the issue. thx & regards, gerhard [1] http://s.apache.org/OZ3 2013/9/30 Gerhard Petracek > +1 > > regards, > gerhard > > > > 2013/9/30 Thomas Andraschko > >> Hi Gerhard, >> >> yo

Re: Renaming @ViewRef config property?

2013-10-03 Thread Gerhard Petracek
-0.5 (instead of -1), because i used "value" in codi back then and there is nothing wrong with it. however, that was one of the lessons learned from using it in projects and explaining it in trainings for almost three years. what we have right now just reflects the feedback. regards, gerhard 20

Re: Renaming @ViewRef config property?

2013-10-03 Thread Romain Manni-Bucau
If config is the unique mandatory attr it should be value imo Le 3 oct. 2013 22:39, "Gerhard Petracek" a écrit : > hi thomas, > > yes - we had something in codi and we might add something like the payload > in bv. > > regards, > gerhard > > > > 2013/10/3 Thomas Andraschko > > > @Gerhard: Are the

Re: Renaming @ViewRef config property?

2013-10-03 Thread Gerhard Petracek
hi thomas, yes - we had something in codi and we might add something like the payload in bv. regards, gerhard 2013/10/3 Thomas Andraschko > @Gerhard: Are there any expected properties on @ViewRef in the future? > > > 2013/10/3 Romain Manni-Bucau > > > +1, same for @ConfigProperty btw > > Le

Re: Renaming @ViewRef config property?

2013-10-03 Thread Thomas Andraschko
@Gerhard: Are there any expected properties on @ViewRef in the future? 2013/10/3 Romain Manni-Bucau > +1, same for @ConfigProperty btw > Le 3 oct. 2013 20:49, "Gerhard Petracek" a > écrit : > > > -0.5 for now > > once we add more, you get the same and it would be not that expressive. > > that

Re: Renaming @ViewRef config property?

2013-10-03 Thread Romain Manni-Bucau
+1, same for @ConfigProperty btw Le 3 oct. 2013 20:49, "Gerhard Petracek" a écrit : > -0.5 for now > once we add more, you get the same and it would be not that expressive. > that was the reason for changing it (compared to codi). > > regards, > gerhard > > > > 2013/10/3 Thomas Andraschko > > >

Re: Renaming @ViewRef config property?

2013-10-03 Thread Gerhard Petracek
-0.5 for now once we add more, you get the same and it would be not that expressive. that was the reason for changing it (compared to codi). regards, gerhard 2013/10/3 Thomas Andraschko > Hi, > > currently @ViewRef has only one property called "config". > > So the current usage is: > @ViewRef

Re: Renaming @ViewRef config property?

2013-10-03 Thread Bruno Leonardo Gonçalves
+1 -- Bruno Leonardo Gonçalves 2013/10/3 Thomas Andraschko > Hi, > > currently @ViewRef has only one property called "config". > > So the current usage is: > @ViewRef(config = Views.Logout.class) > > What about renaming it to "value"? > -> @ViewRef(Views.Logout.class) > > Regards, > Thomas >

Renaming @ViewRef config property?

2013-10-03 Thread Thomas Andraschko
Hi, currently @ViewRef has only one property called "config". So the current usage is: @ViewRef(config = Views.Logout.class) What about renaming it to "value"? -> @ViewRef(Views.Logout.class) Regards, Thomas

[jira] [Commented] (DELTASPIKE-420) Transactional repositories

2013-10-03 Thread Thomas Hug (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784886#comment-13784886 ] Thomas Hug commented on DELTASPIKE-420: --- I'd rather go for option 1 (seems anywa

[jira] [Commented] (DELTASPIKE-421) Find zero or one

2013-10-03 Thread Thomas Hug (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784879#comment-13784879 ] Thomas Hug commented on DELTASPIKE-421: --- Sounds good to me too. I guess we shoul