[GitHub] incubator-distributedlog pull request #128: DL-198: Combining the NOTICE, LI...

2017-04-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/128 DL-198: Combining the NOTICE, LICENSE, and DISCLAIMER files You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-dist

Re: [DISCUSS] Combining the NOTICE, LICENSE, and DISCLAIMER files

2017-04-10 Thread Sijie Guo
I think this is doable - we can change the binary package assembly configuration (src/assemble/bin/xml) to include NOTICE/DISCLAIMER/LICENSE from root directly. Let me file one JIRA and send out a pull request for it. - Sijie On Mon, Apr 10, 2017 at 5:02 PM, Henry Saputra wrote: > Hi All, > >

[GitHub] incubator-distributedlog pull request #127: Change the NOTICE year for Twitt...

2017-04-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/127 Change the NOTICE year for Twitter Copyright to 2016 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributed

[GitHub] incubator-distributedlog issue #127: Change the NOTICE year for Twitter Copy...

2017-04-10 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/127 tag @fcuny @leighst @mgodave --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Sijie Guo
Awesome. I learned a lot from this discussion. We will address these comments and call another vote. - Sijie On Mon, Apr 10, 2017 at 3:11 PM, Marvin Humphrey wrote: > On Mon, Apr 10, 2017 at 2:28 PM, Henry Saputra > wrote: > > The question is whether we need to keep this section: > > > > Porti

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Marvin Humphrey
On Mon, Apr 10, 2017 at 5:06 PM, John D. Ament wrote: > Agreed, however this is where it gets complicated (and at least needs to be > clear to the contributors, or maybe I'm the only one thinking this is > confusing/not obvious). The ASF accepts contributions from individuals, > not companies.

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread John D. Ament
On Mon, Apr 10, 2017 at 7:24 PM Josh Elser wrote: > Marvin Humphrey wrote: > > On Mon, Apr 10, 2017 at 2:28 PM, Henry Saputra > wrote: > >> The question is whether we need to keep this section: > >> > >> Portions of this software were developed by Twitter. > >> Copyright Twitter, 2017 > >> > >> i

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Henry Saputra
Thanks for the review guys, will come back to dev@ list to update the release artifacts. - Henry On Mon, Apr 10, 2017 at 4:24 PM, Josh Elser wrote: > Marvin Humphrey wrote: > >> On Mon, Apr 10, 2017 at 2:28 PM, Henry Saputra >> wrote: >> >>> The question is whether we need to keep this section:

[DISCUSS] Combining the NOTICE, LICENSE, and DISCLAIMER files

2017-04-10 Thread Henry Saputra
Hi All, Seemed like we have 2 locations of the ASF license files: one in the root and one in src/main/resources The problem is that content of the files are different. Could we change the build system to bundle them using the ones in root location instead? Thanks, - Henry

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Josh Elser
Marvin Humphrey wrote: On Mon, Apr 10, 2017 at 2:28 PM, Henry Saputra wrote: The question is whether we need to keep this section: Portions of this software were developed by Twitter. Copyright Twitter, 2017 in the NOTICE file. Since Twitter already signed off the source contributions, we cou

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Marvin Humphrey
On Mon, Apr 10, 2017 at 2:28 PM, Henry Saputra wrote: > The question is whether we need to keep this section: > > Portions of this software were developed by Twitter. > Copyright Twitter, 2017 > > in the NOTICE file. Since Twitter already signed off the source > contributions, we could probably re

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Henry Saputra
The question is whether we need to keep this section: Portions of this software were developed by Twitter. Copyright Twitter, 2017 in the NOTICE file. Since Twitter already signed off the source contributions, we could probably remove this section. As for initial Copyright notice, we should put

[GitHub] incubator-distributedlog issue #126: DL-196: Remove 'Copyright 2017 The Apac...

2017-04-10 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/126 /cc @fcuny @leighst @mgodave for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] incubator-distributedlog pull request #126: DL-196: Remove 'Copyright 2017 T...

2017-04-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/126 DL-196: Remove 'Copyright 2017 The Apache Software Foundation' from license header You can merge this pull request into a Git repository by running: $ git pull https://github.

[GitHub] incubator-distributedlog issue #125: DL-197: Add DISCLAIMER file to the proj...

2017-04-10 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/125 /cc @leighst @fcuny @mgodave for a review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-distributedlog pull request #125: DL-197: Add DISCLAIMER file to t...

2017-04-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/125 DL-197: Add DISCLAIMER file to the project DISCLAIMER is missing for source release. You can merge this pull request into a Git repository by running: $ git pull https://github.

Re: [VOTE] Apache DistributedLog release 0.4.0-incubating

2017-04-10 Thread Sijie Guo
Thank you, Josh. Will address your comments. On Sun, Apr 9, 2017 at 4:38 PM, Josh Elser wrote: > -1 (binding) your source releases still do not contain the DISCLAIMER file > that John pointed out in rc2 [1]. > > * mvn apache-rat:check fails on `src/main/resources/DISCLAIMER.bin.txt` * Don't inc