On Mon, Apr 10, 2017 at 7:24 PM Josh Elser <els...@apache.org> wrote:
> Marvin Humphrey wrote: > > On Mon, Apr 10, 2017 at 2:28 PM, Henry Saputra<henry.sapu...@gmail.com> > wrote: > >> The question is whether we need to keep this section: > >> > >> Portions of this software were developed by Twitter. > >> Copyright Twitter, 2017 > >> > >> in the NOTICE file. Since Twitter already signed off the source > >> contributions, we could probably remove this section. > > > > Only Twitter's authorized representative may legally remove Twitter's > > copyright notice. Everyone else must leave it alone. > > > > Unless something unusual has occurred (like a new SGA from Twitter in > 2017), > > there should not have been a need to update Twitter's copyright. Josh > was > > right to flag that as weird. > > > > Sijie, I see that it was your commit that changed the copyright year in > > NOTICE. It was correct to update the ASF copyright, so please leave > that as > > 2017 (and continue to updated it in future years). For the Twitter > copyright, > > please either restore the 2016 date or discuss any unusual circumstances. > > (Feel free to ask questions, we're here to help.) > > > Agreed, however this is where it gets complicated (and at least needs to be clear to the contributors, or maybe I'm the only one thinking this is confusing/not obvious). The ASF accepts contributions from individuals, not companies. So while people may contribute to DLog as employees as Twitter, the assumption is that you're doing so with the understanding that these are individual contributions, e.g. you're eligible to license the code under the Apache License. The end date of the NOTICE would always be when the SGA was sent to the ASF, where they allowed us to use their code. ASF's copyright would read the original donation date, however if contributions were applied to the original code base those could be updated to 2017. At least that's been my understanding, feel free to tell me I'm wrong. > > Josh was also right to flag the addition of the "Copyright 2017 The > Apache > > Software Foundation" notices in source headers. > > > > http://www.apache.org/legal/src-headers.html#headers > > > > 2. Each source file should include the following license header -- > note > > that there should be no copyright notice in the header: > > > > For individual files, contributors continue to hold copyright on their > > contributions. The ASF (unlike some other entities such as the FSF) > does not > > require copyright assignment. Thus the ASF only holds copyright in the > > collection; that's what's expressed in the NOTICE file ASF copyright > notice. > > > > Marvin Humphrey > > Marvin -- you said it much better than I could have :). Thank you for > the clarity on this one. > > Sijie, just to clarify, the original request by John to update > DistributedLog's copyright year was _just_ for DistributedLog's > copyright. As Marvin points out, you should never be modifying the > copyright from any bundled software (unless you are changing that > bundled software and the copyright also changed ;)) > > Correct - my intention was that the ASF claim should read 2017 in the NOTICE file. > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
