Thank you, Josh. Will address your comments. On Sun, Apr 9, 2017 at 4:38 PM, Josh Elser <els...@apache.org> wrote:
> -1 (binding) your source releases still do not contain the DISCLAIMER file > that John pointed out in rc2 [1]. > > * mvn apache-rat:check fails on `src/main/resources/DISCLAIMER.bin.txt` * Don't include 'Copyright 2017 The Apache Software Foundation' in the > license headers of your source files. The NOTICE files sufficiently covers > this? * Is the 'Copyright Twitter, 2017' accurate? DistributedLog has been > incubating since 2016, right? Have you included new IP from Twitter since > then? > DLog has been incubating since 2016. But we were asked to update the year in the NOTICE to 2017 in last vote. My question for this is: should the year be the year we started incubating or the year when this release is released? I heard different things from different places. - Sijie > > * sigs/xsums OK > * Can build source releases > > - Josh > > [1] https://lists.apache.org/thread.html/c8694114552717fa4776b54 > 1406c2e294a4c654721647bac86340f3a@%3Cgeneral.incubator.apache.org%3E > > > Sijie Guo wrote: > >> Hi everyone, >> >> Please review and vote on the release candidate #3 for the Apache >> DistributedLog version 0.4.0-incubating, as follows: >> [ ] +1, Approve the release >> [ ] -1, Do not approve the release (please provide specific comments) >> >> The complete staging area is available for your review, which includes: >> >> * JIRA release notes [1], >> * the official Apache source release to be deployed to >> dist.apache.org >> [2], >> * all artifacts to be deployed to the Maven Central Repository [3], >> * source code tag "v0.4.0-incubating-RC1_2.11" (for scala 2.11) and >> "v0.4.0-incubating-RC1_2.10" (for scala 2.10) [4][5], >> * website pull request listing the release [6] and publishing the API >> reference manual. >> >> The Apache DistributedLog community has unanimously approved this release >> [7]. >> >> As customary, the vote will be open for at least 72 hours. It is adopted >> by a >> majority approval with at least three PMC affirmative votes. If approved, >> we >> will proceed with the release. >> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> version=12337980&styleName=&projectId=12320620 >> [2] https://dist.apache.org/repos/dist/dev/incubator/distributed >> log/0.4.0- >> incubating-RC3/ >> [3] https://repository.apache.org/content/repositories/ >> orgapachedistributedlog-1006/ >> [4] https://github.com/apache/incubator-distributedlog/tree/ >> v0.4.0-incubating-RC3_2.11 >> [5] https://github.com/apache/incubator-distributedlog/tree/ >> v0.4.0-incubating-RC3_2.10 >> [6] https://github.com/apache/incubator-distributedlog/pull/109 >> [7] >> http://mail-archives.apache.org/mod_mbox/incubator-distribut >> edlog-dev/201704.mbox/%3CCAO2yDyY7DxeQ0Xnm9sPmXTjwF_yhc8nAHN >> %2B4VxmD7jjGbyoGjQ%40mail.gmail.com%3E >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
