[dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled

2016-04-21 Thread John Daley (johndale)
Hi, When VLAN stripping is disabled, X710 and 82599ES act differently for me in this case when receiving VLAN tagged packets. On 82599ES the flag is set but on X710 the flag not set. Do I maybe have old X710 firmware? Or is it not set for X710 on purpose in this case and instead the flag is us

[dpdk-dev] [PATCH] examples/l2fwd-jobstats: Fix a typo.

2016-04-21 Thread Rami Rosen
Signed-off-by: Rami Rosen --- examples/l2fwd-jobstats/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 9f3a77d..dc17f28 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c

[dpdk-dev] [PATCH 1/1] add writing registers

2016-04-21 Thread Rami Rosen
Change-Id: Iaeeefcbc29d109fef17797d6a888cf2448499646 Signed-off-by: Rami Rosen --- fvlproto/build.sh |4 + fvlproto/config.c |7 + fvlproto/myMakefile | 29 + fvlproto/mybuild.sh |5 + fvlproto/regs.txt | 78 ++ fvlproto/regs.txt.org | 1998

[dpdk-dev] [PATCH v2] kni: don't reassign ethernet address every time an interface goes up

2016-04-21 Thread Igor Ryzhov
Currently every time a KNI interface goes up, its ethernet address is reassigned. After this patch ethernet address is assigned only once, at initialization time. Suggested-by: Sergey Balabanov Signed-off-by: Igor Ryzhov --- v2: - change variable name from dev to net_dev - slightly rewrite comm

[dpdk-dev] [PATCH] kni: don't rewrite ethernet address every time an interface goes up

2016-04-21 Thread Igor Ryzhov
Self nack. Forgot to change variable name from dev to net_dev. Will send v2. > 21 ???. 2016 ?., ? 18:12, Igor Ryzhov ???(?): > > Now every time a KNI interface goes up, its ethernet address is overwritten. > After this patch ethernet address is assigned only once, at initialization > time. >

[dpdk-dev] [PATCH] kni: set kni mac on ioctl_create

2016-04-21 Thread Igor Ryzhov
Hello. I rebased a patch and added Suggested-by string. Check it, please: http://dpdk.org/dev/patchwork/patch/12188/ . Best regards, Igor > 18 ? 2016 ?., ? 5:14, Zhang, Helin ???(?): > > Hi Sergey > >> -Original Message- >> From: de

[dpdk-dev] [PATCH] kni: don't rewrite ethernet address every time an interface goes up

2016-04-21 Thread Igor Ryzhov
Now every time a KNI interface goes up, its ethernet address is overwritten. After this patch ethernet address is assigned only once, at initialization time. Suggested-by: Sergey Balabanov Signed-off-by: Igor Ryzhov --- lib/librte_eal/linuxapp/kni/kni_misc.c | 10 ++ lib/librte_eal/linu

[dpdk-dev] Pktgen rate issue

2016-04-21 Thread Iñaki Murillo
Hello Keith, I sent the patch as it is described in http://dpdk.org/dev but I got confused and I did not put that it was a patch for Pktgen. I hope it does not make anyone get confused. Thank you, I?aki Murillo El 21/04/16 a las 16:28, Wiles, Keith escribi?: >> Hello Keith, >> >> I have

[dpdk-dev] [PATCH] Rate as a decimal number

2016-04-21 Thread inaki.murillo
Currently Pktgen does not accept a decimal number for the rate. This patch makes possible to set a decimal number as a rate. Signed-off-by: I?aki Murillo Arroyo --- app/cmd-functions.c| 71 +- app/cmd-functions.h| 38 + app/lpktgenlib.c |2 +- app/pktgen-cmds.c | 10

[dpdk-dev] [PATCH 1/1] add writing registers

2016-04-21 Thread Rosen, Rami
Please ignore, this is a wrong patch -Original Message- From: Rosen, Rami Sent: Thursday, April 21, 2016 8:24 PM To: dev at dpdk.org Cc: Rosen, Rami Subject: [PATCH 1/1] add writing registers Change-Id: Iaeeefcbc29d109fef17797d6a888cf2448499646 Signed-off-by: Rami Rosen --- fvlproto/

[dpdk-dev] [dpdk-users] DPDK 16.04 link changes cause PMD drivers to not be loaded

2016-04-21 Thread Thomas Monjalon
2016-04-21 08:01, Aurojit Panda: > Panu Matilainen wrote: [...] > > Again, PMDs are *plugins* that are *meant* to be loaded at runtime. > > That allows for all sorts of flexibility especially > > for packaging and shipping, at some extra cost in setup complexity. > > I am all for a plugin architec

[dpdk-dev] [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux PF hosts

2016-04-21 Thread Björn Töpel
On Linux PF hosts, the VF has no means of changing the HW CRC strip setting for a RX queue. It's implicitly enabled. This patch checks if the host is running a Linux PF kernel driver, and returns an error, if HW CRC stripping was disabled. Signed-off-by: Bj?rn T?pel --- drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH] Rate as a decimal number

2016-04-21 Thread Wiles, Keith
>Currently Pktgen does not accept a decimal number for the rate. This patch >makes possible to set a decimal number as a rate. > >Signed-off-by: I?aki Murillo Arroyo >--- > app/cmd-functions.c| 71 +- > app/cmd-functions.h| 38 + > app/lpktgenlib.c |2 +- > app/pktgen-cmds.c

[dpdk-dev] [PATCH] ixgbe: configure VLAN TPID

2016-04-21 Thread Beilei Xing
The patch enables configuring the ether types of both inner and outer VLANs. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/ixgbe_ethdev.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixg

[dpdk-dev] [PATCH] e1000: configure VLAN TPID

2016-04-21 Thread Beilei Xing
This patch enables configuring the ether types of both inner and outer VLANs. Note that TPID of single or inner VLAN is read only. Signed-off-by: Beilei Xing --- drivers/net/e1000/igb_ethdev.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a

[dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_rx

2016-04-21 Thread Bruce Richardson
On Thu, Apr 21, 2016 at 03:44:03PM +0100, Kulasek, TomaszX wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Thursday, April 21, 2016 15:52 > > To: Kulasek, TomaszX > > Cc: dev at dpdk.org; Zhang, Helin ; Ananyev, > > Konstantin > > Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] Pktgen rate issue

2016-04-21 Thread Iñaki Murillo
Hello Keith, I have done a patch to the pktgen, but I not sure how to submit it. I would be very grateful if you give me some advice on how to contribute. Thank you, I?aki Murillo El 12/04/16 a las 14:55, Wiles, Keith escribi?: >> Hello >> >> I have been using pktgen for a while and I rel

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Christian Ehrhardt
Thanks Ilya, yeah we usually wait for the point releases as they undergo some extra testing and verification. .1 shouldn't be too much into the future I guess. Thanks a lot for identifying. That said, I'd still go on with Yuanhan to finalize the dpdk side leak fix we identified, so we eventually g

[dpdk-dev] [PATCH] virtio: fix segfault when transmit pkts

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 12:36:10PM +, Jianfeng Tan wrote: > Issue: when using virtio nic to transmit pkts, it causes segment fault. Jianfeng, It's good to describe the issues, steps to reproduce it and how to fix it. But you don't have to tell it like filling a form. Instead, you could try to

[dpdk-dev] [PATCH] i40e: fix packet stats getting

2016-04-21 Thread Bruce Richardson
On Tue, Apr 19, 2016 at 07:21:16AM +0100, Zhang, Helin wrote: > > > > -Original Message- > > From: Wu, Jingjing > > Sent: Tuesday, April 19, 2016 2:11 PM > > To: Richardson, Bruce > > Cc: dev at dpdk.org; Wu, Jingjing ; Zhang, Helin > > > > Subject: [PATCH] i40e: fix packet stats gettin

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 02:56:36AM +, Jianfeng Tan wrote: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. > > Configured parameters include: > - rx (optional, 1 by default), number of rx, not used for now. > - tx (optional, 1 by default), numb

[dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30690: Bad bit shift operation large_shift: In expression 1ULL << i, left shifting by more than 63 bits has undefined behavior. The shift amount, i, is as much as 127. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-

[dpdk-dev] [PATCH v3] examples/qos_sched: fix copy-paste error

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30699: Copy-paste error; rx_port in pconf->rx_port looks like a copy-paste error. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_sched/args.c | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH v3] examples/qos_sched: fix negative loop bound

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30704: Negative loop bound negative_returns: Using unsigned variable n_tokens in a loop exit condition. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_sched/args.c | 2 +- 1

[dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop

2016-04-21 Thread Bruce Richardson
On Fri, Apr 15, 2016 at 01:31:03AM +, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > > Sent: Thursday, April 14, 2016 6:00 PM > > To: Zhang, Helin; Ananyev, Konstantin > > Cc: dev at dpdk.org; Azarewicz, P

[dpdk-dev] [PATCH v2] fm10k: set packet type for multi-segment packets

2016-04-21 Thread Bruce Richardson
On Mon, Apr 18, 2016 at 02:05:23PM +, Chen, Jing D wrote: > Hi, > > > -Original Message- > > From: Michael Frasca [mailto:michael.frasca at oracle.com] > > Sent: Monday, April 18, 2016 8:52 PM > > To: Chen, Jing D > > Cc: dev at dpdk.org; Michael Frasca > > Subject: [PATCH v2] fm10k:

[dpdk-dev] [PATCH v3 1/2] virtio/vdev: add embeded device emulation

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 02:56:35AM +, Jianfeng Tan wrote: > Background: Previously, we usually use a virtio device in QEMU/VM's > context as below pic shows. Virtio nic is emulated in QEMU, and usually > presented in VM as a PCI device. > > |---| > | vm| > |---| (over P

[dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_tx

2016-04-21 Thread Bruce Richardson
On Mon, Apr 18, 2016 at 01:58:02AM +, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Kulasek > > Sent: Friday, April 15, 2016 10:33 PM > > To: dev at dpdk.org > > Cc: Zhang, Helin; Ananyev, Konstantin > > Subject: [d

[dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_rx

2016-04-21 Thread Bruce Richardson
On Fri, Apr 15, 2016 at 03:39:09PM +0200, Tomasz Kulasek wrote: > CID 13193 (#1 of 1): Bad bit shift operation (BAD_SHIFT) > large_shift: In expression 1 << pool, left shifting by more than 31 bits > has undefined behavior. The shift amount, pool, is at least 32. > > This patch limits mask shift t

[dpdk-dev] [PATCH 0/6] fix i40e problematic dereference

2016-04-21 Thread Thomas Monjalon
> > 2016-04-21 11:42, Helin Zhang: > > > It fixes several problematic dereferences in i40e driver, reported by > > > Coverity. > > > > > > Helin Zhang (6): > > > i40e: fix problematic dereference > > > i40e: fix problematic dereference > > > i40e: fix problematic dereference > > > i40e: fix

[dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_rx

2016-04-21 Thread Kulasek, TomaszX
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, April 21, 2016 15:52 > To: Kulasek, TomaszX > Cc: dev at dpdk.org; Zhang, Helin ; Ananyev, > Konstantin > Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix bad shift operation in > ixgbe_set_pool_rx > > On Fri, Apr 15, 2016 at 0

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-21 Thread Thomas Monjalon
2016-04-21 08:08, Neil Horman: > On Thu, Apr 21, 2016 at 09:27:18AM +0200, David Marchand wrote: > > I don't mind doing trivial changes, but I don't have time for more on > > this series. > > > Um, I'm not sure what to say here. The whole point of review is to help > improve > the code. If you

[dpdk-dev] Pktgen rate issue

2016-04-21 Thread Wiles, Keith
>Hello Keith, > >I have done a patch to the pktgen, but I not sure how to submit it. I >would be very grateful if you give me some advice on how to contribute. Please have a look at the DPDK.org page on development : http://dpdk.org/dev You could send me the patch on the current Pktgen and I can

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Ilya Maximets
Hi, Christian. You're, likely, using tar archive with openvswitch from openvswitch.org. It doesn't contain many bug fixes from git/branch-2.5 unfortunately. The problem that you are facing has been solved in branch-2.5 by commit d9df7b9206831631ddbd90f9cbeef1b4fc5a8e89 Author: Ilya Maximets Date

[dpdk-dev] [PATCH] eal: fix unchecked return value from library

2016-04-21 Thread Daniel Mrzyglod
Fix issue reported by Coverity. Coverity ID 13194 The function returns a value that indicates an error condition. If this is not checked, the error condition may not be handled correctly. In pci_vfio_mp_sync_thread: Value returned from a library function is not checked for errors before being us

[dpdk-dev] [PATCH v2] examples/qos_sched: fix out-of-bounds read

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30708: Out-of-bounds read overrun-local: Overrunning array tokens of 8 8-byte elements at element index 4294967294 (byte offset 34359738352) using index i (which evaluates to 4294967294). Fixes: de3cfa2c9823 ("sched: initial i

[dpdk-dev] [PATCH v2] examples/qos_meter: fix unchecked return value

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30693: Unchecked return value check_return: Calling rte_meter_srtcm_config without checking return value. Fixes: e6541fdec8b2 ("meter: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_meter/main.c | 15 ++

[dpdk-dev] [PATCH 0/6] fix i40e problematic dereference

2016-04-21 Thread Zhang, Helin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, April 21, 2016 7:02 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/6] fix i40e problematic dereference > > On Thu, Apr 21, 2016 at 11:42:51AM +0800, Helin Zhang wrote: > > It fixes several p

[dpdk-dev] [PATCH 0/6] fix i40e problematic dereference

2016-04-21 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, April 21, 2016 6:07 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/6] fix i40e problematic dereference > > 2016-04-21 11:42, Helin Zhang: > > It fixes sev

[dpdk-dev] [PATCH] virtio: fix segfault when transmit pkts

2016-04-21 Thread Jianfeng Tan
Issue: when using virtio nic to transmit pkts, it causes segment fault. How to reproduce: a. start testpmd with vhost. $testpmd -c 0x3 -n 4 --socket-mem 1024,0 --no-pci \ --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' -- -i --nb-cores=1 b. start a qemu with a virtio nic connected with the vhost-u

[dpdk-dev] [PATCH v2] mem: fix freeing of memzone used by ivshmem

2016-04-21 Thread Sergio Gonzalez Monroy
On 15/04/2016 09:29, Mauricio Vasquez B wrote: > although previous implementation returned an error when trying to release a > memzone assigned to an ivshmem device, it stills freed it. > > Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") > > Signed-off-by: Mauricio Vasquez B studenti.polito.it> >

[dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak

2016-04-21 Thread Sergio Gonzalez Monroy
On 20/04/2016 10:15, David Marchand wrote: > On Tue, Apr 19, 2016 at 6:27 PM, Marcin Kerlin > wrote: >> Fix issue reported by Coverity. >> >> Coverity ID 13295, 13296, 13303: >> Resource leak: The system resource will not be reclaimed >> and reused, reducing the future availability of the resourc

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-21 Thread Thomas Monjalon
2016-04-21 11:00, Bruce Richardson: > On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > > It's not for testing, more for code review and to help understand the code > > > [though > > > as you say, we do need to ensure that each commit doesn't actually break > > > the > > > build]. >

[dpdk-dev] [PATCH 0/6] fix i40e problematic dereference

2016-04-21 Thread Thomas Monjalon
2016-04-21 11:42, Helin Zhang: > It fixes several problematic dereferences in i40e driver, > reported by Coverity. > > Helin Zhang (6): > i40e: fix problematic dereference > i40e: fix problematic dereference > i40e: fix problematic dereference > i40e: fix problematic dereference > i40e:

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread Thomas Monjalon
2016-04-21 02:56, Jianfeng Tan: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. Why this name eth_cvio? Why the prefix eth_? The virtio-net driver uses a kernel device. Here it is a userland device. Why not virtio-user? > .. table:: Features availab

[dpdk-dev] [PATCH 0/6] fix i40e problematic dereference

2016-04-21 Thread Bruce Richardson
On Thu, Apr 21, 2016 at 11:42:51AM +0800, Helin Zhang wrote: > It fixes several problematic dereferences in i40e driver, > reported by Coverity. > > Helin Zhang (6): > i40e: fix problematic dereference > i40e: fix problematic dereference > i40e: fix problematic dereference > i40e: fix prob

[dpdk-dev] [RFC PATCH 0/2] performance utility in testpmd

2016-04-21 Thread Bruce Richardson
On Thu, Apr 21, 2016 at 11:54:12AM +0200, Thomas Monjalon wrote: > 2016-04-20 18:43, Zhihong Wang: > > This RFC patch proposes a general purpose forwarding engine in testpmd > > namely "portfwd", to enable performance analysis and tuning for poll mode > > drivers in vSwitching scenarios. > > > >

[dpdk-dev] [RFC PATCH 0/2] performance utility in testpmd

2016-04-21 Thread Thomas Monjalon
2016-04-20 18:43, Zhihong Wang: > This RFC patch proposes a general purpose forwarding engine in testpmd > namely "portfwd", to enable performance analysis and tuning for poll mode > drivers in vSwitching scenarios. > > > Problem statement > - > > vSwitching is more I/O bound in

[dpdk-dev] Couple of PMD questions

2016-04-21 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 10:47:59AM -0500, Jay Rolette wrote: > On Wed, Apr 20, 2016 at 9:05 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Wed, Apr 20, 2016 at 07:22:57AM -0500, Jay Rolette wrote: > > > On Wed, Apr 20, 2016 at 4:10 AM, Bruce Richardson < > > > bruce.richar

[dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak

2016-04-21 Thread Kerlin, MarcinX
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Thursday, April 21, 2016 1:19 PM > To: David Marchand > Cc: dev at dpdk.org; Kerlin, MarcinX > Subject: Re: [PATCH 1/1] lib/librte_eal: fix resource leak > > On 20/04/2016 10:15, David Marchand wrote: > > On Tue, Apr 19, 2016 a

[dpdk-dev] [PATCH 6/6] i40e: fix problematic dereference

2016-04-21 Thread Helin Zhang
Fix issue reported by Coverity. Coverity ID 13265: Missing break in switch. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_pf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c

[dpdk-dev] [PATCH 5/6] i40e: fix problematic dereference

2016-04-21 Thread Helin Zhang
Fix issue reported by Coverity. Coverity ID 13298: Dereference before null check. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_pf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_pf.c b/driv

[dpdk-dev] [PATCH 4/6] i40e: fix problematic dereference

2016-04-21 Thread Helin Zhang
Fix issue reported by Coverity. Coverity ID 13299: Dereference before null check. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_pf.c b/driver

[dpdk-dev] [PATCH 3/6] i40e: fix problematic dereference

2016-04-21 Thread Helin Zhang
Fix issue reported by Coverity. Coverity ID 13294: Dereference before null check. Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40

[dpdk-dev] [PATCH 2/6] i40e: fix problematic dereference

2016-04-21 Thread Helin Zhang
Fix issue reported by Coverity. Coverity ID 13301: Dereference before null check. Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40

[dpdk-dev] [PATCH 1/6] i40e: fix problematic dereference

2016-04-21 Thread Helin Zhang
Fix issue reported by Coverity. Coverity ID 119267: Dereference before null check. Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_rxtx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH 0/6] fix i40e problematic dereference

2016-04-21 Thread Helin Zhang
It fixes several problematic dereferences in i40e driver, reported by Coverity. Helin Zhang (6): i40e: fix problematic dereference i40e: fix problematic dereference i40e: fix problematic dereference i40e: fix problematic dereference i40e: fix problematic dereference i40e: fix problemat

[dpdk-dev] ixgbe : query regarding your code changes for VF mac add

2016-04-21 Thread santosh
Hi Ivan and team, Please respond to my last mail and let me know if there is any alternate way to handle this. Our release is in pending due to this issue. Thanks & Regards Santosh On Wed, Apr 20, 2016 at 2:35 PM, santosh wrote: > Hi Ivan, > > Thanks for your response. > > Let me explain you

[dpdk-dev] Couple of PMD questions

2016-04-21 Thread Andriy Berestovskyy
Hi Jay, Max RX frame size and buffer size are independent bits. You may set MAXFRS to 9K and feed 512B buffers or vice versa. The issue is that you are trying to tune both of the options to avoid buf chains. Here is another way to enable jumbo frames and avoid buf chains: 1. Disable scattering and

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Christian Ehrhardt
Hi, I can follow your argument that - and agree that in this case the leak can't be solved your patch. Still I found it useful to revise it along our discussion as eventually it will still be a good patch to have. I followed your suggestion and found: - rte_vhost_driver_register callocs vserver (im

[dpdk-dev] [PATCH] eal: fix unchecked return value from library

2016-04-21 Thread Burakov, Anatoly
> Fix issue reported by Coverity. > Coverity ID 13194 > > The function returns a value that indicates an error condition. If this is > not > checked, the error condition may not be handled correctly. > > In pci_vfio_mp_sync_thread: Value returned from a library function is not > checked for err

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-04-21 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 04:43:44PM +, Harish Patil wrote: > > >On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote: > >> 2016-04-20 00:14, Harish Patil: > >> > >2016-03-31 19:15, Rasesh Mody: > >> > >> --- a/config/common_base > >> > >> +++ b/config/common_base > >> > >> +CONFIG_RT

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-21 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > It's not for testing, more for code review and to help understand the code > > [though > > as you say, we do need to ensure that each commit doesn't actually break > > the > > build]. > > Right now, the driver code goes in as a singl

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread David Marchand
Hello, On Thu, Apr 21, 2016 at 4:56 AM, Jianfeng Tan wrote: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. > > Configured parameters include: > - rx (optional, 1 by default), number of rx, not used for now. > - tx (optional, 1 by default), numbe

[dpdk-dev] [PATCH v3 00/13] kill global pci device id list

2016-04-21 Thread David Marchand
On Wed, Apr 20, 2016 at 2:43 PM, David Marchand wrote: > - not storing the pci ids in a dedicated section anymore, pci drivers are > exported and parsed by a quickly written (and naive) tool Rethinking about this, this part won't do. Stripping symbols breaks it, and I had to go some gymnastics

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 04:04:03PM +0200, Christian Ehrhardt wrote: > Thanks Ilya, > yeah we usually wait for the point releases as they undergo some extra testing > and verification. > .1 shouldn't be too much into the future I guess. > Thanks a lot for identifying. > > That said, I'd still go on

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 02:01:26PM +0300, Ilya Maximets wrote: > Hi, Christian. > You're, likely, using tar archive with openvswitch from openvswitch.org. > It doesn't contain many bug fixes from git/branch-2.5 unfortunately. > > The problem that you are facing has been solved in branch-2.5 by >

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-21 Thread David Marchand
On Wed, Apr 20, 2016 at 8:15 PM, Neil Horman wrote: > On Wed, Apr 20, 2016 at 03:39:59PM +0200, David Marchand wrote: >> On Wed, Apr 20, 2016 at 3:29 PM, Neil Horman >> wrote: >> >> +#ifndef RTE_PCI_DEV_ID_DECL_EM >> >> +#define RTE_PCI_DEV_ID_DECL_EM(vend, dev) >> >> +#endif >> >> + >> >> +#ifn

[dpdk-dev] [PATCH 1/6] i40e: fix problematic dereference

2016-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2016 11:42:52 +0800 Helin Zhang wrote: > Fix issue reported by Coverity. > > Coverity ID 119267: Dereference before null check. > > Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") > > Signed-off-by: Helin Zhang > --- > drivers/net/i40e/i40e_rxtx.c | 10 +- >

[dpdk-dev] [PATCH] eal: fix unchecked return value from library

2016-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2016 13:56:57 +0200 Daniel Mrzyglod wrote: > + if (setsockopt(conn_sock, SOL_SOCKET, SO_LINGER, &l, sizeof(l)) > < 0) > + RTE_LOG(ERR, EAL, "Cannot set SO_LINGER option " > + "on listen socket (%s)\n", > strerror

[dpdk-dev] [dpdk-users] DPDK 16.04 link changes cause PMD drivers to not be loaded

2016-04-21 Thread Aurojit Panda
[The original report is included below for your convenience] Thomas Monjalon wrote: > 2016-04-21 08:01, Aurojit Panda: >> Panu Matilainen wrote: > [...] >>> Again, PMDs are *plugins* that are *meant* to be loaded at runtime. >>> That allows for all sorts of flexibility especially >>> for packaging

[dpdk-dev] [dpdk-users] DPDK 16.04 link changes cause PMD drivers to not be loaded

2016-04-21 Thread Aurojit Panda
Thomas Monjalon wrote: > 2016-04-21 08:01, Aurojit Panda: >> Panu Matilainen wrote: > [...] >>> Again, PMDs are *plugins* that are *meant* to be loaded at runtime. >>> That allows for all sorts of flexibility especially >>> for packaging and shipping, at some extra cost in setup complexity. >> I

[dpdk-dev] [PATCH v3 00/13] kill global pci device id list

2016-04-21 Thread Neil Horman
On Thu, Apr 21, 2016 at 10:07:51AM +0200, David Marchand wrote: > On Wed, Apr 20, 2016 at 2:43 PM, David Marchand > wrote: > > - not storing the pci ids in a dedicated section anymore, pci drivers are > > exported and parsed by a quickly written (and naive) tool > > Rethinking about this, this

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-21 Thread Neil Horman
On Thu, Apr 21, 2016 at 09:27:18AM +0200, David Marchand wrote: > On Wed, Apr 20, 2016 at 8:15 PM, Neil Horman wrote: > > On Wed, Apr 20, 2016 at 03:39:59PM +0200, David Marchand wrote: > >> On Wed, Apr 20, 2016 at 3:29 PM, Neil Horman > >> wrote: > >> >> +#ifndef RTE_PCI_DEV_ID_DECL_EM > >> >>

[dpdk-dev] [dpdk-users] DPDK 16.04 link changes cause PMD drivers to not be loaded

2016-04-21 Thread Aurojit Panda
[Cross-posting to dev] Panu Matilainen wrote: > On 04/20/2016 05:26 PM, Aurojit Panda wrote: >> I am sorry that is a bit unintuitive considering: >> >> (a) This behavior differs between static and shared builds of DPDK. >> - In fact this behavior was identical in 2.2, and even in mainline >> befor

[dpdk-dev] [PATCH v2] examples/qos_sched: fix negative loop bound

2016-04-21 Thread Michal Jastrzebski
Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:35 +0200 Message-Id: <1461239256-8104-4-git-send-email-michalx.k.jastrzebski at intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski at intel.com> References: <1461239256-8104-1-

[dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error

2016-04-21 Thread Michal Jastrzebski
Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:34 +0200 Message-Id: <1461239256-8104-3-git-send-email-michalx.k.jastrzebski at intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski at intel.com> References: <1461239256-8104-1-

[dpdk-dev] [PATCH v2] examples/qos_sched: fix bad bit shift operation

2016-04-21 Thread Michal Jastrzebski
Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:33 +0200 Message-Id: <1461239256-8104-2-git-send-email-michalx.k.jastrzebski at intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski at intel.com> References: <1461239256-8104-1-

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread Jianfeng Tan
Add a new virtual device named eth_cvio, it can be used just like eth_ring, eth_null, etc. Configured parameters include: - rx (optional, 1 by default), number of rx, not used for now. - tx (optional, 1 by default), number of tx, not used for now. - cq (optional, 0 by default), not supported

[dpdk-dev] [PATCH v3 1/2] virtio/vdev: add embeded device emulation

2016-04-21 Thread Jianfeng Tan
Background: Previously, we usually use a virtio device in QEMU/VM's context as below pic shows. Virtio nic is emulated in QEMU, and usually presented in VM as a PCI device. |---| | vm| |---| (over PCI bus or MMIO or Channel I/O) |QEMU | -> device emulation |--

[dpdk-dev] [PATCH v3 0/2] virtio support for container

2016-04-21 Thread Jianfeng Tan
v3: - Remove --single-file option; do no change at EAL memory. - Remove the added API rte_eal_get_backfile_info(), instead we check all opened files with HUGEFILE_FMT to find hugepage files owned by DPDK. - Accordingly, add more restrictions at "Known issue" section. - Rename parameter from