Re: [dpdk-dev] rte_hash thread safe

2018-04-24 Thread Shyam Shrivastav
You can look at hash table support under librte_table, we are using it for tcp stateful and syncache table (16 bytes key), supports optimized burst look ups, pretty good performance at line rate with up to half a billion entries in syn cache lru table and 33 million in flows ext table. However the

Re: [dpdk-dev] [PATCH 1/2] eal: fix potential negative return

2018-04-24 Thread Tan, Jianfeng
On 4/17/2018 11:42 PM, Anatoly Burakov wrote: Value returned by rte_socket_id_by_idx() may be negative, which would result in negative array index access. Coverity issue: 272600 Fixes: b666f17858a3 ("mem: read hugepage counts from node-specific sysfs path") Cc: anatoly.bura...@intel.com Sign

[dpdk-dev] [PATCH] eventdev: convert eth Rx adapter files to SPDX license tag

2018-04-24 Thread Nikhil Rao
Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.h | 32 +++--- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 2 files changed, 7 insertions(+), 29 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_even

Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup

2018-04-24 Thread Zhang, Qi Z
Hi Thomas: > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 25, 2018 3:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Xing, Beilei ; Wu, Jingjing ; > Lu, Wenzhuo ; Yigit, Ferruh > ; Doherty, Declan > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver

2018-04-24 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command > interface driver > > Signed-off-by: Nipun Gup

Re: [dpdk-dev] [PATCH v4 05/20] net/virtio: dump packed virtqueue data

2018-04-24 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann > Sent: Thursday, April 19, 2018 3:08 PM > To: dev@dpdk.org > Cc: Bie, Tiwei ; y...@fridaylinux.org; > maxime.coque...@redhat.com; m...@redhat.com; j...@freimann.org > Subject: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI devices too

2018-04-24 Thread Shreyansh Jain
Hi Nipun, Apologies for delay in review. 2 quick comments inline. > -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 3/9] bus/fslmc: keep Tx qu

[dpdk-dev] [PATCH v3 5/5] doc: update guides for current preferrred log level syntax

2018-04-24 Thread Stephen Hemminger
Use symbolic names and match rather than numbers and regex in the guides. Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/dpaa2_sec.rst | 2 +- doc/guides/cryptodevs/dpaa_sec.rst | 2 +- doc/guides/faq/faq.rst | 23 ++- doc/guides/nics/dpaa2.rst

[dpdk-dev] [PATCH v3 1/5] eal: make syslog facility table const

2018-04-24 Thread Stephen Hemminger
The mapping fro facility name to value can be const. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index

[dpdk-dev] [PATCH v3 3/5] eal: make eal_log_level save private

2018-04-24 Thread Stephen Hemminger
We don't want format of eal log level saved values to be visible in ABI. Move to private storage in eal_common_log. Includes minor optimization. Compile the regular expression for each log match once, rather than each time it is used. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/e

[dpdk-dev] [PATCH v3 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Stephen Hemminger
Regular expressions are not the best way to match a hierarchical pattern like dynamic log levels. And the separator for dynamic log levels is period which is the regex wildcard character. A better solution is to use filename matching 'globbing' so that log levels match like file paths. For compati

[dpdk-dev] [PATCH v3 2/5] eal: allow symbolic log levels

2018-04-24 Thread Stephen Hemminger
Much easeier to remember names than numbers. Allows --log-level=pmd.net.ixgbe.*,debug Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 67 -- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v3 0/5] log level control enhancements

2018-04-24 Thread Stephen Hemminger
This patch set improves the log-level option in EAL. It adds symbolic names for log levels (error, info, debug, etc) and shell style matching of log levels. --log-level='pmd.ixgbe.*:debug' The original syntax (which is maintained for compatibility) used numeric values, comma as separator and re

[dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attached, refcnt of the direct mbuf would be 2 as

[dpdk-dev] [PATCH v5 2/2] app/testpmd: conserve offload flags of mbuf

2018-04-24 Thread Yongseok Koh
This patch is to accommodate an experimental feature of mbuf - external buffer attachment. If mbuf is attached to an external buffer, its ol_flags will have EXT_ATTACHED_MBUF set. Without enabling/using the feature, everything remains same. If PMD delivers Rx packets with non-direct mbuf, ol_flags

Re: [dpdk-dev] [PATCH v2] eal: abstract away the auxiliary vector

2018-04-24 Thread Thomas Monjalon
11/04/2018 23:34, Thomas Monjalon: > Anyone to review, please? > > 02/04/2018 20:24, Aaron Conole: > > Rather than attempting to load the contents of the auxv directly, > > prefer to use an exposed API - and if that doesn't exist then attempt > > to load the vector. This is because on some system

[dpdk-dev] [PATCH] vhost: fix vDPA set features

2018-04-24 Thread Xiao Wang
We should call set_features callback after setting features in virtio_net structure, otherwise vDPA driver cannot get the right features. Fixes: 07718b4f87aa ("vhost: adapt library for selective datapath") Signed-off-by: Xiao Wang --- lib/librte_vhost/vhost_user.c | 10 +- 1 file change

Re: [dpdk-dev] [PATCH v1 2/2] eal: add last init priority

2018-04-24 Thread Thomas Monjalon
> > Add the priority RTE_PRIORITY_LAST, used for initialization routines > > meant to be run after all other constructors. > > > > This priority becomes the default priority for all DPDK constructors. > > > > Signed-off-by: Gaetan Rivet > > --- > > Acked-by: Shreyansh Jain Applied, thanks

Re: [dpdk-dev] TCP GSO support above IPv6

2018-04-24 Thread Hu, Jiayu
Hi, > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 7:13 AM > To: Hu, Jiayu ; dev@dpdk.org; Mark Kavanagh > > Cc: Thomas Monjalon ; Olga Shern > > Subject: RE: TCP GSO support above IPv6 > > Hi, > Please see inline > > > -Origin

Re: [dpdk-dev] [PATCH v5 00/10] devargs cleanup

2018-04-24 Thread Thomas Monjalon
> Gaetan Rivet (10): > devargs: introduce iterator > bus/vdev: do not reference devargs list > bus/pci: do not reference devargs list > net/vdev_netvsc: do not reference devargs list > test: remove devargs unit tests > devargs: make devargs list private > devargs: make parsing variadi

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Hu, Jiayu
Hi Ophir, > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 9:53 PM > To: Hu, Jiayu ; Ananyev, Konstantin > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking

Re: [dpdk-dev] [PATCH v5 10/10] devargs: rename legacy API

2018-04-24 Thread Thomas Monjalon
24/04/2018 01:54, Gaetan Rivet: > + struct rte_devargs da = {0}; It fails with clang. I suggest replacing with memset.

Re: [dpdk-dev] [PATCH v2 9/9] doc: add dpaa2 command interface rawdev to release notes

2018-04-24 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 9/9] doc: add dpaa2 command interface rawdev to > release notes > > Signed-off-by: Nipun Gupt

[dpdk-dev] [PATCH] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-24 Thread Qi Zhang
After add RSS hash offload check, default rss_hf will fail on devices that not support all bits, the patch introduce RSS negotiate flag, when it is set, RSS configuration will negotiate with device capability. By default negotiate is turn on, so it will not break exist PMD. It can be disabled by "-

Re: [dpdk-dev] [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI devices too

2018-04-24 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI > devices too > > The DPCI devices have o

Re: [dpdk-dev] [PATCH v5 05/10] test: remove devargs unit tests

2018-04-24 Thread Thomas Monjalon
24/04/2018 01:54, Gaetan Rivet: > --- > MAINTAINERS | 1 - > test/test/Makefile | 1 - > test/test/test_devargs.c | 103 > --- > 3 files changed, 105 deletions(-) > delete mode 100644 test/test/test_devargs.c The file must be re

Re: [dpdk-dev] [PATCH v2 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Thomas Monjalon
24/04/2018 18:58, Stephen Hemminger: > +/* set log level based on glob (file match) pattern */ > +int > +rte_log_set_level_pattern(const char *pattern, uint32_t level) This new function is not listed in the map file.

Re: [dpdk-dev] [PATCH v2 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Thomas Monjalon
24/04/2018 18:58, Stephen Hemminger: > /* enable all PMD logs (whose identifier string starts with "pmd") */ > - rte_log_set_level_regexp("pmd.*", RTE_LOG_DEBUG); > + rte_log_set_level_match("pmd.*", RTE_LOG_DEBUG); The function name in the doc above does not match (sic) the new function name be

Re: [dpdk-dev] [PATCH v2 3/5] eal: make eal_log_level save private

2018-04-24 Thread Thomas Monjalon
24/04/2018 18:58, Stephen Hemminger: > +int rte_eal_log_save_regexp(const char *regex, int tmp) The prefix rte_log_ is preferred over rte_eal_log_.

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 09:15:38PM +0200, Olivier Matz wrote: > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > Hi Andrew, Yongseok, > > > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > > On 04/2

Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2018 01:03:20 +0200 Thomas Monjalon wrote: > 25/04/2018 00:52, Stephen Hemminger: > > On Wed, 25 Apr 2018 01:16:53 +0300 > > Arnon Warshavsky wrote: > > > > > This patch adds a new function that is called > > > per every checked patch, > > > and alerts for new instances of rte_

Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Thomas Monjalon
25/04/2018 00:52, Stephen Hemminger: > On Wed, 25 Apr 2018 01:16:53 +0300 > Arnon Warshavsky wrote: > > > This patch adds a new function that is called > > per every checked patch, > > and alerts for new instances of rte_panic/rte_exit. > > The check excludes comments, and alerts in the case > >

Re: [dpdk-dev] [PATCH v2 0/6] mempool: add bucket driver

2018-04-24 Thread Thomas Monjalon
Can we have this patchset in 18.05-rc1? Or is it candidate to rc2? 16/04/2018 15:33, Andrew Rybchenko: > The patch series adds bucket mempool driver which allows to allocate > (both physically and virtually) contiguous blocks of objects and adds > mempool API to do it. It is still capable to provi

Re: [dpdk-dev] [PATCH v3 0/5] fix control thread affinities

2018-04-24 Thread Thomas Monjalon
> Olivier Matz (5): > eal: use sizeof to avoid a double use of a define > eal: new function to create control threads > eal: set name when creating a control thread > eal: set affinity for control threads > examples: use new API to create control threads Applied, thanks

Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2018 01:16:53 +0300 Arnon Warshavsky wrote: > This patch adds a new function that is called > per every checked patch, > and alerts for new instances of rte_panic/rte_exit. > The check excludes comments, and alerts in the case > of a positive balance between additions and removals.

Re: [dpdk-dev] [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver

2018-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2018 01:16:44 +0300 Arnon Warshavsky wrote: > replace panic calls with log and return value. > Local functions to this file, > changing from void to int are non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- >

Re: [dpdk-dev] [PATCH] app/test: fix shared library build failure

2018-04-24 Thread Thomas Monjalon
title changed to "test/power: fix build with shared library" 25/04/2018 00:10, Reshma Pattan: > Using private api `guest_channel_host_connect()` > will cause shared library build failure. Adding the log: test_power_kvm_vm.c:(.text+0x2cb): undefined reference to `guest_chan

Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests

2018-04-24 Thread Pattan, Reshma
Hi Thomas, I sent it few mins back. Can you check and apply Thanks, Reshma > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, April 24, 2018 11:34 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; Hunt, David ; Richardson, Bruce > ; Parthasarathy, Jana

Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests

2018-04-24 Thread Thomas Monjalon
24/04/2018 14:51, Pattan, Reshma: > From: Hunt, David > > On 24/4/2018 12:23 PM, Pattan, Reshma wrote: > > > From: Richardson, Bruce > > >> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote: > > >>> 11/04/2018 16:14, Reshma Pattan: > > Unit Testcases are added for power_acpi_cpu_

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > On 04/24/2018 04:38 AM, Yongseok Koh wrote: [...] > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 06eceba37..7f6507a66 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbu

[dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Arnon Warshavsky
This patch adds a new function that is called per every checked patch, and alerts for new instances of rte_panic/rte_exit. The check excludes comments, and alerts in the case of a positive balance between additions and removals. Signed-off-by: Arnon Warshavsky --- devtools/checkpatches.sh | 95 +

[dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Thread function removes the noreturn attribute. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/e

[dpdk-dev] [PATCH v7 10/11] eal: replace rte_panic instances in init sequence

2018-04-24 Thread Arnon Warshavsky
Change some local functions return type from void to int. This change does not break ABI as the functions are internal. Panic thrown from threads was not handled in this patch Signed-off-by: Arnon Warshavsky --- lib/librte_eal/bsdapp/eal/eal.c | 78 +++ lib/librte_e

[dpdk-dev] [PATCH v7 09/11] eal: replace rte_panic instances in ethdev

2018-04-24 Thread Arnon Warshavsky
Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_ether/rte_ethdev.c | 42 ++ lib/librte_ether/rte_ethdev.h | 4 +++- 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/

[dpdk-dev] [PATCH v7 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 + 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/lin

[dpdk-dev] [PATCH v7 06/11] kni: replace rte_panic instances in kni

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_kni/rte_kni.c | 18 -- lib/librte_kni/rte_kni_fifo.h | 11 --- 2 files changed, 20 insertions(+),

[dpdk-dev] [PATCH v7 05/11] eal: replace rte_panic instances in eventdev

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky --- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +--- lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev_

[dpdk-dev] [PATCH v7 04/11] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 -- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 15 ++--

[dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +--- drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa

[dpdk-dev] [PATCH v7 03/11] e1000: replace rte_panic instances in e1000 driver

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/e1000/e1000_ethdev.h | 2 +- drivers/net/e1000/igb_ethdev.c | 4 +++- drivers/net/e1000/igb_pf.c | 15 +-

[dpdk-dev] [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Local functions to this file, changing from void to int are non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++

[dpdk-dev] [PATCH v7 00/11] eal: replace calls to rte_panic and refrain from new instances

2018-04-24 Thread Arnon Warshavsky
The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This patch modifies the majority of rte_panic calls un

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Thomas Monjalon
24/04/2018 23:53, Yongseok Koh: > On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote: > > 24/04/2018 21:15, Olivier Matz: > > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > > > On Tue, Apr 24, 2018 at 03:28:

[dpdk-dev] [PATCH] app/test: fix shared library build failure

2018-04-24 Thread Reshma Pattan
Using private api `guest_channel_host_connect()` will cause shared library build failure. So revert the changes done. Fixes: d550a8cc31 ("app/test: enhance power manager unit tests") Signed-off-by: Jananee Parthasarathy Signed-off-by: Reshma Pattan --- test/test/test_power_kvm_vm.c | 47 ++

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-24 Thread Thomas Monjalon
Hi, First, this is my summary after the survey answers and comments: 1/ allow "forgetting" port offloads in queue offloads setup 2/ update documentation, applications and remove checks in PMDs for 18.05-rc2 3/ an offload enabled at port level, cannot be disabled at queue level 4/ The queue cap

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote: > 24/04/2018 21:15, Olivier Matz: > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > >

Re: [dpdk-dev] [PATCH v2 0/2] Fix file locking in EAL memory

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 22:05:10 +0200 Thomas Monjalon wrote: > 24/04/2018 19:25, Burakov, Anatoly: > > On 24-Apr-18 5:32 PM, Stephen Hemminger wrote: > > > On Tue, 24 Apr 2018 16:54:21 +0100 > > > Anatoly Burakov wrote: > > > > > >> One of the ways to work around this was using OFD locks, > >

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Thomas Monjalon
24/04/2018 21:15, Olivier Matz: > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > > > > + * Returns TRUE

Re: [dpdk-dev] [PATCH v2 0/2] Fix file locking in EAL memory

2018-04-24 Thread Thomas Monjalon
24/04/2018 19:25, Burakov, Anatoly: > On 24-Apr-18 5:32 PM, Stephen Hemminger wrote: > > On Tue, 24 Apr 2018 16:54:21 +0100 > > Anatoly Burakov wrote: > > > >> One of the ways to work around this was using OFD locks, > >> but they are only supported on kernels 3.15+, > > > > Maybe time to move t

Re: [dpdk-dev] [PATCH v7 7/9] ethdev: add switch domain allocator

2018-04-24 Thread Thomas Monjalon
16/04/2018 15:06, Declan Doherty: > +/** > + * Array of switch domains available for allocation. Array is sized to > + * RTE_MAX_ETHPORTS elements as there cannot be more active switch domains > than > + * ethdev ports in a single process. > + */ > +struct rte_eth_dev_switch { > + enum rte_eth

Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-24 Thread Thomas Monjalon
16/04/2018 15:06, Declan Doherty: > From: Remy Horton > > Introduces a new structure, rte_eth_devargs, to support generic > ethdev arguments common across NET PMDs, with a new API > rte_eth_devargs_parse API to support PMD parsing these arguments. Most of the parsing functions should be removed

Re: [dpdk-dev] [PATCH v7 4/9] ethdev: Add port representor device flag

2018-04-24 Thread Thomas Monjalon
16/04/2018 15:06, Declan Doherty: > Add new device flag to specify that an ethdev port is a port representor. > Extend rte_eth_dev_info structure to expose device flags to the user which > enables applications to discover if a port is a representor port. [...] > --- a/lib/librte_ether/rte_ethdev.c

Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup

2018-04-24 Thread Thomas Monjalon
10/04/2018 15:59, Thomas Monjalon: > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x0001 > > +/**< Deferred setup rx queue */ > > +#define DEV_RUNTIME_TX_QUEUE_SETUP 0x0002 > > +/**< Deferred setup tx queue */ > > Ple

Re: [dpdk-dev] [PATCH v6 05/11] eal: replace rte_panic instances in eventdev

2018-04-24 Thread Arnon Warshavsky
Thanks. Same as with dpaa On Tue, Apr 24, 2018 at 6:06 PM, Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 24 Apr 2018 09:41:57 +0300 > Arnon Warshavsky wrote: > > > + if (eventdev->data->dev_private == NULL) { > > + RTE_LOG(CRIT, EAL, "%s(): Cann

Re: [dpdk-dev] [PATCH v6 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-24 Thread Arnon Warshavsky
> > > > + if (cryptodev->data->dev_private == NULL) { > > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone > for private device data", > > + __func__); > > dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro. > > You should go th

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Olivier Matz
On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > Hi Andrew, Yongseok, > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > > > This patch introduces a new w

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement test

2018-04-24 Thread Mokhtar, Amr
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday 24 April 2018 18:45 > To: Chalupnik, KamilX ; dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost > measurement test > > > > > -Original Messag

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software driver

2018-04-24 Thread Mokhtar, Amr
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday 24 April 2018 18:56 > To: Chalupnik, KamilX ; dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo > Software driver > > > > > -Original Message-

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-24 Thread Adrien Mazarguil
On Tue, Apr 24, 2018 at 05:13:46PM +0100, Ferruh Yigit wrote: > On 4/24/2018 3:39 PM, Ferruh Yigit wrote: > > On 4/24/2018 3:18 PM, Qi Zhang wrote: > >> After add RSS hash offload check, default rss_hf will fail on > >> devices that not support all bits, the patch take rss_hf as > >> a suggest valu

Re: [dpdk-dev] ***Spam*** Re: [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Andrew Rybchenko
On 04/24/2018 07:02 PM, Olivier Matz wrote: Hi Andrew, Yongseok, On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: On 04/24/2018 04:38 AM, Yongseok Koh wrote: This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite simil

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag of ports enumeration

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 3:15 AM, Thomas Monjalon wrote: > The basic operations for ports enumeration should not be > considered as experimental in DPDK 18.05. > > The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05. > It uses the function the rte_eth_find_next_owned_by() to get > only ownerless por

Re: [dpdk-dev] [PATCH v4 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 6:16 PM, Hemant Agrawal wrote: > From: Sunil Kumar Kori > > Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs") > > Signed-off-by: Sunil Kumar Kori Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-24 Thread Ferruh Yigit
On 4/23/2018 12:32 PM, Ophir Munk wrote: > Hi Ferruh, > The exact same setup works without your patch (done before sending my first > email). > I started debugging your patch and noticed you have dropped the setting of > txq->csum which always remains 0 therefore [1] is never executed. I see it

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software driver

2018-04-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:44 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software > driver > > Update

[dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-24 Thread Ferruh Yigit
It is not clear if tap PMD supports queue specific offloads, removing the related code. Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") Cc: mo...@mellanox.com Signed-off-by: Ferruh Yigit --- Cc: Ophir Munk v2: * rebased v3: * t

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo software driver

2018-04-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:34 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo > software driver Op

Re: [dpdk-dev] [PATCH v7 3/9] ethdev: add generic create/destroy ethdev APIs

2018-04-24 Thread Thomas Monjalon
16/04/2018 15:05, Declan Doherty: > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -348,7 +348,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev) > rte_eth_dev_shared_data_prepare(); > > rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement test

2018-04-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:27 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement > test > > New te

Re: [dpdk-dev] [PATCH v2 0/2] Fix file locking in EAL memory

2018-04-24 Thread Burakov, Anatoly
On 24-Apr-18 5:32 PM, Stephen Hemminger wrote: On Tue, 24 Apr 2018 16:54:21 +0100 Anatoly Burakov wrote: One of the ways to work around this was using OFD locks, but they are only supported on kernels 3.15+, Maybe time to move to next LTS kernel (3.16)? I'm all for it, but it's not my cal

Re: [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Hemant Agrawal
HI Ferruh, > Hi Hemant, > > Overall this looks good to me, thanks. > > Only I would like to ask if you prefer to replace nodis and not_supported > checks. > > Because with current order, if an offlaod requested that both has not > supported > offload and not enable all nodis offloads, this w

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups

2018-04-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, April 24, 2018 4:30 PM > To: Chalupnik, KamilX ; dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queu

[dpdk-dev] [PATCH v4 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs") Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_ethdev.c | 87 +++--- 1 file changed, 56 insertions(+), 31 deletions(-) diff --git a/drivers/net/dpaa/dpaa_eth

[dpdk-dev] [PATCH v4 2/2] net/dpaa2: fix the ethdev offload checks

2018-04-24 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 0ebce6129bc6 ("net/dpaa2: support new ethdev offload APIs") Signed-off-by: Sunil Kumar Kori Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 88 +++- 1 file changed, 60 insertions(+), 28 deletions(-) diff -

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: fix icc build

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 2:21 PM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Monday, March 12, 2018 7:32 PM >> To: Pascal Mazon >> Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org >> Subject: [dpdk-stabl

[dpdk-dev] [PATCH v2 5/5] doc: update guides for current preferrred log level syntax

2018-04-24 Thread Stephen Hemminger
Use symbolic names and match rather than numbers and regex in the guides. Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/dpaa2_sec.rst | 2 +- doc/guides/cryptodevs/dpaa_sec.rst | 2 +- doc/guides/faq/faq.rst | 23 ++- doc/guides/nics/dpaa2.rst

[dpdk-dev] [PATCH v2 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Stephen Hemminger
Regular expressions are not the best way to match a hierarchical pattern like dynamic log levels. And the separator for dynamic log levels is period which is the regex wildcard character. A better solution is to use filename matching 'globbing' so that log levels match like file paths. For compati

[dpdk-dev] [PATCH v2 2/5] eal: allow symbolic log levels

2018-04-24 Thread Stephen Hemminger
Much easeier to remember names than numbers. Allows --log-level=pmd.net.ixgbe.*,debug Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 67 -- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v2 3/5] eal: make eal_log_level save private

2018-04-24 Thread Stephen Hemminger
We don't want format of eal log level saved values to be visible in ABI. Move to private storage in eal_common_log. Includes minor optimization. Compile the regular expression for each log match once, rather than each time it is used. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/e

[dpdk-dev] [PATCH v2 1/5] eal: make syslog facility table const

2018-04-24 Thread Stephen Hemminger
The mapping fro facility name to value can be const. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index

[dpdk-dev] [PATCH v2 0/5] logging enhancements

2018-04-24 Thread Stephen Hemminger
This patch set improves the log-level option in EAL. It adds symbolic names for log levels (error, info, debug, etc) and shell style matching of log levels. --log-level='pmd.ixgbe.*:debug' The original syntax (which is maintained for compatibility) used numeric values, comma as separator and re

Re: [dpdk-dev] [PATCH 0/3] mlx5 support Tx generic tunnel checksum and TSO

2018-04-24 Thread Shahaf Shuler
Sunday, April 8, 2018 3:41 PM, Xueming Li: > Subject: [dpdk-dev] [PATCH 0/3] mlx5 support Tx generic tunnel checksum > and TSO > > This patchset introduced Tx generic tunnel checksum and TSO offload to mlx5 > PMD. > > This patchset relies on new ethdev API of: > https://emea01.safelinks.pro

Re: [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 4:06 PM, Hemant Agrawal wrote: > From: Sunil Kumar Kori > > Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs") > > Signed-off-by: Sunil Kumar Kori > --- > drivers/net/dpaa/dpaa_ethdev.c | 89 > +++--- > 1 file changed, 57 inserti

Re: [dpdk-dev] [PATCH v7 2/9] ethdev: add switch identifier parameter to port

2018-04-24 Thread Thomas Monjalon
16/04/2018 15:05, Declan Doherty: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > +/** > + * Default values for switch domain id when ethdev does not support switch > + * domain definitions. values -> value > + */ > +#define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID (0) >

Re: [dpdk-dev] [PATCH v2 0/2] Fix file locking in EAL memory

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 16:54:21 +0100 Anatoly Burakov wrote: > One of the ways to work around this was using OFD locks, > but they are only supported on kernels 3.15+, Maybe time to move to next LTS kernel (3.16)?

Re: [dpdk-dev] [PATCH v5 0/4] ethdev additions to support tunnel encap/decap

2018-04-24 Thread Thomas Monjalon
Hi, > Declan Doherty (4): > ethdev: Add tunnel encap/decap actions > ethdev: Add group JUMP action > ethdev: add mark flow item to rte_flow_item_types > ethdev: add shared counter support to rte_flow No specific comment. It is only an API without any PMD implementation. Which PMDs are pl

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 4:20 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, April 24, 2018 1:28 PM >> To: Ananyev, Konstantin ; Thomas Monjalon >> ; dev@dpdk.org >> Cc: Ajit Khaparde ; Jerin Jacob >> ; Shijith Thotton >> ; Santosh Shukla >> ; Rah

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 3:39 PM, Ferruh Yigit wrote: > On 4/24/2018 3:18 PM, Qi Zhang wrote: >> After add RSS hash offload check, default rss_hf will fail on >> devices that not support all bits, the patch take rss_hf as >> a suggest value and only set bits that device supported base on >> rte_eth_dev_get_inf

Re: [dpdk-dev] [PATCH v3 3/5] eal: set name when creating a control thread

2018-04-24 Thread Burakov, Anatoly
On 24-Apr-18 3:46 PM, Olivier Matz wrote: To avoid code duplication, add a parameter to rte_ctrl_thread_create() to specify the name of the thread. This requires to add a wrapper for the thread start routine in rte_thread_init(), which will first wait that the thread is configured. Signed-off-b

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Olivier Matz
Hi Andrew, Yongseok, On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > This patch introduces a new way of attaching an external buffer to a mbuf. > > > > Attaching an external buffer is quite similar to mbuf indirection in > > repl

[dpdk-dev] [PATCH v5 3/3] ethdev: add VLAN and MPLS actions to flow API

2018-04-24 Thread Adrien Mazarguil
From: Qi Zhang Add support for the following OpenFlow-defined actions: - RTE_FLOW_ACTION_OF_POP_VLAN: pop the outer VLAN tag. - RTE_FLOW_ACTION_OF_PUSH_VLAN: push a new VLAN tag. - RTE_FLOW_ACTION_OF_SET_VLAN_VID: set the 802.1q VLAN id. - RTE_FLOW_ACTION_OF_SET_VLAN_PCP: set the 802.1q prior

  1   2   3   >