On 2019-04-05 22:50, Stephen Hemminger wrote:
Read the discussion link about ARC4. http://www.pcg-random.org/
As a general-purpose PRNG, it is rather slow, and it is also slow by
the standards of modern cryptographic PRNGs and is also considered too
weak to use for crypt
Outbound ESP sequence number should be incremented atomically and refeenced
indirectly. Otherwise, concurrent access by multiple threads will break
coherency.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6")
Fixes
A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v19.05-rc1
After one big and one short cycle releases, this one looks normal,
delivering -rc1, almost on time, with 678 patches.
The release notes so far:
http://doc.dpdk.org/guides/rel_notes/rele
On Fri, 5 Apr 2019 20:04:28 +0200
Mattias Rönnblom wrote:
> On 2019-04-05 18:57, Stephen Hemminger wrote:
> >
> > rand48 is a terrible PRNG, why not use something better?
> >
> > Similar discussion in Linux kernel pointed at:
> > http://www.pcg-random.org/posts/some-prng-implementations.html
>
The symbols in the EXPERIMENTAL were close to alphabetic
order but running sort showed several mistakes.
This has no impact on code, API, ABI or otherwise.
Purely for humans.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/rte_eal_version.map | 36 +++---
1 file chan
"Pavan Nikhilesh Bhagavatula" wrote Thursday, March
28, 2019 6:35 AM:
Hi Stefan,
Thanks for the heads up, I am planning to use a modified version of
https://github.com/hcs0/Hackers-Delight/blob/master/divluh.c.txt
for simplicity as we don't require the remainder.
Why don't you refer to the
05/04/2019 20:47, Jerin Jacob Kollanukkaran:
> From: Thomas Monjalon
> > 18/03/2019 17:50, Jerin Jacob Kollanukkaran:
> > > From: Jerin Jacob
> > >
> > > Optimized configuration for Marvell thunderx2 SoC.
> > > Updated meson build to support Marvell thunderx2 SoC.
> > > Added meson cross compile
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, April 5, 2019 11:43 PM
> To: Jerin Jacob Kollanukkaran ; Pavan Nikhilesh
> Bhagavatula
> Cc: dev@dpdk.org; gavin...@arm.com
> Subject: Re: [dpdk-dev] [PATCH v6 3/4] config: add thunderx2 machine
> config
>
> 18/03/2019 17:50, J
18/03/2019 17:50, Jerin Jacob Kollanukkaran:
> From: Jerin Jacob
>
> Optimized configuration for Marvell thunderx2 SoC.
> Updated meson build to support Marvell thunderx2 SoC.
> Added meson cross compile target.
>
> Product details are here:
>
> https://www.marvell.com/server-processors/thunder
On 2019-04-05 18:57, Stephen Hemminger wrote:
rand48 is a terrible PRNG, why not use something better?
Similar discussion in Linux kernel pointed at:
http://www.pcg-random.org/posts/some-prng-implementations.html
Mail thread here:
https://www.spinics.net/lists/netdev/msg560231.html
DPDK was
On 4/2/2019 10:53 AM, Pavan Nikhilesh Bhagavatula wrote:
> From: Pavan Nikhilesh
>
> Testpmd txonly copies the src/dst mac address of the port being
> processed to ethernet header structure on the stack for every packet.
> Move it outside the loop and reuse it.
>
> Signed-off-by: Pavan Nikhilesh
> -Original Message-
> From: Varghese, Vipin
> >
> > > + fflush(stdout);
> >
> > Why is fflush used here and in below other places?
> To ensure the stdout content is flushed out. We had used similar approach to '
> examples/l2fwd/main.c'
>
Can you elaborate more? What problem do you
> -Original Message-
> From: Varghese, Vipin
>
Nit picks:
>
> +The ``--multi`` command line option is optional argument. If passed,
> +capture will be running on unique cores for all ``--pdump`` options. If
> +ignored, capture will be running on single core for all ``--pdump`` optio
On Fri, 5 Apr 2019 15:45:42 +0200
Mattias Rönnblom wrote:
> The rte_rand() documentation left it unspecified if the rte_rand() was
> multi-thread safe or not, and the implementation (based on lrand48())
> was not.
>
> This commit makes rte_rand() safe to use from any lcore thread by
> using lran
On Fri, 5 Apr 2019 13:01:10 +0200
David Marchand wrote:
> On Wed, Apr 3, 2019 at 7:16 PM Stephen Hemminger
> wrote:
>
> > diff --git a/lib/librte_eal/common/eal_common_lcore.c
> > b/lib/librte_eal/common/eal_common_lcore.c
> > index 1cbac42286ba..806204d9f73d 100644
> > --- a/lib/librte_eal/com
The function rte_vlan_insert may allocate a new buffer for the
vlan header and return a different mbuf than originally passed.
In this case, the stored mbuf in txm[] array could point to wrong
buffer.
Fixes: dd856dfcb9e7 ("virtio: use any layout on Tx")
Signed-off-by: Stephen Hemminger
---
v2 - c
From: Marcin Hajkowski
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Burakov
---
app/test/test_power.c | 156 --
1
From: Marcin Hajkowski
Set all power environment related function pointers to NULL
when unset is being made.
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Burakov
---
lib/librte_power/rte_power.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/lib
From: Marcin Hajkowski
On attempt to set_env in already initialized state notify
user by returning error that operation cannot be performed.
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Burakov
---
lib/librte_power/rte_power.c | 3 ++-
lib/librte_power/rte_power.h | 3 ++-
2 files change
From: Marcin Hajkowski
Enhance rte_power API user notification by returning more
suitable value in case of power environment setting, add related tests
and some internal data cleaning corrections.
Please note that changes depends on patch
(http://patchwork.dpdk.org/patch/52349/) which should be
This patch fixes the incorrect iv offset calculation.
Fixes: b063e843fa03 ("crypto/virtio: fix IV physical address")
Cc: sta...@dpdk.org
Signed-off-by: Fan Zhang
---
v2:
fixed a typo
drivers/crypto/virtio/virtio_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
On 2/9/2018 10:38 AM, alanrobertson...@gmail.com wrote:
> From: Alan Robertson
>
> There were 2 issues, the first was time could be lost whilst updating
> the traffic-class period, the second was a frame could be delayed if
> not enough tokens were available for the full frame. By allowing the
>
On 4/10/2018 2:19 PM, Burakov, Anatoly wrote:
> On 10-Apr-18 11:55 AM, Tosatti, Giovanni wrote:
>> This patch adds a " --restore" option that will unbind all devices currently
>> bound to DPDK PMDs back to the kernel driver.
>>
>> ---
>> /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Part
On 4/5/2019 4:33 PM, Bruce Richardson wrote:
> The build spec has lots of levels of indentation, which can be reduced by
> not explicitly checking for linux, but for the needed header and library
> files needed for the driver.
>
> Signed-off-by: Bruce Richardson
Squashed into relevant commit in
On 4/5/2019 4:33 PM, Bruce Richardson wrote:
> The build spec has lots of levels of indentation, which can be reduced by
> not explicitly checking for linux, but for the needed header and library
> files needed for the driver.
>
> Signed-off-by: Bruce Richardson
> ---
> drivers/net/af_xdp/meson.
On 1/16/2018 4:07 PM, alangordonde...@gmail.com wrote:
> From: Alan Dewar
>
> The RED code stores the weighted moving average in a 32-bit integer as
> a pseudo fixed-point floating number with 10 fractional bits. Twelve
> other bits are used to encode the filter weight, leaving just 10 bits
> fo
On Fri, Apr 05, 2019 at 04:31:16PM +0100, Ferruh Yigit wrote:
> On 4/5/2019 4:23 PM, Bruce Richardson wrote:
> > On Fri, Apr 05, 2019 at 11:05:25PM +0800, Ye Xiaolong wrote:
> >> Hi, Ferruh
> >>
> >> On 04/05, Ferruh Yigit wrote:
> >>> On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
> Add a new PMD dr
This patch fixes the incorrect iv offset calculation.
Fixes: b063e843fa03 ("crypto/virtio: fix IV physical address")
Cc: sta...@dpdk.org
Signed-off-by: Fan Zhang
---
drivers/crypto/virtio/virtio_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/virtio
The build spec has lots of levels of indentation, which can be reduced by
not explicitly checking for linux, but for the needed header and library
files needed for the driver.
Signed-off-by: Bruce Richardson
---
drivers/net/af_xdp/meson.build | 25 +++--
1 file changed, 11 in
On 4/5/2019 4:23 PM, Bruce Richardson wrote:
> On Fri, Apr 05, 2019 at 11:05:25PM +0800, Ye Xiaolong wrote:
>> Hi, Ferruh
>>
>> On 04/05, Ferruh Yigit wrote:
>>> On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
Add a new PMD driver for AF_XDP which is a proposed faster version of
AF_PACKET interfa
On 04/05, Ferruh Yigit wrote:
>On 4/5/2019 4:05 PM, Ye Xiaolong wrote:
>> Hi, Ferruh
>>
>> On 04/05, Ferruh Yigit wrote:
>>> On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
Add a new PMD driver for AF_XDP which is a proposed faster version of
AF_PACKET interface in Linux. More info about AF_XDP,
On Fri, Apr 05, 2019 at 11:05:25PM +0800, Ye Xiaolong wrote:
> Hi, Ferruh
>
> On 04/05, Ferruh Yigit wrote:
> >On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
> >> Add a new PMD driver for AF_XDP which is a proposed faster version of
> >> AF_PACKET interface in Linux. More info about AF_XDP, please refer
Fixes: 55bcda7b3515 ("net/af_xdp: introduce AF XDP PMD driver")
Signed-off-by: Ferruh Yigit
---
drivers/net/af_xdp/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 840c93728..e3d86c39a 100644
-
On 4/5/2019 4:05 PM, Ye Xiaolong wrote:
> Hi, Ferruh
>
> On 04/05, Ferruh Yigit wrote:
>> On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
>>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>>> [2].
>>>
>>>
Hi, Ferruh
On 04/05, Ferruh Yigit wrote:
>On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla version PMD which just uses a r
On 1/25/2018 3:40 AM, Simon Guo wrote:
>
> Hi Konstantin,
> On Thu, Jan 18, 2018 at 12:14:05PM +, Ananyev, Konstantin wrote:
>> Hi Simon,
>>
>>>
>>> Hi, Konstantin,
>>> On Tue, Jan 16, 2018 at 12:38:35PM +, Ananyev, Konstantin wrote:
> -Original Message-
> From: d
On 4/5/2019 4:00 PM, Ferruh Yigit wrote:
> On 5/24/2018 5:58 PM, Thomas Monjalon wrote:
>> 09/01/2018 16:44, Ferruh Yigit:
>>> +* If changes effect other parts of the project, update all those parts as
>>> well unless updating requires special knowledge.
>>> + For the cases where not all the effe
On 5/24/2018 5:58 PM, Thomas Monjalon wrote:
> 09/01/2018 16:44, Ferruh Yigit:
>> +* If changes effect other parts of the project, update all those parts as
>> well unless updating requires special knowledge.
>> + For the cases where not all the effected code is updated, the submitter
>> should
On 4/5/2019 3:55 PM, Ferruh Yigit wrote:
> On 5/22/2018 11:17 PM, Thomas Monjalon wrote:
>> 12/12/2017 11:05, Nikhil Agarwal:
>>> Currently, if the rte_eth_rx_burst() function returns a value less than
>>> *nb_pkts*, the application will assume that no more packets are present.
>>>
>>> Some of the
On 2019-04-05 16:28, Bruce Richardson wrote:
On Fri, Apr 05, 2019 at 03:51:39PM +0200, Mattias Rönnblom wrote:
On 2019-04-05 15:45, Mattias Rönnblom wrote:
The rte_rand() documentation left it unspecified if the rte_rand() was
multi-thread safe or not, and the implementation (based on lrand48()
On 5/22/2018 11:17 PM, Thomas Monjalon wrote:
> 12/12/2017 11:05, Nikhil Agarwal:
>> Currently, if the rte_eth_rx_burst() function returns a value less than
>> *nb_pkts*, the application will assume that no more packets are present.
>>
>> Some of the hw queue based hardware can only support smalle
On 4/4/2019 8:34 PM, Shahaf Shuler wrote:
> Allocated mempools were never free. it is bad practice.
+1
>
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Shahaf Shuler
<...>
> @@ -835,7 +837,7 @@ setup_extmem(uint32_t nb_mbufs, uint32_t mbuf_sz, bool
>
As flagged by coverity, the "info" structure is being explicitly
dereferenced before being checked later for a NULL value.
Coverity issue: 277241
Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
CC: sta...@dpdk.org
Cc: zijie@6wind.com
CC: Beilei Xing
CC: Qi Zhang
Signe
The value returned from rte_eth_dev_tx_offload_name() function is used
for string comparison before being checked for NULL. Move the NULL check
up to be done first.
Coverity issue: 279438
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: wei@intel.com
Cc: sta...@dpd
Coverity flags that the txq variable is used before it's checked for NULL.
Also fix typo in error message.
Coverity issue: 195023
Fixes: 24853544c84c ("net/i40e: fix mbuf free in vector Tx")
Cc: qi.z.zh...@intel.com
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
Acked-By: Rami Rosen
---
V
Coverity points out that there is a check in the main thread loop for the
ctrlr->bdev being NULL, but by that stage the pointer has already been
dereferenced. Therefore, for safety, before we enter the loop do an
initial check on the parameter structure.
Coverity issue: 158657
Fixes: db75c7af19bb
The header check for the example app was looking for virtio_scsi.h without
the "linux/" prefix, which meant it was never getting found when it should
have been.
Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency")
CC: sta...@dpdk.org
CC: Maxime Coquelin
CC: Tiwei Bie
A few coverity fixes, along with a fix for one of the examples meson.build
files which I caught along the way.
v2: include a typo fix identified by Rami Rosen.
Bruce Richardson (5):
examples/vhost_scsi: fix header check for meson build
examples/vhost_scsi: fix missing NULL-check for parameter
From: Marcin Hajkowski
Due to lack of thread safety in exisiting solution
use spinlock mechanism for atomic
modification of power environment related data.
Fixes: 445c6528b5 ("power: common interface for guest and host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Bur
On Fri, Apr 05, 2019 at 03:51:39PM +0200, Mattias Rönnblom wrote:
> On 2019-04-05 15:45, Mattias Rönnblom wrote:
> > The rte_rand() documentation left it unspecified if the rte_rand() was
> > multi-thread safe or not, and the implementation (based on lrand48())
> > was not.
> >
> > This commit mak
Acked-By: Rami Rosen
Acked-by: Rami Rosen
Acked-By: Rami Rosen
In this occasion I noticed that there is a typo in the code that appears in
the patch;
it should be "Pointer to txq" instead of "Pointer to rxq":
I would consider resending and fixing it on this occasion:
> if (!txq || !txq->sw_ring) {
> PMD_DRV_LOG(DEBUG, "Po
On 4/5/2019 1:05 PM, Andrew Rybchenko wrote:
> Rx refill in one bulk (which is just 8 descriptors) by default is too
> aggressive and makes too many MMIO writes (Rx doorbells) if packet rate
> is high. Setting default to 1/8 of Rx descriptors number shows good
> performance results. Anyway it is a
> -Original Message-
> From: Singh, Jasvinder
> Sent: Friday, April 5, 2019 2:55 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian
> Subject: [PATCH v3] meter: replace color definitions with rte_color values
>
> This patch implements the changes proposed in the deprecation
> note[1]. Re
This patch implements the changes proposed in the deprecation
note[1]. Replace multiple color definitions in various places such as
rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
in rte_meter.h.
This is simple search and replace exercise without any implementation
change.
[1] h
On 2019-04-05 15:45, Mattias Rönnblom wrote:
The rte_rand() documentation left it unspecified if the rte_rand() was
multi-thread safe or not, and the implementation (based on lrand48())
was not.
This commit makes rte_rand() safe to use from any lcore thread by
using lrand48_r() and per-lcore ran
As flagged by coverity, the "info" structure is being explicitly
dereferenced before being checked later for a NULL value.
Coverity issue: 277241
Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
CC: sta...@dpdk.org
Cc: zijie@6wind.com
CC: Beilei Xing
CC: Qi Zhang
Signe
The rte_rand() documentation left it unspecified if the rte_rand() was
multi-thread safe or not, and the implementation (based on lrand48())
was not.
This commit makes rte_rand() safe to use from any lcore thread by
using lrand48_r() and per-lcore random state structs. Besides the
obvious improvem
Coverity flags that the txq variable is used before it's checked for NULL.
Coverity issue: 195023
Fixes: 24853544c84c ("net/i40e: fix mbuf free in vector Tx")
Cc: qi.z.zh...@intel.com
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/i40e/i40e_rxtx.c | 4 ++--
1 file changed,
The value returned from rte_eth_dev_tx_offload_name() function is used
for string comparison before being checked for NULL. Move the NULL check
up to be done first.
Coverity issue: 279438
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: wei@intel.com
Cc: sta...@dpd
The header check for the example app was looking for virtio_scsi.h without
the "linux/" prefix, which meant it was never getting found when it should
have been.
Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency")
CC: sta...@dpdk.org
CC: Maxime Coquelin
CC: Tiwei Bie
Coverity points out that there is a check in the main thread loop for the
ctrlr->bdev being NULL, but by that stage the pointer has already been
dereferenced. Therefore, for safety, before we enter the loop do an
initial check on the parameter structure.
Coverity issue: 158657
Fixes: db75c7af19bb
A few coverity fixes, along with a fix for one of the examples meson.build
files which I caught along the way.
Bruce Richardson (5):
examples/vhost_scsi: fix header check for meson build
examples/vhost_scsi: fix missing NULL-check for parameter
net/i40e: fix dereference before NULL check in
07/02/2019 16:39, Kevin Traynor:
> Update the LTS section to mention the branch, how LTS support ends
> and update the currently maintained LTS branches.
The current branches were updated in another patch.
> Signed-off-by: Kevin Traynor
> Acked-by: Aaron Conole
> ---
[...]
> +At the end of the
On 4/5/2019 2:13 PM, Tom Barbette wrote:
> Clarify the fact that mask bits should be set in rte_eth_reta_query.
>
> v2:
> - Change documentation string as suggested by Ferruh
>
> Signed-off-by: Tom Barbette
Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
On 4/5/2019 8:36 AM, Nithin Kumar Dabilpuram wrote:
> Tx VLAN & QinQ insert enable need not depend on
> Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
> insert enable, error check is now to see if QinQ was enabled
> but only single VLAN id is set.
>
> Fixes: 6a34f91690d0 ("app/testpmd: fix e
27/03/2019 18:25, Luca Boccassi:
> On Wed, 2019-03-27 at 17:22 +, Kevin Traynor wrote:
> > If a stable branch for a specific DPDK release is to proceed,
> > along with needing a maintainer, there should also be commitment
> > from major contributors for validation of the releases.
> >
> > Also
On 4/5/2019 2:10 PM, Nithin Kumar D wrote:
> Hi Ferruh,
>
> Yes, our mail server had some issue and was inserting CRLF chars. So I sent
> the same v3 as v4 from gmail.
If the content is same I will continue with v3, thanks.
>
> Thanks
> Nithin
>
> On Fri, Apr 5, 2019 at 5:36 PM Ferruh Yigit w
On 04/04/2019 21:13, Kevin Traynor wrote:
> On 04/04/2019 20:08, Wiles, Keith wrote:
>>
>>
>>> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote:
>>>
>>> On 04/04/2019 11:54, Bruce Richardson wrote:
>>>
>>>
My thoughts on the matter are:
1. I think we really need to do work to st
At the mlx5 device closing the shared IB context was destroyed
before cleanup routines completion. As it was found on some
setups (Netlink fails with old kernel drivers and we have to use
sysfs to retrieve interface index, this requires IB device name,
which is stored in shared context) the mlx5_nl
On 04/04/2019 20:08, Wiles, Keith wrote:
>
>
>> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote:
>>
>> On 04/04/2019 11:54, Bruce Richardson wrote:
>>
> ABI breaks should be handled by the board. As for new APIs they are not so
> bad and they do not need to be approved by the board just ha
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 60
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 68 +++--
1 file changed, 62 insertions(+), 6 deletions(-)
diff --git a/examples/vm_power
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 73 +++
2 files changed, 6
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta...@dpdk.org
Sign
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
---
v5:
* enhance logging
v4:
* [vm_power_manager] treat 0 as valid socket id
* [guest_manager] use user level logs
* correct code f
Retrieving network interface index via Netlink fails in
case of old ib_core kernel driver installed - mlx5_nl_ifindex()
routine fails due to RDMA_NLDEV_ATTR_NDEV_INDEX attribute is not
supported by the old driver.
The patch allowing to retrieve the network interface index and
name via Netlink [1].
On 04/04/2019 14:10, Bruce Richardson wrote:
> On Thu, Apr 04, 2019 at 02:05:27PM +0100, Ray Kinsella wrote:
>>
>>
>> On 04/04/2019 13:02, Luca Boccassi wrote:
>>> On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote:
On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote:
>>
Clarify the fact that mask bits should be set in rte_eth_reta_query.
v2:
- Change documentation string as suggested by Ferruh
Signed-off-by: Tom Barbette
---
lib/librte_ethdev/rte_ethdev.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib
Hi Ferruh,
Yes, our mail server had some issue and was inserting CRLF chars. So I sent
the same v3 as v4 from gmail.
Thanks
Nithin
On Fri, Apr 5, 2019 at 5:36 PM Ferruh Yigit wrote:
> On 4/5/2019 1:04 PM, Nithin Dabilpuram wrote:
> > From: Nithin Dabilpuram
> >
> > Tx VLAN & QinQ insert enabl
27/03/2019 12:33, Akhil Goyal:
> link check is done for primary process for the ports
> which are given in the port mask and not the complete
> set of ports.
>
> Fixes: d3641ae86313 ("examples: update link status checks")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Akhil Goyal
> ---
>
On 05/04/19 6:05 PM, Thomas Monjalon wrote:
> 05/04/2019 13:38, Shreyansh Jain:
>> On 05/04/19 4:49 PM, Shreyansh Jain wrote:
>>> On 05/04/19 3:13 AM, Thomas Monjalon wrote:
04/04/2019 23:29, Ferruh Yigit:
> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
>> Removes some unused firmware cod
27/03/2019 12:37, Ferruh Yigit:
> On 3/26/2019 10:04 AM, Chaitanya Babu, TalluriX wrote:
> > From: Yigit, Ferruh
> >> On 3/8/2019 2:02 PM, Bruce Richardson wrote:
> >>> On Fri, Mar 08, 2019 at 12:45:50PM +, Chaitanya Babu Talluri wrote:
> Replace strcat with strlcat to avoid buffer overflo
The patch allowing to retrieve the network interface index and name via Netlink:
https://www.spinics.net/lists/linux-rdma/msg62948.html
In Linux tree: 5b2cc79d (Leon Romanovsky 2018-03-27 20:40:49 +0300 270)
So, the problem depends on ib_core module version - 4.16 supports getting
ifindex via Netl
On 27-Mar-19 11:33 AM, Akhil Goyal wrote:
link check is done for primary process for the ports
which are given in the port mask and not the complete
set of ports.
Fixes: d3641ae86313 ("examples: update link status checks")
Cc: sta...@dpdk.org
Signed-off-by: Akhil Goyal
---
Acked-by: Anatoly
05/04/2019 13:38, Shreyansh Jain:
> On 05/04/19 4:49 PM, Shreyansh Jain wrote:
> > On 05/04/19 3:13 AM, Thomas Monjalon wrote:
> >> 04/04/2019 23:29, Ferruh Yigit:
> >>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
> Removes some unused firmware code which was added in last bump
> of the fi
On 4/5/2019 1:04 PM, Nithin Dabilpuram wrote:
> From: Nithin Dabilpuram
>
> Tx VLAN & QinQ insert enable need not depend on
> Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
> insert enable, error check is now to see if QinQ was enabled
> but only single VLAN id is set.
>
> Fixes: 6a34f9169
Rx refill in one bulk (which is just 8 descriptors) by default is too
aggressive and makes too many MMIO writes (Rx doorbells) if packet rate
is high. Setting default to 1/8 of Rx descriptors number shows good
performance results. Anyway it is a default value which may be
overridden by Rx configura
From: Nithin Dabilpuram
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shah...@mellanox.com
Signed-off-by: Nithin Dabilpuram
Acked-by: B
From: Nithin Dabilpuram
Tx VLAN & QinQ insert enable need not depend on
Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
insert enable, error check is now to see if QinQ was enabled
but only single VLAN id is set.
Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx VLAN")
Cc
This patch implements the changes proposed in the deprecation
note[1].
Replace mulitple color definitions in various places such as
rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
in rte_meter.h.
[1] https://mails.dpdk.org/archives/dev/2019-January/123861.html
Signed-off-by: Ja
On 4/4/19 4:25 PM, Adrien Mazarguil wrote:
Hi Ori,
(trimming message down a bit)
On Thu, Apr 04, 2019 at 09:01:52AM +, Ori Kam wrote:
Hi Adrien,
PSB
From: Adrien Mazarguil
On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote:
Thanks, PSB.
From: Adrien Mazarguil
I sti
On 4/5/2019 12:31 PM, Ferruh Yigit wrote:
> On 4/5/2019 10:05 AM, Qi Zhang wrote:
>> ---
>> v5:
>> 1. add ABI break notification in commit log of PATCH 1/5
>> 2. fix missing help string/document in testpmd cmdline (Bernard Iremonger's
>>comments)
>>
>> V4:
>> 1. rebased to the latest code.
>> 2
On 05/04/19 4:49 PM, Shreyansh Jain wrote:
> On 05/04/19 3:13 AM, Thomas Monjalon wrote:
>> 04/04/2019 23:29, Ferruh Yigit:
>>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
Removes some unused firmware code which was added in last bump
of the firmware version. No current features uses these
On 4/5/2019 12:19 PM, Shreyansh Jain wrote:
> On 05/04/19 3:13 AM, Thomas Monjalon wrote:
>> 04/04/2019 23:29, Ferruh Yigit:
>>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
Removes some unused firmware code which was added in last bump
of the firmware version. No current features uses thes
On 4/5/2019 10:05 AM, Qi Zhang wrote:
> ---
> v5:
> 1. add ABI break notification in commit log of PATCH 1/5
> 2. fix missing help string/document in testpmd cmdline (Bernard Iremonger's
>comments)
>
> V4:
> 1. rebased to the latest code.
> 2. deleted misleading statement.
>
> V3:
> 1. fixed
On Fri, Apr 05, 2019 at 10:17:47AM +0200, David Marchand wrote:
> Currently, when symbols get promoted from the EXPERIMENTAL section to a
> stable ABI section, the script complains they should go to the
> EXPERIMENTAL section.
>
> Example:
> ERROR: symbol rte_devargs_add is added in the DPDK_19.05
On 05/04/19 3:13 AM, Thomas Monjalon wrote:
> 04/04/2019 23:29, Ferruh Yigit:
>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
>>> Removes some unused firmware code which was added in last bump
>>> of the firmware version. No current features uses these APIs.
>>>
>>> Signed-off-by: Shreyansh Jain
>>
>
> This patchset fixes the issue of the first inbound packet
> being dropped for inline crypto.
>
> Changes in v3:
> --
> The previous refactoring of the create_session() function has been dropped.
> The create_session() function is now called from sa_init() at startup.
>
> The f
1 - 100 of 135 matches
Mail list logo
