01/04/2019 13:05, Dekel Peled:
> This patch adds file to "Ethernet API" section of MAINTAINERS file:
> F: doc/guides/prog_guide/switch_representation.rst
>
> Fixes: b7f859c9a9a5 ("doc: add switch representation documentation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dekel Peled
Acked-by: Thomas
> -Original Message-
> From: Zhao1, Wei
> Sent: Monday, April 1, 2019 2:25 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo
> ; Stillwell Jr, Paul M ;
> Zhao1, Wei
> Subject: [PATCH v3] net/ixgbe: enable 10Mb/s link setup for x553
>
> This patch enable 10Mb/s link
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, April 4, 2019 10:28 AM
> To: Zhang, Qi Z ; Lu, Wenzhuo
> Cc: dev@dpdk.org; Stillwell Jr, Paul M
> Subject: RE: [PATCH] net/ice: send driver version to firmware
>
>
>
> -Original Message-
> From: Zhang, Qi Z
> Sent:
Tx VLAN & QinQ insert enable need not depend on
Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
insert enable, error check is now to see if QinQ was enabled
but only single VLAN id is set.
Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx VLAN")
Cc: xiao.w.w...@intel.com
S
01/04/2019 13:06, Dekel Peled:
> Remove redundant item 'a4' in comment.
>
> Fixes: 86c743cf9140 ("eal: define generic vector types")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dekel Peled
Applied, thanks
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shah...@mellanox.com
Signed-off-by: Nithin Dabilpuram
---
v3:
* Rename headline
v2:
* Spli
On Thu, Apr 04, 2019 at 05:03:43PM -0700, Stephen Hemminger wrote:
The function rte_vlan_insert may allocate a new buffer for the
vlan header and return a different mbuf than originally passed.
In this case, the stored mbuf in txm[] array could point to wrong
buffer.
Fixes: dd856dfcb9e7 ("virtio
> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, April 3, 2019 10:26 AM
> To: David Harton ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Zhang, Qi Z
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation
>
> HI,
>
> Why not add some more co
03/04/2019 13:04, Dekel Peled:
> Update broken links, replace with valid links.
>
> Fixes: 7798f17a0d62 ("doc: add documentation guidelines")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dekel Peled
Applied, thanks
15/03/2019 11:39, Kovacevic, Marko:
> > This patch fixes two typos in the coding style part of DPDK contributing
> > guide:
> >
> > - The header entry should have .h file instead of .c file.
> > - The will->This will
> >
> > Fixes: 44a6dface13b ("doc: describe how to add new components")
+Cc: s
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Wednesday, April 3, 2019 11:59 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default
>
> This patch stopped lldp by default to
On 4/5/19 1:23 AM, Thomas Monjalon wrote:
Hi,
02/04/2019 10:44, Andrew Rybchenko:
On 4/2/19 11:25 AM, Jerin Jacob Kollanukkaran wrote:
On Tue, 2019-04-02 at 10:36 +0300, Andrew Rybchenko wrote:
On 4/2/19 3:47 AM, Jerin Jacob Kollanukkaran wrote:
On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybc
On 4/5/19 1:01 AM, Thomas Monjalon wrote:
Hi,
You forgot to Cc Andrew, co-maintainer of ethdev.
20/03/2019 05:54, Qi Zhang:
Device reset should be implemented in an async way since it is
possible to be invoked in interrupt thread and sometimes to reset a
device need to wait for some dependency
On Thu, Apr 04, 2019 at 10:10:15AM -0700, Stephen Hemminger wrote:
> On Thu, 4 Apr 2019 11:45:45 +
> Hemant Agrawal wrote:
>
> > These APIs are available in DPDK for last 4 releases
> > and used by multiple drivers.
> >
> > Cc: gaetan.ri...@6wind.com
> >
> > Signed-off-by: Hemant Agrawal
>
Currently, when symbols get promoted from the EXPERIMENTAL section to a
stable ABI section, the script complains they should go to the
EXPERIMENTAL section.
Example:
ERROR: symbol rte_devargs_add is added in the DPDK_19.05 section, but is
expected to be added in the EXPERIMENTAL section of the ver
25/03/2019 11:20, Kovacevic, Marko:
> > Subject: [PATCH] doc: fix a typo in procinfo guide
> >
> > This patch fixes a trivial info in proc info section.
> > informationi=>information.
> >
> > Fixes: 8a37f37fc243 ("app/procinfo: add --show-port")
> >
> > Signed-off-by: Rami Rosen
>
> Acked-by:
19/03/2019 18:19, Neil Horman:
> On Tue, Mar 19, 2019 at 03:05:18PM +0100, David Marchand wrote:
> > The doc examples are not aligned on the script following the
> > incriminated commit.
> >
> > Fixes: c4a5fe3bf832 ("devtools: rework ABI checker script")
> > Cc: sta...@dpdk.org
> >
> > Cc: Olivie
https://bugs.dpdk.org/show_bug.cgi?id=239
Bug ID: 239
Summary: ipsec-secgw fails to initialize when librte_ipsec is
enabled
Product: DPDK
Version: unspecified
Hardware: ARM
OS: Linux
Status: CONF
01/04/2019 16:56, Mcnamara, John:
> From: Varghese, Vipin
> > doc/guides/howto/debug_troubleshoot_guide.rst | 465 ++
> > doc/guides/howto/index.rst| 1 +
> > +.. note::
> > +
> > + It is difficult to cover all possible issues; in a single attempt.
> > + With `
Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x")
Signed-off-by: Viacheslav Ovsiienko
v2:
rebasing only
v1:
http://patches.dpdk.org/patch/52056/
---
drivers/net/mlx5/mlx5.c | 14 +++---
drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++---
From: Qiming Yang
This patch added VXLAN-GPE macro in rte_eth_tunnel_type.
This patch will break the ABI, RTE_TUNNEL_TYPE_MAX will have
problem when running with new version of the ethdev shared
library.
Signed-off-by: Qiming Yang
---
lib/librte_ethdev/rte_eth_ctrl.h | 1 +
1 file changed, 1 i
---
v5:
1. add ABI break notification in commit log of PATCH 1/5
2. fix missing help string/document in testpmd cmdline (Bernard Iremonger's
comments)
V4:
1. rebased to the latest code.
2. deleted misleading statement.
V3:
1. fixed issue in release note.
2. fixed check patch issue.
3. spilted
From: Qiming Yang
Added VXLAN-GPE tunnel filter, supported filter to queue.
Signed-off-by: Qiming Yang
Acked-by: Qi Zhang
---
drivers/net/i40e/i40e_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index f382013c4..
From: Qiming Yang
Add new protocol type VXLAN-GPE support for UDP tunnel.
inner IP/TCP/UDP checksum and RSS configuration shared
the same implementation of VXLAN.
Signed-off-by: Qiming Yang
Acke-by: Qi Zhang
---
drivers/net/i40e/i40e_ethdev.c | 13 +
1 file changed, 9 insertions(+
From: Qiming Yang
Updated release note.
Signed-off-by: Qiming Yang
---
doc/guides/rel_notes/release_19_05.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_notes/release_19_05.rst
index 2acb42e45..62f4741e9 100644
--- a/doc/
From: Qiming Yang
This patch added new item "vxlan-gpe" to tunnel_type to
support new VXLAN-GPE packet type, and its clasification.
Signed-off-by: Qiming Yang
---
app/test-pmd/cmdline.c | 19 ---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +++
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, April 3, 2019 9:59 PM
> To: Kiran Kumar Kokkilagadda
> Cc: dev@dpdk.org; Jerin Jacob
> Subject: [EXT] Re: [dpdk-dev] [PATCH v2] kni: add IOVA va support for kni
>
> External Email
>
> ---
Hi all,
Here is a new stable release:
https://fast.dpdk.org/rel/dpdk-18.08.1.tar.xz
The git tree is at:
https://dpdk.org/browse/dpdk-stable/?h=18.08
Information about the validation of this stable release can
be found in the release note:
http://doc.dpdk.org/guides-18.08/
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
> Sent: Friday, April 5, 2019 10:06 AM
> To: Yigit, Ferruh ; Zhang, Qi Z
> ; Iremonger, Bernard
> Cc: dev@dpdk.org; Yang, Qiming
> Subject: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro
>
> F
> -Original Message-
> From: David Christensen
> Sent: Thursday, April 4, 2019 22:06
> To: Slava Ovsiienko ; dev@dpdk.org
> Cc: Shahaf Shuler
> Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix device probing for old
> kernel drivers
>
> > Retrieving network interface index via Netlink f
On 4/5/2019 10:36 AM, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
>> Sent: Friday, April 5, 2019 10:06 AM
>> To: Yigit, Ferruh ; Zhang, Qi Z
>> ; Iremonger, Bernard
>> Cc: dev@dpdk.org; Yang, Qiming
>> Subject: [
Hi,
Sorry for not catching it before, but I was not Cc.
Please use git send-email --to-cmd devtools/get-maintainer.sh
05/04/2019 11:42, Ferruh Yigit:
> On 4/5/2019 10:36 AM, Ananyev, Konstantin wrote:
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
> >> From: Qiming Yang
> >>
>
On Wed, Apr 3, 2019 at 7:16 PM Stephen Hemminger
wrote:
> diff --git a/lib/librte_eal/common/eal_common_lcore.c
> b/lib/librte_eal/common/eal_common_lcore.c
> index 1cbac42286ba..806204d9f73d 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
On 4/5/2019 11:37 AM, Thomas Monjalon wrote:
> Hi,
>
> Sorry for not catching it before, but I was not Cc.
> Please use git send-email --to-cmd devtools/get-maintainer.sh
>
> 05/04/2019 11:42, Ferruh Yigit:
>> On 4/5/2019 10:36 AM, Ananyev, Konstantin wrote:
>>> From: dev [mailto:dev-boun...@dpdk
>
> Fix xform initialisation.
> Fix testsuite_setup.
> Remove unused variables.
>
> Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup")
>
> Signed-off-by: Bernard Iremonger
> ---
> Changes in v3:
> drop changes to logic aro
>
> This patchset fixes the issue of the first inbound packet
> being dropped for inline crypto.
>
> Changes in v3:
> --
> The previous refactoring of the create_session() function has been dropped.
> The create_session() function is now called from sa_init() at startup.
>
> The f
On 05/04/19 3:13 AM, Thomas Monjalon wrote:
> 04/04/2019 23:29, Ferruh Yigit:
>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
>>> Removes some unused firmware code which was added in last bump
>>> of the firmware version. No current features uses these APIs.
>>>
>>> Signed-off-by: Shreyansh Jain
>>
On Fri, Apr 05, 2019 at 10:17:47AM +0200, David Marchand wrote:
> Currently, when symbols get promoted from the EXPERIMENTAL section to a
> stable ABI section, the script complains they should go to the
> EXPERIMENTAL section.
>
> Example:
> ERROR: symbol rte_devargs_add is added in the DPDK_19.05
On 4/5/2019 10:05 AM, Qi Zhang wrote:
> ---
> v5:
> 1. add ABI break notification in commit log of PATCH 1/5
> 2. fix missing help string/document in testpmd cmdline (Bernard Iremonger's
>comments)
>
> V4:
> 1. rebased to the latest code.
> 2. deleted misleading statement.
>
> V3:
> 1. fixed
On 4/5/2019 12:19 PM, Shreyansh Jain wrote:
> On 05/04/19 3:13 AM, Thomas Monjalon wrote:
>> 04/04/2019 23:29, Ferruh Yigit:
>>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
Removes some unused firmware code which was added in last bump
of the firmware version. No current features uses thes
On 05/04/19 4:49 PM, Shreyansh Jain wrote:
> On 05/04/19 3:13 AM, Thomas Monjalon wrote:
>> 04/04/2019 23:29, Ferruh Yigit:
>>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
Removes some unused firmware code which was added in last bump
of the firmware version. No current features uses these
On 4/5/2019 12:31 PM, Ferruh Yigit wrote:
> On 4/5/2019 10:05 AM, Qi Zhang wrote:
>> ---
>> v5:
>> 1. add ABI break notification in commit log of PATCH 1/5
>> 2. fix missing help string/document in testpmd cmdline (Bernard Iremonger's
>>comments)
>>
>> V4:
>> 1. rebased to the latest code.
>> 2
On 4/4/19 4:25 PM, Adrien Mazarguil wrote:
Hi Ori,
(trimming message down a bit)
On Thu, Apr 04, 2019 at 09:01:52AM +, Ori Kam wrote:
Hi Adrien,
PSB
From: Adrien Mazarguil
On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote:
Thanks, PSB.
From: Adrien Mazarguil
I sti
This patch implements the changes proposed in the deprecation
note[1].
Replace mulitple color definitions in various places such as
rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
in rte_meter.h.
[1] https://mails.dpdk.org/archives/dev/2019-January/123861.html
Signed-off-by: Ja
From: Nithin Dabilpuram
Tx VLAN & QinQ insert enable need not depend on
Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
insert enable, error check is now to see if QinQ was enabled
but only single VLAN id is set.
Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx VLAN")
Cc
From: Nithin Dabilpuram
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shah...@mellanox.com
Signed-off-by: Nithin Dabilpuram
Acked-by: B
Rx refill in one bulk (which is just 8 descriptors) by default is too
aggressive and makes too many MMIO writes (Rx doorbells) if packet rate
is high. Setting default to 1/8 of Rx descriptors number shows good
performance results. Anyway it is a default value which may be
overridden by Rx configura
On 4/5/2019 1:04 PM, Nithin Dabilpuram wrote:
> From: Nithin Dabilpuram
>
> Tx VLAN & QinQ insert enable need not depend on
> Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
> insert enable, error check is now to see if QinQ was enabled
> but only single VLAN id is set.
>
> Fixes: 6a34f9169
05/04/2019 13:38, Shreyansh Jain:
> On 05/04/19 4:49 PM, Shreyansh Jain wrote:
> > On 05/04/19 3:13 AM, Thomas Monjalon wrote:
> >> 04/04/2019 23:29, Ferruh Yigit:
> >>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
> Removes some unused firmware code which was added in last bump
> of the fi
On 27-Mar-19 11:33 AM, Akhil Goyal wrote:
link check is done for primary process for the ports
which are given in the port mask and not the complete
set of ports.
Fixes: d3641ae86313 ("examples: update link status checks")
Cc: sta...@dpdk.org
Signed-off-by: Akhil Goyal
---
Acked-by: Anatoly
The patch allowing to retrieve the network interface index and name via Netlink:
https://www.spinics.net/lists/linux-rdma/msg62948.html
In Linux tree: 5b2cc79d (Leon Romanovsky 2018-03-27 20:40:49 +0300 270)
So, the problem depends on ib_core module version - 4.16 supports getting
ifindex via Netl
27/03/2019 12:37, Ferruh Yigit:
> On 3/26/2019 10:04 AM, Chaitanya Babu, TalluriX wrote:
> > From: Yigit, Ferruh
> >> On 3/8/2019 2:02 PM, Bruce Richardson wrote:
> >>> On Fri, Mar 08, 2019 at 12:45:50PM +, Chaitanya Babu Talluri wrote:
> Replace strcat with strlcat to avoid buffer overflo
On 05/04/19 6:05 PM, Thomas Monjalon wrote:
> 05/04/2019 13:38, Shreyansh Jain:
>> On 05/04/19 4:49 PM, Shreyansh Jain wrote:
>>> On 05/04/19 3:13 AM, Thomas Monjalon wrote:
04/04/2019 23:29, Ferruh Yigit:
> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
>> Removes some unused firmware cod
27/03/2019 12:33, Akhil Goyal:
> link check is done for primary process for the ports
> which are given in the port mask and not the complete
> set of ports.
>
> Fixes: d3641ae86313 ("examples: update link status checks")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Akhil Goyal
> ---
>
Hi Ferruh,
Yes, our mail server had some issue and was inserting CRLF chars. So I sent
the same v3 as v4 from gmail.
Thanks
Nithin
On Fri, Apr 5, 2019 at 5:36 PM Ferruh Yigit wrote:
> On 4/5/2019 1:04 PM, Nithin Dabilpuram wrote:
> > From: Nithin Dabilpuram
> >
> > Tx VLAN & QinQ insert enabl
Clarify the fact that mask bits should be set in rte_eth_reta_query.
v2:
- Change documentation string as suggested by Ferruh
Signed-off-by: Tom Barbette
---
lib/librte_ethdev/rte_ethdev.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib
On 04/04/2019 14:10, Bruce Richardson wrote:
> On Thu, Apr 04, 2019 at 02:05:27PM +0100, Ray Kinsella wrote:
>>
>>
>> On 04/04/2019 13:02, Luca Boccassi wrote:
>>> On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote:
On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote:
>>
Retrieving network interface index via Netlink fails in
case of old ib_core kernel driver installed - mlx5_nl_ifindex()
routine fails due to RDMA_NLDEV_ATTR_NDEV_INDEX attribute is not
supported by the old driver.
The patch allowing to retrieve the network interface index and
name via Netlink [1].
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
---
v5:
* enhance logging
v4:
* [vm_power_manager] treat 0 as valid socket id
* [guest_manager] use user level logs
* correct code f
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta...@dpdk.org
Sign
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 68 +++--
1 file changed, 62 insertions(+), 6 deletions(-)
diff --git a/examples/vm_power
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 73 +++
2 files changed, 6
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 60
At the mlx5 device closing the shared IB context was destroyed
before cleanup routines completion. As it was found on some
setups (Netlink fails with old kernel drivers and we have to use
sysfs to retrieve interface index, this requires IB device name,
which is stored in shared context) the mlx5_nl
On 04/04/2019 20:08, Wiles, Keith wrote:
>
>
>> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote:
>>
>> On 04/04/2019 11:54, Bruce Richardson wrote:
>>
> ABI breaks should be handled by the board. As for new APIs they are not so
> bad and they do not need to be approved by the board just ha
On 04/04/2019 21:13, Kevin Traynor wrote:
> On 04/04/2019 20:08, Wiles, Keith wrote:
>>
>>
>>> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote:
>>>
>>> On 04/04/2019 11:54, Bruce Richardson wrote:
>>>
>>>
My thoughts on the matter are:
1. I think we really need to do work to st
On 4/5/2019 2:10 PM, Nithin Kumar D wrote:
> Hi Ferruh,
>
> Yes, our mail server had some issue and was inserting CRLF chars. So I sent
> the same v3 as v4 from gmail.
If the content is same I will continue with v3, thanks.
>
> Thanks
> Nithin
>
> On Fri, Apr 5, 2019 at 5:36 PM Ferruh Yigit w
27/03/2019 18:25, Luca Boccassi:
> On Wed, 2019-03-27 at 17:22 +, Kevin Traynor wrote:
> > If a stable branch for a specific DPDK release is to proceed,
> > along with needing a maintainer, there should also be commitment
> > from major contributors for validation of the releases.
> >
> > Also
On 4/5/2019 8:36 AM, Nithin Kumar Dabilpuram wrote:
> Tx VLAN & QinQ insert enable need not depend on
> Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
> insert enable, error check is now to see if QinQ was enabled
> but only single VLAN id is set.
>
> Fixes: 6a34f91690d0 ("app/testpmd: fix e
On 4/5/2019 2:13 PM, Tom Barbette wrote:
> Clarify the fact that mask bits should be set in rte_eth_reta_query.
>
> v2:
> - Change documentation string as suggested by Ferruh
>
> Signed-off-by: Tom Barbette
Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
07/02/2019 16:39, Kevin Traynor:
> Update the LTS section to mention the branch, how LTS support ends
> and update the currently maintained LTS branches.
The current branches were updated in another patch.
> Signed-off-by: Kevin Traynor
> Acked-by: Aaron Conole
> ---
[...]
> +At the end of the
A few coverity fixes, along with a fix for one of the examples meson.build
files which I caught along the way.
Bruce Richardson (5):
examples/vhost_scsi: fix header check for meson build
examples/vhost_scsi: fix missing NULL-check for parameter
net/i40e: fix dereference before NULL check in
Coverity points out that there is a check in the main thread loop for the
ctrlr->bdev being NULL, but by that stage the pointer has already been
dereferenced. Therefore, for safety, before we enter the loop do an
initial check on the parameter structure.
Coverity issue: 158657
Fixes: db75c7af19bb
The header check for the example app was looking for virtio_scsi.h without
the "linux/" prefix, which meant it was never getting found when it should
have been.
Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency")
CC: sta...@dpdk.org
CC: Maxime Coquelin
CC: Tiwei Bie
The value returned from rte_eth_dev_tx_offload_name() function is used
for string comparison before being checked for NULL. Move the NULL check
up to be done first.
Coverity issue: 279438
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: wei@intel.com
Cc: sta...@dpd
Coverity flags that the txq variable is used before it's checked for NULL.
Coverity issue: 195023
Fixes: 24853544c84c ("net/i40e: fix mbuf free in vector Tx")
Cc: qi.z.zh...@intel.com
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/i40e/i40e_rxtx.c | 4 ++--
1 file changed,
The rte_rand() documentation left it unspecified if the rte_rand() was
multi-thread safe or not, and the implementation (based on lrand48())
was not.
This commit makes rte_rand() safe to use from any lcore thread by
using lrand48_r() and per-lcore random state structs. Besides the
obvious improvem
As flagged by coverity, the "info" structure is being explicitly
dereferenced before being checked later for a NULL value.
Coverity issue: 277241
Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
CC: sta...@dpdk.org
Cc: zijie@6wind.com
CC: Beilei Xing
CC: Qi Zhang
Signe
On 2019-04-05 15:45, Mattias Rönnblom wrote:
The rte_rand() documentation left it unspecified if the rte_rand() was
multi-thread safe or not, and the implementation (based on lrand48())
was not.
This commit makes rte_rand() safe to use from any lcore thread by
using lrand48_r() and per-lcore ran
This patch implements the changes proposed in the deprecation
note[1]. Replace multiple color definitions in various places such as
rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
in rte_meter.h.
This is simple search and replace exercise without any implementation
change.
[1] h
> -Original Message-
> From: Singh, Jasvinder
> Sent: Friday, April 5, 2019 2:55 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian
> Subject: [PATCH v3] meter: replace color definitions with rte_color values
>
> This patch implements the changes proposed in the deprecation
> note[1]. Re
On 4/5/2019 1:05 PM, Andrew Rybchenko wrote:
> Rx refill in one bulk (which is just 8 descriptors) by default is too
> aggressive and makes too many MMIO writes (Rx doorbells) if packet rate
> is high. Setting default to 1/8 of Rx descriptors number shows good
> performance results. Anyway it is a
Acked-By: Rami Rosen
In this occasion I noticed that there is a typo in the code that appears in
the patch;
it should be "Pointer to txq" instead of "Pointer to rxq":
I would consider resending and fixing it on this occasion:
> if (!txq || !txq->sw_ring) {
> PMD_DRV_LOG(DEBUG, "Po
Acked-by: Rami Rosen
Acked-By: Rami Rosen
On Fri, Apr 05, 2019 at 03:51:39PM +0200, Mattias Rönnblom wrote:
> On 2019-04-05 15:45, Mattias Rönnblom wrote:
> > The rte_rand() documentation left it unspecified if the rte_rand() was
> > multi-thread safe or not, and the implementation (based on lrand48())
> > was not.
> >
> > This commit mak
From: Marcin Hajkowski
Due to lack of thread safety in exisiting solution
use spinlock mechanism for atomic
modification of power environment related data.
Fixes: 445c6528b5 ("power: common interface for guest and host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Bur
A few coverity fixes, along with a fix for one of the examples meson.build
files which I caught along the way.
v2: include a typo fix identified by Rami Rosen.
Bruce Richardson (5):
examples/vhost_scsi: fix header check for meson build
examples/vhost_scsi: fix missing NULL-check for parameter
The header check for the example app was looking for virtio_scsi.h without
the "linux/" prefix, which meant it was never getting found when it should
have been.
Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency")
CC: sta...@dpdk.org
CC: Maxime Coquelin
CC: Tiwei Bie
Coverity flags that the txq variable is used before it's checked for NULL.
Also fix typo in error message.
Coverity issue: 195023
Fixes: 24853544c84c ("net/i40e: fix mbuf free in vector Tx")
Cc: qi.z.zh...@intel.com
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
Acked-By: Rami Rosen
---
V
Coverity points out that there is a check in the main thread loop for the
ctrlr->bdev being NULL, but by that stage the pointer has already been
dereferenced. Therefore, for safety, before we enter the loop do an
initial check on the parameter structure.
Coverity issue: 158657
Fixes: db75c7af19bb
The value returned from rte_eth_dev_tx_offload_name() function is used
for string comparison before being checked for NULL. Move the NULL check
up to be done first.
Coverity issue: 279438
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: wei@intel.com
Cc: sta...@dpd
As flagged by coverity, the "info" structure is being explicitly
dereferenced before being checked later for a NULL value.
Coverity issue: 277241
Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
CC: sta...@dpdk.org
Cc: zijie@6wind.com
CC: Beilei Xing
CC: Qi Zhang
Signe
On 4/4/2019 8:34 PM, Shahaf Shuler wrote:
> Allocated mempools were never free. it is bad practice.
+1
>
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Shahaf Shuler
<...>
> @@ -835,7 +837,7 @@ setup_extmem(uint32_t nb_mbufs, uint32_t mbuf_sz, bool
>
On 5/22/2018 11:17 PM, Thomas Monjalon wrote:
> 12/12/2017 11:05, Nikhil Agarwal:
>> Currently, if the rte_eth_rx_burst() function returns a value less than
>> *nb_pkts*, the application will assume that no more packets are present.
>>
>> Some of the hw queue based hardware can only support smalle
On 2019-04-05 16:28, Bruce Richardson wrote:
On Fri, Apr 05, 2019 at 03:51:39PM +0200, Mattias Rönnblom wrote:
On 2019-04-05 15:45, Mattias Rönnblom wrote:
The rte_rand() documentation left it unspecified if the rte_rand() was
multi-thread safe or not, and the implementation (based on lrand48()
On 4/5/2019 3:55 PM, Ferruh Yigit wrote:
> On 5/22/2018 11:17 PM, Thomas Monjalon wrote:
>> 12/12/2017 11:05, Nikhil Agarwal:
>>> Currently, if the rte_eth_rx_burst() function returns a value less than
>>> *nb_pkts*, the application will assume that no more packets are present.
>>>
>>> Some of the
On 5/24/2018 5:58 PM, Thomas Monjalon wrote:
> 09/01/2018 16:44, Ferruh Yigit:
>> +* If changes effect other parts of the project, update all those parts as
>> well unless updating requires special knowledge.
>> + For the cases where not all the effected code is updated, the submitter
>> should
On 4/5/2019 4:00 PM, Ferruh Yigit wrote:
> On 5/24/2018 5:58 PM, Thomas Monjalon wrote:
>> 09/01/2018 16:44, Ferruh Yigit:
>>> +* If changes effect other parts of the project, update all those parts as
>>> well unless updating requires special knowledge.
>>> + For the cases where not all the effe
On 1/25/2018 3:40 AM, Simon Guo wrote:
>
> Hi Konstantin,
> On Thu, Jan 18, 2018 at 12:14:05PM +, Ananyev, Konstantin wrote:
>> Hi Simon,
>>
>>>
>>> Hi, Konstantin,
>>> On Tue, Jan 16, 2018 at 12:38:35PM +, Ananyev, Konstantin wrote:
> -Original Message-
> From: d
1 - 100 of 135 matches
Mail list logo
