Re: [dpdk-dev] [PATCH] doc: fix doc build with latest meson

2019-07-05 Thread Thomas Monjalon
05/07/2019 18:31, Luca Boccassi: > On Fri, 2019-07-05 at 16:56 +0100, Bruce Richardson wrote: > > The latest versions of meson don't build targets when > > build_by_default is > > false but install is true, unlike older versions. We can fix this by > > having > > both build_by_default and install s

Re: [dpdk-dev] [PATCH v3 1/1] timer: fix resource leak in finalize

2019-07-05 Thread Thomas Monjalon
05/07/2019 19:22, Anatoly Burakov: > Currently, whenever timer library is initialized, the memory > is leaked because there is no telling when primary or secondary > processes get to use the state, and there is no way to > initialize/deinitialize timer library state without race > conditions [1] be

Re: [dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public

2019-07-05 Thread Thomas Monjalon
05/07/2019 19:26, Anatoly Burakov: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > A lot of the patchset is a search-and-replace job and should > be pretty easy to review. The rest are pretty trivial EAL > changes

Re: [dpdk-dev] [PATCH] test/table: skip when not enough memory is available

2019-07-05 Thread Thomas Monjalon
Hi, 05/07/2019 19:54, Dumitrescu, Cristian: > From: David Marchand [mailto:david.march...@redhat.com] > > Following empirical tries, this test wants at least 3300M of memory to > > run. > > > > Signed-off-by: David Marchand > > Yes, some tests need large amounts of memory. Basic tests should n

Re: [dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public

2019-07-05 Thread David Marchand
On Fri, Jul 5, 2019 at 7:26 PM Anatoly Burakov wrote: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > A lot of the patchset is a search-and-replace job and should > be pretty easy to review. The rest are pretty t

[dpdk-dev] [Bug 298] BPF: eval_call() is messing bounds of return types different of RTE_BPF_ARG_RAW

2019-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=298 Michel Machado (mic...@digirati.com.br) changed: What|Removed |Added Resolution|--- |FIXED Status

Re: [dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config

2019-07-05 Thread Thomas Monjalon
05/07/2019 19:26, Anatoly Burakov: > --- a/lib/librte_eal/common/include/rte_fbarray.h > +++ b/lib/librte_eal/common/include/rte_fbarray.h > @@ -34,7 +34,6 @@ > extern "C" { > #endif > > -#include > #include It triggers some compilation errors in mlx4 and mlx5: fatal error: unknown

Re: [dpdk-dev] [PATCH v4 2/3] lib/lpm: memory orderings to avoid race conditions for v20

2019-07-05 Thread Vladimir Medvedkin
Hi all, пт, 5 июл. 2019 г. в 17:52, Medvedkin, Vladimir < vladimir.medved...@intel.com>: > Hi Wang, > > On 03/07/2019 06:44, Ruifeng Wang wrote: > > When a tbl8 group is getting attached to a tbl24 entry, lookup > > might fail even though the entry is configured in the table. > > > > For ex: cons

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-05 Thread Yongseok Koh
> On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil > wrote: > > On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: >> A tag is a transient data which can be used during flow match. This can be >> used to store match result from a previous table so that the same pattern >> need not be m

Re: [dpdk-dev] [PATCH] test/table: skip when not enough memory is available

2019-07-05 Thread Dumitrescu, Cristian
Hi David, > -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, July 5, 2019 10:19 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] test/table: skip when not enough memory is available > > Following empirical tries, this test wa

[dpdk-dev] [PATCH v5 9/9] eal: prevent different primary/secondary process versions

2019-07-05 Thread Anatoly Burakov
Currently, nothing stops DPDK to attempt to run primary and secondary processes while having different versions. This can lead to all sorts of weird behavior and makes it harder to maintain compatibility without breaking ABI every once in a while. Fix it by explicitly disallowing running different

[dpdk-dev] [PATCH v5 8/9] eal: unify internal config initialization

2019-07-05 Thread Anatoly Burakov
Currently, each EAL will update internal/shared config in their own way at init, resulting in needless duplication of code and OS-dependent behavior. Move the functions to a common file and add missing FreeBSD steps. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: David Marc

[dpdk-dev] [PATCH v5 6/9] eal: uninline wait for mcfg complete function

2019-07-05 Thread Anatoly Burakov
Currently, the function to wait until config completion is static inline for no reason. Move its implementation to an EAL common file. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/common/eal_common_mcfg.c | 10 ++ lib/librte_eal

[dpdk-dev] [PATCH v5 7/9] eal: unify and move mcfg complete function

2019-07-05 Thread Anatoly Burakov
Currently, mcfg completion function exists in two independent implementations doing the same thing, which is bug prone. Unify the two functions and move them into one place. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/common/eal_common

[dpdk-dev] [PATCH v5 5/9] eal: remove packed attribute from mcfg structure

2019-07-05 Thread Anatoly Burakov
There is no reason to pack the memconfig structure, and doing so gives out warnings in some static analyzers. Fix it by removing the packed attributed. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/common/eal_memcfg.h | 2 +- 1 file chan

[dpdk-dev] [PATCH v5 3/9] eal: add new API to lock/unlock mempool list

2019-07-05 Thread Anatoly Burakov
Currently, in order to lock access to the mempool list, a direct access to the shared memory structure is needed. Add an API to do the same, and search-and-replace all usages. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/common/eal_comm

[dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config

2019-07-05 Thread Anatoly Burakov
Now that everything that has ever accessed the shared memory config is doing so through the public API's, we can make it internal. Since we're removing quite a few headers from rte_eal_memconfig.h, we need to add them back in places where this header is used. This bumps the ABI, so also change all

[dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public

2019-07-05 Thread Anatoly Burakov
This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls. A lot of the patchset is a search-and-replace job and should be pretty easy to review. The rest are pretty trivial EAL changes. v5: - Accidentally squashed last patch into an

[dpdk-dev] [PATCH v5 2/9] eal: add EAL tailq list lock/unlock API

2019-07-05 Thread Anatoly Burakov
Currently, locking/unlocking the TAILQ list requires direct access to the shared memory config. Add an API to do the same, and search-and-replace all usages. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_acl/rte_acl.c |

[dpdk-dev] [PATCH v5 1/9] eal: add API to lock/unlock memory hotplug

2019-07-05 Thread Anatoly Burakov
Currently, the memory hotplug is locked automatically by all memory-related _walk() functions, but sometimes locking the memory subsystem outside of them is needed. There is no public API to do that, so it creates a dependency on shared memory config to be public. Fix this by introducing a new API

[dpdk-dev] [PATCH v3 1/1] timer: fix resource leak in finalize

2019-07-05 Thread Anatoly Burakov
Currently, whenever timer library is initialized, the memory is leaked because there is no telling when primary or secondary processes get to use the state, and there is no way to initialize/deinitialize timer library state without race conditions [1] because the data itself must live in shared mem

[dpdk-dev] [PATCH v3 0/1] Fix timer resource leak

2019-07-05 Thread Anatoly Burakov
Previous attempts [1] at fixing the resource leak have been deemed unsuccessful because of limitations around what can be done without breaking the ABI. Now that we've broken the EAL ABI, we can fix this issue properly. This patchset is adding a new lock API, as well as fixes the actual issue. Th

[dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages

2019-07-05 Thread Fiona Trahe
Use ERR rather than INFO to warn that it's a negative test else the errors are seen but the warning to expect them isn't. Also add comment to make it easier to follow code. Signed-off-by: Fiona Trahe --- app/test/test_compressdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) d

[dpdk-dev] [PATCH v8 11/11] net/memif: use common ethernet address parsing routine

2019-07-05 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index e9ddf6413597..00c9b396ab85

[dpdk-dev] [PATCH v8 07/11] app/testpmd: use new ethernet address parser

2019-07-05 Thread Stephen Hemminger
The cmdline_parse_ether_addr does not need to be used everywhere in testpmd. Can use rte_ether_unformat_addr instead. As an added bonus it eliminates some code for copying. Signed-off-by: Stephen Hemminger Acked-by: Bernard Iremonger --- app/test-pmd/cmdline_flow.c | 5 ++--- app/test-pmd/conf

[dpdk-dev] [PATCH v8 10/11] net/vdev_netvsc: use common ethernet address parsing

2019-07-05 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_ne

[dpdk-dev] [PATCH v8 09/11] net/failsafe: use common ether address parsing routine

2019-07-05 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args

[dpdk-dev] [PATCH v8 06/11] net/bonding: use new ethernet address parser

2019-07-05 Thread Stephen Hemminger
The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile| 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +- 3 fil

[dpdk-dev] [PATCH v8 08/11] net/virtio: use new ether addr parsing

2019-07-05 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/

[dpdk-dev] [PATCH v8 05/11] cmdline: use new ethernet address parser

2019-07-05 Thread Stephen Hemminger
Now that there is a version of ether_aton in rte_ether, it can be used by the cmdline ethernet address parser. Note: ether_aton_r can not be used in cmdline because the old code would accept either bytes XX:XX:XX:XX:XX:XX or words :: and we need to keep compatiablity. Signed-off-by: S

[dpdk-dev] [PATCH v8 04/11] net/ether: use bitops to speedup comparison

2019-07-05 Thread Stephen Hemminger
Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko Acked-by: Olivier Matz --- lib/librte_net/r

[dpdk-dev] [PATCH v8 01/11] net/ether: deinline non-critical functions

2019-07-05 Thread Stephen Hemminger
Formatting Ethernet address and getting a random value are not in critical path so they should not be inlined. Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen Reviewed-by: Andrew Rybchenko Acked-by: Olivier Matz --- drivers/net/axgbe/Makefile | 2 +- drivers/net/memif/Makefile

[dpdk-dev] [PATCH v8 03/11] ethdev: use new ethernet parsing function

2019-07-05 Thread Stephen Hemminger
Use rte_eth_unformat_addr, so that ethdev can be built and work without the cmdline library. The dependency on cmdline was an arrangement of convenience anyway. Signed-off-by: Stephen Hemminger --- lib/Makefile | 1 - lib/librte_ethdev/Makefile| 2 +- lib/librte_ethd

[dpdk-dev] [PATCH v8 00/11] ether: improvements and optimizations

2019-07-05 Thread Stephen Hemminger
This is a collection of patches around the ethernet address manipulation routines in librte_net/rte_ether. v8 set rte_errno in rte_eth_unformat_addr drop ether_address alignment patch. Bruce can handle deprecation and sending the patches later v7 use rte_ether_unformat_addr in more dri

[dpdk-dev] [PATCH v8 02/11] net/ether: add function to convert string to ethernet address

2019-07-05 Thread Stephen Hemminger
Make a function that can be used in place of eth_aton_r to convert a string to rte_ether_addr. This function allows both byte (xx:xx:xx:xx:xx:xx) and word (::) format and has the same lack of error handling as the original. This also allows ethdev to no longer have a hard dependency on

[dpdk-dev] [PATCH v2] compress/qat: fixed overflow status return from qat pmd

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch fixes fail status returned from compression PMD in case destination buffer size is not enough to store all data. Fixes: 3dc9ef2d23fe ("compress/qat: fix returned status on overflow") Cc: sta...@dpdk.org Signed-off-by: Tomasz Jozwiak Signed-off-by: Adam Dybkowski

Re: [dpdk-dev] [PATCH v7 08/12] app/testpmd: use new ethernet address parser

2019-07-05 Thread Stephen Hemminger
On Wed, 3 Jul 2019 13:30:35 + "Iremonger, Bernard" wrote: > Hi Stephen, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Tuesday, July 2, 2019 11:13 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-

Re: [dpdk-dev] [PATCH v3 3/3] lib/lpm: memory orderings to avoid race conditions for v20

2019-07-05 Thread Medvedkin, Vladimir
Hi Alex, On 05/07/2019 14:45, Alex Kiselev wrote: Hi, As a general remark consider writing all of the tbl entries including tbl8 with atomic_store. Now "lpm->tbl8[j] = new_tbl8_entry;" is looks like 1e9: 44 88 9c 47 40 01 00mov %r11b,0x2000140(%rdi,%rax,2) <-write first by

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

2019-07-05 Thread Medvedkin, Vladimir
Hi Wang, On 03/07/2019 06:44, Ruifeng Wang wrote: Compiler could generate non-atomic stores for whole table entry updating. This may cause incorrect nexthop to be returned, if the byte with valid flag is updated prior to the byte with next hot is updated. Changed to use atomic store to update w

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

2019-07-05 Thread Medvedkin, Vladimir
Hi Alex, On 05/07/2019 14:37, Alex Kiselev wrote: пт, 5 июл. 2019 г. в 13:31, Medvedkin, Vladimir : Hi Stephen, On 28/06/2019 16:35, Stephen Hemminger wrote: On Fri, 28 Jun 2019 15:16:30 +0100 "Medvedkin, Vladimir" wrote: Hi Honnappa, On 28/06/2019 14:57, Honnappa Nagarahalli wrote: Hi a

Re: [dpdk-dev] [PATCH v4 2/3] lib/lpm: memory orderings to avoid race conditions for v20

2019-07-05 Thread Medvedkin, Vladimir
Hi Wang, On 03/07/2019 06:44, Ruifeng Wang wrote: When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 gr

Re: [dpdk-dev] [PATCH] doc: fix doc build with latest meson

2019-07-05 Thread Bruce Richardson
On Fri, Jul 05, 2019 at 05:30:49PM +0100, Luca Boccassi wrote: > On Fri, 2019-07-05 at 17:18 +0100, Luca Boccassi wrote: > > On Fri, 2019-07-05 at 16:56 +0100, Bruce Richardson wrote: > > > The latest versions of meson don't build targets when > > > build_by_default is > > > false but install is tr

Re: [dpdk-dev] [PATCH] doc: fix doc build with latest meson

2019-07-05 Thread Luca Boccassi
On Fri, 2019-07-05 at 16:56 +0100, Bruce Richardson wrote: > The latest versions of meson don't build targets when > build_by_default is > false but install is true, unlike older versions. We can fix this by > having > both build_by_default and install settings come from the build-time > option. >

Re: [dpdk-dev] [PATCH] doc: fix doc build with latest meson

2019-07-05 Thread Luca Boccassi
On Fri, 2019-07-05 at 17:18 +0100, Luca Boccassi wrote: > On Fri, 2019-07-05 at 16:56 +0100, Bruce Richardson wrote: > > The latest versions of meson don't build targets when > > build_by_default is > > false but install is true, unlike older versions. We can fix this > > by > > having > > both bui

Re: [dpdk-dev] [PATCH v2 3/3] bus/pci: only consider usable devices to select IOVA mode

2019-07-05 Thread Stephen Hemminger
On Fri, 5 Jul 2019 09:58:44 +0200 David Marchand wrote: > On Thu, Jul 4, 2019 at 7:14 PM Stephen Hemminger > wrote: > > > On Fri, 14 Jun 2019 11:39:17 +0200 > > David Marchand wrote: > > > > > /* Supports only RTE_KDRV_NIC_UIO */ > > > + if (pdev->kdrv != RTE_KDRV_NIC_UIO) > > > +

Re: [dpdk-dev] [PATCH] doc: fix doc build with latest meson

2019-07-05 Thread Luca Boccassi
On Fri, 2019-07-05 at 16:56 +0100, Bruce Richardson wrote: > The latest versions of meson don't build targets when > build_by_default is > false but install is true, unlike older versions. We can fix this by > having > both build_by_default and install settings come from the build-time > option. >

[dpdk-dev] [PATCH] doc: fix doc build with latest meson

2019-07-05 Thread Bruce Richardson
The latest versions of meson don't build targets when build_by_default is false but install is true, unlike older versions. We can fix this by having both build_by_default and install settings come from the build-time option. Bugzilla ID: 303 Fixes: d02a2dab2dfb ("doc: support building HTML guides

Re: [dpdk-dev] [PATCH v2] app/pdump: enforcing pdump to use sw mempool

2019-07-05 Thread Olivier Matz
hi, On Fri, Jul 05, 2019 at 03:40:20PM +, Harman Kalra wrote: > A secondary process cannot access HW mempool already > initiazed by primary, and neither it can setup its own > HW mempool due to its own restrictions. > > Since dpdk-pdump creates mempool for managing its local > mbufs, SW mempo

Re: [dpdk-dev] [PATCH v7 05/12] net/ether: mark ethernet addresses as being 2-byte aligned

2019-07-05 Thread Richardson, Bruce
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, July 5, 2019 3:34 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; Richardson, Bruce ; Andrew > Rybchenko > Subject: Re: [dpdk-dev] [PATCH v7 05/12] net/ether: mark ethernet > addresses as being 2-by

[dpdk-dev] [PATCH v2] app/pdump: enforcing pdump to use sw mempool

2019-07-05 Thread Harman Kalra
A secondary process cannot access HW mempool already initiazed by primary, and neither it can setup its own HW mempool due to its own restrictions. Since dpdk-pdump creates mempool for managing its local mbufs, SW mempool is capable enough to solve this purpose. Signed-off-by: Harman Kalra ---

Re: [dpdk-dev] [EXT] Re: [PATCH] app/pdump: enforcing pdump to use sw mempool

2019-07-05 Thread Thomas Monjalon
05/07/2019 16:39, Harman Kalra: > On Fri, Jul 05, 2019 at 03:48:01PM +0200, Olivier Matz wrote: > > On Thu, Jul 04, 2019 at 06:29:25PM +0200, Thomas Monjalon wrote: > > > 15/03/2019 16:27, Harman Kalra: > > > > Since pdump uses SW rings to manage packets hence > > > > pdump should use SW ring mempo

Re: [dpdk-dev] [PATCH v2 0/3] Improve automatic selection of IOVA mode

2019-07-05 Thread Thomas Monjalon
14/06/2019 11:39, David Marchand: > In SPDK, not all drivers are registered with DPDK at start up time. > Previously, that meant DPDK always chose to set itself up in IOVA_PA > mode. Instead, when the correct iova choice is unclear based on the > devices and drivers known to DPDK at start up time,

[dpdk-dev] [Bug 306] Intel X722 chipset DPDK driver issue with WindRiver Titianium R18.03 platform - CentOS 7.4

2019-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=306 Bug ID: 306 Summary: Intel X722 chipset DPDK driver issue with WindRiver Titianium R18.03 platform - CentOS 7.4 Product: DPDK Version: 17.11 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH v2] net: adjust layer 2 length on soft VLAN insertion

2019-07-05 Thread Olivier Matz
On Mon, Jun 24, 2019 at 02:46:02PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > Layer 2 length must be updated after the prepend to mbuf to keep > the length right to be used by other Tx offloads. > > If the packet has tunnel encapsulation, outer_l2_len should be > updated. Otherwis

Re: [dpdk-dev] [PATCH v7 06/12] cmdline: use new ethernet address parser

2019-07-05 Thread Olivier Matz
On Tue, Jul 02, 2019 at 03:12:41PM -0700, Stephen Hemminger wrote: > Now that there is a version of ether_aton in rte_ether, it can > be used by the cmdline ethernet address parser. > > Note: ether_aton_r can not be used in cmdline because > the old code would accept either bytes XX:XX:XX:XX:XX:XX

Re: [dpdk-dev] [EXT] Re: [PATCH] app/pdump: enforcing pdump to use sw mempool

2019-07-05 Thread Harman Kalra
On Fri, Jul 05, 2019 at 03:48:01PM +0200, Olivier Matz wrote: > External Email > > -- > Hi, > > On Thu, Jul 04, 2019 at 06:29:25PM +0200, Thomas Monjalon wrote: > > 15/03/2019 16:27, Harman Kalra: > > > Since pdump uses SW rings

Re: [dpdk-dev] [PATCH v7 04/12] net/ether: use bitops to speedup comparison

2019-07-05 Thread Olivier Matz
On Tue, Jul 02, 2019 at 03:12:39PM -0700, Stephen Hemminger wrote: > Using bit operations like or and xor is faster than a loop > on all architectures. Really just explicit unrolling. > > Similar cast to uint16 unaligned is already done in > other functions here. > > Signed-off-by: Stephen Hemmin

Re: [dpdk-dev] [PATCH v7 05/12] net/ether: mark ethernet addresses as being 2-byte aligned

2019-07-05 Thread Olivier Matz
On Tue, Jul 02, 2019 at 03:12:40PM -0700, Stephen Hemminger wrote: > From: Bruce Richardson > > When including the rte_ether.h header in applications with warnings > enabled, a warning was given because of the assumption of 2-byte alignment > of ethernet addresses when processing them. > > .../i

Re: [dpdk-dev] [PATCH v7 01/12] net/rte_ether: deinline non-critical functions

2019-07-05 Thread Olivier Matz
On Tue, Jul 02, 2019 at 03:12:36PM -0700, Stephen Hemminger wrote: > Formatting Ethernet address and getting a random value are > not in critical path so they should not be inlined. > > Signed-off-by: Stephen Hemminger > Acked-by: Rami Rosen > Reviewed-by: Andrew Rybchenko just a nit in the ti

Re: [dpdk-dev] [PATCH v7 02/12] net/ether: add function to convert string to ethernet address

2019-07-05 Thread Olivier Matz
Hi, On Tue, Jul 02, 2019 at 03:12:37PM -0700, Stephen Hemminger wrote: > Make a function that can be used in place of eth_aton_r > to convert a string to rte_ether_addr. This function > allows both byte (xx:xx:xx:xx:xx:xx) and word (::) > format and has the same lack of error handling

[dpdk-dev] [PATCH v2] devtools: better freebsd support

2019-07-05 Thread Olivier Matz
- As "readlink -e" and "readlink -m" do not exist on freebsd, use "readlink -f", it should not have any impact in these cases. - "sed -ri" is invalid on freebsd and should be replaced by "sed -ri=''" - Use gmake instead of make. This fixes the following command: SYSDIR=/usr/src/sys ./devtool

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-05 Thread Zhang, Roy Fan
Hi Akhil, Thanks for the review, comments inline. Regards, Fan > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, July 5, 2019 2:28 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: RE: [PATCH] crypto/mvsam: fix missed code change for mvsam > > Hi Fan,

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-05 Thread Adrien Mazarguil
On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: > A tag is a transient data which can be used during flow match. This can be > used to store match result from a previous table so that the same pattern > need not be matched again on the next table. Even if outer header is > decapsulate

Re: [dpdk-dev] [PATCH] app/pdump: enforcing pdump to use sw mempool

2019-07-05 Thread Olivier Matz
Hi, On Thu, Jul 04, 2019 at 06:29:25PM +0200, Thomas Monjalon wrote: > 15/03/2019 16:27, Harman Kalra: > > Since pdump uses SW rings to manage packets hence > > pdump should use SW ring mempool for managing its > > own copy of packets. > > I'm not sure to understand the reasoning. > Reshma, Olivi

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno

2019-07-05 Thread Iremonger, Bernard
Hi Andrew, Dilshod > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Friday, July 5, 2019 1:18 PM > To: Nicolau, Radu ; Akhil Goyal > > Cc: dev@dpdk.org; Dilshod Urazov ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/ipsec-secg

Re: [dpdk-dev] [PATCH v3 3/3] lib/lpm: memory orderings to avoid race conditions for v20

2019-07-05 Thread Alex Kiselev
Hi, > > > > > > As a general remark consider writing all of the tbl entries including > > tbl8 with atomic_store. Now "lpm->tbl8[j] = new_tbl8_entry;" is looks like > > > > 1e9: 44 88 9c 47 40 01 00mov > > %r11b,0x2000140(%rdi,%rax,2) <-write first byte > > 1f0: 02 > >

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

2019-07-05 Thread Alex Kiselev
пт, 5 июл. 2019 г. в 13:31, Medvedkin, Vladimir : > > Hi Stephen, > > On 28/06/2019 16:35, Stephen Hemminger wrote: > > On Fri, 28 Jun 2019 15:16:30 +0100 > > "Medvedkin, Vladimir" wrote: > > > >> Hi Honnappa, > >> > >> On 28/06/2019 14:57, Honnappa Nagarahalli wrote: > Hi all, > >

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-05 Thread Akhil Goyal
Hi Liron, Following patch need to be merged today as it is fixing a build issue for a patch already merged. Could you please review this patch? Sorry for a very short notice. Thanks, Akhil > -Original Message- > From: Fan Zhang > Sent: Friday, July 5, 2019 6:54 PM > To: dev@dpdk.org >

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-05 Thread Akhil Goyal
Hi Fan, > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform > key data type change for mvsam driver. > > Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant") > > Signed-off-by: Fan Zhang > --- > drivers/crypto/mvsam/rte_mrvl_pmd.c | 44 > ++

[dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-05 Thread Fan Zhang
This patch fixes the missed "uint8_t *" to "const uint8_t *" xform key data type change for mvsam driver. Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant") Signed-off-by: Fan Zhang --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 44 ++--- drivers/crypt

[dpdk-dev] [PATCH v2 0/1] Fix timer resource leak

2019-07-05 Thread Anatoly Burakov
Previous attempts [1] at fixing the resource leak have been deemed unsuccessful because of limitations around what can be done without breaking the ABI. Now that we've broken the EAL ABI, we can fix this issue properly. This patchset is adding a new lock API, as well as fixes the actual issue. Th

[dpdk-dev] [PATCH v2 1/1] timer: fix resource leak in finalize

2019-07-05 Thread Anatoly Burakov
Currently, whenever timer library is initialized, the memory is leaked because there is no telling when primary or secondary processes get to use the state, and there is no way to initialize/deinitialize timer library state without race conditions [1] because the data itself must live in shared mem

Re: [dpdk-dev] [PATCH] mem: fix typo in API description

2019-07-05 Thread Thomas Monjalon
05/07/2019 11:48, Burakov, Anatoly: > On 05-Jul-19 10:18 AM, David Marchand wrote: > > Fixes: 552afc420a67 ("mem: add contig walk function") > > Cc: sta...@dpdk.org > > > > Signed-off-by: David Marchand > > Acked-by: Anatoly Burakov Applied, thanks

[dpdk-dev] [PATCH v4 5/8] eal: remove packed attribute from mcfg structure

2019-07-05 Thread Anatoly Burakov
There is no reason to pack the memconfig structure, and doing so gives out warnings in some static analyzers. Fix it by removing the packed attributed. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- lib/librte_eal/common/eal_memcfg.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[dpdk-dev] [PATCH v4 7/8] eal: unify and move mcfg complete function

2019-07-05 Thread Anatoly Burakov
Currently, mcfg completion function exists in two independent implementations doing the same thing, which is bug prone. Unify the two functions and move them into one place. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_mcfg.c | 14 +

[dpdk-dev] [PATCH v4 8/8] eal: unify internal config initialization

2019-07-05 Thread Anatoly Burakov
Currently, each EAL will update internal/shared config in their own way at init, resulting in needless duplication of code and OS-dependent behavior. Move the functions to a common file and add missing FreeBSD steps. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- lib/librte_eal/

[dpdk-dev] [PATCH v4 6/8] eal: uninline wait for mcfg complete function

2019-07-05 Thread Anatoly Burakov
Currently, the function to wait until config completion is static inline for no reason. Move its implementation to an EAL common file. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_mcfg.c | 10 ++ lib/librte_eal/common/eal_memcfg.h

[dpdk-dev] [PATCH v4 3/8] eal: add new API to lock/unlock mempool list

2019-07-05 Thread Anatoly Burakov
Currently, in order to lock access to the mempool list, a direct access to the shared memory structure is needed. Add an API to do the same, and search-and-replace all usages. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_mcfg.c | 28 +

[dpdk-dev] [PATCH v4 2/8] eal: add EAL tailq list lock/unlock API

2019-07-05 Thread Anatoly Burakov
Currently, locking/unlocking the TAILQ list requires direct access to the shared memory config. Add an API to do the same, and search-and-replace all usages. Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- lib/librte_acl/rte_acl.c | 18 ++-- lib/librt

[dpdk-dev] [PATCH v4 4/8] eal: hide shared memory config

2019-07-05 Thread Anatoly Burakov
Now that everything that has ever accessed the shared memory config is doing so through the public API's, we can make it internal. Since we're removing quite a few headers from rte_eal_memconfig.h, we need to add them back in places where this header is used. This bumps the ABI, so also change all

[dpdk-dev] [PATCH v4 0/8] Make shared memory config non-public

2019-07-05 Thread Anatoly Burakov
This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls. A lot of the patchset is a search-and-replace job and should be pretty easy to review. The rest are pretty trivial EAL changes. v4: - Rebase on top of latest master - Squashe

[dpdk-dev] [PATCH v4 1/8] eal: add API to lock/unlock memory hotplug

2019-07-05 Thread Anatoly Burakov
Currently, the memory hotplug is locked automatically by all memory-related _walk() functions, but sometimes locking the memory subsystem outside of them is needed. There is no public API to do that, so it creates a dependency on shared memory config to be public. Fix this by introducing a new API

Re: [dpdk-dev] [PATCH] raw/ioat: fix issue with icc build

2019-07-05 Thread Thomas Monjalon
05/07/2019 14:33, Burakov, Anatoly: > On 05-Jul-19 12:54 PM, Bruce Richardson wrote: > > When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC > > tries to use the x87 floating point registers, leading to warnings about > > not properly clearing value when switching between x87 and

Re: [dpdk-dev] [PATCH] raw/ioat: fix issue with icc build

2019-07-05 Thread Burakov, Anatoly
On 05-Jul-19 12:54 PM, Bruce Richardson wrote: When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes. error #13203: No EMMS i

Re: [dpdk-dev] [PATCH] raw/ioat: fix issue with icc build

2019-07-05 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, July 5, 2019 12:54 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH] raw/ioat: fix issue with icc build > > When using _mm_set_epi64() rather than _mm_set

Re: [dpdk-dev] [PATCH v4] cryptodev: make xform key pointer constant

2019-07-05 Thread Thomas Monjalon
25/06/2019 14:46, Akhil Goyal: > > > > > This patch changes the key pointer data types in cipher, auth, > > and aead xforms from "uint8_t *" to "const uint8_t *" for a > > more intuitive and safe sessionn creation. > > > > Signed-off-by: Fan Zhang > > Acked-by: Arek Kusztal > > Acked-by: Akhil

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno

2019-07-05 Thread Andrew Rybchenko
From: Dilshod Urazov Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- examples/ipsec-secgw/sa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-se

[dpdk-dev] [PATCH] raw/ioat: fix issue with icc build

2019-07-05 Thread Bruce Richardson
When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes. error #13203: No EMMS instruction before call to function Fix this by u

[dpdk-dev] [Bug 304] [bnx2x_init] Initialization failed, stack notified driver is NOT running!

2019-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=304 Bug ID: 304 Summary: [bnx2x_init] Initialization failed, stack notified driver is NOT running! Product: DPDK Version: 19.05 Hardware: x86 OS: Linux Statu

[dpdk-dev] [PATCH v7 5/6] doc: update dpdk-test-compress-perf description

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch updates dpdk-test-compress-perf documentation. Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- doc/guides/tools/comp_perf.rst | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/comp

[dpdk-dev] [PATCH v7 6/6] app/test-compress-perf: add force process termination

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds a possibility to force controlled process termination as a result of two signals: SIGTERM and SIGINT Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/comp_perf_options.h| 1 + app/test-compress-perf/comp_perf_test_b

[dpdk-dev] [PATCH v7 2/6] app/test-compress-perf: add ptest command line option

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds --ptest option to make possible to choose test case from command line. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/comp_perf_options_parse.c | 32 1 file changed,

[dpdk-dev] [PATCH v7 4/6] app/test-compress-perf: add benchmark test case

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds a benchmark part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Also updates release notes. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile

[dpdk-dev] [PATCH v7 3/6] app/test-compress-perf: add verification test case

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds a verification part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile| 1 + app

[dpdk-dev] [PATCH v7 1/6] app/test-compress-perf: add weak functions for multi-cores test

2019-07-05 Thread Fiona Trahe
From: Tomasz Jozwiak This patch adds template functions for multi-cores performance version of compress-perf-tool Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 3 +- app/test-compress-perf/comp_per

[dpdk-dev] [PATCH v7 0/6] add multiple cores feature to test-compress-perf

2019-07-05 Thread Fiona Trahe
This patchset adds multiple cores feature to compression perf tool. All structures have been aligned and are consistent with crypto perf tool. All test cases have constructor, runner and destructor and can use more cores and compression devices at the same time. v7 changes: - rebase as patch fail

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

2019-07-05 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Medvedkin, Vladimir > Sent: Friday, July 5, 2019 18:41 > To: Ruifeng Wang (Arm Technology China) > Cc: Honnappa Nagarahalli ; Stephen > Hemminger ; bruce.richard...@intel.com; > dev@dpdk.org; Gavin Hu (Arm Technology China) ; nd > > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v11 0/4] rawdev driver for ntb

2019-07-05 Thread Thomas Monjalon
05/07/2019 04:41, Li, Xiaoyun: > From: Thomas Monjalon > > > > This patch set adds support for Intel NTB device with Skylake platform. > > It is a raw device for allowing two hosts to communicate with each other and > > access the peer memory. > > > > This patch set also provides a simple example

Re: [dpdk-dev] [PATCH v2 0/8] OCTEON TX2 DMA driver

2019-07-05 Thread Thomas Monjalon
05/07/2019 10:37, jer...@marvell.com: > Jerin Jacob (2): > raw/octeontx2_dma: add build infra and device probe > usertools: add octeontx2 DMA device binding > > Satha Rao (6): > raw/octeontx2_dma: update probe function > raw/octeontx2_dma: add device configuration > raw/octeontx2_dma: ad

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

2019-07-05 Thread Medvedkin, Vladimir
On 01/07/2019 07:44, Ruifeng Wang (Arm Technology China) wrote: Hi Medvedkin, -Original Message- From: Stephen Hemminger Sent: Friday, June 28, 2019 23:35 To: Medvedkin, Vladimir Cc: Honnappa Nagarahalli ; Ruifeng Wang (Arm Technology China) ; bruce.richard...@intel.com; dev@dpdk.or

  1   2   >