Re: [dpdk-dev] [RFC v2 4/5] spinlock: use wfe to reduce contention on aarch64

2019-07-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Gavin Hu >Sent: Wednesday, July 3, 2019 2:29 PM >To: dev@dpdk.org >Cc: n...@arm.com >Subject: [dpdk-dev] [RFC v2 4/5] spinlock: use wfe to reduce contention >on aarch64 > >In acquiring a spinlock, cores repeatedly poll the lock variable. >This

Re: [dpdk-dev] [RFC v2 2/5] ticketlock: use new API to reduce contention on aarch64

2019-07-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Gavin Hu >Sent: Wednesday, July 3, 2019 2:29 PM >To: dev@dpdk.org >Cc: n...@arm.com >Subject: [dpdk-dev] [RFC v2 2/5] ticketlock: use new API to reduce >contention on aarch64 > >While using ticket lock, cores repeatedly poll the lock variable.

Re: [dpdk-dev] [RFC v2 3/5] ring: use wfe to wait for ring tail update on aarch64

2019-07-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Gavin Hu >Sent: Wednesday, July 3, 2019 2:29 PM >To: dev@dpdk.org >Cc: n...@arm.com >Subject: [dpdk-dev] [RFC v2 3/5] ring: use wfe to wait for ring tail >update on aarch64 >Instead of polling for tail to be updated, use wfe instruction. > >S

Re: [dpdk-dev] [EXT] [RFC v2 1/5] eal: add the APIs to wait until equal

2019-07-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Gavin Hu >Sent: Wednesday, July 3, 2019 2:29 PM >To: dev@dpdk.org >Cc: n...@arm.com >Subject: [EXT] [dpdk-dev] [RFC v2 1/5] eal: add the APIs to wait until >equal > >External Email > >---

Re: [dpdk-dev] [DPDK] net/e1000: fix buffer overrun while i219 processing DMA transactions

2019-07-19 Thread Anand H. Krishnan
This seems to be changing the IGB driver. Shouldn't you be changing the em driver rather than the igb driver? Thanks, Anand On Mon, Jul 8, 2019 at 10:10 AM Xiao Zhang wrote: > > Intel® 100/200 Series Chipset platforms reduced the round-trip > latency for the LAN Controller DMA accesses, causing

[dpdk-dev] DPDK ARP issue on UBUNTU

2019-07-19 Thread Hari Narayan S
Hello, I am using DPDK drivers for my ubuntu machine, connected to a cisco switch. Once the DPDK is installed, and start my application to pump some UDP/TCP traffic, the DPDK hasnot resolved the ARP of its peer interface, which is a CISCO switch. Any pointers to resolve the issue? Kindly throw

Re: [dpdk-dev] [dpdk-stable] [v4] net/i40e: fix SFP X722 not work with FW4.16

2019-07-19 Thread Zhang, Xiao
> -Original Message- > From: Yigit, Ferruh > Sent: Saturday, July 20, 2019 2:18 AM > To: Stillwell Jr, Paul M ; Zhang, Xiao > ; dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [v4] net/i40e: fix SFP X722 not work >

Re: [dpdk-dev] [Bug 333] PCI devices not found when DPDK is linked as dynamic libraries

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 20:43:04 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=333 > > Bug ID: 333 >Summary: PCI devices not found when DPDK is linked as dynamic > libraries >Product: DPDK >Version: 19.08 >

Re: [dpdk-dev] [PATCH 0/7] bnxt patches

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 7:18 AM, Ajit Khaparde wrote: > Patchset based after an earlier submission > https://patchwork.dpdk.org/patch/56690/ > > This set mostly contains bug fixes, an update to the bnxt.rst doc > and a adds a VF PCI device ID for Thor based network controller. > > Please apply. > > Ajit Kh

Re: [dpdk-dev] [PATCH 7/7] doc: update release information for bnxt

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 7:19 AM, Ajit Khaparde wrote: > Update the HWRM version to the latest version used by the bnxt PMD > from 1.10.0.74 to 1.10.0.91 > > Signed-off-by: Ajit Khaparde Squashed into patch that does the code update in previous patchset [22/22] https://patches.dpdk.org/patch/56690/

Re: [dpdk-dev] [PATCH 2/7] net/bnxt: use correct number of RSS contexts for thor

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 7:19 AM, Ajit Khaparde wrote: > From: Santoshkumar Karanappa Rastapur > > BCM57500-based adapters use a variable number of RSS contexts > depending upon the number of receive rings in use. The current > implementation is erroneously using the maximum possible number > of RSS contexts

Re: [dpdk-dev] [PATCH 00/22] bnxt patchset

2019-07-19 Thread Ferruh Yigit
On 7/18/2019 4:35 AM, Ajit Khaparde wrote: > This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73 > contains bug fixes and an update to the HWRM API. > Please apply. > > Ajit Khaparde (1): > net/bnxt: update HWRM API to version 1.10.0.91 > > Kalesh AP (11): > net/bnxt: fix t

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-19 Thread Stephen Hemminger
On Tue, 16 Jul 2019 09:46:04 +0100 Bruce Richardson wrote: > On Mon, Jul 15, 2019 at 05:19:12PM -0700, Stephen Hemminger wrote: > > On Mon, 15 Jul 2019 16:41:36 -0700 > > Stephen Hemminger wrote: > > > > > If DPDK is built as a shared library, then any application linked > > > with rte.app.mk

[dpdk-dev] [Bug 333] PCI devices not found when DPDK is linked as dynamic libraries

2019-07-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=333 Bug ID: 333 Summary: PCI devices not found when DPDK is linked as dynamic libraries Product: DPDK Version: 19.08 Hardware: All OS: Linux Status: UNCONFIR

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-19 Thread Stephen Hemminger
On Tue, 16 Jul 2019 09:46:04 +0100 Bruce Richardson wrote: > On Mon, Jul 15, 2019 at 05:19:12PM -0700, Stephen Hemminger wrote: > > On Mon, 15 Jul 2019 16:41:36 -0700 > > Stephen Hemminger wrote: > > > > > If DPDK is built as a shared library, then any application linked > > > with rte.app.mk

Re: [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements

2019-07-19 Thread Ferruh Yigit
On 7/16/2019 2:36 PM, Thomas Monjalon wrote: > 16/07/2019 13:40, Ferruh Yigit: >> On 7/15/2019 10:53 PM, Thomas Monjalon wrote: >>> 15/07/2019 10:44, Hemant Agrawal: Nipun Gupta (1): bus/fslmc: use cinh read for eqcr ci on ls1088 platform Sachin Saxena (1): mempool/dpaa

Re: [dpdk-dev] [EXT] Re: [PATCH v3] app/testpmd: add device related cmds

2019-07-19 Thread Ferruh Yigit
On 7/18/2019 6:27 AM, Nithin Kumar Dabilpuram wrote: > Hi Ferruh, > > On 7/17/2019 10:21 PM, Ferruh Yigit wrote: >> External Email >> >> -- >> On 7/17/2019 1:30 PM, Nithin Dabilpuram wrote: >>> With the latest published interface

Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow

2019-07-19 Thread Ferruh Yigit
On 7/18/2019 10:35 PM, Thomas Monjalon wrote: > 18/07/2019 23:24, Thomas Monjalon: >> 11/07/2019 17:33, Stephen Hemminger: >>> On Thu, 11 Jul 2019 13:35:07 +0100 >>> Ferruh Yigit wrote: >>> 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for that case will be wrong and

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine

2019-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 19, 2019 15:47 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: bernard.iremon...@intel.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display > capabilities routine > > On 7/19/2019 6:07 AM,

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: cache the associated network device ifindex

2019-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 19, 2019 21:03 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > Subject: Re: [PATCH 1/2] net/mlx5: cache the associated network device > ifindex > > On Fri, 19 Jul 2019 16:41:38 + > Slava O

Re: [dpdk-dev] [dpdk-stable] [v4] net/i40e: fix SFP X722 not work with FW4.16

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 4:30 PM, Stillwell Jr, Paul M wrote: > >> -Original Message- >> From: dev On Behalf Of Xiao Zhang >> Sent: Friday, July 19, 2019 4:00 AM >> To: dev@dpdk.org >> Cc: Xing, Beilei ; Wang, Haiyue >> ; Zhang, Qi Z ; Zhang, Xiao >> ; sta...@dpdk.org >> Subject: [dpdk-dev] [v4] net/

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-19 Thread Stephen Hemminger
On Tue, 16 Jul 2019 09:46:04 +0100 Bruce Richardson wrote: > I don't think the position of these is going to be the cause here, the more > likely cause is that the pci bus driver - and all other drivers - are not > linked into apps for shared library builds. You always need to pass "-d" > paramet

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix ETH address example

2019-07-19 Thread Ferruh Yigit
On 7/17/2019 8:44 PM, Dekel Peled wrote: > Ethernet address examples contain 5 bytes only. > This patch changes the examples to valid 6 bytes Ethernet addresses. > > Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") > Cc: sta...@dpdk.org > > Signed-off-by: Dekel Peled Reviewed-by: Ferruh

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: cache the associated network device ifindex

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 16:41:38 + Slava Ovsiienko wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, July 19, 2019 19:16 > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > > > Subject: Re: [PATCH 1/2] net/mlx5: cache the associated

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-19 Thread Ferruh Yigit
On 7/17/2019 7:42 PM, Stephen Hemminger wrote: > On Wed, 10 Jul 2019 16:31:59 -0400 > Aaron Conole wrote: > >> Stephen Hemminger writes: >> >>> On Wed, 10 Jul 2019 15:13:02 -0400 >>> Aaron Conole wrote: >>> Stephen Hemminger writes: > On Wed, 10 Jul 2019 14:33:42 -0400 >

Re: [dpdk-dev] [PATCH v2] net: be more restrictive in accepted ether string formats

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 2:42 PM, Olivier Matz wrote: > On Thu, Jul 18, 2019 at 11:35:44AM -0700, Stephen Hemminger wrote: >> The current ether_unformat_addr code was based off of >> BSD ether_aton. That version changed what was allowed >> by the cmdline ether address parser. >> For example, it allows dropping

Re: [dpdk-dev] [EXT] [PATCH v5 1/1] app/test-compress-perf: report header improvement

2019-07-19 Thread Trahe, Fiona
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, July 19, 2019 5:21 PM > To: Trybula, ArturX > Cc: dev@dpdk.org; Akhil Goyal ; Shally Verma > ; Trahe, > Fiona ; Dybkowski, AdamX > Subject: Re: [dpdk-dev] [EXT] [PATCH v5 1/1] app/test-c

Re: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 2:07 PM, Ed Czeck wrote: > Queue index was incorrectly incremented with port, which > caused swizzling of packet placement among queues. What is "swizzling of packet placement"? 'qidx' is used to set 'phys_qid', if what the name suggest is correct it is used to access the actual ph

[dpdk-dev] [PATCH v3] mk: fix output directory name when compiling with custom kernel header dir

2019-07-19 Thread Herakliusz Lipiec
When building dpdk with differnt kernel headers by specifying RTE_KERNELDIR igb_uio is compiled to directory with a name of the version of kernel thats running on the system instead of the one that dpdk is actually compiled against. Fixed by replacing hardcoded value with value from RTE_KERNELDIR.

Re: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir

2019-07-19 Thread Lipiec, Herakliusz
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, July 19, 2019 12:37 PM > To: Lipiec, Herakliusz > Cc: dev@dpdk.org; sta...@dpdk.org; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when > compiling with custo

Re: [dpdk-dev] [PATCH 00/22] bnxt patchset

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 2:22 PM, Ajit Kumar Khaparde wrote: >> On Jul 19, 2019, at 18:00, Ferruh Yigit wrote: >> >>> On 7/18/2019 4:35 AM, Ajit Khaparde wrote: >>> This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73 >>> contains bug fixes and an update to the HWRM API. >>> Please apply. >>

Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 03:37:26 + Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, July 17, 2019 12:18 AM > > To: Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org > > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed

Re: [dpdk-dev] [PATCH 0/7] bnxt patches

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 5:18 PM, Stephen Hemminger wrote: > On Fri, 19 Jul 2019 13:33:32 +0100 > Ferruh Yigit wrote: > >> On 7/19/2019 7:18 AM, Ajit Khaparde wrote: >>> Patchset based after an earlier submission >>> https://patchwork.dpdk.org/patch/56690/ >>> >>> This set mostly contains bug fixes, an updat

[dpdk-dev] [PATCH v2] doc: add deprecation notice about changes to ethernet structures

2019-07-19 Thread Stephen Hemminger
Tell users about upcoming changes to rte_ether_addr and rte_ether_header. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- v2 - reword and fix spelling doc/guides/rel_notes/deprecation.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/depre

Re: [dpdk-dev] [EXT] [PATCH v5 0/7] Rework API for RSA algorithm in asymmetric crypto

2019-07-19 Thread Kusztal, ArkadiuszX
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, July 19, 2019 6:23 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; Akhil Goyal ; Shally Verma > ; Trahe, Fiona ; Nowak, > DamianX ; Ayuj Verma > ; Kanaka Durga Kotamarthy > ; Sunila Sahu

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-19 Thread Ferruh Yigit
On 7/17/2019 8:45 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Support QinQ strip RX offload configuration through > testpmd command line and boot time arguments. For the testpmd command part, unfortunately there are two set of commands for same purpose, the new ones are (lets bot

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: cache the associated network device ifindex

2019-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 19, 2019 19:16 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > Subject: Re: [PATCH 1/2] net/mlx5: cache the associated network device > ifindex > > On Fri, 19 Jul 2019 05:31:44 + > Viaches

Re: [dpdk-dev] [PATCH 2/2] Revert "net/mlx5: fix master device Netlink socket sharing"

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 16:21:17 + Slava Ovsiienko wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, July 19, 2019 19:17 > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > > > Subject: Re: [PATCH 2/2] Revert "net/mlx5: fix master de

Re: [dpdk-dev] [EXT] [PATCH v5 0/7] Rework API for RSA algorithm in asymmetric crypto

2019-07-19 Thread Thomas Monjalon
19/07/2019 14:51, Akhil Goyal: > > > Arek Kusztal (7): > > > cryptodev: change RSA API comments about primes > > > cryptodev: add cipher field to RSA op > > > crypto/openssl: add cipher field to openssl RSA implementation > > > test: add cipher field to RSA test > > > cryptodev: remove RS

Re: [dpdk-dev] [EXT] [PATCH v5 1/1] app/test-compress-perf: report header improvement

2019-07-19 Thread Thomas Monjalon
19/07/2019 15:17, Akhil Goyal: > > > > > +static struct cperf_buffer_info tests_res; > > Rename test_res too --> buffer_info? You can address it in next release > > cycle as > > well. > > [Artur] Thank you Shally. Good point. Will be changed in the next cycle. > > > > > Applied to dpdk-next

Re: [dpdk-dev] [PATCH 2/2] Revert "net/mlx5: fix master device Netlink socket sharing"

2019-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 19, 2019 19:17 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > Subject: Re: [PATCH 2/2] Revert "net/mlx5: fix master device Netlink socket > sharing" > > On Fri, 19 Jul 2019 05:31:45 + > V

Re: [dpdk-dev] [PATCH 0/7] bnxt patches

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 13:33:32 +0100 Ferruh Yigit wrote: > On 7/19/2019 7:18 AM, Ajit Khaparde wrote: > > Patchset based after an earlier submission > > https://patchwork.dpdk.org/patch/56690/ > > > > This set mostly contains bug fixes, an update to the bnxt.rst doc > > and a adds a VF PCI device

Re: [dpdk-dev] [PATCH 2/2] Revert "net/mlx5: fix master device Netlink socket sharing"

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 05:31:45 + Viacheslav Ovsiienko wrote: > This reverts commit e28111ac9864af09e826241a915dfff87a9c00ad. > The netlink requests are replaced by ifindex caching and > not needed anymore. > > Signed-off-by: Viacheslav Ovsiienko > Fixes: e28111ac9864 ("net/mlx5: fix master de

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: cache the associated network device ifindex

2019-07-19 Thread Stephen Hemminger
On Fri, 19 Jul 2019 05:31:44 + Viacheslav Ovsiienko wrote: > + /* > + * Store associated network device interface index. This index > + * is permanent throughout the lifetime of device. We do not spawn > + * rte_eth_dev ports without associated network device, and if > +

Re: [dpdk-dev] [RFC 1/4] mempool: clarify default populate function

2019-07-19 Thread Andrew Rybchenko
On 7/19/19 4:38 PM, Olivier Matz wrote: No functional change. Clarify the populate function to make the next commit easier to understand. Rename the variables: - to avoid negation in the name - to have more understandable names Remove useless variable (no_pageshift is equivalent to pg_sz == 0).

Re: [dpdk-dev] [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-07-19 Thread Iremonger, Bernard
Hi Akhil, > > > Subject: [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped > > > > > > This patchset fixes the issue of the first inbound packet being > > > dropped for inline crypto. > > > > > > Changes in v7: > > > -- > > > Rebased to DPDK 19.08-rc1 > > > > > > Changes in

Re: [dpdk-dev] [RFC] mark asym session-buffer non-reuseable

2019-07-19 Thread Trahe, Fiona
No need as API is still experimental. Howver I'd suggest changing the subject to "declare crypto asym xform immutable" non-reusable is confusing as the session and xform will be re-used on all the ops associated with the session. From: Ayuj Verma [mailto:ayve...@marvell.com] Sent: Friday, July 1

Re: [dpdk-dev] [v4] net/i40e: fix SFP X722 not work with FW4.16

2019-07-19 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev On Behalf Of Xiao Zhang > Sent: Friday, July 19, 2019 4:00 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue > ; Zhang, Qi Z ; Zhang, Xiao > ; sta...@dpdk.org > Subject: [dpdk-dev] [v4] net/i40e: fix SFP X722 not work with FW4.16 > > The code check

Re: [dpdk-dev] [PATCH v5 02/11] sched: add config flexibility to tc queue sizes

2019-07-19 Thread Singh, Jasvinder
> > diff --git a/lib/librte_sched/rte_sched.c > > b/lib/librte_sched/rte_sched.c index f7c218ef0..3d3d4c69f 100644 > > --- a/lib/librte_sched/rte_sched.c > > +++ b/lib/librte_sched/rte_sched.c > > @@ -146,15 +146,15 @@ struct rte_sched_grinder { > > struct rte_sched_pipe_profile *pipe_param

Re: [dpdk-dev] [PATCH v5 06/11] sched: improve doxygen comments

2019-07-19 Thread Singh, Jasvinder
> > @@ -165,61 +170,90 @@ struct rte_sched_subport_stats { > > * byte. > > */ > > struct rte_sched_pipe_params { > > - /* Pipe token bucket */ > > - uint32_t tb_rate;/**< Rate (measured in bytes per > > second) > > */ > > - uint32_t tb_size;/**< Size

Re: [dpdk-dev] [RFC] doc: deprecate legacy code path in ipsec-secgw

2019-07-19 Thread Zhang, Roy Fan
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, July 11, 2019 6:06 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [dpdk-dev] [RFC] doc: deprecate legacy code path in ip

Re: [dpdk-dev] [RFC] mark asym session-buffer non-reuseable

2019-07-19 Thread Ayuj Verma
Hi Akhil, Arek, Fiona, Since this require changes in other Asym PMD( qat) apart from openssl (we plan to send changes for this), so should we need to send any announcement on ABI breakage here before proposing patch v1? Thanks and regards Ayuj Verma From: A

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-19 Thread Eads, Gage
> > > > > +/** > > > > > + * 128-bit integer structure. > > > > > + */ > > > > > +RTE_STD_C11 > > > > > +typedef struct { > > > > > + RTE_STD_C11 > > > > > + union { > > > > > + uint64_t val[2]; > > > > > + __extension__ __int128 int128; > > > > Instead of guarding

[dpdk-dev] [PATCH v6 10/11] examples/qos_sched: add tc and queue config flexibility

2019-07-19 Thread Jasvinder Singh
Update qos sched sample app for configuration flexibility of pipe traffic classes and queues. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/qos_sched/app_thread.c | 11 +- examples/qos_sched/cfg_file.c | 130 +--- examples/q

[dpdk-dev] [PATCH v6 11/11] sched: remove redundant macros

2019-07-19 Thread Jasvinder Singh
Remove unused macros from the library, and update release notes. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- doc/guides/rel_notes/release_19_08.rst | 10 +- lib/librte_sched/rte_sched.h | 11 --- 2 files changed, 9 i

[dpdk-dev] [PATCH v6 09/11] examples/ip_pipeline: add config flexibility to tm function

2019-07-19 Thread Jasvinder Singh
Update ip pipeline sample app for configuration flexiblity of pipe traffic classes and queues. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/ip_pipeline/cli.c | 43 +++--- examples/ip_pipeline/tmgr.h

[dpdk-dev] [PATCH v6 08/11] test_sched: modify tests for config flexibility

2019-07-19 Thread Jasvinder Singh
update unit tests for configuration flexibility of pipe traffic classes and queues size. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/t

[dpdk-dev] [PATCH v6 05/11] sched: improve error log messages

2019-07-19 Thread Jasvinder Singh
Replace hard-coded numbers for reporting errors with error messages. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 293 ++- 1 file changed, 221 insertions(+), 72 deletions(-) diff

[dpdk-dev] [PATCH v6 03/11] sched: add max pipe profiles config in run time

2019-07-19 Thread Jasvinder Singh
Allow setting the maximum number of pipe profiles in run time. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 8 +--- lib/librte_sched/rte_sched.h | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH v6 04/11] sched: rename tc3 params to best-effort tc

2019-07-19 Thread Jasvinder Singh
Change the traffic class 3 related params name to best-effort(be) traffic class. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 56 ++-- 1 file changed, 28 insertions(+), 28 deletion

[dpdk-dev] [PATCH v6 07/11] net/softnic: add config flexibility to softnic tm

2019-07-19 Thread Jasvinder Singh
Update softnic tm function for configuration flexiblity of pipe traffic classes and queues size. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- drivers/net/softnic/rte_eth_softnic.c | 98 drivers/net/softnic/rte_eth_softnic_cli.c

[dpdk-dev] [PATCH v6 06/11] sched: improve doxygen comments

2019-07-19 Thread Jasvinder Singh
Improve doxygen comments. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.h | 152 ++- 1 file changed, 94 insertions(+), 58 deletions(-) diff --git a/lib/librte_sched/rte_sched.h b/lib/l

[dpdk-dev] [PATCH v6 02/11] sched: add config flexibility to tc queue sizes

2019-07-19 Thread Jasvinder Singh
Add support for zero queue sizes of the traffic classes. The queues which are not used can be set to zero size. This helps in reducing memory footprint of the hierarchical scheduler. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sche

[dpdk-dev] [PATCH v6 01/11] sched: remove wrr from strict priority tc queues

2019-07-19 Thread Jasvinder Singh
All higher priority traffic classes contain only one queue, thus remove wrr function for them. The lowest priority best-effort traffic class conitnue to have multiple queues and packet are scheduled from its queues using wrr function. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar S

[dpdk-dev] [PATCH v6 00/11] sched: feature enhancements

2019-07-19 Thread Jasvinder Singh
This patchset refactors the dpdk qos sched library to allow flexibile configuration of the pipe traffic classes and queue sizes. Currently, each pipe has 16 queues hardwired into 4 TCs scheduled with strict priority, and each TC has exactly with 4 queues that are scheduled with Weighted Fair Queui

Re: [dpdk-dev] [RFC 4/4] mempool: prevent objects from being across pages

2019-07-19 Thread Burakov, Anatoly
On 19-Jul-19 2:38 PM, Olivier Matz wrote: When using iova contiguous memory and objets smaller than page size, ensure that objects are not located across several pages. Signed-off-by: Vamsi Krishna Attunuru Signed-off-by: Olivier Matz --- total_elt_sz = mp->header_size + mp->elt_s

Re: [dpdk-dev] [RFC 4/4] mempool: prevent objects from being across pages

2019-07-19 Thread Burakov, Anatoly
On 19-Jul-19 2:38 PM, Olivier Matz wrote: When using iova contiguous memory and objets smaller than page size, ensure that objects are not located across several pages. Signed-off-by: Vamsi Krishna Attunuru Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool_ops_default.c | 39 +++

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-19 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Friday, July 19, 2019 8:35 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Honnappa > Nagarahalli ; Gavin Hu (Arm Technology > China) ; nd ; gage.e...@intel.com; nd >

Re: [dpdk-dev] [PATCH v2] net: be more restrictive in accepted ether string formats

2019-07-19 Thread Olivier Matz
On Thu, Jul 18, 2019 at 11:35:44AM -0700, Stephen Hemminger wrote: > The current ether_unformat_addr code was based off of > BSD ether_aton. That version changed what was allowed > by the cmdline ether address parser. > For example, it allows dropping leading zeros. > > Change the code to be more

[dpdk-dev] [RFC 2/4] mempool: unalign size when calculating required mem amount

2019-07-19 Thread Olivier Matz
The size returned by rte_mempool_op_calc_mem_size_default() is aligned to the specified page size. This means that with big pages, the returned amount is more that what we really need to populate the mempool. This problem is tempered by the allocation method of rte_mempool_populate_default(): in s

[dpdk-dev] [RFC 1/4] mempool: clarify default populate function

2019-07-19 Thread Olivier Matz
No functional change. Clarify the populate function to make the next commit easier to understand. Rename the variables: - to avoid negation in the name - to have more understandable names Remove useless variable (no_pageshift is equivalent to pg_sz == 0). Remove duplicate affectation of "externa

[dpdk-dev] [RFC 4/4] mempool: prevent objects from being across pages

2019-07-19 Thread Olivier Matz
When using iova contiguous memory and objets smaller than page size, ensure that objects are not located across several pages. Signed-off-by: Vamsi Krishna Attunuru Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool_ops_default.c | 39 ++-- 1 file changed, 37

[dpdk-dev] [RFC 0/4] mempool: avoid objects allocations across pages

2019-07-19 Thread Olivier Matz
When IOVA mode is VA, a mempool can be created with objects that are not physically contiguous, which breaks KNI. To solve this, this patchset changes the default behavior of mempool populate function, to prevent objects from being located across pages. Olivier Matz (4): mempool: clarify defaul

[dpdk-dev] [RFC 3/4] mempool: introduce function to get mempool page size

2019-07-19 Thread Olivier Matz
In rte_mempool_populate_default(), we determine the page size, which is needed for calc_size and allocation of memory. Move this in a function and export it, it will be used in next commit. Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 50 +--

Re: [dpdk-dev] [PATCH 00/22] bnxt patchset

2019-07-19 Thread Ajit Kumar Khaparde
> On Jul 19, 2019, at 18:00, Ferruh Yigit wrote: > >> On 7/18/2019 4:35 AM, Ajit Khaparde wrote: >> This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73 >> contains bug fixes and an update to the HWRM API. >> Please apply. >> >> Ajit Khaparde (1): >> net/bnxt: update HWRM API to

Re: [dpdk-dev] [EXT] [PATCH v5 1/1] app/test-compress-perf: report header improvement

2019-07-19 Thread Akhil Goyal
> > > +static struct cperf_buffer_info tests_res; > Rename test_res too --> buffer_info? You can address it in next release cycle > as > well. > [Artur] Thank you Shally. Good point. Will be changed in the next cycle. > > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 1/2] test/crypto: fix session init failure for wireless test

2019-07-19 Thread Akhil Goyal
> > This patch add the support to handle the failure in session > create for wireless related cases. Else it will cause > segment fault due to I/O on un-initialized sessions. > > Fixes: b3bbd9e5f2659 ("cryptodev: support device independent sessions") > Cc: sta...@dpdk.org > > Signed-off-by: H

[dpdk-dev] [PATCH 2/2] net/ark: remove resources when port is close

2019-07-19 Thread Ed Czeck
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the resources for the port can be freed by rte_eth_dev_close() Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index 86e500

[dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-19 Thread Ed Czeck
Queue index was incorrectly incremented with port, which caused swizzling of packet placement among queues. This manifested when the number of configured ports was >1 and < nb_queues. Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers

Re: [dpdk-dev] [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-07-19 Thread Iremonger, Bernard
Hi Akhil, > > Subject: [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped > > > > This patchset fixes the issue of the first inbound packet being > > dropped for inline crypto. > > > > Changes in v7: > > -- > > Rebased to DPDK 19.08-rc1 > > > > Changes in v6: > > --

Re: [dpdk-dev] [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-07-19 Thread Akhil Goyal
> -Original Message- > From: Bernard Iremonger > Sent: Wednesday, July 10, 2019 4:53 PM > To: dev@dpdk.org; konstantin.anan...@intel.com; Akhil Goyal > > Cc: Bernard Iremonger > Subject: [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped > > This patchset fixes the issue of the

Re: [dpdk-dev] [EXT] [PATCH v5 0/7] Rework API for RSA algorithm in asymmetric crypto

2019-07-19 Thread Akhil Goyal
> > -- > > Ramoved patches that was not acked by Shally. > > So open things: > > 1. Creating padding struct. > > 2. Padding parameters (seedlen, optional label etc). > > 3. Leading zeroes questions. > > 4. Random number requirement

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 6:07 AM, Slava Ovsiienko wrote: > Hi, Ferruh > > Please, see below > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, July 17, 2019 17:56 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: bernard.iremon...@intel.com; sta...@dpdk.org >> Subject: Re: [dpdk-stable] [P

Re: [dpdk-dev] [PATCH] failsafe: skip devargs if not present in secondary

2019-07-19 Thread Ferruh Yigit
On 7/18/2019 12:18 PM, Gaëtan Rivet wrote: > On Wed, Jul 17, 2019 at 07:21:51PM +0100, Ferruh Yigit wrote: >> On 6/24/2019 5:27 PM, Gaëtan Rivet wrote: >>> On Mon, Jun 24, 2019 at 08:23:38AM -0700, Stephen Hemminger wrote: On Mon, 24 Jun 2019 10:15:58 +0200 Gaëtan Rivet wrote: >

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-19 Thread Jerin Jacob Kollanukkaran
> > > +#define RTE_HAS_ACQ(mo) ((mo) != __ATOMIC_RELAXED && (mo) != > > > +__ATOMIC_RELEASE) #define RTE_HAS_RLS(mo) ((mo) == > > > __ATOMIC_RELEASE || \ > > > + (mo) == __ATOMIC_ACQ_REL || \ > > > + (mo) == __ATOMIC_SEQ_CST) > > > + > > > +#define RTE_MO_LOAD(mo)

[dpdk-dev] [PATCH v2 08/10] crypto/nitrox: add burst enqueue and dequeue operations

2019-07-19 Thread Nagadheeraj Rottela
Add burst enqueue and dequeue operations along with interface for symmetric request manager. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_qp.h | 55 ++ drivers/crypto/nitrox/nitrox_sym.c| 123 - drivers/crypto/nitrox/nitrox_sym_

[dpdk-dev] [PATCH v2 10/10] test/crypto: add tests for Nitrox PMD

2019-07-19 Thread Nagadheeraj Rottela
Add hmac(sha1), cbc(aes) authenc tests in the test mechanism. Signed-off-by: Nagadheeraj Rottela --- app/test/test_cryptodev.c | 52 ++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_aes_test_vectors.h | 30 +++-

[dpdk-dev] [PATCH v2 09/10] crypto/nitrox: add cipher auth crypto chain processing

2019-07-19 Thread Nagadheeraj Rottela
Add cipher auth crypto chain processing functionality in symmetric request manager. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 427 +- 1 file changed, 425 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nitrox/nitrox_

[dpdk-dev] [PATCH v2 07/10] crypto/nitrox: add session management operations

2019-07-19 Thread Nagadheeraj Rottela
Add all the session management operations. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_sym.c | 323 - drivers/crypto/nitrox/nitrox_sym_ctx.h | 85 + 2 files changed, 405 insertions(+), 3 deletions(-) create mode 100644 drivers

[dpdk-dev] [PATCH v2 05/10] crypto/nitrox: add software queue management functionality

2019-07-19 Thread Nagadheeraj Rottela
Add software queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/Makefile| 2 + drivers/crypto/nitrox/meson.build | 2 + drivers/crypto/nitrox/nitrox_qp.c | 74 +++

[dpdk-dev] [PATCH v2 06/10] crypto/nitrox: add hardware queue management functionality

2019-07-19 Thread Nagadheeraj Rottela
Add hardware queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_csr.h | 13 drivers/crypto/nitrox/nitrox_hal.c | 151 + drivers/crypto/nitrox/nitrox_hal.h | 1

[dpdk-dev] [PATCH v2 02/10] crypto/nitrox: add PCI probe and remove routines

2019-07-19 Thread Nagadheeraj Rottela
Add pci probe, remove and hardware init routines. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/Makefile| 1 + drivers/crypto/nitrox/meson.build | 1 + drivers/crypto/nitrox/nitrox_csr.h| 28 + drivers/crypto/nitrox/nitrox_device.c | 105 ++

[dpdk-dev] [PATCH v2 00/10] add Nitrox crypto device support

2019-07-19 Thread Nagadheeraj Rottela
Add the Nitrox PMD to support Nitrox crypto device. --- v2: * Fix compilation error on AARCH64. * Fix checkpatch warning "UNNECESSARY_ELSE: else is not generally useful after a break or return". Nagadheeraj Rottela (10): crypto/nitrox: add Nitrox build and doc skeleton crypto/nitrox: add PCI

[dpdk-dev] [PATCH v2 01/10] crypto/nitrox: add Nitrox build and doc skeleton

2019-07-19 Thread Nagadheeraj Rottela
Add bare minimum Nitrox PMD library and doc build infrastructure and claim responsibility by updating the maintainers file. Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 7 ++ config/common_base | 5 + doc/guides

[dpdk-dev] [PATCH v2 04/10] crypto/nitrox: add basic symmetric cryptodev operations

2019-07-19 Thread Nagadheeraj Rottela
Add the following cryptodev operations, - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get Signed-off-by: Nagadheeraj Rottela --- doc/guides/cryptodevs/features/nitrox.ini | 38 doc/guides/cryptodevs/nitrox.rst| 37 +++ drivers/crypto/ni

Re: [dpdk-dev] [PATCH 0/7] bnxt patches

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 7:18 AM, Ajit Khaparde wrote: > Patchset based after an earlier submission > https://patchwork.dpdk.org/patch/56690/ > > This set mostly contains bug fixes, an update to the bnxt.rst doc > and a adds a VF PCI device ID for Thor based network controller. > > Please apply. > > Ajit Kh

[dpdk-dev] [PATCH v2 03/10] crypto/nitrox: create Nitrox symmetric cryptodev

2019-07-19 Thread Nagadheeraj Rottela
Add Nitrox symmetric cryptodev with no operations. Cryptodev operations will be added in the next set of patches. Also, registered nitrox log type. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/Makefile| 2 + drivers/crypto/nitrox/meson.build | 2 + drivers/crypto/ni

Re: [dpdk-dev] [PATCH 00/22] bnxt patchset

2019-07-19 Thread Ferruh Yigit
On 7/18/2019 4:35 AM, Ajit Khaparde wrote: > This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73 > contains bug fixes and an update to the HWRM API. > Please apply. > > Ajit Khaparde (1): > net/bnxt: update HWRM API to version 1.10.0.91 > > Kalesh AP (11): > net/bnxt: fix t

Re: [dpdk-dev] [PATCH v5 00/11] sched: feature enhancements

2019-07-19 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, July 19, 2019 12:41 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v5 00/11] sched: feature enhancements > > 19/07/2019 13:16, Singh, Jasvinde

Re: [dpdk-dev] [PATCH v5 00/11] sched: feature enhancements

2019-07-19 Thread Thomas Monjalon
19/07/2019 13:16, Singh, Jasvinder: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 19/07/2019 00:57, Dumitrescu, Cristian: > > > > Jasvinder Singh (11): > > > > sched: remove wrr from strict priority tc queues > > > > sched: add config flexibility to tc queue sizes > > > > sched: ad

  1   2   >