Re: [dpdk-dev] [PATCH] Do RCU synchronization at fixed interval in PMD main loop.

2019-08-06 Thread David Marchand
Hello Nitin, On Wed, Aug 7, 2019 at 8:13 AM Nitin Katiyar wrote: > > Each PMD updates the global sequence number for RCU synchronization > purpose with other OVS threads. This is done at every 1025th iteration > in PMD main loop. > > If the PMD thread is responsible for polling large number of qu

[dpdk-dev] [PATCH] Do RCU synchronization at fixed interval in PMD main loop.

2019-08-06 Thread Nitin Katiyar
Each PMD updates the global sequence number for RCU synchronization purpose with other OVS threads. This is done at every 1025th iteration in PMD main loop. If the PMD thread is responsible for polling large number of queues that are carrying traffic, it spends a lot of time processing packets and

Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity

2019-08-06 Thread Stephen Hemminger
On Wed, 7 Aug 2019 05:38:42 + Matan Azrad wrote: > From: Stephen Hemminger > > Sent: Wednesday, August 7, 2019 2:09 AM > > To: Matan Azrad > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: Re: [dpdk-dev] [PATCH v5 1/4] > > examples/multi_process/client_server_mp: check port validity > >

Re: [dpdk-dev] [PATCH v7 0/2] examples/client_server_mp: port id (fixes only)

2019-08-06 Thread Matan Azrad
Acked-by: Matan Azrad From: Stephen Hemminger > Sent: Monday, August 5, 2019 7:38 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v7 0/2] examples/client_server_mp: port id > (fixes only) > > v7 - widen port mask to allow 64 ports > > v6 - just include fixes; clea

Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity

2019-08-06 Thread Matan Azrad
From: Stephen Hemminger > Sent: Wednesday, August 7, 2019 2:09 AM > To: Matan Azrad > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v5 1/4] > examples/multi_process/client_server_mp: check port validity > > On Tue, 6 Aug 2019 20:03:22 + > Matan Azrad wrote: > > >

[dpdk-dev] [PATCH] net/memif: fix build error with gcc 9.1

2019-08-06 Thread jerinj
From: Jerin Jacob gcc-9 stricter on NULL arguments for printf. Fix the following build error by avoiding NULL argument to printf. In file included from drivers/net/memif/memif_socket.c:26: In function 'memif_socket_create', inlined from 'memif_socket_init' at net/memif/memif_socket.c:965:12: net

Re: [dpdk-dev] [v2] net/fm10k: fix segment fault at calling fm10k_stats_get()

2019-08-06 Thread Wang, Xiao W
Hi > -Original Message- > From: luqiu...@iie.ac.cn [mailto:luqiu...@iie.ac.cn] > Sent: Tuesday, August 6, 2019 2:34 PM > To: sta...@dpdk.org; dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Xiao W > ; ys...@mellanox.com > Subject: [v2] net/fm10k: fix segment fault at calling fm10k_stats_get() > >

Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload

2019-08-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, August 7, 2019 4:45 AM > To: Andrew Rybchenko > Cc: Pavan Nikhilesh Bhagavatula ; Hemant > Agrawal ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload > >

Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload

2019-08-06 Thread Stephen Hemminger
On Tue, 6 Aug 2019 12:06:35 +0300 Andrew Rybchenko wrote: > On 8/6/19 11:47 AM, Pavan Nikhilesh Bhagavatula wrote: > > > >> -Original Message- > >> From: Hemant Agrawal > >> Sent: Tuesday, August 6, 2019 1:49 PM > >> To: Pavan Nikhilesh Bhagavatula ; Jerin > >> Jacob Kollanukkaran > >

Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity

2019-08-06 Thread Stephen Hemminger
On Tue, 6 Aug 2019 20:03:22 + Matan Azrad wrote: > > > > The DPDK has lots of hard coded assumptions of all ports fitting in 64 bits. > > Examples include testpmd/parameters.c etc. > > Yes, I understand, but the user should know not to change the default value > of > RTE_MAX_ETHPORTS, a

[dpdk-dev] KNI Module (multiple) to handle IGMP requests

2019-08-06 Thread Vikash Kumar
Hello Everyone, Currently I am working on a project in which I need to capture the ipv4 multicast data from a managed (igmp enabled) switch. In order achieve this, I am currently using below configuration: dpdk-18.05.1. *Hardware Description:* Operating System: CentOS Linux 7 (Core) CPE OS

[dpdk-dev] [dpdk-announce] release candidate 19.08-rc4

2019-08-06 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.08-rc4 82 patches were integrated. This is the last release candidate for DPDK 19.08. The release notes are complete: http://doc.dpdk.org/guides/rel_notes/release_19_08.html Only the deprecatio

Re: [dpdk-dev] [PATCH v1] doc: add note about patching third party dependencies

2019-08-06 Thread Thomas Monjalon
30/07/2019 13:07, John McNamara: > Added a note to the getting started guides about patching third > party libraries/dependencies to avoid any known vulnerabilities. > > Signed-off-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

2019-08-06 Thread Thomas Monjalon
> > > > As legacy filter API "filter_ctrl" is superseded since 2017 by the > > > > rte_flow API, and got the deprecated attribute in DPDK 19.05, it is > > > > time to remove the associated features from the matrix. > > > > Not documenting deprecated features as supported will avoid confusion. > > >

Re: [dpdk-dev] [PATCH v2 0/2] coverity fixes for bbdev

2019-08-06 Thread Thomas Monjalon
06/08/2019 16:08, Nicolas Chautru: > Fixing a few coverity minor issues reported by Coverity for DPDK 19.08 RC : > 344980, 344992, 345010. > v2: Commit message update > > Nicolas Chautru (2): > baseband/turbo_sw: remove logically dead code > app/bbdev: fix unchecked return valued Applied, t

[dpdk-dev] [PATCH v2 2/2] app/bbdev: fix unchecked return valued

2019-08-06 Thread Nicolas Chautru
Returned value from rte_bbdev_enc_op_alloc_bulk not checked consistently. Coverity issue: 344986. Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/

[dpdk-dev] [PATCH v2 1/2] baseband/turbo_sw: remove logically dead code

2019-08-06 Thread Nicolas Chautru
Error handling code cannot logically be reached. Coverity issue : 344980, 344992 Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G") Signed-off-by: Nicolas Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH v2 0/2] coverity fixes for bbdev

2019-08-06 Thread Nicolas Chautru
Fixing a few coverity minor issues reported by Coverity for DPDK 19.08 RC : 344980, 344992, 345010. v2: Commit message update Nicolas Chautru (2): baseband/turbo_sw: remove logically dead code app/bbdev: fix unchecked return valued app/test-bbdev/test_bbdev_perf.c | 6

Re: [dpdk-dev] [PATCH 0/2] coverity fixes for bbdev

2019-08-06 Thread Thomas Monjalon
06/08/2019 15:27, Nicolas Chautru: > Fixing a few coverity minor issues reported by Coverity > for DPDK 19.08 RC : 344980, 344992, 345010. > > Nicolas Chautru (2): > baseband/turbo_sw: remove logically dead code > app/bbdev: fix unchecked return valued The patches are missing a "Fixes" line

[dpdk-dev] [PATCH 0/2] coverity fixes for bbdev

2019-08-06 Thread Nicolas Chautru
Fixing a few coverity minor issues reported by Coverity for DPDK 19.08 RC : 344980, 344992, 345010. Nicolas Chautru (2): baseband/turbo_sw: remove logically dead code app/bbdev: fix unchecked return valued app/test-bbdev/test_bbdev_perf.c | 6 -- drivers/baseband/turbo

[dpdk-dev] [PATCH 1/2] baseband/turbo_sw: remove logically dead code

2019-08-06 Thread Nicolas Chautru
Coverity issue : 344980, 344992 Signed-off-by: Nicolas Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c index acb63a4.

[dpdk-dev] [PATCH 2/2] app/bbdev: fix unchecked return valued

2019-08-06 Thread Nicolas Chautru
Coverity issue: 344986 Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index a166eaf..7ab61ef 100644 --- a/app/test-bbdev/test_bbdev_p

Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity

2019-08-06 Thread Matan Azrad
Hi From: Stephen Hemminger > Sent: Tuesday, August 6, 2019 6:40 PM > To: Matan Azrad > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v5 1/4] > examples/multi_process/client_server_mp: check port validity > > On Tue, 6 Aug 2019 08:19:01 + > Matan Azrad wrote: > > > F

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

2019-08-06 Thread Matan Azrad
Hi From: Ananyev, Konstantin > > -Original Message- > > From: Matan Azrad [mailto:ma...@mellanox.com] > > Sent: Tuesday, August 6, 2019 3:56 PM > > To: dev@dpdk.org > > Cc: Thomas Monjalon ; Yigit, Ferruh > > ; Andrew Rybchenko > > ; Ananyev, Konstantin > > ; Olivier Matz > > Subject: [PA

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 5:56 PM, Matan Azrad wrote: The API breakage is because the ``tso_segsz`` field was documented for LRO. The ``tso_segsz`` field in mbuf indicates the size of each segment in the LRO packet in Rx path and should be provided by the LRO packet port. While the generic LRO packet may aggre

Re: [dpdk-dev] [EXT] Re: [RFC 1/3] ethdev: add ptype as an Rx offload

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 6:45 PM, Stephen Hemminger wrote: On Tue, 6 Aug 2019 14:31:43 + Pavan Nikhilesh Bhagavatula wrote: -Original Message- From: Andrew Rybchenko Sent: Tuesday, August 6, 2019 2:30 PM To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob Kollanukkaran ; John McNamara ; Marko Kovacevi

[dpdk-dev] Compilation error on master with gcc 9.1

2019-08-06 Thread Jerin Jacob Kollanukkaran
CC memif_socket.o In file included from /home/jerin/dpdk.org/drivers/net/memif/memif_socket.c:26: In function 'memif_socket_create', inlined from 'memif_socket_init' at /home/jerin/dpdk.org/drivers/net/memif/memif_socket.c:965:12: /home/jerin/dpdk.org/drivers/net/memif/rte_eth_memif.h:35:2: er

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory event callback list

2019-08-06 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, August 6, 2019 6:01 PM > To: dev@dpdk.org > Cc: Yongseok Koh ; Shahaf Shuler > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix memory event callback list > > The shared Infiniband device

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

2019-08-06 Thread Ananyev, Konstantin
> -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Tuesday, August 6, 2019 3:56 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko ; > Ananyev, Konstantin ; Olivier Matz > > Subject: [PATCH 2/2] doc: announce new mbuf field for L

Re: [dpdk-dev] [EXT] Re: [RFC 1/3] ethdev: add ptype as an Rx offload

2019-08-06 Thread Stephen Hemminger
On Tue, 6 Aug 2019 14:31:43 + Pavan Nikhilesh Bhagavatula wrote: > >-Original Message- > >From: Andrew Rybchenko > >Sent: Tuesday, August 6, 2019 2:30 PM > >To: Pavan Nikhilesh Bhagavatula ; Jerin > >Jacob Kollanukkaran ; John McNamara > >; Marko Kovacevic > >; Thomas Monjalon > >; F

Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity

2019-08-06 Thread Stephen Hemminger
On Tue, 6 Aug 2019 08:19:01 + Matan Azrad wrote: > From: Stephen Hemminger > > On Sun, 4 Aug 2019 08:31:54 + > > Matan Azrad wrote: > > > > > > > > /* convert parameter to a number and verify */ > > > > > > pm = strtoul(portmask, &end, 16); > > > > > > - if (end == NULL || *

Re: [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 5:56 PM, Matan Azrad wrote: It may be needed by the user to limit the LRO session packet size. In order to allow the above limitation, a new Rx configuration may be added for the maximum LRO session size. A new capability may be added too to expose the maximum LRO session size supporte

[dpdk-dev] net/i40e: fix vf runtime queues rss config

2019-08-06 Thread Xiao Zhang
I40evf queue can not work properly with kernel pf driver. Eg. when configured to use 8 queue pairs, only 4 queues can receive packets, and half packets will be lost if using 2 queue pairs. This issue is caused by misconfiguration of look up table, use aq command to setup the lut to make it work pro

[dpdk-dev] [PATCH] net/mlx5: fix memory event callback list

2019-08-06 Thread Viacheslav Ovsiienko
The shared Infiniband device context should be included into memory event callback list only once on context creation, and removed from the list only once on context destroying. Multiple insertions of the same object caused the infinite loop on the list processing. Fixes: ccb3815346e6 ("net/mlx5:

[dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields

2019-08-06 Thread Matan Azrad
It may be needed by the user to limit the LRO session packet size. In order to allow the above limitation, a new Rx configuration may be added for the maximum LRO session size. A new capability may be added too to expose the maximum LRO session size supported by the port. Signed-off-by: Matan Azr

[dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

2019-08-06 Thread Matan Azrad
The API breakage is because the ``tso_segsz`` field was documented for LRO. The ``tso_segsz`` field in mbuf indicates the size of each segment in the LRO packet in Rx path and should be provided by the LRO packet port. While the generic LRO packet may aggregate different segments sizes in one pac

Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion

2019-08-06 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, August 6, 2019 12:35 PM > To: Su, Simei > Cc: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei ; Yang, > Qiming ; or...@mellanox.com; > adrien.mazarg...@6wind.com; ary

Re: [dpdk-dev] [EXT] Re: [RFC 1/3] ethdev: add ptype as an Rx offload

2019-08-06 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Andrew Rybchenko >Sent: Tuesday, August 6, 2019 2:30 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; John McNamara >; Marko Kovacevic >; Thomas Monjalon >; Ferruh Yigit >Cc: dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [RFC 1/3] ethdev: add p

Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity

2019-08-06 Thread Zhang, Xiao
Got it. Thanks Xiaolong and Qi. > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, August 6, 2019 10:01 PM > To: Zhang, Xiao ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Xing, Beilei > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [v2 0/5] fix dereference after null check coveri

Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity

2019-08-06 Thread Ye Xiaolong
Hi, Xiao On 08/06, Zhang, Qi Z wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong >> Sent: Monday, August 5, 2019 11:46 PM >> To: Zhang, Xiao >> Cc: dev@dpdk.org; Yang, Qiming ; Xing, Beilei >> ; sta...@dpdk.org >> Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal

2019-08-06 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Friday, August 2, 2019 2:29 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly > Subject: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal > > This symbol has been deprecated fo

Re: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload

2019-08-06 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Ananyev, Konstantin >Sent: Tuesday, August 6, 2019 2:50 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Hunt, David >; Kovacevic, Marko >; Ori Kam ; >Richardson, Bruce ; De Lara Guarch, >Pablo ; Nicolau, Radu >; Akhil Goyal ; >Kantecki, Toma

Re: [dpdk-dev] [PATCH v2] doc: announce removal of old port count function

2019-08-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Tuesday, August 6, 2019 7:02 PM > To: dev@dpdk.org > Cc: David Marchand > Subject: [dpdk-dev] [PATCH v2] doc: announce removal of old port count > function > > The function rte_eth_dev_count() was marked as deprecated

Re: [dpdk-dev] [PATCH] doc: announce cpuflags check symbol removal

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 4:54 PM, Ananyev, Konstantin wrote: This symbol has been deprecated for quite some time. Let's drop it in the next release. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecat

Re: [dpdk-dev] [PATCH] doc: announce cpuflags check symbol removal

2019-08-06 Thread Ananyev, Konstantin
> This symbol has been deprecated for quite some time. > Let's drop it in the next release. > > Signed-off-by: David Marchand > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_note

Re: [dpdk-dev] [PATCH] doc: announce lcore_config symbol removal

2019-08-06 Thread Andrew Rybchenko
On 7/31/19 2:06 PM, David Marchand wrote: New accessors have been introduced to provide the hidden information. This symbol can now be kept internal. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal

2019-08-06 Thread Andrew Rybchenko
On 8/2/19 4:29 PM, David Marchand wrote: This symbol has been deprecated for quite some time. Let's drop it in the next release. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko since it was deprecated in previous LTS, I think it is already OK to remove.

Re: [dpdk-dev] [PATCH v2] doc: announce removal of old port count function

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 4:39 PM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Tuesday, August 6, 2019 2:32 PM To: dev@dpdk.org Cc: David Marchand Subject: [dpdk-dev] [PATCH v2] doc: announce removal of old port count function

Re: [dpdk-dev] [PATCH v2] doc: announce removal of old port count function

2019-08-06 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, August 6, 2019 2:32 PM > To: dev@dpdk.org > Cc: David Marchand > Subject: [dpdk-dev] [PATCH v2] doc: announce removal of old port count > function > > The function rte_eth_dev_

[dpdk-dev] [PATCH v2] doc: announce removal of old port count function

2019-08-06 Thread Thomas Monjalon
The function rte_eth_dev_count() was marked as deprecated in DPDK 18.05 in commit d9a42a69febf ("ethdev: deprecate port count function"). It is planned to be removed after the next LTS release. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- v2: move notice near other ethdev one ---

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight

2019-08-06 Thread Thomas Monjalon
06/08/2019 13:49, Jasvinder Singh: > The sched library checks the subport tc ov weight value regardless > of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not. > > This fix allows application to always set valid tc ov weight value. > > Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic

Re: [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag

2019-08-06 Thread Neil Horman
On Tue, Aug 06, 2019 at 12:03:38PM +0200, Thomas Monjalon wrote: > I think it would be good to rebase and send at the beginning of the 19.11 > cycle. > Thank you > I'm on PTO for the next 10 days or so, but yes, I'll take care of that asap. Thanks Neil > 13/06/2019 16:23, Neil Horman: > > Hey

Re: [dpdk-dev] [PATCH v7 1/2] examples/multi_process/client_server_mp: check port validity

2019-08-06 Thread Matan Azrad
Hi > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Monday, August 5, 2019 7:38 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v7 1/2] > examples/multi_process/client_server_mp: check port validity > > From: Stephen Hemminger > > The

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

2019-08-06 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, August 6, 2019 11:43 AM > To: Dumitrescu, Cristian ; Singh, Jasvinder > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from > pipe profile cli > > 31

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight

2019-08-06 Thread Jasvinder Singh
The sched library checks the subport tc ov weight value regardless of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not. This fix allows application to always set valid tc ov weight value. Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object") error log SCHED: pipe_profile

Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte flow RSS action

2019-08-06 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, August 6, 2019 7:39 PM > To: 'Thomas Monjalon' ; Su, Simei > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Yang, Qiming ; > adrien.mazarg...@6wind.com; or...@mellanox.com > Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI

Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte flow RSS action

2019-08-06 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, August 6, 2019 7:31 PM > To: Su, Simei > Cc: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei ; Yang, Qiming > ; adrien.mazarg...@6wind.com; > or...@mellanox.com > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion

2019-08-06 Thread Thomas Monjalon
04/07/2019 06:43, simei: > From: Simei Su > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This > can support symmetric hash function by rte_flow RSS action. > > Signed-off-by: Simei Su > --- > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash > funtion.

Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte flow RSS action

2019-08-06 Thread Thomas Monjalon
04/07/2019 06:46, simei: > From: Simei Su > > Add new structure inputset in rte_flow_action_rss. This > can support input set configuration by rte_flow RSS action. > > Signed-off-by: Simei Su > --- > +* ethdev: New member in ``rte_flow_action_rss`` to support input set change > + by rte_flow R

Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity

2019-08-06 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Monday, August 5, 2019 11:46 PM > To: Zhang, Xiao > Cc: dev@dpdk.org; Yang, Qiming ; Xing, Beilei > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [v2 0/5] fix dereference after null check cover

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice about changes to ethernet structures

2019-08-06 Thread Thomas Monjalon
> >> Tell users about upcoming changes to rte_ether_addr and > >> rte_ether_header. > >> > >> Signed-off-by: Stephen Hemminger > >> Acked-by: Bruce Richardson > > > > Acked-by: Andrew Rybchenko > > Acked-by: Ferruh Yigit Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-08-06 Thread Thomas Monjalon
23/07/2019 16:22, Ferruh Yigit: > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > void return value is bad for get API (like rte_eth_dev_info-get()) > > since caller does not know if the function does its job or not and > > output value is filled in. > > > > void return value is bad for state ch

Re: [dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations

2019-08-06 Thread Thomas Monjalon
26/07/2019 12:15, Burakov, Anatoly: > So it's biased towards scaling up quickly, but it's doing that over a > period. Please correct me if i'm wrong as i'm not really familiar with > this codebase, but, assuming the window size is long enough, you could > be missing opportunities to scale down?

Re: [dpdk-dev] [PATCH] net/ice: remove wrong tag for dev parameter

2019-08-06 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaolong Ye > Sent: Thursday, August 1, 2019 11:12 PM > To: Yigit, Ferruh ; Yang, Qiming > ; Lu, Wenzhuo > Cc: dev@dpdk.org; Ye, Xiaolong ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: remove wrong tag

Re: [dpdk-dev] [PATCH] net/e1000: fix unchecked return value coverity issue

2019-08-06 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Monday, August 5, 2019 1:39 PM > To: Zhang, Xiao > Cc: dev@dpdk.org; Lu, Wenzhuo ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix unchecked return value > coverity issue >

Re: [dpdk-dev] [PATCH v2] net/ice: fix potential null pointer dereferences

2019-08-06 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaolong Ye > Sent: Monday, August 5, 2019 5:15 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Ye, Xiaolong ; Wang, Ying A > > Subject: [dpdk-dev] [PATCH v2] net/ice: fix potential null pointer > de

[dpdk-dev] Multiprocess CI failures

2019-08-06 Thread David Marchand
Hello Anatoly, I noticed some failures in CI tests: https://travis-ci.com/ovsrobot/dpdk/jobs/222357629 https://travis-ci.com/ovsrobot/dpdk/jobs/72182 Do we have an issue with multiprocess mappings? Or is this something that can happen? and we should set errno = ETOOBAD ;-) -- David Marchan

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

2019-08-06 Thread Thomas Monjalon
31/07/2019 14:19, Dumitrescu, Cristian: > From: Singh, Jasvinder > > Subject: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile > > cli > > > > Since sched library always check the non-zero value of subport tc > > ov weight. Therefore, it is necessary to set right value of tc ov >

[dpdk-dev] [PATCH v5 1/2] vhost: support inflight share memory protocol feature

2019-08-06 Thread JinYu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the shared buffer from backend. Then qemu should send it back through VHOST_USER_S

[dpdk-dev] [PATCH v5 2/2] vhost: add vhost-user-blk example which support inflight

2019-08-06 Thread JinYu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so It can show how there APIs work to support inflight feature. Signed-off-by: JinYu --- V1 - add the case. V2 - add the rte_vhost prefix. V3 - add packed ring support --- examples/vh

[dpdk-dev] [PATCH v5 0/2] vhost: support inflight share memory protocol feature

2019-08-06 Thread JinYu
This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Now It can both support split and packed ring. The example code show how these API work. The test has passed. How to test the example

Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP

2019-08-06 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, July 24, 2019 2:32 PM > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org; Jack Min > Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP > > The RSS expand function for I

[dpdk-dev] [PATCH] app/compress-perf: fix floating point exception

2019-08-06 Thread Adam Dybkowski
This patch fixes the floating point exception that happened when the number of cores to be used during the benchmark was zero. After the fix such situation is detected, the error message is printed and the benchmark application exits. Fixes: 424dd6c8c1a8 ("app/compress-perf: add weak functions for

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/bpf: fix compilation issue

2019-08-06 Thread Thomas Monjalon
31/07/2019 09:26, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 30/07/2019 12:19, Konstantin Ananyev: > > > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are > > > failing to compile with latest dpdk.org master. > > > The reason is changes in some core

Re: [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag

2019-08-06 Thread Thomas Monjalon
I think it would be good to rebase and send at the beginning of the 19.11 cycle. Thank you 13/06/2019 16:23, Neil Horman: > Hey- > Based on our recent conversations regarding the use of symbols only > meant for internal dpdk consumption (between dpdk libraries), this is an idea > that I've

Re: [dpdk-dev] [PATCH] common/caamflib: move shared sec HW code

2019-08-06 Thread Hemant Agrawal
> > common/caamflib}/rta/store_cmd.h > > (100%) > > > > Can we move this in dpaax instead of having a separate directory for NXP > specific code. [Hemant] Yes, We can.

[dpdk-dev] [PATCH] app/compress-perf: fix memory deallocation issue

2019-08-06 Thread Adam Dybkowski
This patch fixes the memory deallocation issue which happened after unsuccessful allocation (e.g. due to the out of memory) and produced the segmentation fault. Fixes: 424dd6c8c1 ("app/compress-perf: add weak functions for multicore test") Signed-off-by: Adam Dybkowski --- app/test-compress-per

Re: [dpdk-dev] [PATCH] common/caamflib: move shared sec HW code

2019-08-06 Thread Akhil Goyal
> The SEC HW code is being shared by multiple NXP based > drivers. It is better to place it at a common place. > > Signed-off-by: Hemant Agrawal > --- > drivers/{crypto/dpaa2_sec/hw => common/caamflib}/compat.h | 0 > drivers/{crypto/dpaa2_sec/hw => common/caamflib}/desc.h | 4 ++-- > .../{

Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name

2019-08-06 Thread Dybkowski, AdamX
> -Original Message- > From: Daly, Lee > Sent: Tuesday, 6 August, 2019 11:28 > To: Dybkowski, AdamX ; dev@dpdk.org; > Trahe, Fiona ; Luse, Paul E > Cc: Dybkowski, AdamX > Subject: RE: [dpdk-dev] [PATCH] compress/isal: create shorter qp name > > Hi Adam, > > Take care to add the maintain

Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name

2019-08-06 Thread Daly, Lee
Hi Adam, Take care to add the maintainer of the code you are changing to your email, a list can be found in the MAINTAINERS file. This will hopefully ensure a response to the change. Thanks. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adam Dybkowski > Sen

Re: [dpdk-dev] [PATCH v2] net/memif: fix multi-process malfunctioning device

2019-08-06 Thread Thomas Monjalon
06/08/2019 10:45, Phil Yang: > When working as a secondary process, it uses eth_memif_rx in PMD egress. > It should be eth_memif_tx. > > Fixes: c41a04958b ("net/memif: support multi-process") > > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu Applied, thanks Instead of the vague "malfunctio

[dpdk-dev] [PATCH] common/caamflib: move shared sec HW code

2019-08-06 Thread Hemant Agrawal
The SEC HW code is being shared by multiple NXP based drivers. It is better to place it at a common place. Signed-off-by: Hemant Agrawal --- drivers/{crypto/dpaa2_sec/hw => common/caamflib}/compat.h | 0 drivers/{crypto/dpaa2_sec/hw => common/caamflib}/desc.h | 4 ++-- .../{crypto/dpaa2_sec/hw

Re: [dpdk-dev] [Suspected-Phishing][PATCH] net/mlx5: fix RSS expand for IP-in-IP

2019-08-06 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Wednesday, July 24, 2019 14:32 > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org; Jack Min > Subject: [Suspected-Phishing][PATCH] net/mlx5: fix RSS expand for IP-in-IP > > The RSS expand function for IP-in-IP tunnel

Re: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload

2019-08-06 Thread Ananyev, Konstantin
> -Original Message- > From: pbhagavat...@marvell.com [mailto:pbhagavat...@marvell.com] > Sent: Tuesday, August 6, 2019 9:02 AM > To: jer...@marvell.com; Ananyev, Konstantin ; > Hunt, David ; Kovacevic, Marko > ; Ori Kam ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; Nicolau, Radu ;

[dpdk-dev] [PATCH] compress/isal: create shorter qp name

2019-08-06 Thread Adam Dybkowski
This patch shortens the queue pair name created when initializing the queue pair of the ISAL PIM, based on the device and qp ids. The patch idea of shortening the queue pair name was proposed by Luse, Paul E < Signed-off-by: Adam Dybkowski --- drivers/compress/isal/isal_compress_pmd_ops.c | 2 +-

Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 11:47 AM, Pavan Nikhilesh Bhagavatula wrote: -Original Message- From: Hemant Agrawal Sent: Tuesday, August 6, 2019 1:49 PM To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob Kollanukkaran Cc: dev@dpdk.org Subject: RE: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload Add PTYP

Re: [dpdk-dev] [RFC 1/3] ethdev: add ptype as an Rx offload

2019-08-06 Thread Andrew Rybchenko
On 8/6/19 11:02 AM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add ptype to DEV_RX_OFFLOAD_* flags which can be used to enable/disable packet type parsing. Signed-off-by: Pavan Nikhilesh I like the idea. I think there are few more Rx features which lack Rx offload bit:  - deliver

Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload

2019-08-06 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Hemant Agrawal >Sent: Tuesday, August 6, 2019 1:49 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran >Cc: dev@dpdk.org >Subject: RE: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload >> >> Add PTYPE to DEV_RX_OFFLOAD_* flags. >> >> Currently

[dpdk-dev] [PATCH v2] net/memif: fix multi-process malfunctioning device

2019-08-06 Thread Phil Yang
When working as a secondary process, it uses eth_memif_rx in PMD egress. It should be eth_memif_tx. Fixes: c41a04958b ("net/memif: support multi-process") Signed-off-by: Phil Yang Reviewed-by: Gavin Hu --- v2: Add descriptions in commit log. v1: Initial version. drivers/net/memif/rte_eth_mem

Re: [dpdk-dev] [PATCH v2] examples/ntb: fix error handling

2019-08-06 Thread Thomas Monjalon
06/08/2019 09:45, Ye Xiaolong: > On 08/05, Xiaoyun Li wrote: > >This patch adds return value checking for fseek function to fix > >error handling issue found by coverity scan. > > > >Coverity issue: 344996 > >Fixes: c5eebf85badc ("examples/ntb: add example for NTB") > >Cc: sta...@dpdk.org > > > >Si

Re: [dpdk-dev] [PATCH v2] net/memif: fix coverity defects

2019-08-06 Thread Thomas Monjalon
05/08/2019 11:07, Jakub Grajciar: > fixes CID: 343440, 343459, 343464, 343394 > > Signed-off-by: Jakub Grajciar Commit message fixed: net/memif: fix error paths Coverity issue: 343440, 343459, 343464, 343394 Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") App

[dpdk-dev] [PATCH 5/7] net/mlx5: support modify VLAN priority on VLAN hdr

2019-08-06 Thread Moti Haimovsky
This commit adds support for modifying the VLAN priority (PCP) field in about-to-be-pushed VLAN header. This feature can only modify the PCP field of a new VLAN header yet to be pushed. It does not support modifying an existing or already pushed VLAN headers. Signed-off-by: Moti Haimovsky --- dr

[dpdk-dev] [PATCH 3/7] net/mlx5: support pop flow action on VLAN header

2019-08-06 Thread Moti Haimovsky
This commit adds support for RTE_FLOW_ACTION_TYPE_OF_POP_VLAN via direct verbs flow rules. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.h| 5 ++- drivers/net/mlx5/mlx5_flow_dv.c | 78

[dpdk-dev] [PATCH 6/7] net/mlx5: supp modify VLAN ID on new VLAN header

2019-08-06 Thread Moti Haimovsky
This commit adds support for modifying the VLAN ID (VID) field in an about-to-be-pushed VLAN header. This feature can only modify the VID field of a new VLAN header yet to be pushed. It does not support modifying an existing or already pushed VLAN headers. Signed-off-by: Moti Haimovsky --- drive

[dpdk-dev] [PATCH 4/7] net/mlx5: support push flow action on VLAN header

2019-08-06 Thread Moti Haimovsky
This commit adds support for RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN using direct verbs flow rules. If present in the flow, The VLAN default values are taken from the VLAN item configuration. In this commit only the VLAN TPID value can be set since VLAN modification actions are not supported yet. Signed

[dpdk-dev] [PATCH 7/7] net/mlx5: supp modify VLAN ID on existing VLAN hdr

2019-08-06 Thread Moti Haimovsky
This commit adds support for modifying the VID of the outermost VLAN header already present in the packet. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5_flow.h| 3 +- drivers/net/mlx5/mlx5_flow_dv.c | 90 +++-- drivers/net/mlx5/mlx5_prm.h |

[dpdk-dev] [PATCH 2/7] net/mlx5: add VLAN push/pop DR commands to glue

2019-08-06 Thread Moti Haimovsky
This commit adds the mlx5dv VLAN push and pop commands to mlx5_glue interface. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/meson.build | 2 ++ drivers/net/mlx5/mlx5_glue.c | 29 + drivers/net/mlx5/mlx5_glue.h | 6 +

[dpdk-dev] [PATCH 1/7] net/mlx5: support for an action search in a list

2019-08-06 Thread Moti Haimovsky
This commit adds a helper routine that supports searching for a specific action in a list of actions. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5_flow.c | 23 +++ drivers/net/mlx5/mlx5_flow.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/ml

[dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-08-06 Thread Moti Haimovsky
VLAN actions support is implemented in librte_ethdev, and in test-pmd application, based on [1] Generic flow API. These actions conform to the VLAN actions defined in [2] the OpenFlow Switch Specification. rte_flow defines the following VLAN actions: 1. OF_POP_VLAN Pop the outer-most VLAN hea

Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload

2019-08-06 Thread Hemant Agrawal
> > Add PTYPE to DEV_RX_OFFLOAD_* flags. > > Currently, most of the NICs already support PTYPE parsing and update the > mbuf->packet_type through an internal lookup table, but there is no way to > disable the lookup if the application is not intrested in ptypes returned by > `rte_eth_dev_get_supp

  1   2   >