Re: [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support

2020-04-08 Thread Xiaojun Liu
Hi Xiao, Thank you! I add release note and remove the DEV_RX_OFFLOAD_RSS_HASH modification(It may be a mistake). I submit the new patch again:) Best regards, Xiaojun -Original Message- From: Wang, Xiao W [mailto:xiao.w.w...@intel.com] Sent: Thursday, April 02, 2020 5:12 PM To: Xiaoju

[dpdk-dev] [PATCH v4 4/5] net/fm10k: add flow interface and switch management

2020-04-08 Thread Xiaojun Liu
Add flow interface to support offload flow into HW. It supports parse vlan and parse mpls, all these data will be transferred to ffu data. Add switch management, includes initialization, port mapping, epl port link, LED controller, interrupt handler. It create 3 threads. One for interrupt handler,

[dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support

2020-04-08 Thread Xiaojun Liu
Split dev init to 2 parts. First only register the port in switch management; second init hook will be called after all the pf are registered and switch initialization. It will finish dev init. Also add switch interrupt support. Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset to support mirror op

[dpdk-dev] [PATCH v4 3/5] net/fm10k: add ffu and statistics and config file functions

2020-04-08 Thread Xiaojun Liu
Add ffu to support offload flow into HW. It supports forward, mirror, push VLAN, pop VLAN. It also supports flowset for a group flow definition. The config file can configure debug log, port speed, epl port mapping dpdk port, flowset. All these configuration will be used by switch management. Stati

[dpdk-dev] [PATCH v4 1/5] net/fm10k: add basic functions for switch management

2020-04-08 Thread Xiaojun Liu
Add I2C to control the inside LED and PHY. All the operations of I2C are using fm10k I2C register. Add SBUS to communicate with spico(micro code in serdes) by using fm10k SBUS register. This is like I2C operations. Add registers defination, which include all the registers will be used in the driver

[dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-08 Thread Xiaojun Liu
V4: * Add I2C to control the inside LED and PHY. * Add SBUS to communicate with spico. * Add registers defination. * Add switch management log API. * Add switch management structures. * Add epl serdes include loading spico, controlling pcsl, dma, dfe, ical. * Add spico code. * Add state machine f

Re: [dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management

2020-04-08 Thread Xiaojun Liu
Hi Xiao, OK. I will check the two empty lines carefully and check the patch by "git am". Best regards, Xiaojun -Original Message- From: Wang, Xiao W [mailto:xiao.w.w...@intel.com] Sent: Thursday, April 02, 2020 4:56 PM To: Xiaojun Liu; Zhang, Qi Z; Kwan, Ngai-mint; Keller, Jacob E Cc:

Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv

2020-04-08 Thread Ray Kinsella
On 08/04/2020 18:10, Ferruh Yigit wrote: > On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: >> Hi, >> >>> -Original Message- >>> From: Ophir Munk >>> Sent: Monday, March 30, 2020 1:32 AM >>> To: dev@dpdk.org; Matan Azrad >>> Cc: Thomas Monjalon ; Olga Shern >>> ; Raslan Darawsheh ; Ophir

Re: [dpdk-dev] [PATCH v2 0/4] update i40e base code

2020-04-08 Thread Ye Xiaolong
On 04/08, Jiaqi Min wrote: >The main changes include: > >* Update X722/X710 FW API version to 1.10. >* New device ID introduced for V710-T*L 5G. >* Add constants for PTP pins. >* Update version in README. >--- >v2 changes: >* Updated version in README > >Jiaqi Min (4): > net/i40e/base: update X722

Re: [dpdk-dev] [PATCH v2 0/4] update i40e base code

2020-04-08 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Jiaqi Min > Sent: Wednesday, April 8, 2020 6:05 PM > To: dev@dpdk.org > Cc: Min, JiaqiX > Subject: [dpdk-dev] [PATCH v2 0/4] update i40e base code > > The main changes include: > > * Update X722/X710 FW API version to 1.10. > * New device

Re: [dpdk-dev] [dpdk-techboard] rte_atomic deprecation discussion for the tech board meeting

2020-04-08 Thread Honnappa Nagarahalli
Adding the dev mailing list. We could not complete the discussion today in the tech board. It was agreed that the older compilers without C11 atomic API support (stdatomic.h) need to be supported and wrappers around C11 built-ins can be provided. OVS [1] implementation was pointed out. [1] htt

Re: [dpdk-dev] [PATCH v3 0/2] add generic filter support for iavf

2020-04-08 Thread Ye Xiaolong
On 04/03, Qiming Yang wrote: >This patch set added generic flow APIs and supported patterns includes: >/* L2 */ >/* ARP */ >/* IPv4 */ >/* IPv6 */ >/* GTPU */ >/* ESP */ >/* AH */ >/* L2TPV3 */ >/* PFCP */ > >--- >v2 changes: > - fixed document error. > - fixed multiple thread not safe issue. > -

Re: [dpdk-dev] [Bug 440] net/mlx5: Read of "out_of_buffer" using fopen/fscanf/fclose causing TLB shootdowns due to mmap/munmap

2020-04-08 Thread Mohsin Shaikh
Resending. commit 89681d3655f27d758537ae01a02d500deee1acd6 Author: Mohsin Shaikh Date: Thu Apr 9 12:19:45 2020 +0800 net/mlx5: Use open/read/close for reading ib stat fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(

Re: [dpdk-dev] [Bug 440] net/mlx5: Read of "out_of_buffer" using fopen/fscanf/fclose causing TLB shootdowns due to mmap/munmap

2020-04-08 Thread Mohsin Shaikh
Hi Alexander, Thank you for your quick response. Please find attached the patch for bug 440. - Mohsin > On 9 Apr 2020, at 1:07 AM, bugzi...@dpdk.org wrote: > > https://bugs.dpdk.org/show_bug.cgi?id=440 > > Alexander Kozyrev (akozy...@mellanox.com) changed: > > What|Removed

Re: [dpdk-dev] [PATCH v4 06/29] graph: populate fastpath memory for graph reel

2020-04-08 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: dev On Behalf Of Andrzej Ostruszka > Sent: Wednesday, April 8, 2020 11:00 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 06/29] graph: populate fastpath memory for > graph reel > > On 4/5/20 10:55 AM, jer...@marvell.com wrote: > > From: Jerin Jaco

Re: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types

2020-04-08 Thread Jeff Guo
Bernard and qi On 4/8/2020 8:15 AM, Zhang, Qi Z wrote: -Original Message- From: Iremonger, Bernard Sent: Wednesday, April 8, 2020 1:02 AM To: Guo, Jia ; Ye, Xiaolong ; Zhang, Qi Z Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui ; Su, Simei ; Guo, Jia Subject: RE: [dpdk-dev] [dpdk-dev v

[dpdk-dev] [PATCH v2] net/pfe: fix double free of MAC address

2020-04-08 Thread wangyunjian
From: Yunjian Wang The 'mac_addrs' freeing has been moved to rte_eth_dev_release_port(), so freeing 'mac_addrs' like this in pfe_eth_exit() is unnecessary and will cause double free. Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang ---

Re: [dpdk-dev] [PATCH v3 09/12] service: avoid race condition for MT unsafe service

2020-04-08 Thread Honnappa Nagarahalli
> > > > > > Subject: [PATCH v3 09/12] service: avoid race condition for MT > > > > unsafe service > > > > > > > > From: Honnappa Nagarahalli > > > > > > > > There has possible that a MT unsafe service might get configured > > > > to run on another core while the service is running currently. > >

Re: [dpdk-dev] Arm roadmap for 20.05

2020-04-08 Thread Chen, Zhaoyan
> -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Tuesday, April 7, 2020 1:15 PM > To: Mattias Rönnblom ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com; Morten Brørup > ; Ananyev, Konstantin > ; Richardson, Bruce > ; Van Haaren, Harry > ; David Ch

Re: [dpdk-dev] [PATCH v1] net/pfe: fix to set mac_addrs to NULL after freeing

2020-04-08 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 8, 2020 10:28 PM > To: wangyunjian ; dev@dpdk.org > Cc: g.si...@nxp.com; akhil.go...@nxp.com; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org; Hemant Agrawal > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v2 1/4] hash: add k32v64 hash library

2020-04-08 Thread Ananyev, Konstantin
Hi Vladimir, I didn't look at actual implementation (yet), just some compatibility comments. > K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. > This table is hash function agnostic so user must provide > precalculated hash signature for add/delete/lookup operations. >

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-08 Thread Honnappa Nagarahalli
> > > > > > Subject: [PATCH 2/2] lib/timer: relax barrier for status update > > > > > > > > Volatile has no ordering semantics. The rte_timer structure > > > > defines timer status as a volatile variable and uses the rte_r/wmb > > > > barrier to guarantee inter-thread visibility. > > > > > > > >

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-08 Thread Carrillo, Erik G
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, April 8, 2020 4:16 PM > To: Carrillo, Erik G ; Phil Yang > ; rsanf...@akamai.com; dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; Gavin

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-08 Thread Honnappa Nagarahalli
> > Subject: [PATCH 2/2] lib/timer: relax barrier for status update > > > > Volatile has no ordering semantics. The rte_timer structure defines > > timer status as a volatile variable and uses the rte_r/wmb barrier to > > guarantee inter-thread visibility. > > > > This patch optimized the volatil

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-08 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Monday, February 24, 2020 12:42 AM > To: rsanf...@akamai.com; Carrillo, Erik G ; > dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; honnappa.nagaraha...@arm.c

[dpdk-dev] [PATCH] eal: return -1 if rte_lcore_index called from non-DPDK thread

2020-04-08 Thread Stephen Hemminger
If rte_lcore_index() is asked to give the index of the current lcore (argument -1) and is called from a non-DPDK thread then it would invalid result. The result would come lcore_config[-1].core_index which is some other data in the per-thread area. The resolution is to return -1 which is what rte_

[dpdk-dev] [Bug 446] rte_lcore_index(-1) returns invalid data for non DPDK thread.

2020-04-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=446 Bug ID: 446 Summary: rte_lcore_index(-1) returns invalid data for non DPDK thread. Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED

[dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-08 Thread Neil Horman
Since we've moved away from our initial validate-abi.sh script, in favor of check-abi.sh, which uses libabigail, remove the old script from the tree, and update the docs accordingly Signed-off-by: Neil Horman CC: tho...@monjalon.net CC: david.march...@redhat.com CC: m...@ashroe.eu --- MAINTAINER

Re: [dpdk-dev] [PATCH v3 12/12] service: relax barriers with C11 atomic operations

2020-04-08 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, April 6, 2020 6:06 PM > To: Van Haaren, Harry ; Phil Yang > ; tho...@monjalon.net; Ananyev, Konstantin > ; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvel

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-08 Thread Jerin Jacob
On Wed, Apr 8, 2020 at 11:27 PM Mattias Rönnblom wrote: > > Extend Eventdev API to allow for event devices which require various > forms of internal processing to happen, even when events are not > enqueued to or dequeued from a port. > > Signed-off-by: Mattias Rönnblom > --- > lib/librte_eventd

Re: [dpdk-dev] [PATCH v4 08/29] graph: implement graph operation APIs

2020-04-08 Thread Jerin Jacob
On Wed, Apr 8, 2020 at 11:19 PM Andrzej Ostruszka wrote: > > On 4/5/20 10:55 AM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Adding support for graph specific API implementation like > > Graph lookup to get graph object, retrieving graph ID > > From name and graph name from ID. > > >

[dpdk-dev] [PATCH v3 1/2] hash: add hash bulk lookup with hash signatures array

2020-04-08 Thread Vladimir Medvedkin
Implement rte_hash_lookup_with_hash_bulk_data() - lookup function with precomputed hash signatures. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_cuckoo_hash.c| 309 --- lib/librte_hash/rte_hash.h | 55 +++ lib/librte_hash/rte_hash_v

[dpdk-dev] [PATCH v3 2/2] test: update hash performance tests

2020-04-08 Thread Vladimir Medvedkin
Add preformance test for rte_hash_lookup_with_hash_bulk_data() Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 60 +++ 1 file changed, 55 insertions(+), 5 deletions(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.

[dpdk-dev] [PATCH v2 3/4] test: add k32v64 hash autotests

2020-04-08 Thread Vladimir Medvedkin
Add autotests for rte_k32v64_hash library Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 12 +++ app/test/meson.build| 3 + app/test/test_k32v64_hash.c | 229 4 files changed, 245 in

[dpdk-dev] [PATCH v2 4/4] test: add k32v64 perf tests

2020-04-08 Thread Vladimir Medvedkin
Add performance tests for rte_k32v64_hash Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 83 +++ 1 file changed, 83 insertions(+) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index a438eae..0a02445 100644 --- a

[dpdk-dev] [PATCH v2 2/4] hash: add documentation for k32v64 hash library

2020-04-08 Thread Vladimir Medvedkin
Add programmers guide and doxygen API for k32v64 hash library Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/k32v64_hash_lib.rst | 66 +++ 3 files changed,

[dpdk-dev] [PATCH v2 0/4] add new k32v64 hash table

2020-04-08 Thread Vladimir Medvedkin
Currently DPDK has a special implementation of a hash table for 4 byte keys which is called FBK hash. Unfortunately its main drawback is that it only supports 2 byte values. The new implementation called K32V64 hash supports 4 byte keys and 8 byte associated values, which is enough to store a point

[dpdk-dev] [PATCH v2 1/4] hash: add k32v64 hash library

2020-04-08 Thread Vladimir Medvedkin
K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. This table is hash function agnostic so user must provide precalculated hash signature for add/delete/lookup operations. Signed-off-by: Vladimir Medvedkin --- lib/Makefile | 2 +- lib/librte_hash/M

Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support for telemetry

2020-04-08 Thread Wiles, Keith
> On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > From: Bruce Richardson > > The ethdev library now registers commands with telemetry, and > implements the callback functions. These commands allow the list of > ethdev ports and the stats and link status for a port to be queried. > > Si

Re: [dpdk-dev] [PATCH v2 06/16] telemetry: add utility functions for creating json

2020-04-08 Thread Wiles, Keith
> On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > From: Bruce Richardson > > The functions added in this patch will make it easier for applications > to build up correct JSON responses to telemetry requests. > > Signed-off-by: Bruce Richardson > --- > lib/librte_telemetry/Makefile

Re: [dpdk-dev] [PATCH 1/4] lib: introduce IF Proxy library

2020-04-08 Thread Andrzej Ostruszka [C]
On 4/8/20 5:04 AM, Varghese, Vipin wrote: > Hi Andrzej, > > Thanks for the reply. Please find explanations for some of the queries > > snipped +uint64_t rte_ifpx_events_available(void) { + /* All events are supported on Linux. */ + return (1ULL << RTE_IFPX_NUM_EVENTS) - 1; >>> S

[dpdk-dev] [RFC 3/3] eventdev: allow devices requiring maintenance with adapters

2020-04-08 Thread Mattias Rönnblom
Introduce support for event devices requiring calls to rte_event_maintain() in the Ethernet RX, Timer and Crypto Eventdev adapters. Signed-off-by: Mattias Rönnblom --- lib/librte_eventdev/rte_event_crypto_adapter.c | 16 +++- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 3 +++ l

[dpdk-dev] [RFC 2/3] event/dsw: make use of eventdev maintenance facility

2020-04-08 Thread Mattias Rönnblom
Set the RTE_EVENT_DEV_CAP_REQUIRES_MAINT flag, and perform DSW background tasks on rte_event_maintain() calls. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 4 +++- drivers/event/dsw/dsw_evdev.h | 1 + drivers/event/dsw/dsw_event.c | 8 lib/librte_ev

[dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-08 Thread Mattias Rönnblom
Extend Eventdev API to allow for event devices which require various forms of internal processing to happen, even when events are not enqueued to or dequeued from a port. Signed-off-by: Mattias Rönnblom --- lib/librte_eventdev/rte_eventdev.h | 65 ++ lib/librte_eventd

Re: [dpdk-dev] [PATCH v3 09/12] service: avoid race condition for MT unsafe service

2020-04-08 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, April 4, 2020 7:03 PM > To: Van Haaren, Harry ; Phil Yang > ; tho...@monjalon.net; Ananyev, Konstantin > ; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marv

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-08 Thread Thomas Monjalon
08/04/2020 18:49, Ciara Power: > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the previously sent RFC for a "process info" > library: https://patch

Re: [dpdk-dev] [PATCH v2 05/16] telemetry: introduce new telemetry functionality

2020-04-08 Thread Wiles, Keith
> On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > From: Bruce Richardson > > This patch introduces a new telemetry connection socket and handling > functionality. Like the existing telemetry implementation (which is > unaffected by this change) it uses a unix socket, but unlike the > ex

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-08 Thread Thomas Monjalon
08/04/2020 17:49, Lukasz Wojciechowski: > Hi guys, > > I don't know what is the current status of "legacy" build using > gnumakes, so I added the new DEBUG flag to config just as it was done in > other libs like eventdev. > Many guides still point config files as the one that should be changed

Re: [dpdk-dev] [PATCH v4 08/29] graph: implement graph operation APIs

2020-04-08 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: > From: Jerin Jacob > > Adding support for graph specific API implementation like > Graph lookup to get graph object, retrieving graph ID > From name and graph name from ID. > > Signed-off-by: Jerin Jacob > Signed-off-by: Kiran Kumar K > Signed-off

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-08 Thread Thomas Monjalon
08/04/2020 18:15, Lukasz Wojciechowski: > Hi Thomas, > > Before my patch there was just a definition: > #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE > without #ifndef condition. > > It caused a build problem to me when working on security test, which > uses both rte_test.h and test.h > As l

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-08 Thread Thomas Monjalon
08/04/2020 16:34, Ray Kinsella: > On 07/04/2020 12:58, Thomas Monjalon wrote: > > I really wonder who is the real maintainer of ABI tooling and policy. > > Neil, Ray, I was expecting a better involvement in this major > > policy enforcement. > > I missed it on the ML, was check-maintainers.sh run?

Re: [dpdk-dev] [PATCH v4 06/29] graph: populate fastpath memory for graph reel

2020-04-08 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: > From: Jerin Jacob [...] > diff --git a/lib/librte_graph/graph_populate.c > b/lib/librte_graph/graph_populate.c > new file mode 100644 > index 0..093512efa > --- /dev/null > +++ b/lib/librte_graph/graph_populate.c > @@ -0,0 +1,234 @@ > +/* SP

Re: [dpdk-dev] [PATCH v4 07/29] graph: implement create and destroy APIs

2020-04-08 Thread Jerin Jacob
> > +++ b/lib/librte_graph/graph.c > [...] > > +static int > > +graph_node_add(struct graph *graph, struct node *node) > > +{ > > + struct graph_node *graph_node; > > + size_t sz; > > + > > + /* Skip the duplicate nodes */ > > + STAILQ_FOREACH(graph_node, &graph->node_list, next) >

[dpdk-dev] [PATCH v2 14/16] lib: add telemetry as eal dependency

2020-04-08 Thread Ciara Power
This patch moves telemetry further down the build, and adds it as a dependency for EAL. Telemetry V2 is now configured to build by default, and the legacy support is built when the telemetry config flag is set. Telemetry now has EAL flags, shown below: "--telemetry" = Enables telemetry (this is de

[dpdk-dev] [PATCH v2 15/16] eal: add eal telemetry callbacks

2020-04-08 Thread Ciara Power
From: Bruce Richardson EAL now registers commands to provide some basic info from EAL. Example: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"pid": 926, "version": "DPDK 20.05.0-rc0", "max_output_len": 16384} --> / {"/": ["/", "/eal/app_params", "/eal/params", "/ethdev/link_status", \

Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv

2020-04-08 Thread Ferruh Yigit
On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: > Hi, > >> -Original Message- >> From: Ophir Munk >> Sent: Monday, March 30, 2020 1:32 AM >> To: dev@dpdk.org; Matan Azrad >> Cc: Thomas Monjalon ; Olga Shern >> ; Raslan Darawsheh ; Ophir >> Munk ; Asaf Penso >> Subject: [PATCH v1] common/m

[dpdk-dev] [PATCH v2 16/16] doc: update telemetry documentation

2020-04-08 Thread Ciara Power
The existing documentation for Telemetry is updated, and further documentation is added. Signed-off-by: Ciara Power --- doc/api/doxy-api-index.md | 1 + doc/guides/howto/telemetry.rst| 108 ++ doc/guides/linux_gsg/eal_args.include.rst | 8 ++ d

[dpdk-dev] [PATCH v2 13/16] telemetry: remove existing telemetry files

2020-04-08 Thread Ciara Power
This patch removes the existing telemetry files, which are now redundant as the new version of telemetry has backward compatibility for their functionality. Signed-off-by: Ciara Power --- lib/librte_metrics/rte_metrics_telemetry.c|9 - lib/librte_telemetry/Makefile |5

[dpdk-dev] [PATCH v2 10/16] rawdev: add callback support for telemetry

2020-04-08 Thread Ciara Power
The rawdev library now registers commands with telemetry, and implements the corresponding callback functions. These allow a list of rawdev devices and xstats for a rawdev port to be queried. An example usage, with ioat rawdev driver instances, is shown below: Connecting to /var/run/dpdk/rte/dpdk

[dpdk-dev] [PATCH v2 12/16] telemetry: introduce telemetry backward compatibility

2020-04-08 Thread Ciara Power
The new telemetry will now open a socket using the old telemetry path, to ensure backward compatibility. This is not yet initialised, as it would clash with the existing telemetry, to be removed in a later patch. This means that both old and new telemetry socket interfaces are handled in a common w

[dpdk-dev] [PATCH v2 11/16] examples/l3fwd-power: enable use of new telemetry

2020-04-08 Thread Ciara Power
The l3fwd-power example app now registers a stats command with telemetry, and provides a callback function to handle formatting the power stats. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"pid": 6726, "version": "DPDK 20.05.0-rc0", "max_output_len": 16384}

[dpdk-dev] [PATCH v2 09/16] usertools: add new telemetry python script

2020-04-08 Thread Ciara Power
From: Bruce Richardson This patch adds a python script that can be used with the new telemetry socket. It connects as a client to the socket, and allows the user send a command and see the JSON response. The example usage below shows the script connecting to the new telemetry socket, and sending

[dpdk-dev] [PATCH v2 08/16] ethdev: add callback support for telemetry

2020-04-08 Thread Ciara Power
From: Bruce Richardson The ethdev library now registers commands with telemetry, and implements the callback functions. These commands allow the list of ethdev ports and the stats and link status for a port to be queried. Signed-off-by: Bruce Richardson Signed-off-by: Ciara Power --- v2: -

[dpdk-dev] [PATCH v2 05/16] telemetry: introduce new telemetry functionality

2020-04-08 Thread Ciara Power
From: Bruce Richardson This patch introduces a new telemetry connection socket and handling functionality. Like the existing telemetry implementation (which is unaffected by this change) it uses a unix socket, but unlike the existing one it does not have a fixed list of commands - instead librari

[dpdk-dev] [PATCH v2 06/16] telemetry: add utility functions for creating json

2020-04-08 Thread Ciara Power
From: Bruce Richardson The functions added in this patch will make it easier for applications to build up correct JSON responses to telemetry requests. Signed-off-by: Bruce Richardson --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build | 2 +- lib

[dpdk-dev] [PATCH v2 07/16] app/test: add telemetry json tests

2020-04-08 Thread Ciara Power
From: Bruce Richardson This patch adds tests for the json utility functions in the telemetry library. Signed-off-by: Bruce Richardson --- app/test/Makefile | 2 + app/test/meson.build | 4 + app/test/test_telemetry_json.c | 136 + 3 fi

[dpdk-dev] [PATCH v2 04/16] telemetry: invert dependency on metrics

2020-04-08 Thread Ciara Power
From: Bruce Richardson Rather than having the telemetry library depend on the metrics lib we invert the dependency so that metrics instead depends on telemetry lib, and registers the needed functions with it at init time. This prepares the way for a cleaner telemetry architecture to be applied in

[dpdk-dev] [PATCH v2 02/16] telemetry: move code to metrics for later reuse

2020-04-08 Thread Ciara Power
This commit moves some of the telemetry library code to a new file in the metrics library. No modifications are made to the moved code, except what is needed to allow it to compile and run. The additional code in metrics is built only when the Jansson library is present. Telemetry functions as nor

[dpdk-dev] [PATCH v2 03/16] metrics: reduce code taken from telemetry

2020-04-08 Thread Ciara Power
The telemetry code that was moved into the metrics library can be shortened, while still maintaining the same functionality. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson --- lib/librte_metrics/rte_metrics_telemetry.c | 476 lib/librte_metrics/rte_metrics_tele

[dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-08 Thread Ciara Power
This patchset extensively reworks the telemetry library adding new functionality and simplifying much of the existing code, while maintaining backward compatibility. This work is based on the previously sent RFC for a "process info" library: https://patchwork.dpdk.org/project/dpdk/list/?series=774

[dpdk-dev] [PATCH v2 01/16] build: add arch-specific header path to global includes

2020-04-08 Thread Ciara Power
From: Bruce Richardson The global include path, which is used by anything built before EAL, points to the EAL header files so they utility macros etc. can be used anywhere in DPDK. This path included the OS-specific EAL header files, but not the architecture-specific ones. This patch moves the se

Re: [dpdk-dev] [PATCH v4 07/29] graph: implement create and destroy APIs

2020-04-08 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: > From: Jerin Jacob > > Adding graph specific API implementations like graph create > and graph destroy. This detect loops in the graph, > check for isolated nodes and operation to verify the validity of > graph. > > Signed-off-by: Jerin Jacob > Sig

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-08 Thread Lukasz Wojciechowski
Hi Thomas, Before my patch there was just a definition: #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE without #ifndef condition. It caused a build problem to me when working on security test, which uses both rte_test.h and test.h As libraries should go first on the include list before local

[dpdk-dev] [PATCH 2/2] l3fwd-power: implement proper shutdown handling

2020-04-08 Thread Anatoly Burakov
Currently, shutdown for l3fwd-power application is all over the place and may or may not happen either in the signal handler or in the main() function. Fix this so that the signal handler will only set the exit variable, thereby allowing all of the loops to end properly and proceed to deinitialize

[dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed

2020-04-08 Thread Anatoly Burakov
Currently, if power library initialization fails, only a log message is displayed. This is suboptimal for a number of reasons, but the main one is that telemetry mode does not depend on the power library and can therefore run in environments where l3fwd-power would normally not run correctly (such

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-08 Thread Lukasz Wojciechowski
Hi guys, I don't know what is the current status of "legacy" build using gnumakes, so I added the new DEBUG flag to config just as it was done in other libs like eventdev. Many guides still point config files as the one that should be changed in order to enable some features, so I thought I sho

Re: [dpdk-dev] [PATCH v3 1/4] ip_frag: ensure minimum v4 fragmentation length

2020-04-08 Thread Aaron Conole
"Ananyev, Konstantin" writes: >> >> >> The IPv4 specification says that each fragment must at least the size >> >> >> of >> >> >> an IP header plus 8 octets. When attempting to run ipfrag using a >> >> >> smaller size, the fragment library will return successful completion, >> >> >> even though

Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests

2020-04-08 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 8, 2020 1:51 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests > > This patch adds a new test suite for v

Re: [dpdk-dev] [PATCH v2 1/2] compress/qat: im buffer too small - split op

2020-04-08 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 8, 2020 1:51 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/2] compress/qat: im buffer too small - split op > > This patch implements a special way of buffer

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-04-08 Thread David Marchand
On Wed, Apr 8, 2020 at 5:05 PM Gavin Hu wrote: > > -Original Message- > > From: Kevin Traynor > > Hi Gavin, I lost track if v2 is still a candidate for merge. fwiw, it > > compiles without giving the zero-length-bounds warning on my system. > > > > Kevin. > > Yes, this path alone is a ca

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-04-08 Thread Gavin Hu
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Wednesday, April 8, 2020 1:14 AM > To: Gavin Hu ; Bruce Richardson > ; Morten Brørup > > Cc: Ferruh Yigit ; dev@dpdk.org; nd > ; david.march...@redhat.com; tho...@monjalon.net; > jer...@marvell.com; Honnappa Nagarahalli > ; Ru

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-08 Thread Ray Kinsella
On 07/04/2020 08:36, David Marchand wrote: > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: >> >> Since we've moved away from our initial abi_versioning.sh script, in > > abi_versioning.sh does not exist (idem with the patch title). > I suppose you meant validate-abi.sh. > >> favor of chec

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-08 Thread Ray Kinsella
On 06/04/2020 20:34, Neil Horman wrote: > Since we've moved away from our initial abi_versioning.sh script, in > favor of check_abi.sh, which uses libabigail, remove the old script from > the tree, and update the docs accordingly > > Signed-off-by: Neil Horman > CC: tho...@monjalon.net > --- >

Re: [dpdk-dev] [dpdk-stable] [v2] app/testpmd: fix PPPOES flow API

2020-04-08 Thread Ferruh Yigit
On 4/5/2020 4:12 PM, Ori Kam wrote: > Hi Xiao, > > > >> -Original Message- >> From: Xiao Zhang >> Sent: Tuesday, March 31, 2020 4:30 PM >> To: dev@dpdk.org >> Cc: Ori Kam ; qi.z.zh...@intel.com; >> wei.zh...@intel.com; Xiao Zhang ; sta...@dpdk.org >> Subject: [v2] app/testpmd: fix PPPOE

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-08 Thread Anoob Joseph
Hi Thomas, > > -- > 08/04/2020 15:02, Anoob Joseph: > > Hi Thomas, > > > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > > This patch adds verification of the parameters to the ret_security > > > > API functions. All required p

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-08 Thread Ray Kinsella
On 07/04/2020 12:58, Thomas Monjalon wrote: > 07/04/2020 13:33, Neil Horman: >> On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: >>> On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: Since we've moved away from our initial abi_versioning.sh script, in >>> >>> abi_versio

Re: [dpdk-dev] [PATCH v1] net/pfe: fix to set mac_addrs to NULL after freeing

2020-04-08 Thread Ferruh Yigit
On 4/7/2020 12:39 PM, wangyunjian wrote: > From: Yunjian Wang > > It does not correctly set the mac_addrs variable to NULL after > freeing it, which will lead to a double free. > > Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: support flow director feature

2020-04-08 Thread Praveen Shetty
Support load distribution in security gateway application using NIC load distribution feature(Flow Director). Flow Director is used to redirect the specified inbound ipsec flow to a specified queue.This is achieved by extending the SA rule syntax to support specification by adding new action_type o

[dpdk-dev] [PATCH v3] crypto/aesni_mb: support DOCSIS AES-256

2020-04-08 Thread Mairtin o Loingsigh
This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh Acked-by: Pablo de Lara --- doc/guides/rel_notes/release_20_05.rst | 5 + drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++ 2 files changed, 11 insertions(+) diff --git a/doc/

[dpdk-dev] First the test fail and than get passed

2020-04-08 Thread Muhammad Bilal
About 2 days ago, I submitted a patch for a Bug 353. And I saw that "iol-testing" failed on patchwork for "openSUSE" Environment. Today I checked and it shows all the tests are passed [ http://mails.dpdk.org/archives/test-report/2020-April/124201.html]. Is this normal that first the test fail and t

Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

2020-04-08 Thread Kevin Traynor
On 08/04/2020 14:07, Alex Kiselev wrote: > rte_lpm6: fix incorrect size of tbl8 group > Fixes: e480688dce6d ("lpm6: add incremental update on delete") Cc: sta...@dpdk.org Thanks for Cc'ing stable. It is better to add the tag directly in the commit message as we automate checking for the tag in dp

Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

2020-04-08 Thread Thomas Monjalon
08/04/2020 15:02, Anoob Joseph: > Hi Thomas, > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > This patch adds verification of the parameters to the ret_security API > > > functions. All required parameters are checked if they are not NULL. > > [...] > > > --- a/config/common_base > > > +++ b/co

Re: [dpdk-dev] [PATCH v3 00/30] Update ENA driver to v2.1.0

2020-04-08 Thread Ferruh Yigit
On 4/8/2020 9:28 AM, Michal Krawczyk wrote: > Hi, > > This patchset is including severeal changes, including: > * ena_com (HAL) update > * Support for upcoming device features > * Refactor of the IO path > * Documentation update about ENA usage on metal instances > > v2: > * Fix comments from rev

Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

2020-04-08 Thread Bruce Richardson
On Wed, Apr 08, 2020 at 03:07:30PM +0200, Alex Kiselev wrote: > rte_lpm6: fix incorrect size of tbl8 group > Fixes: e480688dce6d ("lpm6: add incremental update on delete") > > Signed-off-by: Alex Kiselev > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-08 Thread Aaron Conole
Juraj Linkeš writes: > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. > > Signed-off-by: Juraj Linkeš > --- Acked-by: Aaron Conole

[dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

2020-04-08 Thread Alex Kiselev
rte_lpm6: fix incorrect size of tbl8 group Fixes: e480688dce6d ("lpm6: add incremental update on delete") Signed-off-by: Alex Kiselev --- lib/librte_lpm/rte_lpm6.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c index 1

Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

2020-04-08 Thread Anoob Joseph
Hi Thomas, > 08/04/2020 05:13, Lukasz Wojciechowski: > > This patch adds verification of the parameters to the ret_security API > > functions. All required parameters are checked if they are not NULL. > [...] > > --- a/config/common_base > > +++ b/config/common_base > > CONFIG_RTE_LIBRTE_SECURITY

Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

2020-04-08 Thread Thomas Monjalon
08/04/2020 05:13, Lukasz Wojciechowski: > This patch adds verification of the parameters to the ret_security API > functions. All required parameters are checked if they are not NULL. [...] > --- a/config/common_base > +++ b/config/common_base > CONFIG_RTE_LIBRTE_SECURITY=y > +CONFIG_RTE_LIBRTE_SE

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-08 Thread Thomas Monjalon
08/04/2020 05:13, Lukasz Wojciechowski: > Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause > as it might be already defined. I think it should not be defined at all. Why not including rte_test.h?

Re: [dpdk-dev] [PATCH 0/8] net/mlx5 counter optimize

2020-04-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, April 7, 2020 7:00 AM > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/8] net/mlx5 counter optimize > > In the plan of save the memory consumption for rte_flow, the counter > memory consumption will be optimized from

  1   2   >