[dpdk-dev] [PATCH v4] net/mlx5: fix matching for UDP tunnels with verbs

2020-05-05 Thread Raslan Darawsheh
When creating flow rule with zero specs it will cause matching all UDP packets like following: eth / ipv4 / udp / vxlan / end Such rule will match all udp packets. This change the behavior to match the dv flow engine which will automatically set the match on relative outer UDP port if the user di

Re: [dpdk-dev] Intel CI failure due to Virtio PMD AVX series

2020-05-05 Thread Liu, Yong
Sure, I have fixed it in http://patchwork.dpdk.org/patch/69802/. The issue was caused by clang 6.0.0 not defined the function when building 32-bit target. Thanks, Marvin > -Original Message- > From: Maxime Coquelin > Sent: Monday, May 4, 2020 5:59 PM > To: Liu, Yong > Cc: Yigit, Ferr

Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton

2020-05-05 Thread Ajit Khaparde
::snip:: > > + }, > > + .rx_adv_conf = { > > + .rss_conf.rss_hf = > > + ETH_RSS_IP | > > + ETH_RSS_UDP | > > May be it is better to remove ETH_RSS_UDP by default, > since it is les

[dpdk-dev] [PATCH v3] net/mlx5: fix matching for UDP tunnels with verbs

2020-05-05 Thread Raslan Darawsheh
When creating flow rule with zero specs it will cause matching all UDP packets like following: eth / ipv4 / udp / vxlan / end Such rule will match all udp packets. This change the behavior to match the dv flow engine which will automatically set the match on relative outer UDP port if the user di

[dpdk-dev] [PATCH] net/virtio: fix 32-bit build with clang 6.0.0

2020-05-05 Thread Marvin Liu
Clang 6.0.0 will undefine function _mm512_maskz_set1_epi64 on i686 target. Fix it by replacing the function with _mm512_set4_epi64 when doing 32-bit build. Warning messasge during build: ../drivers/net/virtio/virtio_rxtx_packed_avx.c:385:19: warning: implicit declaration of function '_mm512_maskz_

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread Jerin Jacob
On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin wrote: > > Hi, > > On 5/5/20 6:16 PM, David Marchand wrote: > > On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > > Removing this special case could break x86 applications running with > legacy virtio. > > > On the pl

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread Maxime Coquelin
Hi, On 5/5/20 6:16 PM, David Marchand wrote: > On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: Removing this special case could break x86 applications running with legacy virtio. On the plus side, we have been announcing for some time in virtio: RTE_PMD_REGIST

Re: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter

2020-05-05 Thread Yang, Qiming
Acked-by: Qiming Yang > -Original Message- > From: Jiang, JunyuX > Sent: Wednesday, May 6, 2020 11:05 > To: dev@dpdk.org > Cc: Yang, Qiming ; Jiang, JunyuX > ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix core dumped issue in switch filter > > The number of queues in queue group s

Re: [dpdk-dev] [PATCH] net/mlx5: fix debug log segfault on TxQ release

2020-05-05 Thread Matan Azrad
From: Alexander Kozyrev > Program received signal SIGSEGV, Segmentation fault. > 0x008ef7c4 in mlx5_tx_queue_release (dpdk_txq=0x17ce01680) at > drivers/net/mlx5/mlx5_txq.c:302 > 301 mlx5_txq_release(ETH_DEV(priv), i); > 302 DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", > 303

[dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow

2020-05-05 Thread Shougang Wang
This patch fixes the issue that the flow which both source MAC mask and destination MAC mask are all zeros can not be created. Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_flow.c | 3 ++- 1 file changed, 2

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Wed, May 6, 2020 at 1:40 AM Thomas Monjalon wrote: > > 05/05/2020 19:28, Jerin Jacob: > > On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > > 05/05/2020 19:09, Jerin Jacob: > > > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob > > > > wrote: > > > > > On Tue, May 5, 2020 at 10:28 PM T

[dpdk-dev] [PATCH 1/2] net/bnxt: fix to alloc FW specified TQM ring context memory

2020-05-05 Thread Kalesh A P
From: Kalesh AP Newer firmware advertises the number of TQM rings to allocate context memory for. Use the firmware specified value and fall back to the old value derived from "bp->max_q" if it is not available. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH 0/2] bnxt bug fixes

2020-05-05 Thread Kalesh A P
From: Kalesh AP Please apply. Kalesh AP (2): net/bnxt: fix to alloc FW specified TQM ring context memory net/bnxt: fix TQM ring context memory sizing formulas drivers/net/bnxt/bnxt.h| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 21 + drivers/net/bnxt/bnxt_hwrm.c |

[dpdk-dev] [PATCH 2/2] net/bnxt: fix TQM ring context memory sizing formulas

2020-05-05 Thread Kalesh A P
From: Kalesh AP The current formulas to calculate the TQM slow path and fast path ring context memory sizes are not quite correct. TQM slow path entry is array index 0 of ctx->tqm_mem[]. The other array entries are for fast path. Fix these sizes according to firmware spec. for 57500 and newer chi

Re: [dpdk-dev] [PATCH 0/2] fix coverity reported issues

2020-05-05 Thread Ajit Khaparde
On Tue, May 5, 2020 at 12:18 PM Ajit Khaparde wrote: > Fix issues reported by Coverity. > Note that one issue was reported in internal coverity scan. > Patches applied to dpdk-next-net-brcm. > > Ajit Khaparde (1): > net/bnxt: fix uninitialized variable error > > Kishore Padmanabha (1): > n

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-05-05 Thread Ray Kinsella
On 15/04/2020 12:17, Jerin Jacob wrote: > On Wed, Apr 15, 2020 at 4:39 PM Dmitry Kozlyuk > wrote: >> >> >> >>> On Wed, Apr 15, 2020 at 4:02 PM Dmitry Kozlyuk >>> wrote: > On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > wrote: >> >> Clang on Windows follows MS ABI wher

Re: [dpdk-dev] [PATCH v2] net/ice: support mark only action for FDIR

2020-05-05 Thread Ye Xiaolong
On 04/30, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Su, Simei >> Sent: Tuesday, April 14, 2020 11:11 PM >> To: Zhang, Qi Z ; Ye, Xiaolong >> Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei >> ; sta...@dpdk.org >> Subject: [PATCH v2] net/ice: support mark only action for FDIR >> >> T

Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD

2020-05-05 Thread Ye Xiaolong
On 04/16, zhihongx.p...@intel.com wrote: >From: Peng Zhihong > >DPDK does not implement interrupt mechanism on BSD, >so force NIC status synchronization. > >Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) >Cc: liang-min.w...@intel.com > >Signed-off-by: Peng Zhihong >--- > drivers/

Re: [dpdk-dev] [PATCH v2] net/ice/base: fix bm mask set and find switch recipe method

2020-05-05 Thread Ye Xiaolong
On 04/29, Wei Zhao wrote: >When we download a switch rule for ipv6 with esp payload >"eth / ipv6 / esp spi is 1 / end actions queue index 2 / end" > >if we don't add bm bit set check for tun_type, then a packet of >ipv4 with esp payload > >"sendp([Ether(dst="00:00:00:00:01:00")/IP(proto=50)/ESP(spi

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/iavf: fix link speed

2020-05-05 Thread Ye Xiaolong
On 04/30, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >If the PF driver does not support the new speed reporting capabilities then >use link_event instead of link_event_adv to get the speed. > >Fixes: 48de41ca11f0 (net/iavf: enable link status update) >Cc: jingjing...@intel.com >Cc: sta...@

Re: [dpdk-dev] [PATCH v3] net/axgbe: enabling VLAN support in axgbe

2020-05-05 Thread Sardar, Shamsher singh
[AMD Official Use Only - Internal Distribution Only] Hi Ferruh, Thanks for knowledge sharing. Yes etlt - 0x09 is nothing but indicate " ■ 4’b1001: The packet is type packet with Single CVLAN tag." And you are right it should be as below and will do changes on same: if (vlan) { mbuf->ol_f

[dpdk-dev] [PATCH] doc: add rcu defer queue API info

2020-05-05 Thread Honnappa Nagarahalli
Added notes about RCU defer queue APIs. Signed-off-by: Honnappa Nagarahalli --- doc/guides/rel_notes/release_20_05.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index c287cb48a..0d505d7f1 100644 ---

[dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-05-05 Thread Yuan Linsi
From: Linsi Yuan We see a stack smashing as a result of defensive code missing. Once the nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to zero after doing a floor align, and we can not exit the following receiving packets loop. And the buffers will be overwrite, then the stack

[dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-05-05 Thread Yuan Linsi
From: yuanlinsi01 We see a stack smashing as a result of defensive code missing. Once the nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to zero after doing a floor align, and we can not exit the following receiving packets loop. And the buffers will be overwrite, then the stac

[dpdk-dev] 答复: [PATCH] net/bnxt: fix a possible stack smashing

2020-05-05 Thread Yuan,Linsi
Ok, I'll modify it per you suggestion Thanks, Yuan Linsi 发件人: Ajit Khaparde 发送时间: 2020年5月5日 11:42:20 收件人: Ferruh Yigit 抄送: Yuan,Linsi; Somnath Kotur; Lance Richardson; dpdk-dev 主题: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing On Thu, Apr 30, 2

[dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter

2020-05-05 Thread Junyu Jiang
The number of queues in queue group should be checked before using it. This patch fixed the issue. Fixes: 47d460d63233 ("net/ice: rework switch filter") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang Tested-by: Qimai Xiao --- drivers/net/ice/ice_switch_filter.c | 2 ++ 1 file changed, 2 insert

Re: [dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-05-05 Thread Xiaoyu Min
On Tue, 20-05-05, 17:06, Ferruh Yigit wrote: > On 4/30/2020 2:07 PM, Xiaoyu Min wrote: > > One new cmdline option `--rx-mq-mode` is added in order to have the > > possibility to check whether PMD handle the mq mode correctly or not. > > > > The reason is some NICs need to do different settings bas

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-05 Thread Rasesh Mody
Hi, >From: Thomas Monjalon >Sent: Tuesday, May 05, 2020 2:15 AM > >05/05/2020 10:59, Ferruh Yigit: >> On 5/5/2020 7:44 AM, Jerin Jacob wrote: >> > On Tue, May 5, 2020 at 8:39 AM Rasesh Mody >wrote: >> >> >> >> Some applications do not explicitly restore Tx queues setup during >> >> port re-confi

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-05 Thread Rasesh Mody
Hi Ferruh, >From: Ferruh Yigit >Sent: Tuesday, May 05, 2020 2:01 AM > >On 5/5/2020 4:09 AM, Rasesh Mody wrote: >> Fix to assign dummy Rx/Tx handlers in dev_stop. >> For MTU set, assignment of the appropriate Rx/Tx handlers will be >> handled by dev_start/dev_stop. >> >> Fixes: 81f8804992c9 ("net/

Re: [dpdk-dev] [PATCH v2 1/2] eal: add fnmatch implementation

2020-05-05 Thread Narcisa Ana Maria Vasile
On Tue, May 05, 2020 at 06:30:31PM -0700, Pallavi Kadam wrote: > Fnmatch implementation is required on Windows to support > log level arguments specified with a globbing pattern. > The source file is with BSD-3-Clause license. > https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c

Re: [dpdk-dev] [PATCH v2 2/2] eal: add log support on Windows

2020-05-05 Thread Narcisa Ana Maria Vasile
On Tue, May 05, 2020 at 06:30:32PM -0700, Pallavi Kadam wrote: > Initialize logging on Windows to send log output > to the console. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > Reviewed-by: Tasnim Bashar > Tested-by: Dmitry Kozlyuk > --- Tested-by: Narcisa Vasile Acked-by: N

[dpdk-dev] [PATCH v2 2/2] eal: add log support on Windows

2020-05-05 Thread Pallavi Kadam
Initialize logging on Windows to send log output to the console. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Tasnim Bashar Tested-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal.c | 3 +++ lib/librte_eal/windows/eal_log.c | 16 lib/librte_ea

[dpdk-dev] [PATCH v2 1/2] eal: add fnmatch implementation

2020-05-05 Thread Pallavi Kadam
Fnmatch implementation is required on Windows to support log level arguments specified with a globbing pattern. The source file is with BSD-3-Clause license. https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by:

[dpdk-dev] [PATCH v2 0/2] Windows logging

2020-05-05 Thread Pallavi Kadam
This patchset adds EAL logging support on Windows. Logs will be sent to console output. v2 Changes: Introduced Fnmatch implementation first Added logging support in the second patch Pallavi Kadam (2): eal: add fnmatch implementation eal: add log support on Windows lib/librte

[dpdk-dev] 答复: [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

2020-05-05 Thread Lilijun (Jerry)
> -邮件原件- > 发件人: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > 发送时间: 2020年5月6日 7:18 > 收件人: Lilijun (Jerry) ; 'dev@dpdk.org' > > 抄送: wangyunjian ; xudingke > ; 'sta...@dpdk.org' ; nd > ; Honnappa Nagarahalli ; > yipeng1.w...@intel.com; nd > 主题: RE: [dpdk-dev] [PATCH] lib/libr

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR

2020-05-05 Thread Zhao1, Wei
HI, Ferruh This is the patch enable FDIR for flow filter, so we can use this. Fixes: 14c66a451ef ("net/i40e: parse flow director filter ") Cc: sta...@dpdk.org > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 30, 2020 6:19 PM > To: Zhao1, Wei ; dev@dpdk.org >

Re: [dpdk-dev] [PATCH] kni: fix kernel deadlock when using mlx devices

2020-05-05 Thread Stephen Hemminger
On Wed, 18 Mar 2020 16:17:57 +0100 Thomas Monjalon wrote: > 17/01/2020 17:43, Ferruh Yigit: > > On 12/22/2019 5:55 PM, Stephen Hemminger wrote: > > > This fixes a deadlock when using KNI with bifurcated drivers. > > > Bringing kni device up always times out when using Mellanox > > > devices. >

Re: [dpdk-dev] DPDK techboard minutes for Apr 22nd 2020

2020-05-05 Thread Honnappa Nagarahalli
> -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Thursday, April 23, 2020 2:46 PM > To: dev@dpdk.org > Cc: techbo...@dpdk.org; nd ; nd > Subject: [dpdk-dev] DPDK techboard minutes for Apr 22nd 2020 > > Meeting notes for the DPDK technical board meeting held o

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-05 Thread Dmitry Kozlyuk
On 2020-05-05 17:24 GMT+0100 Burakov, Anatoly wrote: > On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: > Lots of duplication... I wonder if it would be possible to share at > least some of this code in common. Tracking down bugs because of > duplicated code desync is always a pain... This was the m

[dpdk-dev] [PATCH 0/2] fix coverity reported issues

2020-05-05 Thread Ajit Khaparde
Fix issues reported by Coverity. Note that one issue was reported in internal coverity scan. Ajit Khaparde (1): net/bnxt: fix uninitialized variable error Kishore Padmanabha (1): net/bnxt: fix overrun of the ulp device params array drivers/net/bnxt/tf_core/tf_tbl.c | 2 +- drivers/n

[dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array

2020-05-05 Thread Ajit Khaparde
From: Kishore Padmanabha Fix a buffer overrun issue spotted by coverity while accessing the array ulp_device_params. Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init") Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bn

[dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error

2020-05-05 Thread Ajit Khaparde
Fix uninitialized variable error reported by coverity. Fixes: d33b68154fa4 ("net/bnxt: add tf_core table scope support") Coverity issue: 357771 Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Randy Schacher --- drivers/net/bnxt/tf_core/tf_tbl.c | 2 +- 1 file changed, 1 i

Re: [dpdk-dev] [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

2020-05-05 Thread Honnappa Nagarahalli
Adding Yipeng, maintainer for hash library > > Thanks for your reply. > > Using rte_hash iterate and delete keys is to free the related data's memory. > There are two reasons why rte_hash_reset() is not properly: > 1) the reset function just clear all keys, the key's related data are leaked.

Re: [dpdk-dev] [PATCH v5 00/29] graph: introduce graph subsystem

2020-05-05 Thread Thomas Monjalon
11/04/2020 16:13, jer...@marvell.com: > From: Jerin Jacob > > Using graph traversal for packet processing is a proven architecture > that has been implemented in various open source libraries. > > Graph architecture for packet processing enables abstracting the data > processing functions as “no

[dpdk-dev] [PATCH 2/2] crypto/dpaa_sec: repair memory allocations

2020-05-05 Thread Lukasz Wojciechowski
This patch repairs 2 memory allocations issues: 1) possible leak of memory In cryptodev_dpaa_sec_probe() function in case of portal initialization failure, function exited without cleanup. The patch redirects flow to out label, which provides proper cleanup in case of error: freei

[dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: improve memory freeing

2020-05-05 Thread Lukasz Wojciechowski
This patch fixes management of memory for authentication and encryption keys. There were two issues with former state of implementation: 1) Invalid access to dpaa_sec_session union members The dpaa_sec_session structure includes an anonymous union: union { struct {...} aead_key;

[dpdk-dev] [PATCH v4 6/6] service: relax barriers with C11 atomics

2020-05-05 Thread Honnappa Nagarahalli
From: Phil Yang The runstate, comp_runstate and app_runstate are used as guard variables in the service core lib. To guarantee the inter-threads visibility of these guard variables, it uses rte_smp_r/wmb. This patch use c11 atomic built-ins to relax these barriers. Signed-off-by: Phil Yang Revi

[dpdk-dev] [PATCH v4 0/6] use c11 atomics for service core lib

2020-05-05 Thread Honnappa Nagarahalli
The rte_atomic ops and rte_smp barriers enforce DMB barriers on aarch64. Using c11 atomics with explicit memory ordering instead of the rte_atomic ops and rte_smp barriers for inter-threads synchronization can uplift the performance on aarch64 and no performance loss on x86. This patchset contains

[dpdk-dev] [PATCH v4 4/6] service: remove redundant code

2020-05-05 Thread Honnappa Nagarahalli
From: Phil Yang The service id validation is duplicated, remove the redundant code in the calling functions. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Acked-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 28 ++-- 1 file changed, 6 inse

[dpdk-dev] [PATCH v4 5/6] service: optimize with c11 atomics

2020-05-05 Thread Honnappa Nagarahalli
From: Phil Yang The num_mapped_cores is used as a statistics. Use c11 atomics with RELAXED ordering for num_mapped_cores instead of rte_atomic ops which enforce unnessary barriers on aarch64. Replace execute_lock operations to spinlock_try_lock to avoid duplicate code. Signed-off-by: Phil Yang

[dpdk-dev] [PATCH v4 3/6] service: remove rte prefix from static functions

2020-05-05 Thread Honnappa Nagarahalli
From: Phil Yang clean up rte prefix from static functions. remove unused parameter for service_dump_one function. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Acked-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 34 ++--- 1 file changed,

[dpdk-dev] [PATCH v4 1/6] service: fix race condition for MT unsafe service

2020-05-05 Thread Honnappa Nagarahalli
The MT unsafe service might get configured to run on another core while the service is running currently. This might result in the MT unsafe service running on multiple cores simultaneously. Use 'execute_lock' always when the service is MT unsafe. If the service is known to be mmapped on a single

[dpdk-dev] [PATCH v4 2/6] service: fix identification of service running on other lcore

2020-05-05 Thread Honnappa Nagarahalli
The logic to identify if the MT unsafe service is running on another core can return -EBUSY spuriously. In such cases, running the service becomes costlier than using atomic operations. Assume that the application passes the right parameters and reduce the number of instructions for all cases. Cc:

Re: [dpdk-dev] [PATCH] net/bnxt: fix build with gcc10 default fno-common

2020-05-05 Thread Ajit Khaparde
On Tue, May 5, 2020 at 7:56 AM Kevin Traynor wrote: > On 05/05/2020 05:03, Ajit Khaparde wrote: > > From: Randy Schacher > > > > Remove the defensive compile-time checker macro. > > > > Thanks Ajit/Randy. This removes the error for bnxt on my Fedora 32 system. > > Was chatting to David and he su

Re: [dpdk-dev] [PATCH] doc: update bnxt guide

2020-05-05 Thread Ajit Khaparde
On Fri, May 1, 2020 at 3:03 PM Ajit Khaparde wrote: > - Update list of supported adapters. > - Update list of supported features. > - Add some details to describe the features. > - Remove obsolete limitations. > - Fix and update links. > > Signed-off-by: JP Lee > Signed-off-b

Re: [dpdk-dev] [PATCH] net/bnxt: fix build with gcc10 default fno-common

2020-05-05 Thread Ajit Khaparde
On Tue, May 5, 2020 at 7:56 AM Kevin Traynor wrote: > On 05/05/2020 05:03, Ajit Khaparde wrote: > > From: Randy Schacher > > > > Remove the defensive compile-time checker macro. > > > > Thanks Ajit/Randy. This removes the error for bnxt on my Fedora 32 system. > > Was chatting to David and he su

Re: [dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-05 Thread David Christensen
I can't find "rte_altivec.h", am I missing something. With just ignoring "-Warray-bounds" changes, I confirm ena build issue is fixed with gcc 9.1 The rte_altivec.h is related to another open patch required to build on POWER systems (http://patches.dpdk.org/patch/69605/) that's waiting to be ac

Re: [dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-05 Thread David Christensen
The rte_altivec.h is related to another open patch required to build on POWER systems (http://patches.dpdk.org/patch/69605/) that's waiting to be accepted. You may not have encountered it if you're not building the MLX5 PMD which has additional library requirements. Is there a point in havin

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 19:28, Jerin Jacob: > On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > 05/05/2020 19:09, Jerin Jacob: > > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon > > > > wrote: > > > > > 05/05/2020 18:46, Jerin Jacob: > >

[dpdk-dev] [PATCH] net/mlx5: fix debug log segfault on TxQ release

2020-05-05 Thread Alexander Kozyrev
Program received signal SIGSEGV, Segmentation fault. 0x008ef7c4 in mlx5_tx_queue_release (dpdk_txq=0x17ce01680) at drivers/net/mlx5/mlx5_txq.c:302 301 mlx5_txq_release(ETH_DEV(priv), i); 302 DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", 303 PORT_ID(priv), txq->idx); The p

[dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state

2020-05-05 Thread Gaetan Rivet
The service proxy is initialized at 0. This is assuming that all of its fields are invalid at 0. The issue is that a file descriptor at 0 is a valid one. The value -1 is used as sentinel during cleanup. Initialize the RX proxy file descriptor to -1. Fixes: 366226dd859f ("net/failsafe: fix fd leak

[dpdk-dev] [PATCH v1 2/3] net/ring: fix eth_dev device pointer on allocation

2020-05-05 Thread Gaetan Rivet
When a net_ring device is allocated, its device pointer is not set before calling rte_eth_dev_probing_finish, which is incorrect. The following: commit: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") commit: a6992e961050 ("net/ring: set ethernet device field") already attempted t

[dpdk-dev] [PATCH v1 0/3] failsafe & ring fixes

2020-05-05 Thread Gaetan Rivet
Some issues seen on next-net. Gaetan Rivet (3): net/failsafe: avoid crash on malformed eth_dev net/ring: fix eth_dev device pointer on allocation net/failsafe: fix default service proxy state drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 5

[dpdk-dev] [PATCH v1 1/3] net/failsafe: avoid crash on malformed eth_dev

2020-05-05 Thread Gaetan Rivet
Some PMD do not respect the eth_dev API when allocating their rte_eth_dev. As a result, on device add event resulting from rte_eth_dev_probing_finish() call, the eth_dev processed is incomplete. The segfault is a good way to focus the developer on the issue, but does not inspire confidence. Instea

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-05-05 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > > Hi Konstantin, > > > > > > > I like the way the tests are organized and it looks good. > > > > > > > > > > > > > > I am just wondering about the way it is being tested here. The > > > > > > > intent to write the test cases the way they are currently is > > > > > >

Re: [dpdk-dev] [PATCH v4 4/4] ci: add aarch64 -> arm32 cross compiling jobs

2020-05-05 Thread Aaron Conole
Juraj Linkeš writes: > Add two jobs (static and shared libs), both building on aarch64 and > producing 32 bit arm binaries. Do not run tests in these jobs. > > Signed-off-by: Juraj Linkeš > --- > .ci/linux-build.sh | 7 ++- > .travis.yml| 19 +++ > 2 files changed,

Re: [dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-05 Thread Ferruh Yigit
On 5/5/2020 5:32 PM, David Christensen wrote: > > >>> diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h >>> b/lib/librte_eal/ppc/include/rte_memcpy.h >>> index 25311ba1d..de47a5d2e 100644 >>> --- a/lib/librte_eal/ppc/include/rte_memcpy.h >>> +++ b/lib/librte_eal/ppc/include/rte_memcpy.h >>> @

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix fd leak

2020-05-05 Thread Gaëtan Rivet
On 05/05/20 09:14 +, Ali Alnubani wrote: > > -Original Message- > > From: Gaëtan Rivet > > Sent: Monday, May 4, 2020 7:22 PM > > To: Ali Alnubani > > Cc: Ferruh Yigit ; wangyunjian > > ; dev@dpdk.org; jerry.lili...@huawei.com; > > xudin...@huawei.com; sta...@dpdk.org; Raslan Darawsheh

Re: [dpdk-dev] [PATCH 0/7] net/netvsc: more minor fixes

2020-05-05 Thread Ferruh Yigit
On 4/30/2020 8:08 PM, Stephen Hemminger wrote: > These are fixes for several small issues found during review > and my testing of netvsc PMD. > > Stephen Hemminger (7): > net/netvsc: fix comment spelling errors > bus/vmbus: fix comment spelling errors > net/vmbus: add missing barrier > net

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-05-05 Thread Honnappa Nagarahalli
> > > > > > > > > > > Hi Konstantin, > > > > > > I like the way the tests are organized and it looks good. > > > > > > > > > > > > I am just wondering about the way it is being tested here. The > > > > > > intent to write the test cases the way they are currently is > > > > > > to mimic how t

[dpdk-dev] [PATCH v1] doc: fix references to bind_default_symbol

2020-05-05 Thread Ray Kinsella
The document abi_versioning.rst incorrectly instructs the developer to add BIND_DEFAULT_SYMBOL to the public header, not the source file. This commit fixes the issue and adds some clarifications. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_versioning.rst | 45 +---

Re: [dpdk-dev] [PATCH 1/2] librte_ethdev: Introduce a function to release HW rings

2020-05-05 Thread Lukasz Wojciechowski
W dniu 05.05.2020 o 19:25, Renata Saiakhova pisze: Hi Lukasz, thanks for your comments! I understand Anatoly is going to to make a fix rather in memzone API level, to introduce atomic "find and allocate" and "find and free" operations, so this patch code won't stay long and in this case may

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > 05/05/2020 19:09, Jerin Jacob: > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon > > > wrote: > > > > 05/05/2020 18:46, Jerin Jacob: > > > > > On Tue, May 5, 2020 at 9:58 PM Dav

Re: [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error

2020-05-05 Thread De Lara Guarch, Pablo
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Tuesday, May 5, 2020 1:55 PM > To: dev@dpdk.org; De Lara Guarch, Pablo > Cc: david.march...@redhat.com; Kevin Traynor > Subject: [PATCH] crypto/kasumi: fix gcc 10 fno-common error > > gcc 10 defaults to fno-common and it repo

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 19:09, Jerin Jacob: > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > > 05/05/2020 18:46, Jerin Jacob: > > > > On Tue, May 5, 2020 at 9:58 PM David Marchand > > > > wrote: > > > > > On Tue, May 5, 2020 at 5:25 PM Jerin

[dpdk-dev] [PATCH] doc: remove empty feature list

2020-05-05 Thread Ferruh Yigit
To increase the feature table readability, removing empty column, the file can be added back when the content is available. Signed-off-by: Ferruh Yigit --- MAINTAINERS | 1 - doc/guides/nics/features/afpacket.ini | 6 -- 2 files changed, 7 deletions(-) delete mode

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > > > 05/05/2020 18:46, Jerin Jacob: > > > On Tue, May 5, 2020 at 9:58 PM David Marchand > > > wrote: > > > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob > > > > wrote: > > > > > On

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > 05/05/2020 18:46, Jerin Jacob: > > On Tue, May 5, 2020 at 9:58 PM David Marchand > > wrote: > > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob > > > > wrote: > > > > > On Tue, Ma

Re: [dpdk-dev] [PATCH 1/7] common/dpaax: move internal symbols into INTERNAL section

2020-05-05 Thread David Marchand
Cc: Ray. On Tue, May 5, 2020 at 4:10 PM Hemant Agrawal wrote: > > This patch moves the internal symbols to INTERNAL sections > so that any change in them is not reported as ABI breakage. Talking about the series (not just this patch as I did not look at the details), travis reported a build issu

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 18:46, Jerin Jacob: > On Tue, May 5, 2020 at 9:58 PM David Marchand > wrote: > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand > > > > wrote: > > > > > On Tue, May 5, 2

Re: [dpdk-dev] [PATCH v2] doc: refine ethernet and VLAN flow rule items

2020-05-05 Thread Ferruh Yigit
On 5/3/2020 8:17 AM, Dekel Peled wrote: > Specified pattern may be translated in different manner. > For example the pattern "eth / ipv4" can be translated to match > untagged packets only, since the pattern doesn't specify a VLAN item. > It can also be translated to match both tagged and untagged

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 9:58 PM David Marchand wrote: > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand > > > wrote: > > > > > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jaco

Re: [dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 6:32 PM David Christensen wrote: > >> diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h > >> b/lib/librte_eal/ppc/include/rte_memcpy.h > >> index 25311ba1d..de47a5d2e 100644 > >> --- a/lib/librte_eal/ppc/include/rte_memcpy.h > >> +++ b/lib/librte_eal/ppc/include/rte_mem

Re: [dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-05 Thread David Christensen
diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h b/lib/librte_eal/ppc/include/rte_memcpy.h index 25311ba1d..de47a5d2e 100644 --- a/lib/librte_eal/ppc/include/rte_memcpy.h +++ b/lib/librte_eal/ppc/include/rte_memcpy.h @@ -8,8 +8,8 @@ #include #include -/*To include altivec.h, GCC

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand > > wrote: > > > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > > > > Please share the data. > > > > > > > > > > Measure

Re: [dpdk-dev] [PATCH 2/2] vfio: modify spapr iommu support to use static window sizing

2020-05-05 Thread David Christensen
That's not even mentioning the fact that the user may register external memory for DMA which may cause the window to be of insufficient size to cover said external memory. Regarding external memory, I can think of two obvious options: 1) Skip window sizing altogether if external memory is dete

Re: [dpdk-dev] [PATCH] mem: check DMA mask for user-supplied IOVA addresses

2020-05-05 Thread Burakov, Anatoly
On 05-May-20 4:48 PM, Anatoly Burakov wrote: Currently, external memory API will silently succeed if the IOVA addresses supplied by the user do not fit into the DMA mask. This can cause difficult to debug issues or accepting failed kernel VFIO DMA mappings. Fix it so that if the IOVA addresses a

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-05 Thread Burakov, Anatoly
On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at s

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > > > > > > Removing this special case could break x86 applications running with > > > legacy virtio. > > > > > > > > > On the plus side, we have been announcing for some time in virtio: > > > RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_

Re: [dpdk-dev] [PATCH v4 4/8] eal: extract common code for memseg list initialization

2020-05-05 Thread Burakov, Anatoly
On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- Would it be possible to extract all sim

Re: [dpdk-dev] [PATCH v2] raw/ioat: add ICX support

2020-05-05 Thread Bruce Richardson
On Wed, Apr 29, 2020 at 01:29:30PM +0100, Radu Nicolau wrote: > Add support for Ice Lake IOAT DMA engine PCI Device ID. > > Signed-off-by: Radu Nicolau > --- > v2: squash commits, add description. > > drivers/raw/ioat/ioat_rawdev.c | 2 ++ > usertools/dpdk-devbind.py | 4 +++- > 2 files ch

Re: [dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-05-05 Thread Ferruh Yigit
On 4/30/2020 2:07 PM, Xiaoyu Min wrote: > One new cmdline option `--rx-mq-mode` is added in order to have the > possibility to check whether PMD handle the mq mode correctly or not. > > The reason is some NICs need to do different settings based on different > RX mq mode, i.e RSS or not. > > With

[dpdk-dev] [PATCH v2 3/4] vdpa/mlx5: support virtio queue statistics get

2020-05-05 Thread Matan Azrad
Add support for statistics operations. A DevX counter object is allocated per virtq in order to manage the virtq statistics. The counter object is allocated before the virtq creation and destroyed after it, so the statistics are valid only in the life time of the virtq. Signed-off-by: Matan Azra

[dpdk-dev] [PATCH v2 4/4] examples/vdpa: add statistics show command

2020-05-05 Thread Matan Azrad
A new vDPA driver feature was added to query the virtq statistics from the HW. Use this feature to show the HW queues statistics for the virtqs. Command description: stats X Y. X is the device ID. Y is the queue ID, Y=0x to show all the virtio queues statistics of the device X. Signed-off-by

[dpdk-dev] [PATCH v2 0/4] vhost: support vDPA virtio queue statistics

2020-05-05 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this patch introduce new APIs to get traffic statistics and to reset them per virtio queue. Since there is no any formal statistics suggested by the virtio specs, th

[dpdk-dev] [PATCH v2 2/4] common/mlx5: support DevX virtq stats operations

2020-05-05 Thread Matan Azrad
Add DevX API to create and query virtio queue statistics from the HW. The next counters are supported by the HW per virtio queue: received_desc. completed_desc. error_cqes. bad_desc_errors. exceed_max_chain. invalid_buffer. Signed-off-by: Matan Azrad

[dpdk-dev] [PATCH v2 1/4] vhost: inroduce operation to get vDPA queue stats

2020-05-05 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this patch introduces new 3 APIs to get traffic statistics, the device statistics name and to reset the statistics per virtio queue. The statistics are taken directly

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread Jerin Jacob
On Tue, Apr 28, 2020 at 3:04 PM Jerin Jacob wrote: > > On Tue, Apr 28, 2020 at 2:21 PM David Marchand > wrote: > > > > On Sun, Apr 26, 2020 at 10:06 PM Thomas Monjalon > > wrote: > > > > > > 26/04/2020 20:41, Jerin Jacob: > > > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > > > wrote:

[dpdk-dev] [PATCH] mem: check DMA mask for user-supplied IOVA addresses

2020-05-05 Thread Anatoly Burakov
Currently, external memory API will silently succeed if the IOVA addresses supplied by the user do not fit into the DMA mask. This can cause difficult to debug issues or accepting failed kernel VFIO DMA mappings. Fix it so that if the IOVA addresses are provided, they are checked to see if they fi

Re: [dpdk-dev] [PATCH 1/2] librte_ethdev: Introduce a function to release HW rings

2020-05-05 Thread Lukasz Wojciechowski
Hi Renata, few minor hints inline W dniu 03.05.2020 o 18:26, Renata Saiakhova pisze: > Free previously allocated memzone for HW rings > > Signed-off-by: Renata Saiakhova > --- > lib/librte_ethdev/rte_ethdev.c | 23 +++ > lib/librte_ethdev/rte_ethdev_driver.h|

  1   2   3   >