[dpdk-dev] [PATCH] net/ice: fix incorrect EEPROM data

2020-05-08 Thread Shougang Wang
Kernel driver reads EEPROM data from flash but DPDK reads from shadow ram. This patch fixes the issue by changing method to get EEPROM data from flash. Fixes: 68a1ab82ad74 ("net/ice: speed up to retrieve EEPROM") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ice/base/ice_nvm.

Re: [dpdk-dev] [PATCH] net/ice: fix incorrect EEPROM data

2020-05-08 Thread Yang, Qiming
Hi, Shougang We can't change share code except formal share code update. I'll Nack it. Qiming > -Original Message- > From: Wang, ShougangX > Sent: Friday, May 8, 2020 15:14 > To: dev@dpdk.org > Cc: Yang, Qiming ; Wang, ShougangX > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix incorre

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

2020-05-08 Thread Ananyev, Konstantin
> > +#if (STATS_INTERVAL > 0) > + > +/* Print out statistics on packet distribution */ > +static void > +print_stats(void) > +{ > + uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; > + unsigned int coreid; > + float burst_percent; > + > + total_packets_dropped

Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support for VF MAC address add and remove

2020-05-08 Thread Sun, GuinanX
Hi zhaowei > -Original Message- > From: Zhao1, Wei > Sent: Friday, May 8, 2020 2:58 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Sun, GuinanX ; Guo, Jia > > Subject: RE: [dpdk-dev] [PATCH v3] net/ixgbe: add support for VF MAC address > add and remove > > Hi,

Re: [dpdk-dev] [PATCH v2] net/igc: fix memory illegal accesses

2020-05-08 Thread Ye Xiaolong
On 05/07, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Fix some out-of-bounds memory issues, they may lead to wrong results >or affect application stability. > >Fixes: bd3fcf0d0fa1 (net/igc: support RSS) >Cc: sta...@dpdk.org Please append the coverity number, you can refer to other fixes i

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports

2020-05-08 Thread Ye Xiaolong
On 05/08, Phil Yang wrote: >> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber >> ports >> >> With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it >> is possible when a port is started to experience a timing issue >> which prevents the link from ever being

[dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode

2020-05-08 Thread Guinan Sun
The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. The patch fixes the issue. Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- drivers/n

Re: [dpdk-dev] [PATCH] example/vhost_blk: fix buffer not null terminated

2020-05-08 Thread Ye Xiaolong
On 05/08, Jin Yu wrote: >Fix the potential bug. Could you describe more about the potential bug? Fixes tag is needed here. Thanks, Xiaolong > >Signed-off-by: Jin Yu >--- > examples/vhost_blk/vhost_blk.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/examples/vhost_b

Re: [dpdk-dev] [PATCH 0/9] test/crypto: code cleanup

2020-05-08 Thread Ruifeng Wang
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 5, 2020 5:58 AM > To: dev@dpdk.org > Cc: Ruifeng Wang ; declan.dohe...@intel.com; > asoma...@amd.com; ano...@marvell.com; roy.fan.zh...@intel.com; > fiona.tr...@intel.com; t...@semihalf.com; rnagadhee...@marvell.com; > adwiv..

[dpdk-dev] [PATCH v2] doc: remove Intel PMD examples in flow bifurcation guide

2020-05-08 Thread Xiaolong Ye
Now this feature is no longer supported by kernel side, (i40e kernel driver doesn't support it from v2.3.2 and ixgbe kernel driver isn't guaranteed to support this feature as well in the future), so remove the Intel PMD examples to avoid confusion. Signed-off-by: Xiaolong Ye --- doc/guides/howto

[dpdk-dev] [PATCH v3] net/igc: fix memory illegal accesses

2020-05-08 Thread alvinx . zhang
From: Alvin Zhang Fix some out-of-bounds memory issues, they may lead to wrong results or affect application stability. Coverity issue: 357759, 357713 Fixes: bd3fcf0d0fa1 (net/igc: support RSS) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- V2: update git log V3: update git log drivers/

[dpdk-dev] [PATCH] net/iavf: fix rte flow error log issue

2020-05-08 Thread Jeff Guo
When processing a rte flow, such as creating a parse engine, or creating or destroying a rss rule, if they are failed, they all need to construct the flow error structure before return the error message back to app. If not so, it will cause app crash when app printing the message out of a flow erro

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule completion report value

2020-05-08 Thread Zeng, XiaoxiaoX
Tested-by: Zeng,Xiaoxiao Best regards, Zeng,xiaoxiao > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye, Xiaolong > Sent: Friday, May 8, 2020 10:35 AM > To: Zhang, Qi Z > Cc: Su, Simei ; dev@dpdk.org; Cao, Yahui > > Subject: Re: [dpdk-dev] [PATCH] net/ice

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-08 Thread Zeng, XiaoxiaoX
Tested-by: Zeng,Xiaoxiao Best regards, Zeng,xiaoxiao > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Simei Su > Sent: Friday, May 8, 2020 9:22 AM > To: Zhang, Qi Z ; Ye, Xiaolong > > Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei > > Subject: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-05-08 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > > > > > > > > > > Hi Konstantin, > > > > > > > > > I like the way the tests are organized and it looks > > > > > > > > > good. > > > > > > > > > > > > > > > > > > I am just wondering about the way it is being tested here. > > > > > > > > > The intent to write the

[dpdk-dev] [PATCH v2] net/ixgbe: fix link state timing issue on fiber ports

2020-05-08 Thread Phil Yang
In ixgbe_dev_link_update_share(), if the media type is fiber and the link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback to ixgbe_dev_setup_link_thread_handler() is scheduled which should try to set up the link and clear the flag afterwards. This flag works as a guard variable bet

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports

2020-05-08 Thread Phil Yang
> -Original Message- > From: Ye Xiaolong > Sent: Friday, May 8, 2020 4:36 PM > To: Phil Yang > Cc: dev@dpdk.org; konstantin.anan...@intel.com; wenzhuo...@intel.com; > qi.z.zh...@intel.com; Lijian Zhang ; Gavin Hu > ; Honnappa Nagarahalli > ; nd ; sta...@dpdk.org > Subject: Re: [dpdk-dev]

[dpdk-dev] [RFC] net/mlx5: add reclaim_mem_mode devarg

2020-05-08 Thread Suanming Mou
Currently, when flow destroyed, some memory resources may still be kept as cached to help next time create flow more efficiently. Some system may need the resources to be more flexible with flow create and destroy.  After peak time, with millions of flows destroyed, the system would prefer the

Re: [dpdk-dev] [PATCH v2] net/ring: fix eth_dev device pointer on allocation

2020-05-08 Thread Ferruh Yigit
On 5/6/2020 7:09 PM, Gaetan Rivet wrote: > When a net_ring device is allocated, its device pointer is not set > before calling rte_eth_dev_probing_finish, which is incorrect. > > The following: > commit: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") > commit: a6992e961050 ("net/r

[dpdk-dev] [PATCH v3] vhost: fix mbuf allocation failures

2020-05-08 Thread Sivaprasad Tummala
vhost buffer allocation is successful for packets that fit into a linear buffer. If it fails, vhost library is expected to drop the current packet and skip to the next. The patch fixes the error scenario by skipping to next packet. Note: Drop counters are not currently supported. Fixes: c3ff0ac70

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-05-08 Thread Ferruh Yigit
On 1/8/2020 2:07 PM, Thomas Monjalon wrote: > 08/01/2020 14:58, Laurent Hardy: >> About the 'is_supported()' versions of APIs, in the current patch I >> factorize >> the check on dev ops on and off availability in a same function named >> "led_ctrl_capable" but I can rename it if required. >> >> J

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-05-08 Thread Ferruh Yigit
On 1/8/2020 1:58 PM, Laurent Hardy wrote: > > On 1/8/20 2:06 PM, Thomas Monjalon wrote: >> 08/01/2020 13:59, Ferruh Yigit: >>> On 1/8/2020 10:31 AM, Laurent Hardy wrote: Hi all, On 1/8/20 10:55 AM, David Marchand wrote: > On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit > wrot

Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

2020-05-08 Thread Ananyev, Konstantin
> From: Pavan Nikhilesh > > Merge crc32 hash calculation public API headers for x86 and ARM, > split implementations of x86 and ARM into their respective private > headers. > This reduces the ifdef code clutter while keeping current ABI intact. > > Although we install `rte_crc_arm64.h` it is n

Re: [dpdk-dev] rte_ring work

2020-05-08 Thread Ananyev, Konstantin
> > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > 1) Remove the detailed comments on top of the internal functions - > > > > > it is hard to maintain, the parameters are already > > > > > self-explanatory > > > > > 3) Files need some re-org > > > > >

[dpdk-dev] [PATCH v5 1/9] net/dpaa2: fix 10G port negotiation issue

2020-05-08 Thread Hemant Agrawal
From: Rohit Raj Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface on LS2088ARDB, the ports were showing link as down. This was identified to be caused by the setting of link as down during config. Also, the line rate wa

[dpdk-dev] [PATCH v5 0/9] NXP DPAAx fixes and enhancements

2020-05-08 Thread Hemant Agrawal
v5: split the default param patch and enhance commit details v4: address the review comments v3: Limiting the patches to avoid ABI breakage. Hemant Agrawal (4): net/dpaa2: add default values for Rx params in info net/dpaa2: reduce prints in queue count functions bus/fslmc: fix the size of qm

[dpdk-dev] [PATCH v5 2/9] net/dpaa2: do not prefetch annotaion for physical mode

2020-05-08 Thread Hemant Agrawal
From: Nipun Gupta When IOVA is physical address do not prefetch the annotation of the next frame, as there is a cost involved there to convert the physical address to virtual address. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 6 ++-- drivers/net/dpaa2/dpaa2_rxtx

[dpdk-dev] [PATCH v5 6/9] net/dpaa2: reduce prints in queue count functions

2020-05-08 Thread Hemant Agrawal
changing them to DP as it is impacting l3fwd-power apps Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 0be61cda04..08f9832eb8 10064

[dpdk-dev] [PATCH v5 4/9] drivers: dpaa2 enhance portal alloc failure log

2020-05-08 Thread Hemant Agrawal
From: Nipun Gupta Update the portal allocation failure log to print the thread id as well. Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++-- drivers/event/dpaa2/dpaa2_eventdev.c| 8 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool.c| 12 +

[dpdk-dev] [PATCH v5 5/9] net/dpaa2: support UDP dst port based muxing

2020-05-08 Thread Hemant Agrawal
From: Nipun Gupta This change adds DPDMUX support to bifurcate traffic on the basis of UDP destination port. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_mux.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b

[dpdk-dev] [PATCH v5 3/9] net/dpaa2: add default values for Rx params in info

2020-05-08 Thread Hemant Agrawal
This patch adds default/preferred rx/tx params in dev info, specially the advertised burst size. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 4 drivers/net/dpaa/dpaa_ethdev.h | 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 9 + drivers/net/dpaa2/dpaa2_ethdev.h |

[dpdk-dev] [PATCH v5 8/9] bus/fslmc: fix the size of qman fq desc

2020-05-08 Thread Hemant Agrawal
correct the qman_fq_desc as per the HW defined size Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc

[dpdk-dev] [PATCH v5 9/9] net/dpaa2: add the support for additional link speeds

2020-05-08 Thread Hemant Agrawal
This patch adds the support for additional link speed supported by LX2160A platforms. Signed-off-by: Hemant Agrawal --- doc/guides/nics/features/dpaa2.ini | 2 +- drivers/net/dpaa2/dpaa2_ethdev.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/feature

[dpdk-dev] [PATCH v5 7/9] net/dpaa2: fix cong group id for multiple tcs

2020-05-08 Thread Hemant Agrawal
From: Jun Yang When using a single TC, flow id is same as congestion group id. However in case of multiple traffic classes, same flow id values are used within each traffc classs, which causes incorrect traffic behavior e.g. halting of traffic. This patches changes to use the cgid as the index wh

[dpdk-dev] [PATCH v6 02/10] net/dpaa2: fix 10G port negotiation issue

2020-05-08 Thread Hemant Agrawal
From: Rohit Raj Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface on LS2088ARDB, the ports were showing link as down. This was identified to be caused by the setting of link as down during config. Also, the line rate wa

[dpdk-dev] [PATCH v6 03/10] net/dpaa2: do not prefetch annotaion for physical mode

2020-05-08 Thread Hemant Agrawal
From: Nipun Gupta When IOVA is physical address do not prefetch the annotation of the next frame, as there is a cost involved there to convert the physical address to virtual address. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 6 ++-- drivers/net/dpaa2/dpaa2_rxtx

[dpdk-dev] [PATCH v6 04/10] net/dpaa2: add default values for Rx params in info

2020-05-08 Thread Hemant Agrawal
This patch adds default/preferred rx/tx params in dev info, specially the advertised burst size. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 4 drivers/net/dpaa/dpaa_ethdev.h | 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 9 + drivers/net/dpaa2/dpaa2_ethdev.h |

[dpdk-dev] [PATCH v6 00/10] NXP DPAAx fixes and enhancement

2020-05-08 Thread Hemant Agrawal
v6: missed one patch v5: split the default param patch and enhance commit details v4: address the review comments v3: Limiting the patches to avoid ABI breakage. Apeksha Gupta (1): bus/fslmc: fix dereferencing null pointer Hemant Agrawal (4): net/dpaa2: add default values for Rx params in inf

[dpdk-dev] [PATCH v6 01/10] bus/fslmc: fix dereferencing null pointer

2020-05-08 Thread Hemant Agrawal
From: Apeksha Gupta This patch fixees the nxp internal coverity reported null pointer dereferncing issue. Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta --- drivers/bus/fslmc/qbman/qbman_debug.c | 7 --- 1 file changed, 4

[dpdk-dev] [PATCH v6 06/10] net/dpaa2: support UDP dst port based muxing

2020-05-08 Thread Hemant Agrawal
From: Nipun Gupta This change adds DPDMUX support to bifurcate traffic on the basis of UDP destination port. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_mux.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b

[dpdk-dev] [PATCH v6 07/10] net/dpaa2: reduce prints in queue count functions

2020-05-08 Thread Hemant Agrawal
changing them to DP as it is impacting l3fwd-power apps Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 0be61cda04..08f9832eb8 10064

[dpdk-dev] [PATCH v6 05/10] drivers: dpaa2 enhance portal alloc failure log

2020-05-08 Thread Hemant Agrawal
From: Nipun Gupta Update the portal allocation failure log to print the thread id as well. Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++-- drivers/event/dpaa2/dpaa2_eventdev.c| 8 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool.c| 12 +

[dpdk-dev] [PATCH v6 10/10] net/dpaa2: add the support for additional link speeds

2020-05-08 Thread Hemant Agrawal
This patch adds the support for additional link speed supported by LX2160A platforms. Signed-off-by: Hemant Agrawal --- doc/guides/nics/features/dpaa2.ini | 2 +- drivers/net/dpaa2/dpaa2_ethdev.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/feature

[dpdk-dev] [PATCH v6 08/10] net/dpaa2: fix cong group id for multiple tcs

2020-05-08 Thread Hemant Agrawal
From: Jun Yang When using a single TC, flow id is same as congestion group id. However in case of multiple traffic classes, same flow id values are used within each traffc classs, which causes incorrect traffic behavior e.g. halting of traffic. This patches changes to use the cgid as the index wh

[dpdk-dev] [PATCH v6 09/10] bus/fslmc: fix the size of qman fq desc

2020-05-08 Thread Hemant Agrawal
correct the qman_fq_desc as per the HW defined size Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc

Re: [dpdk-dev] [PATCH v6 00/10] NXP DPAAx fixes and enhancement

2020-05-08 Thread Hemant Agrawal (OSS)
Series-Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 3/3] net/ena: fix build for O1 optimization

2020-05-08 Thread Michał Krawczyk
czw., 7 maj 2020 o 14:03 Ferruh Yigit napisał(a): > > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) > > Build error: > .../drivers/net/ena/ena_ethdev.c: In function ‘eth_ena_dev_init’: > .../drivers/net/ena/ena_ethdev.c:1815:20: > e

Re: [dpdk-dev] [PATCH v2] doc: remove Intel PMD examples in flow bifurcation guide

2020-05-08 Thread Stephen Hemminger
On Fri, 8 May 2020 16:48:23 +0800 Xiaolong Ye wrote: > Now this feature is no longer supported by kernel side, (i40e kernel > driver doesn't support it from v2.3.2 and ixgbe kernel driver isn't > guaranteed to support this feature as well in the future), so remove the > Intel PMD examples to avo

Re: [dpdk-dev] [PATCH] common/qat: fix stats update

2020-05-08 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, May 6, 2020 12:30 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH] common/qat: fix stats update > > This patch fixes enqueued and dequeued count statistics that should >

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix null pointer dereferencing issue

2020-05-08 Thread Ferruh Yigit
On 5/8/2020 5:50 AM, Kalesh A P wrote: > From: Kalesh AP > > In cmd_ddp_get_list_parsed(), elements of "p_list" are accessed > even after the memory allocation for "p_list" fails. > > With this patch, this null pointer dereference is avoided as we > return when there is malloc failure. > > Fixe

Re: [dpdk-dev] [PATCH v6 05/10] drivers: dpaa2 enhance portal alloc failure log

2020-05-08 Thread Ferruh Yigit
On 5/8/2020 2:02 PM, Hemant Agrawal wrote: > From: Nipun Gupta > > Update the portal allocation failure log to print the thread id > as well. > > Signed-off-by: Nipun Gupta Off the topic. This is the patch 7 in patchwork! Thanks to everyone contributed! https://patches.dpdk.org/patch/700

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-05-08 Thread Van Haaren, Harry
> -Original Message- > From: Phil Yang > Sent: Thursday, April 30, 2020 3:54 AM > To: Lukasz Wojciechowski ; Van Haaren, > Harry ; Jerin Jacob > > Cc: dev@dpdk.org; sta...@dpdk.org; nd ; nd > Subject: RE: [dpdk-dev] [PATCH] eal: fix lcore state bug > > > -Original Message- > > F

Re: [dpdk-dev] [PATCH 2/3] mempool/octeontx2: fix build for gcc O1 optimization

2020-05-08 Thread Ferruh Yigit
On 5/7/2020 3:05 PM, Ananyev, Konstantin wrote: > Hi Ferruh, Jerin > >> Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using >> gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) >> >> Build error: >> In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, >> from

[dpdk-dev] [PATCH] drivers/crypto: fix gcc 10 fno-common errors

2020-05-08 Thread Kevin Traynor
gcc 10 defaults to -fno-common and as a result when linking with crypto drivers: drivers/librte_pmd_dpaa_sec.a(crypto_dpaa_sec_dpaa_sec.c.o): (.bss+0x4): multiple definition of `rta_sec_era'; drivers/librte_pmd_caam_jr.a(crypto_caam_jr_caam_jr.c.o): (.bss+0x0): first defined here drivers/librte_p

Re: [dpdk-dev] [PATCH 2/3] mempool/octeontx2: fix build for gcc O1 optimization

2020-05-08 Thread Ferruh Yigit
On 5/8/2020 5:20 PM, Ferruh Yigit wrote: > On 5/7/2020 3:05 PM, Ananyev, Konstantin wrote: >> Hi Ferruh, Jerin >> >>> Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using >>> gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) >>> >>> Build error: >>> In file included from .../drivers/mempool/octe

[dpdk-dev] [PATCH v2 1/4] ring: fix build for gcc O1 optimization

2020-05-08 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Two build errors: 1) In file included from .../build/include/rte_ring_elem.h:1093, from .../lib/librte_rcu/rte_rcu_qsbr.c:21: ../lib/librte_rcu/rte_rcu_qsbr.c: In function ‘rt

[dpdk-dev] [PATCH v2 2/4] mempool/octeontx2: fix build for gcc O1 optimization

2020-05-08 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Build error: In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, from .../drivers/mempool/octeontx2/otx2_mempool_ops.c:8: .../drivers/mempool/octeontx2/otx2_

[dpdk-dev] [PATCH v2 3/4] net/ena: fix build for O1 optimization

2020-05-08 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Build error: .../drivers/net/ena/ena_ethdev.c: In function ‘eth_ena_dev_init’: .../drivers/net/ena/ena_ethdev.c:1815:20: error: ‘wd_state’ may be used uninitialized in this function

[dpdk-dev] [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization

2020-05-08 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc 7.3.0 Build error In file included from .../drivers/event/octeontx2/ot x2_evdev.c:15:0: .../drivers/event/octeontx2/otx2_evdev_stats.h: In function ‘otx2_sso_xstats_get’: .../drivers/event/octeontx2/otx2_evdev_stats.h:124:9:

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-05-08 Thread Lukasz Wojciechowski
W dniu 08.05.2020 o 18:12, Van Haaren, Harry pisze: >> -Original Message- >> From: Phil Yang >> Sent: Thursday, April 30, 2020 3:54 AM >> To: Lukasz Wojciechowski ; Van Haaren, >> Harry ; Jerin Jacob >> >> Cc: dev@dpdk.org; sta...@dpdk.org; nd ; nd >> Subject: RE: [dpdk-dev] [PATCH] ea

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU cycles

2020-05-08 Thread Ananyev, Konstantin
> Hi Konstantin, > > > On May 7, 2020, at 4:50 AM, Ananyev, Konstantin > > wrote: > > > > > > > >> -Original Message- > >> From: dev On Behalf Of Dharmik Thakkar > >> Sent: Wednesday, May 6, 2020 10:59 PM > >> To: Lu, Wenzhuo ; Wu, Jingjing > >> ; Iremonger, Bernard > >> Cc: dev@dpdk.

Re: [dpdk-dev] [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization

2020-05-08 Thread Ananyev, Konstantin
> Subject: [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization > > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > gcc 7.3.0 > > Build error > In file included from .../drivers/event/octeontx2/ot > x2_evdev.c:15:0: > .../drivers/event/octeontx2/otx2_evdev_stats.h: >

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU cycles

2020-05-08 Thread Dharmik Thakkar
> On May 8, 2020, at 12:17 PM, Ananyev, Konstantin > wrote: > >> Hi Konstantin, >> >>> On May 7, 2020, at 4:50 AM, Ananyev, Konstantin >>> wrote: >>> >>> >>> -Original Message- From: dev On Behalf Of Dharmik Thakkar Sent: Wednesday, May 6, 2020 10:59 PM To: L

Re: [dpdk-dev] rte_ring work

2020-05-08 Thread Honnappa Nagarahalli
> > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > > > 1) Remove the detailed comments on top of the internal > > > > > > functions - it is hard to maintain, the parameters are already > > > > > > self-explanatory > > > > > > 3) Files need some re-org > > >

Re: [dpdk-dev] rte_ring work

2020-05-08 Thread Ananyev, Konstantin
> > > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > > > > > 1) Remove the detailed comments on top of the internal > > > > > > > functions - it is hard to maintain, the parameters are already > > > > > > > self-explanatory > > > > > > > 3) Files need som

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU cycles

2020-05-08 Thread Ananyev, Konstantin
> -Original Message- > From: Dharmik Thakkar > Sent: Friday, May 8, 2020 6:37 PM > To: Ananyev, Konstantin > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > Iremonger, Bernard ; > dev@dpdk.org; nd > Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU > cycles > > > >

Re: [dpdk-dev] [PATCH v6 00/10] NXP DPAAx fixes and enhancement

2020-05-08 Thread Ferruh Yigit
On 5/8/2020 2:08 PM, Hemant Agrawal (OSS) wrote: > Series-Acked-by: Hemant Agrawal > Series applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v4 0/4] add new kv hash table

2020-05-08 Thread Vladimir Medvedkin
Currently DPDK has a special implementation of a hash table for 4 byte keys which is called FBK hash. Unfortunately its main drawback is that it only supports 2 byte values. The new implementation called KV hash supports 4 byte keys and 8 byte associated values, which is enough to store a pointer.

[dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-05-08 Thread Vladimir Medvedkin
KV hash is a special optimized key-value storage for fixed key and value sizes. At the moment it supports 32 bit keys and 64 bit values. This table is hash function agnostic so user must provide precalculated hash signature for add/delete/lookup operations. Signed-off-by: Vladimir Medvedkin ---

[dpdk-dev] [PATCH v4 3/4] test: add kv hash autotests

2020-05-08 Thread Vladimir Medvedkin
Add autotests for rte_kv_hash library Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 12 +++ app/test/meson.build | 3 + app/test/test_kv_hash.c | 242 ++ 4 files changed, 258 insertions(+

[dpdk-dev] [PATCH v4 4/4] test: add kv perf tests

2020-05-08 Thread Vladimir Medvedkin
Add performance tests for rte_kv_hash Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 111 ++ 1 file changed, 111 insertions(+) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cdac5..3d4c13d 100644 --- a/ap

[dpdk-dev] [PATCH v4 2/4] hash: add documentation for kv hash library

2020-05-08 Thread Vladimir Medvedkin
Add programmers guide and doxygen API for kv hash library Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/kv_hash_lib.rst | 66 +++ 3 files changed, 68 insertio

Re: [dpdk-dev] [PATCH v3 0/4] add new k32v64 hash table

2020-05-08 Thread Medvedkin, Vladimir
Hi Yipeng, Sorry for late reply On 17/04/2020 01:21, Wang, Yipeng1 wrote: -Original Message- From: Mattias Rönnblom Sent: Thursday, April 16, 2020 4:41 AM To: Medvedkin, Vladimir;dev@dpdk.org Cc: Ananyev, Konstantin; Wang, Yipeng1 ; Gobriel, Sameh; Richardson, Bruce Subject: Re: [dpdk-d

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-05-08 Thread Medvedkin, Vladimir
Hi Konstantin, Thanks for review, On 23/04/2020 14:31, Ananyev, Konstantin wrote: Hi Vladimir, Apologies for late review. My comments below. K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. This table is hash function agnostic so user must provide precalculated hash s

Re: [dpdk-dev] [PATCH] drivers/crypto: fix gcc 10 fno-common errors

2020-05-08 Thread Kevin Traynor
https://travis-ci.com/ovsrobot/dpdk/builds/164784623 looks to be travis run issue passing on my travis https://travis-ci.org/github/kevuzaj/dpdk-master/builds/684814829 On 08/05/2020 17:27, Kevin Traynor wrote: > gcc 10 defaults to -fno-common and as a result when linking > with crypto drivers:

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-05-08 Thread Medvedkin, Vladimir
Hi Honnappa, Thanks for the comments. On 29/04/2020 22:29, Honnappa Nagarahalli wrote: Hi Vladimir, I am not sure which way the decision is made, but few comments inline. Please use C11 built-ins for synchronization. -Original Message- From: dev On Behalf Of Vladimir Medvedk

[dpdk-dev] [PATCH v2 4/5] doc: include config options in testpmd user guide

2020-05-08 Thread Dharmik Thakkar
Update testpmd documentation to include RECORD configuration options, CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Phil Yang --- v2: - Remove extra '#'. --- doc/guides/testpmd_a

[dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide

2020-05-08 Thread Dharmik Thakkar
Update documentation for 'show fwd' testpmd runtime function to show CPU cycles/packet example. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Phil Yang --- v2: - Use shorter lines, up to 100. --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 53 +---

[dpdk-dev] [PATCH v2 5/5] doc: add aarch64 generic counter section

2020-05-08 Thread Dharmik Thakkar
Add a separate section for low-resolution generic counter for ARM64 profiling methods. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Acked-by: Jerin Jacob --- v2: - Add Acked-by tag --- doc/guides/prog_guide/profile_app.rst | 11 --- 1 file c

[dpdk-dev] [PATCH v2 1/5] app/testpmd: print clock with CPU cycles per pkt

2020-05-08 Thread Dharmik Thakkar
On aarch64 platforms, the cycles are counted using either a low-resolution generic counter or a high-resolution PMU cycle counter. Print the clock frequency along with CPU cycles/packet to identify which cycle counter is being used. Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli

[dpdk-dev] [PATCH v2 2/5] app/testpmd: print fractional part in CPU cycles

2020-05-08 Thread Dharmik Thakkar
Change printing of CPU cycles/packet to include fractional part for accurateness. Example: Without patch: CPU cycles/packet=14 (total cycles=4899533541 / total RX packets=343031966) With patch: CPU cycles/packet=14.28 (total cycles=4899533541 / total RX packets=343031966) Signed-off-by: Dharmik

[dpdk-dev] [PATCH] eal: remove register from function parameter in headers

2020-05-08 Thread Stephen Hemminger
Compiling a C++ application that includes directly or indirectly rte_common.h will cause a warning: include/rte_common.h:350:37: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister] rte_combine32ms1b(register uint32_t x) C++ pickier than standard C and flags this an

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-05-08 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Konstantin, > > > > > > > > > > I like the way the tests are organized and it looks > good. > > > > > > > > > > > > > > > > > > > > I am just wondering about the way it is being tested here. > > > > > > > > > > The intent to write the

Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode

2020-05-08 Thread Jiang, YuX
Tested-by: Jiang, YuX -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Guinan Sun Sent: Friday, May 8, 2020 4:30 PM To: dev@dpdk.org Cc: Sun, GuinanX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode The register aut

[dpdk-dev] [PATCH v5 0/4] Support ipv6 flow rules

2020-05-08 Thread Xiaoyun wang
This patch adds jumbo frame offload flag, increases judgment whether Tx/Rx queues is non-null when free resources, and if card mode does not support nic, driver will be initialized failed, supports ipv6 flow director for BGP or ICMP packets. -- v4->v5: - increase Tx/Rx queues non-null judgment

[dpdk-dev] [PATCH v5 4/4] net/hinic/base: support ipv6 flow rules

2020-05-08 Thread Xiaoyun wang
The patch supports ipv6 flow rules for BGP or ICMP packets. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 57 +- drivers/net/hinic/hinic_pmd_flow.c | 209 --- 2 files changed, 249 insertions(+), 17 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v5 2/4] net/hinic: add jumbo frame offload flag

2020-05-08 Thread Xiaoyun wang
The patch adds DEV_RX_OFFLOAD_JUMBO_FRAME flag for jumbo when set mtu. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethde

[dpdk-dev] [PATCH v5 1/4] net/hinic: increase Tx/Rx queues non-null judgment

2020-05-08 Thread Xiaoyun wang
Increase tx_queues and rx_queues non-null judgment before free tx or rx resources, and modify some formate for logs. Fixes: 54faba2295bd ("net/hinic: adds Tx queue xstats members") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmdq.h | 2 +- drivers/net/

[dpdk-dev] [PATCH v5 3/4] net/hinic: increase judgment for support NIC or not

2020-05-08 Thread Xiaoyun wang
If hardware mode for this card does not support nic, the network features for this card will not be supported and driver will be initialized failed. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cfg.c | 3 ++- drivers/net/hinic/hinic_pmd_ethdev.c | 6 +- 2 files changed,

Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

2020-05-08 Thread Zhang, Qi Z
> -Original Message- > From: Lu, Nannan > Sent: Thursday, May 7, 2020 9:52 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error > > Tested-by: Lu, Nannan > > -Original Message- > From: Zhao1, Wei > Sent:

Re: [dpdk-dev] [PATCH] net/iavf: fix input set for rss hash

2020-05-08 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Friday, May 8, 2020 5:30 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: Iremonger, Bernard ; Ye, Xiaolong > ; Zhang, Qi Z ; > dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/iavf: fix input set for rss hash > > Since some specific rss hash type

Re: [dpdk-dev] [PATCH] net/iavf: fix rte flow error log issue

2020-05-08 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Saturday, May 9, 2020 4:59 AM > To: Xing, Beilei ; Ye, Xiaolong > ; Yang, Qiming ; Wu, > Jingjing > Cc: Zhang, Qi Z ; dev@dpdk.org; Lu, Wenzhuo > ; Guo, Jia > Subject: [PATCH] net/iavf: fix rte flow error log issue > > When processing a r

Re: [dpdk-dev] [PATCH] net/iavf: fix input set for rss hash

2020-05-08 Thread Guo, Jia
ok. Best regards, Jeff Guo -Original Message- From: Zhang, Qi Z Sent: Saturday, May 9, 2020 2:21 PM To: Guo, Jia ; Xing, Beilei ; Wu, Jingjing Cc: Iremonger, Bernard ; Ye, Xiaolong ; dev@dpdk.org Subject: RE: [PATCH] net/iavf: fix input set for rss hash > -Original Message