25/05/2020 07:29, Sieduszewski, Piotr:
> Hi
>
> I send answer yesterday, but now I put more examples from my scripts at work:
Please send a patch v2 with more explanations in sentences.
It would be appreciated if you use --in-reply-to.
PS: please do not top-post, do not use HTML, and do not mark
25/05/2020 03:46, wangyunjian:
> From: Yunjian Wang
>
> This patch fixes the Huawei internal coverity reported
> resource leak issue.
The problem is not seen in the community Coverity?
> Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
> Cc: sta...@dpdk.org
>
> Signed
Tested-by: Zhiwei.He
-Original Message-
From: dev On Behalf Of Jeff Guo
Sent: Sunday, May 24, 2020 1:53 PM
To: Xing, Beilei ; Zhang, Qi Z ;
Wu, Jingjing
Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
Subject: [dpdk-dev] [dpdk-dev v2] net/iavf: fix protocol field selector
configure
When
On Mon, May 25, 2020 at 6:08 AM Dmitry Kozlyuk wrote:
>
> It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows,
> sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs.
> Tracepoints using "long" field emitter are therefore invalid there.
> Add dedicated field emitter for s
From: Jerin Jacob
The legacy virtio feature is not architecture agnostics.
It relies on x86 IO port scheme support for its working.
The legacy virtio is only the consumer of RTE_KDRV_NONE in DPDK PCI
subsystem. Legacy virtio removal will also optimize DPDK PCI enumeration
management as it does n
On Mon, May 25, 2020 at 5:14 AM Thomas Monjalon wrote:
>
> 23/05/2020 16:07, jer...@marvell.com:
> > From: Jerin Jacob
> >
> > The legacy virtio is not architecture agnostics.
> > It relies on x86 IO port scheme support for its working.
> > The legacy virtio is only the consumer of RTE_KDRV_NONE
DPDK-20.05 RC3 quick report
* Totally create ~400+ new test cases for DPDK20.05 new features.
* Totally 10203 cases, execution percentage is 100%, pass rate is about
99%, 8 new issues are found, including a high level issue(has been fixed and
verified).
* Checked build and compile, f
On 05/24, Zhang, Qi Z wrote:
>
>
>> -Original Message-
>> From: Guo, Jia
>> Sent: Sunday, May 24, 2020 1:53 PM
>> To: Xing, Beilei ; Zhang, Qi Z ;
>> Wu, Jingjing
>> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
>>
>> Subject: [dpdk-dev v2] net/iavf: fix protocol field selector configure
>>
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, May 25, 2020 7:11 AM
> To: Phil Yang
> Cc: dev@dpdk.org; bruce.richard...@intel.com; ferruh.yi...@intel.com;
> hemant.agra...@nxp.com; Honnappa Nagarahalli
> ; jer...@marvell.com;
> ktray...@redhat.com; konstantin.anan...@intel.
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, May 25, 2020 5:21 AM
> To: Phil Yang
> Cc: dev@dpdk.org; david.march...@redhat.com; jer...@marvell.com;
> Honnappa Nagarahalli ; Gavin Hu
> ; Joyce Kong ; nd
> ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add aar
Thanks, Beilei and Ferruh.
Regards,
Zhaoyan Chen
> -Original Message-
> From: Xing, Beilei
> Sent: Monday, May 25, 2020 10:04 AM
> To: Yigit, Ferruh ; Chen, Zhaoyan
> ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1]doc:Update i40e PMD firmware/driver
> mapping table.
>
>
>
> > --
> -Original Message-
> From: Yigit, Ferruh
> Sent: Friday, May 22, 2020 11:31 PM
> To: Xing, Beilei ; Chen, Zhaoyan
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1]doc:Update i40e PMD firmware/driver
> mapping table.
>
> On 5/22/2020 3:20 AM, Xing, Beilei wrote:
> >
> >
> >> -O
On 05/21, Wei Zhao wrote:
>The action number for switch filter should be 1, any
>other such as 0 or more than 1 is invalid.
>
>Fixes: 3428c6b6ec1f ("net/ice: add action number check for switch")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Wei Zhao
>---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 f
> -Original Message-
> From: Zhao1, Wei
> Sent: Thursday, May 21, 2020 3:34 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhang, Qi Z ; Ye, Xiaolong
> ; Zhao1, Wei
> Subject: [PATCH] net/ice: fix switch action number check
>
> The action number for switch filter should be 1, any other
From: Yunjian Wang
This patch fixes the Huawei internal coverity reported
resource leak issue.
Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v2:
* Update commit log
---
app/test-pmd/cmdline_mtr.c | 1 +
1 file ch
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, May 25, 2020 12:08 AM
> To: wangyunjian
> Cc: dev@dpdk.org; Lilijun (Jerry) ; xudingke
> ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] test-pmd: fix memory leaks when mtr policer
> actions updat
On Wed, 20 May 2020 17:32:53 -0700
Tasnim Bashar wrote:
> Add rte_sys_gettid function to use rte_gettid() on Windows.
> rte_gettid() is required for recursive spin lock and recursive ticket lock.
>
> Signed-off-by: Tasnim Bashar
> ---
>
> v2: remove eal_thread_self function and fix style
>
>
On Sat, 23 May 2020 00:25:56 -0700
Tasnim Bashar wrote:
> Casting thread ID to handle is not accurate way to get thread handle.
> Need to use OpenThread function to get thread handle from thread ID.
>
> pthread_setaffinity_np and pthread_getaffinity_np functions
> for Windows are affected becaus
1. Map CPU cores to their respective NUMA nodes as reported by system.
2. Support systems with more than 64 cores (multiple processor groups).
3. Fix magic constants, styling issues, and compiler warnings.
4. Add EAL private function to map DPDK socket ID to NUMA node number.
Fixes: 53ffd9f080fc (
Add hugepages discovery ("large pages" in Windows terminology)
and update documentation for required privilege setup. Only 2MB
hugepages are supported and their number is estimated roughly
due to the lack or unstable status of suitable OS APIs.
Signed-off-by: Dmitry Kozlyuk
---
config/meson.buil
EAL common code depends on tracepoint calls, but generic implementation
cannot be enabled on Windows due to missing standard library facilities.
Add stub functions to support tracepoint compilation, so that common
code does not have to conditionally include tracepoints until proper
support is added
Basic memory management supports core libraries and PMDs operating in
IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain
IOVAs of hugepages allocated from user-mode. Multi-process mode is not
implemented and is forcefully disabled at startup.
Signed-off-by: Dmitry Kozlyuk
---
co
Code in Linux EAL that supports dynamic memory allocation (as opposed to
static allocation used by FreeBSD) is not OS-dependent and can be reused
by Windows EAL. Move such code to a file compiled only for the OS that
require it.
Signed-off-by: Dmitry Kozlyuk
---
lib/librte_eal/common/eal_common_
Limited version imported previously lacks at least SLIST macros.
Import a complete file from FreeBSD, since its license exception is
already approved by Technical Board.
Signed-off-by: Dmitry Kozlyuk
---
lib/librte_eal/windows/include/sys/queue.h | 663 +++--
1 file changed, 601
All supported OS create memory segment lists (MSL) and reserve VA space
for them in a nearly identical way. Move common code into EAL private
functions to reduce duplication.
Signed-off-by: Dmitry Kozlyuk
---
lib/librte_eal/common/eal_common_memory.c | 92 +
lib/librte_eal/commo
Introduce OS-independent wrappers for memory management operations used
across DPDK and specifically in common code of EAL:
* rte_mem_map()
* rte_mem_unmap()
* rte_get_page_size()
* rte_mem_lock()
Windows uses different APIs for memory mapping and reservation, while
Unices reserve memory by mappi
It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows,
sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs.
Tracepoints using "long" field emitter are therefore invalid there.
Add dedicated field emitter for size_t and use it to store size_t values
in all existing tracepoin
EAL common code uses file locking and truncation. Introduce
OS-independent wrappers in order to support both Linux/FreeBSD
and Windows:
* eal_file_lock: lock or unlock an open file.
* eal_file_truncate: enforce a given size for an open file.
Wrappers follow POSIX semantics, but interface is not P
Clang on Windows follows MS ABI where enum values are limited to 2^31-1.
Enum rte_page_sizes has members valued above this limit, which get
wrapped to zero, resulting in compilation error (duplicate values in
enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs.
Remove rte_page_size
Note: cover letter updated for v5.
This patchset implements basic MM with the following features:
* Hugepages are dynamically allocated in user-mode.
* Only 2MB hugepages are supported.
* IOVA is always PA, obtained through kernel-mode driver.
* No 32-bit support (presumably not demanded).
* Ni m
A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v20.05-rc4
There are 44 new patches in this snapshot.
Release notes:
http://doc.dpdk.org/guides/rel_notes/release_20_05.html
Some deprecation notices might be added if reviewed on time.
This is t
> > As agreed in the DPDK tech board [1], after 20.05 release, patches must
> > use C11 atomic operations semantics with the help of wrappers.
> >
> > [1] http://mails.dpdk.org/archives/dev/2020-April/165143.html
> >
> > Signed-off-by: Honnappa Nagarahalli
> > Reviewed-by: Phil Yang
> > Reviewe
23/05/2020 16:07, jer...@marvell.com:
> From: Jerin Jacob
>
> The legacy virtio is not architecture agnostics.
> It relies on x86 IO port scheme support for its working.
> The legacy virtio is only the consumer of RTE_KDRV_NONE in the DPDK
> PCI subsystem. Legacy virtio deprecation will also opti
10/08/2019 23:31, Thomas Monjalon:
> 06/08/2019 20:17, Andrew Rybchenko:
> > On 8/6/19 5:56 PM, Matan Azrad wrote:
> > > The API breakage is because the ``tso_segsz`` field was documented for
> > > LRO.
> > >
> > > The ``tso_segsz`` field in mbuf indicates the size of each segment in
> > > the LRO
> > > From: Nithin Dabilpuram
> > >
> > > Based on the discussion in mail thread, it is concluded that
> > > all traffic manager API's (rte_tm.h) need to be marked experimental
> > > till few more releases to support further improvements to spec.
> > >
> > > https://mails.dpdk.org/archives/dev/202
28/02/2020 11:55, Andrew Rybchenko:
> On 2/26/20 7:53 PM, Thomas Monjalon wrote:
> > 26/02/2020 17:35, Jerin Jacob:
> >> On Wed, Feb 26, 2020 at 8:31 PM Ferruh Yigit
> >> wrote:
> >>>
> >>> Signed-off-by: Ferruh Yigit
> >>
> >> Acked-by: Jerin Jacob
> >
> > Acked-by: Thomas Monjalon
>
> Acke
04/03/2020 10:57, Ferruh Yigit:
> For the ABI compatibility it is better to hide internal data structures
> from the application as much as possible. But because of some inline
> functions 'struct eth_dev_ops' can't be hidden completely.
>
> Plan is to split the 'struct eth_dev_ops' into two as on
12/05/2020 10:03, Phil Yang:
> Add the maintainership of c11 atomics code.
>
> Signed-off-by: Phil Yang
> Reviewed-by: Honnappa Nagarahalli
> ---
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +C11 Code Maintainer
> +M: Honnappa Nagarahalli
Typo: comma in the email address.
That's what happens when
> >
> > +/*
> > + * helper function, used by emit_ld_mbuf().
> > + * generates code for 'fast_path':
> > + * calculate load offset and check is it inside first packet segment.
> > + */
> > +static void
> > +emit_ldmb_fast_path(struct bpf_jit_state *st, const uint32_t
> > rg[EBPF_REG_7],
> > + uin
30/07/2019 13:16, Mcnamara, John:
> From: Yigit, Ferruh
> > Sent: Monday, June 17, 2019 5:07 PM
> >
> > Clarify that a fixed date will be used for end of embargo (public
> > disclosure) date while communicating with downstream stakeholders.
> >
> > Initial document got a review that it gives an i
22/05/2020 16:06, John McNamara:
> +* **Added additional algorithms to the Cryptodev API.**
>
> + Added additional algorithms and updated support to the Cryptodev PMD and
> + APIs, including:
>
> + * Added support for intel-ipsec-mb version 0.54 to the following PMDs:
> AESNI
> +MB, AES
11/03/2019 19:39, Kevin Traynor:
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor
> ---
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> - Global whitespace rule in DPDK, use tabs for inden
22/05/2020 21:46, jer...@marvell.com:
> From: Jerin Jacob
>
> Add tested Marvell integrated NIC platforms to v20.05 release notes.
>
> Signed-off-by: Jerin Jacob
Applied, thanks
16/12/2019 20:15, Thomas Monjalon:
> The config options are updated with sed and the short in-place option.
> In order to avoid creating a backup file when using sed in-place,
> the argument was tentatively set as an empty suffix.
> On Linux, the suffix argument is optional, without space or equal
20/05/2020 10:38, Raslan Darawsheh:
> Signed-off-by: Raslan Darawsheh
> ---
> doc/guides/rel_notes/release_20_05.rst | 119 +
> 1 file changed, 119 insertions(+)
Applied, thanks
22/05/2020 06:30, Chen, Zhaoyan:
> Add tested Intel platforms for DPDK 20.05 release
>
> Signed-off-by: Chen, Zhaoyan
Applied, thanks
19/03/2020 11:46, Kevin Traynor:
> On 19/03/2020 08:28, David Marchand wrote:
> > for file in $(git grep -l http://.*dpdk.org doc/); do
> > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file;
> > done
> >
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: David Marchand
>
> Acked-by: Kevin Tr
26/03/2020 06:46, Muhammad Bilal:
> Bugzilla ID: 422
> Cc: marko.kovace...@intel.com
> Cc: john.mcnam...@intel.com
> Cc: dev@dpdk.org
> Cc: sta...@dpdk.org
> Signed-off-by: Muhammad Bilal
> ---
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> -file as the c
21/03/2020 19:17, Sarosh Arif:
> Bugzilla ID: 420
> Cc: sta...@dpdk.org
> Signed-off-by: Sarosh Arif
> ---
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> -Once the environment variable the script can be run as follows::
> +Once the environment variable is
Any update?
18/10/2019 12:56, Jerin Jacob:
> On Thu, Oct 17, 2019 at 9:28 PM Olivier Matz wrote:
> >
> > Hi,
> >
> > On Tue, Aug 27, 2019 at 10:02:30AM +0100, A.McLoughlin wrote:
> > > This patch adds a graphical overview of the rte_mbuf struct, showing where
> > > each value is stored within th
What is the status of this patch?
There was no review.
23/09/2019 14:15, Marcin Zapolski:
> Add unit tests and code coverage reports generation guides to Meson
> build documentation.
>
> Signed-off-by: Marcin Zapolski
> ---
> v2: fix trailing whitespaces
> ---
> doc/build-sdk-meson.txt | 40 ++
11/11/2019 11:34, Phil Yang:
> Add a guidance for aarch64 natively build 32-bit aarch32 DPDK.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Phil Yang
> Reviewed-by: Gavin Hu
> Tested-by: Joyce Kong
>
> ---
> .../linux_gsg/cross_build_dpdk_for_arm64.rst | 36
> ++
> 1
21/05/2020 17:11, Ferruh Yigit:
> igb_uio kernel module disabled by default starting from v20.02, document
> this to prevent confusion.
>
> And add note about long term igb_uio plans/directions to move it to
> another repo based on DPDK technical board decision:
> http://mails.dpdk.org/archives/de
22/05/2020 17:14, Kevin Traynor:
> Note support for gcc 10 in the DPDK 20.05 release notes.
>
> Signed-off-by: Kevin Traynor
> ---
> Note: Reduced context so can apply before/after John's cleanup patch
> ---
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05
20/05/2020 12:25, Ferruh Yigit:
> AltiVec ->
> IOTLB -> Input/Output Translation Lookaside Buffer
> IPsec -> Internet Protocol security
> PPPoE -> Point-to-Point Protocol over Ethernet
> PVID-> Port VLAN IDentifier
>
> Signed-off-by: Ferruh Yigit
Applied, thanks
Hi Thomas,
Can this be merged as it was discussed and agreed long back.
--
Nithin
On Thu, May 21, 2020, 16:19 Jerin Jacob wrote:
> On Tue, May 5, 2020 at 2:25 PM Dumitrescu, Cristian
> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Nithin Dabilpuram
> > > Sent: Tuesday, May
06/05/2020 11:55, Ciara Power:
> This patch modifies the arguments expected by the check-git-log script,
> to match the format of arguments for the checkpatches script. Both
> scripts now take certain argument options in the same format, making
> them easier to use.
> e.g. Both now take a commit ID
From: Neil Horman
Since we've moved away from our initial validate-abi.sh script,
in favor of check-abi.sh, which uses libabigail,
remove the old script from the tree, and update the docs accordingly.
Signed-off-by: Neil Horman
Signed-off-by: Thomas Monjalon
---
No progress was done during a m
Hi,
Can you please review the latest changes and ack this patchset?
This is the base for the PMD code.
Thanks,
Ori
> -Original Message-
> From: dev On Behalf Of Ori Kam
> Sent: Thursday, May 7, 2020 12:46 PM
> To: jer...@marvell.com; xiang.w.w...@intel.com
> Cc: g...@marvell.com; dev@dp
On Sun, 24 May 2020 19:30:07 +0200
Thomas Monjalon wrote:
> Some compilers raise an error when declaring a variable
> in the middle of a function. This is a C99 allowance.
> Even if DPDK switches globally to C99 or C11 standard,
> the coding rules are for declarations at the beginning
> of a bloc
When building an ABI reference with meson, some static libraries
are built and linked in apps. They are useless and take a lot of space.
Those binaries, and other useless files (examples and doc files)
in the share/ directory, are removed after being installed.
In order to save time when building
Some compilers raise an error when declaring a variable
in the middle of a function. This is a C99 allowance.
Even if DPDK switches globally to C99 or C11 standard,
the coding rules are for declarations at the beginning
of a block:
http://doc.dpdk.org/guides/contributing/coding_style.html#local-var
13/04/2020 18:19, Andrew Rybchenko:
> On 4/13/20 7:18 PM, Christos Ricudis wrote:
> > Fixes the case where a PCI device string identifier
> > contains non-ASCII UTF-8
> >
> > A particular example is Mellanox Connext-X 5 EN MT27800:
> >
> > 28:00.0 Ethernet controller: Mellanox Technologies
> > MT
30/03/2020 16:18, Piotr Sieduszewski:
> From: Piotr Sieduszewski
>
> Signed-off-by: Piotr Sieduszewski
Please add some explanations, it may help getting reviews.
Thanks
Hello,
17/04/2020 14:50, Sarosh Arif:
> Hello,
> If there is no objection on this patch then it can perhaps be applied.
There are 3 issues here:
1/ There is no maintainer for this script (and no review of the patch)
2/ There is no explanation in this patch (probably explaining the lack of
review
21/05/2020 11:27, Kevin Traynor:
> On 21/05/2020 10:15, Pablo de Lara wrote:
> > The intel-ipsec-mb library requires NASM as a dependency.
> > Steps on how to get and install NASM are added on the documentation
> > of the crypto PMDs which requires the library.
> >
> > Bugzilla ID: 417
> > Cc: sta
22/05/2020 18:44, Laatz, Kevin:
> On 22/05/2020 17:27, Ciara Power wrote:
> > The example shown for registering telemetry commands was previously
> > missing the help text parameter.
> >
> > Fixes: 24cd1b529f35 ("doc: update telemetry guides")
> >
> > Signed-off-by: Ciara Power
>
> Reviewed-by: K
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Sunday, May 24, 2020 5:39 PM
>
> 24/05/2020 17:31, Morten Brørup:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Sunday, May 24, 2020 5:12 PM
> > >
> > > 15/05/2020 15:08, guohongzhi:
> > > > 1.rte
27/04/2020 18:57, Jasvinder Singh:
> For sending request messages to data plane threads, the
> caller invokes pipeline_msg_send_recv() function which never
> returns null response. Thus, removed redundant check on
> the returned response.
>
> Coverity Issues: 357750, 357740, 357749, 357758, 357702
27/04/2020 18:56, Jasvinder Singh:
> For sending request messages to data plane threads, the
> caller invokes thread_msg_send_recv() function which never
> returns null response. Thus, removed redundant check on
> the returned response.
>
> Coverity Issues: 357773, 357723
> Fixes: 32e5d9b154cb ("e
Bruce, as maintainer of l2fwd example, any opinion about this change?
11/05/2020 02:23, Pavan Nikhilesh Bhagavatula:
> Hi Vipin,
>
> >Hi Pavan,
> >
> >snipped
> >> >
> >> >Should we check & warn the user if
> >> >1. port speed mismatch
> >> >2. on different NUMA
> >> >3. port pairs are physical
23/05/2020 13:21, wangyunjian:
> From: Yunjian Wang
>
> Fix memory leaks reported by Coverity.
Please add the Coverity ID with the syntax "Coverity issue:".
>
> Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yunjian Wang
22/05/2020 18:48, Bruce Richardson:
> On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> > On Fri, May 22, 2020 at 7:21 PM Ciara Power wrote:
> > >
> > > Initially, printf was used to indicate and error/warning resulting from
> > > telemetry initialisation. This is now fixed to use EAL
We are missing a review for this patch, please.
02/03/2020 21:41, Thinh Tran:
> - When running the dedault configuration of autotest of the make test
> it'd take 900 seconds (15 minutes) for the script TIMEOUT and marks
> Failed for a specific device test that is not supported on the
> syst
21/05/2020 19:32, Rasesh Mody:
> From: Ferruh Yigit
> >During MTU set (kni_change_mtu) sample application setup queues, which
> >can free and re-allocate queues.
> >Meanwhile sample application keeps continues in Rx/Tx burst calls in
> >different
> >threads, which may cause crash during queue set
24/05/2020 17:31, Morten Brørup:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Sunday, May 24, 2020 5:12 PM
> >
> > 15/05/2020 15:08, guohongzhi:
> > > 1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624)
> > > 2.__rte_raw_cksum should consider Big Endian.
>
Somnath, why neither update, nor reply to reviews after February 7?
It is discouraging for reviewers.
24/04/2020 20:24, Thomas Monjalon:
> Please Somnath, it is waiting for a v2.
>
>
> 26/02/2020 01:55, Stephen Hemminger:
> > On Fri, 7 Feb 2020 15:29:59 +0100
> > Olivier Matz wrote:
> >
> > >
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Sunday, May 24, 2020 5:12 PM
>
> 15/05/2020 15:08, guohongzhi:
> > 1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624)
> > 2.__rte_raw_cksum should consider Big Endian.
> > 3.checksum 0x is invalid for udp, but
11/05/2020 15:43, Harman Kalra:
> An issue has been observed where epoll file descriptor
> list rebuilds every time an interrupt/alarm event is
> received.
>
> eal_intr_process_interrupts() should notify pipe fd only
> if any source is removed from the source list i.e (rv > 0)
>
> Fixes: 0c7ce182
01/05/2020 22:43, Ananyev, Konstantin:
>
> >
> > When fragmenting ipv4 packet, the data offset should be calculated through
> > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
> >
> > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper
> > library"
14/05/2020 03:27, guohongzhi:
> The function of rte_ipv4_cksum for calculating the
> checksum of IPv4 header is incorrect.
> This function will return checksum value like 0x.
> This value, however, is considered an illegal checksum on some switches(like
> Trident3).
>
> RFC 1624 specifies the
15/05/2020 15:08, guohongzhi:
> 1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624)
> 2.__rte_raw_cksum should consider Big Endian.
> 3.checksum 0x is invalid for udp, but valid for tcp.(rfc768)
Please consider doing 3 patches, thanks.
It was sent late for 20.05, I prefe
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin Ananyev
> Sent: Monday, May 18, 2020 5:53 PM
>
> Make x86 JIT to generate native code for
> (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD)
> instructions.
>
> Signed-off-by: Konstantin Ananyev
> ---
> lib/librte_bpf/bpf_jit_x86.
From: Tonghao Zhang
If user don't set the dv_xmeta_en to 1 or 2,
in the flow_dv_convert_action_set_meta function:
* flow_dv_get_metadata_reg may return the REG_NONE,
when MLX5_METADATA_FDB enabled for metadata set
action.
* reg_to_field(REG_NONE) return MLX5_MODI_OUT_NONE
which is invalid.
On Sat, May 23, 2020 at 1:17 AM Slava Ovsiienko
wrote:
>
> Hi, Tonghao
>
> Thank you for the patch.
> I suppose, the patch should be extended to encompass the routines:
> - flow_dv_convert_action_mark
> - flow_dv_convert_action_set_meta (done in the patch)
> - flow_dv_validate_item_mark
> - flow_d
21/05/2020 17:32, Akhil Goyal:
> >
> > This patch fixes improper SHA-1 digest size in the enum comment
> > and also adds the note about HMAC-SHA-1-96.
> >
> > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Adam Dybkowski
> > Acked-
> -Original Message-
> From: Guo, Jia
> Sent: Sunday, May 24, 2020 1:53 PM
> To: Xing, Beilei ; Zhang, Qi Z ;
> Wu, Jingjing
> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
>
> Subject: [dpdk-dev v2] net/iavf: fix protocol field selector configure
>
> When VFs configure the rss rule by v
87 matches
Mail list logo
