Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status textrepresentation

2020-06-08 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, June 5, 2020 1:45 PM > > On 5/27/2020 8:45 AM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Dyukov > >> Sent: Tuesday, May 26, 2020 9:10 PM > >> > >> This commit add function

Re: [dpdk-dev] [PATCH v1 09/12] net/ice: add queue start and stop for DCF

2020-06-08 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Saturday, June 6, 2020 04:18 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Mcnamara, John ; > Kovacevic, Marko > Subject: [PATCH v1 09/12] net/ice: add queue start and stop for DCF > > From: Qi Zhang > > Add queue start and sto

[dpdk-dev] [PATCH v6 00/11] Windows basic memory management

2020-06-08 Thread Dmitry Kozlyuk
This patchset implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * Only 2MB hugepages are supported. * IOVA is always PA, obtained through kernel-mode driver. * No 32-bit support (presumably not demanded). * Ni multi-process support (it is forceful

[dpdk-dev] [PATCH v7 05/11] eal/mem: extract common code for dynamic memory allocation

2020-06-08 Thread Dmitry Kozlyuk
Code in Linux EAL that supports dynamic memory allocation (as opposed to static allocation used by FreeBSD) is not OS-dependent and can be reused by Windows EAL. Move such code to a file compiled only for the OS that require it. Keep Anatoly Burakov maintainer of extracted code. Signed-off-by: Dmi

[dpdk-dev] [PATCH v7 04/11] eal/mem: extract common code for memseg list initialization

2020-06-08 Thread Dmitry Kozlyuk
All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_memory.c | 97 ++ lib/librte_eal/comm

[dpdk-dev] [PATCH v7 06/11] trace: add size_t field emitter

2020-06-08 Thread Dmitry Kozlyuk
It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows, sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs. Tracepoints using "long" field emitter are therefore invalid there. Add dedicated field emitter for size_t and use it to store size_t values in all existing tracepoin

[dpdk-dev] [PATCH v7 01/11] eal: replace rte_page_sizes with a set of constants

2020-06-08 Thread Dmitry Kozlyuk
Clang on Windows follows MS ABI where enum values are limited to 2^31-1. Enum rte_page_sizes has members valued above this limit, which get wrapped to zero, resulting in compilation error (duplicate values in enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. Remove rte_page_size

[dpdk-dev] [PATCH v7 03/11] eal: introduce memory management wrappers

2020-06-08 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_mem_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and reservation, while Unices reserve memory by mappi

[dpdk-dev] [PATCH v7 02/11] eal: introduce internal wrappers for file operations

2020-06-08 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers in order to support common EAL code on Unix and Windows: * eal_file_open: open or create a file. * eal_file_lock: lock or unlock an open file. * eal_file_truncate: enforce a given size for an open file. Implementation for Linux and FreeBSD is placed in "unix" sub

[dpdk-dev] [PATCH v7 10/11] eal/windows: initialize hugepage info

2020-06-08 Thread Dmitry Kozlyuk
Add hugepages discovery ("large pages" in Windows terminology) and update documentation for required privilege setup. Only 2MB hugepages are supported and their number is estimated roughly due to the lack or unstable status of suitable OS APIs. Assign myself as maintainer for the implementation fil

[dpdk-dev] [PATCH v7 11/11] eal/windows: implement basic memory management

2020-06-08 Thread Dmitry Kozlyuk
Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at startup. Assign myself as a maintainer for Windo

[dpdk-dev] [PATCH v7 09/11] eal/windows: improve CPU and NUMA node detection

2020-06-08 Thread Dmitry Kozlyuk
1. Map CPU cores to their respective NUMA nodes as reported by system. 2. Support systems with more than 64 cores (multiple processor groups). 3. Fix magic constants, styling issues, and compiler warnings. 4. Add EAL private function to map DPDK socket ID to NUMA node number. Fixes: 53ffd9f080fc (

[dpdk-dev] [PATCH v7 08/11] eal/windows: replace sys/queue.h with a complete one from FreeBSD

2020-06-08 Thread Dmitry Kozlyuk
Limited version imported previously lacks at least SLIST macros. Import a complete file from FreeBSD, since its license exception is already approved by Technical Board. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/include/sys/queue.h | 663 +++-- 1 file changed, 601

[dpdk-dev] [PATCH v7 07/11] eal/windows: add tracing support stubs

2020-06-08 Thread Dmitry Kozlyuk
EAL common code depends on tracepoint calls, but generic implementation cannot be enabled on Windows due to missing standard library facilities. Add stub functions to support tracepoint compilation, so that common code does not have to conditionally include tracepoints until proper support is added

Re: [dpdk-dev] [PATCH] mbuf: fix external mbufs pool boundaries

2020-06-08 Thread Olivier Matz
On Mon, Jun 01, 2020 at 03:24:16PM +, Alexander Kozyrev wrote: > Memzones are created in testpmd in order to test external data > buffers functionality. Each memzone is 2Mb in size and divided among > the pool of external memory buffers. > > Memzone may not always be fully utilized because mbu

[dpdk-dev] [PATCH v2 1/3] drivers/net/softnic: Remove the re-implementation of inet_pton

2020-06-08 Thread Ibtisam Tariq
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of inet_pton4 and inet_pton6 with libc inet_pton function Bugzilla ID: 365 Fixes: 31ce8d888625 ("net/softnic: add command interface") Cc: jasvinder.si...@intel.com Reported-by: David Marchand Signed-off-by: Ibtisam Tariq --- v2

[dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: Remove the re-implementation of inet_pton

2020-06-08 Thread Ibtisam Tariq
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of inet_pton4 and inet_pton6 with libc inet_pton function Bugzilla ID: 365 Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") Cc: roy.fan.zh...@intel.com Reported-by: David Marchand Signed-off-by: Ibtisam T

[dpdk-dev] [PATCH v2 2/3] examples/ip_pipeline: Remove the re-implementation of inet_pton

2020-06-08 Thread Ibtisam Tariq
inet_pton4 and inet_pton6 was reimplemented. Replacing implementation of inet_pton4 and inet_pton6 with libc inet_pton function Bugzilla ID: 365 Fixes: ed7a0490f7e2 ("examples/ip_pipeline: add string parsing helpers") Cc: piotrx.t.azarew...@intel.com Reported-by: David Marchand Signed-off-by: Ib

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-08 Thread Juraj Linkeš
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 4, 2020 3:30 PM > To: Juraj Linkeš ; Thomas Monjalon > > Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli > > Subject: Re: [PATCH] ethdev: fix dpdk gcc build on Arm > > On 6/4/2020 1:55 PM, Juraj Linkeš

[dpdk-dev] [PATCH v2 1/2] eal: move OS common debug functions to single file

2020-06-08 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_debug.c. Those functions are rte_exit, __rte_panic and rte_dump_registers which has the same implementation on Unix and Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/eal_common_debug.c | 58

[dpdk-dev] [PATCH v2 2/2] eal/windows: support debug calls

2020-06-08 Thread talshn
From: Tal Shnaiderman Support the debug functions in eal_common_debug.c for Windows. Implementation of rte_dump_stack to get a backtrace similarly to Unix and of rte_eal_cleanup in eal.c. Signed-off-by: Tal Shnaiderman --- config/meson.build | 1 + lib/librte_eal/common/meson

[dpdk-dev] [PATCH v2 0/2] Support EAL debug functions on Windows

2020-06-08 Thread talshn
From: Tal Shnaiderman This patchset adds support for the EAL debug function on Windows by implementing backtracing in rte_dump_stack and cleanup calls in rte_eal_cleanup. Additionally, the functions rte_exit, __rte_panic and rte_dump_registers were moved to a common file to avoid code duplicatio

Re: [dpdk-dev] Handling missing export functions in MSVC linkage

2020-06-08 Thread David Marchand
On Mon, Jun 8, 2020 at 2:09 AM Dmitry Kozlyuk wrote: > > On Sun, 7 Jun 2020 12:26:56 + > Tal Shnaiderman wrote: > > > In clang build the .map file is converted into Module-Definition (.Def) > > File. > > If you create a .def manually, it will override the generation from .map. Of > cause, th

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-08 Thread Maxime Coquelin
Hi Matan, On 6/7/20 12:38 PM, Matan Azrad wrote: > Hi Maxime > > Thanks for the huge work. > Please see a suggestion inline. > > From: Maxime Coquelin: >> Sent: Thursday, May 14, 2020 11:02 AM >> To: xiaolong...@intel.com; Shahaf Shuler ; Matan >> Azrad ; amore...@redhat.com; >> xiao.w.w...@inte

Re: [dpdk-dev] [PATCH 0/9] Rename blacklist/whitelist to blocklist/allowlist

2020-06-08 Thread Luca Boccassi
On Sun, 2020-06-07 at 10:01 -0700, Stephen Hemminger wrote: > The terms blacklist and whitelist are often seen as reminders > of the divisions in society. Instead, use more exact terms for > handling of which devices are used in DPDK. > > This is a proposed change for DPDK 20.08 to replace the nam

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for set MTU API

2020-06-08 Thread Ferruh Yigit
On 6/1/2020 3:48 PM, gnand...@amd.com wrote: > From: gnandiba > > This patch adds support for set_mtu API which can be used to change > the Maximum Transmission unit (MTU) from application. > > Signed-off-by: gnandiba Please use "Name Surname " format, for this time I am updating it as followi

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-08 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin: > Hi Matan, > > On 6/7/20 12:38 PM, Matan Azrad wrote: > > Hi Maxime > > > > Thanks for the huge work. > > Please see a suggestion inline. > > > > From: Maxime Coquelin: > >> Sent: Thursday, May 14, 2020 11:02 AM > >> To: xiaolong...@intel.com; Shahaf Shuler ; > >

Re: [dpdk-dev] [PATCH 6/9] eal: replace pci-whitelist/pci-blacklist options

2020-06-08 Thread Bruce Richardson
On Sun, Jun 07, 2020 at 10:01:24AM -0700, Stephen Hemminger wrote: > Replace pci-whitelist with pci-allowlist and pci-blacklist with > pci-blocklist. Allow the old options for now, but make sure help > and all tests will use the new options. > > The short flags are more commonly used and changing

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-08 Thread Nithin Dabilpuram
On Wed, Jun 03, 2020 at 04:14:13PM +, Slava Ovsiienko wrote: > > -Original Message- > > From: dev On Behalf Of Nithin Dabilpuram > > Sent: Wednesday, June 3, 2020 15:52 > > To: Olivier Matz > > Cc: Ananyev, Konstantin ; Jerin Jacob > > ; Dumitrescu, Cristian > > ; Nithin Dabilpuram >

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for utility APIs

2020-06-08 Thread Ferruh Yigit
On 6/1/2020 2:57 PM, selwin.sebast...@amd.com wrote: > From: Selwin Sebastian > > Add support for rx, tx queue utility APIs > Add support for 'fw_revision_get' API > > Signed-off-by: Selwin Sebastian Hi Selwin, Can you please split this patch into three patches, 1) rx/tx queue start/stop Plea

[dpdk-dev] very high VIRT memory usage

2020-06-08 Thread Francesco
Hi all, I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK 20.05 and I noticed that if I look at "top" I see that the VIRT memory taken by my application is now 256.1GB while before it was <1GB. I've seen this same behavior with also "testpmd" example... is this a known is

Re: [dpdk-dev] [PATCH v1 2/8] net/mlx5: add mlx5 Linux specific file with getter functions

2020-06-08 Thread Ferruh Yigit
On 6/3/2020 4:05 PM, Ophir Munk wrote: > 'ctx' type (field in 'struct mlx5_ctx_shared') is changed from 'struct > ibv_context *' to 'void *'. 'ctx' members which are verbs dependent > (e.g. device_name) will be accessed through getter functions which are > added to a new file under Linux directory

Re: [dpdk-dev] [PATCH v1 7/8] net/mlx5: add mlx5 header file specific to Linux

2020-06-08 Thread Ferruh Yigit
On 6/3/2020 4:06 PM, Ophir Munk wrote: > File drivers/net/linux/mlx5_os.h is added. It includes specific > Linux definitions such as PCI driver flags, link state changes > interrupts, link removal interrupts, etc. > > Signed-off-by: Ophir Munk > Acked-by: Matan Azrad <...> > diff --git a/drive

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-08 Thread Ferruh Yigit
On 6/8/2020 9:17 AM, Juraj Linkeš wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, June 4, 2020 3:30 PM >> To: Juraj Linkeš ; Thomas Monjalon >> >> Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli >> >> Subject: Re: [PATCH] ethdev: fix dpdk gcc

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-08 Thread Juraj Linkeš
> -Original Message- > From: Ferruh Yigit > Sent: Monday, June 8, 2020 1:39 PM > To: Juraj Linkeš ; Thomas Monjalon > > Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm > > On 6/8/2020 9:17 AM, Jura

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-08 Thread Ferruh Yigit
On 6/8/2020 1:03 PM, Juraj Linkeš wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, June 8, 2020 1:39 PM >> To: Juraj Linkeš ; Thomas Monjalon >> >> Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli >> >> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix

[dpdk-dev] [PATCH 1/3] test/crypto: fix asym session mempool creation

2020-06-08 Thread Adam Dybkowski
This patch fixes the element size of the mempool used for allocating asym crypto sessions and their private data. Fixes: 2c6dab9cd93d ("test/crypto: add RSA and Mod tests") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev_asym.c | 5 +++-- 1 file changed, 3 insertio

[dpdk-dev] [PATCH 3/3] crypto/qat: verify session IOVA

2020-06-08 Thread Adam Dybkowski
This patch adds the verification of the crypto session IOVA that should be known (not zero) to proceed with the session initialisation. In case of unknown IOVA the error code -EINVAL is returned. Signed-off-by: Adam Dybkowski --- drivers/crypto/qat/qat_sym_session.c | 10 +- 1 file chang

[dpdk-dev] [PATCH 2/3] cryptodev: verify session mempool element size

2020-06-08 Thread Adam Dybkowski
This patch adds the verification of the element size of the mempool provided for the session creation. Returns the error if the element size is too small to hold the session object. Signed-off-by: Adam Dybkowski --- lib/librte_cryptodev/rte_cryptodev.c | 45 +++- 1 file c

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-08 Thread Juraj Linkeš
> -Original Message- > From: Ferruh Yigit > Sent: Monday, June 8, 2020 2:39 PM > To: Juraj Linkeš ; Thomas Monjalon > > Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm > > On 6/8/2020 1:03 PM, Jura

[dpdk-dev] [PATCH] devtools: allow ENOSYS in checkpatch

2020-06-08 Thread Thomas Monjalon
The Linux checkpatch default is warning on the use of ENOSYS. This is allowed in DPDK API. Signed-off-by: Thomas Monjalon --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 158087f1ca..0a5840a

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-08 Thread Ferruh Yigit
On 6/8/2020 2:19 PM, Juraj Linkeš wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, June 8, 2020 2:39 PM >> To: Juraj Linkeš ; Thomas Monjalon >> >> Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli >> >> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix

Re: [dpdk-dev] [PATCH] devtools: allow ENOSYS in checkpatch

2020-06-08 Thread Ferruh Yigit
On 6/8/2020 2:28 PM, Thomas Monjalon wrote: > The Linux checkpatch default is warning on the use of ENOSYS. > This is allowed in DPDK API. > > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] maintainers: add Xavier for bonding

2020-06-08 Thread Ferruh Yigit
On 6/8/2020 2:42 AM, Charles (Chas) Williams wrote: > > On 5/18/2020 9:00 AM, Ferruh Yigit wrote: >> On 5/18/2020 12:20 PM, Wei Hu (Xavier) wrote: >>> Adding Xavier as additional maintainer to bonding. >>> >>> Signed-off-by: Wei Hu (Xavier) >>> --- >>> MAINTAINERS | 1 + >>> 1 file changed, 1

[dpdk-dev] [PATCH] net/mlx5: fix typos in meter error messages

2020-06-08 Thread Ali Alnubani
Fixes: 3bd26b23cefc ("net/mlx5: support meter profile operations") Cc: suanmi...@mellanox.com Signed-off-by: Ali Alnubani Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_meter.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/mlx5/

[dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command

2020-06-08 Thread Shy Shyman
MTU is used in testpmd to set the maximum payload size for packets. According to testpmd, the setting influnce RX only. In rte_ethdev there's no relation between MTU setting and JUMBO offload or rx_max_pkt_len. The previous fix in patch referenced below was meant to update the correlated variables

[dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name

2020-06-08 Thread Adam Dybkowski
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cr

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix passing negative parameter to strerror

2020-06-08 Thread Ferruh Yigit
On 6/6/2020 4:46 AM, Wei Hu (Xavier) wrote: > Currently, there are coverity defect warnings those were found from the > public coverity. > https://scan.coverity.com/projects/dpdk-data-plane-development-kit > > Coverity issue: > In nic_stats_clear function: > CID 358450 (#1 of 1): Argument ca

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command

2020-06-08 Thread Ferruh Yigit
On 6/8/2020 3:17 PM, Shy Shyman wrote: > MTU is used in testpmd to set the maximum payload size for packets. > According to testpmd, the setting influnce RX only. > In rte_ethdev there's no relation between MTU setting and JUMBO offload or > rx_max_pkt_len. > > The previous fix in patch referenced

Re: [dpdk-dev] Handling missing export functions in MSVC linkage

2020-06-08 Thread Tal Shnaiderman
> Subject: Re: Handling missing export functions in MSVC linkage > > On Sun, 7 Jun 2020 12:26:56 + > Tal Shnaiderman wrote: > > > In clang build the .map file is converted into Module-Definition (.Def) > > File. > > If you create a .def manually, it will override the generation from .map.

[dpdk-dev] [PATCH 1/2] doc: announce rte_dev_probe() API change

2020-06-08 Thread Maxime Coquelin
In order to simplify the use of rte_dev_probe() and rte_dev_remove() by applications, rte_dev_probe() will return a reference on the rte_device stating DPDK v20.11. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/do

[dpdk-dev] [PATCH 0/2] rte_dev_probe() API change

2020-06-08 Thread Maxime Coquelin
This series proposes a change in rte_dev_probe() API for DPDK v20.11. First patch is the deprecation notice to be applied in v20.0 Maxime Coquelin (2): doc: announce rte_dev_probe() API change eal: improve device probing API app/test-pmd/testpmd.c | 2 +- doc/guides/rel_note

[dpdk-dev] [PATCH v20.11 2/2] eal: improve device probing API

2020-06-08 Thread Maxime Coquelin
This patch makes rte_dev_probe() to return the rte_device pointer on success and NULL on error instead of returning 0 on success and negative value on error. The goal is to avoid that the calling application iterates the devices list afterwards to retrieve the pointer. Retrieving the pointer is re

[dpdk-dev] [PATCH 0/1] net/mlx5: fix flow memory allocation size

2020-06-08 Thread Gregory Etelson
Gregory Etelson (1): net/mlx5: fix flow memory allocation size drivers/net/mlx5/mlx5.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) -- 2.25.1

[dpdk-dev] [PATCH 1/1] net/mlx5: fix flow memory allocation size

2020-06-08 Thread Gregory Etelson
In DV enabled MLX5 PMD build mlx5_ipool_cfg[MLX5_IPOOL_MLX5_FLOW].size was initiated for DV structure. If RTE initialization encountered MLX5 PCI function with disabled DV support mlx5_ipool_cfg[MLX5_IPOOL_MLX5_FLOW].size was reduced to match legacy verbs flow size. Since mlx5_ipool_cfg[MLX5_IPOOL

[dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-08 Thread Bruce Richardson
Rather than continuing to recommend an 80-char line limit, let's take a hint from the Linux kernel[1] and aim for an 100-char recommended limit instead. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 Signed-off-by: Bruce

[dpdk-dev] [PATCH] test/ring_perf: fix error statistics in bulk enq/dequeue

2020-06-08 Thread Feifei Wang
In size 32 bulk ring enq/dequeue performance test, the "Total count" statistics is incorrect. For example, running the test on lcore 25 and lcore 26, the output is as follows: The test command: $sudo ./arm64-armv8a-linuxapp-gcc/app/test -l 25-26 RTE>>ring_perf_autotest Bulk enq/dequeue count on s

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-08 Thread Honnappa Nagarahalli
> Subject: [PATCH v4 1/3] lib/lpm: integrate RCU QSBR > > Currently, the tbl8 group is freed even though the readers might be using the > tbl8 group entries. The freed tbl8 group can be reallocated quickly. This > results in incorrect lookup results. > > RCU QSBR process is integrated for safe

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-08 Thread Stephen Hemminger
On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson wrote: > Rather than continuing to recommend an 80-char line limit, let's take a hint > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co

[dpdk-dev] [PATCH v2 01/10] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

2020-06-08 Thread Stephen Hemminger
The comment used the term whitelist and was awkardly written. Replace it with simpler direct description of adding a new address. No code or API changes for this. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH v2 00/10] Rename blacklist/whitelist to

2020-06-08 Thread Stephen Hemminger
The terms blacklist and whitelist are often seen as reminders of the divisions in society. Instead, use more exact terms for handling of which devices are used in DPDK. This is a proposed change for DPDK 20.08 to replace the names blacklist and whitelist in API and command lines. The first three

[dpdk-dev] [PATCH v2 03/10] check_maintainers: change variable names

2020-06-08 Thread Stephen Hemminger
Use blocklist where blacklist was used and allowlist where whitelist was used. Signed-off-by: Stephen Hemminger --- devtools/check-maintainers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-maintainers.sh b/devtools/check-maintainers.sh index 85a300

[dpdk-dev] [PATCH v2 05/10] drivers: replace references to blacklist

2020-06-08 Thread Stephen Hemminger
Use the new terminolgy BLOCKED to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fslmc_vfio.c | 8 drivers/bus/pci/pci_com

[dpdk-dev] [PATCH v2 06/10] eal: replace pci-whitelist/pci-blacklist options

2020-06-08 Thread Stephen Hemminger
Replace pci-whitelist with pci-only-list and pci-blacklist with pci-skip-probe. Allow the old options for now, but make sure help and all tests will use the new options. Leave the short flags are more commonly used and changing them would impact more documentation and applications. Signed-off-by:

[dpdk-dev] [PATCH v2 07/10] doc: replace references to blacklist/whitelist

2020-06-08 Thread Stephen Hemminger
The terms blacklist and whitelist are no longer used. Replace them in the documentation. Most of this was automatic replacement, but in a couple of places the language was awkward before and have tried to improve the readabilty. Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/dpaa2_s

[dpdk-dev] [PATCH v2 04/10] eal: replace usage of blacklist/whitelist in enum

2020-06-08 Thread Stephen Hemminger
This patch renames the enum values in the EAL include files. As a backward compatiable temporary migration tool, define a replacement mapping for old values. The old names relating to blacklist and whitelist are replaced by blocklist and allowlist, but applications may be using the older compatiab

[dpdk-dev] [PATCH v2 08/10] app/test: use new allowlist and blocklist

2020-06-08 Thread Stephen Hemminger
Test the renamed pci-blocklist and pci-allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger --- app/test/autotest.py| 16 ++-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2 +- app/test/test_eal_fla

[dpdk-dev] [PATCH v2 02/10] mk: replace reference to blacklist/whitelist

2020-06-08 Thread Stephen Hemminger
Use BLOCKLIST and ALLOWLIST in the make variable names. Signed-off-by: Stephen Hemminger --- mk/rte.sdktest.mk | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk index 803018ba3a70..6777e0c0f603 100644 --- a/mk/rte.sdktest.mk

[dpdk-dev] [PATCH v2 10/10] eal: mark old macros for blacklist/whitelist as deprecated

2020-06-08 Thread Stephen Hemminger
Use of these macros in applications should cause a deprecation warning. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_bus.h | 10 +++--- lib/librte_eal/include/rte_dev.h | 10 +++--- lib/librte_eal/include/rte_devargs.h | 10 +++--- 3 files changed, 21 inser

[dpdk-dev] [PATCH v2 09/10] doc: add note about blacklist/whitelist changes

2020-06-08 Thread Stephen Hemminger
The blacklist/whitelist changes to API will cause warnings to change for applications. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/release_20_08.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08

Re: [dpdk-dev] rte_log simplification using constructor scheme

2020-06-08 Thread Thomas Monjalon
27/05/2020 18:05, Jerin Kollanukkaran: > +#define RTE_LOG_REGISTER(type, name, level)\ > +int type; \ > +RTE_INIT(__##type) \ > +{

[dpdk-dev] [PATCH] eal: generic counter based loop for CPU freq calculation

2020-06-08 Thread Honnappa Nagarahalli
get_tsc_freq uses 'nanosleep' system call to calculate the CPU frequency. However, 'nanosleep' results in the process getting un-scheduled. The kernel saves and restores the PMU state. This ensures that the PMU cycles are not counted towards a sleeping process. When RTE_ARM_EAL_RDTSC_USE_PMU is def

[dpdk-dev] [PATCH] doc: fix minor typo for better display

2020-06-08 Thread Honnappa Nagarahalli
The display was not proper due to the missing space. Changed arm64 to aarch64. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- doc/guides/linux_gsg/linux_drivers.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/linux_gsg/linux_drivers.rst

[dpdk-dev] Arm roadmap for 20.08

2020-06-08 Thread Honnappa Nagarahalli
(Bcc: Arm internal stake holders) Hello, Following are the work items planned for 20.08: 1) LPM integration with RCU 2) rte_bitops APIs 3) rte_atomic API deprecation with-in DPDK 4) Use C11 atomic semantics in mbuf, eventdev, eal interrupts 5) Change IO barriers to align with other-multi-

[dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error

2020-06-08 Thread Jiang Mao
Fdir allocating msix resource is not strictly necessary, if no resource left, print a warning message. Signed-off-by: Jiang Mao Fixes: 4861cde461 (i40e: new poll mode driver) --- drivers/net/i40e/i40e_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/i40e/i4

[dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-06-08 Thread Jiang Mao
The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will be bind to vector 0. Signed-off-by: Jiang Mao Fixes: 4861cde461 (i40e: new poll mode driver) --- drivers/net/i40e/i40e_ethdev.c | 41 +++--- drivers/net/i40e/i40e_ethdev.h | 2 +- 2 file

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-06-08 Thread Ye Xiaolong
On 06/09, Jiang Mao wrote: >The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will >be bind to vector 0. > >Signed-off-by: Jiang Mao > >Fixes: 4861cde461 (i40e: new poll mode driver) Fixes tag should be put before SOB line and please cc sta...@dpdk.org. >--- > drivers/ne

[dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-06-08 Thread Jiang Mao
The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will be bind to vector 0. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Signed-off-by: Jiang Mao --- drivers/net/i40e/i40e_ethdev.c | 41 +++--- drivers/net/i40e/i40e_ethde

[dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error

2020-06-08 Thread Jiang Mao
Fdir allocating msix resource is not strictly necessary, if no resource left, print a warning message. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Signed-off-by: Jiang Mao --- drivers/net/i40e/i40e_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-08 Thread Jerin Jacob
On Tue, Jun 9, 2020 at 12:47 AM Stephen Hemminger wrote: > > On Mon, 8 Jun 2020 17:46:40 +0100 > Bruce Richardson wrote: > > > Rather than continuing to recommend an 80-char line limit, let's take a hint > > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > > > [1]

[dpdk-dev] [PATCH] mbuf: remove unused next member

2020-06-08 Thread Xiaolong Ye
TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te, next). Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: sta...@dpdk.org