Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-26 Thread Jiawei(Jonny) Wang
> -Original Message- > From: Jan Viktorin > Sent: Wednesday, September 23, 2020 4:30 PM > To: Jiawei(Jonny) Wang > Cc: Asaf Penso ; dev@dpdk.org; Ori Kam > ; Slava Ovsiienko > Subject: Re: [dpdk-dev] Duplicating traffic with RTE Flow > > On Wed, 23 Sep 2020 02:28:03 + > "Jiawei(Jo

Re: [dpdk-dev] [PATCH v8 13/13] doc: update offload dependencies document

2020-09-26 Thread Asaf Penso
Regards, Asaf Penso >-Original Message- >From: Jiawei Wang >Sent: Sunday, September 27, 2020 9:19 AM >To: Ori Kam ; Slava Ovsiienko ; >Matan Azrad ; NBU-Contact-Thomas Monjalon >; ferruh.yi...@intel.com; >marko.kovace...@intel.com; arybche...@solarflare.com >Cc: dev@dpdk.org; Raslan Da

Re: [dpdk-dev] [PATCH 17/20] drivers/net: accept removing device without any port

2020-09-26 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, September 14, 2020 6:07 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybche...@solarflare.com; Xu, > Rosen ; Stephen Hemminger > ; K. Y. Srinivasan ; > Haiyang Zhang ; Long Li ; > Heinrich Kuhn ; Gagandeep Singh > ; Akhil Goyal

[dpdk-dev] [PATCH v8 10/13] net/mlx5: update translate function for mirror

2020-09-26 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list. PMD will check the destination action number in current flow, if found multiple destination actions, then create the new destination array rdma action that group actions for each destination. Currently only sup

[dpdk-dev] [PATCH v8 13/13] doc: update offload dependencies document

2020-09-26 Thread Jiawei Wang
Add the offloads minimum versions for new sampling feature. Signed-off-by: Jiawei Wang --- doc/guides/nics/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index c021f37..95f6820 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/

[dpdk-dev] [PATCH v8 11/13] app/testpmd: add port and encap support for sample action

2020-09-26 Thread Jiawei Wang
Use sample action with ratio is 1 for mirroring flow, add supports to set the different port or encap action for mirrored packets. The example of test-pmd command: 1. set sample_actions 1 port_id id 1 / end flow create 0 ... pattern eth / end actions sample ratio 1 index 1 / port_id id

[dpdk-dev] [PATCH v8 03/13] common/mlx5: query sampler object capability via DevX

2020-09-26 Thread Jiawei Wang
Update function mlx5_devx_cmd_query_hca_attr() to add the NIC Flow Table attributes query, then get the log_max_flow_sampler_num from flow table properties. Add the related structs definition in mlx5_prm.h. Signed-off-by: Jiawei Wang Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- driver

[dpdk-dev] [PATCH v8 12/13] doc: add the sample flow limitation description

2020-09-26 Thread Jiawei Wang
Add description about the sample flow limitation. Sample Flow supports in NIC-Rx and E-Switch domains. Due to Metadata register c0 is deleted while doing the loopback, so that only support forward the sampling packet into E-Switch manager port, no additional action support in sample flow. Signed-o

[dpdk-dev] [PATCH v8 06/13] net/mlx5: update translate function for sample action

2020-09-26 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list, then create the sample DR action. The metadata register value will be lost in the default path after Sampler in FDB due to CX5 HW limitation. Since source vport also be shared with metadata register c0, MLX5

[dpdk-dev] [PATCH v8 07/13] app/testpmd: add testpmd command for sample action

2020-09-26 Thread Jiawei Wang
Add a new testpmd command 'set sample_actions' that supports the multiple sample actions list configuration by using the index: set sample_actions The examples for the sample flow use case and result as below: 1. set sample_actions 0 mark id 0x8 / queue index 2 / end .. pattern eth / end action

[dpdk-dev] [PATCH v8 00/13] support the flow-based traffic sampling

2020-09-26 Thread Jiawei Wang
This patch set implement the flow sampling for mlx5 driver. The solution is introduced a new rte_flow action that will sample the incoming traffic and send a duplicated traffic with the specified ratio to the application, while the original packet will continue to the target destination. If the

[dpdk-dev] [PATCH v8 04/13] net/mlx5: add the validate sample action

2020-09-26 Thread Jiawei Wang
Add sample action validate function. Sample Flow is supported in NIC-RX and FDB domains. For the NIC-RX the Sample Flow action list must include the destination queue action. Only NIC-RX domain supports the optional actions list. FDB doesn't support any optional actions, the sampled packets is al

[dpdk-dev] [PATCH v8 05/13] net/mlx5: split sample flow into two sub flows

2020-09-26 Thread Jiawei Wang
The flow with sample action will be splited into two sub flows: the prefix sub flow with the all actions preceding the sample action and sample action itself, and the suffix sub flow with the actions following the sample action. The original items remain in the prefix sub flow, add the implicit ta

[dpdk-dev] [PATCH v8 08/13] common/mlx5: add glue function for mirroring

2020-09-26 Thread Jiawei Wang
The new DR destination array action is supported since the rdma-core version v32. Destination array action is used group DR actions to a single action, And it can be used for mirroring packet and forward to every destination (port or queue) in the array. Signed-off-by: Jiawei Wang Acked-by: Viac

[dpdk-dev] [PATCH v8 02/13] common/mlx5: glue for sample action

2020-09-26 Thread Jiawei Wang
The new DR sample action is supported since OFED version 5.1.2 or rdma-core version v32. MLX5 PMD adds the rdma-core command in glue to create this action. Sample action is used for creating the sample object to implement the sampling/mirroring function. Signed-off-by: Jiawei Wang Acked-by: Via

[dpdk-dev] [PATCH v8 01/13] ethdev: introduce sample action for rte flow

2020-09-26 Thread Jiawei Wang
When using full offload, all traffic will be handled by the HW, and forwarded to the requested VF or wire and the control application does not see this traffic anymore. So there's a need for an action that enables the control application some forwarded traffic visibility. The solution introduces a

[dpdk-dev] [PATCH v8 09/13] net/mlx5: update validation for mirroring flow

2020-09-26 Thread Jiawei Wang
Mirroring flow using sample action with ratio is 1, and it doesn't support jump action with the same one flow. Sample action must have destination actions like port or queue for mirroring, and don't need split function as sampling flow. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko

Re: [dpdk-dev] [PATCH] gso: add VXLAN UDP GSO support

2020-09-26 Thread yang_y_yi
Jiayu, also please help review this GSO patch, thanks a lot. At 2020-07-01 14:46:43, yang_y...@163.com wrote: >From: Yi Yang > >Many NICs can't offload VXLAN UFO, so it is very important >to do VXLAN UDP GSO by software to improve VM-to-VM UDP >performance, especially for the ca

Re: [dpdk-dev] [PATCH V1 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-09-26 Thread yang_y_yi
Hi, folks Per GSO requirement, this is a must-have change, Jiayu, can you help review this series? Olivier, if you used the old interface, maybe you need to change your code to adapt this, I don't think we can have a better way to handle GSO case. At 2020-08-04 09:31:19, "yang_y_yi

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2020-09-26 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, September 22, 2020 15:29 > To: Xu, Rosen > Cc: Zhang, Qi Z ; Wang, Xiao W > ; Yang, Qiming ; Yigit, > Ferruh ; Richardson, Bruce > ; Andrew Rybchenko > ; Wang, Zhihong ; > Xing, Beilei ; Wu, Jingjing ; > dev@dpdk.org; Zhao

Re: [dpdk-dev] [PATCH v7 3/3] doc: update prog_guide and rel_notes for GRO

2020-09-26 Thread Hu, Jiayu
Acked-by: Jiayu Hu > -Original Message- > From: yang_y...@163.com > Sent: Thursday, September 24, 2020 4:58 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net; > yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH v7 3/3] doc: update prog_guide and rel_notes for GRO > > Fr

Re: [dpdk-dev] [PATCH v7 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-26 Thread Hu, Jiayu
Acked-by: Jiayu Hu > -Original Message- > From: yang_y...@163.com > Sent: Thursday, September 24, 2020 4:58 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net; > yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH v7 2/3] gro: add VXLAN UDP/IPv4 GRO support > > From: Yi Ya

Re: [dpdk-dev] [PATCH v7 1/3] gro: add UDP/IPv4 GRO support

2020-09-26 Thread Hu, Jiayu
Acked-by: Jiayu Hu > -Original Message- > From: yang_y...@163.com > Sent: Thursday, September 24, 2020 4:58 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net; > yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH v7 1/3] gro: add UDP/IPv4 GRO support > > From: Yi Yang >

Re: [dpdk-dev] [PATCH v7 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-26 Thread Jiayu Hu
On Sun, Sep 27, 2020 at 11:14:44AM +0800, yang_y_yi wrote: > Ok, thanks Jiayu, but I don't know before which "}" whitespace should be > inserted, can you paste your check report here? > > BTW, I used chekpatch.pl in Linux 5.5.9, it doesn't report this,I also tried > checkpatch.pl in Linus kernel g

Re: [dpdk-dev] [PATCH v2 03/12] acl: remove of unused enum value

2020-09-26 Thread Ruifeng Wang
> -Original Message- > From: Konstantin Ananyev > Sent: Wednesday, September 16, 2020 12:50 AM > To: dev@dpdk.org > Cc: jer...@marvell.com; Ruifeng Wang ; > vladimir.medved...@intel.com; Konstantin Ananyev > > Subject: [PATCH v2 03/12] acl: remove of unused enum value > > Removal of unus

[dpdk-dev] [PATCH V5 0/2] change data type in TC queue

2020-09-26 Thread Min Hu (Connor)
From: Huisong Li This series change data type in TC rxq and TC txq, fix compiling errors for per-queue statistics. Huisong Li (2): dpdk: resolve compiling errors for per-queue stats ethdev: change data type in TC rxq and TC txq app/proc-info/main.c | 2 +- app/test-pmd/c

[dpdk-dev] [PATCH V5 2/2] ethdev: change data type in TC rxq and TC txq

2020-09-26 Thread Min Hu (Connor)
From: Huisong Li Currently, base and nb_queue in the tc_rxq and tc_txq information of queue and TC mapping on both TX and RX paths are uint8_t. However, these data will be truncated when queue number under a TC is greater than 256. So it is necessary for base and nb_queue to change from uint8_t t

[dpdk-dev] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats

2020-09-26 Thread Min Hu (Connor)
From: Huisong Li Currently, only statistics of rx/tx queues with queue_id less than RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain application scenario that it needs to use 256 or more than 256 queues and display all statistics of rx/tx queue. At this moment, we have to chang

Re: [dpdk-dev] [PATCH v7 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-26 Thread yang_y_yi
Ok, thanks Jiayu, but I don't know before which "}" whitespace should be inserted, can you paste your check report here? BTW, I used chekpatch.pl in Linux 5.5.9, it doesn't report this,I also tried checkpatch.pl in Linus kernel git tree, the same result, so out of curiosity, can you send me yo

Re: [dpdk-dev] [PATCH v6] net/iavf: support flex desc metadata extraction

2020-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Sunday, September 27, 2020 10:09 AM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Jia > > Subject: [PATCH v6] net/iavf: support flex desc metadata extraction > > Enable metadata extraction for flex

[dpdk-dev] [PATCH] doc: update release notes for iavf

2020-09-26 Thread alvinx . zhang
From: Alvin Zhang Update release notes by adding new features for iavf PMD. Signed-off-by: Alvin Zhang --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index adf

[dpdk-dev] [PATCH v6] net/iavf: support flex desc metadata extraction

2020-09-26 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

Re: [dpdk-dev] [PATCH v7 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-26 Thread Hu, Jiayu
Hi Yi, Just a small issue, and please see it inline. After change it, you can add my ack in the serial patches. Thanks, Jiayu > -Original Message- > From: yang_y...@163.com > Sent: Thursday, September 24, 2020 4:58 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net; > yangy...@i

[dpdk-dev] [PATCH v4 2/3] net/iavf: enable AVX512 for flexible RX

2020-09-26 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the flexible RX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 10 + drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v4 1/3] net/iavf: enable AVX512 for legacy RX

2020-09-26 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the legacy RX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 27 +- drivers/net/iavf/iavf_rxt

[dpdk-dev] [PATCH v4 3/3] net/iavf: enable AVX512 for TX

2020-09-26 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the TX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- doc/guides/rel_notes/release_20_11.rst | 3 + drivers/net/iavf/iavf_ethdev.c

[dpdk-dev] [PATCH v4 0/3] enable AVX512 for iavf

2020-09-26 Thread Wenzhuo Lu
AVX512 instructions is supported by more and more platforms. These instructions can be used in the data path to enhance the per-core performance of packet processing. Comparing with the existing implementation, this path set introduces some AVX512 instructions into the iavf data path, and we get

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: enhance old ethdev close behavior

2020-09-26 Thread Thomas Monjalon
25/09/2020 21:24, Rasesh Mody: > Hi Thomas, > > >From: Thomas Monjalon > >Sent: Friday, September 25, 2020 12:11 AM > > > >25/09/2020 06:17, Rasesh Mody: > >> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources > >> for the port can be freed by rte_eth_dev_close(). With this chan

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-26 Thread Andrey Vesnovaty
Hi Ajit, Andrew & Ori. PSB 😉 > -Original Message- > From: Ajit Khaparde > Sent: Thursday, September 24, 2020 10:25 PM > To: Ori Kam > Cc: Andrew Rybchenko ; Andrey Vesnovaty > ; NBU-Contact-Thomas Monjalon > ; Slava Ovsiienko ; > jer...@marvell.com; dpdk-dev ; j...@marvell.com; Jerin Jac

Re: [dpdk-dev] [EXTERNAL] [PATCH v2 7/7] examples/cmdline: build on Windows

2020-09-26 Thread Khoa To
> -Original Message- > From: Dmitry Kozlyuk > > diff --git a/examples/meson.build b/examples/meson.build index > eb13e8210..2b8ebce3b 100644 > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -79,9 +79,9 @@ foreach example: examples > > ext_deps = [execinfo] > i

[dpdk-dev] Port Link Down Error while ruining Dpdk ipsec-secgw application

2020-09-26 Thread satyavalli rama
Hi Anoob and DPDK Dev Team, Please guide us resolve the issue.. While running the ipsec-secgw application the ports are getting down and it is throwing -->Port Link Down Error We are doing the below steps: Since we don't have IXGBE driver in the virtual machines. we used SRIOV to import th

Re: [dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning

2020-09-26 Thread David Marchand
On Fri, Sep 25, 2020 at 7:13 PM Stephen Hemminger wrote: > > On Fri, 25 Sep 2020 18:41:40 +0200 > David Marchand wrote: > > > On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger > > wrote: > > > > > > The DPDK does not have (or want to use) the same fallthrough > > > wrapper as the Linux kernel.