Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-02 Thread 谢华伟(此时此刻)
On 2021/3/2 21:14, David Marchand wrote: This change is a fix/optimisation. This is a separate topic from adding MMIO support with x86 ioport. I would split as a separate patch. Hi David: Maybe there is confuse? There is no change. The out/in is added. I don't remove _p on purpose. Looking a

Re: [dpdk-dev] [PATCH v1] net/ice: fix wrong RSS hash update

2021-03-02 Thread Wu, Wenjun1
Hi Qiming, There are two consequences if skipping the state rss_conf->rss_hf == 0. 1. The function " port config all rss none" means to disable RSS. When rss_conf->rss_hf == 0, the function will not take affect, which does not conform to the description in dpdk doc: The none option is

[dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables

2021-03-02 Thread Marvin Liu
This patch fixs coverity issue by adding initialization step before using temporary virtio header. Coverity issue: 366181, 366123 Fixes: fb3815cc614d ("vhost: handle virtually non-contiguous buffers in Rx-mrg") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_n

Re: [dpdk-dev] [PATCH v1] net/ice: fix wrong RSS hash update

2021-03-02 Thread Yang, Qiming
> -Original Message- > From: Wu, Wenjun1 > Sent: Tuesday, March 2, 2021 13:31 > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 ; sta...@dpdk.org > Subject: [PATCH v1] net/ice: fix wrong RSS hash update > > This patch removes redundant judgment statements to disable R

[dpdk-dev] [PATCH v16 3/3] raw/ifpga: add miscellaneous APIs

2021-03-02 Thread Wei Huang
Below miscellaneous APIs are used to implement OPAE application. 1. rte_pmd_ifpga_get_pci_bus() get PCI bus ifpga driver registered. 2. rte_pmd_ifpga_partial_reconfigure() do partial reconfiguration. 3. rte_pmd_ifpga_cleanup() free software resources allocated by driver. 4. rte_pmd_ifpga_set_rsu_st

[dpdk-dev] [PATCH v16 2/3] raw/ifpga: add APIs to get fpga information

2021-03-02 Thread Wei Huang
There are some information data can be got from FPGA, they are implemented in below APIs: 1. rte_pmd_ifpga_get_property() get properties of FPGA (include BMC). 2. rte_pmd_ifpga_get_phy_info() get information of PHY connect to FPGA. 3. rte_pmd_ifpga_get_rsu_status() get status of rsu process. Signe

[dpdk-dev] [PATCH v16 1/3] raw/ifpga: add fpga rsu APIs

2021-03-02 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are five APIs added: 1. rte_pmd_ifpga_get_dev_id() get raw device ID of ifpga device from PCI address like 'Domai

[dpdk-dev] [PATCH v16 0/3] raw/ifpga: add extra APIs for Cyborg

2021-03-02 Thread Wei Huang
Cyborg is part of OpenStack, it needs some extra APIs to manage devices with Intel FPGA. These patches add APIs to meet Cyborg requirement. Main changes from v15: - remove example from the patch set Wei Huang (3): raw/ifpga: add fpga rsu APIs raw/ifpga: add APIs to get fpga information raw/

Re: [dpdk-dev] 20.11.1 patches review and test

2021-03-02 Thread Chen, BoX C
> -Original Message- > From: Luca Boccassi > Sent: March 2, 2021 19:28 > To: Chen, BoX C ; sta...@dpdk.org > Cc: dev@dpdk.org; Walker, Benjamin ; > Govindharajan, Hariprasad ; > Mcnamara, John ; Yu, PingX > ; Pei Zhang ; Peng, Yuan > ; Chen, Zhaoyan > Subject: Re: [dpdk-dev] 20.11.1 patch

Re: [dpdk-dev] [PATCH v2] ci: catch coredumps

2021-03-02 Thread Aaron Conole
David Marchand writes: > Parts of the unit tests code rely on forked/secondary processes > (expectedly) failing. > A crash in those situations could be missed so add a check on coredumps > presence after unit tests have run. > When unit tests fail, it can also help checking for coredumps as it >

Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx descriptor status

2021-03-02 Thread Lance Richardson
On Tue, Mar 2, 2021 at 9:29 AM Lance Richardson wrote: > > Fix a number of issues in the bnxt receive descriptor status > function, including: >- Provide status of receive descriptor instead of completion > descriptor. >- Remove invalid comparison of raw ring index with masked ring >

[dpdk-dev] Q on l3fwd-acl and acl library

2021-03-02 Thread Ravi Kerur
Hello, I am using l3fwd-acl example code and would like to know the intention of ACL_DENY_SIGNATURE in the code. Is ACL rules programmed to drop packets and not for any other functionality? I see that userdata is ignored for ACL and programmed with ACL_DENY_SIGNATURE + count. After classification

[dpdk-dev] [PATCH] net/bnxt: don't set mbuf pointers to null in vector PMD

2021-03-02 Thread Lance Richardson
Remove code for setting consumed mbuf pointers to NULL from the vector receive functions as a minor performance optimization. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxq.c | 10 ++ drivers/net/bnxt/

[dpdk-dev] [PATCH] net/bnxt: fix Rx descriptor status

2021-03-02 Thread Lance Richardson
Fix a number of issues in the bnxt receive descriptor status function, including: - Provide status of receive descriptor instead of completion descriptor. - Remove invalid comparison of raw ring index with masked ring index. - Correct misinterpretation of offset parameter as ring

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-02 Thread Matan Azrad
Hi Cristian Good discussion, thank you for that! From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Tuesday, March 2, 2021 12:37 PM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko > > Cc: dev@dpdk.or

[dpdk-dev] [dpdk-announce] DPDK Summit APAC - FULL AGENDA live!

2021-03-02 Thread Jill Lovato
DPDK Community: DPDK Summit APAC is just a few weeks away, happening virtually March 22-23! The FULL AGENDA is now posted, so take a look at the great lineup and register to join us today (did we mention that registration is complimentary?!) REGISTER HERE---> https://events.linuxfoundation.org/dp

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix wrong segmented packet in Rx

2021-03-02 Thread Slava Ovsiienko
> -Original Message- > From: Jiawei Zhu <17826875...@163.com> > Sent: Monday, March 1, 2021 19:20 > To: dev@dpdk.org > Cc: zhujiawe...@huawei.com; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko ; > Jiawei Zhu <17826875...@163.com>; sta...@dpdk.org > Subject: [PATCH v3] net/mlx5: fix wrong

Re: [dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API

2021-03-02 Thread Dmitry Kozlyuk
2021-03-02 17:26, Tal Shnaiderman: > add error number reporting to rte_errno in all > functions in the rte_thread_tls_* API. > > Suggested-by: Anatoly Burakov > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/include/rte_thread.h | 6 +++--- > lib/librte_eal/unix/rte_thread.c| 6 +

[dpdk-dev] [PATCH] net/pcap: fix fd leak on uninit

2021-03-02 Thread Tengfei Zhang
pcap fd was opend when vdev probed, but not closed when vdev removed. Fixes: c956caa6eabf ("pcap: support port hotplug") Cc: sta...@dpdk.org Signed-off-by: Tengfei Zhang --- drivers/net/pcap/rte_eth_pcap.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

2021-03-02 Thread Jiawei Zhu
Hi, Slava Thanks a lot for your correction and advice. I'm not very good at grammar 😁. Here is new patch and used your words.😃 https://patches.dpdk.org/project/dpdk/patch/1614619190-3846-1-git-send-email-17826875...@163.com/ With best regards, Jiawei On 2021/3/2 4:10 PM, Slava Ovsiienko wrot

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-03-02 Thread Elad Nachman
Hi Dan, Thanks for the information but you are addressing a different problem. The problem discussed here is making ifconfig up or down while the DPDK application is running. Elad. בתאריך יום ב׳, 1 במרץ 2021, 23:26, מאת Dan Gora ‏: > This is from my git commit fixing this: > > kni: separate rel

[dpdk-dev] [PATCH v3] net/mlx5: fix wrong segmented packet in Rx

2021-03-02 Thread Jiawei Zhu
The issue occurred if mbuf starvation happened in the middle of segmented packet reception. In such a situation, after release the segments of packet being received, code did not advance the consumer index to the next stride. This caused the receiving of the wrong segmented packet data. The possib

Re: [dpdk-dev] [PATCH v3 3/5] examples/l3fwd: add FIB infrastructure

2021-03-02 Thread Ananyev, Konstantin
> > The purpose of this commit is to add the necessary function calls > and supporting infrastructure to allow the Forwarding Information Base > (FIB) library to be integrated into the l3fwd sample app. > The flag '-F' has been added to the applications options to allow > the user to specify that

Re: [dpdk-dev] [PATCH v3 4/5] examples/l3fwd: implement FIB lookup method

2021-03-02 Thread Ananyev, Konstantin
> > This patch implements the Forwarding Information Base (FIB) library > in l3fwd using the function calls and infrastructure introduced in > the previous patch. > > Signed-off-by: Conor Walsh > --- > examples/l3fwd/l3fwd_fib.c | 475 - > 1 file changed, 4

Re: [dpdk-dev] [PATCH v3 2/5] examples/l3fwd: move l3fwd routes to common header

2021-03-02 Thread Ananyev, Konstantin
> > To prevent code duplication from the addition of lookup methods > the routes specified in lpm should be moved to a common header. > > Signed-off-by: Conor Walsh > --- > examples/l3fwd/l3fwd_common_route.h | 48 +++ > examples/l3fwd/l3fwd_lpm.c | 74 +++--

Re: [dpdk-dev] [PATCH v2] ci: catch coredumps

2021-03-02 Thread Luca Boccassi
On Mon, 2021-01-25 at 16:05 +0100, David Marchand wrote: > Parts of the unit tests code rely on forked/secondary processes > (expectedly) failing. > A crash in those situations could be missed so add a check on coredumps > presence after unit tests have run. > When unit tests fail, it can also help

Re: [dpdk-dev] [PATCH] test: move debug_autotest out of fast suite

2021-03-02 Thread Luca Boccassi
On Tue, 2021-03-02 at 15:19 +0100, David Marchand wrote: > On Tue, Mar 2, 2021 at 3:13 PM Luca Boccassi wrote: > > RTE>>EAL: Detected 2 lcore(s) > > EAL: Detected 1 NUMA nodes > > EAL: Multi-process socket /var/run/dpdk/debug_autotest/mp_socket > > EAL: Selected IOVA mode 'VA' > > EAL: Probing VFI

Re: [dpdk-dev] [RFC 0/5] Use correct memory ordering in eal functions

2021-03-02 Thread Honnappa Nagarahalli
> > > rte_eal_remote_launch and rte_eal_wait_lcore need to provide correct > > memory ordering to address the data communication from main core to > > worker core and vice versa. > > > > There are 2 use cases: > > 1) All the store operations (meant for worker) by main core should be > > visible

Re: [dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-03-02 Thread Bruce Richardson
On Tue, Mar 02, 2021 at 10:26:59AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > On Tue, Mar 02, 2021 at 10:07:26AM +0100, David Marchand wrote: > >> On Wed, Feb 10, 2021 at 3:56 PM Aaron Conole wrote: > >> > diff --git a/doc/guides/contributing/testing.rst > >> > b/doc/guides/con

Re: [dpdk-dev] [PATCH v2 2/2] eal: rename key opaque pointer in TLS API

2021-03-02 Thread Morten Brørup
> From: Tal Shnaiderman [mailto:tal...@nvidia.com] > Sent: Tuesday, March 2, 2021 4:27 PM > > rename the key opaque pointer from rte_tls_key to > rte_thread_key to avoid confusion with transport layer security. > > Suggested-by: Vladimir Medvedkin > Signed-off-by: Tal Shnaiderman [...] > diff

[dpdk-dev] [PATCH v2 2/2] eal: rename key opaque pointer in TLS API

2021-03-02 Thread Tal Shnaiderman
rename the key opaque pointer from rte_tls_key to rte_thread_key to avoid confusion with transport layer security. Suggested-by: Vladimir Medvedkin Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/linux/mlx5_flow_os.c | 2 +- drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +- lib/librte_eal

[dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API

2021-03-02 Thread Tal Shnaiderman
add error number reporting to rte_errno in all functions in the rte_thread_tls_* API. Suggested-by: Anatoly Burakov Signed-off-by: Tal Shnaiderman --- lib/librte_eal/include/rte_thread.h | 6 +++--- lib/librte_eal/unix/rte_thread.c| 6 ++ lib/librte_eal/windows/rte_thread.c | 8 +++-

[dpdk-dev] [PATCH v2 0/2] EAL Thread TLS API enhancements

2021-03-02 Thread Tal Shnaiderman
Enhancements to the TLS API. --- v2: Rename key to avoid redundancy[MortenB]. --- Tal Shnaiderman (2): eal: error number enhancement for thread TLS API eal: rename key opaque pointer in TLS API drivers/net/mlx5/linux/mlx5_flow_os.c | 2 +- drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-

Re: [dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-03-02 Thread Aaron Conole
Bruce Richardson writes: > On Tue, Mar 02, 2021 at 10:07:26AM +0100, David Marchand wrote: >> On Wed, Feb 10, 2021 at 3:56 PM Aaron Conole wrote: >> > diff --git a/doc/guides/contributing/testing.rst >> > b/doc/guides/contributing/testing.rst >> > new file mode 100644 >> > index 00..86c

Re: [dpdk-dev] [PATCH v7 8/9] ethdev: representor iterator compare complete info

2021-03-02 Thread Xueming(Steven) Li
>-Original Message- >From: Andrew Rybchenko >Sent: Tuesday, March 2, 2021 10:10 PM >To: Xueming(Steven) Li >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso >; NBU-Contact-Thomas Monjalon >; Ferruh Yigit ; Ray Kinsella >; Neil Horman > >Subject: Re: [PATCH v7 8/9] ethdev: representor it

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-02 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Tuesday, March 2, 2021 12:37 PM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; > m...@smartsharesystems.com; ajit.khapa..

Re: [dpdk-dev] [PATCH] test: move debug_autotest out of fast suite

2021-03-02 Thread David Marchand
On Tue, Mar 2, 2021 at 3:13 PM Luca Boccassi wrote: > RTE>>EAL: Detected 2 lcore(s) > EAL: Detected 1 NUMA nodes > EAL: Multi-process socket /var/run/dpdk/debug_autotest/mp_socket > EAL: Selected IOVA mode 'VA' > EAL: Probing VFIO support... > APP: HPET is not enabled, using TSC as default timer >

Re: [dpdk-dev] [PATCH] test: move debug_autotest out of fast suite

2021-03-02 Thread Luca Boccassi
On Mon, 2021-03-01 at 09:03 +0100, David Marchand wrote: > On Thu, Feb 25, 2021 at 8:49 PM wrote: > > From: Luca Boccassi > > > > It consistently fails when ran on a build machine within the > > reproducible build environment, so move it out of there, so > > that we can run the fast suite at bui

Re: [dpdk-dev] [PATCH v7 8/9] ethdev: representor iterator compare complete info

2021-03-02 Thread Andrew Rybchenko
On 3/2/21 2:43 PM, Xueming Li wrote: > The NIC can have multiple PCIe links and can be attached to multiple > hosts, for example the same single NIC can be shared for multiple server > units in the rack. On each PCIe link NIC can provide multiple PFs and > VFs/SFs based on these ones. The full repr

[dpdk-dev] [PATCH V2 14/14] net/hns3: fix imprecise statistics

2021-03-02 Thread Lijun Ou
From: Chengchang Tang Currently, the hns3 statistics may be inaccurate due to the following two problems: 1. Queue-level statistics are read from the firmware, and only one Rx or Tx can be read at a time. This results in a large time interval between reading multiple queues statistics in a stres

[dpdk-dev] [PATCH V2 12/14] net/hns3: fix memory leakage for mbuf

2021-03-02 Thread Lijun Ou
From: Huisong Li The mbufs of rx queue will be allocated in "hns3_do_start" function. But these mbufs are not released when "hns3_dev_start" executes failed. Fixes: c4ae39b2cfc5 ("net/hns3: fix Rx interrupt after reset") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --

[dpdk-dev] [PATCH V2 02/14] net/hns3: add more registers to dump

2021-03-02 Thread Lijun Ou
From: Chengchang Tang This patch makes more registers dumped in the dump_reg API to help loacte the fault. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.h | 13 drivers/net/hns3/hns3_regs.c | 171 ++- 2 file

[dpdk-dev] [PATCH V2 01/14] net/hns3: support module EEPROM dump

2021-03-02 Thread Lijun Ou
From: Chengchang Tang This patch add support for dumping module EEPROM. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- doc/guides/rel_notes/release_21_05.rst | 4 + drivers/net/hns3/hns3_cmd.h| 16 drivers/net/hns3/hns3_ethdev.c | 159 ++

[dpdk-dev] [PATCH V2 13/14] net/hns3: add process for MAC interrupt

2021-03-02 Thread Lijun Ou
From: Hongbo Zheng TNL is the abbreviation of tunnel, which means port here. MAC TNL interrupt indicates the MAC status report of the network port, which will be generated when the MAC status changes. This patch enables MAC TNL interrupt reporting, and queries and prints the corresponding MAC st

[dpdk-dev] [PATCH V2 05/14] net/hns3: add imissed packet stats

2021-03-02 Thread Lijun Ou
From: "Min Hu (Connor)" This patch implement Rx imissed stats by querying cmdq. Signed-off-by: Min Hu (Connor) Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.h| 7 +++ drivers/net/hns3/hns3_ethdev.c | 7 +++ drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_stats.c

[dpdk-dev] [PATCH V2 09/14] net/hns3: support RXD advanced layout

2021-03-02 Thread Lijun Ou
From: Chengwen Feng Currently, the driver get packet type by parse the L3_ID/L4_ID/OL3_ID/OL4_ID from Rx descriptor and then lookup multiple tables, it's time consuming. Now Kunpeng930 support advanced RXD layout, which: 1. Combine OL3_ID/OL4_ID to 8bit PTYPE filed, so the driver get packet type

[dpdk-dev] [PATCH V2 10/14] net/hns3: fix maximum frame size update after buffer alloc

2021-03-02 Thread Lijun Ou
From: Chengchang Tang After MTU changed, the buffer used to store packets in HW should be reallocated. And buffer size is allocated based on the maximum frame size in the PF struct. However, the value of maximum frame size is not updated in time when MTU is changed. This would lead to a packet l

[dpdk-dev] [PATCH V2 07/14] net/hns3: fix device capabilities for copper media type

2021-03-02 Thread Lijun Ou
From: Huisong Li The configuration operation for PHY is implemented by firmware. And a capability flag will be report to driver, which means the firmware supports the PHY driver. However, the current implementation only supports obtaining the capability bit, but some basic functions of copper po

[dpdk-dev] [PATCH V2 11/14] net/hns3: remove unused parameter from func declaration

2021-03-02 Thread Lijun Ou
From: Huisong Li All input parameters in the "hns3_dev_xstats_get_by_id" API are used, so the rte_unused flag of some variables should be deleted. Fixes: 3213d584b698 ("net/hns3: fix xstats with id and names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- drivers/

[dpdk-dev] [PATCH V2 08/14] net/hns3: support PF device with copper phys

2021-03-02 Thread Lijun Ou
From: Huisong Li The normal operation of devices with copper phys depends on the initialization and configuration of the PHY chip. The task of driving the PHY chip is implemented in some firmware versions. If firmware supports the phy driver, it will report a capability flag to driver in probing

[dpdk-dev] [PATCH V2 03/14] net/hns3: implement cleanup for Tx done

2021-03-02 Thread Lijun Ou
From: Chengwen Feng This patch add support tx_done_cleanup ops, which could support for the API rte_eth_tx_done_cleanup to free consumed mbufs on Tx ring. Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- doc/guides/nics/features/hns3.ini | 1 + doc/guides/nics/features/hns3_vf.i

[dpdk-dev] [PATCH V2 04/14] net/hns3: add Rx and Tx bytes stats

2021-03-02 Thread Lijun Ou
From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Rx/Tx bytes stats will be enabled if the macro RTE_LIBRTE_HNS3_PMD_SOFT_COUNTERS is defined. Signed-off-by: Min Hu (Connor) Signed-off-by: Lij

[dpdk-dev] [PATCH V2 06/14] net/hns3: encapsulate a port shaping interface

2021-03-02 Thread Lijun Ou
From: Huisong Li When rate of port changes, the rate limit of the port needs to be updated. So it is necessary to encapsulate an interface that configures the rate limit based on the rate. Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_dcb.c| 22 ++

[dpdk-dev] [PATCH V2 00/14] Features and bugfixes for hns3

2021-03-02 Thread Lijun Ou
This series add three features according to the 21.05 roadmap as well as fix some bugs. v1->v2: - fix the commit log for patch[8/14]. - add more comit log information for patch[13/14]. - add a fix patch[7/14] because the version will not suport for copper phy before merge patch[8/14]. Chengcha

Re: [dpdk-dev] [PATCH 2/2] eal: rename key opaque pointer in TLS API

2021-03-02 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tal Shnaiderman > Sent: Tuesday, March 2, 2021 2:13 PM > > > Subject: RE: [dpdk-dev] [PATCH 2/2] eal: rename key opaque pointer in > TLS > > API > > > > External email: Use caution opening links or attachments > > > > > > > From: dev [mailto:d

Re: [dpdk-dev] [PATCH v8 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-03-02 Thread David Marchand
On Tue, Mar 2, 2021 at 1:48 PM 谢华伟(此时此刻) wrote: > > Hi David and ferru: > > Any other issue integrating this patch? I just replied on patch 2. Besides, checkpatch complains about trivial issues. http://mails.dpdk.org/archives/test-report/2021-March/180454.html http://mails.dpdk.org/archives/test

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-02 Thread David Marchand
On Mon, Mar 1, 2021 at 4:44 PM 谢华伟(此时此刻) wrote: > >>> What is the downside of using "pause until the I/O completes" versions? > >> The downside in virtio PMD is a small performance penalty when we use it > >> to notify backend. CPU executes unnecessary serializing IO instruction. > >> > >> I check

Re: [dpdk-dev] [PATCH 2/2] eal: rename key opaque pointer in TLS API

2021-03-02 Thread Tal Shnaiderman
> Subject: RE: [dpdk-dev] [PATCH 2/2] eal: rename key opaque pointer in TLS > API > > External email: Use caution opening links or attachments > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tal Shnaiderman > > Sent: Tuesday, March 2, 2021 12:25 PM > > > > rename the key opaque poin

Re: [dpdk-dev] [PATCH v8 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-03-02 Thread Ferruh Yigit
On 3/2/2021 12:48 PM, 谢华伟(此时此刻) wrote: Please don't top post, message moved down. On 2021/3/2 0:01, 谢华伟(此时此刻) wrote: From: "huawei.xhw" virtio PMD assumes legacy device only supports PIO BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited,

Re: [dpdk-dev] [PATCH v8 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-03-02 Thread 谢华伟(此时此刻)
Hi David and ferru: Any other issue integrating this patch? On 2021/3/2 0:01, 谢华伟(此时此刻) wrote: From: "huawei.xhw" virtio PMD assumes legacy device only supports PIO BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited, we expose MMIO(memory

Re: [dpdk-dev] [PATCH v2] power: remove duplicated symbols from map file

2021-03-02 Thread David Marchand
On Thu, Feb 25, 2021 at 3:38 PM David Marchand wrote: > > On Thu, Feb 25, 2021 at 11:55 AM Ferruh Yigit wrote: > > > > This is causing build error, like: > > https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104 > > > > Also '@internal' marker removed from doxygen comment, since public API >

Re: [dpdk-dev] [PATCH 2/2] eal: rename key opaque pointer in TLS API

2021-03-02 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tal Shnaiderman > Sent: Tuesday, March 2, 2021 12:25 PM > > rename the key opaque pointer from rte_tls_key to > rte_thread_tls_key to avoid confusion with transport layer security. > [...] > diff --git a/lib/librte_eal/include/rte_thread.h

Re: [dpdk-dev] telemetry logs

2021-03-02 Thread Thomas Monjalon
02/03/2021 12:18, Bruce Richardson: > On Tue, Mar 02, 2021 at 12:01:12PM +0100, Thomas Monjalon wrote: > > 02/03/2021 11:42, Bruce Richardson: > > > On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > > > > 02/03/2021 11:14, Bruce Richardson: > > > > > On Mon, Mar 01, 2021 at 08:22:1

Re: [dpdk-dev] [PATCH v3] ci: update arm64 Travis jobs to Graviton2

2021-03-02 Thread David Marchand
On Tue, Feb 23, 2021 at 9:28 AM Juraj Linkeš wrote: > > Use only the newer Graviton2 environment in Travis CI instead of using > the older platform, which has intermittent issues: > 1. collect2: fatal error: ld terminated with signal 9 [Killed] > 2. ticketlock_autotest sometimes times out > > Thes

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-02 Thread Matan Azrad
HI Cristian From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Tuesday, March 2, 2021 7:02 AM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; > > Ra

Re: [dpdk-dev] [PATCH v6 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-03-02 Thread 谢华伟(此时此刻)
On 2021/2/25 1:52, David Marchand wrote: On Wed, Feb 24, 2021 at 4:29 PM 谢华伟(此时此刻) wrote: Did you check that virtio devices bound to uio_pci_generic still works with legacy mode + PIO? I had verified PIO, might under igb_uio driver. Well, if you are unsure, please retest both cases, igb_uio

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-02 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Tuesday, March 2, 2021 7:02 AM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; > m...@smartsharesystems.com; ajit.khapa...

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-02 Thread Dumitrescu, Cristian
... > Overall I think this is a better approach. And default packet_mode > will be bytes. > Yes, agreed.

Re: [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check

2021-03-02 Thread Ferruh Yigit
On 2/17/2021 4:30 PM, Ferruh Yigit wrote: On 2/17/2021 4:26 PM, Ferruh Yigit wrote: From: Vadim Podovinnikov In bond (LACP) we have several NICs (ports), when we have negotiation with peer about what port we prefer, we send information about what system we preferred in partner system name fiel

Re: [dpdk-dev] [PATCH v7 7/9] ethdev: new API to get representor info

2021-03-02 Thread Andrew Rybchenko
On 3/2/21 2:43 PM, Xueming Li wrote: > The NIC can have multiple PCIe links and can be attached to multiple > hosts, for example the same single NIC can be shared for multiple server > units in the rack. On each PCIe link NIC can provide multiple PFs and > VFs/SFs based on these ones. The full repr

Re: [dpdk-dev] [PATCH v7 5/9] ethdev: support PF index in representor

2021-03-02 Thread Andrew Rybchenko
On 3/2/21 2:42 PM, Xueming Li wrote: > With Kernel bonding, multiple underlying PFs are bonded, VFs come > from different PF, need to identify representor of VFs unambiguously by > adding PF index. > > This patch introduces optional 'pf' section to representor devargs > syntax, examples: > repres

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/6] net/pcap: fix format string

2021-03-02 Thread Ferruh Yigit
On 2/25/2021 2:45 PM, Ferruh Yigit wrote: On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: Use PRIu32 for uint32_t (found by -Wformat with Clang on Windows). Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Ferruh Yigi

[dpdk-dev] [PATCH v7 9/9] kvargs: update parser to support lists

2021-03-02 Thread Xueming Li
This patch updates kvargs parser to support lists on top of range, allow multiple lists or range: k1=a[1,2]b[3-5] Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalon --- app/test/test_kvargs.c | 46 +-- lib/librte_kvargs/rte_kvargs.c | 101

[dpdk-dev] [PATCH v7 8/9] ethdev: representor iterator compare complete info

2021-03-02 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. The full representor identifier consists of three indices

[dpdk-dev] [PATCH v7 7/9] ethdev: new API to get representor info

2021-03-02 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. The full representor identifier consists of three indices

[dpdk-dev] [PATCH v7 6/9] ethdev: support multi-host in representor

2021-03-02 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to the multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. To provide the unambiguous identification of the PCIe

[dpdk-dev] [PATCH v7 5/9] ethdev: support PF index in representor

2021-03-02 Thread Xueming Li
With Kernel bonding, multiple underlying PFs are bonded, VFs come from different PF, need to identify representor of VFs unambiguously by adding PF index. This patch introduces optional 'pf' section to representor devargs syntax, examples: representor=pf0vf0 - single VF representor r

[dpdk-dev] [PATCH v7 4/9] ethdev: support sub function representor

2021-03-02 Thread Xueming Li
SubFunction is a portion of the PCI device, created on demand, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports eswitch representation offload similar to existing PF and VF representors. To support SF representor, this patch introduces new devargs syntax, examples: represe

[dpdk-dev] [PATCH v7 3/9] ethdev: support new VF representor syntax

2021-03-02 Thread Xueming Li
Current VF representor syntax: representor=2 - single representor representor=[0-3] - single range To prepare for more representor types, this patch adds compatible VF representor devargs syntax: vf#: representor=vf2 - single representor representor=vf[1,3,5]- singl

[dpdk-dev] [PATCH v7 1/9] ethdev: introduce representor type

2021-03-02 Thread Xueming Li
To support more representor type, this patch introduces representor type enum. The enum is subject to be extended to support new representor in patches upcoming. For each devarg structure, only one type supported. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalo

[dpdk-dev] [PATCH v7 0/9] ethdev: support SubFunction representor

2021-03-02 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports E-Switch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. >From SmartNIC pe

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

2021-03-02 Thread Nick Connolly
DPDK supports a variety of platforms and toolsets and my experience with SPDK suggests that we'll end up with compiler specific ifdef's. I'd argue they are inevitable. Consider POSIX close(): if it's missing, what would be a correct fallback? It depends on the execution environment (OS). Str

Re: [dpdk-dev] 20.11.1 patches review and test

2021-03-02 Thread Luca Boccassi
On Tue, 2021-03-02 at 10:52 +, Chen, BoX C wrote: > Hi Luca, > > Testing with dpdk v20.11.1 from Intel looks good. > > # Basic Intel(R) NIC testing > *PF(i40e, ixgbe): test scenarios including rte_flow/TSO/Jumboframe/checksum > offload/Tunnel, etc. Listed but not all. > - No new issue

[dpdk-dev] [PATCH 0/2] EAL Thread TLS API enhancements

2021-03-02 Thread Tal Shnaiderman
Enhancements to the TLS API. Tal Shnaiderman (2): eal: error number enhancement for thread TLS API eal: rename key opaque pointer in TLS API drivers/net/mlx5/linux/mlx5_flow_os.c | 2 +- drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +- lib/librte_eal/include/rte_thread.h | 19

[dpdk-dev] [PATCH 1/2] eal: error number enhancement for thread TLS API

2021-03-02 Thread Tal Shnaiderman
add error number reporting to rte_errno in all functions in the rte_thread_tls_* API. Suggested-by: Anatoly Burakov Signed-off-by: Tal Shnaiderman --- lib/librte_eal/include/rte_thread.h | 6 +++--- lib/librte_eal/unix/rte_thread.c| 6 ++ lib/librte_eal/windows/rte_thread.c | 8 +++-

[dpdk-dev] [PATCH 2/2] eal: rename key opaque pointer in TLS API

2021-03-02 Thread Tal Shnaiderman
rename the key opaque pointer from rte_tls_key to rte_thread_tls_key to avoid confusion with transport layer security. Suggested-by: Vladimir Medvedkin Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/linux/mlx5_flow_os.c | 2 +- drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +- lib/librte

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-02 Thread Nick Connolly
Is posix_memalign() used more extensively in SPDK? In DPDK, it's 2 PMDs: Yes, there are about 80 references. A lot are in ISA-L where they are #defined to _aligned_malloc and can be ignored, but there still several in the rest of the code. * Sockets are unfortunately specified as using cl

Re: [dpdk-dev] telemetry logs

2021-03-02 Thread Bruce Richardson
On Tue, Mar 02, 2021 at 12:01:12PM +0100, Thomas Monjalon wrote: > 02/03/2021 11:42, Bruce Richardson: > > On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > > > 02/03/2021 11:14, Bruce Richardson: > > > > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > > > > Hi

Re: [dpdk-dev] telemetry logs

2021-03-02 Thread Thomas Monjalon
02/03/2021 11:42, Bruce Richardson: > On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > > 02/03/2021 11:14, Bruce Richardson: > > > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > > > Hi, > > > > Sorry if I already asked this question. > > > > Would it be possi

Re: [dpdk-dev] [PATCH v2] driver/net/pcap fix: fd leak bug

2021-03-02 Thread Ferruh Yigit
On 3/1/2021 3:30 PM, ZhangTengfei wrote: pcap fd was opend when vdev probed, but not closed when vdev removed. This bug appears in dpdk-pdump The patch title should have "net/pcap: " as module name instead of "driver/net/pcap: ", suggested title: net/pcap: fix fd leak on uninit Also needs f

Re: [dpdk-dev] 20.11.1 patches review and test

2021-03-02 Thread Chen, BoX C
Hi Luca, Testing with dpdk v20.11.1 from Intel looks good. # Basic Intel(R) NIC testing *PF(i40e, ixgbe): test scenarios including rte_flow/TSO/Jumboframe/checksum offload/Tunnel, etc. Listed but not all. - No new issue are found. *VF(i40e,ixgbe): test sce

Re: [dpdk-dev] telemetry logs

2021-03-02 Thread Bruce Richardson
On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > 02/03/2021 11:14, Bruce Richardson: > > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > > Hi, > > > Sorry if I already asked this question. > > > Would it be possible to use rte_log in rte_telemetry > > > instea

Re: [dpdk-dev] 20.11.1 patches review and test

2021-03-02 Thread Luca Boccassi
On Tue, 2021-03-02 at 11:53 +0530, Kalesh Anakkur Purayil wrote: > Hi Luca, > > Testing with dpdk v20.11.1 from Broadcom looks good. > > - Basic functionality: > Send and receive multiple types of traffic. > - Changing/checking link status through testpmd. > - RSS tests. > - TSO tests > - VLAN

Re: [dpdk-dev] 20.11.1 patches review and test

2021-03-02 Thread Kalesh Anakkur Purayil
Hi Luca, Testing with dpdk v20.11.1 from Broadcom looks good. - Basic functionality: Send and receive multiple types of traffic. - Changing/checking link status through testpmd. - RSS tests. - TSO tests - VLAN filtering tests. - MAC filtering test - statistics tests - Checksum offload tests - M

Re: [dpdk-dev] telemetry logs

2021-03-02 Thread Thomas Monjalon
02/03/2021 11:14, Bruce Richardson: > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > Hi, > > Sorry if I already asked this question. > > Would it be possible to use rte_log in rte_telemetry > > instead of returning telemetry_log_error at init? > > > It probably could be made

Re: [dpdk-dev] telemetry logs

2021-03-02 Thread Bruce Richardson
On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > Hi, > Sorry if I already asked this question. > Would it be possible to use rte_log in rte_telemetry > instead of returning telemetry_log_error at init? > It probably could be made to work by passing in the log function at init tim

Re: [dpdk-dev] [PATCH v2] guides: add a testing guide for developing tests

2021-03-02 Thread Bruce Richardson
On Tue, Mar 02, 2021 at 10:07:26AM +0100, David Marchand wrote: > On Wed, Feb 10, 2021 at 3:56 PM Aaron Conole wrote: > > diff --git a/doc/guides/contributing/testing.rst > > b/doc/guides/contributing/testing.rst > > new file mode 100644 > > index 00..86ca24ce43 > > --- /dev/null > > +++

Re: [dpdk-dev] [PATCH v2] mbuf: rename outer ip checksum macro

2021-03-02 Thread Ferruh Yigit
On 2/26/2021 4:27 PM, Ajit Khaparde wrote: On Fri, Feb 26, 2021 at 8:01 AM Ferruh Yigit wrote: On 2/25/2021 2:31 PM, Lance Richardson wrote: Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and deprecate the original name. The new name is better aligned with existing PKT_RX_OUTER_* fl

Re: [dpdk-dev] [PATCH] net/af_xdp: fix error handling during Rx queue setup

2021-03-02 Thread Ferruh Yigit
On 3/1/2021 10:34 AM, Ciara Loftus wrote: Prior to this commit, if rte_pktmbuf_alloc_bullk failed during rx queue setup the error was not returned to the user and they may incorrectly assume that the rx queue had been successfully set up. This commit ensures that the error is returned to the user

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: tunnel offload model

2021-03-02 Thread Thomas Monjalon
02/03/2021 10:22, Ivan Malov: > Hi Gregory, Eli, > > On 16/10/2020 15:51, Gregory Etelson wrote: > > Applications wishing to offload tunneled traffic are required to use > > the rte_flow primitives, such as group, meta, mark, tag, and others to > > model their high-level objects. The hardware

  1   2   >