Re: [dpdk-dev] Questions about reporting auto-negotiation capability

2021-03-29 Thread Thomas Monjalon
29/03/2021 06:02, Huisong Li: > Hi, all > > 'speed_capa' in struct rte_eth_dev_info is defined as follows: > > uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ > > >Most PMD drivers use this field to report the speeds capability > supported by the devic

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-29 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Monday, March 29, 2021 14:47 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log > > From: Hongbo Zheng > > This patch adds more err info for Tx/Rx descript

Re: [dpdk-dev] Questions about reporting auto-negotiation capability

2021-03-29 Thread Thomas Monjalon
29/03/2021 09:03, Thomas Monjalon: > 29/03/2021 06:02, Huisong Li: > > 'speed_capa' in struct rte_eth_dev_info is defined as follows: > > > > uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ > > > > > >Most PMD drivers use this field to report the speeds

[dpdk-dev] [PATCH] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Murphy Yang
If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting the device (but after setting everything else), then RSS RETA configuration be zero after starting the device. This patch gives a notification if the port not started. Bugzilla ID: 664 Fixes: 249358424eab ("ixgbe: RSS RETA conf

[dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability

2021-03-29 Thread Thomas Monjalon
The flag ETH_LINK_SPEED_AUTONEG is 0, so it cannot be used in a capability bitmap. Having 0 in speed capability means all speeds are accepted. Signed-off-by: Thomas Monjalon --- drivers/net/bnxt/bnxt_ethdev.c | 2 -- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 4 2 files changed, 6

Re: [dpdk-dev] [PATCH v1 5/6] raw/ioat: add api to query remaining ring space

2021-03-29 Thread Pai G, Sunil
Tested-by: Sunil Pai G

Re: [dpdk-dev] [PATCH v7] app/testpmd: support multi-process

2021-03-29 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Friday, March 26, 2021 16:53 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; ajit.khapa...@broadcom.com; Li, > Xiaoyun > Subject: [PATCH v7] app/testpmd: support multi-process > > From: Lijun Ou > > This patch adds multi-process support

Re: [dpdk-dev] [PATCH] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Wang, Haiyue
> -Original Message- > From: Yang, MurphyX > Sent: Monday, March 29, 2021 15:20 > To: dev@dpdk.org > Cc: Yang, Qiming ; Wang, Haiyue > ; Guo, Jia > ; Yang, SteveX ; Zhang, RobinX > ; > Yang, MurphyX > Subject: [PATCH] net/ixgbe: fix RSS RETA be reset after port start > > If one calls ‘

Re: [dpdk-dev] [PATCH 0/2] adjusting mkey creations

2021-03-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, March 25, 2021 10:53 AM > To: Michael Baum ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: RE: [PATCH 0/2] adjusting mkey creations > > Hi, > > > -Original Message- > > From: Michael Baum > > Sen

[dpdk-dev] [PATCH v2] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Murphy Yang
If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting the device (but after setting everything else), then RSS RETA configuration be zero after starting the device. This patch gives a notification if the port not started. Bugzilla ID: 664 Fixes: 249358424eab ("ixgbe: RSS RETA conf

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Wang, Haiyue
> -Original Message- > From: Murphy Yang > Sent: Monday, March 29, 2021 16:11 > To: dev@dpdk.org > Cc: Yang, Qiming ; Wang, Haiyue > ; Guo, Jia > ; Yang, SteveX ; Zhang, RobinX > ; > Yang, MurphyX > Subject: [PATCH v2] net/ixgbe: fix RSS RETA be reset after port start > > If one calls

[dpdk-dev] [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Murphy Yang
If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting the device (but after setting everything else), then RSS RETA configuration be zero after starting the device. This patch gives a notification if the port not started. Bugzilla ID: 664 Fixes: 249358424eab ("ixgbe: RSS RETA conf

Re: [dpdk-dev] [PATCH] ethdev: update qfi definition

2021-03-29 Thread Ori Kam
Hi > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition > > On 3/23/2021 12:11 PM, Raslan Darawsheh wrote: > > qfi field is 8 bits which represent single bit for > > PPP (paging Policy Presence) single bit for RQI > >

Re: [dpdk-dev] [PATCH] ethdev: update qfi definition

2021-03-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ori Kam > Sent: Monday, March 29, 2021 11:53 AM > To: Ferruh Yigit ; Raslan Darawsheh > ; dev@dpdk.org; Andrew Rybchenko > ; Ivan Malov > Cc: Slava Ovsiienko ; Shiri Kuzin > ; ying.a.w...@intel.com; sta...@dpdk.org; NBU- > Contact-Thomas Monjalon ; Olivie

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Ori Kam
Hi All, > -Original Message- > From: Matan Azrad > Subject: RE: [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API > > Hi Cristian > > Thank you for your important review! > I agree with all your comments except one, please see inline. > > From: Dumitrescu, Cristian > > Hi Li

Re: [dpdk-dev] [PATCH v2 3/4] app/test-regex: support scattered mbuf input

2021-03-29 Thread Ori Kam
Hi Mou, > -Original Message- > From: Suanming Mou > > This commits adds the scattered mbuf input support. > > Signed-off-by: Suanming Mou > --- > app/test-regex/main.c | 134 ++ > 1 file changed, 109 insertions(+), 25 deletions(-) > Acked-by:

Re: [dpdk-dev] [PATCH v2 1/4] common/mlx5: add user memory registration bits

2021-03-29 Thread Ori Kam
Hi, > -Original Message- > From: Suanming Mou > This commit adds the UMR capability bits. > > Signed-off-by: Suanming Mou > --- > drivers/common/mlx5/linux/meson.build | 2 ++ > drivers/common/mlx5/mlx5_devx_cmds.c | 5 + > drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ > 3 files

Re: [dpdk-dev] [PATCH v2 2/4] regex/mlx5: add data path scattered mbuf process

2021-03-29 Thread Ori Kam
Hi Mou, PSB one small comment, Please update and feel free to add my ack. > -Original Message- > From: Suanming Mou > > UMR WQE can convert multiple mkey's memory sapce to contiguous space. > Take advantage of the UMR WQE, scattered mbuf in one operation can be > converted to an indirec

Re: [dpdk-dev] [PATCH v2 4/4] regex/mlx5: prevent wrong calculation of free sqs in umr mode

2021-03-29 Thread Ori Kam
Hi > -Original Message- > From: Suanming Mou > > From: John Hurley > > A recent change adds support for scattered mbuf and UMR support for regex. > Part of this commit makes the pi and ci counters of the regex_sq a quarter > of the length in non umr mode, effectively moving them from 1

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-29 Thread Ferruh Yigit
On 3/26/2021 8:52 PM, Tyler Retzlaff wrote: On Fri, Mar 26, 2021 at 12:02:55PM +, Ferruh Yigit wrote: On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: 24/03/2021 12:27, Ferruh Yigit: But not sure how to manage the same problem f

Re: [dpdk-dev] [PATCH v1] net/ice: remove the redundant function type

2021-03-29 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Monday, March 29, 2021 12:56 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Haiyue > ; Yang, Qiming > Subject: [PATCH v1] net/ice: remove the redundant function type > > The function 'ice_is_profile_rule' is defined as 'ice_is_prof_ru

Re: [dpdk-dev] [PATCH v2 2/4] regex/mlx5: add data path scattered mbuf process

2021-03-29 Thread Suanming Mou
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Monday, March 29, 2021 5:35 PM > To: Suanming Mou > Cc: dev@dpdk.org; Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: RE: [PATCH v2 2/4] regex/mlx5: add data path scattered mbuf process > > Hi Mou, > > PSB one small co

[dpdk-dev] [Bug 668] DPDK power governor fails if base_frequency is not opened

2021-03-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=668 Bug ID: 668 Summary: DPDK power governor fails if base_frequency is not opened Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v3 0/6] net: ngbe PMD

2021-03-29 Thread Jiawen Wu
Hi, > -Original Message- > From: Jiawen Wu > Sent: Tuesday, March 23, 2021 10:20 AM > To: dev@dpdk.org > Cc: Jiawen Wu > Subject: [PATCH v3 0/6] net: ngbe PMD > > This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun > WX1860 series NICs. > > v3: > - Use rte_ether fu

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Jerin Jacob
On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very limited. > In addition, the policy cannot be pre-defined. > > Due to the growing in flow actions offload abilities th

[dpdk-dev] [PATCH v4] build: alias default build as generic

2021-03-29 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

Re: [dpdk-dev] [PATCH v4 0/3] vhost: make virtqueue cache-friendly

2021-03-29 Thread Balazs Nemeth
On Tue, 2021-03-23 at 11:30 +0100, David Marchand wrote: > On Tue, Mar 23, 2021 at 10:02 AM Maxime Coquelin > wrote: > > > > As done for Virtio PMD, this series improves cache utilization > > of the vhost_virtqueue struct by removing unused field, > > make the live-migration cache dynamically all

Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: make virtqueue struct cache-friendly

2021-03-29 Thread Balazs Nemeth
On Tue, 2021-03-16 at 10:38 +0100, Maxime Coquelin wrote: > This series optimizes the cache usage of virtqueue struct, > by making a "fake" mbuf being dynamically allocated in Rx > virtnet struct, by removing a useless virtuque pointer > into the virtnet structs and by moving a few fields > to pack

[dpdk-dev] [PATCH v3] build: add platform meson option

2021-03-29 Thread Juraj Linkeš
The current meson option 'machine' should only specify the ISA, which is not sufficient for Arm, where setting ISA implies other setting as well. Add a new meson option, 'platform', which differentiates the type of the build (native/generic) and sets machine accordingly, unless the user chooses to

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic: fix coredump when PMD used by fstack

2021-03-29 Thread Zhou Guoyang
在 2021/3/23 1:17, Ferruh Yigit 写道: > On 3/15/2021 8:14 AM, Guoyang Zhou wrote: >> The fstack will use secondary process to access the memory of >> eth_dev_ops , and it wants to get the info of dev, but hinic >> driver does not initialized it when in secondary process. >> > > I guess the issue is n

Re: [dpdk-dev] [PATCH] ethdev: update qfi definition

2021-03-29 Thread Ferruh Yigit
On 3/29/2021 10:06 AM, Raslan Darawsheh wrote: Hi, -Original Message- From: Ori Kam Sent: Monday, March 29, 2021 11:53 AM To: Ferruh Yigit ; Raslan Darawsheh ; dev@dpdk.org; Andrew Rybchenko ; Ivan Malov Cc: Slava Ovsiienko ; Shiri Kuzin ; ying.a.w...@intel.com; sta...@dpdk.org; NBU-

Re: [dpdk-dev] Questions about reporting auto-negotiation capability

2021-03-29 Thread Huisong Li
在 2021/3/29 15:19, Thomas Monjalon 写道: 29/03/2021 09:03, Thomas Monjalon: 29/03/2021 06:02, Huisong Li: 'speed_capa' in struct rte_eth_dev_info is defined as follows: uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ Most PMD drivers use this field

[dpdk-dev] rte_flow ageing

2021-03-29 Thread David Bouyeure
Hi, I've found out the pretty useful experimental brand new flow ageing API implemented in the mlx5 PMD. I'm trying it (rte_eth_dev_callback_register(RTE_ETH_EVENT_FLOW_AGED), RTE_FLOW_ACTION_TYPE_AGE) to recover any flow that I previously offloaded. The DPDK version is 20.08 and Mellanox(

Re: [dpdk-dev] Questions about reporting auto-negotiation capability

2021-03-29 Thread Thomas Monjalon
29/03/2021 13:44, Huisong Li: > > 在 2021/3/29 15:19, Thomas Monjalon 写道: > > 29/03/2021 09:03, Thomas Monjalon: > >> 29/03/2021 06:02, Huisong Li: > >>> 'speed_capa' in struct rte_eth_dev_info is defined as follows: > >>> > >>> uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK

Re: [dpdk-dev] [EXTERNAL] Re: Handling missing export functions in MSVC linkage

2021-03-29 Thread Tyler Retzlaff
Unless I misunderstood the last status of this issue was that it was desired empty stubs that fail at runtime as opposed to conditionally generating exports. Is this no longer the case? -Original Message- From: Thomas Monjalon Sent: Friday, March 26, 2021 1:40 AM To: Dmitry Kozlyuk ; r

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-29 Thread Thomas Monjalon
29/03/2021 11:43, Ferruh Yigit: > On 3/26/2021 8:52 PM, Tyler Retzlaff wrote: > > On Fri, Mar 26, 2021 at 12:02:55PM +, Ferruh Yigit wrote: > >> On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: > >>> On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: > 24/03/2021 12:27, Ferruh Yig

Re: [dpdk-dev] [PATCH v2] vhost: add support for packed ring in async vhost

2021-03-29 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Liu, Yong > Sent: Wednesday, March 24, 2021 5:19 PM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com; > Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Jiang, > Cheng1 > Subject: RE: [dpdk-dev] [PATCH v2] vhost: add support fo

Re: [dpdk-dev] rte_flow ageing

2021-03-29 Thread David Bouyeure
Sorry for the below topic confusion(in-reply-to). On 3/29/21 9:50 AM, David Bouyeure wrote: Hi, I've found out the pretty useful experimental brand new flow ageing API implemented in the mlx5 PMD. I'm trying it (rte_eth_dev_callback_register(RTE_ETH_EVENT_FLOW_AGED), RTE_FLOW_ACTION_TYPE_A

[dpdk-dev] rte_flow ageing

2021-03-29 Thread David Bouyeure
Hi, I've found out the pretty useful experimental brand new flow ageing API implemented in the mlx5 PMD. I'm trying it (rte_eth_dev_callback_register(RTE_ETH_EVENT_FLOW_AGED), RTE_FLOW_ACTION_TYPE_AGE) to recover any flow that I previously offloaded. The DPDK version is 20.08 and Mellanox(

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Wang, Haiyue
> -Original Message- > From: Yang, MurphyX > Sent: Monday, March 29, 2021 16:29 > To: dev@dpdk.org > Cc: Yang, Qiming ; Wang, Haiyue > ; Guo, Jia > ; Yang, SteveX ; Zhang, RobinX > ; > Yang, MurphyX > Subject: [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start > > If one call

[dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-29 Thread Juraj Linkeš
The current meson option 'machine' should only specify the ISA, which is not sufficient for Arm, where setting ISA implies other setting as well. Add a new meson option, 'platform', which differentiates the type of the build (native/generic) and sets machine accordingly, unless the user chooses to

[dpdk-dev] [PATCH 0/8] ice: base code update batch 2

2021-03-29 Thread Qi Zhang
Qi Zhang (8): net/ice/base: code cleanup net/ice/base: support removing VSI from flow profile net/ice/base: print link configure error net/ice/base: remove unused ptype field in PTT definition net/ice/base: set MAC type for E823C device net/ice/base: change protocol ID for VLAN in case

[dpdk-dev] [PATCH 1/8] net/ice/base: code cleanup

2021-03-29 Thread Qi Zhang
1. There are a lots of function header mismatch its function name. 2. remove unnecessary header file include. 3. remove unnecessary macro. 4. remove unnecessary comment. Signed-off-by: Dave Ertman Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 4 ++-- drivers/net/ice/base/i

[dpdk-dev] [PATCH 2/8] net/ice/base: support removing VSI from flow profile

2021-03-29 Thread Qi Zhang
Adding a function ice_flow_rem_vsi_prof() to remove flow entries associated to the sw vsi handle. Once complete clear the vsi index from the flow profile bitmap. This will ensure that the a vsi once removed can be re-added and the package block rules will be added again. Signed-off-by: Vignesh Sri

[dpdk-dev] [PATCH 3/8] net/ice/base: print link configure error

2021-03-29 Thread Qi Zhang
Newer NVMs return link_cfg_err for get_link_status AQ. Print it for debug use. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_co

[dpdk-dev] [PATCH 4/8] net/ice/base: remove unused ptype field in PTT definition

2021-03-29 Thread Qi Zhang
Remove the unused ptype entry, and use the gcc extension for ranged initializers in arrays for Linux, and explicitly target each table entry by index when initializing under Linux. Signed-off-by: Jesse Brandeburg Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_lan_tx_rx.h | 10 --

[dpdk-dev] [PATCH 5/8] net/ice/base: set MAC type for E823C device

2021-03-29 Thread Qi Zhang
Set E823C device's MAC type as generic. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 5c21d71b70..356a8b4d0

[dpdk-dev] [PATCH 6/8] net/ice/base: change protocol ID for VLAN in case of DVM

2021-03-29 Thread Qi Zhang
Protocol id for first vlan in Double VLAN Mode (DVM) should be ICE_VLAN_OF_HW = 16, but for Single VLAN Mode (SVM) this should be ICE_VLAN_OL_HW = 17. Change protocol id in type to id translation array for outer vlan to 17 when DVM is enabled, which means the driver, package, and firmware support

[dpdk-dev] [PATCH 7/8] net/ice/base: enable I2C read/write commands

2021-03-29 Thread Qi Zhang
Enable I2C read/write AQ commands. They are now required for controlling the external physical connectors via external I2C port expander on E810-T adapters. Signed-off-by: Maciej Machnikowski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 29 + drivers/net/ice/base/

[dpdk-dev] [PATCH 8/8] net/ice/base: add RSS support for PPPoL2TPv2oUDP

2021-03-29 Thread Qi Zhang
Add support for PPPoL2TPv2oUDP RSS hash. L2TPv2 and PPP ptypes and flow headers are added. Prot id for PPP is added. Signed-off-by: Ting Xu Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 65 ++-- drivers/net/ice/base/ice_flow.h | 2 + driver

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve interrupt management

2021-03-29 Thread Maxime Coquelin
On 3/18/21 10:13 AM, Matan Azrad wrote: > The driver should notify the guest for each traffic burst detected by CQ > polling. > > The CQ polling trigger is defined by `event_mode` device argument, > either by busy polling on all the CQs or by blocked call to HW > completion event using DevX cha

[dpdk-dev] [PATCH v5 1/3] kni: refactor user request processing

2021-03-29 Thread Ferruh Yigit
From: Elad Nachman Refactor the parameter kni_net_process_request() gets, this is preparation for addressing a user request processing deadlock problem. Signed-off-by: Stephen Hemminger Signed-off-by: Elad Nachman --- kernel/linux/kni/kni_net.c | 25 + 1 file changed,

[dpdk-dev] [PATCH v5 2/3] kni: support async user request

2021-03-29 Thread Ferruh Yigit
Adding async userspace requests which don't wait for the userspace response and always return success. This is preparation to address a regression in KNI. Signed-off-by: Elad Nachman Signed-off-by: Ferruh Yigit --- kernel/linux/kni/kni_net.c | 9 + lib/librte_kni/rte_kni.c|

[dpdk-dev] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-03-29 Thread Ferruh Yigit
KNI runs userspace callback with rtnl lock held, this is not working fine with some devices that needs to interact with kernel interface in the callback, like Mellanox devices. The solution is releasing the rtnl lock before calling the userspace callback. But it requires two consideration: 1. The

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-29 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Friday, March 26, 2021 9:33 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > Harry ; Ray Kinsella ; Neil > Horman ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Pavan Nikhilesh > ; Hemant Agrawal ; >

Re: [dpdk-dev] [PATCH 2/4] vhost: remove unnecessary free

2021-03-29 Thread Maxime Coquelin
On 3/17/21 1:56 PM, Jiayu Hu wrote: > This patch removes unnecessary rte_free() for async_pkts_info > and async_descs_split. > > Signed-off-by: Jiayu Hu > --- > lib/librte_vhost/vhost_user.c | 7 --- > 1 file changed, 7 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime

[dpdk-dev] [PATCH v2 0/2] Enhancements to crypto adapter forward mode

2021-03-29 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes for the usage of new API is yet to add. v2: - Updated release notes. - Made use of RTE_EVENTDEV_VALID

[dpdk-dev] [PATCH v2 1/2] eventdev: introduce crypto adapter enqueue API

2021-03-29 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v2 2/2] event/octeontx2: support crypto adapter forward mode

2021-03-29 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 42 ++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr

Re: [dpdk-dev] [PATCH 3/4] vhost: avoid deadlock on async register

2021-03-29 Thread Maxime Coquelin
On 3/17/21 1:56 PM, Jiayu Hu wrote: > Users register async copy device when vhost queue is enabled. > However, if VHOST_USER_F_PROTOCOL_FEATURES is not supported, > a deadlock occurs inside rte_vhost_async_channel_register(), > as vhost_user_msg_handler() already takes vq->access_lock > before p

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-29 Thread Ferruh Yigit
On 3/29/2021 1:10 PM, Thomas Monjalon wrote: 29/03/2021 11:43, Ferruh Yigit: On 3/26/2021 8:52 PM, Tyler Retzlaff wrote: On Fri, Mar 26, 2021 at 12:02:55PM +, Ferruh Yigit wrote: On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH v4 6/6] net/txgbe: add FFE parameters for user debugging

2021-03-29 Thread Ferruh Yigit
On 3/29/2021 4:17 AM, Jiawen Wu wrote: Support to set PHY link mode by user defined. And update release notes 21.05 for txgbe. During merge, release notes update moved to 3/6 where looks more appropriate, since this patch adds FFE parameters but note is about AN training. But please let me k

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-29 Thread Jerin Jacob
On Mon, Mar 29, 2021 at 8:30 PM McDaniel, Timothy wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, March 26, 2021 9:33 AM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > > Harry ; Ray Kinsella ; Neil > > Horman ; Rao, Nikhil ; > > Carri

Re: [dpdk-dev] [PATCH v4 0/6] txgbe backplane AN training

2021-03-29 Thread Ferruh Yigit
On 3/29/2021 4:17 AM, Jiawen Wu wrote: This series update link process for backplane NICs. And support to control AN training. v4: - Convert BP_LOG to dynamic log. v3: - Add devargs gradually in the patches they are used. - Update 21.05 relaese notes. v2: - Convert compile time flags to runtime

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-29 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Monday, March 29, 2021 10:51 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > Harry ; Ray Kinsella ; Neil > Horman ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Pavan Nikhilesh > ; Hemant Agrawal ; >

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Thursday, March 25, 2021 6:57 AM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andr

Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-29 Thread Ferruh Yigit
On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: From: Huisong Li The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. However, the modification in the SVE algorithm is omitted. As a result, the driver fails to be compiled when the SVE algorithm is used. Fixes: 9b77f1fe303f ("net/hns3

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Dumitrescu, Cristian
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Monday, March 29, 2021 10:23 AM > To: Matan Azrad ; Dumitrescu, Cristian > ; Li Zhang ; Dekel Peled > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andrew

[dpdk-dev] [PATCH] doc: remove obsolete future considerations in flow guide

2021-03-29 Thread Thomas Monjalon
After 4 years, rte_flow has evolved enough to not require special notes about what could be added in future. Part of the removed plans were obsolete anyway. Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/rte_flow.rst | 38 +- 1 file changed, 1 insertion(+),

Re: [dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-29 Thread Stephen Hemminger
On Mon, 29 Mar 2021 03:14:29 + Honnappa Nagarahalli wrote: > > > > Subject: [PATCH v3] pflock: implementation of phase-fair reader writer locks > > > > This is a new type of reader-writer lock that provides better fairness > > guarantees which makes it better for typical DPDK applications.

Re: [dpdk-dev] rte_flow ageing

2021-03-29 Thread Asaf Penso
Hello David, Thanks for reaching out, I'll try to answer as best as I know and I added Matan who will be able to provide further info during next week. First, according to our pmd documentation (http://doc.dpdk.org/guides/nics/mlx5.html#supported-hardware-offloads) we recommend using DPDK20.11

Re: [dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-29 Thread Honnappa Nagarahalli
> > > > > Subject: [PATCH v3] pflock: implementation of phase-fair reader > > > writer locks > > > > > > This is a new type of reader-writer lock that provides better > > > fairness guarantees which makes it better for typical DPDK applications. > > > They lock internally uses two ticket pools, o

Re: [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability

2021-03-29 Thread Ajit Khaparde
On Mon, Mar 29, 2021 at 12:29 AM Thomas Monjalon wrote: > > The flag ETH_LINK_SPEED_AUTONEG is 0, > so it cannot be used in a capability bitmap. > > Having 0 in speed capability means all speeds are accepted. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/bnxt/bnxt_ethdev.c | 2

Re: [dpdk-dev] Questions about reporting auto-negotiation capability

2021-03-29 Thread Ajit Khaparde
On Mon, Mar 29, 2021 at 12:19 AM Thomas Monjalon wrote: > > 29/03/2021 09:03, Thomas Monjalon: > > 29/03/2021 06:02, Huisong Li: > > > 'speed_capa' in struct rte_eth_dev_info is defined as follows: > > > > > > uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ > > >

Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-29 Thread Aaron Conole
Ferruh Yigit writes: > On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: >> From: Huisong Li >> >> The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. >> However, the modification in the SVE algorithm is omitted. >> As a result, the driver fails to be compiled when the SVE >> algorithm

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-29 Thread Thomas Monjalon
29/03/2021 17:23, Ferruh Yigit: > On 3/29/2021 1:10 PM, Thomas Monjalon wrote: > > 29/03/2021 11:43, Ferruh Yigit: > >> On 3/26/2021 8:52 PM, Tyler Retzlaff wrote: > >>> On Fri, Mar 26, 2021 at 12:02:55PM +, Ferruh Yigit wrote: > On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: > > On Wed,

Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-29 Thread David Marchand
On Mon, Mar 29, 2021 at 8:32 PM Aaron Conole wrote: > Ferruh Yigit writes: > > This is a very obvious build error, I am concerned how this is > > released. Do you have any internal testing? > > > > + Aaron & Honnappa, > > > > If we can have a build test in our public CI with SVE? > > Maybe it's p

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

2021-03-29 Thread Matan Azrad
Hi Ajit Looks like you agree with this RFC to move meter objects to be managed by PMD pointers. Thanks for the review! From: Ajit Khaparde > On Thu, Mar 25, 2021 at 1:21 AM Matan Azrad wrote: > > > > Hi Cristian > > > > From: Dumitrescu, Cristian > > > Hi Li and Matan, > > > > > > > -Origi

Re: [dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-29 Thread Stephen Hemminger
Meta question: is implementing trylock worth it? The original did not have it. There are tradeoffs about number of readers and added complexity in the code? > > diff --git a/lib/librte_eal/include/generic/rte_pflock.h > > b/lib/librte_eal/include/generic/rte_pflock.h > > new file mode 100644 > >

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

2021-03-29 Thread Matan Azrad
Hi Jerin Thanks for the review. PSB From: Jerin Jacob > On Thu, Mar 25, 2021 at 1:51 PM Matan Azrad wrote: > > > > Hi Cristian > > > > From: Dumitrescu, Cristian > > > Hi Li and Matan, > > > > > > > -Original Message- > > > > From: Li Zhang > > > > Sent: Thursday, March 18, 2021 8:58 AM

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Matan Azrad
Hi Jerin Thanks for the review. PSB From: Jerin Jacob > On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > > > Currently, the flow meter policy does not support multiple actions per > > color; also the allowed action types per color are very limited. > > In addition, the policy cannot be pre-de

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Matan Azrad
From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Thursday, March 25, 2021 6:57 AM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko ; Shahaf > > Shuler ; lir...@marvell.com; Singh, Jasvinder > > ; NBU

Re: [dpdk-dev] [PATCH 1/2] timer: clarify subsystem_init return value

2021-03-29 Thread Carrillo, Erik G
> -Original Message- > From: Michal Krawczyk > Sent: Friday, March 26, 2021 5:48 AM > To: dev@dpdk.org; Robert Sanford ; Carrillo, Erik G > > Cc: Stanislaw Kardach ; Michal Krawczyk > > Subject: [PATCH 1/2] timer: clarify subsystem_init return value > > From: Stanislaw Kardach > > rte

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations

2021-03-29 Thread Matan Azrad
From: Thomas Monjalon > Since rte_flow is the only API for filtering operations, > the legacy driver interface filter_ctrl was too much complicated > for the simple task of getting the struct rte_flow_ops. > > The filter type RTE_ETH_FILTER_GENERIC and > the filter operarion RTE_ETH_FILTER_GET

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix shared inner RSS

2021-03-29 Thread Matan Azrad
From: Xiaoyu Min > The shared RSS action use the _tunnel_ information which is derived from flow > items to decide whether need to do inner RSS or not. > However, inner RSS should be decided by RSS level (>1) in configuration and > then to create TIR with 'IBV_RX_HASH_INNER' hash bit set. > > A

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing shared RSS hash types

2021-03-29 Thread Matan Azrad
From: Xiaoyu Min > Shared RSS action create all supported RSS hash combination in advance and > lookup the right hash TIR when flow is actually applied by comparing hash > field > value. > > Unfortunately some hash combination is missed, for example, UDP/TCP dest > port only, L3-src-only, etc.

Re: [dpdk-dev] [PATCH v2 1/8] bus/vdev: add DMA mapping ops

2021-03-29 Thread Thomas Monjalon
25/09/2020 14:31, Maxime Coquelin: > Add DMA map/unmap operation callbacks to the vdev bus, which > could be used by DMA capable vdev drivers. [...] > @@ -551,6 +601,8 @@ static struct rte_bus rte_vdev_bus = { > .plug = vdev_plug, > .unplug = vdev_unplug, > .parse = vdev_parse, >

Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-29 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm > > On Mon, Mar 29, 2021 at 8:32 PM Aaron Conole > wrote: > > Ferruh Yigit writes: > > > This is a very obvious build error, I am concerned how this is > > > released. Do you have any internal testing? > > > > > >

[dpdk-dev] [PATCH v5 02/10] eal: add thread attributes

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 53 lib/librte_eal/include/rte_thread.h | 82 +

[dpdk-dev] [PATCH v5 00/10] eal: Add new API for threading

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

[dpdk-dev] [PATCH v5 01/10] eal: add thread id and simple thread functions

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add the thread identifier type. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 101 ++ lib/librte_eal/include/rte_thread.h

[dpdk-dev] [PATCH v5 04/10] eal: implement functions for thread affinity management

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/rte_thread.c | 13 ++ lib/librte_eal/include/rte_thread.h | 41 +++ lib/librte_eal/windows/eal_lcore.c | 170 ++

[dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/windows/rte_thread.c | 65 ++--- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/lib/librte_eal/windows/rte_th

[dpdk-dev] [PATCH v5 06/10] eal: add thread lifetime management

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for thread creation, join, canceling. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 110 lib/librte_eal/include/rte_thread.h | 53 lib/librte_eal/windows/rte_thread.c | 125 ++

[dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can select the thread priority to be either 'normal' or 'critical': --thread-prio normal --thread-prio realtime Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_o

[dpdk-dev] [PATCH v5 08/10] eal: implement functions for thread barrier management

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 16 +++ lib/librte_eal/include/rte_thread.h | 46 +++ lib/librte_eal/include/rte_thread_types.h | 2 + .../in

[dpdk-dev] [PATCH v5 07/10] eal: implement functions for mutex management

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 24 + lib/librte_eal/include/rte_thread.h | 53 +++ lib/librte_eal/include/rte_thread_types.h | 3 +

[dpdk-dev] [PATCH v5 05/10] eal: implement thread priority management functions

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 25 ++ lib/librte_eal/include/rte_thread.h | 17 +++ lib/librte_eal/windows/rte_thread.c | 76 + 3 files chan

Re: [dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-29 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH v3] pflock: implementation of phase-fair reader writer > locks > > Meta question: is implementing trylock worth it? > The original did not have it. If there is no use for it currently, I suggest not to add. If someone sees a need, they can always add. I am ok if you add a

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-03-29 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > The blocklist is, I think, agreed upon by everyone. > > > > > > > > > > The question is whether we want to support the > > > > > > > > > > allowlist alongside it and there seem to be enough reasons > > > > > > > > > > to do > that. > > > > > > > > > Sorry, may be thi

  1   2   >