Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-24 Thread Jerin Jacob
On Wed, Jun 23, 2021 at 9:20 AM fengchengwen wrote: > > >> > >> So I prefer following prototype: > >> uint16_t rte_dmadev_completed(uint16_t dev_id, dma_cookie_t *cookie, > >> uint16_t nb_cpls, bool *has_error) > >> -- nb_cpls: indicate max process operations number > >> -- has_error:

[dpdk-dev] [PATCH] net/i40e: fix FDIR input set conflict issue

2021-06-24 Thread beilei . xing
From: Beilei Xing Currently, there'll be conflict error when running the folowing commands: 1. flow create 0 ingress pattern eth / ipv4 / udp src is 32 / end actions queue index 2 / end 2. flow destroy 0 rule 0 3. flow create 0 ingress pattern eth / ipv4 / udp dst is 32 / end

[dpdk-dev] [PATCH v2] net/i40e: fix FDIR input set conflict issue

2021-06-24 Thread beilei . xing
From: Beilei Xing Currently, there'll be conflict error when running the following commands: 1. flow create 0 ingress pattern eth / ipv4 / udp src is 32 / end actions queue index 2 / end 2. flow destroy 0 rule 0 3. flow create 0 ingress pattern eth / ipv4 / udp dst is 32 / end

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-24 Thread Thomas Monjalon
24/06/2021 03:55, Ajit Khaparde: > On Tue, Jun 22, 2021 at 5:44 AM wangyunjian wrote: > > > > From: Yunjian Wang > > > > In kni_allocate_mbufs(), we alloc mbuf for alloc_q as this code. > > allocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1) \ > > & (MAX_MBUF_BURST_NUM -

Re: [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch

2021-06-24 Thread Thomas Monjalon
Waiting for review 23/04/2021 10:12, Min Hu (Connor): > From: Chengwen Feng > > Some drivers may return errcode when switch allmulticast mode, so it's > necessary to check the return code. > > Fixes: b34801d1aa2e ("kni: support allmulticast mode set") > Cc: sta...@dpdk.org > > Signed-off-by: C

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix crash on userspace VA for segmented packets

2021-06-24 Thread Thomas Monjalon
24/06/2021 03:57, Ajit Khaparde: > On Tue, Jun 22, 2021 at 5:39 AM Ferruh Yigit wrote: > > > > When IOVA=VA, address translation for segmented packets is wrong, it > > assumes the address in the mbuf->next is physical address, not VA > > address. > > > > Fixing the address translation to work both

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-24 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Thursday, 24 June 2021 09.03 > > On Wed, Jun 23, 2021 at 9:20 AM fengchengwen > wrote: > > > > > > > > > prototype like the following works for us: > > > rte_dmadev_enq_sg(void **src, void **dest, unsigned int **length, >

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-24 Thread Jerin Jacob
On Thu, Jun 24, 2021 at 1:29 PM Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Thursday, 24 June 2021 09.03 > > > > On Wed, Jun 23, 2021 at 9:20 AM fengchengwen > > wrote: > > > > > > > > > > > > > prototype like the following works for us:

Re: [dpdk-dev] [PATCH] doc: note KNI alternatives and deprecation plan

2021-06-24 Thread Ferruh Yigit
On 6/23/2021 7:33 PM, Stephen Hemminger wrote: > On Wed, 23 Jun 2021 18:31:42 +0100 > Ferruh Yigit wrote: > >> Add a note that KNI kernel module will be moved to dpdk-kmods git repo >> and there is a long term plan to deprecate it. >> >> Also add some more details on the alternatives to KNI and c

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-24 Thread Xueming(Steven) Li
Thanks for clarification, will update in next version. From: Thomas Monjalon Sent: Thursday, June 24, 2021 2:37:19 PM To: Xueming(Steven) Li Cc: Parav Pandit ; dev@dpdk.org ; Wang Haiyue ; Kinsella Ray ; david.march...@redhat.com ; ferruh.yi...@intel.com Subje

Re: [dpdk-dev] [PATCH v2] flow_classify: fix leaking rules on delete

2021-06-24 Thread Iremonger, Bernard
Hi Owen, > -Original Message- > From: ohily...@iol.unh.edu > Sent: Wednesday, June 23, 2021 6:07 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org; david.march...@redhat.com; Owen Hilyard > > Subject: [PATCH v2] flow_classify: fix leaking rules on delete > > From: Owen Hilyard > > Rules

Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit

2021-06-24 Thread Shiri Kuzin
This patch will be removed for now until FW support is fully done and be added when the support is completed. Regards, Shiri > -Original Message- > From: Raslan Darawsheh > Sent: Sunday, June 6, 2021 2:32 PM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...

Re: [dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow

2021-06-24 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 21/06/2021 16:28, ohily...@iol.unh.edu wrote: From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the

Re: [dpdk-dev] [PATCH v2] flow_classify: fix leaking rules on delete

2021-06-24 Thread David Marchand
On Thu, Jun 24, 2021 at 10:43 AM Iremonger, Bernard wrote: > > -Original Message- > > From: ohily...@iol.unh.edu > > Sent: Wednesday, June 23, 2021 6:07 PM > > To: Iremonger, Bernard > > Cc: dev@dpdk.org; david.march...@redhat.com; Owen Hilyard > > > > Subject: [PATCH v2] flow_classify:

Re: [dpdk-dev] [PATCH v2] net/i40e: fix FDIR input set conflict issue

2021-06-24 Thread Chen, LingliX
> -Original Message- > From: dev On Behalf Of beilei.x...@intel.com > Sent: Thursday, June 24, 2021 3:30 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix FDIR input set conflict issue > > From: Beilei Xing > > Curr

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Ananyev, Konstantin
> >>> > Previously, the semantics of power monitor were such that we were > checking current value against the expected value, and if they > matched, > then the sleep was aborted. This is somewhat inflexible, because it > only > allowed u

Re: [dpdk-dev] [PATCH v5 1/2] devargs: add common key definition

2021-06-24 Thread Thomas Monjalon
23/06/2021 02:03, Xueming Li: > Adds common devargs key definition for "bus", "class" and "driver". > > Cc: Thomas Monjalon > Signed-off-by: Xueming Li Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library

2021-06-24 Thread Slava Ovsiienko
Hi, David Thank you for the review and comments. What do you think about the commit message like this? common/mlx5: fix rdma-core v35 query port API support The rdma-core mlx5 provider introduced the port attributes query API since version v35.0 - the mlx5dv_query_port routine. In order to suppo

[dpdk-dev] Experimental symbols in security lib

2021-06-24 Thread Kinsella, Ray
Hi Declan and Goyal, The following security experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_security_get_userd

[dpdk-dev] Experimental symbols in net lib

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following net experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_net_make_rarp_packet * rte_net_s

[dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

2021-06-24 Thread Akhil Goyal
From: Nithin Dabilpuram For Tx inline processing, when RTE_SECURITY_TX_OLOAD_NEED_MDATA is set, rte_security_set_pkt_metadata() needs to be called for pkts to associate a Security session with a mbuf before submitting to Ethdev Tx. This is apart from setting PKT_TX_SEC_OFFLOAD in mbuf.ol_flags. r

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: modify event mode inline path

2021-06-24 Thread Akhil Goyal
From: Nithin Dabilpuram Align event mode path for Tx inline IPsec processing to adhere to security spec. Call rte_security_set_pkt_metadata() only with mbuf containing L3 header and above. Also update mbuf.l2_len with L2 header size. This patch also fixes a bug in arg parsing. Signed-off-by: Ni

[dpdk-dev] Experimental symbols in mbuf lib

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following mbuf experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mbuf_check * rte_mbuf_dynfield_

[dpdk-dev] Experimental symbols in vhost lib

2021-06-24 Thread Kinsella, Ray
Hi Maxime and Chenbo, The following vhost experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_vhost_driver_get_pro

[dpdk-dev] Experimental symbols in flow_classify lib

2021-06-24 Thread Kinsella, Ray
Hi Bernard, The following flow_classify experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_flow_classifier_create

[dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread Kinsella, Ray
Hi Anatoly & Thomas, The following eal experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mp_action_register * r

[dpdk-dev] Experimental symbols in port lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian The following port experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_port_eventdev_writer_nodrop_ops

[dpdk-dev] Experimental symbols in compressdev lib

2021-06-24 Thread Kinsella, Ray
Hi Fiona & Ashish, The following compressdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_compressdev_capabi

[dpdk-dev] Experimental symbols in sched lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian & Jasvinder, The following sched experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_sched_subport_pipe

[dpdk-dev] Experimental symbols in cryptodev lib

2021-06-24 Thread Kinsella, Ray
Hi Declan, The following cryptodev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_cryptodev_asym_capability_ge

[dpdk-dev] Experimental symbols in rib lib

2021-06-24 Thread Kinsella, Ray
Hi Vladimir The following rib experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_rib_create, * rte_rib_find_existin

[dpdk-dev] Experimental symbols in pipeline lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian, The following pipeline experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_port_in_action_create * rte_

[dpdk-dev] Experimental symbols in ip_frag

2021-06-24 Thread Kinsella, Ray
Hi Konstantin The following ip_frag experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_frag_table_del_expired_entri

[dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Kinsella, Ray
Hi Nicolas The following bbdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_bbdev_allocate * rte_bbdev_callba

[dpdk-dev] Experimental Symbols in ethdev lib

2021-06-24 Thread Kinsella, Ray
Hi Thomas, Ferruh and Andrew, The following ethdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mtr_capabili

[dpdk-dev] Experimental Symbols in kvargs

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following kvargs experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_kvargs_parse_delim * rte_kvargs_

[dpdk-dev] Experimental symbols in power lib

2021-06-24 Thread Kinsella, Ray
Hi David, The following power experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_empty_poll_detection * rte_power

[dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Kinsella, Ray
Hi Ferruh, The following kni experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_kni_update_link Ray K

[dpdk-dev] Experimental symbols in metrics lib

2021-06-24 Thread Kinsella, Ray
Hi Thomas, The following metrics experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_metrics_deinit Ray K

[dpdk-dev] Experimental symbols in fib lib

2021-06-24 Thread Kinsella, Ray
Hi Vladimir, The following fib experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_fib_add * rte_fib_create * rt

Re: [dpdk-dev] Experimental symbols in hash lib

2021-06-24 Thread Kinsella, Ray
+ dpdk dev (missed the dev list the first time, apologies). On 24/06/2021 11:41, Kinsella, Ray wrote: > Hi Yipeng, Sameh, Bruce and Vladimir, > > The following hash experimental symbols are present in both v21.05 and v19.11 > release. These symbols should be considered for promotion to stable

Re: [dpdk-dev] [PATCH v4 4/7] vhost: fix NUMA reallocation with multiqueue

2021-06-24 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 18, 2021 4:48 PM > To: Xia, Chenbo ; dev@dpdk.org; > david.march...@redhat.com > Cc: sta...@dpdk.org > Subject: Re: [PATCH v4 4/7] vhost: fix NUMA reallocation with multiqueue > > > > On 6/18/21 10:21 AM, Xia,

Re: [dpdk-dev] Experimental symbols in security lib

2021-06-24 Thread Kinsella, Ray
(correcting Goyals address, apologies for the resend) On 24/06/2021 11:28, Kinsella, Ray wrote: > Hi Declan and Goyal, > > The following security experimental symbols are present in both v21.05 and > v19.11 release. These symbols should be considered for promotion to stable as > part of the

[dpdk-dev] [Bug 747] [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1

2021-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=747 Bug ID: 747 Summary: [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1 Product: DPDK Version: 19.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] Experimental symbols in compressdev lib

2021-06-24 Thread Trahe, Fiona
Hi Ray, Sounds reasonable, however I'm not curently working on this project, so will have to leave to others to propose. Fiona > -Original Message- > From: Kinsella, Ray > Sent: Thursday, June 24, 2021 11:33 AM > To: Trahe, Fiona ; Ashish Gupta > ; Thomas > Monjalon ; Stephen Hemminge

Re: [dpdk-dev] Experimental symbols in vhost lib

2021-06-24 Thread Xia, Chenbo
Hi Ray, > -Original Message- > From: Kinsella, Ray > Sent: Thursday, June 24, 2021 6:30 PM > To: Maxime Coquelin ; Xia, Chenbo > ; Thomas Monjalon ; Stephen > Hemminger ; dpdk-dev > Subject: Experimental symbols in vhost lib > > Hi Maxime and Chenbo, > > The following vhost experimenta

Re: [dpdk-dev] 19.11.9 patches review and test

2021-06-24 Thread Yu, PingX
Hi all, Testing with dpdk v19.11.9-rc3 from Intel is almost finished, no new issue is found. Three bugs as below has been fixed in LTS19.11.9-rc3: 1) https://bugs.dpdk.org/show_bug.cgi?id=728 [dpdk-19.11.9-rc2]When compiling dpdk with make or meson under SUSE Linux Enterprise Server 15 SP2, the

Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit

2021-06-24 Thread Raslan Darawsheh
Ok dropping this patch from next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: Shiri Kuzin > Sent: Thursday, June 24, 2021 11:55 AM > To: Raslan Darawsheh ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit >

Re: [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch

2021-06-24 Thread Ferruh Yigit
On 4/23/2021 9:12 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > Some drivers may return errcode when switch allmulticast mode, so it's > necessary to check the return code. > > Fixes: b34801d1aa2e ("kni: support allmulticast mode set") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Fe

[dpdk-dev] [PATCH] test: remove hack for private header inclusion

2021-06-24 Thread David Marchand
This hack was needed with the make build system. With meson, any private header from a library is visible as long as a dependency to this library is expressed. Signed-off-by: David Marchand --- app/test/test_eal_fs.c | 3 +-- app/test/test_memzone.c| 3 ++- app/test/test_telemetr

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-06-24 Thread Havlík Martin
Dne 2021-06-23 09:04, Min Hu (Connor) napsal: 在 2021/6/22 17:25, Martin Havlik 写道: When dedicated queues are enabled, mlx5 PMD fails to install RTE Flows if the underlying ethdev is not started: bond_ethdev_8023ad_flow_set(267) - bond_ethdev_8023ad_flow_set: port not started (slave_port=0 queue

Re: [dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-24 Thread Olivier Matz
Hi Owen, One small issue remain, please see below. On Wed, Jun 23, 2021 at 02:06:45PM -0400, ohily...@iol.unh.edu wrote: > From: Owen Hilyard > > Fixes for a few memory leaks in the cmdline_autotest unit test. > > All of the leaks were related to not freeing the commandline struct > after test

Re: [dpdk-dev] [PATCH] test: remove hack for private header inclusion

2021-06-24 Thread Bruce Richardson
On Thu, Jun 24, 2021 at 01:53:19PM +0200, David Marchand wrote: > This hack was needed with the make build system. > With meson, any private header from a library is visible as long as a > dependency to this library is expressed. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread David Marchand
On Thu, Jun 24, 2021 at 12:31 PM Kinsella, Ray wrote: > > Hi Anatoly & Thomas, > > The following eal experimental symbols are present in both v21.05 and v19.11 > release. These symbols should be considered for promotion to stable as part > of the v22 ABI in DPDK 21.11, as they have been experime

Re: [dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread Kinsella, Ray
Good point, that one is very up to the lib maintainer to make that call. Ray K On 24/06/2021 13:14, David Marchand wrote: > On Thu, Jun 24, 2021 at 12:31 PM Kinsella, Ray wrote: >> >> Hi Anatoly & Thomas, >> >> The following eal experimental symbols are present in both v21.05 and v19.11 >> rele

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-24 Thread fengchengwen
OK, thank Bruce How about next week ? PS: I still working on V2 and hope it as a basis for discussion. On 2021/6/23 22:56, Bruce Richardson wrote: > This is developing into quite a long discussion with multiple threads > ongoing at the same time. Since it's getting relatively hard to follow (at >

Re: [dpdk-dev] [EXT] Re: Experimental symbols in security lib

2021-06-24 Thread Akhil Goyal
Hi Ray, > -- > (correcting Goyals address, apologies for the resend) > > On 24/06/2021 11:28, Kinsella, Ray wrote: > > Hi Declan and Goyal, > > > > The following security experimental symbols are present in both v21.05 > and v19.1

Re: [dpdk-dev] [PATCH v2] flow_classify: fix leaking rules on delete

2021-06-24 Thread David Marchand
On Wed, Jun 23, 2021 at 7:07 PM wrote: > > From: Owen Hilyard > > Rules in a classify table were not freed if the table > had a delete function. > > Fixes: be41ac2a3 ("flow_classify: introduce flow classify library") Updated sha1 to be 12 characters. Cc: sta...@dpdk.org > > Signed-off-by: Owen H

Re: [dpdk-dev] [PATCH v4] rib: fix max depth IPv6 lookup

2021-06-24 Thread David Marchand
On Wed, Jun 23, 2021 at 5:17 PM wrote: > > From: Owen Hilyard > > ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. > The fix for the stack buffer overflow was to make sure depth > was always < 128, since when depth = 128 it caused the index > into the ip address to be 16, which r

Re: [dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Ferruh Yigit
On 6/24/2021 11:42 AM, Kinsella, Ray wrote: > Hi Ferruh, > > The following kni experimental symbols are present in both v21.05 and v19.11 > release. These symbols should be considered for promotion to stable as part > of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at

Re: [dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-24 Thread David Marchand
On Thu, Jun 24, 2021 at 2:08 PM Olivier Matz wrote: > > - if (cmdline_file_new(&ctx, "prompt", "/dev/null") == NULL) { > > + cl = cmdline_file_new(&ctx, "prompt", "/dev/null"); > > + if (cl == NULL) { > > printf("Error: failed to open /dev/null for reading!"); > > +

Re: [dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-24 Thread David Marchand
On Wed, Jun 23, 2021 at 8:06 PM wrote: > > From: Owen Hilyard > > Fixes for a few memory leaks in the cmdline_autotest unit test. > > All of the leaks were related to not freeing the commandline struct > after testing had completed. > > Fixes: dbb860e03e ("cmdline: tests") Updated sha1. Cc: sta..

Re: [dpdk-dev] [PATCH] tests/test_eal_flags: fix memory leak

2021-06-24 Thread David Marchand
On Wed, Jun 16, 2021 at 6:26 PM wrote: > > From: Owen Hilyard > > The directory steam was not closed when the hugepage action was > HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of > the unit tests. > Fixes: 45f1b6e8680a ("app: add new tests on eal flags") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH] kni: update link only on change

2021-06-24 Thread Ferruh Yigit
'rte_kni_update_link()' updates virtual KNI interface link using kernel sysfs interface. If the requested link status is same as interface link status, do not update the link status but return with success. Signed-off-by: Ferruh Yigit --- Cc: Dan Gora --- lib/kni/rte_kni.c | 5 - lib/kni/

Re: [dpdk-dev] [PATCH] bus/pci: Fix PowerNV platform detection logic

2021-06-24 Thread David Marchand
On Tue, Jun 15, 2021 at 7:21 PM David Christensen wrote: > > Fix the IOMMU detection logic that looks for the "platform" field of > /proc/cpuinfo on POWER systems. > > Fixes: 905215731833 ("bus/pci: support IOVA as VA on PowerNV systems") Cc: sta...@dpdk.org > > Signed-off-by: David Christensen

Re: [dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Kinsella, Ray
Sounds more than reasonable, +1 from me. Ray K On 24/06/2021 14:24, Ferruh Yigit wrote: > On 6/24/2021 11:42 AM, Kinsella, Ray wrote: >> Hi Ferruh, >> >> The following kni experimental symbols are present in both v21.05 and v19.11 >> release. These symbols should be considered for promotion to

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Burakov, Anatoly
On 24-Jun-21 10:47 AM, Ananyev, Konstantin wrote: I did a quick prototype for this, and i don't think it is going to work. Callbacks with just "current value" as argument will be pretty limited and will only really work for cases where we know what we are expecting. However, for cases like

[dpdk-dev] [PATCH] add testing requirement for new PMDs

2021-06-24 Thread Ferruh Yigit
As discussed in the technical board meeting https://mails.dpdk.org/archives/dev/2021-February/200012.html This is to record that new upstreamed devices tested adequately. Signed-off-by: Ferruh Yigit --- CC: John McNamara Cc: dev@dpdk.org --- content/testing/_index.md | 4 1 file changed,

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Ananyev, Konstantin
> I did a quick prototype for this, and i don't think it is going to work. > > Callbacks with just "current value" as argument will be pretty limited > and will only really work for cases where we know what we are expecting. > However, for cases like event/dlb or net/mlx5

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Burakov, Anatoly
On 24-Jun-21 3:57 PM, Ananyev, Konstantin wrote: I did a quick prototype for this, and i don't think it is going to work. Callbacks with just "current value" as argument will be pretty limited and will only really work for cases where we know what we are expecting. However, for cases like eve

[dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum

2021-06-24 Thread Mohsin Kazmi
Preparation the headers for the hardware offload misses the outer ipv4 checksum offload. It results in bad checksum computed by hardware NIC. This patch fixes the issue by setting the outer ipv4 checksum field to 0. Cc: ray.kinse...@intel.com Signed-off-by: Mohsin Kazmi --- lib/net/rte_net.h |

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Ananyev, Konstantin
> >> I did a quick prototype for this, and i don't think it is going to > >> work. > >> > >> Callbacks with just "current value" as argument will be pretty limited > >> and will only really work for cases where we know what we are > >> expecting. > >> However, for cas

[dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum

2021-06-24 Thread Mohsin Kazmi
Preparation the headers for the hardware offload misses the outer ipv4 checksum offload. It results in bad checksum computed by hardware NIC. This patch fixes the issue by setting the outer ipv4 checksum field to 0. Cc: ray.kinse...@intel.com Signed-off-by: Mohsin Kazmi --- lib/net/rte_net.h |

Re: [dpdk-dev] [PATCH] add testing requirement for new PMDs

2021-06-24 Thread Dmitry Kozlyuk
2021-06-24 15:45 (UTC+0100), Ferruh Yigit: > As discussed in the technical board meeting > https://mails.dpdk.org/archives/dev/2021-February/200012.html > > This is to record that new upstreamed devices tested adequately. > > Signed-off-by: Ferruh Yigit > --- > CC: John McNamara > Cc: dev@dpdk.

Re: [dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Chautru, Nicolas
Hi Ray, That request was considered for 20.11. But this was deferred by the community while waiting for other vendors who may be willing to contribute their own PMDs. Any specific concern with this not being on a tracked ABI? Thanks Nic > -Original Message- > From: Kinsella, Ray > Se

Re: [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-06-24 Thread Tyler Retzlaff
On Wed, Jun 23, 2021 at 02:26:32PM -0700, Jie Zhou wrote: > On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > > - > > void > > fdir_set_flex_mask(portid_t port_id, struct rte_eth_fdir_flex_mask *cfg) > > { > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > > index

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Burakov, Anatoly
On 24-Jun-21 4:25 PM, Ananyev, Konstantin wrote: I did a quick prototype for this, and i don't think it is going to work. Callbacks with just "current value" as argument will be pretty limited and will only really work for cases where we know what we are expecting. However, for cases like even

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-06-24 Thread Tyler Retzlaff
On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote: > 23/06/2021 20:26, Tyler Retzlaff: > > today rte_common.h defines common macros for use by dpdk and consuming > > applications. most expansions are specific to the gcc toolchain. > > > > example > > // lib/eal/include/rte_common.h >

Re: [dpdk-dev] [PATCH] test: remove hack for private header inclusion

2021-06-24 Thread Tyler Retzlaff
On Thu, Jun 24, 2021 at 01:53:19PM +0200, David Marchand wrote: > This hack was needed with the make build system. > With meson, any private header from a library is visible as long as a > dependency to this library is expressed. > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff

Re: [dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf

2021-06-24 Thread Tyler Retzlaff
On Wed, Jun 23, 2021 at 01:31:54PM -0700, David Christensen wrote: > Replacing memcpy() with rte_memcpy() improved 64 byte packet > performance by 33% on a POWER9 system and by 10% on an x86_64 > system. > > Signed-off-by: David Christensen > --- Acked-by: Tyler Retzlaff

Re: [dpdk-dev] [PATCH v5 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-24 Thread Thomas Monjalon
23/06/2021 02:03, Xueming Li: > +static int > +rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv, > +struct rte_auxiliary_device *dev) [...] > + AUXILIARY_LOG(DEBUG, "Probe driver: %s", drv->driver.name); I think the debug log above is useless given th

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-06-24 Thread Thomas Monjalon
24/06/2021 18:02, Tyler Retzlaff: > On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote: > > 23/06/2021 20:26, Tyler Retzlaff: > > > // lib/eal/gcc/rte_toolchain_common.h > > > #define __rte_noreturn __attribute__((noreturn)) > > > > We should keep a macro in rte_common.h which trigger

Re: [dpdk-dev] [PATCH] bus/pci: Fix PowerNV platform detection logic

2021-06-24 Thread David Christensen
On 6/24/21 6:51 AM, David Marchand wrote: On Tue, Jun 15, 2021 at 7:21 PM David Christensen wrote: Fix the IOMMU detection logic that looks for the "platform" field of /proc/cpuinfo on POWER systems. Fixes: 905215731833 ("bus/pci: support IOVA as VA on PowerNV systems") Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-06-24 Thread Dmitry Kozlyuk
2021-06-24 08:45 (UTC-0700), Tyler Retzlaff: > On Wed, Jun 23, 2021 at 02:26:32PM -0700, Jie Zhou wrote: > > On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > > > - > > > void > > > fdir_set_flex_mask(portid_t port_id, struct rte_eth_fdir_flex_mask *cfg) > > > { > > > diff --gi

Re: [dpdk-dev] Experimental symbols in sched lib

2021-06-24 Thread Singh, Jasvinder
> On 24 Jun 2021, at 11:33, Kinsella, Ray wrote: > > Hi Cristian & Jasvinder, > > The following sched experimental symbols are present in both v21.05 and > v19.11 release. These symbols should be considered for promotion to stable as > part of the v22 ABI in DPDK 21.11, as they have been ex

Re: [dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Kinsella, Ray
Hi Nicolas, I could equally ask is there is any concern with this being a tracked ABI? The API has seen zero changes in two years - IMHO we'd need a very good reason not standardize it. As there has been ample opportunities for others to chime in. git log --format=oneline --follow v19.11..v21.0

Re: [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-06-24 Thread Jie Zhou
On Thu, Jun 24, 2021 at 09:44:04PM +0300, Dmitry Kozlyuk wrote: > 2021-06-24 08:45 (UTC-0700), Tyler Retzlaff: > > On Wed, Jun 23, 2021 at 02:26:32PM -0700, Jie Zhou wrote: > > > On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > > > > - > > > > void > > > > fdir_set_flex_mask(po

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-24 Thread Dmitry Kozlyuk
2021-06-23 15:34 (UTC-0700), Jie Zhou: > Enable building libraries that testpmd depends on for Windows > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > lib/meson.build | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/lib/meson.build b/lib/meson.build > index 4a64756

Re: [dpdk-dev] [PATCH v14 2/9] eal/windows: add necessary macros

2021-06-24 Thread Dmitry Kozlyuk
2021-06-23 15:34 (UTC-0700), Jie Zhou: > Add required macros by testpmd on Windows in rte_os_shim.h > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v14 4/9] eal/Windows: add clock_gettime on Windows

2021-06-24 Thread Dmitry Kozlyuk
2021-06-23 15:34 (UTC-0700), Jie Zhou: > Add clock_gettime on Windows in rte_os_shim.h > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v14 7/9] app/testpmd: replace POSIX specific code

2021-06-24 Thread Dmitry Kozlyuk
2021-06-23 15:34 (UTC-0700), Jie Zhou: > - Make printf format OS independent > - Replace htons with RTE_BE16 > - Replace POSIX specific inet_aton with OS independent inet_pton > - Replace sleep with rte_delay_us_sleep > - Repalce random with rte_rand > - #ifndef mman related code for now > -

Re: [dpdk-dev] [PATCH v14 8/9] app/testpmd: fix unused function warnings

2021-06-24 Thread Dmitry Kozlyuk
2021-06-23 15:34 (UTC-0700), Jie Zhou: > Function print_fdir_mask and print_fdir_flex_payload is only called > when either i40e or ixgbe presents. Add #if defined to remove > "unused function" compilation warning. > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > Acked-by: Tal Shnaiderman

[dpdk-dev] [PATCH] eal/windows: ensure all the CPUs in the set are checked

2021-06-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Fix count_cpu() to ensure it iterates through all the CPUs in a set. count_cpu() iterates through the CPUs in the set 's' and counts the selected ones. Previously, it was incorrectly using the number of CPUSETS to iterate through the CPUs. Signed-off-by: Narcisa Vasile ---

[dpdk-dev] [PATCH v5 0/2] power: add support for cppc cpufreq driver

2021-06-24 Thread Richael Zhuang
v5: rebase on Anatoly's patch: http://dpdk.org/patch/94763 Richael Zhuang (2): power: add support for cppc cpufreq test/power: round cpuinfo cur freq only when using CPPC cpufreq app/test/test_power.c | 3 +- app/test/test_power_cpufreq.c | 26 +- lib/power/meson.build

[dpdk-dev] [PATCH v5 1/2] power: add support for cppc cpufreq

2021-06-24 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app/test/test_power.c | 3 +- app/test/test_power_c

[dpdk-dev] [PATCH v5 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq

2021-06-24 Thread Richael Zhuang
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [Question] why ixgbevf driver not support dynamic txq/rxq start/stop

2021-06-24 Thread Xue, Joyce (NSB - CN/Hangzhou)
Hi all, We would like to start/stop a specific Rx/Tx queue of a ixgbevf device and found that rx_queue_start/tx_queue_start operations are not supported on ixgbevf driver. I am wondering why this driver not support dynamic txq/rxq start/stop. Is there any hardlimit to implement this? Thanks very

Re: [dpdk-dev] [PATCH v6 2/7] vhost: fix missing guest pages table NUMA realloc

2021-06-24 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Friday, June 18, 2021 10:04 PM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v6 2/7] vhost: fix missing guest pages table NUMA realloc > > When the guest allocat

Re: [dpdk-dev] [PATCH v6 1/7] vhost: fix missing memory table NUMA realloc

2021-06-24 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Friday, June 18, 2021 10:04 PM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v6 1/7] vhost: fix missing memory table NUMA realloc > > When the guest allocates vi

Re: [dpdk-dev] [PATCH v6 3/7] vhost: fix missing cache logging NUMA realloc

2021-06-24 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 18, 2021 10:04 PM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Maxime Coquelin > Subject: [PATCH v6 3/7] vhost: fix missing cache logging NUMA realloc > > When the guest allocates virtqu

  1   2   >