Re: [dpdk-dev] [PATCH v19 1/7] dmadev: introduce DMA device library public APIs

2021-09-05 Thread Gagandeep Singh
> -Original Message- > From: fengchengwen > Sent: Saturday, September 4, 2021 7:02 AM > To: Gagandeep Singh ; tho...@monjalon.net; > ferruh.yi...@intel.com; bruce.richard...@intel.com; jer...@marvell.com; > jerinjac...@gmail.com; andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; m...@sma

Re: [dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable

2021-09-05 Thread Andrew Rybchenko
On 9/6/21 8:56 AM, Haiyue Wang wrote: > The DPDK Symbol Bot reports: > Please note the symbols listed below have expired. In line with the > DPDK ABI policy, they should be scheduled for removal, in the next > DPDK release. > > Symbol > rte_eth_rx_burst_mode_get > rte_eth_tx_burst_mode_get > > Si

[dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable

2021-09-05 Thread Haiyue Wang
The DPDK Symbol Bot reports: Please note the symbols listed below have expired. In line with the DPDK ABI policy, they should be scheduled for removal, in the next DPDK release. Symbol rte_eth_rx_burst_mode_get rte_eth_tx_burst_mode_get Signed-off-by: Haiyue Wang Acked-by: Ferruh Yigit Acked-by

[dpdk-dev] [PATCH v2 4/4] common/iavf: update the driver version

2021-09-05 Thread Haiyue Wang
Update the driver version to trace the change. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index 611fdcea94..89bdbc827e 100644 --- a/drive

[dpdk-dev] [PATCH v2 3/4] common/iavf: remove the FDIR query opcode

2021-09-05 Thread Haiyue Wang
The VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 38 -- 1 file changed, 38 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtch

[dpdk-dev] [PATCH v2 2/4] common/iavf: add proto hdr field support for L4 checksum

2021-09-05 Thread Haiyue Wang
From: Alvin Zhang Add TCP/UDP/SCTP header checksum field selectors, they can be used in creating FDIR or RSS rules related to TCP/UDP/SCTP header checksum. Signed-off-by: Alvin Zhang Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+) diff -

[dpdk-dev] [PATCH v2 1/4] common/iavf: add QFI fields for GTPU UL and DL

2021-09-05 Thread Haiyue Wang
From: Junfeng Guo The QFI is 6-bit "QoS Flow Identifier" within the GTPU Extension Header. Add virtchnl fields QFI of GTPU UL/DL for supporting the AVF FDIR. Signed-off-by: Junfeng Guo Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 5 + 1 file changed, 5 insertions(+) di

[dpdk-dev] [PATCH v2 0/4] iavf base code update

2021-09-05 Thread Haiyue Wang
v2: update the commit message. Alvin Zhang (1): common/iavf: add proto hdr field support for L4 checksum Haiyue Wang (2): common/iavf: remove the FDIR query opcode common/iavf: update the driver version Junfeng Guo (1): common/iavf: add QFI fields for GTPU UL and DL drivers/common/iavf

[dpdk-dev] [PATCH v2] net/ice: refine flow priority support in PF

2021-09-05 Thread Yuying Zhang
The usage of priority is converse in pipeline mode and non-pipeline mode. Refine attribute priority support of flow filter in PF driver. When priority is 0, rules are created in switch filter first and FDIR is used as backup. When priority is 1, rules are all created in switch filter. Other filters

Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit

2021-09-05 Thread Peng, ZhihongX
> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, September 1, 2021 1:52 AM > To: Peng, ZhihongX > Cc: olivier.m...@6wind.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit > > 2021-08-31 10:28 (UTC+0800), zhihon

Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit

2021-09-05 Thread Peng, ZhihongX
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, September 1, 2021 12:59 AM > To: Peng, ZhihongX > Cc: olivier.m...@6wind.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit > > On Tue, 31 Aug 2021 10:28:44 +0

Re: [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection

2021-09-05 Thread Xia, Chenbo
Hi Gaoxiang, > -Original Message- > From: Gaoxiang Liu > Sent: Saturday, September 4, 2021 10:28 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; liugaoxi...@huawei.com; Gaoxiang Liu ; > sta...@dpdk.org > Subject: [PATCH] vhost: add log print of socket path on adding

Re: [dpdk-dev] Intel FW 8.15 with DPDK 20.11 & 21.02

2021-09-05 Thread Xing, Beilei
Hi Igor, According to the Recommended Matching List in doc/guides/nics/i40e.rst, we should use FW 8.00 with DPDK 20.11 & 21.02. +--+---+--+ | DPDK version | Kernel driver version | Firmware version | +==+===

Re: [dpdk-dev] [PATCH v7] vhost: fix crash on port deletion

2021-09-05 Thread Xia, Chenbo
> -Original Message- > From: Gaoxiang Liu > Sent: Thursday, September 2, 2021 11:46 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; liugaoxi...@huawei.com; Gaoxiang Liu > Subject: [PATCH v7] vhost: fix crash on port deletion > > The rte_vhost_driver_unregister() and

[dpdk-dev] [PATCH v3 6/6] test/oops: support unit test case for oops handling APIs

2021-09-05 Thread jerinj
From: Jerin Jacob Added unit test cases for all the oops handling APIs. Signed-off-by: Jerin Jacob --- app/test/meson.build | 2 + app/test/test_oops.c | 122 +++ 2 files changed, 124 insertions(+) create mode 100644 app/test/test_oops.c diff --git a

[dpdk-dev] [PATCH v3 5/6] eal/arm64: support register dump for oops

2021-09-05 Thread jerinj
From: Jerin Jacob Dump the arm64 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index a9c22cbe70..6793497bee 100644 -

[dpdk-dev] [PATCH v3 4/6] eal/x86: support register dump for oops

2021-09-05 Thread jerinj
From: Jerin Jacob Dump the x86 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index 9c2d9d99d9..a9c22c

[dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace

2021-09-05 Thread jerinj
From: Jerin Jacob adding optional libwind library dependency to DPDK for enhanced backtrace based on ucontext. Signed-off-by: Jerin Jacob --- .github/workflows/build.yml | 2 +- .travis.yml | 2 +- config/meson.build | 8 +++ lib/eal/unix/eal_oops.c | 45 +++

[dpdk-dev] [PATCH v3 2/6] eal: oops handling API implementation

2021-09-05 Thread jerinj
From: Jerin Jacob Implement the base oops handling APIs. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 173 ++-- 1 file changed, 166 insertions(+), 7 deletions(-) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index 53b580f733..a4

[dpdk-dev] [PATCH v3 1/6] eal: introduce oops handling API

2021-09-05 Thread jerinj
From: Jerin Jacob Introducing oops handling API with following specification and enable stub implementation for Linux and FreeBSD. On rte_eal_init() invocation and if –no-oops not provided in the EAL command line argument, then EAL library installs the oops handler for the essential signals. The

[dpdk-dev] [PATCH v3 0/6] support oops handling

2021-09-05 Thread jerinj
From: Jerin Jacob v3: - Updated the release notes - Introduce "--no-oops" EAL option to disable default EAL handler. Default EAL oops handler stores the existing handler and invoke after decoding. So there may not be explicit use case to use this. But added, just in case for control to app

Re: [dpdk-dev] [PATCH v6] vhost: fix crash on port deletion

2021-09-05 Thread Gaoxiang Liu
Hi Chenbo, But same issue happens when you deleted 'vsocket->socket_fd' but failed to delete one of the conn_fd: you will goto again and try to delete socket_fd again and then loop forever. So anyway you need to prevent this from happening. ==> It will not happen, because fdset_try_del only ret

Re: [dpdk-dev] [PATCH v6] vhost: fix crash on port deletion

2021-09-05 Thread Xia, Chenbo
Hi Gaoxiang, > -Original Message- > From: dev On Behalf Of Xia, Chenbo > Sent: Monday, September 6, 2021 11:18 AM > To: Gaoxiang Liu > Cc: maxime.coque...@redhat.com; dev@dpdk.org; liugaoxi...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v6] vhost: fix crash on port deletion > > Hi Gaoxi

[dpdk-dev] [PATCH 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-09-05 Thread Ruifeng Wang
Rx descriptor is 16B/32B in size and consists of multiple words. The word that includes DD field should be read first. Read result with DD bit set indicates the rest part in a descriptor is valid. In functions for simple Rx, the descriptor is not read atomically in whole. On weaker ordered systems

[dpdk-dev] [PATCH 1/2] net/i40e: fix risk in Rx descriptor read in NEON vector path

2021-09-05 Thread Ruifeng Wang
Rx descriptor is 16B/32B in size and consists of multiple words. The word that includes DD field should be read first. Read result with DD bit set indicates the rest part in a descriptor is valid. In NEON vector PMD, vector load loads two contiguous 8B of descriptor data into vector register. Give

[dpdk-dev] [PATCH 0/2] i40e Rx descriptor loads ordering

2021-09-05 Thread Ruifeng Wang
On Rx path, NIC fills Rx descriptor with data pertains to received packet. A single descriptor consists of multiple words. Word1 has the bit that indicates readiness of descriptor for software to use. So word1 should be loaded before other words. On architectures with weaker memory ordering, b

Re: [dpdk-dev] [PATCH v7] vhost: fix crash on port deletion

2021-09-05 Thread Xia, Chenbo
Hi, > -Original Message- > From: Gaoxiang Liu > Sent: Thursday, September 2, 2021 11:46 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; liugaoxi...@huawei.com; Gaoxiang Liu > Subject: [PATCH v7] vhost: fix crash on port deletion > > The rte_vhost_driver_unregister(

Re: [dpdk-dev] [PATCH v6] vhost: fix crash on port deletion

2021-09-05 Thread Xia, Chenbo
Hi Gaoxiang, > > >From: Gaoxiang Liu >Sent: Thursday, September 2, 2021 11:38 PM >To: Xia, Chenbo >Cc: maxime.coque...@redhat.com; dev@dpdk.org; liugaoxi...@huawei.com >Subject: Re:RE: [PATCH v6] vhost: fix crash on port deletion > > >Hi chenbo, >why this is not moved up? >>> + if (vs

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-09-05 Thread Xia, Chenbo
Hi, > -Original Message- > From: Vijay Kumar Srivastava > Sent: Friday, September 3, 2021 9:20 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Harpreet Singh > Anand ; Praveen Kumar Jain > Subject: RE: [PATCH 02/10] vdpa/sfc: add suppo

[dpdk-dev] [PATCH v2] net/ixgbe: fix vf mac remains

2021-09-05 Thread Qiming Chen
In the following two scenarios, the mac address residual problem will occur: 1) In the VF hard pass-through environment, after adding the mac address, the process restarts, and the previously added mac is still valid; 2) In the vf hard pass-through environment, after the mac address is issued, the

[dpdk-dev] [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-05 Thread Qiming Chen
Ifconfig pf port up/down, after several times, the dpdk vf driver may fail to obtain the mailbox lock, resulting in configuration failure and functional failure. In order to increase the reliability of mailbox communication, the patch uses a trial strategy. Fixes: af75078fece3 ("first public relea

[dpdk-dev] [PATCH v4 18/18] net/i40e: fix redefinition warning

2021-09-05 Thread Robin Zhang
After update i40e share code, there will be a redefinition compile warning. This patch fix the situation by remove duplicate definition in i40e_ethdev.c Fixes: eef2daf2e199 ("net/i40e: fix link update no wait") Signed-off-by: Robin Zhang --- drivers/net/i40e/i40e_ethdev.c | 3 +-- 1 file change

[dpdk-dev] [PATCH v4 17/18] net/i40e/base: update version in readme

2021-09-05 Thread Robin Zhang
Update base code version in README. Signed-off-by: Robin Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6af2993116..2e4fa5a921 100644 --- a/drivers/net/i40e/base/README +

[dpdk-dev] [PATCH v4 16/18] net/i40e/base: add defines related to DDP

2021-09-05 Thread Robin Zhang
This patch adds some defines related to DDP Track ID. Signed-off-by: Artur Tyminski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index 813c1ec00f..f4a

[dpdk-dev] [PATCH v4 15/18] net/i40e/base: Update FVL FW API version to 1.15

2021-09-05 Thread Robin Zhang
Update FVL FW API version to 1.15 Signed-off-by: Maciej Paczkowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index

[dpdk-dev] [PATCH v4 14/18] net/i40e/base: separate kernel allocated rx_bi rings from AF_XDP rings

2021-09-05 Thread Robin Zhang
Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP zero-copy/sk_buff rx_bi rings are now separate. Functions to properly allocate the different rings are added as well. Signed-off-by: Björn Töpel Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_type.h | 5 - 1 file c

[dpdk-dev] [PATCH v4 13/18] net/i40e/base: add defs for MAC frequency calculation if no link

2021-09-05 Thread Robin Zhang
Add macros and structures for MAC frequency calculation in case the link is not present. Signed-off-by: Piotr Kwapulinski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 9 + drivers/net/i40e/base/i40e_register.h | 10 ++ drivers/net/i40e/base/i40e_ty

[dpdk-dev] [PATCH v4 12/18] net/i40e/base: fix checksum is used before return value is checked

2021-09-05 Thread Robin Zhang
The variable checksum from i40e_calc_nvm_checksum is used before return value is checked. Fix this logic. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 3ed6c3246f43 ("i40e/base: handle AQ timeout when releasing NVM") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Robin Zhan

[dpdk-dev] [PATCH v4 11/18] net/i40e/base: fix potentially uninitialized variables in NVM code

2021-09-05 Thread Robin Zhang
The status of i40e_read_nvm_word is not checked, so variables set from this function could be used uninitialized. In this case, preserve the existing flow that does not block initialization by initializing these values from the start. Fixes: 8d6c51fcd24b ("i40e/base: get OEM version") Fixes: 2db70

[dpdk-dev] [PATCH v4 10/18] net/i40e/base: fix headers to match functions

2021-09-05 Thread Robin Zhang
Fix several kernel-doc warnings when building with W=1. These changes are only to comments. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 842ea1996335 ("i40e/base: save link module type") Fixes: fd72a2284a89 ("i40e/base: support LED blinking with new PHY") Fixes: 788fc17b2dec ("i40e/base: suppo

[dpdk-dev] [PATCH v4 09/18] net/i40e/base: add flags and fields for double vlan processing

2021-09-05 Thread Robin Zhang
Add flags for outer vlan and include set port parameters in Linux compilation. Add flags, which describe port and switch state for both double vlan functionality and outer vlan processing. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.

[dpdk-dev] [PATCH v4 08/18] net/i40e/base: fix AOC media type reported by ethtool

2021-09-05 Thread Robin Zhang
For Active Optical Cable (AOC) the correct media type is "Fibre", not "Direct Attach Copper". Fixes: d749d4d89969 ("i40e/base: add AOC PHY types") Fixes: aa153cc89ff0 ("net/i40e/base: add new PHY types for 25G AOC and ACC") Cc: sta...@dpdk.org Signed-off-by: Dawid Lukwinski Signed-off-by: Robin

[dpdk-dev] [PATCH v4 07/18] net/i40e/base: fix update link data for X722

2021-09-05 Thread Robin Zhang
The X722 card has 'Link Type' information elsewhere than the X710. Previously, for all cards, the 'Link Type' information was retrieved by opcode 0x0607 and this value was wrong for all X722 cards. Now this information for X722 only is taken by opcode 0x0600 (function: i40e_aq_get_phy_capabilities)

[dpdk-dev] [PATCH v4 06/18] net/i40e/base: fix PF reset failed

2021-09-05 Thread Robin Zhang
PF has to delete all the filters during reset. If it is fully loaded with filters then it is possible that it will take more than 200 ms to finish the reset resulting in timeout during pf_reset and PF reset failed, -15 error indication. Increasing the timeout value for PF reset from 200 to 1000 to

[dpdk-dev] [PATCH v4 05/18] net/i40e/base: fix PHY type identifiers for 2.5G and 5G adapters

2021-09-05 Thread Robin Zhang
Unlike other supported adapters, 2.5G and 5G use different PHY type identifiers for reading/writing PHY settings and for reading link status. This commit intruduces separate PHY identifiers for these two operation types. Fixes: 988ed63c7441 ("net/i40e/base: add support for Carlsville device") Cc:

[dpdk-dev] [PATCH v4 04/18] net/i40e/base: define new Shadow RAM pointers

2021-09-05 Thread Robin Zhang
Add definitions for Shadow RAM pointers: 6th FPA module, 5th FPA module in X722 and Preservation Rules Module. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_type.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/base/i40e_t

[dpdk-dev] [PATCH v4 03/18] net/i40e/base: set TSA table values when parsing CEE configuration

2021-09-05 Thread Robin Zhang
Driver did not Set TSA table values when parsing CEE configuration obtained from FW. Signed-off-by: Pawel Malinowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_dcb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_dcb.c b/driv

[dpdk-dev] [PATCH v4 02/18] net/i40e/base: add support for Min Rollback Revision for 4 more X722 modules

2021-09-05 Thread Robin Zhang
This change increments X722 API version and adds new constants related to the extended implementation of Security Version Opt-In. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 16 ++-- 1 file changed, 10 insertions(+), 6

[dpdk-dev] [PATCH v4 01/18] net/i40e/base: add new versions of send ASQ command functions

2021-09-05 Thread Robin Zhang
ASQ send command functions are returning only i40e status codes yet some calling functions also need Admin Queue status that is stored in hw->aq.asq_last_status. Since hw object is stored on a heap it introduces a possibility for a race condition in access to hw if calling function is not fast enou

[dpdk-dev] [PATCH v4 00/18] i40e base code update

2021-09-05 Thread Robin Zhang
update i40e base code. source code of i40e driver: cid-i40e.2021.08.16.tar.gz changelog in i40e share repo: >From 59a080f4fafe ("i40e-shared: Add opcode 0x0406 and 0x0416 to Linux support") To 2c7aab559654 ("i40e-shared: Add defines related to DDP") The following commits are ignored: cb9139e3bce

[dpdk-dev] [PATCH v1] lib/ethdev: fix a typo in ethdev comment

2021-09-05 Thread Joyce Kong
Fix a typo that mb_pool was misspelt as mp_pool. Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Cc: Viacheslav Ovsiienko Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- lib/ethdev/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

2021-09-05 Thread Xia, Chenbo
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 3, 2021 8:59 PM > To: fengchengwen ; Richardson, Bruce > ; Li, Xiaoyun > Cc: tho...@monjalon.net; Yigit, Ferruh ; > jer...@marvell.com; jerinjac...@gmail.com; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; m...@sm

Re: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Qiming Chen > Sent: Monday, August 23, 2021 11:46 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > > Subject: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset > > In the embedded RTOS environment, the x722 controll

Re: [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: Tu, Lijuan > Sent: Monday, September 6, 2021 9:35 AM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: Guo, Junfeng ; dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix performance with writeback policy > > > Apply the same fix that for iavf to DCF >

Re: [dpdk-dev] [PATCH] net/i40e: solve vf rxq buf size alignment

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Qiming Chen > Sent: Monday, August 23, 2021 12:11 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > > Subject: [dpdk-dev] [PATCH] net/i40e: solve vf rxq buf size alignment > > The RTE_ALIGN macro is aligned upwards. If the buf_size

Re: [dpdk-dev] [PATCH] net/ixgbe: fix vf mac remains

2021-09-05 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Tuesday, August 31, 2021 22:17 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix vf mac remains > > In the following two scenarios, the mac address residual problem > will occur: > 1)

Re: [dpdk-dev] [PATCH] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-05 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Tuesday, August 31, 2021 16:41 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix probability of obtaining mailbox lock failure > > Ifconfig pf port up/down, after several times, the d

Re: [dpdk-dev] [PATCH] net/i40e: fix vf resource leakage problem

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of > chenqiming_hua...@163.com > Sent: Saturday, August 21, 2021 4:14 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix vf resource leakage problem > > From: Qiming Chen >

Re: [dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

2021-09-05 Thread Li, Xiaoyun
Hi > -Original Message- > From: fengchengwen > Sent: Saturday, September 4, 2021 15:02 > To: Maxime Coquelin ; Richardson, Bruce > ; Li, Xiaoyun > Cc: tho...@monjalon.net; Yigit, Ferruh ; > jer...@marvell.com; jerinjac...@gmail.com; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; m...@sma

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mbuf leak

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Monday, September 6, 2021 9:22 AM > To: Qiming Chen ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mbuf leak > > > -Original Message- > > From: Qiming Chen > > Sent: We

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Monday, September 6, 2021 9:25 AM > To: Qiming Chen ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak > > > -Original Message- > > From: Qiming Chen > >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix queue resource leak

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Monday, September 6, 2021 9:35 AM > To: Qiming Chen ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix queue resource leak > > > -Original Message- > > From: Qiming Chen > > S

Re: [dpdk-dev] [PATCH] net/ixgbe: fix hash handle leak

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Qiming Chen > Sent: Tuesday, August 31, 2021 9:24 PM > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix hash handle leak > > In the ixgbe_fdir_filter_init and ixgbe_l2_tn_fil

Re: [dpdk-dev] [PATCH] net/ice: fix performance with writeback policy

2021-09-05 Thread Tu, Lijuan
> Apply the same fix that for iavf to DCF > commit: ead06572bd8f ("net/iavf: fix performance with writeback policy") > > Fixes: 4b0d391f0eab ("net/ice: add queue config in DCF") > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang Tested-by: Lijuan Tu

Re: [dpdk-dev] [PATCH] net/ixgbe: fix queue resource leak

2021-09-05 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Tuesday, August 31, 2021 21:40 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix queue resource leak > > In the ixgbevf_dev_start function, after initializing the rxtx queue, if > an

Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss max rxtx queue num

2021-09-05 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Tuesday, August 31, 2021 17:11 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix rss max rxtx queue num > > Through the local actual test, it is found that the maximum number of > RSS

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak

2021-09-05 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Wednesday, September 1, 2021 15:12 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH v3] net/ixgbe: fix mac resourece leak > > In the eth_ixgbevf_dev_init and eth_ixgbe_dev_init functions, memory is

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mbuf leak

2021-09-05 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Wednesday, September 1, 2021 15:23 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH v3] net/ixgbe: fix mbuf leak > > A local test found that repeated port start and stop operations during > the cont

Re: [dpdk-dev] [PATCH] net/ice: enable CVL DCF device reset API

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Wednesday, September 1, 2021 1:26 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX > Subject: [PATCH] net/ice: enable CVL DCF device reset API > > From: Dapeng Yu > > DCF PMD needs to support rte_eth_dev_reset, t

Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: remove i40evf

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Wednesday, September 1, 2021 11:31 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Burakov, Anatoly > ; Wu, Jingjing ; > m...@ashroe.eu; Zhang, Qi Z ; Guo, Junfeng > ; Yang, SteveX ; > david.march...@redhat.com; ktray...@redhat.com; Zhang, R

Re: [dpdk-dev] [PATCH v7] ethdev: add IPv4 and L4 checksum RSS offload types

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Tuesday, August 31, 2021 5:53 PM > To: Zhang, Qi Z ; Guo, Junfeng > > Cc: dev@dpdk.org; Zhang, AlvinX ; Ajit Khaparde > ; Singh, Aman Deep > > Subject: [PATCH v7] ethdev: add IPv4 and L4 checksum RSS offload types > > This patch defi

Re: [dpdk-dev] [PATCH v1] net/ice: refine flow priority support in PF

2021-09-05 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Monday, August 30, 2021 1:30 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Zhang, Yuying > Subject: [PATCH v1] net/ice: refine flow priority support in PF > > The usage of priority is converse in pipeline mode and non-pipeline mode. > Ref

[dpdk-dev] [RFC] common/mlx5: support cross vHCA mkey

2021-09-05 Thread Michael Baum
The mlx5 devices support multiple vHCA under the same device. The mlx5 devices IOVA addresses are built from mkey ID and the process virtual address(VA); given the VA, the kernel mlx5 driver creates an mkey that defines the mapping between the VA space and the PA space. This feature allows having a

Re: [dpdk-dev] [PATCH v2] bus/vmbus: Fix crash when handling packets in secondary process

2021-09-05 Thread Jonathan Erb
Long, I have applied the patch and have verified that I can successfully send packets on queue 1 in a secondary process without issue. I believe this exercises the use of vmbus subchannels in secondary processes. Seems fine to me. Thanks. On 8/31/21 2:01 AM, Long Li wrote: I posted a patch

[dpdk-dev] [PATCH V2] compress/mlx5: allow partial transformations support

2021-09-05 Thread Raja Zidane
Currently compress, decompress and dma are allowed only when all 3 capabilities are on. A case where the user wants decompress offload, if decompress capability is on but one of compress, dma is off, is not allowed. Split compress/decompress/dma support check to allow partial transformations. V2:

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-09-05 Thread Kamaraj P
Hello Thomas, THanks for the suggestion. Yes. Our DPDK application already has an in-memory option. BTW we are not using a multi-process environment for our DPDK application. Thanks, Kamaraj On Wed, Sep 1, 2021 at 11:23 PM Thomas Monjalon wrote: > 01/09/2021 18:09, Kamaraj P: > > Thanks Bruce.

Re: [dpdk-dev] [EXT] [PATCH v4 10/10] ipsec: add ol_flags support

2021-09-05 Thread Akhil Goyal
> Set mbuff->ol_flags for IPsec packets. > Could you please add more information in the description About the need of the patch and what issue this patch is resolving. > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin B

Re: [dpdk-dev] [EXT] [PATCH v4 07/10] ipsec: add support for NAT-T

2021-09-05 Thread Akhil Goyal
> Add support for the IPsec NAT-Traversal use case for Tunnel mode > packets. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > --- > lib/ipsec/iph.h | 13 + > lib/ipsec/rte_ipsec_sa.h |

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-05 Thread Akhil Goyal
Hi Radu, > -- > Update ipsec_xform definition to include ESN field. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > --- > lib/security/r

Re: [dpdk-dev] [EXT] [PATCH v4 04/10] mbuf: add IPsec ESP tunnel type

2021-09-05 Thread Akhil Goyal
> -- > Add tunnel type for IPsec ESP tunnels > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > --- > lib/mbuf/rte_mbuf_core.h | 1 + > 1 fi

Re: [dpdk-dev] [EXT] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T

2021-09-05 Thread Akhil Goyal
Hi Radu, > Add support for specifying UDP port params for UDP encapsulation option. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley Do we really need to specify the port numbers for NAT-T? I suppose they ar

Re: [dpdk-dev] [EXT] [PATCH] compress/mlx5: allow partial transformations support

2021-09-05 Thread Akhil Goyal
> Currently compress, decompress and dma are allowed only when all 3 > capabilities are on. > A case where the user wants decompress offload, if decompress capability > is on but one of compress, dma is off, is not allowed. > Split compress/decompress/dma support check to allow partial > transforma

[dpdk-dev] [PATCH v1 1/2] net/mlx5: fix RSS expansion for 'explicit' graph node

2021-09-05 Thread Lior Margalit
The RSS expansion algorithm is using a graph to find the possible expansion paths. A graph node with the 'explicit' flag will be skipped, if it is not found in the flow pattern. The current implementation misses the case where the node with the explicit flag is in the middle of the expanded path.

[dpdk-dev] [PATCH v1 2/2] net/mlx5: fix RSS expansion traversal over next nodes

2021-09-05 Thread Lior Margalit
The RSS expansion is based on DFS algorithm to traverse over the possible expansion paths. The current implementation breaks out, if it reaches the terminator of the "next nodes" array, instead of going backwards to try the next path. For example: testpmd> flow create 0 ingress pattern eth / ipv6

[dpdk-dev] [PATCH v1 0/2] Fixes in the RSS expansion method

2021-09-05 Thread Lior Margalit
The RSS expansion algorithm is using a graph to find the possible expansion paths. This patch set corrects the traversal over the nodes. Lior Margalit (2): net/mlx5: fix RSS expansion for 'explicit' graph node net/mlx5: fix RSS expansion traversal over next nodes drivers/net/mlx5/mlx5_flow.

Re: [dpdk-dev] [PATCH 2/6] net/mlx5: fix PCI probing error flow

2021-09-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Tuesday, August 31, 2021 11:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH 2/6] net/mlx5: fix PCI probing error flow > How about changing to something like this:

Re: [dpdk-dev] [PATCH 1/6] net/mlx5: fix shared device context creation error flow

2021-09-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Tuesday, August 31, 2021 11:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH 1/6] net/mlx5: fix shared device context creation error flow How about something like t

[dpdk-dev] [PATCH v2] crypto/mlx5: fix timestamp format configuration

2021-09-05 Thread Michael Baum
This patch adds support for the timestamp format settings for the receive and send queues. If the firmware version x.30.1000 or above is installed and the NIC timestamps are configured with the real-time format, the default zero values for newly added fields cause the queue creation to fail. The p