[Bug 956] [dpdk-22.03][asan] dpdk-pdump: detected memory leaks when quit dpdk-pdump

2022-03-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=956 Bug ID: 956 Summary: [dpdk-22.03][asan] dpdk-pdump: detected memory leaks when quit dpdk-pdump Product: DPDK Version: unspecified Hardware: All OS: All S

RE: [PATCH v2 2/2] app/testpmd:fix testpmd quit failure

2022-03-08 Thread Wu, WenxuanX
> -Original Message- > From: Yigit, Ferruh > Sent: 2022年3月5日 0:16 > To: Wu, WenxuanX ; Li, Xiaoyun > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH v2 2/2] app/testpmd:fix testpmd quit failure > > On 3/3/2022 1:22 PM, Wu, WenxuanX wrote: > > moved down, please don't top pos

Re: [PATCH v1 1/2] bbdev: add device info on queue topology

2022-03-08 Thread Stephen Hemminger
On Tue, 8 Mar 2022 16:22:34 -0800 Nicolas Chautru wrote: > diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h > index b88c881..10c06b6 100644 > --- a/lib/bbdev/rte_bbdev.h > +++ b/lib/bbdev/rte_bbdev.h > @@ -274,6 +274,10 @@ struct rte_bbdev_driver_info { > > /** Maximum number o

Re: [PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-08 Thread Stephen Hemminger
On Tue, 8 Mar 2022 22:24:02 +0800 Gaoxiang Liu wrote: > + cache_size = RTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ? > + 32 : RTE_MEMPOOL_CACHE_MAX_SIZE; No need to open code a min(). cache_size = RTE_MIN(RTE_MEMPOOL_CACHE_SIZE, 32);

Re: [PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-08 Thread Stephen Hemminger
On Tue, 8 Mar 2022 22:24:02 +0800 Gaoxiang Liu wrote: > diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h > index 1e7a3c1527..fa15ed710f 100644 > --- a/lib/mempool/rte_mempool.h > +++ b/lib/mempool/rte_mempool.h > @@ -56,6 +56,8 @@ > extern "C" { > #endif > > +#define RTE_ME

[PATCH v1 1/2] bbdev: add device info on queue topology

2022-03-08 Thread Nicolas Chautru
Adding more options in the API to expose the number of queues exposed and related priority. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index b88c881..10c06b6 100644 --- a/lib/bbdev

[PATCH v1 2/2] drivers/baseband: update PMDs to expose queue per operation

2022-03-08 Thread Nicolas Chautru
Add support in existing bbdev PMDs for the explicit number of queue and priority for each operation type configured on the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 29 +- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c

[PATCH v1 0/2] bbdev: add device info on queue topology

2022-03-08 Thread Nicolas Chautru
Addressing an historical concern that the device info struct only imperfectly captured what queues are available on the device (number of operation and priority). This ended up being an iterative process for application to find each queue could be configured. ie. the gap was captured as technical

release candidate 22.03-rc3

2022-03-08 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.03-rc3 There are 102 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_03.html This should be the last release candidate. Only documentation and cr

Re: [PATCH v2 6/8] remove self from timers maintainers

2022-03-08 Thread Thomas Monjalon
21/12/2021 20:57, Robert Sanford: > Remove self from Timers maintainers. > > Signed-off-by: Robert Sanford Applied

RE: [PATCH v1] net/i40e: fix build issue with 16B descriptor on Arm

2022-03-08 Thread Zhang, Qi Z
> -Original Message- > From: Joyce Kong > Sent: Friday, March 4, 2022 3:35 PM > To: Ruifeng Wang ; Xing, Beilei > ; Joyce Kong > Cc: dev@dpdk.org; n...@arm.com > Subject: [PATCH v1] net/i40e: fix build issue with 16B descriptor on Arm > > For NEON vector path, there is an issue when bu

Re: [PATCH v1] maintainers: add explicit maintainer for some bbdev PMDs

2022-03-08 Thread Thomas Monjalon
03/03/2022 19:51, Nicolas Chautru: > These were implicit from DPDK script but adding > separate reference to make it explicit > > Signed-off-by: Nicolas Chautru > --- > MAINTAINERS | 4 > 1 file changed, 4 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7577834..004ec91 10

Re: [PATCH] maintainers: Update MAINTAINERS for FIPS validation

2022-03-08 Thread Thomas Monjalon
> > Replace Marko Kovacevic with Brian Dooley and Fan Zhang > > > > FIPS validation example > > -M: Marko Kovacevic > > +M: Fan Zhang > > +M: Brian Dooley > > F: examples/fips_validation/ > > F: doc/guides/sample_app_ug/fips_validation.rst > > > Acked-by: Fan Zhang Applied, thanks.

Re: [PATCH] devtools: fix symbols check

2022-03-08 Thread Liang Ma
On Tue, Mar 08, 2022 at 11:05:49PM +0100, Thomas Monjalon wrote: > 08/03/2022 22:27, Liang Ma: > > On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote: > > > In some environments, the check of local symbols catch-all > > > was failing. Note: this script is called during the build. > > >

Re: [PATCH v2] maintainers: update for testpmd

2022-03-08 Thread Thomas Monjalon
10/02/2022 16:03, Yuying Zhang: > Move 'test-pmd/bpf_cmd.*' files under BPF component. > > Signed-off-by: Yuying Zhang > Acked-by: Ferruh Yigit Assuming Konstantin is OK. Applied, thanks.

Re: [PATCH v3] maintainers: update for testpmd

2022-03-08 Thread Thomas Monjalon
24/02/2022 14:15, Dumitrescu, Cristian: > > > -Original Message- > > From: Zhang, Yuying > > Sent: Thursday, February 10, 2022 2:51 PM > > To: dev@dpdk.org; Li, Xiaoyun ; Yigit, Ferruh > > ; tho...@monjalon.net; Dumitrescu, Cristian > > > > Cc: Zhang, Yuying > > Subject: [PATCH v3] main

Re: [PATCH v1] doc: fix telemetry example for cryptodev

2022-03-08 Thread Thomas Monjalon
08/03/2022 16:56, Sean Morrissey: > Blank line added to the final telemetry example for the > cryptography device library as to fix the example > rendering. Even for a simple fix like that, you need to add a Fixes: line so we know where to backport (or not). > > Signed-off-by: Sean Morrissey >

Re: [PATCH v2 2/2] gpudev: use page_size in comm_list creation

2022-03-08 Thread Thomas Monjalon
09/03/2022 00:59, eagost...@nvidia.com: > From: Elena Agostini > > Memory allocated for CPU mapping the status flag > in the communication list should be aligned to the > GPU page size. > > Fixes: 9b8cae4d991e ("gpudev: use CPU mapping in communication list") > Signed-off-by: Elena Agostini Pa

Re: [PATCH] devtools: fix symbols check

2022-03-08 Thread Thomas Monjalon
08/03/2022 22:27, Liang Ma: > On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote: > > In some environments, the check of local symbols catch-all > > was failing. Note: this script is called during the build. > > > > The reason is that grep returns an error if nothing is found. > > The

Re: [PATCH v18 8/8] eal: implement functions for mutex management

2022-03-08 Thread Dmitry Kozlyuk
Hi Stephen, 2022-02-24 09:44 (UTC-0800), Stephen Hemminger: > There seems to be some confusion here: >pthread_mutex put thread to sleep if contended and on linux are built on > the futex system call. >pthread_rwlock are the reader/writer versions of these. > > The DPDK has primitives for

Re: [PATCH v18 8/8] eal: implement functions for mutex management

2022-03-08 Thread Dmitry Kozlyuk
Hi Konstantin, 2022-02-24 17:29 (UTC+), Ananyev, Konstantin: [...] > > However, DmitryM suggested using Slim Reader-Writer lock (SRW): > > https://docs.microsoft.com/en-us/windows/win32/sync/slim-reader-writer--srw--locks > > instead of CRITICAL_SECTION. > > It seems to be a much better option

Re: [PATCH] devtools: fix symbols check

2022-03-08 Thread Liang Ma
On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote: > In some environments, the check of local symbols catch-all > was failing. Note: this script is called during the build. > > The reason is that grep returns an error if nothing is found. > The option -e of the shell script makes thi

Re: [PATCH] devtools: fix symbols check

2022-03-08 Thread Thomas Monjalon
08/03/2022 22:18, Thomas Monjalon: > In some environments, the check of local symbols catch-all > was failing. Note: this script is called during the build. > > The reason is that grep returns an error if nothing is found. > The option -e of the shell script makes this error fatal. > It is not alw

[PATCH] devtools: fix symbols check

2022-03-08 Thread Thomas Monjalon
In some environments, the check of local symbols catch-all was failing. Note: this script is called during the build. The reason is that grep returns an error if nothing is found. The option -e of the shell script makes this error fatal. It is not always fatal because the grep is in a command subs

Re: [PATCH] build: encapsulate grep for local_miss_maps in a function

2022-03-08 Thread Thomas Monjalon
08/03/2022 19:52, Usama Arif: > check-symbols-maps.sh runs with the -e option to exit as soon as > there is an error. Currently the build is failing as the search of > grep -L is empty (which is the case for all version.map files as > they have the local symbol) which causes the script to return >

[PATCH] build: encapsulate grep for local_miss_maps in a function

2022-03-08 Thread Usama Arif
check-symbols-maps.sh runs with the -e option to exit as soon as there is an error. Currently the build is failing as the search of grep -L is empty (which is the case for all version.map files as they have the local symbol) which causes the script to return with an error. This patch encapsulates t

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-08 Thread Ajit Khaparde
On Tue, Mar 8, 2022 at 12:19 AM Thierry Herbelot wrote: > > Hello, > > After upgrading the firmware on the bnxt NIC, the NIC is correctly > detected by a DPDK application with both DPDK-v20.11 and DPDK-v21.11. Great. Thanks for the update Thierry. > > Regards > > Thierry > > On 3/

RE: [PATCH] net/mlx5: fix IPv6 flow item validation for VERB API

2022-03-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, March 8, 2022 11:10 AM > To: Gregory Etelson ; dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org; Slava Ovsiienko > ; Dekel Peled ; Ori Kam > > Subject: RE: [PATCH] net/mlx5: fix IPv6 flow item validation for VERB API > >

[PATCH v2 2/2] gpudev: use page_size in comm_list creation

2022-03-08 Thread eagostini
From: Elena Agostini Memory allocated for CPU mapping the status flag in the communication list should be aligned to the GPU page size. Fixes: 9b8cae4d991e ("gpudev: use CPU mapping in communication list") Signed-off-by: Elena Agostini --- lib/gpudev/gpudev.c | 9 - 1 file changed, 8 i

[PATCH v2 1/2] gpudev: add GPU page_size to info

2022-03-08 Thread eagostini
From: Elena Agostini Page alignment on the GPU can be different from the CPU page alignment. Fixes: 9b8cae4d991e ("gpudev: use CPU mapping in communication list") Signed-off-by: Elena Agostini --- drivers/gpu/cuda/cuda.c | 4 lib/gpudev/rte_gpudev.h | 2 ++ 2 files changed, 6 insertions(+

[PATCH v1] doc: fix telemetry example for cryptodev

2022-03-08 Thread Sean Morrissey
Blank line added to the final telemetry example for the cryptography device library as to fix the example rendering. Signed-off-by: Sean Morrissey --- doc/guides/prog_guide/cryptodev_lib.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides

Re: [PATCH v2] build: try to get kernel version from kernel source

2022-03-08 Thread Ferruh Yigit
On 3/3/2022 1:15 PM, Ferdinand Thiessen wrote: When building the kernel modules, try to get the kernel version from the kernel sources first. This fixes the kernel modules installation directory if the target kernel version differs from the host kernel version, like for CI build or when packaging

Re: [PATCH] ethdev: fix doxygen comment for device info struct

2022-03-08 Thread Thomas Monjalon
08/03/2022 10:47, Ferruh Yigit: > API documentation for "struct rte_eth_dev_info" was missing some fields > 'device' & 'max_hash_mac_addrs', > because of syntax error in doxygen comment, fixing it. > > Bugzilla ID: 954 > Fixes: 88ac4396ad29 ("ethdev: add VMDq support") > Fixes: cd8c7c7ce241 ("ethd

[Bug 953] Virtio Crypto Test failed

2022-03-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=953 Fan Zhang (roy.fan.zh...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|

RE: [PATCH v2 1/3] common/mlx5: add Netlink event helpers

2022-03-08 Thread Dmitry Kozlyuk
Hi Kevin, > -Original Message- > From: Kevin Traynor [...] > The updated API is internal so that should be ok. I'm ok to take this > on > 21.11 as long as you can confirm it's not breaking any user > compatibility with external sw versions/ABI/API etc from 21.11.0 ? > > Assuming that's o

Re: [PATCH] net/iavf: fix potential out of bounds access

2022-03-08 Thread Ferruh Yigit
On 3/8/2022 5:56 AM, Leyi Rong wrote: Fix potential out-out-bounds access as overrunning callee's array of size 26 by passing argument rxq->rxdid(which evaluates to 63) in call to iavf_rx_scan_hw_ring_flex_rxd. Coverity issue: 376616 Fixes: 7b1ba38904a0 ("net/iavf: fix function pointer in multi-

Re: [PATCH v2] vhost: fix external message handlers

2022-03-08 Thread David Marchand
On Tue, Mar 8, 2022 at 10:45 AM David Marchand wrote: > > Following a rework, external message handlers were receiving a pointer > to a vhost_user message (as stated in the API), but lost the ability to > interact with fds attached to the message. > Restore the original layout and put a build chec

RE: [PATCH v4] app/pdump: check lcore is not the maximum core

2022-03-08 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon > Subject: Re: [PATCH v4] app/pdump: check lcore is not the maximum core > > 08/03/2022 14:47, Mcnamara, John: > > Thomas, could you include this in RC3 if possible. > > I did already yesterday: > https://git.dpdk.org/dpdk/commit/?id=3

RE: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2022-03-08 Thread Jeff Daly
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, March 6, 2022 12:56 PM > To: Wang, Haiyue ; Zhang, Qi Z > ; ferruh.yi...@intel.com > Cc: Jeff Daly ; dev@dpdk.org; sta...@dpdk.org; > Stephen Douthit ; Lu, Wenzhuo > > Subject: Re: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp()

RE: [PATCH] examples/distributor: one Tx queue is enough

2022-03-08 Thread Tu, Lijuan
> Do we know why DTS is making this change? Does having more TX queues than > necessary cause problems? DTS is to reduce tx queues to enable many workers for performance testing. Distributor application creates one Tx queue per core, and total (lcore-1) queues, Which make it only 1 worker, but i

[PATCH 5/5] doc/linux_gsg: expand list of directories

2022-03-08 Thread Bruce Richardson
Not all directories were given in the GSG document, but many of those omitted would be of interest to users, e.g. "doc", "license" and "usertools" directories. Adding these leaves only "devtools", and "kernel" as the only undocumented directories, so add them in too for completeness. When updating

[PATCH 4/5] doc/linux_gsg: merge requirements section for app building

2022-03-08 Thread Bruce Richardson
When building end-applications linked with DPDK, the only additional tool needed is pkg-config/pkgconf. However, the standard development tools meta-packages on most distro's include this as standard, meaning it does not really require its own section. The one outlier in the existing text is "alpin

[PATCH 3/5] doc/linux_gsg: remove duplicated note

2022-03-08 Thread Bruce Richardson
A note about secure boot not allowing uio is present in both the system requirements section and the driver binding section. This fits better in the driver binding section, so the copy in system requirements can be removed. The document in general now also emphasises vfio over uio more than when th

[PATCH 2/5] doc/linux_gsg: drop note about old chipset

2022-03-08 Thread Bruce Richardson
The chipsets referenced in the note[1] were all launched in 2012 and are now discontinued, so we can drop the note about them at this stage. [1] https://ark.intel.com/content/www/us/en/ark/products/codename/44946/products-formerly-cave-creek.html Signed-off-by: Bruce Richardson --- doc/guides/

[PATCH 1/5] doc/linux_gsg: add driver guides to document list

2022-03-08 Thread Bruce Richardson
The document roadmap section was missing any mention of the individual drivers guides which are important for users. Add them to list. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/intro.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/guides/linu

[PATCH 0/5] Small Doc improvements for Linux GSG

2022-03-08 Thread Bruce Richardson
This patchset contains a number of small documentation improvements for the linux GSG, spread across a few sections. Bruce Richardson (5): doc/linux_gsg: add driver guides to document list doc/linux_gsg: drop note about old chipset doc/linux_gsg: remove duplicated note doc/linux_gsg: merge

Re: [PATCH v2] vhost: fix external message handlers

2022-03-08 Thread Christophe Fontaine
On Tue, Mar 8, 2022 at 10:44 AM David Marchand wrote: > > Following a rework, external message handlers were receiving a pointer > to a vhost_user message (as stated in the API), but lost the ability to > interact with fds attached to the message. > Restore the original layout and put a build chec

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-03-08 Thread Thomas Monjalon
15/02/2022 16:31, Bruce Richardson: > On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > > When building with Meson 0.61.1 on FreeBSD some archives become > > corrupted. This can be avoided by using 'llvm-ar' instead of 'ar'. > > > > Signed-off-by: Karl Bonde Torp > > --- > > bui

Re: [PATCH] net/tap: do not include l2 header in gso size when compared with mtu

2022-03-08 Thread Harold Huang
On Mon, Feb 28, 2022 at 4:27 PM Harold Huang wrote: > > The gso size is calculated with all of the headers and payload. As a > result, the l2 header should not be included when comparing gso size > with mtu. > > Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") > Cc: sta...@dpdk.o

Re: [PATCH v2 0/2] add missing local symbols catch-all

2022-03-08 Thread Thomas Monjalon
08/03/2022 15:24, Thomas Monjalon: > The libraries (and driver) regexdev, gpudev and auxiliary bus > were missing "local:*" in their version.map linker script > which catch all non-listed functions to be hidden in shared libraries. > > v2: add a devtools check > > Thomas Monjalon (2): > regexde

Re: [PATCH] gpu/cuda: missing slash in libcuda.so path

2022-03-08 Thread Thomas Monjalon
08/03/2022 15:24, Elena Agostini: > Yes please > > Thanks > EA > > From: Kevin Traynor > > Hi Elena, > > On 07/03/2022 21:47, Thomas Monjalon wrote: > > 01/03/2022 20:42, eagost...@nvidia.com: > >> From: Elena Agostini > >> > >> Signed-off-by: Elena Agostini > > > > Applied with this title a

Re: [PATCH v4] app/pdump: check lcore is not the maximum core

2022-03-08 Thread Thomas Monjalon
08/03/2022 14:47, Mcnamara, John: > Thomas, could you include this in RC3 if possible. I did already yesterday: https://git.dpdk.org/dpdk/commit/?id=3ee04ebc91 Looks like I forgot to send an email. Applied, thanks :)

Re: [PATCH] gpu/cuda: missing slash in libcuda.so path

2022-03-08 Thread Elena Agostini
Yes please Thanks EA From: Kevin Traynor Date: Tuesday, 8 March 2022 at 15:24 To: Elena Agostini Cc: dev@dpdk.org , NBU-Contact-Thomas Monjalon (EXTERNAL) Subject: Re: [PATCH] gpu/cuda: missing slash in libcuda.so path External email: Use caution opening links or attachments Hi Elena, On 0

[PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-08 Thread Gaoxiang Liu
The following log message may appear after a slave is idle(or nearly idle) for a few minutes:"PMD: Failed to allocate LACP packet from pool". And bond mode 4 negotiation may fail. Problem:When bond mode 4 has been chosed and delicated queue has not been enable, all mbufs from a slave' private pool

[PATCH v2 2/2] build: hide local symbols in shared libraries

2022-03-08 Thread Thomas Monjalon
The symbols which are not listed in the version script are exported by default. Adding a local section with a wildcard make non-listed functions and variables as hidden, as it should be in all version.map files. These are the changes done in the shared libraries: - DF .text Base auxiliar

[PATCH v2 1/2] regexdev: fix section attribute of symbols

2022-03-08 Thread Thomas Monjalon
The functions used by the drivers must be internal, while the function and variables used in inline functions must be experimental. These are the changes done in the shared library: - DF .text Base rte_regexdev_get_device_by_name + DF .text INTERNAL rte_regexdev_get_device_by_name

[PATCH v2 0/2] add missing local symbols catch-all

2022-03-08 Thread Thomas Monjalon
The libraries (and driver) regexdev, gpudev and auxiliary bus were missing "local:*" in their version.map linker script which catch all non-listed functions to be hidden in shared libraries. v2: add a devtools check Thomas Monjalon (2): regexdev: fix section attribute of symbols build: hide l

Re: [PATCH] gpu/cuda: missing slash in libcuda.so path

2022-03-08 Thread Kevin Traynor
Hi Elena, On 07/03/2022 21:47, Thomas Monjalon wrote: 01/03/2022 20:42, eagost...@nvidia.com: From: Elena Agostini Signed-off-by: Elena Agostini Applied with this title and commit log: gpu/cuda: fix dependency loading path A slash was missing in libcuda.so path for dlopen.

RE: [PATCH v2] vhost: fix external message handlers

2022-03-08 Thread Poczatek, Jakub
Hi everyone, > Following a rework, external message handlers were receiving a pointer > to a vhost_user message (as stated in the API), but lost the ability > to interact with fds attached to the message. > Restore the original layout and put a build check and reminders. > > Bugzilla ID: 953 >

Re: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers

2022-03-08 Thread Thomas Monjalon
02/03/2022 11:16, Ray Kinsella: > > David Marchand writes: > > > Convert the existing exception in the ABI script into a libabigail > > suppression rule. > > > > Note: file_name_regexp could be used to achive the same with versions of > > libabigail < 1.7 but soname_regexp has been preferred her

Question about commit 44dddd14059 in DPDK e1000 driver

2022-03-08 Thread Francesco Mancino
I have a question about some changes to the e1000 driver that where committed in 2020 (commit 4414059f151f39f7e075b887decfc9a10f11). I see that e1000_power_down_phy_copper_82575 has been replaced by e1000_power_down_phy_copper_base, but the two functions are not the same. more specificall

Re: [PATCH v2 1/3] common/mlx5: add Netlink event helpers

2022-03-08 Thread Kevin Traynor
On 02/03/2022 15:56, Dmitry Kozlyuk wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit [...] Hi Dmitry, For clarification, this patch is not fix, but it is requested to be backported to be able to backport fixes in this patchset, right? Yes. The updated API is internal so t

RE: [PATCH v4] app/pdump: check lcore is not the maximum core

2022-03-08 Thread Mcnamara, John
Thomas, could you include this in RC3 if possible. > -Original Message- > From: Reshma Pattan > Sent: Monday, February 28, 2022 9:59 AM > To: dev@dpdk.org > Cc: step...@networkplumber.org; Yigit, Ferruh ; > Pattan, Reshma ; vipin.vargh...@intel.com; > sta...@dpdk.org > Subject: [PATCH v4]

Re: [PATCH v3] devtools/cocci: update cocci for ethdev namespace

2022-03-08 Thread Thomas Monjalon
07/03/2022 15:27, Aman Singh: > Changed the filter from ETH_SPEED to ETH_SPEED_NUM to make the match > more specific. Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA > as these were missed before. > > Signed-off-by: Aman Singh Applied, thanks.

Re: [PATCH] examples/kni: add CR character at print log

2022-03-08 Thread Thomas Monjalon
07/03/2022 15:52, Ferruh Yigit: > On 3/7/2022 9:05 AM, Tianli Lai wrote: > > add CR character at print link state information > > > > Signed-off-by: Tianli Lai > > --- > > examples/kni/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/kni/main.c b/

Re: [PATCH] examples/vm_power: replace list foreach with while loop

2022-03-08 Thread Thomas Monjalon
01/03/2022 15:53, Shibin Koikkara Reeny: > Linux header files don't support LIST_FOREACH_SAFE so replacing > LIST_FOREACH with while loop. What is the original issue you are trying to solve? > - struct virtual_machine_info *vm_info; > - > - LIST_FOREACH(vm_info, &vm_list_head, vms_info) {

Re: [PATCH v3] examples/multi_process: reconfigure port when rss or csum isn't supported

2022-03-08 Thread Thomas Monjalon
28/02/2022 08:55, Ling, WeiX: > From: Bruce Richardson > > On Tue, Feb 22, 2022 at 10:51:27AM +, Wenwu Ma wrote: > > > The default values of rx mq_mode and rx offloads for port will cause > > > symmetric_mp startup failure if the port do not support rss or csum. > > > This Patch make the app t

Re: [PATCH] usertools: add check for IOMMU support in dpdk-devbind

2022-03-08 Thread Bruce Richardson
On Tue, Mar 08, 2022 at 05:49:01PM +0500, Fidaullah Noonari wrote: > binding with vfio driver, when IOMMU is disabled, causes program to crash. > this patch checks for IOMMU support, if it is disabled, changes vfio > into unsafe noiommu mode and prints a warning message. > > Signed-off-by: Fidaull

[PATCH] usertools: add check for IOMMU support in dpdk-devbind

2022-03-08 Thread Fidaullah Noonari
binding with vfio driver, when IOMMU is disabled, causes program to crash. this patch checks for IOMMU support, if it is disabled, changes vfio into unsafe noiommu mode and prints a warning message. Signed-off-by: Fidaullah Noonari --- usertools/dpdk-devbind.py | 25 + 1

RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-08 Thread Raslan Darawsheh
> -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, March 8, 2022 2:23 PM > To: Raslan Darawsheh > Cc: Thinh Tran ; dev@dpdk.org; > d...@linux.vnet.ibm.com > Subject: Re: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl > > Hi Raslan, > > > Missing: > > Fixes tag:

Re: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-08 Thread Dmitry Kozlyuk
Hi Raslan, > Missing: > Fixes tag: > > Fixes: 5ceb3a02b000 ("net/mlx5: move Rx queue DevX resource") > Cc: xuemi...@nvidia.com I believe the bug originates from my earlier commit, not Xueming's one: Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")

Re: [PATCH] net/sfc: do not spam logs on tunnel restore info errors

2022-03-08 Thread Ferruh Yigit
On 3/6/2022 4:12 PM, Ivan Malov wrote: OvS might invoke this API on its data path, out of sync with its control plane. If the control path has already deactivated the tunnel context entry, these invocations will produce quite a few error printouts. Suppress that. Fixes: 7e5b479803c3 ("net/sfc: i

RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-08 Thread Raslan Darawsheh
Hi Thinh, > -Original Message- > From: Thinh Tran > Sent: Tuesday, March 8, 2022 12:53 AM > To: dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Thinh Tran > Subject: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl > This is a fix, so it's better to start commit title with a fi

RE: [PATCH] examples/flow_classify: fix spelling when log error

2022-03-08 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 11:44 AM > To: Chuanshe Zhang > Cc: dev@dpdk.org; Iremonger, Bernard > Subject: Re: [PATCH] examples/flow_classify: fix spelling when log error > > 23/02/2022 17:05, Iremonger, Bernard: > > Hi Chuans

Re: [PATCH] examples/flow_classify: fix spelling when log error

2022-03-08 Thread Thomas Monjalon
23/02/2022 17:05, Iremonger, Bernard: > Hi Chuanshe, > > From: Chuanshe Zhang > > > > Signed-off-by: Chuanshe Zhang > > --- > > - flow_classify_log("failed to read source address/mask: > > %s\n", > > + flow_classify_log("failed to read destination address/mask: > > %s\n", >

Re: [PATCH] examples/distributor: one Tx queue is enough

2022-03-08 Thread Thomas Monjalon
08/03/2022 11:00, Bruce Richardson: > On Mon, Mar 07, 2022 at 10:39:46PM +, Honnappa Nagarahalli wrote: > > Distributor application creates one Tx queue per core. However > > the transmit is done only from a single core. Hence creating > > one Tx queue is enough. > > > > Fixes: 07db4a975094 ("

Re: [PATCH] examples/l3fwd: resolve stack buffer overflow issue

2022-03-08 Thread Thomas Monjalon
11/01/2022 13:50, Rahul Bhansali: > This patch fixes the stack buffer overflow error reported > from AddressSanitizer. > Function send_packetsx4() tries to access out of bound data > from rte_mbuf and fill it into TX buffer even in the case > where no pending packets (len = 0). > Performance impact

Re: [PATCH] net/hinic: fix Tx mbuf length problem

2022-03-08 Thread Ferruh Yigit
On 3/7/2022 4:06 PM, Stephen Hemminger wrote: On Mon, 7 Mar 2022 22:12:20 +0800 Junjie Lin <277600...@qq.com> wrote: From: Junjie Lin The Tx mbuf needs to be ignored if the pkt_len member is zero. Fixes: 54faba2295bd ("net/hinic:adds Tx queue xstats members") Cc: sta...@dpdk.org Signed-off

RE: [PATCH] crypto/qat: fix structurally dead code

2022-03-08 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, February 28, 2022 4:06 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: fix structurally dead code > > This patch fixes structurally dead code in QAT > as

Re: [PATCH v2] vhost: fix external message handlers

2022-03-08 Thread Maxime Coquelin
On 3/8/22 10:44, David Marchand wrote: Following a rework, external message handlers were receiving a pointer to a vhost_user message (as stated in the API), but lost the ability to interact with fds attached to the message. Restore the original layout and put a build check and reminders. Bug

RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-08 Thread Matan Azrad
From: Thinh Tran > I hit a failure during ports drop queue RQ creation when my adapters are on > CPU > socket ID 1 instead of socket ID 0: > > EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.0 (socket 1) > EAL: set_mempolicy failed: Invalid argument > mlx5_common: Failed to al

RE: [PATCH] maintainers: Update MAINTAINERS for FIPS validation

2022-03-08 Thread Zhang, Roy Fan
> -Original Message- > From: Dooley, Brian > Sent: Monday, March 7, 2022 3:14 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Dooley, Brian ; Kovacevic, > Marko ; Zhang, Roy Fan > ; Akhil Goyal ; Thomas > Monjalon > Subject: [PATCH] maintainers: Update MAINTAINERS for FIPS validation > > Re

Re: [PATCH] examples/distributor: one Tx queue is enough

2022-03-08 Thread Bruce Richardson
On Mon, Mar 07, 2022 at 10:39:46PM +, Honnappa Nagarahalli wrote: > Distributor application creates one Tx queue per core. However > the transmit is done only from a single core. Hence creating > one Tx queue is enough. > > Fixes: 07db4a975094 ("examples/distributor: new sample app") > Cc: bru

[PATCH] ethdev: fix doxygen comment for device info struct

2022-03-08 Thread Ferruh Yigit
API documentation for "struct rte_eth_dev_info" was missing some fields 'device' & 'max_hash_mac_addrs', because of syntax error in doxygen comment, fixing it. Bugzilla ID: 954 Fixes: 88ac4396ad29 ("ethdev: add VMDq support") Fixes: cd8c7c7ce241 ("ethdev: replace bus specific struct with generic d

[PATCH v2] vhost: fix external message handlers

2022-03-08 Thread David Marchand
Following a rework, external message handlers were receiving a pointer to a vhost_user message (as stated in the API), but lost the ability to interact with fds attached to the message. Restore the original layout and put a build check and reminders. Bugzilla ID: 953 Fixes: 5e0099dc709e ("vhost: r

[PATCH] eal/linux: enable the hugepage mem dump

2022-03-08 Thread Li Feng
These hugepages include important structures. We should dump these hugepages into a coredump file for debugging when generating a coredump. Signed-off-by: Li Feng --- lib/eal/linux/eal_memalloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/e

Re: [PATCH 1/2] app/testpmd: add test for remote PD and CTX

2022-03-08 Thread Thomas Monjalon
07/03/2022 17:07, Michael Baum: > On 3/3/2022 2:57 PM, Ferruh Yigit wrote: > > Hi Michael, > > > > This is too much mlx5 specific addition, and I don't think it is good to > > extend > > testpmd with PMD specific code. > > If we enable it, sure there will be other vendors willing to do the same,

Re: [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code

2022-03-08 Thread Thomas Monjalon
> nb_rxd and nb_txd are used in polling mode and event mode of operation. > nb_rxd and nb_txd are already global in polling mode but are not visible to > event mode code. Make them visible to all parts of the application. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Kathleen Capella

RE: [PATCH] net/mlx5: fix IPv6 flow item validation for VERB API

2022-03-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Monday, March 7, 2022 7:18 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko ; Dekel Peled > ; Ori Kam > Subject: [PATCH] net/mlx5: fix IPv6 flow item validation for

Re: [PATCH v6 0/2] Add config file support for l3fwd

2022-03-08 Thread Thomas Monjalon
01/03/2022 15:49, Sean Morrissey: > This patchset introduces config file support for l3fwd > and its lookup methods LPM, FIB, and EM, similar to > that of l3fwd-acl. This allows for route rules to be > defined in configuration files and edited there instead > of in each of the lookup methods hardco

Re: [PATCH] vhost: fix external message handlers

2022-03-08 Thread Maxime Coquelin
On 3/8/22 09:37, David Marchand wrote: On Tue, Mar 8, 2022 at 9:34 AM Maxime Coquelin wrote: On 3/7/22 19:11, David Marchand wrote: Following a rework, external message handlers were receiving a pointer to a vhost_user message (as stated in the API), but lost the ability to interact with fd

Re: [PATCH] vhost: fix external message handlers

2022-03-08 Thread David Marchand
On Tue, Mar 8, 2022 at 9:34 AM Maxime Coquelin wrote: > On 3/7/22 19:11, David Marchand wrote: > > Following a rework, external message handlers were receiving a pointer > > to a vhost_user message (as stated in the API), but lost the ability to > > interact with fds attached to the message. > > R

Re: [PATCH] vhost: fix external message handlers

2022-03-08 Thread Maxime Coquelin
Hi, On 3/7/22 19:11, David Marchand wrote: Following a rework, external message handlers were receiving a pointer to a vhost_user message (as stated in the API), but lost the ability to interact with fds attached to the message. Restore the original layout and put a build check and reminders. B

Re: [PATCH] app/dumpcap: allow help/version without primary process

2022-03-08 Thread Thomas Monjalon
22/02/2022 11:03, Thomas Monjalon: > 25/01/2022 04:25, Ben Magistro: > > Currently dumpcap tries to initialize dpdk before parsing command line > > arguments, this makes it impossible to check version or help without > > having the primary process running already. > > > > Signed-off-by: Ben Magist

Re: [PATCH 0/3] small fixes suggested by Coverity scan

2022-03-08 Thread Thomas Monjalon
11/02/2022 00:09, Stephen Hemminger: > Fix some simple bugs. > > Stephen Hemminger (3): > pcapng: handle rte_ethlink_get failing > app/test_bpf: don't print eBPF program if NULL > app/dumpcap: check for failure to set promiscious Improved titles and applied, thanks.

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-08 Thread Thierry Herbelot
Hello, After upgrading the firmware on the bnxt NIC, the NIC is correctly detected by a DPDK application with both DPDK-v20.11 and DPDK-v21.11. Regards Thierry On 3/4/22 01:56, Honnappa Nagarahalli wrote: + Ruifeng On Wed, Mar 2, 2022 at 9:28 AM Thierry Herbelot wrote:

[Bug 955] build failure in qos_sched example app

2022-03-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=955 Bug ID: 955 Summary: build failure in qos_sched example app Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Prior

RE: [PATCH] raw/ntb: add check for DB intr handler registering

2022-03-08 Thread Guo, Junfeng
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 16:10 > To: Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] raw/ntb: add check for DB intr handler registering > > 08/03/2022 09:08, Guo, Junfeng: > > From: Thomas Monj

Re: [PATCH] raw/ntb: add check for DB intr handler registering

2022-03-08 Thread Thomas Monjalon
08/03/2022 09:08, Guo, Junfeng: > From: Thomas Monjalon > > There is no formal ack. What is the status of this patch? > > > > Thanks for the reminding! > Currently, we agreed that this fix is not for the root cause of no response > of doorbell > interrupt when building the connection between tw

RE: [PATCH] raw/ntb: add check for DB intr handler registering

2022-03-08 Thread Guo, Junfeng
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 01:07 > To: Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] raw/ntb: add check for DB intr handler registering > > 10/02/2022 11:43, Guo, Junfeng: > > > > > -Origin

  1   2   >