RE: [PATCH v6] net/i40e: rework maximum frame size configuration

2023-03-23 Thread Jiang, YuX
> -Original Message- > From: Kevin Traynor > Sent: Thursday, March 23, 2023 10:51 PM > To: Zhang, Qi Z ; Su, Simei ; Xing, > Beilei ; Zhang, Yuying ; > david.march...@redhat.com; Jiang, YuX > Cc: dev@dpdk.org; Yang, Qiming ; sta...@dpdk.org; > Luca Boccassi ; Mcnamara, John > > Subject:

[RFC PATCH] ethdev: add flow item for RoCE infiniband BTH

2023-03-23 Thread dong zhou
From: Dong Zhou IB(InfiniBand) is one type of networking used in high-performance computing with high throughput and low latency. Like Ethernet, IB defines a layered protocol (Physical, Link, Network, Transport Layers). IB provides native support for RDMA(Remote DMA), an extension of the DMA that

[PATCH v2 15/15] doc: update multicore dispatch model in graph guides

2023-03-23 Thread Zhirun Yan
Update graph documentation to introduce new multicore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- doc/guides/prog_guide/graph_lib.rst | 59 +++-- 1 file changed, 55 insertions(+), 4 deletions(-) diff --git a/doc

[PATCH v2 14/15] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-03-23 Thread Zhirun Yan
Add new parameter "model" to choose dispatch or rtc worker model. And in dispatch model, the node will affinity to worker core successively. Note: only support one RX node for remote model in current implementation. ./dpdk-l3fwd-graph -l 8,9,10,11 -n 4 -- -p 0x1 --config="(0,0,9)" -P --model="di

[PATCH v2 13/15] graph: add stats for corss-core dispatching

2023-03-23 Thread Zhirun Yan
Add stats for cross-core dispatching scheduler if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_debug.c | 6 +++ lib/graph/graph_stats.c | 74 +--- lib/graph/

[PATCH v2 12/15] graph: enable graph multicore dispatch scheduler model

2023-03-23 Thread Zhirun Yan
This patch enables to chose new scheduler model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_worker.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/graph/rte_graph_worker.h b/lib/graph/rte_graph_wor

[PATCH v2 11/15] graph: introduce graph walk by cross-core dispatch

2023-03-23 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v2 10/15] graph: enable create and destroy graph scheduling workqueue

2023-03-23 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/graph.c

[PATCH v2 09/15] graph: introduce stream moving cross cores

2023-03-23 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h| 27 + lib/graph/m

[PATCH v2 08/15] graph: add struct for stream moving between cores

2023-03-23 Thread Zhirun Yan
Add graph_sched_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 1 + lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v2 07/15] graph: introduce graph clone API for other worker core

2023-03-23 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 110 ++

[PATCH v2 06/15] graph: introduce graph bind unbind API

2023-03-23 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan ---

[PATCH v2 05/15] graph: introduce graph node core affinity API

2023-03-23 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h| 1 + lib/graph/meson.build

[PATCH v2 04/15] graph: add get/set graph worker model APIs

2023-03-23 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c| 54 +++

[PATCH v2 03/15] graph: move node process into inline function

2023-03-23 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33 +++

[PATCH v2 02/15] graph: split graph worker into common and default model

2023-03-23 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_pcap.c

[PATCH v2 01/15] graph: rename rte_graph_work as common

2023-03-23 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- MAINTAINERS | 1 + lib/graph/graph_pcap.c

[PATCH v2 00/15] graph enhancement for multi-core dispatch

2023-03-23 Thread Zhirun Yan
V2: Use git mv to keep git history for patch 1,2. Use TLS for per-thread local storage about model setting in patch 4. Change model name to mcore dispatch. Change API with specific mode name. Split big patch for patch 8,9. Fix CI build issues. Rebase l3fwd-graph example. Update doc and maintainers

RE: [EXT] Re: [PATCH] kni: fix build with Linux 6.3

2023-03-23 Thread Vamsi Krishna Attunuru
> -Original Message- > From: David Marchand > Sent: Monday, March 20, 2023 6:31 PM > To: Ferruh Yigit ; Vamsi Krishna Attunuru > ; Kiran Kumar Kokkilagadda > ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Thomas Monjalon > Subject: [EXT] Re: [PATCH] kni: fix build with Linux 6.3 >

RE: [PATCH v1] doc/guides/nics: remove limitation of ipn3ke

2023-03-23 Thread Huang, Wei
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 23, 2023 16:53 > To: dev@dpdk.org; david.march...@redhat.com; Huang, Wei > > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: Re: [PATCH v1] doc/guides/nics: remove limitation

RE: [PATCH v1] raw/ifpga: remove virtual device unplug operation

2023-03-23 Thread Huang, Wei
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 23, 2023 16:52 > To: Huang, Wei > Cc: dev@dpdk.org; david.march...@redhat.com; sta...@dpdk.org; Xu, > Rosen ; Zhang, Tianfei ; > Zhang, Qi Z > Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation

Re: Commit broke 32-bit testpmd app

2023-03-23 Thread Roger Melton (rmelton)
Hi Maxime/Chenbo, Have you had a chance to look at the data Sampath provided? Regards, Roger On 1/30/23 3:29 PM, Sampath Peechu (speechu) wrote: Hi Maxime, Could you please let us know if you got a chance to look at the debugs logs I provided? Thanks, Sampath From: Sampath Peechu (speechu)

[PATCH] net/mlx5: fix CQEs dumping for Tx

2023-03-23 Thread Alexander Kozyrev
The regular CQE size can be 64 bytes or 128 bytes depending on the cache line size. The error CQE is always 64 bytes long. Only 64 bytes are dumped to the log file in case of Tx queue recovery form the error. Use the CQE size, not the error CQE size. Fixes: 957e45fb7b ("net/mlx5: handle Tx complet

[PATCH v3 5/7] net/ixgbe: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/ixgbe/ixgbe_bypass.c | 1 - drivers/net/ixgbe/ixgbe_ethdev.c | 18 -- drivers/net/ixgbe/ixgbe_ethdev.h | 3 ++- drivers/net/i

[PATCH v3 6/7] net/null: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/null/rte_eth_null.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/net/null/rte_eth

[PATCH v3 7/7] net/ring: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/ring/rte_eth_ring.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/net/ring/rte_eth_r

[PATCH v3 1/7] ring: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- lib/ring/rte_ring_core.h| 1 - lib/ring/rte_ring_generic_pvt.h | 12 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/l

[PATCH v3 4/7] net/ice: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/ice_dcf.c| 1 - drivers/net/ice/ice_dcf_ethdev.c | 1 - drivers/net/ice/ice_ethdev.c | 12 3 files changed, 8 in

[PATCH v3 3/7] dma/idxd: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/dma/idxd/idxd_internal.h | 3 +-- drivers/dma/idxd/idxd_pci.c | 8 +--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH v3 2/7] stack: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- lib/stack/rte_stack_lf_generic.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/stack/rte_stack_lf_generic.h b/li

[PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. This series covers the libraries and drivers that are built on Windows. The code has be converted to use the __atomic builtins but there are additional during conversion i notice that there

[PATCH v2 7/7] net/ring: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/ring/rte_eth_ring.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/net/ring/rte_eth_r

[PATCH v2 6/7] net/null: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/null/rte_eth_null.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/net/null/rte_eth

[PATCH v2 5/7] net/ixgbe: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/ixgbe/ixgbe_bypass.c | 1 - drivers/net/ixgbe/ixgbe_ethdev.c | 18 -- drivers/net/ixgbe/ixgbe_ethdev.h | 3 ++- drivers/net/i

[PATCH v2 4/7] net/ice: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/ice_dcf.c| 1 - drivers/net/ice/ice_dcf_ethdev.c | 1 - drivers/net/ice/ice_ethdev.c | 12 3 files changed, 8 in

[PATCH v2 3/7] dma/idxd: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- drivers/dma/idxd/idxd_internal.h | 3 +-- drivers/dma/idxd/idxd_pci.c | 8 +--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH v2 2/7] stack: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- lib/stack/rte_stack_lf_generic.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/stack/rte_stack_lf_generic.h b/li

[PATCH v2 0/7] replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. This series covers the libraries and drivers that are built on Windows. The code has be converted to use the __atomic builtins but there are additional during conversion i notice that there

[PATCH v2 1/7] ring: replace rte atomics with GCC builtin atomics

2023-03-23 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff --- lib/ring/rte_ring_core.h| 1 - lib/ring/rte_ring_generic_pvt.h | 12 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/l

RE: [PATCH] net/mlx5/hws: fix IPv4 frag matching

2023-03-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Thursday, March 23, 2023 2:34 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Matan > Azrad > Cc: dev@dpdk.org; Ori Kam ; Hamdan Igbaria > ; sta...@dpdk.org > Subject: [PATCH] net/ml

RE: [PATCH] net/mlx5/hws: fix send sync drain empty queue check

2023-03-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Thursday, March 23, 2023 2:34 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Matan > Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5/hws: fix send sync drain empty q

RE: [PATCH] net/mlx5/hws: fix return value of send queue action

2023-03-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Thursday, March 23, 2023 2:34 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Matan > Azrad > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: [PATCH] net/mlx5/hws: fix return

RE: [PATCH] doc: update mlx5 limitations on ESP header match

2023-03-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, March 22, 2023 5:07 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] doc: update mlx5 limitations on ESP header match > > The match on ESP header is supported over PF only. > >

[PATCH v2 2/2] devtools: stop depending on libabigail xml format

2023-03-23 Thread David Marchand
A ABI reference depends on: - DPDK build options, - toolchain compiler and versions, - libabigail version. The reason for the latter point is that, when the ABI reference was generated, ABI xml files were dumped in a format depending on the libabigail version. Those xml files were then later used

[PATCH v2 0/2] ABI check updates

2023-03-23 Thread David Marchand
This series moves ABI exceptions in a single configuration file and simplifies the ABI check so that no artefact depending on libabigail version is stored in the CI. -- David Marchand Changes since v1: - rebased after abi check parallelisation rework, David Marchand (2): devtools: unify conf

[PATCH v2 1/2] devtools: unify configuration for ABI check

2023-03-23 Thread David Marchand
We have been skipping removed libraries in the ABI check by updating the check-abi.sh script itself. See, for example, commit 33584c19ddc2 ("raw/dpaa2_qdma: remove driver"). Having two places for exception is a bit confusing, and those exceptions are best placed in a single configuration file out

[Bug 1198] Tap driver incorrectly uses globally unique ID when "mac=fixed" is specified

2023-03-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1198 Bug ID: 1198 Summary: Tap driver incorrectly uses globally unique ID when "mac=fixed" is specified Product: DPDK Version: 23.03 Hardware: All OS: All St

[PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-03-23 Thread David Christensen
Building DPDK with gcc 12 on a ppc64le system generates a stringop-overflow warning. Replace the local MAC address validation function parse_user_mac() with a call to rte_ether_unformat_addr() instead. Bugzilla ID: 1197 Cc: sta...@dpdk.org Signed-off-by: David Christensen --- v2: * Added NULL ch

Re: [PATCH] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-03-23 Thread David Christensen
On 3/22/23 4:43 PM, Stephen Hemminger wrote: static int set_mac_type(const char *key __rte_unused, const char *value, @@ -2311,7 +2288,7 @@ set_mac_type(const char *key __rte_unused, goto success; } - if (parse_user_mac(user_mac, value) != 6) + i

[PATCH 1/1] app/mldev: fix code formatting and alignment

2023-03-23 Thread Srikanth Yalavarthi
Updated ML application source files to have uniform code formatting style across. Remove extra blank lines. Fixes: 8cb22a545447 ("app/mldev: fix debug build") Fixes: c9f073cdca95 ("mldev: remove unnecessary null checks") Fixes: da6793390596 ("app/mldev: support inference validation") Signed-off-b

[PATCH 1/1] app/mldev: add check for model and filelist option

2023-03-23 Thread Srikanth Yalavarthi
Application currently doesn't check for empty models list and filelist entries. This causes the app to report an incorrect error messages and test status when the lists are empty. Fixes: bbd272edcb14 ("app/mldev: add ordered inferences") Fixes: f6661e6d9a3a ("app/mldev: validate model operations")

Re: [PATCH] app/testpmd: display RSS hash key of rte flow rule

2023-03-23 Thread Ferruh Yigit
On 3/16/2023 12:58 PM, Dongdong Liu wrote: > From: Huisong Li > > There are two ways to set RSS hash key with rte flow rule: > 1. 'key_len' isn't zero and 'key' is NULL. > 2. 'key_len' isn't zero and 'key' isn't NULL. > This patch adds displaying for the hash key of rte flow rule. > > Signed-off

Re: [PATCH v3] net/iavf: fix iavf query stats in intr thread

2023-03-23 Thread Ferruh Yigit
On 3/22/2023 7:26 AM, Kaiwen Deng wrote: > When iavf send query-stats command in eal-intr-thread through > virtual channel, there will be no response received from > iavf_dev_virtchnl_handler for this command during block and wait. > Because iavf_dev_virtchnl_handler is also registered in eal-intr-

[PATCH 1/1] app/mldev: add internal function for file read

2023-03-23 Thread Srikanth Yalavarthi
Added internal function to read model, input and reference files with required error checks. This change fixes the unchecked return value and improper use of negative value issues reported by coverity scan for file read operations. Coverity issue: 383742, 383743 Fixes: f6661e6d9a3a ("app/mldev: va

Re: [PATCH v6] net/i40e: rework maximum frame size configuration

2023-03-23 Thread Kevin Traynor
On 22/03/2023 16:50, Kevin Traynor wrote: On 27/02/2023 00:35, Zhang, Qi Z wrote: Hi Simei/Qi/Yu Hi Yu, -Original Message- From: Su, Simei Sent: Monday, February 20, 2023 4:00 PM To: Xing, Beilei ; Zhang, Yuying ; Zhang, Qi Z ; david.march...@redhat.com Cc: dev@dpdk.org; Yang,

Re: [PATCH] vhost: fix deadlock with no multiqueue

2023-03-23 Thread Maxime Coquelin
On 3/23/23 15:44, David Marchand wrote: This deadlock happens when a guest, that had virtio ports with multi queues configured, does not announce the multi q feature in SET_FEATURES. In such a situation, all vq locks are already taken before calling free_vq(), which itself takes the lock. As

[PATCH] vhost: fix deadlock with no multiqueue

2023-03-23 Thread David Marchand
This deadlock happens when a guest, that had virtio ports with multi queues configured, does not announce the multi q feature in SET_FEATURES. In such a situation, all vq locks are already taken before calling free_vq(), which itself takes the lock. As mentioned in the code, in this situation, the

Re: [dpdk-dev] [RFC] ethdev: improve link speed to string

2023-03-23 Thread Ferruh Yigit
On 2/10/2023 2:41 PM, Ferruh Yigit wrote: > On 1/19/2023 4:45 PM, Stephen Hemminger wrote: >> On Thu, 19 Jan 2023 11:41:12 + >> Ferruh Yigit wrote: >> >>> Nothing good will happen if you try to use the function to >>> print two different link speeds in one log message. >> You are

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2023-03-23 Thread Dmitry Kozlyuk
2023-03-23 13:13 (UTC+), Ferruh Yigit: > On 6/6/2022 8:53 AM, Michał Krawczyk wrote: > > sob., 21 maj 2022 o 00:08 Ferruh Yigit napisał(a): > >> > >> On 8/30/2021 3:05 PM, William Tu wrote: > >>> On Mon, Aug 30, 2021 at 12:12 AM Michał Krawczyk > >>> wrote: > >>> [...] > Hi Willia

Re: [PATCH v2 41/44] event/opdl: fix segment fault when parse devargs

2023-03-23 Thread Liang Ma
On Mon, Mar 20, 2023 at 09:21:07AM +, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault whe

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2023-03-23 Thread Ferruh Yigit
On 6/6/2022 8:53 AM, Michał Krawczyk wrote: > sob., 21 maj 2022 o 00:08 Ferruh Yigit napisał(a): >> >> On 8/30/2021 3:05 PM, William Tu wrote: >>> On Mon, Aug 30, 2021 at 12:12 AM Michał Krawczyk wrote: >>> [...] Hi William, It's great to hear that you're working on ENA support for

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2023-03-23 Thread Ferruh Yigit
On 6/3/2021 10:27 AM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> >> Hi Ori, >> >> Cc Eli and Ilya since I think OvS could be interested in the feature. >> >> On 6/3/21 11:25 AM, Ori Kam wrote: >>> Hi Andrew, >>> -Original Message- Fr

Re: [PATCH 0/5] fix segment fault when parse args

2023-03-23 Thread Thomas Monjalon
23/03/2023 12:58, fengchengwen: > On 2023/3/22 21:49, Thomas Monjalon wrote: > > 22/03/2023 09:53, Ferruh Yigit: > >> On 3/22/2023 1:15 AM, fengchengwen wrote: > >>> On 2023/3/21 21:50, Ferruh Yigit wrote: > On 3/17/2023 2:43 AM, fengchengwen wrote: > > On 2023/3/17 2:18, Ferruh Yigit wrot

[PATCH] net/mlx5/hws: fix IPv4 frag matching

2023-03-23 Thread Alex Vesker
From: Hamdan Igbaria Fix IPv4 frag matching in case fragment_offset field is set to non zero value in the mask. fragment_offset value is converted using the following logic: -In case fragment_offset value was set to 0x3fff, then we will match only on ip_fragmented bit. -Otherwise we will match f

[PATCH] net/mlx5/hws: fix send sync drain empty queue check

2023-03-23 Thread Alex Vesker
The function that checks if the queue is empty used on queue action for SYNC and ASYNC drain didn't function correctly since cur_post is a free running value and not cyclic. The fix is bitwise AND cur_post to get the real value. Fixes: 9047ee33 ("net/mlx5/hws: support synchronous drain") Signe

[PATCH] net/mlx5/hws: fix return value of send queue action

2023-03-23 Thread Alex Vesker
The rte_errno should be set to a positive error value while the ret of the function should return a negative value this aligns code to other mlx5dr API functions. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Cc: sta...@dpdk.org Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-b

Re: [PATCH 0/5] fix segment fault when parse args

2023-03-23 Thread fengchengwen
On 2023/3/22 21:49, Thomas Monjalon wrote: > 22/03/2023 09:53, Ferruh Yigit: >> On 3/22/2023 1:15 AM, fengchengwen wrote: >>> On 2023/3/21 21:50, Ferruh Yigit wrote: On 3/17/2023 2:43 AM, fengchengwen wrote: > On 2023/3/17 2:18, Ferruh Yigit wrote: >> On 3/14/2023 12:48 PM, Chengwen Fe

RE: [RFC 0/1] ring: add callback infrastructire to ring library

2023-03-23 Thread Morten Brørup
> From: Rory Sexton [mailto:rory.sex...@intel.com] > Sent: Thursday, 23 March 2023 12.38 > > This is an RFC proposing the addition of a callback infrastructure to the ring > library, particularly in the ring dequeue functions, but they could also be > added to the enqueue functions if desired. >

Re: [PATCH] app/testpmd:add vxlan txonly

2023-03-23 Thread Ferruh Yigit
On 3/6/2023 12:07 PM, Ferruh Yigit wrote: > On 2/18/2023 11:47 PM, Ferruh Yigit wrote: >> On 2/18/2023 11:06 AM, wushaohua wrote: >>> >>> 在 2023/2/18 4:43, Ferruh Yigit 写道: On 1/3/2023 2:30 AM, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > Add the vxlan packet sending mo

RE: [PATCH v4 1/3] ethdev: add API for buffer recycle mode

2023-03-23 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Thursday, 23 March 2023 11.43 > [...] > +static inline uint16_t rte_eth_rx_descriptors_refill(uint16_t port_id, > + uint16_t queue_id, uint16_t nb) > +{ > + struct rte_eth_fp_ops *p; > + void *qd; > + > +#ifdef RTE_ETH

[RFC 1/1] ring: add infrastructure to allow callbacks within the ring library

2023-03-23 Thread Rory Sexton
Adding initial code to give a feel for what it would look like if callbacks were supported by the ring dequeue functions within the ring library. They could be optionally compiled in/out as required. Signed-off-by: Rory Sexton --- lib/ring/rte_ring.h | 133 ++

[RFC 0/1] ring: add callback infrastructire to ring library

2023-03-23 Thread Rory Sexton
This is an RFC proposing the addition of a callback infrastructure to the ring library, particularly in the ring dequeue functions, but they could also be added to the enqueue functions if desired. Callbacks in the ring dequeue functions would be beneficial for a number of reasons including but no

Re: [PATCH] net/mana: remove "Features" section in mana.rst

2023-03-23 Thread Ferruh Yigit
On 3/21/2023 9:42 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > The features are already defined in doc/guides/nics/features/mana.ini. > Remove this section from mana.rst. > > Signed-off-by: Long Li Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

DPDK Release Status Meeting 2023-03-23

2023-03-23 Thread Mcnamara, John
Release status meeting minutes 2023-03-23 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the propose

Re: [PATCH v2] app/testpmd: fix wrong encap/decap size calculation

2023-03-23 Thread Ferruh Yigit
On 3/23/2023 10:34 AM, Ori Kam wrote: > Hi Michael, > >> -Original Message- >> From: Michael Baum >> Sent: Thursday, 16 March 2023 20:24 >> >> Testpmd app has some functions to create either encap or decap buffer >> for some special cases: >> - "l2_encap" and "l2_decap" >> - "mplsogre_e

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-23 Thread Sachin Saxena (OSS)
On 3/23/2023 4:37 PM, Ferruh Yigit wrote: On 3/23/2023 6:00 AM, Sachin Saxena (OSS) wrote: On 3/21/2023 11:33 PM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: +ENETFEC +--- + +This section provides an overview of the NXP ENETFEC and how it is +integrated into the DPDK. D

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-23 Thread Ferruh Yigit
On 3/23/2023 6:00 AM, Sachin Saxena (OSS) wrote: > On 3/21/2023 11:33 PM, Ferruh Yigit wrote: >> On 11/15/2021 7:19 AM, Apeksha Gupta wrote: >>> +ENETFEC >>> +--- >>> + >>> +This section provides an overview of the NXP ENETFEC and how it is >>> +integrated into the DPDK. Driver is taken as **ex

RE: [PATCH] net/mlx5: relax hws meter validation

2023-03-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, March 13, 2023 8:15 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Subject: [PATCH] net/mlx5: relax hws meter validation > > The policies array is not required for the new ME

RE: [PATCH v2] net/mlx5: fix build with GCC 12 and ASan

2023-03-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: David Marchand > Sent: Wednesday, March 22, 2023 7:06 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH v2] net/mlx5: fix build with GCC 12 and ASan > > Building with gcc 12 and ASan raises this warning: > >

[PATCH v3] net/mlx5: fix the sysfs port name translation

2023-03-23 Thread Bing Zhao
With some OFED or upstream kernel of mlx5, the port name fetched from "/sys/class/net/[DEV]/phys_port_name" may have a tailing "\n" as the EOL. The sscanf() will return the scanned items number with this EOL. In such case, the "equal to" condition is considered as false and the function mlx5_trans

RE: 回复: [PATCH v3 2/3] net/i40e: enable direct rearm with separate API

2023-03-23 Thread Feifei Wang
> -Original Message- > From: Konstantin Ananyev > Sent: Monday, March 20, 2023 12:11 AM > To: Feifei Wang ; Konstantin Ananyev > ; Yuying Zhang > ; Beilei Xing ; Ruifeng > Wang > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > Subject: Re: 回复: [PATCH v3 2/3] net/i40e: enable direct rea

RE: [PATCH] net/mlx5: relax hws meter validation

2023-03-23 Thread Matan Azrad
From: Alexander Kozyrev > The policies array is not required for the new METER_MARK action. > It is only required for the old METER action implementation. > Furthermore, the profiles array is optional for the METER_MARK action since > a profile can be found using the rte_mtr_meter_profile_get().

[PATCH v4 3/3] net/ixgbe: implement recycle buffer mode

2023-03-23 Thread Feifei Wang
Define specific function implementation for ixgbe driver. Currently, recycle buffer mode can support 128bit vector path. And can be enabled both in fast free and no fast free mode. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Naga

[PATCH v4 2/3] net/i40e: implement recycle buffer mode

2023-03-23 Thread Feifei Wang
Define specific function implementation for i40e driver. Currently, recycle buffer mode can support 128bit vector path. And can be enabled both in fast free and no fast free mode. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagar

[PATCH v4 1/3] ethdev: add API for buffer recycle mode

2023-03-23 Thread Feifei Wang
There are 4 upper APIs for buffer recycle mode: 1. 'rte_eth_rx_queue_buf_recycle_info_get' This is to retrieve buffer ring information about given ports's Rx queue in buffer recycle mode. And due to this, buffer recycle can be no longer limited to the same driver in Rx and Tx. 2. 'rte_eth_dev_buf_

[PATCH v4 0/3] Recycle buffers from Tx to Rx

2023-03-23 Thread Feifei Wang
Note: this version is just for community review, not the final version. Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The

[RFC PATCH v1 4/4] dts: format docstrigs to google format

2023-03-23 Thread Juraj Linkeš
WIP: only one module is reformatted to serve as a demonstration. The google format is documented here [0]. [0]: https://google.github.io/styleguide/pyguide.html Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 152 +++- 1 file changed, 103 insertion

[RFC PATCH v1 3/4] dts: add doc generation

2023-03-23 Thread Juraj Linkeš
The tool used to generate developer docs is sphinx, which is already used in DPDK. The configuration is kept the same to preserve the style. Sphinx generates the documentation from Python docstrings. The docstring format most suitable for DTS seems to be the Google format [0] which requires the sp

[RFC PATCH v1 2/4] dts: add doc generation dependencies

2023-03-23 Thread Juraj Linkeš
Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are used when Sphinx is executed. Signed-of

[RFC PATCH v1 1/4] dts: code adjustments for sphinx

2023-03-23 Thread Juraj Linkeš
sphinx-build only imports the Python modules when building the documentation; it doesn't run DTS. This requires changes that make the code importable without running it. This means: * properly guarding argument parsing in the if __name__ == '__main__' block. * the logger used by DTS runner underw

[RFC PATCH v1 0/4] dts: add dts api docs

2023-03-23 Thread Juraj Linkeš
Augment the meson build system with dts api generation. The api docs are generated from Python docstrings in DTS using Sphinx. The format of choice is the Google format [0]. The guide html sphinx configuration is used to preserve the same style. The build requires the same Python version and depe

RE: [PATCH v2] app/testpmd: fix wrong encap/decap size calculation

2023-03-23 Thread Ori Kam
Hi Michael, > -Original Message- > From: Michael Baum > Sent: Thursday, 16 March 2023 20:24 > > Testpmd app has some functions to create either encap or decap buffer > for some special cases: > - "l2_encap" and "l2_decap" > - "mplsogre_encap" and "mplsogre_decap" > - "mplsoudp_encap"

Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2023-03-23 Thread Kevin Traynor
+cc John For better context, this part of the discussion starts here: http://inbox.dpdk.org/dev/d718d0fe-09a2-8840-e8a4-dd41b732b...@redhat.com/ On 16/03/2023 13:31, Kevin Traynor wrote: On 15/03/2023 11:47, Kevin Traynor wrote: On 21/12/2022 09:28, Kevin Traynor wrote: On 21/12/2022 06:09, A

Re: [PATCH 0/4] Remove unnecessary null free checks

2023-03-23 Thread Thomas Monjalon
23/03/2023 02:04, Stephen Hemminger: > These were produced by using coccinelle script. > $ ./devtools/cocci.sh ./devtools/cocci/nullfree.cocci > > Stephen Hemminger (4): > mldev: remove unnecessary null free checks > ml/cnkx: remove unnecessary null checks > graph: remove unnicessary null

Re: [PATCH 0/2] small fixes for QoS profile handling

2023-03-23 Thread Thomas Monjalon
21/03/2023 14:13, Bruce Richardson: > Fix issues with the QoS block not having explicitly configured pipes - > instead they started zeroed, which worked fine. Also add into the > example app a check to flag a warning on any future misconfiguration. > > Bruce Richardson (2): > examples/qos_sched:

[PATCH v1 1/1] eventdev/eth_rx: add event buf size and count in telemetry

2023-03-23 Thread Ganapati Kundapura
rx_event_buf_count and rx_event_buf_size is added to structure rte_event_eth_rx_adapter_stats but they are not displayed in rxa_stats telemetry handler. Updated handle_rxa_stats() to display rx_event_buf_count and rx_event_buf_size. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rt

Re: [PATCH v1] doc/guides/nics: remove limitation of ipn3ke

2023-03-23 Thread Thomas Monjalon
23/03/2023 02:00, Wei Huang: > Now ipn3ke is not evaluation in 19.05 . What do you mean? It is not considered for evaluation since 19.05? Do you want to backport? [...] > -19.05 limitation > - > - > -Ipn3ke code released in 19.05 is for evaluation only. >

Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation

2023-03-23 Thread Thomas Monjalon
23/03/2023 04:26, Huang, Wei: > From: Thomas Monjalon > > 22/03/2023 02:26, Huang, Wei: > > > From: Thomas Monjalon > > > > 21/03/2023 09:41, Huang, Wei: > > > > > From: Thomas Monjalon > > > > > > 21/03/2023 01:11, Huang, Wei: > > > > > > > From: Thomas Monjalon > > > > > > > > 16/03/2023 21:4

RE: [PATCH v2] common/mlx5: fix the sysfs port name translation

2023-03-23 Thread Bing Zhao
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, March 22, 2023 11:00 PM > To: Bing Zhao > Cc: Slava Ovsiienko ; Matan Azrad > ; dev@dpdk.org; Raslan Darawsheh > ; sta...@dpdk.org > Subject: Re: [PATCH v2] common/mlx5: fix the sysfs port name translation > >

RE: release candidate 23.03-rc3

2023-03-23 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 21, 2023 12:30 AM > To: annou...@dpdk.org > Subject: release candidate 23.03-rc3 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v23.03-rc3 > > There are 110 new patches i

  1   2   >