Re: [PATCH v6] enhance NUMA affinity heuristic

25/04/2023 07:16, Kaisen You: > Trying to allocate memory on the first detected numa node,it has less > chance to find some memory actually available rather than on the main > lcore numa node (especially when the DPDK application is started only > on one numa node). You didn't change the explanati

RE: [PATCH v1] event/cnxk: fix setting event attributes in empty get work

> -Original Message- > From: Shijith Thotton > Sent: Thursday, April 27, 2023 11:58 AM > To: Jerin Jacob Kollanukkaran > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > Nikhilesh Bhagavatula ; sta...@dpdk.org > Subject: [PATCH v1] event/cnxk: fix setting event attributes in empty get > work

[PATCH 30/30] net/ice/base: fix Generic Checksum acronym

Fixes: c31095a0b20f ("net/ice/base: add GCO defines and GCO flex descriptor") Cc: sta...@dpdk.org Signed-off-by: Paul Greenwalt Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_lan_tx_rx.h | 15 --- 2 files changed, 9 insertions(+

[PATCH 29/30] net/ice/base: introduce a new ID for E810 NIC

Signed-off-by: Milena Olech Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_adminq_cmd.h | 4 ++-- drivers/net/ice/base/ice_common.c | 1 + drivers/net/ice/base/ice_devids.h | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_adminq_

[PATCH 27/30] net/ice/base: support inner etype in switchdev

Enable support for adding TC rules that filter on the inner EtherType field of tunneled packet headers. Signed-off-by: Martyna Szapar-Mudlaw Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_switch.c | 32 --- 1 file changed, 21 insertions(+), 11 deletions(-)

[PATCH 28/30] net/ice/base: use const array to store link modes

Change suggested during review on E1000 mailing list. Implementation moves 1,5k of .text to .rodata Signed-off-by: Lukasz Plachno Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 135 +++--- 1 file changed, 30 insertions(+), 105 deletions(-) diff --git

[PATCH 26/30] net/ice/base: remove bypass mode

Previous implementation switches between bypass and Vernier mode dynamically. However bypass mode should be removed due to low precision. Signed-off-by: Milena Olech Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ptp_hw.c | 46 ++- drivers/net/ice/base/ice_p

[PATCH 25/30] net/ice/base: add PPPoE hardware offload

Add support for creating PPPoE filters in switchdev mode. Add support for parsing PPPoE and PPP-specific tc options: pppoe_sid and ppp_proto. Signed-off-by: Marcin Szycik Signed-off-by: Lukasz Plachno Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_switch.c | 82 +++

[PATCH 24/30] net/ice/base: cleanup timestamp registers correct

E822 PHY TS registers should not be written and the only way to cleanup them is to reset QUAD memory. To ensure that the status bit for the timestamp index is cleared, ensure that ice_clear_phy_tstamp implementations first read the timestamp out. Implementations which can write the register contin

[PATCH 22/30] net/ice/base: return CGU PLL config function params

Change params in ice_cfg_cgu_pll_e822 to pointers to return real values of frequency and clock source. Remove static from frequency and clock source conversion functions. Signed-off-by: Karol Kolacinski Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ptp_hw.c | 39 ++

[PATCH 23/30] net/ice/base: change method to get pca9575 handle

More universal method for getting pca9575 handle is introduced. The first step is to look for CLK_MUX handle. Having that it is possible to find CLK_MUX GPIO pin. Provided data let check what is driving the pin - the expectation is that pca9575 node part number is returned. Signed-off-by: Milena O

[PATCH 21/30] net/ice/base: add PHY OFFSET READY register clear

Add a possibility to mark all transmitted/received timestamps as invalid by clearing PHY OFFSET_READY registers. Signed-off-by: Karol Kolacinski Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_adminq_cmd.h | 4 + drivers/net/ice/base/ice_ptp_hw.c | 126 --

[PATCH 20/30] net/ice/base: add L2TPv3 support for adv rules

This patch unwraps L2TPv3 dummy packet, date structures and defines from DPDK_SUPPORT. Signed-off-by: Wojciech Drewek Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_nvm.h | 1 - drivers/net/ice/base/ice_protocol_type.h | 5 +- drivers/net/ice/base/ice_switch.c| 74

[PATCH 19/30] net/ice/base: reduce time to read Option ROM CIVD

Re-write ice_get_orom_civd_data to allocate memory to store the Option ROM data. Copy the entire OptionROM contents at once using ice_read_flash_module. Finally, use this memory copy to scan for the '$CIV' section. This change significantly reduces the time to read the Option ROM CIVD section from

[PATCH 18/30] net/ice/base: add VLAN TPID in switchdev

Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_protocol_type.h | 6 +++- drivers/net/ice/base/ice_switch.c| 42 ++-- drivers/net/ice/base/ice_switch.h| 1 + 3 files changed, 38 insertions(+), 11 deletions(-) diff --git a/drivers/net/ice/base/ice_pro

[PATCH 16/30] net/ice/base: add E830 PTP init

The E830, E822 and E810 PTP initialization flows are similar. So related fix are also added. Signed-off-by: Paul Greenwalt Signed-off-by: Sergey Temerkhanov Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ptp_hw.c | 295 +++--- drivers/net/ice/base/ice_ptp_hw.h

[PATCH 17/30] net/ice/base: add C825X device support

Use ICE_MAC_GENERIC_3K type for C825X devices and fix E825X name to C825X. Signed-off-by: Grzegorz Nitka Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 13 + drivers/net/ice/base/ice_ddp.c| 8 +++- drivers/net/ice/base/ice_ddp.h| 1 + drivers/net/ic

[PATCH 15/30] net/ice/base: allow skip main timer

Allow initialization functions to skip main timer programming. Signed-off-by: Sergey Temerkhanov Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ptp_hw.c | 32 --- drivers/net/ice/base/ice_ptp_hw.h | 9 ++--- drivers/net/ice/ice_ethdev.c | 2 +- 3

[PATCH 14/30] net/ice/base: removed no need 56G releated code

As 56G related code is no need, delete unnecessary code. Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ptp_hw.c | 1396 - drivers/net/ice/base/ice_ptp_hw.h | 38 - 2 files changed, 1434 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/driver

[PATCH 13/30] net/ice/base: add function to get rxq context

This patch exports rxq context which is consumed by linux linve migration driver to save device state. Signed-off-by: Yahui Cao Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 75 +++ drivers/net/ice/base/ice_common.h | 7 ++- 2 files changed, 71

[PATCH 12/30] net/ice/base: add E830 device ids

Added new E830 device id and related registers. Signed-off-by: Paul Greenwalt Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c |8 +- drivers/net/ice/base/ice_ddp.c|6 + drivers/net/ice/base/ice_ddp.h|1 + drivers/net/ice/base/ice_devids.h |

[PATCH 11/30] net/ice/base: add new fls function

Add a new function called ice_fls() and merged some code clean. Signed-off-by: Jesse Brandeburg Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c| 40 ++-- drivers/net/ice/base/ice_common.h| 1 + drivers/net/ice/base/ice_protocol_type.h | 11 +

[PATCH 10/30] net/ice/base: use coccinelle to instead macro

MSVC is not allowing array initialization with indexes, best way to avoid the issue when compiling for Windows is to use macro to remove index on Windows and use coccinelle to maintain compatibility with linux upstream. Signed-off-by: LUkasz Plachno Signed-off-by: Marcin Szycik Signed-off-by: Qi

[PATCH 09/30] net/ice/base: add pre-allocate memory argument

Add an option to pre-allocate memory for ice_sched_node struct. Add new arguments to ice_sched_add() and ice_sched_add_elems() that allow for pre-allocation of memory for ice_sched_node struct Signed-off-by: Michal Wilczynski Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_adminq_cmd.h

[PATCH 07/30] net/ice/base: add reading cap and ropo cap

The driver can use this capability to see if temperature sensor reading or other HW sensor reading capabilities are supported before reading them using the Get Sensor Reading AQ command. Define and add parsing support for new device capability ICE_AQC_CAPS_NAC_TOPOLOGY. Signed-off-by: Eric Joyner

[PATCH 08/30] net/ice/base: add function to read HW sensors

Adds new helper function to read from HW sensors via a new AQ command "Get Sensor Reading (0x0632)". Signed-off-by: Martion Domagala Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_adminq_cmd.h | 29 + drivers/net/ice/base/ice_common.c | 36 ++

[PATCH 06/30] net/ice/base: add ability to set markid via switch filter

Support to add large action to set 32 bits markid via switch filter. For OVS-DPDK VXLAN acceleration solution, switch markid will be used for mega flow match for decap. For one ptype, the pattern may have different fields as follow: eth / ipv4 src / udp dst eth / ipv4 dst src / udp dst FDIR

[PATCH 05/30] net/ice/base: clean up RSS LUT and fix media type

Refactor __ice_aq_get_set_rss_lut(): - get variant: - make use params->lut_size only as a size of params->lut; - return LUT size via params->lut_size; - set: remove option to set RSS LUT smaller than available (eg forbid PF LUT sized 512); - both: clean up code. -

[PATCH 04/30] net/ice/base: update flow seg fields to declared bitmaps

ice_flow_seg_info fields match and range are being used with bit operations but not declared as bitmaps. This can cause issues when casting values greater than 32. This change is to declare them as proper bitmaps so that the bitmap operations can function as intended. Signed-off-by: Ashish Shah S

[PATCH 03/30] net/ice/base: remove unnecessary control queue array

The driver allocates a cmd_buf array in addition to the desc_buf array. This array stores an ice_sq_cd command details structure for each entry in the control queue ring. And improve debug print for control queue messages. Signed-off-by: Jacob Keller Signed-off-by: Qiming Yang --- drivers/net/i

[PATCH 02/30] net/ice/base: add flex array safe allocations

The Linux Kernel is now requiring flex array safe allocations from drivers and the way that we used overlaid union structures was confusing or worse, breaking Klocwork as well as failing upstream builds that were checking -Warray-bounds. And refactor structure size macros. The driver used several m

[PATCH 01/30] net/ice/base: updated copyright

Updated copyright to 2023. Signed-off-by: Qiming Yang --- drivers/net/ice/base/README | 2 +- drivers/net/ice/base/ice_acl.c | 2 +- drivers/net/ice/base/ice_acl.h | 2 +- drivers/net/ice/base/ice_acl_ctrl.c | 2 +- drivers/net/ice/base/ice_adminq_cmd.h|

[PATCH 00/30] net/ice/base: share code update

Updated share code to 2023.03 version. Qiming Yang (30): net/ice/base: updated copyright net/ice/base: add flex array safe allocations net/ice/base: remove unnecessary control queue array net/ice/base: update flow seg fields to declared bitmaps net/ice/base: clean up RSS LUT and fix medi

[PATCH v1] event/cnxk: fix setting event attributes in empty get work

Even when no events are dequeued, it is important to update event attributes as they provide valuable information for checking the work slot state and other attributes. Fixes: c0a9774f030d ("event/cnxk: move post-processing to separate function") Signed-off-by: Shijith Thotton --- drivers/event

[PATCH v3 3/3] net/iavf: support Rx timestamp offload on SSE

This patch enables Rx timestamp offload on SSE data path. Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. Signed-off-by: Zhichao Zeng --- v3: logging with driver dedicated macro --- v2: fix compile war

[PATCH v3 2/3] net/iavf: support Rx timestamp offload on AVX2

This patch enables Rx timestamp offload on AVX2 data path. Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. Signed-off-by: Zhichao Zeng --- v3: logging with driver dedicated macro --- v2: fix compile wa

[PATCH v3 0/3] Enable iavf Rx Timestamp offload on vector path

Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. --- v3: logging with driver dedicated macro --- v2: fix compile warning and SSE path Zhichao Zeng (3): net/iavf: support Rx timestamp offload on AVX512

[PATCH v3 1/3] net/iavf: support Rx timestamp offload on AVX512

This patch enables Rx timestamp offload on AVX512 data path. Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. Signed-off-by: Wenjun Wu Signed-off-by: Zhichao Zeng --- v3: logging with driver dedicated

[PATCH] net/mana: return probe failure if there is no device found

From: Long Li When there is no device found on this PCI device, return probe failure and release allocated resources for this PCI device. Fixes: 517ed6e2d5 ("net/mana: add basic driver with build environment") Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/net/mana/mana.c | 39

RE: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE

Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, April 26, 2023 11:32 PM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org; Zhang, Qi Z ; Tang, Yaqi > ; Han, YingyaX ; Richardson, > Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei > Subject: Re: [PATCH v2 3/3]

Re: Error while compiling DPDK with VPP 23.02

On Wed, 26 Apr 2023 08:03:43 + Chinmaya Agarwal wrote: > Hi, > > While compiling DPDK for VPP v23.02 on Centos 8, we saw below compilation > error:- > > In file included from ../src-dpdk/drivers/common/mlx5/mlx5_common_mr.c:14: > ../src-dpdk/drivers/common/mlx5/linux/mlx5_glue.h:15:10: fat

[PATCH] net/gve: Check whether the driver is compatible with the device presented.

Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Depends-on: series-27687 Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by:

[PATCH] examples/ipsec-secgw: Update fixed MAC address used by tap driver

Modify LOCAL_MAC value to match new locally administered MAC address used by TAP driver. Bugzilla ID: 1198 Signed-off-by: David Christensen --- examples/ipsec-secgw/test/common_defs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/test/common_defs.sh

[PATCH v2 next 7/7] net/vmxnet3: update to version 7

With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 7, provided the emulation advertises support for version 7. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- doc/guides/nics/vmxnet3.rst| 26 +++

[PATCH v2 next 4/7] net/vmxnet3: add command to set ring buffer sizes

This patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15 ++

[PATCH v2 next 6/7] net/vmxnet3: avoid updating rxprod register frequently

When UPT is enabled, the driver updates rxprod register to let the device know that it has processed the received packets and new buffers are available. However, updating it too frequently can lead to reduced performance. This patch adds code to avoid updating the register frequently. Signed-off-

[PATCH v2 next 5/7] net/vmxnet3: limit number of TXDs used for TSO packet

Currently, vmxnet3 does not have a limit on number of descriptors used for a TSO packet. However, with UPT, for hardware performance reasons, this patch limits the number of transmit descriptors to 24 for a TSO packet. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/

[PATCH v2 next 3/7] net/vmxnet3: add support for large passthrough BAR register

For vmxnet3 to work in UPT mode, the BAR sizes have been increased. The PT page has been extended to 2 pages and also includes OOB pages as a part of PT BAR. This patch enhances vmxnet3 to use appropriate BAR offsets based on the capability registered. To use new offsets, VMXNET3_CAP_LARGE_BAR need

[PATCH v2 next 2/7] net/vmxnet3: add support for capability registers

This patch enhances vmxnet3 to support capability registers which allows it to enable features selectively. The DCR register tracks the capabilities vmxnet3 device supports. The PTCR register states the capabilities that the passthrough device supports. With the help of these registers, vmxnet3 ca

[PATCH v2 next 1/7] net/vmxnet3: prepare for version 7 changes

vmxnet3 is currently at version 6 and this patch initiates the preparation to accommodate changes for up to version 7. Introduced utility macros for vmxnet3 version 7 comparison. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 1 file changed,

[PATCH v2 next 0/7] net/vmxnet3: upgrade to version 7

vmxnet3 emulation has recently added several new features including support for uniform passthrough(UPT). To make UPT work vmxnet3 has to be enhanced as per the new specification. This patch series extends the vmxnet3 driver to leverage these new features. Compatibility is maintained using existin

Re: [PATCH next 0/7] vmxnet3: upgrade to version 7

> On 4/26/23, 11:16 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > > btw, while checking the driver documentation, it seems it is not updated > for a while, the paper it refers is old. > Do you have any newer version of documentation to reference? I don’t think we have any other docum

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/26/23, 9:58 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" > has only file license comment, and I can see this is used in a few other > type declaration. > > What is the reasoning behind using these headers?

Error while compiling DPDK with VPP 23.02

Hi, While compiling DPDK for VPP v23.02 on Centos 8, we saw below compilation error:- In file included from ../src-dpdk/drivers/common/mlx5/mlx5_common_mr.c:14: ../src-dpdk/drivers/common/mlx5/linux/mlx5_glue.h:15:10: fatal error: infiniband/mlx5dv.h: No such file or directory #include

Re: [PATCH next 0/7] vmxnet3: upgrade to version 7

On 4/26/2023 5:54 PM, Ferruh Yigit wrote: > On 4/12/2023 5:26 PM, Ronak Doshi wrote: >> vmxnet3 emulation has recently added several new features including >> support for uniform passthrough(UPT). To make UPT work vmxnet3 has >> to be enhanced as per the new specification. This patch series >> exte

Re: [PATCH next 1/7] vmxnet3: prepare for version 7 changes

On 4/12/2023 5:26 PM, Ronak Doshi wrote: > vmxnet3 is currently at version 6 and this patch initiates the > preparation to accommodate changes for upto version 7. Introduced s/upto/up to/ (this is highlighted by checkpatch, please address all checkpatch warnings) > utility macros for vmxnet3 ver

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/12/2023 5:26 PM, Ronak Doshi wrote: > This patch adds a new command to set ring buffer sizes. This is > required to pass the buffer size information to passthrough devices. > Also, ring sizes are round down to power of 2. > > Signed-off-by: Ronak Doshi > Acked-by: Jochen Behrens > --- > dr

Re: [PATCH next 2/7] vmxnet3: add support for capability registers

On 4/12/2023 5:26 PM, Ronak Doshi wrote: > This patch enhances vmxnet3 to suuport capability registers which s/suuport/support/ > allows it to enable features selectively. The DCR register tracks > the capabilities vmxnet3 device supports. The PTCR register states > the capabilities that the pass

Re: [PATCH next 0/7] vmxnet3: upgrade to version 7

On 4/12/2023 5:26 PM, Ronak Doshi wrote: > vmxnet3 emulation has recently added several new features including > support for uniform passthrough(UPT). To make UPT work vmxnet3 has > to be enhanced as per the new specification. This patch series > extends the vmxnet3 driver to leverage these new fea

Re: [PATCH] net/tap: Set locally administered bit with a fixed MAC address

On 4/26/2023 1:39 AM, Stephen Hemminger wrote: > On Tue, 25 Apr 2023 16:58:06 -0400 > David Christensen wrote: > >> When the tap driver is loaded and the user selects the optional >> "mac=fixed" setting, the tap driver incorrectly uses a globally >> unique EUI-48 identifier (as documented in RFC

Re: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE

On Wed, Apr 12, 2023 at 10:42 AM Zhichao Zeng wrote: [snip] > +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" > + if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) { > + inflection

RE: [PATCH v3 00/15] update idpf base code

> -Original Message- > From: Qiao, Wenjing > Sent: Wednesday, April 26, 2023 6:23 PM > To: Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Liu, Mingxia ; Qiao, Wenjing > > Subject: [PATCH v3 00/15] update idpf base code > > This patch set updates idpf base code. > >

RE: [PATCH v3 15/15] common/idpf/base: update license and README

> -Original Message- > From: Qiao, Wenjing > Sent: Wednesday, April 26, 2023 6:23 PM > To: Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Liu, Mingxia ; Qiao, Wenjing > > Subject: [PATCH v3 15/15] common/idpf/base: update license and README > > Update license and READ

Re: [RFC 1/3] lib/coroutine: add coroutine library

On 4/24/2023 2:02 PM, Chengwen Feng wrote: > This patch adds coroutine library. The main elements are: > 1. scheduler: container of coroutines, which is responsible for > scheduling coroutine. > 2. coroutine: Minimum scheduling unit, it should associated to one > scheduler. > > In the coroutine ca

Re: [RFC 0/3] introduce coroutine library

On 4/25/2023 3:11 AM, fengchengwen wrote: > On 2023/4/25 0:08, Stephen Hemminger wrote: >> On Mon, 24 Apr 2023 13:02:05 + >> Chengwen Feng wrote: >> >>> This patchset introduces the coroutine library which will help refactor >>> the hns3 PMD's reset process. >>> >>> The hns3 single function re

[PATCH v3 15/15] common/idpf/base: update license and README

Update license and README Signed-off-by: Wenjing Qiao --- .mailmap | 8 drivers/common/idpf/base/README| 4 ++-- drivers/common/idpf/base/idpf_alloc.h | 2 +- drivers/common/idpf/base/idpf_common.c | 2 +- drivers/co

[PATCH v3 14/15] common/idpf/base: add func to clean all DESCs on controlq

Add 'idpf_ctlq_clean_sq_force' which will clean all descriptors on given control queue. It is needed in case control plane is not running and we need to do proper driver cleanup. Signed-off-by: NorbertX Ciosek Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_controlq.c | 56 +++

[PATCH v3 12/15] common/idpf/base: replace MAKEMASK to IDPF_M

Replace MAKEMASK to IDPF_M to avoid conflicts with MAKEMASK redefinition from various subcomponents. Signed-off-by: Priyalee Kushwaha Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_controlq.h | 3 -- drivers/common/idpf/base/idpf_lan_pf_regs.h | 26 +-- drivers/co

[PATCH v3 13/15] common/idpf/base: add/delete queue groups commands

Add types for new two virtchnl commands: add & delete queue group Signed-off-by: Nizan Zorea Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/virtchnl2.h | 189 +++ 1 file changed, 189 insertions(+) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/co

[PATCH v3 11/15] common/idpf/base: allocate static buffer at initialization

Some OSs don't allow allocating DMA memory at runtime. So create an initial static buffer at initialization to hold this data. Signed-off-by: Christopher Pau Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_common.c | 26 +++--- 1 file changed, 15 insertions(+),

[PATCH v3 10/15] common/idpf/base: fix memory leaks on ctrlq functions

idpf_init_hw needs to free it's q_info. idpf_clean_arq_element needs to return buffers via post_rx_buffs Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_common.c | 12

[PATCH v3 09/15] common/idpf/base: fix idpf_send_msg_to_cp prototypes

Virtchnl2 opcodes are no longer in the enum virtchnl_ops. So change these parameters to allow int rather that compiler enum type checking. Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Wenjing Qiao --- drivers/co

[PATCH v3 08/15] common/idpf/base: swap opcode and retval location in msg struct

To make the code more readable and make it clearer that the opcode goes in cookie_high and retval goes in cookie_low. Add macro definitions for filling opcode and retval. Signed-off-by: Charles Stoll Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_controlq.c | 2 ++ drivers/c

[PATCH v3 07/15] common/idpf/base: add virtchnl2 error codes

Virtchnl2 error codes are required for meaningful failure information sharing between CP and PF/VF. Introduce the necessary error codes. New error codes were introduced removing the old ones. So the references to the old one should be modified to avoid CI build failures. Use appropriate error cod

[PATCH v3 06/15] common/idpf/base: modify SSO/LSO and ITR fields

- Driver assumes minimum packet length for sso as 17 bytes but it should be a negotiated value from CP. - Similarly, the number of header buffers for lso that are supported by the device should also be a negotiated value. Add min_sso_packet_len, max_hdr_buf_per_lso to address the above. Also, the

[PATCH v3 05/15] common/idpf/base: move OEM capability to the last bit

Move the existing OEM capability in VIRTCHNL2_OTHER_CAPS to the last bit. This should not break any backward compatibility as it is not used yet. And VIRTCHNL2_MEV_DEVICE is no longer upstreamed. Signed-off-by: Pavan Kumar Linga Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/virtchnl

[PATCH v3 04/15] common/idpf/base: remove qregion struct variables

Existing qregion variables are not well defined and cannot be used for TC related stuff. Remove them from create vport struct and add those freed bytes to a new reserved field. Add appropriate comments on how to use the dynctl and itrn register spacing variables. Only VF reference was used in get

[PATCH v3 03/15] common/idpf/base: fix ITR register definitions for AVF

Fix ITR register definitions for AVF1.0 and AVF2.0 Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Priyalee Kushwaha Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_lan_pf_regs.h | 9 +++-- drivers/common/idpf/base/idpf_lan_vf

[PATCH v3 02/15] common/idpf/base: fix ctlq message send and receive

Fixes the ctlq send and receive functions to not cast the cookie field to a u64 before programming. By doing a cast, it can cause endianness issues as LE will swap the lower 32 and higher 32 bits whereas BE will not. By treating this field as two 32 bit values, both BE and LE will place the retval

[PATCH v3 01/15] common/idpf/base: remove virtchnl related base code

Since virtchnl related base code of iavf and idpf has the same sourse, so remove virtual related base code of idpf. Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_common.c|2 +- drivers/common/idpf/base/idpf_prototype.h |2 +- drivers/common/idpf/base/virtchnl.

[PATCH v3 00/15] update idpf base code

This patch set updates idpf base code. Wenjing Qiao (15): common/idpf/base: remove virtchnl related base code common/idpf/base: fix ctlq message send and receive common/idpf/base: fix ITR register definitions for AVF common/idpf/base: remove qregion struct variables common/idpf/base: mov

[PATCH 1/1] app/test: resolve mbuf_test application failure

when RTE_ENABLE_ASSERT is defined test_mbuf application is failing because we are trying to attach extbuf to a cloned buffer to which external mbuf is already attached.This patch fixes the same. Signed-off-by: Rakesh Kudurumalla --- v2: removed gerrit id app/test/test_mbuf.c | 1 + 1 file chang

[PATCH 1/1] app/test: resolve mbuf_test application failure

when RTE_ENABLE_ASSERT is defined test_mbuf application is failing because we are trying to attach extbuf to a cloned buffer to which external mbuf is already attached.This patch fixes the same. Signed-off-by: Rakesh Kudurumalla Change-Id: Ia5a0f8a81036e12a1cfec82e61bfd6f1d0c6f89e --- app/test/t

RE: [PATCH v1 1/3] net/ice/base: extend VXLAN type with inner pattern for FDIR

> -Original Message- > From: Yan, Zhirun > Sent: Wednesday, June 22, 2022 11:01 AM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Cc: Wang, Xiao W ; Yan, Zhirun > > Subject: [PATCH v1 1/3] net/ice/base: extend VXLAN type with inner pattern > for FDIR > > When offload VXLAN rule o

RE: [PATCH v1 2/3] net/ice: fix outer src mac as FDIR input field

> -Original Message- > From: Yan, Zhirun > Sent: Wednesday, June 22, 2022 11:01 AM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Cc: Wang, Xiao W ; Yan, Zhirun > > Subject: [PATCH v1 2/3] net/ice: fix outer src mac as FDIR input field > > Add src mac in input set map. If not add

RE: [PATCH v1 3/3] net/ice: fix flow management in FDIR

> -Original Message- > From: Yan, Zhirun > Sent: Wednesday, June 22, 2022 11:01 AM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Cc: Wang, Xiao W > Subject: [PATCH v1 3/3] net/ice: fix flow management in FDIR > If this is a fix, please add fixline > From: Xiao Wang > > The

RE: [PATCH v5] common/idpf: refine capability get

> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, April 26, 2023 1:18 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH v5] common/idpf: refine capability get > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Monday, April 24, 2023 4:08 P

RE: [PATCH] common/idpf: remove unnecessary field in vport

> -Original Message- > From: Xing, Beilei > Sent: Wednesday, April 26, 2023 3:38 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] common/idpf: remove unnecessary field in vport > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, April 21, 2023

RE: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE

> -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, April 12, 2023 2:50 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Tang, Yaqi ; > Han, YingyaX ; Zeng, ZhichaoX > ; Richardson, Bruce > ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei > Subject: [PATCH v2 3/3] net/iavf: su

RE: [PATCH] common/idpf: remove unnecessary field in vport

> -Original Message- > From: Zhang, Qi Z > Sent: Friday, April 21, 2023 12:21 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] common/idpf: remove unnecessary field in vport > > Remove the pointer to rte_eth_dev instance, as 1. there is already a pointer > to

RE: [PATCH v5 3/3] net/ixgbe: implement recycle buffer mode

> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 19, 2023 10:47 PM > To: Feifei Wang ; Qiming Yang > ; Wenjun Wu > Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; > m...@smartsharesystems.com; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > > Subject: Re: [PATCH v5 3/3

RE: [PATCH v5 1/3] ethdev: add API for buffer recycle mode

> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 19, 2023 10:46 PM > To: Feifei Wang ; tho...@monjalon.net; Andrew > Rybchenko > Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; > m...@smartsharesystems.com; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > > Subject: Re:

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

On 4/22/2023 4:50 AM, Joshua Washington wrote: Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow

[PATCH v2] common/idpf: remove unnecessary compile option

Remove compile option "__KERNEL" which should not be considered in DPDK. Also only #include in idpf_osdep.h. Signed-off-by: Qi Zhang --- v2: - add fallthrough comment back drivers/common/idpf/base/idpf_controlq.c | 4 drivers/common/idpf/base/idpf_controlq.h | 8 drivers/

RE: [PATCH] common/idpf: remove unnecessary compile option

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, April 25, 2023 12:24 AM > To: Zhang, Qi Z > Cc: Xing, Beilei ; dev@dpdk.org > Subject: Re: [PATCH] common/idpf: remove unnecessary compile option > > On Mon, 24 Apr 2023 18:47:00 -0400 > Qi Zhang wrote: > > > Remove com

RE: [PATCH] common/idpf: remove device stop flag

> -Original Message- > From: Xing, Beilei > Sent: Wednesday, April 26, 2023 2:42 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] common/idpf: remove device stop flag > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Thursday, April

RE: [PATCH v5 1/3] ethdev: add API for buffer recycle mode

> -Original Message- > From: Morten Brørup > Sent: Thursday, March 30, 2023 11:59 PM > To: Feifei Wang ; tho...@monjalon.net; Ferruh > Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; nd ; > Honnappa Nagarahalli ; Ruifeng Wang > ; nd > Subject: RE: [PATCH