RE: [PATCH] net/gve: fix bug in verify driver compatibility

2023-05-31 Thread Guo, Junfeng
> -Original Message- > From: Rushil Gupta > Sent: Thursday, June 1, 2023 12:50 > To: Zhang, Qi Z ; ferruh.yi...@amd.com > Cc: Guo, Junfeng ; dev@dpdk.org; Rushil Gupta > > Subject: [PATCH] net/gve: fix bug in verify driver compatibility > > gVNIC requires physical address to be passed

[PATCH v2] common/sfc_efx/base: set return code in case of the error

2023-05-31 Thread Artemii Morozov
If the prefix for the rss hash was not chosen the ENOTSUP error should be returned. Signed-off-by: Artemii Morozov Reviewed-by: Andy Moreton --- v2: don't use capital letters in email drivers/common/sfc_efx/base/efx_rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH] net/gve: fix bug in verify driver compatibility

2023-05-31 Thread Rushil Gupta
gVNIC requires physical address to be passed in the adminq command. This was initially rightly pointed by ferruh.yigit@. Fixed by passing 'driver_info_mem->iova'. Signed-off-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH] net/gve: fix bug in verify driver compatibility

2023-05-31 Thread Rushil Gupta
gVNIC requires physical address to be passed in the adminq command. This was initially rightly pointed by ferruh.yigit@. Fixed by passing 'driver_info_mem->iova'. Signed-off-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

RE: [PATCH v4 3/3] net/iavf: support Rx timestamp offload on SSE

2023-05-31 Thread Tang, Yaqi
> -Original Message- > From: Zeng, ZhichaoX > Sent: Monday, May 29, 2023 10:23 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Tang, Yaqi ; > Zeng, ZhichaoX ; Richardson, Bruce > ; Konstantin Ananyev > ; Wu, Jingjing ; Xing, > Beilei > Subject: [PATCH v4 3/3] net/iavf: support Rx timestamp of

RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

2023-05-31 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, May 30, 2023 1:05 PM > To: Vamsi Krishna Attunuru > Cc: Yan, Zhirun ; dev@dpdk.org; > tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > Nithin Kumar Dabilpuram ; Liang, Cunming > ; Wang, Haiyue ; Sunil > Kumar Kori > Subject: [

RE: [EXT] Re: [PATCH 2/4] node: add a node to receive pkts from kernel

2023-05-31 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Jerin Jacob > Sent: Monday, May 29, 2023 11:10 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram > Subject: [EXT] Re: [PATCH 2/4] node: add a node to receive pkts from kernel > > External Email > > -

Re: [PATCH v3 2/3] lib: add IPv6 rewrite node

2023-05-31 Thread Nithin Dabilpuram
Series Acked-by: Nithin Dabilpuram On Wed, May 31, 2023 at 5:08 PM Amit Prakash Shukla wrote: > > Similar to IPv4 rewrite node, patch adds IPv6 rewrite node. > > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Performance related changes > > v3: > - Removing redundant dynamic variable > > d

Re: [PATCH v3 1/3] lib: add IPv6 lookup node

2023-05-31 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Wed, May 31, 2023 at 5:08 PM Amit Prakash Shukla wrote: > > From: Sunil Kumar Kori > > Similar to IPv4 lookup node, patch adds IPv6 lookup > node. > > Signed-off-by: Sunil Kumar Kori > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Performance related changes

RE: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 31, 2023 5:29 PM > To: Xia, Chenbo ; Thomas Monjalon > ; Eelco Chaudron ; > david.march...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt > kick > > > > On 5/31

RE: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one

2023-05-31 Thread Xia, Chenbo
> -Original Message- > From: Eelco Chaudron > Sent: Wednesday, May 31, 2023 7:14 PM > To: Maxime Coquelin > Cc: Xia, Chenbo ; david.march...@redhat.com; > dev@dpdk.org > Subject: Re: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a > read/write one > > > > On 31 May 2023,

[PATCH 2/2] drivers: don't use rte_strlcpy

2023-05-31 Thread Stephen Hemminger
Prefer using strlcpy over rte_strlcpy. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h| 2 +- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 2 +- drivers/net/cnxk/cnxk_ethdev_ops.c| 4 ++-- drivers/net/mlx5/mlx5_testpmd.c | 2 +- 4

[PATCH 1/2] lib: replace rte_strlcpy() with strlcpy()

2023-05-31 Thread Stephen Hemminger
The function rte_strlcpy is intended to be a platform specific wrapper function and only used where necessary. Prefer using the OS supplied strlcpy() if available. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memzone.c | 2 +- lib/fib/rte_fib.c | 2 +- lib/f

[PATCH 0/2] cleanup use of rte_strlcpy

2023-05-31 Thread Stephen Hemminger
In DPDK API's rte_strlcpy() is not intended to be used directly. It was introduced as a replacement for when operating system libraries were missing strlcpy(). Over time it appears several drivers and subsystems started using it directly, which is inefficient since the wrapper uses snprintf(). Thi

[PATCH v2] net/mlx5: fix MPRQ stride size to accommodate the headroom

2023-05-31 Thread Alexander Kozyrev
The space for the headroom is reserved at the end of every MPRQ stride for the next packet. The Rx burst logic is to copy any overlapping packet data if there is an overlap with this reserved headroom space. But it is not possible if the headroom size is bigger than the whole stride. Adjust the str

[PATCH] net/mlx5: fix MPRQ stride size to accommodate the headroom

2023-05-31 Thread Alexander Kozyrev
The space for the headroom is reserved at the end of every MPRQ stride for the next packet. The Rx burst logic is to copy any overlapping packet data if there is an overlap with this reserved headroom space. But it is not possible if the headroom size is bigger than the whole stride. Adjust the str

[PATCH v2] graph: fix pcapng file support

2023-05-31 Thread Stephen Hemminger
The interface to rte_pcapng changed in last release so that the interfaces used need to be added to the pcapng file via the API. If this step is missing the pcapng file will not be valid and can't be read by wireshark etc. Fixes: d1da6d0d04c7 ("pcapng: require per-interface information") Signed-of

Re: [v5] net/gve: check driver compatibility

2023-05-31 Thread Ferruh Yigit
On 5/24/2023 6:13 PM, Rushil Gupta wrote: > Change gve_driver_info fields to report DPDK as OS type and DPDK RTE > version as OS version, reserving driver_version fields for GVE driver > version based on features. > > Signed-off-by: Rushil Gupta > Signed-off-by: Joshua Washington > Signed-off-by

Re: [v4] net/gve: check driver compatibility

2023-05-31 Thread Rushil Gupta
http://patchwork.dpdk.org/project/dpdk/patch/20230524171324.2072742-1-rush...@google.com/ Does this look good to you? On Wed, May 24, 2023 at 10:14 AM Rushil Gupta wrote: > > As noted from spec: "Some commands require an additional dma memory > region to be passed to the device" > We are passing

Re: [PATCH v2 1/2] ethdev: add API to check queue ID validity

2023-05-31 Thread Ferruh Yigit
On 5/22/2023 2:58 PM, Andrew Rybchenko wrote: > On 5/22/23 16:09, Dengdui Huang wrote: >> The API rte_eth_dev_is_valid_rxq/txq checks >> the port ID validity and then the Rx/Tx queue ID is valid. > > What is valid Tx/Rx queue? It depends on on caller > expectations. Some functions are satisfied wi

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread Thomas Monjalon
31/05/2023 16:54, Jerin Jacob: > On Wed, May 31, 2023 at 8:19 PM Thomas Monjalon wrote: > > > > 31/05/2023 16:07, Jerin Jacob: > > > On Wed, May 31, 2023 at 7:31 PM Thomas Monjalon > > > wrote: > > > > > > > > 31/05/2023 15:21, Jerin Jacob: > > > > > On Wed, May 31, 2023 at 6:17 PM wrote: > > >

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread Jerin Jacob
On Wed, May 31, 2023 at 8:19 PM Thomas Monjalon wrote: > > 31/05/2023 16:07, Jerin Jacob: > > On Wed, May 31, 2023 at 7:31 PM Thomas Monjalon wrote: > > > > > > 31/05/2023 15:21, Jerin Jacob: > > > > On Wed, May 31, 2023 at 6:17 PM wrote: > > > > > > > > > > From: Jerin Jacob > > > > > > > > >

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread Thomas Monjalon
31/05/2023 16:07, Jerin Jacob: > On Wed, May 31, 2023 at 7:31 PM Thomas Monjalon wrote: > > > > 31/05/2023 15:21, Jerin Jacob: > > > On Wed, May 31, 2023 at 6:17 PM wrote: > > > > > > > > From: Jerin Jacob > > > > > > > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > > > > c

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Maxime Coquelin
On 5/31/23 16:12, David Marchand wrote: Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq) if (vhost_need_event(off, new, old)) kick = true; kick: -

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread David Marchand
Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: > @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct > vhost_virtqueue *vq) > if (vhost_need_event(off, new, old)) > kick = true; > kick: > - if (kick && vq->callfd >= 0) { > -

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread Jerin Jacob
On Wed, May 31, 2023 at 7:31 PM Thomas Monjalon wrote: > > 31/05/2023 15:21, Jerin Jacob: > > On Wed, May 31, 2023 at 6:17 PM wrote: > > > > > > From: Jerin Jacob > > > > > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > > > changed to TIMESTAMP [2]. Fixed the following warn

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread Thomas Monjalon
31/05/2023 15:21, Jerin Jacob: > On Wed, May 31, 2023 at 6:17 PM wrote: > > > > From: Jerin Jacob > > > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > > changed to TIMESTAMP [2]. Fixed the following warning[1] by providing > > the correct configuration option based on doxyge

Re: [PATCH] ethdev: fix indirect action convert

2023-05-31 Thread Ferruh Yigit
On 5/29/2023 7:12 AM, Ori Kam wrote: > Hi Suanming, > >> -Original Message- >> From: Suanming Mou >> Sent: Friday, May 26, 2023 6:18 AM >> >> As indirect action conf fills the indirect action handler, while >> converting indirect action, the action conf(action handler) should >> be copied

[PATCH 3/3] net/sfc: support VLAN stripping offload

2023-05-31 Thread Artemii Morozov
Extract vlan tci provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst| 4 ++-- drivers

[PATCH 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-05-31 Thread Artemii Morozov
To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. VLAN stripping is supported for ef100 datapath only. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/s

[PATCH 1/3] common/sfc_efx/base: report VLAN stripping capability

2023-05-31 Thread Artemii Morozov
These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++ drivers/common/sfc_efx/base/efx.h | 1 + drivers/common/sfc_

[PATCH 0/3] net/sfc: support VLAN stripping offload

2023-05-31 Thread Artemii Morozov
This patch series adds VLAN stripping offload. Note that this offload are device level offload. Artemii Morozov (3): common/sfc_efx/base: report VLA

[PATCH v7 14/14] doc: update the doc of CPFL PMD

2023-05-31 Thread beilei . xing
From: Beilei Xing Update cpfl.rst to clarify hairpin support. Signed-off-by: Beilei Xing --- doc/guides/nics/cpfl.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst index d25db088eb..8d5c3082e4 100644 --- a/doc/guides/nics/cpfl.rs

[PATCH v7 13/14] net/cpfl: support hairpin bind/unbind

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports hairpin_bind/unbind ops. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 137 + 1 file changed, 137 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl

[PATCH v7 12/14] net/cpfl: support peer ports get

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports get hairpin peer ports. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH v7 11/14] net/cpfl: enable write back based on ITR expire

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch enables write back based on ITR expire (WR_ON_ITR) for hairpin queues. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_

[PATCH v7 10/14] common/idpf: add irq map config API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports idpf_vport_irq_map_config_by_qids API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 75 drivers/common/idpf/idpf_common_device.h | 4 ++ drivers/common/idpf/version.map

[PATCH v7 09/14] net/cpfl: support hairpin queue start/stop

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue start/stop. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 46 + drivers/net/cpfl/cpfl_rxtx.c | 164 + drivers/net/cpfl/cp

[PATCH v7 07/14] net/cpfl: support hairpin queue configuration

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue configuration. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 136 +++-- drivers/net/cpfl/cpfl_rxtx.c | 80 +++ driver

[PATCH v7 08/14] common/idpf: add switch queue API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds idpf_vc_ena_dis_one_queue API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/common/idpf/idpf_common_virtchnl.h | 3 +++ drivers/common/idpf/version.map| 1 + 3 files changed,

[PATCH v7 06/14] common/idpf: add queue config API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx queue configuration APIs. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 70 ++ drivers/common/idpf/idpf_common_virtchnl.h | 6 ++ drivers/common/idpf/version.map

[PATCH v7 05/14] net/cpfl: support hairpin queue setup and release

2023-05-31 Thread beilei . xing
From: Beilei Xing Support hairpin Rx/Tx queue setup and release. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 6 + drivers/net/cpfl/cpfl_ethdev.h | 11 + drivers/net/cpfl/cpfl_rxtx.c| 364

[PATCH v7 04/14] net/cpfl: support hairpin queue capbility get

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds hairpin_cap_get ops support. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/d

[PATCH v7 03/14] net/cpfl: add haipin queue group during vport init

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vport init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 133 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 7 ++ 3 file

[PATCH v7 02/14] common/idpf: support queue groups add/delete

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds queue group add/delete virtual channel support. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 66 ++ drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ drivers/common/idpf/version.

[PATCH v7 01/14] net/cpfl: refine structures

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch refines some structures to support hairpin queue, cpfl_rx_queue/cpfl_tx_queue/cpfl_vport. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 85 +++- drivers/net/cpfl/cpfl_ethdev.h | 6 +- driver

[PATCH v7 00/14] net/cpfl: add hairpin queue support

2023-05-31 Thread beilei . xing
From: Beilei Xing This patchset adds hairpin queue support. v2 changes: - change hairpin rx queus configuration sequence. - code refine. v3 changes: - Refine the patchset based on the latest code. v4 change: - Remove hairpin rx buffer queue's sw_ring. - Change hairpin rx queus configurati

Re: [PATCH v2] event/cnxk: fix LMTST write for single event mode

2023-05-31 Thread Jerin Jacob
On Wed, May 31, 2023 at 4:25 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Srujana Challa > > Sent: Wednesday, May 31, 2023 4:03 PM > > To: Pavan Nikhilesh Bhagavatula ; Shijith > > Thotton ; Rahul Bhansali ; > > Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.o

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread Jerin Jacob
On Wed, May 31, 2023 at 6:17 PM wrote: > > From: Jerin Jacob > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > changed to TIMESTAMP [2]. Fixed the following warning[1] by providing > the correct configuration option based on doxygen version. loongarch-compilation reported a

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Eelco Chaudron
On 31 May 2023, at 14:48, Maxime Coquelin wrote: > On 5/31/23 14:01, David Marchand wrote: >> Eelco, Maxime, >> >> On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: >>> @@ -846,6 +848,11 @@ vhost_user_socket_mem_free(struct vhost_user_socket >>> *vsocket) >>> vsocket->pa

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Maxime Coquelin
On 5/31/23 14:01, David Marchand wrote: Eelco, Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: @@ -846,6 +848,11 @@ vhost_user_socket_mem_free(struct vhost_user_socket *vsocket) vsocket->path = NULL; } + if (vsocket && vsocket->malloc_notify_

[dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-05-31 Thread jerinj
From: Jerin Jacob Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option changed to TIMESTAMP [2]. Fixed the following warning[1] by providing the correct configuration option based on doxygen version. [1] Warning: Tag 'HTML_TIMESTAMP' at line 115 of file 'doc/api/doxy-api.conf' has be

RE: [EXT] Re: [PATCH 1/4] node: add pkt punt to kernel node

2023-05-31 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Jerin Jacob > Sent: Monday, May 29, 2023 11:00 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram > Subject: [EXT] Re: [PATCH 1/4] node: add pkt punt to kernel node > > External Email > >

RE: [EXT] Re: [PATCH v2 1/4] node: add pkt punt to kernel node

2023-05-31 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Nithin Dabilpuram > Sent: Tuesday, May 30, 2023 1:47 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabilpuram > > Subject: [EXT] Re: [PATCH v2 1/4] node: add pkt punt to kernel node > >

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread David Marchand
Eelco, Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: > @@ -846,6 +848,11 @@ vhost_user_socket_mem_free(struct vhost_user_socket > *vsocket) > vsocket->path = NULL; > } > > + if (vsocket && vsocket->malloc_notify_ops) { > + free(vsocket

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread David Marchand
On Tue, May 30, 2023 at 3:02 PM Maxime Coquelin wrote: > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentiall

[PATCH v3 3/3] examples/l3fwd-graph: add IPv6 lookup and rewrite support

2023-05-31 Thread Amit Prakash Shukla
From: Sunil Kumar Kori Similar to ipv4, to support IPv6 lookup and rewrite node routes and rewrite data needs to be added. Patch adds routes for ipv6 to validate ip6_lookup node and rewrite data to validate ip6_rewrite node. Signed-off-by: Sunil Kumar Kori Signed-off-by: Amit Prakash Shukla

[PATCH v3 2/3] lib: add IPv6 rewrite node

2023-05-31 Thread Amit Prakash Shukla
Similar to IPv4 rewrite node, patch adds IPv6 rewrite node. Signed-off-by: Amit Prakash Shukla --- v2: - Performance related changes v3: - Removing redundant dynamic variable doc/guides/prog_guide/graph_lib.rst | 8 + lib/node/ethdev_ctrl.c | 13 ++ lib/node/ip6_rewrite.c

[PATCH v3 1/3] lib: add IPv6 lookup node

2023-05-31 Thread Amit Prakash Shukla
From: Sunil Kumar Kori Similar to IPv4 lookup node, patch adds IPv6 lookup node. Signed-off-by: Sunil Kumar Kori Signed-off-by: Amit Prakash Shukla --- v2: - Performance related changes v3: - Removing redundant dynamic variable doc/guides/prog_guide/graph_lib.rst | 13 + lib/node/ip6_looku

Re: [PATCH v6] ethdev: add indirect list flow action

2023-05-31 Thread Ferruh Yigit
On 5/29/2023 7:14 AM, Ori Kam wrote: > Hi gregory, > >> -Original Message- >> From: Gregory Etelson >> Sent: Sunday, May 28, 2023 6:44 PM >> >> Indirect API creates a shared flow action with unique action handle. >> Flow rules can access the shared flow action and resources related to >>

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Eelco Chaudron
On 31 May 2023, at 11:29, Maxime Coquelin wrote: > On 5/31/23 08:19, Xia, Chenbo wrote: >>> -Original Message- >>> From: Maxime Coquelin >>> Sent: Tuesday, May 30, 2023 11:17 PM >>> To: Thomas Monjalon ; Eelco Chaudron >>> ; Xia, Chenbo ; >>> david.march...@redhat.com >>> Cc: dev@dpdk.

Re: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one

2023-05-31 Thread Eelco Chaudron
On 31 May 2023, at 11:27, Maxime Coquelin wrote: > On 5/31/23 08:37, Xia, Chenbo wrote: >> Hi Eelco, >> >>> -Original Message- >>> From: Eelco Chaudron >>> Sent: Wednesday, May 17, 2023 5:09 PM >>> To: maxime.coque...@redhat.com; Xia, Chenbo ; >>> david.march...@redhat.com >>> Cc: dev@

RE: [PATCH v2] event/cnxk: fix LMTST write for single event mode

2023-05-31 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Srujana Challa > Sent: Wednesday, May 31, 2023 4:03 PM > To: Pavan Nikhilesh Bhagavatula ; Shijith > Thotton ; Rahul Bhansali ; > Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Srujana Challa ; Nithin Kumar > Dabilpuram > Subject: [PATCH v2] event/cnxk: fix

RE: [PATCH v4 13/13] net/cpfl: support hairpin bind/unbind

2023-05-31 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Tuesday, May 30, 2023 12:00 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Wang, Xiao W > Subject: RE: [PATCH v4 13/13] net/cpfl: support hairpin bind/unbind > > > > > -Original Message- > > From: Xing, Beilei > >

RE: [PATCH v4 09/13] net/cpfl: support hairpin queue start/stop

2023-05-31 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Tuesday, May 30, 2023 11:31 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Wang, Xiao W > Subject: RE: [PATCH v4 09/13] net/cpfl: support hairpin queue start/stop > > > > > -Original Message- > > From: Xing, Beilei

RE: [PATCH v4 05/13] net/cpfl: support hairpin queue setup and release

2023-05-31 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Tuesday, May 30, 2023 10:50 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Wang, Xiao W > Subject: RE: [PATCH v4 05/13] net/cpfl: support hairpin queue setup and > release > > > > > -Original Message- > > From: Liu

[PATCH v6 13/13] net/cpfl: support hairpin bind/unbind

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports hairpin_bind/unbind ops. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 137 + 1 file changed, 137 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl

[PATCH v6 12/13] net/cpfl: support peer ports get

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports get hairpin peer ports. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH v6 11/13] net/cpfl: enable write back based on ITR expire

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch enables write back based on ITR expire (WR_ON_ITR) for hairpin queues. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_

[PATCH v6 09/13] net/cpfl: support hairpin queue start/stop

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue start/stop. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 46 + drivers/net/cpfl/cpfl_rxtx.c | 164 + drivers/net/cpfl/cp

[PATCH v6 10/13] common/idpf: add irq map config API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports idpf_vport_irq_map_config_by_qids API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 75 drivers/common/idpf/idpf_common_device.h | 4 ++ drivers/common/idpf/version.map

[PATCH v6 07/13] net/cpfl: support hairpin queue configuration

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue configuration. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 136 +++-- drivers/net/cpfl/cpfl_rxtx.c | 80 +++ driver

[PATCH v6 08/13] common/idpf: add switch queue API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds idpf_vc_ena_dis_one_queue API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/common/idpf/idpf_common_virtchnl.h | 3 +++ drivers/common/idpf/version.map| 1 + 3 files changed,

[PATCH v6 06/13] common/idpf: add queue config API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx queue configuration APIs. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 70 ++ drivers/common/idpf/idpf_common_virtchnl.h | 6 ++ drivers/common/idpf/version.map

[PATCH v6 05/13] net/cpfl: support hairpin queue setup and release

2023-05-31 Thread beilei . xing
From: Beilei Xing Support hairpin Rx/Tx queue setup and release. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 6 + drivers/net/cpfl/cpfl_ethdev.h | 11 + drivers/net/cpfl/cpfl_rxtx.c| 364

[PATCH v6 03/13] net/cpfl: add haipin queue group during vport init

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vport init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 133 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 7 ++ 3 file

[PATCH v6 02/13] common/idpf: support queue groups add/delete

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds queue group add/delete virtual channel support. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 66 ++ drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ drivers/common/idpf/version.

[PATCH v6 04/13] net/cpfl: support hairpin queue capbility get

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds hairpin_cap_get ops support. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/d

[PATCH v6 00/13] net/cpfl: add hairpin queue support

2023-05-31 Thread beilei . xing
From: Beilei Xing This patchset adds hairpin queue support. v2 changes: - change hairpin rx queus configuration sequence. - code refine. v3 changes: - Refine the patchset based on the latest code. v4 change: - Remove hairpin rx buffer queue's sw_ring. - Change hairpin rx queus configurati

[PATCH v6 01/13] net/cpfl: refine structures

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch refines some structures to support hairpin queue, cpfl_rx_queue/cpfl_tx_queue/cpfl_vport. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 85 +++- drivers/net/cpfl/cpfl_ethdev.h | 6 +- driver

[PATCH v5 13/13] net/cpfl: support hairpin bind/unbind

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports hairpin_bind/unbind ops. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 137 + 1 file changed, 137 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl

[PATCH v5 12/13] net/cpfl: support peer ports get

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports get hairpin peer ports. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH v5 10/13] common/idpf: add irq map config API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports idpf_vport_irq_map_config_by_qids API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 75 drivers/common/idpf/idpf_common_device.h | 4 ++ drivers/common/idpf/version.map

[PATCH v5 11/13] net/cpfl: enable write back based on ITR expire

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch enables write back based on ITR expire (WR_ON_ITR) for hairpin queues. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_

[PATCH v5 09/13] net/cpfl: support hairpin queue start/stop

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue start/stop. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 46 + drivers/net/cpfl/cpfl_rxtx.c | 164 + drivers/net/cpfl/cp

[PATCH v5 08/13] common/idpf: add switch queue API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds idpf_vc_ena_dis_one_queue API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/common/idpf/idpf_common_virtchnl.h | 3 +++ drivers/common/idpf/version.map| 1 + 3 files changed,

[PATCH v5 07/13] net/cpfl: support hairpin queue configuration

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue configuration. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 136 +++-- drivers/net/cpfl/cpfl_rxtx.c | 80 +++ driver

[PATCH v5 06/13] common/idpf: add queue config API

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx queue configuration APIs. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 70 ++ drivers/common/idpf/idpf_common_virtchnl.h | 6 ++ drivers/common/idpf/version.map| 2 + 3 files changed, 7

[PATCH v5 05/13] net/cpfl: support hairpin queue setup and release

2023-05-31 Thread beilei . xing
From: Beilei Xing Support hairpin Rx/Tx queue setup and release. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 6 + drivers/net/cpfl/cpfl_ethdev.h | 11 + drivers/net/cpfl/cpfl_rxtx.c| 364

[PATCH v5 04/13] net/cpfl: support hairpin queue capbility get

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds hairpin_cap_get ops support. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/d

[PATCH v5 03/13] net/cpfl: add haipin queue group during vport init

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vport init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 133 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 7 ++ 3 file

[PATCH v5 02/13] common/idpf: support queue groups add/delete

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch adds queue group add/delete virtual channel support. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 66 ++ drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ drivers/common/idpf/version.

[PATCH v5 01/13] net/cpfl: refine structures

2023-05-31 Thread beilei . xing
From: Beilei Xing This patch refines some structures to support hairpin queue, cpfl_rx_queue/cpfl_tx_queue/cpfl_vport. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 85 +++- drivers/net/cpfl/cpfl_ethdev.h | 6 +- driver

[PATCH v5 00/13] net/cpfl: add hairpin queue support

2023-05-31 Thread beilei . xing
From: Beilei Xing This patchset adds hairpin queue support. v2 changes: - change hairpin rx queus configuration sequence. - code refine. v3 changes: - Refine the patchset based on the latest code. v4 change: - Remove hairpin rx buffer queue's sw_ring. - Change hairpin rx queus configurati

[PATCH v2] event/cnxk: fix LMTST write for single event mode

2023-05-31 Thread Srujana Challa
LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the LMTST operation is complete. Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path") Cc: pbhagavat...@marvell.com Signed-off-by: Srujana Challa ---

Re: [PATCH v1] bus/pci: get PCI address from rte_device

2023-05-31 Thread David Marchand
(I reformatted the mail a bit) On Wed, May 31, 2023 at 10:51 AM Elena Agostini wrote: > > On Wed, May 31, 2023 at 10:44 AM Elena Agostini eagost...@nvidia.com wrote: > > > > On Tue, May 30, 2023 at 1:48 PM eagost...@nvidia.com wrote: > > > > > From: Elena Agostini eagost...@nvidia.com > > > > > I

Re: [PATCH v3 3/4] vhost: fix invalid call FD handling

2023-05-31 Thread Maxime Coquelin
On 5/31/23 08:12, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, May 30, 2023 8:54 PM To: Eelco Chaudron ; Xia, Chenbo ; david.march...@redhat.com Cc: dev@dpdk.org Subject: Re: [PATCH v3 3/4] vhost: fix invalid call FD handling On 5/17/23 11:09, Eelco Ch

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Maxime Coquelin
On 5/31/23 08:19, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, May 30, 2023 11:17 PM To: Thomas Monjalon ; Eelco Chaudron ; Xia, Chenbo ; david.march...@redhat.com Cc: dev@dpdk.org Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt

Re: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one

2023-05-31 Thread Maxime Coquelin
On 5/31/23 08:37, Xia, Chenbo wrote: Hi Eelco, -Original Message- From: Eelco Chaudron Sent: Wednesday, May 17, 2023 5:09 PM To: maxime.coque...@redhat.com; Xia, Chenbo ; david.march...@redhat.com Cc: dev@dpdk.org Subject: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to

RE: [PATCH 1/3] security: introduce out of place support for inline ingress

2023-05-31 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 30 May 2023 15.52 > > 30/05/2023 11:23, Jerin Jacob: > > > > > > > + */ > > > > > > > + uint32_t ingress_oop : 1; > > > > > > > + > > > > > > > /** Reserved bit fields for future extension > > > > > > >* >

  1   2   >