[PATCH v5 2/2] app/testpmd: add set dev led on/off command

2024-10-09 Thread Chaoyong He
From: James Hershaw Add command to change the state of a controllable LED on an ethdev port to on/off. This is for the purpose of identifying which physical port is associated with an ethdev. Usage: testpmd> set port led Signed-off-by: James Hershaw Reviewed-by: Chaoyong He --- app/test-

[PATCH v5 1/2] app/testpmd: add support for setting device EEPROM

2024-10-09 Thread Chaoyong He
From: James Hershaw There is currently no means to test the .set_eeprom function callback of a given PMD in drivers/net/. This patch adds functionality to allow a user to set device eeprom from the testpmd cmdline. Usage: testpmd> set port eeprom magic \ value offset - i

[PATCH v5 0/2] add two commands for testpmd application

2024-10-09 Thread Chaoyong He
This patch series aims to add two commands for the testpmd application: - testpmd> set port eeprom magic \ value offset - testpmd> set port led --- v5: * Use 'accept_risk' rather than 'confirm' to make it clear enough. * Use dynamic memory alloc rather than VLA. * Place the logic

RE: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-09 Thread Akhil Goyal
> >>> Now added inline APIs for getting the list end which need to be updated > >>> for each new entry to the enum. This shall help in avoiding ABI break > >>> for adding new algo. > >>> > >> > >> Hi Akhil, > >> > >> *I think* this hides the problem instead of fixing it, and this may be > >> partia

[v3] crypto/dpaa2_sec: rework debug code

2024-10-09 Thread Gagandeep Singh
Move the duplicate code in a common function and remove un-necessary newline characters from the logs. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 110 1 file changed, 44 insertions(+), 66 deletions(-) diff --git

RE: [PATCH v4 1/2] app/testpmd: add support for setting device EEPROM

2024-10-09 Thread Chaoyong He
> On 9/18/2024 3:38 AM, Chaoyong He wrote: > > From: James Hershaw > > > > There is currently no means to test the .set_eeprom function callback > > of a given PMD in drivers/net/. This patch adds functionality to allow > > a user to set device eeprom from the testpmd cmdline. > > > > Usage: > >

RE: [PATCH v4 2/2] app/testpmd: add set dev led on/off command

2024-10-09 Thread Chaoyong He
> On 9/18/2024 3:38 AM, Chaoyong He wrote: > > From: James Hershaw > > > > Add command to change the state of a controllable LED on an ethdev > > port to on/off. This is for the purpose of identifying which physical > > port is associated with an ethdev. > > > > Usage: > > testpmd> set port led

RE: [EXTERNAL] [v2] crypto/dpaa2_sec: rework debug code

2024-10-09 Thread Gagandeep Singh
Hi, Sure, I will submit the rebased patch soon. > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 10, 2024 2:32 AM > To: Gagandeep Singh ; dev@dpdk.org; Hemant Agrawal > > Cc: Jun Yang > Subject: RE: [EXTERNAL] [v2] crypto/dpaa2_sec: rework debug code > > Hi Gagan, >

Re: [PATCH v7 0/7] Lcore variables

2024-10-09 Thread Stephen Hemminger
On Wed, 18 Sep 2024 10:26:07 +0200 Mattias Rönnblom wrote: > This patch set introduces a new API for static > per-lcore id data allocation. > > Please refer to the API documentation for both a > rationale for this new API, and a comparison to the alternatives > available. > > The adoption of

RE: [RFC PATCH 1/3] graph: add feature arc support

2024-10-09 Thread Nitin Saxena
Hi Kiran, See my inline comments. Somehow I forgot to respond earlier Thanks, Nitin > -Original Message- > From: Kiran Kumar Kokkilagadda > Sent: Wednesday, September 11, 2024 10:11 AM > To: Nitin Saxena ; Jerin Jacob ; > Nithin Kumar Dabilpuram ; Zhirun Yan > > Cc: dev@dpdk.org; Niti

RE: [EXTERNAL] Re: [PATCH v3 0/5] add feature arc in rte_graph

2024-10-09 Thread Nitin Saxena
Thanks Stephen. Will fix compilation in next version. Thanks, Nitin > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 9, 2024 11:08 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan ; Robin > Jarry ; Chr

RE: [EXTERNAL] Re: [PATCH v3 0/5] add feature arc in rte_graph

2024-10-09 Thread Nitin Saxena
Hi Christophe, Thanks for the review. See my comments inline Thanks, Nitin > -Original Message- > From: Christophe Fontaine > Sent: Wednesday, October 9, 2024 7:51 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan ; Robin > Ja

RE: [PATCH v6 4/4] common/nfp: use new API to parse kvargs

2024-10-09 Thread Chaoyong He
> -Original Message- > From: Chengwen Feng > Sent: Wednesday, October 9, 2024 12:51 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Chaoyong He > > Cc: dev@dpdk.org; step...@networkplumber.org > Subject: [PATCH v6 4/4] common/nfp: use new API to parse kvargs > > The nfp_parse_clas

Re: [PATCH 6/6] app/test: add asymmetric tests for virtio pmd

2024-10-09 Thread Stephen Hemminger
On Thu, 5 Sep 2024 20:26:10 +0530 Gowrishankar Muthukrishnan wrote: > Add asymmetric tests for Virtio PMD. > > Signed-off-by: Gowrishankar Muthukrishnan This patch set has lots of build errors. See patchwork. For example: *Build Failed #1: OS: RHEL94-64 Target: x86_64-native-linuxapp-clang FA

Re: [v2 00/43] DPAA2 specific patches

2024-10-09 Thread Stephen Hemminger
On Wed, 18 Sep 2024 13:20:13 +0530 vanshika.shu...@nxp.com wrote: > From: Vanshika Shukla > > This series includes: > -> Fixes and enhancements for NXP DPAA2 drivers. > -> Upgrade with MC version 10.37 > -> Enhancements in DPDMUX code > -> Fixes for coverity issues reported > > V2 changes: >

Re: [dpdk-dev] [PATCH 10/10] net/bonding: fix configuration assignment overflow

2024-10-09 Thread Stephen Hemminger
On Mon, 19 Apr 2021 21:34:49 +0800 "Min Hu (Connor)" wrote: > From: Chengchang Tang > > The expression may cause an overflow. > > This patch fix the codeDEX static check warning "INTEGER_OVERFLOW". > > Fixes: 46fb43683679 ("bond: add mode 4") > Cc: sta...@dpdk.org > > Signed-off-by: Chengcha

[PATCH] doc: reword sample app guides

2024-10-09 Thread Nandini Persad
I have reviewed these sections for grammar/clarity and made small modifications to the formatting of sections to adhere to a template which will create uniformality in the sample application user guides overall. Signed-off-by: Nandini Persad Acked-by: Chengwen Feng --- doc/guides/sample_app_ug/

Re: [PATCH v6 1/4] kvargs: add one new process API

2024-10-09 Thread Ferruh Yigit
On 10/9/2024 5:50 AM, Chengwen Feng wrote: > The rte_kvargs_process() was used to handle key=value (e.g. > socket_id=0), it also supports to handle only-key (e.g. socket_id). > But many drivers's callback can only handle key=value, it will segment > fault if handles only-key. so the patchset [1] wa

Re: [PATCH] ethdev: convert string initialization

2024-10-09 Thread Ferruh Yigit
On 10/4/2024 8:18 PM, Dariusz Sosnowski wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Friday, October 4, 2024 09:27 >> To: Ferruh Yigit ; NBU-Contact-Thomas Monjalon >> (EXTERNAL) ; Ori Kam ; Aman Singh >> ; Konstantin Ananyev >> ; Reshma Pattan ; >> Stephen Hemminger ; A

Re: [PATCH] net/pcap: use pcap_next_ex to track errors

2024-10-09 Thread Stephen Hemminger
On Thu, 10 Oct 2024 03:24:42 +0100 Ferruh Yigit wrote: > On 10/10/2024 3:21 AM, Stephen Hemminger wrote: > > On Thu, 10 Oct 2024 03:14:48 +0100 > > Ferruh Yigit wrote: > > > >> On 9/5/2024 5:10 PM, Stephen Hemminger wrote: > >>> Use pcap_next_ex rather than just pcap_next because pcap_next

Re: [PATCH v2] net/memif: fix buffer overflow in zero copy Rx

2024-10-09 Thread Ferruh Yigit
On 6/28/2024 10:01 PM, Mihai Brodschi wrote: > rte_pktmbuf_alloc_bulk is called by the zero-copy receiver to allocate > new mbufs to be provided to the sender. The allocated mbuf pointers > are stored in a ring, but the alloc function doesn't implement index > wrap-around, so it writes past the end

Re: [PATCH] net/pcap: use pcap_next_ex to track errors

2024-10-09 Thread Ferruh Yigit
On 10/10/2024 3:21 AM, Stephen Hemminger wrote: > On Thu, 10 Oct 2024 03:14:48 +0100 > Ferruh Yigit wrote: > >> On 9/5/2024 5:10 PM, Stephen Hemminger wrote: >>> Use pcap_next_ex rather than just pcap_next because pcap_next >>> always blocks if there is no packets to receive. >>> >> >> Hi Step

[DPDK/other Bug 1562] dumpcap captures all available network interfaces when specifying any PCI network interface

2024-10-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1562 Bug ID: 1562 Summary: dumpcap captures all available network interfaces when specifying any PCI network interface Product: DPDK Version: 21.11 Hardware: All OS: All

Re: [PATCH] net/pcap: use pcap_next_ex to track errors

2024-10-09 Thread Ferruh Yigit
On 9/5/2024 5:10 PM, Stephen Hemminger wrote: > Use pcap_next_ex rather than just pcap_next because pcap_next > always blocks if there is no packets to receive. > Hi Stephen, Do you know if using 'pcap_next_ex()' (instead of 'pcap_next()') has any dependency impact? Like can we rely that all lib

RE: [PATCH] net/nfp: fix duplicate call to rte_free

2024-10-09 Thread Chaoyong He
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, September 28, 2024 5:58 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Chaoyong He > ; Niklas Söderlund > > Subject: [PATCH] net/nfp: fix duplicate call to rte_free > > Calling rte_free twice on same object will corrupt

Re: [PATCH v3 1/3] ethdev: add traffic manager query function

2024-10-09 Thread Ferruh Yigit
On 10/9/2024 11:32 AM, Bruce Richardson wrote: > Add function to allow querying a node in the scheduler tree. Returns > the parameters as were given to the add function. Adding this function > allows apps to just query the hierarchy rather than having to maintain > their own copies of it internall

Re: [PATCH v2] net/memif: fix buffer overflow in zero copy Rx

2024-10-09 Thread Ferruh Yigit
On 8/31/2024 2:38 PM, Mihai Brodschi wrote: > Hi Ferruh, > > Apologies for the late response. > I've run some performance tests for the two proposed solutions. > In the tables below, the rte_memcpy results correspond to this patch. > The 2xpktmbuf_alloc results correspond to the other proposed sol

Re: [PATCH] vhost: promote max queue setting API to stable

2024-10-09 Thread Chenbo Xia
> On Oct 9, 2024, at 21:00, Maxime Coquelin wrote: > > External email: Use caution opening links or attachments > > > This patch promotes the rte_vhost_driver_set_max_queue_num > API to stable. > > Signed-off-by: Maxime Coquelin > --- > lib/vhost/rte_vhost.h | 4 > lib/vhost/version.map

Re: [PATCH v4 0/6] refine argparse library

2024-10-09 Thread fengchengwen
Hi Thomas and David, Kindly ping for merge. On 2024/10/10 3:33, Stephen Hemminger wrote: > On Mon, 18 Mar 2024 11:18:32 + > Chengwen Feng wrote: > >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: re

Re: [PATCH v3] net/mvneta: fix possible out-of-bounds write

2024-10-09 Thread Stephen Hemminger
On Thu, 10 Oct 2024 00:53:26 + Chengwen Feng wrote: > The mvneta_ifnames_get() function will save 'iface' value to ifnames, > it will out-of-bounds write if passed many iface pairs (e.g. > 'iface=xxx,iface=xxx,...'). > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") > Cc: sta...@dpdk.

Re: [PATCH v2] net/mvneta: fix possible out-of-bounds write

2024-10-09 Thread fengchengwen
On 2024/10/10 2:00, Stephen Hemminger wrote: > On Wed, 9 Oct 2024 06:08:45 + > Chengwen Feng wrote: > >> The mvneta_ifnames_get() function will save 'iface' value to ifnames, >> it will out-of-bounds write if passed many iface pairs (e.g. >> 'iface=xxx,iface=xxx,...'). >> >> Fixes: 4ccc8d770d

[PATCH v3] net/mvneta: fix possible out-of-bounds write

2024-10-09 Thread Chengwen Feng
The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit --- v3: fi

Re: [PATCH] cryptodev: remove unnecessary list end

2024-10-09 Thread Ferruh Yigit
On 10/9/2024 12:24 PM, Akhil Goyal wrote: > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END and > RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END are not used anywhere and > mostly it do not fulfil any objective. > Rather it does not allow addition of new algorithms and > new padding type as it result in ABI breakage. >

Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-09 Thread Ferruh Yigit
On 10/4/2024 8:04 AM, David Marchand wrote: > On Fri, Oct 4, 2024 at 5:55 AM Ferruh Yigit wrote: >> >> On 9/5/2024 11:14 AM, Akhil Goyal wrote: >>> Replace *_LIST_END enumerators from asymmetric crypto >>> lib to avoid ABI breakage for every new addition in >>> enums with inline APIs. >>> >>> Sign

Re: [PATCH v4 1/7] ethdev: fix race-condition of proactive error handling mode

2024-10-09 Thread Stephen Hemminger
On Thu, 5 Sep 2024 09:24:58 + Chengwen Feng wrote: > In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a > race-condition with data pa

Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-09 Thread Ferruh Yigit
On 10/4/2024 10:38 AM, Dodji Seketeli wrote: > Hello, > > Ferruh Yigit writes: > >> On 9/5/2024 11:14 AM, Akhil Goyal wrote: >>> Replace *_LIST_END enumerators from asymmetric crypto >>> lib to avoid ABI breakage for every new addition in >>> enums with inline APIs. >>> >>> Signed-off-by: Akhil

Re: [PATCH v2 2/2] examples/l3fwd: fix read beyond array boundaries in ACL mode

2024-10-09 Thread Stephen Hemminger
On Tue, 30 Jul 2024 13:22:35 +0100 Konstantin Ananyev wrote: > From: Konstantin Ananyev > > With commit: ACL mode now can use send_packets_multi(). > What I missed with that changes: send_packets_multi() can't deal > properly with input dst_port[i] == BAD_PORT (though it can set > it itself), a

Re: [PATCH v2 1/2] examples/l3fwd: fix read beyond array bondaries

2024-10-09 Thread Stephen Hemminger
On Tue, 30 Jul 2024 13:22:34 +0100 Konstantin Ananyev wrote: > From: Konstantin Ananyev > > ASAN report: > ERROR: AddressSanitizer: unknown-crash on address 0x7ef92e32 at pc > 0x0053d1e9 bp 0x7ef92c00 sp 0x7ef92bf8 > READ of size 16 at 0x7ef92e32 thread T0 > #0 0x53d1e8

Re: [v2 2/2] eal: add total memory size in memory dump APIs

2024-10-09 Thread Stephen Hemminger
On Tue, 30 Jul 2024 16:33:13 +0530 Gagandeep Singh wrote: > This patch add total memory size dump in memzone and > memsegments dump APIs. > > Signed-off-by: Gagandeep Singh > --- > lib/eal/common/eal_common_memory.c | 2 ++ > lib/eal/common/eal_common_memzone.c | 18 -- > 2 f

Re: [PATCH] doc: update TAP device features

2024-10-09 Thread Ferruh Yigit
On 10/9/2024 5:53 PM, Stephen Hemminger wrote: > On Sun, 6 Oct 2024 21:36:31 +0100 > Ferruh Yigit wrote: > >> On 10/4/2024 9:48 PM, Stephen Hemminger wrote: >>> On Fri, 4 Oct 2024 02:48:21 +0100 >>> Ferruh Yigit wrote: >>> > +Stats per queue = Y > This feature name

Re: [RFC 0/4] ethdev: rework config restore

2024-10-09 Thread Ferruh Yigit
On 10/9/2024 5:18 PM, Dariusz Sosnowski wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, October 9, 2024 03:08 >> To: Konstantin Ananyev ; Dariusz Sosnowski >> ; NBU-Contact-Thomas Monjalon (EXTERNAL) >> ; Andrew Rybchenko >> Cc: dev@dpdk.org; Bruce Richardson >> Su

Re: [PATCH v6 1/2] dts: add methods for setting mac and multicast addresses

2024-10-09 Thread Patrick Robb
Actually, I do have one thought. On Tue, Oct 8, 2024 at 4:45 PM Nicholas Pratte wrote: > +def set_mac_addr(self, port_id: int, mac_address: str, add: bool, > verify: bool = True) -> None: > +"""Add or remove a mac address on a given port's Allowlist. > + > +Args: > +

Re: [PATCH v6 0/2] Mac Filter Port to New DTS

2024-10-09 Thread Patrick Robb
Series-reviewed-by: Patrick Robb

Re: [PATCH v6 1/2] dts: add methods for setting mac and multicast addresses

2024-10-09 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 0/4] cfgfile: enhance error detecting

2024-10-09 Thread Stephen Hemminger
On Fri, 5 Jul 2024 09:31:11 + Chengwen Feng wrote: > When I was trying to debug a problem introduced by config.ini in > test-dma-perf, I found the cfgfile library should enhance error > detecting, so got this patchset. > > Chengwen Feng (4): > cfgfile: remove dead code > cfgfile: support

Re: [PATCH v6 2/2] dts: mac filter test suite refactored for new dts

2024-10-09 Thread Patrick Robb
Thanks Nick this looks (almost) ready to be applied to next-dts. Other than a little disconnect between your series and Dean's Patch-145500 ("dts: add VLAN methods to testpmd shell") series which I will flag below, I think this looks good. On Tue, Oct 8, 2024 at 4:45 PM Nicholas Pratte wrote: >

Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

2024-10-09 Thread Stephen Hemminger
On Wed, 12 Apr 2023 17:52:39 +0800 Min Zhou wrote: > In the testpmd command, we have to stop the port firstly before configuring > the DCB. However, some PMDs may execute a hardware reset during the port > stop, such as ixgbe. Some kind of reset operations of PMD could clear the > configurations

RE: [PATCH v7 1/7] eal: add static per-lcore memory allocation facility

2024-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 18 September 2024 10.26 > > Introduce DPDK per-lcore id variables, or lcore variables for short. > > An lcore variable has one value for every current and future lcore > id-equipped thread. > > The primary use ca

Re: [PATCH v6 1/7] event/dlb2: include headers for vector and memory copy APIs

2024-10-09 Thread Stephen Hemminger
On Fri, 20 Sep 2024 12:27:10 +0200 Mattias Rönnblom wrote: > The DLB2 PMD depended on being included as a side-effect > of being included. > > In addition, DLB2 used rte_memcpy() but did not include , > but rather depended on other include files to do so. > > This patch addresses both of thos

RE: [PATCH v6 7/7] vhost: optimize memcpy routines when cc memcpy is used

2024-10-09 Thread Morten Brørup
> +#if defined(RTE_USE_CC_MEMCPY) && defined(RTE_ARCH_X86_64) > +static __rte_always_inline void > +pktcpy(void *restrict in_dst, const void *restrict in_src, size_t len) > +{ A comment describing why batch_copy_elem.dst and src point to 16 byte aligned data would be nice. > + void *dst = __

[PATCH v3 12/12] baseband/acc: clean up of VRB1 capabilities

2024-10-09 Thread Hernan Vargas
The interrupt support was defeatured on the VRB1 device. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/vrb1.rst | 3 --- drivers/baseband/acc/rte_vrb_pmd.c | 8 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/doc/guides/bbdevs/vrb1.rst b/doc/guides/bbdevs/vrb

[PATCH v3 11/12] baseband/acc: rte free refactor

2024-10-09 Thread Hernan Vargas
Refactor to explicitly set pointer to NULL after free to avoid double free. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 23 +++-- drivers/baseband/acc/rte_vrb_pmd.c| 48 +++ 2 files changed, 39 insertions(+), 32 deletions(-) diff

[PATCH v3 10/12] baseband/acc: cosmetic changes

2024-10-09 Thread Hernan Vargas
Cosmetic code changes. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- drivers/baseband/acc/rte_vrb_pmd.c| 54 +-- 2 files changed, 36 insertions(+), 20 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pm

[PATCH v3 09/12] baseband/acc: reset ring data valid bit

2024-10-09 Thread Hernan Vargas
Reset only the valid bit to keep info ring data notably for dumping. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rt

[PATCH v3 08/12] baseband/acc: remove check on HARQ memory

2024-10-09 Thread Hernan Vargas
Automatically reset HARQ memory to prevent errors and simplify usage. In a way we can assume that the HARQ output operation will always overwrite the buffer, so we can reset this from the driver to prevent an error being reported when application fails to do this explicitly. Signed-off-by: Hernan

[PATCH v3 07/12] baseband/acc: algorithm tuning for LDPC decoder

2024-10-09 Thread Hernan Vargas
Reverting to MS1 version of the algorithm to improve MU1 fading conditions. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/ba

[PATCH v3 06/12] baseband/acc: enhance SW ring alignment

2024-10-09 Thread Hernan Vargas
Calculate the aligned total size required for queue rings, ensuring that the size is a power of two for proper memory allocation. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/acc

[PATCH v3 05/12] baseband/acc: future proof structure comparison

2024-10-09 Thread Hernan Vargas
Some implementation in the PMD is based on some size assumption from the bbdev structure, which should use sizeof instead to be more future proof in case these structures change. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 4 ++-- 1 file cha

[PATCH v3 04/12] baseband/acc: configure max queues per device

2024-10-09 Thread Hernan Vargas
Configure max_queues based on the number of queue groups and numbers of AQS per device variant. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_

[PATCH v3 03/12] baseband/acc: queue allocation refactor

2024-10-09 Thread Hernan Vargas
Refactor to manage queue memory per operation more flexibly for VRB devices. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 5 + drivers/baseband/acc/rte_vrb_pmd.c | 214 - 2 files changed, 157 insertions(+), 62 deletions(-) diff --git a/driv

[PATCH v3 02/12] baseband/acc: fix soft output bypass RM

2024-10-09 Thread Hernan Vargas
Removing soft output bypass RM capability due to VRB2 device limitations. Fixes: b49fe052f9cd ("baseband/acc: add FEC capabilities for VRB2 variant") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_vrb_pmd.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions

[PATCH v3 01/12] baseband/acc: fix access to deallocated mem

2024-10-09 Thread Hernan Vargas
Prevent op_addr access during queue_stop operation, as this memory may have been deallocated. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 36 --

[PATCH v3 00/12] acc baseband PMD fix and updates for 24.11

2024-10-09 Thread Hernan Vargas
This series targets 24.11. v3: Updated code with community recommendations. Added 2 commits for rte_free refactor and clean up of VRB1 capabilities. v2: Rebased to the latest next-baseband-for-main which includes needed rte_bbdev lib updates. v1: It includes a memory access fix, refactoring of qu

RE: [EXTERNAL] Re: [PATCH v2] rawdev: add API to get device from index

2024-10-09 Thread Akhil Goyal
> > > diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h > > > index 22b406444d..8339122348 100644 > > > --- a/lib/rawdev/rte_rawdev_pmd.h > > > +++ b/lib/rawdev/rte_rawdev_pmd.h > > > @@ -102,6 +102,30 @@ rte_rawdev_pmd_get_named_dev(const char > *name) > > > return NUL

RE: [EXTERNAL] [PATCH v8 6/8] lib/cryptodev: add sm4 xts for crypto

2024-10-09 Thread Akhil Goyal
> Title should be cryptodev: add SM4-XTS > > > add support of sm4 xts . > > > > Signed-off-by: Hanxiao Li > > Send this patch (along with test cases) as a separate patchset "not included > in this > series." > > Update documentation doc/guides/cryptodevs/features/defaults.ini > Update release

RE: [PATCH v6 6/7] ci: test compiler memcpy

2024-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Friday, 20 September 2024 12.27 > +if [ "$CCMEMCPY" = "true" ]; then > + OPTS="$OPTS -Duse_cc_memcpy=true" > +else > + OPTS="$OPTS -Duse_cc_memcpy=true" > +fi With the bug (only testing true) found by David fixed, Ac

RE: [EXTERNAL] [PATCH v5 1/4] cryptodev: reorder structures in asym crypto header

2024-10-09 Thread Akhil Goyal
> Asymmetric-crypto header has a simple structure that allows to > keep logically separate blocks together. Therefore, xforms, > ops, and generic structs may be appropriately ordered. > This patch moves sm2-op structs to be placed along other > algorithms-op structs. > > Signed-off-by: Arkadiusz K

RE: [EXTERNAL] [v2] crypto/dpaa2_sec: rework debug code

2024-10-09 Thread Akhil Goyal
Hi Gagan, > Output debug information according to various modes. > > Signed-off-by: Jun Yang > Signed-off-by: Gagandeep Singh It seems the base patch was merged in main branch. Can you rebase this patch on current top of tree? > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 72

RE: [PATCH v6 4/7] fib: add missing vector API header include

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [PATCH v6 3/7] distributor: add missing vector API header include

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [PATCH v6 2/7] net/octeon_ep: add missing vector API header include

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [PATCH v6 1/7] event/dlb2: include headers for vector and memory copy APIs

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-09 Thread Akhil Goyal
> In the case when PMD cannot support the full process of the SM2, > but elliptic curve computation only, additional fields > are needed to handle such a case. > > Points C1, kP therefore were added to the SM2 crypto operation struct. > > Signed-off-by: Arkadiusz Kusztal > --- > lib/cryptodev/r

RE: [EXTERNAL] [PATCH v5 3/4] crypto/qat: add sm2 encryption/decryption function

2024-10-09 Thread Akhil Goyal
> This commit adds SM2 elliptic curve based asymmetric > encryption and decryption to the Intel QuickAssist > Technology PMD. > > Signed-off-by: Arkadiusz Kusztal > --- > doc/guides/cryptodevs/features/qat.ini | 1 + > doc/guides/rel_notes/release_24_11.rst | 4 + > drivers

RE: [PATCH v7 3/7] eal: add lcore variable performance test

2024-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 18 September 2024 10.26 A few corrections to a comment. Besides that, Acked-by: Morten Brørup > +/* > + * The potential performance benefit of lcore variables compared to > + * the use of statically sized, lcore

RE: [PATCH] cryptodev: remove unnecessary list end

2024-10-09 Thread Akhil Goyal
> > From: Akhil Goyal [mailto:gak...@marvell.com] > > Sent: Wednesday, 9 October 2024 13.25 > > > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END and > > RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END are not used anywhere and > > mostly it do not fulfil any objective. > > Rather it does not allow addition of new algo

[DPDK/core Bug 1385] rt_bitops.h fails to give implied atomicity guarantees

2024-10-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1385 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED A

RE: [PATCH v3 1/3] cryptodev: add asymmetric operational capability

2024-10-09 Thread Akhil Goyal
> Subject: [PATCH v3 1/3] cryptodev: add asymmetric operational capability > > Asymmetric crypto algorithms such as SM2, EdDSA would need per op > capability and based on it, the input param to a crypto operation > is chosen wisely. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > v3: > -

RE: [PATCH 4/6] eal: add unit tests for atomic bitset operations

2024-10-09 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 12 September 2024 06.52 > > On Fri, Aug 09, 2024 at 10:14:38PM +0200, Mattias R??nnblom wrote: > > Extend bitset tests to cover the basic operation of the > > rte_bitset_atomic_*() family of functions. > > > > Signed-of

Re: [PATCH v3 5/5] net/cxgbe: use rte macro instead of GCC attribute

2024-10-09 Thread David Marchand
On Wed, Mar 6, 2024 at 11:14 PM Tyler Retzlaff wrote: > > Use existing __rte_may_alias macro from rte_common.h instead of > directly using __attribute__((__may_alias__)). > > Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Reviewed-by: Potnuri Bharat Teja Applied, thanks. -- David

Re: [PATCH v12 0/7] Improve EAL bit operations API

2024-10-09 Thread David Marchand
On Fri, Sep 20, 2024 at 12:57 PM Mattias Rönnblom wrote: > > This patch set represent an attempt to improve and extend the RTE > bitops API, in particular for functions that operate on individual > bits. > > All new functionality is exposed to the user as generic selection > macros, delegating the

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Akhil Goyal
> > > > Introduce stateless packet preparation API for IPsec > > processing. The new API would allow preparation of IPsec > > packets without altering the internal state of an IPsec > > session. > > > > For outbound IPsec processing, the change enables user to > > provide sequence number to be us

RE: [EXTERNAL] Re: [PATCH v1] Revert "doc: extension of crypto event callback announced"

2024-10-09 Thread Akhil Goyal
> On Thu, 1 Aug 2024 13:06:07 +0530 > Srujana Challa wrote: > > > The previously planned update to the `rte_cryptodev_cb_fn` function > > prototype is being reverted. The introduction of the > > `rte_cryptodev_queue_pair_event_error_query` API provides a means for > > applications to retrieve the

RE: [PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-09 Thread Akhil Goyal
> Acked-by: Arek Kusztal > Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Updated release notes and removed associated deprecation notices. Thanks.

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-09 Thread Akhil Goyal
> > Subject: RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm > > > > > Acked-by: Arkadiusz Kusztal Series Applied to dpdk-next-crypto Thanks. Updated release notes and removed deprecation notices for EDDSA.

Re: [PATCH v4 0/6] refine argparse library

2024-10-09 Thread Stephen Hemminger
On Mon, 18 Mar 2024 11:18:32 + Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argp

Re: [PATCH v2] doc: reword sample app guides

2024-10-09 Thread Stephen Hemminger
On Sun, 6 Oct 2024 16:45:17 -0700 Nandini Persad wrote: > I have reviewed these sections for grammar/clarity > and made small modifications to the formatting of sections > to adhere to a template which will create uniformality > in the sample application user guides overall. > > Signed-off-by:

RE: [PATCH v2 1/2] fib: implement RCU rule reclamation

2024-10-09 Thread Doug Foster
The check for NULL is not necessary before calling rte_rcu_qsbr_dq_delete. Similar to other free routines, an error will not occur when the dq pointer is NULL. However, it will give a debug log statement to indicate an invalid parameter and return 0 to indicate success. -Original Message---

Re: [PATCH] doc: enhance the global log level documentation

2024-10-09 Thread Stephen Hemminger
On Wed, 26 Jun 2024 19:10:48 +0200 Ilya Maximets wrote: > On 6/26/24 17:09, David Marchand wrote: > > The current documentation is non intuitive in that the global log level > > can be understood as being a single knob controlling all components > > logs. > > On the contrary, all the global log l

Re: [PATCH v4 2/2] ip_frag: updated name for IP frag define

2024-10-09 Thread Stephen Hemminger
On Mon, 8 Jan 2024 11:36:14 + Euan Bourke wrote: > diff --git a/config/rte_config.h b/config/rte_config.h > index da265d7dd2..e2fa2a58fa 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -85,7 +85,7 @@ > #define RTE_RAWDEV_MAX_DEVS 64 > > /* ip_fragmentation defines */

Re: [PATCH v2] fib: network byte order IPv4 lookup

2024-10-09 Thread Stephen Hemminger
On Tue, 8 Oct 2024 17:16:05 + Vladimir Medvedkin wrote: > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order

RE: [EXTERNAL] Re: [PATCH v3 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-09 Thread Akhil Goyal
> On Wed, 9 Oct 2024 00:19:07 +0530 > Akhil Goyal wrote: > > > CNXK product families can have a use case to allow PF and VF > > applications to communicate using mailboxes and also get notified > > of any interrupt that may occur on the device. > > Hence, a new raw device driver is added for such

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Konstantin Ananyev
> Introduce stateless packet preparation API for IPsec > processing. The new API would allow preparation of IPsec > packets without altering the internal state of an IPsec > session. > > For outbound IPsec processing, the change enables user to > provide sequence number to be used for the IPsec

Re: [v5 15/15] bus/dpaa: add port bmi stats

2024-10-09 Thread Stephen Hemminger
On Tue, 8 Oct 2024 16:28:10 +0530 Gagandeep Singh wrote: > From: Hemant Agrawal > > Add BMI statistics and fixing the existing extended > statistics > > Signed-off-by: Hemant Agrawal > Signed-off-by: Gagandeep Singh > --- This patch is failing build, Fedora has a more recent Gcc with more

Re: [PATCH v2] net/mvneta: fix possible out-of-bounds write

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 06:08:45 + Chengwen Feng wrote: > The mvneta_ifnames_get() function will save 'iface' value to ifnames, > it will out-of-bounds write if passed many iface pairs (e.g. > 'iface=xxx,iface=xxx,...'). > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") > Cc: sta...@dpdk.o

Re: [PATCH v13 4/4] eal: add PMU support to tracing library

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 14:50:02 +0200 Morten Brørup wrote: > > From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > > Sent: Wednesday, 9 October 2024 13.23 > > > > +PMU tracepoint > > +-- > > + > > +Performance monitoring unit (PMU) event values can be read from > > hardware > > +reg

Re: [PATCH 4/5] net/ice: add option to download scheduler topology

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:21 +0100 Bruce Richardson wrote: > diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h > index 2781362d04..76310f2c99 100644 > --- a/drivers/net/ice/ice_ethdev.h > +++ b/drivers/net/ice/ice_ethdev.h > @@ -564,6 +564,7 @@ struct ice_devargs { >

Re: [PATCH 2/5] net/ice: improve Tx scheduler graph output

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:19 +0100 Bruce Richardson wrote: > The function to dump the TX scheduler topology only adds to the chart > nodes connected to TX queues or for the flow director VSI. Change the > function to work recursively from the root node and thereby include all > scheduler nodes, w

Re: [PATCH 5/5] net/ice: limit the number of queues to sched capabilities

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:22 +0100 Bruce Richardson wrote: > Rather than assuming that each VSI can hold up to 256 queue pairs, > or the reported device limit, query the available nodes in the scheduler > tree to check that we are not overflowing the limit for number of > child scheduling nodes a

Re: [PATCH 3/5] net/ice: add option to choose DDP package file

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:20 +0100 Bruce Richardson wrote: > The "Dynamic Device Personalization" package is loaded at initialization > time by the driver, but the specific package file loaded depends upon > what package file is found first by searching through a hard-coded list > of firmware pat

  1   2   3   >