RE: [PATCH] test/event: remove timer state check

2023-08-04 Thread Carrillo, Erik G
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, July 31, 2023 8:29 AM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] test/event: remove timer state check > > From: Pavan Nikhilesh >

RE: [PATCH] doc: fix event timer adapter guide

2023-04-12 Thread Carrillo, Erik G
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, April 7, 2023 3:14 AM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] doc: fix event timer adapter guide > > From: Pavan Nikhilesh &g

RE: [PATCH v2] eventdev/timer: fix timeout event wait behavior

2023-04-12 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Tuesday, March 21, 2023 12:20 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: Shijith Thotton ; dev@dpdk.org; > pbhagavat...@marvell.com; sta...@dpdk.org > Subject: [PATCH v2] eventdev/timer: fix timeou

RE: [PATCH v2] eventdev/timer: fix overflow issue

2023-02-07 Thread Carrillo, Erik G
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, February 7, 2023 12:01 AM > To: Carrillo, Erik G ; Stephen Hemminger > > Cc: jer...@marvell.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] eventdev/timer: fix overflow issue > > On W

RE: [PATCH v3] eventdev/timer: add API to get remaining ticks

2023-01-13 Thread Carrillo, Erik G
Hi Jerin, Thanks for the review. One response in-line: <...snipped...> > > +static int > > +swtim_get_remaining_ticks(const struct rte_event_timer_adapter > *adapter, > > + const struct rte_event_timer *evtim, > > + uint64_t *ticks_remaining) { >

RE: [EXT] [PATCH v2] eventdev/timer: add API to get remaining ticks

2022-12-19 Thread Carrillo, Erik G
<... snipped ...> > > diff --git a/app/test/test_event_timer_adapter.c > > b/app/test/test_event_timer_adapter.c > > index 1a440dfd10..1a1fb48b24 100644 > > --- a/app/test/test_event_timer_adapter.c > > +++ b/app/test/test_event_timer_adapter.c > > @@ -1920,6 +1920,72 @@ adapter_create_max(void) >

RE: [PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-19 Thread Carrillo, Erik G
Hi Harish, Adding a couple of comments inline: > -Original Message- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 12:29 AM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v

RE: [PATCH] eventdev/timer: add API to get remaining ticks

2022-12-17 Thread Carrillo, Erik G
> -Original Message- > From: Mattias Rönnblom > Sent: Saturday, December 17, 2022 3:22 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: Naga Harish K, S V ; Jayatheerthan, Jay > ; pbhagavat...@marvell.com; > sthot...@marvell.com; dev@dpdk.org > Subject: Re

RE: [PATCH v2] doc: fix minor issues in the event timer adapter guide

2022-11-01 Thread Carrillo, Erik G
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, November 1, 2022 4:34 AM > To: Carrillo, Erik G > Cc: Jerin Jacob ; dev@dpdk.org; sta...@dpdk.org; > mattias.ronnblom > Subject: [PATCH v2] doc: fix minor issues in the event timer adapter guid

RE: [PATCH 4/4] eventdev: have timer adapter appropriately report idle

2022-10-17 Thread Carrillo, Erik G
> -Original Message- > From: Mattias Rönnblom > Sent: Monday, October 10, 2022 9:54 AM > To: Jayatheerthan, Jay ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; Jerin Jacob > Cc: dev@dpdk.org; Van Haaren, Harry ; > hof...@lysator.liu.se; mattias.ronnblom > Su

RE: [PATCH v4 4/4] test/event: update periodic event timer tests

2022-08-18 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:07 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v4 4/4] test/event: update periodic event timer tes

RE: [PATCH v4 3/4] timer: fix function to stop all timers

2022-08-18 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:08 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v4 3/4] timer: fix function to stop all timers > > There is a possibility of deadlock in this

RE: [PATCH v4 1/4] eventdev/timer: add periodic event timer support

2022-08-18 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:07 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v4 1/4] eventdev/timer: add periodic event timer

RE: [PATCH v3 1/4] eventdev/timer: add periodic event timer support

2022-08-11 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Thursday, August 11, 2022 10:37 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v3 1/4] eventdev/timer: add periodic e

RE: [PATCH v2 2/4] event/sw: report periodic event timer capability

2022-08-10 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, August 10, 2022 2:10 AM > To: Carrillo, Erik G ; jer...@marvell.com; Van > Haaren, Harry > Cc: dev@dpdk.org > Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability >

RE: [PATCH v2 1/4] eventdev/timer: add periodic event timer support

2022-08-10 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, August 10, 2022 2:07 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v2 1/4] eventdev/timer: add periodic e

RE: [PATCH v2 3/4] timer: fix function to stop all timers

2022-08-10 Thread Carrillo, Erik G
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, August 10, 2022 2:10 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2 3/4] timer: fix function to stop all timers > > There is a possibility of deadl

RE: [PATCH] doc: add event timer expiry drop stat

2022-06-30 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Monday, June 27, 2022 10:40 AM > To: m...@ashroe.eu; jer...@marvell.com; pbhagavat...@marvell.com; > sthot...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org > Subject: [PATCH] doc: add event timer expi

RE: [PATCH v5 41/50] eventdev: remove unneeded header includes

2022-01-18 Thread Carrillo, Erik G
> -Original Message- > From: Morrissey, Sean > Sent: Monday, January 17, 2022 2:20 PM > To: Jerin Jacob ; Carrillo, Erik G > > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v5 41/50] eventdev: remove unneeded header includes > > These header includ

RE: [PATCH v5 07/50] timer: remove unneeded header includes

2022-01-18 Thread Carrillo, Erik G
> -Original Message- > From: Morrissey, Sean > Sent: Monday, January 17, 2022 2:19 PM > To: Robert Sanford ; Carrillo, Erik G > > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v5 07/50] timer: remove unneeded header includes > > These header includ

Re: [dpdk-dev] [PATCH v5 11/14] eventdev: move timer adapters memory to hugepage

2021-10-20 Thread Carrillo, Erik G
Hi Pavan and Jerin, > -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, October 18, 2021 6:36 PM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 11/14] eventdev: move timer adapters &g

Re: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage

2021-10-08 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Friday, October 8, 2021 12:38 AM > To: Carrillo, Erik G ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters > memory to hugepag

Re: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage

2021-10-07 Thread Carrillo, Erik G
Hi Pavan, Some comments below: > -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, October 6, 2021 1:50 AM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer

Re: [dpdk-dev] [PATCH] app/test: fix event timer adapter create unit test

2021-09-09 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Monday, August 30, 2021 3:13 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; jer...@marvell.com; > pbhagavat...@marvell.com; Carrillo, Erik G > Subject: [PATCH] app/test: fix event timer adapter create unit test &g

Re: [dpdk-dev] [EXT] Re: [RFC 11/15] eventdev: reserve fields in timer object

2021-09-07 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 1, 2021 1:48 AM > To: Stephen Hemminger ; Carrillo, Erik G > > Cc: Jerin Jacob Kollanukkaran ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [EXT] Re: [dpdk-dev] [RFC

Re: [dpdk-dev] [RFC 12/15] eventdev: move timer adapters memory to hugepage

2021-08-24 Thread Carrillo, Erik G
Hi Pavan, > -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, August 23, 2021 2:40 PM > To: jer...@marvell.com; Carrillo, Erik G > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Pavan Nikhilesh > Subject: [dpdk-dev] [RFC 12/15] eventdev: move tim

Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

2021-08-23 Thread Carrillo, Erik G
Hi Pavan, One comment in-line: > -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, August 23, 2021 2:40 PM > To: jer...@marvell.com; Carrillo, Erik G > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Pavan Nikhilesh > Subject: [dpdk-dev] [RFC 11/

Re: [dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure check

2021-05-03 Thread Carrillo, Erik G
> -Original Message- > From: Min Hu (Connor) > Sent: Monday, May 3, 2021 8:08 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Carrillo, Erik G > ; rsanf...@akamai.com > Subject: [PATCH v2] test/timer: fix memzone reserve failure check > > Segmentation fault ma

Re: [dpdk-dev] [PATCH] test/timer: fix memzone reserve failure check

2021-05-01 Thread Carrillo, Erik G
> -Original Message- > From: Min Hu (Connor) > Sent: Thursday, April 22, 2021 4:19 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; rsanf...@akamai.com; Carrillo, > Erik G > Subject: [PATCH] test/timer: fix memzone reserve failure check > > Segmentation fault ma

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-04-21 Thread Carrillo, Erik G
> -Original Message- > From: Min Hu (Connor) > Sent: Thursday, April 15, 2021 2:12 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; rsanf...@akamai.com; Carrillo, > Erik G > Subject: [PATCH] examples/timer: fix incorrect time interval > > From: Chengchang Tang

Re: [dpdk-dev] [PATCH 1/2] timer: clarify subsystem_init return value

2021-03-29 Thread Carrillo, Erik G
> -Original Message- > From: Michal Krawczyk > Sent: Friday, March 26, 2021 5:48 AM > To: dev@dpdk.org; Robert Sanford ; Carrillo, Erik G > > Cc: Stanislaw Kardach ; Michal Krawczyk > > Subject: [PATCH 1/2] timer: clarify subsystem_init return value >

Re: [dpdk-dev] [PATCH v3 2/3] test/event: add unit tests for periodic timer

2021-03-17 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Wednesday, March 17, 2021 3:04 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH v3 2/3] test/event: add unit tests for periodic timer > &g

Re: [dpdk-dev] [PATCH v3 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-17 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Wednesday, March 17, 2021 3:04 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH v3 1/3] eventdev: introduce adapter flags for periodic mode

Re: [dpdk-dev] [PATCH] app/eventdev: fix timeout accuracy

2021-03-17 Thread Carrillo, Erik G
Hi Pavan, > -Original Message- > From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Thursday, February 25, 2021 6:02 AM > To: jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/eventdev: fix timeout accuracy > > From: Pavan

Re: [dpdk-dev] [PATCH v2 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-16 Thread Carrillo, Erik G
Thanks, Shijith. I'm posting a couple of follow-up comments in-line: > -Original Message- > From: Shijith Thotton > Sent: Sunday, March 14, 2021 11:46 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Sub

Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-12 Thread Carrillo, Erik G
Hi Shijith, Some comments in-line: > -Original Message- > From: Shijith Thotton > Sent: Monday, March 8, 2021 2:46 PM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH 1/3] eventdev: introduce ad

Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-11 Thread Carrillo, Erik G
Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Wednesday, March 10, 2021 3:15 AM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter f

Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-09 Thread Carrillo, Erik G
Hi Shijith, Please see a question in-line: > -Original Message- > From: Shijith Thotton > Sent: Monday, March 8, 2021 2:46 PM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH 1/3] eventdev: int

Re: [dpdk-dev] [PATCH] test/event: fix timeout accuracy

2021-03-08 Thread Carrillo, Erik G
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Saturday, March 6, 2021 2:27 PM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] test/event: fix timeout accuracy >

Re: [dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and reset

2020-10-08 Thread Carrillo, Erik G
> -Original Message- > From: David Marchand > Sent: Thursday, October 8, 2020 5:28 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; sta...@dpdk.org; nd ; Honnappa > Nagarahalli ; Sarosh Arif > > Subject: Re: [dpdk-dev] [PATCH 1/1] timer: add limitation note f

Re: [dpdk-dev] [PATCH] doc: announce API change in timer

2020-08-04 Thread Carrillo, Erik G
> -Original Message- > From: Sarosh Arif > Sent: Monday, August 3, 2020 10:29 PM > To: Honnappa Nagarahalli ; Carrillo, Erik G > > Cc: rsanf...@akamai.com; dev@dpdk.org; nd > Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in timer > > Thank you Er

Re: [dpdk-dev] [PATCH] doc: announce API change in timer

2020-08-03 Thread Carrillo, Erik G
> -Original Message- > From: Sarosh Arif > Sent: Monday, August 3, 2020 6:21 AM > To: Carrillo, Erik G ; rsanf...@akamai.com > Cc: dev@dpdk.org; Sarosh Arif > Subject: [PATCH] doc: announce API change in timer > > If the user tries to reset/stop some othe

Re: [dpdk-dev] [PATCH v3] lib/librte_timer:fix corruption with reset

2020-07-28 Thread Carrillo, Erik G
Hi Sarosh, Some comments in-line: > -Original Message- > From: Sarosh Arif > Sent: Friday, July 10, 2020 2:00 AM > To: rsanf...@akamai.com; Carrillo, Erik G ; > dev@dpdk.org > Cc: sta...@dpdk.org; Sarosh Arif ; > h.mikit...@gmail.com > Subject: [PATCH v3] lib/lib

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-07-02 Thread Carrillo, Erik G
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, July 1, 2020 10:56 PM > To: Phil Yang ; Carrillo, Erik G > ; dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Ruifeng Wang ; > Dharmik Thakkar ; sta...@dpdk.org; nd > ; jer...@marvell.com; Hon

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11 atomics

2020-07-02 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Thursday, July 2, 2020 12:27 AM > To: Carrillo, Erik G ; dev@dpdk.org > Cc: jer...@marvell.com; honnappa.nagaraha...@arm.com; > d...@linux.vnet.ibm.com; ruifeng.w...@arm.com; > dharmik.thak...@arm.com; n...@arm.com >

Re: [dpdk-dev] [PATCH v2 2/4] eventdev: use c11 atomics for lcore timer armed flag

2020-07-02 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Thursday, July 2, 2020 12:27 AM > To: Carrillo, Erik G ; dev@dpdk.org > Cc: jer...@marvell.com; honnappa.nagaraha...@arm.com; > d...@linux.vnet.ibm.com; ruifeng.w...@arm.com; > dharmik.thak...@arm.com; n...@arm.com >

Re: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics

2020-06-29 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Sunday, June 28, 2020 12:34 PM > To: Carrillo, Erik G ; dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar > ; nd > Subject: RE: [dpdk-dev] [PATCH 3/3] eventdev:

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, June 23, 2020 4:20 PM > To: Phil Yang > Cc: dev@dpdk.org; Carrillo, Erik G ; > d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com >

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com >

Re: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Monday, June 22, 2020 5:12 AM > To: Phil Yang ; dev@dpdk.org; Carrillo, Erik G > > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar > ; nd > Su

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-06-18 Thread Carrillo, Erik G
Hi Phil, Good catch - thanks for the fix. I've commented in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w..

Re: [dpdk-dev] [PATCH v3] lib/timer: relax barrier for status update

2020-04-26 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Sunday, April 26, 2020 9:20 AM > To: Carrillo, Erik G ; tho...@monjalon.net > Cc: rsanf...@akamai.com; dev@dpdk.org; david.march...@redhat.com; > Honnappa Nagarahalli ; Gavin Hu > ; nd ; nd ; nd > > Subject: RE

Re: [dpdk-dev] [PATCH v3] lib/timer: relax barrier for status update

2020-04-26 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Sunday, April 26, 2020 2:36 AM > To: tho...@monjalon.net > Cc: Carrillo, Erik G ; rsanf...@akamai.com; > dev@dpdk.org; david.march...@redhat.com; Honnappa Nagarahalli > ; Gavin Hu ; nd > ; nd > Subject: RE: [dpd

Re: [dpdk-dev] [PATCH v2] lib/timer: relax barrier for status update

2020-04-23 Thread Carrillo, Erik G
Hi Honnappa, > -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, April 23, 2020 3:06 PM > To: Phil Yang ; Carrillo, Erik G > ; rsanf...@akamai.com; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Ananyev, > Konstantin ; jer...@marve

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-09 Thread Carrillo, Erik G
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, April 8, 2020 4:56 PM > To: Carrillo, Erik G ; Phil Yang > ; rsanf...@akamai.com; dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; >

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-08 Thread Carrillo, Erik G
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, April 8, 2020 4:16 PM > To: Carrillo, Erik G ; Phil Yang > ; rsanf...@akamai.com; dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; >

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-08 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Monday, February 24, 2020 12:42 AM > To: rsanf...@akamai.com; Carrillo, Erik G ; > dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nx

Re: [dpdk-dev] Questions about rte_timer APIs

2020-02-26 Thread Carrillo, Erik G
, Erik > -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, February 25, 2020 5:56 PM > To: Honnappa Nagarahalli ; Robert > Sanford ; Carrillo, Erik G > Cc: dev ; nd ; Phil Yang > ; Gavin Hu ; > david.march...@redhat.com; tho...@monjalon.net; nd

Re: [dpdk-dev] [PATCH 1/2] lib/timer: protect timer subsystem initialized with lock

2020-02-25 Thread Carrillo, Erik G
> -Original Message- > From: Phil Yang > Sent: Monday, February 24, 2020 12:42 AM > To: rsanf...@akamai.com; Carrillo, Erik G ; > dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nx

Re: [dpdk-dev] [PATCH v1] rte_timer: add rte_timer_next_ticks

2019-12-20 Thread Carrillo, Erik G
Hi Stephen, I added a comment in-line. With that change, it looks good to me: Acked-by: Erik Gabriel Carrillo Regards, Erik > -Original Message- > From: Stephen Hemminger > Sent: Monday, December 16, 2019 6:55 PM > To: dev@dpdk.org > Cc: Carrillo, Erik G ; St

Re: [dpdk-dev] [PATCH v4 04/10] timer: remove deprecated code

2019-10-17 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, October 17, 2019 9:32 AM > To: dev@dpdk.org > Cc: Baran, MarcinX ; Robert Sanford > ; Carrillo, Erik G ; > Mcnamara, John ; Richardson, Bruce > ; tho...@monjalon.net; > david.march...@redhat.com

Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference

2019-07-16 Thread Carrillo, Erik G
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, July 16, 2019 3:31 AM > To: Carrillo, Erik G > Cc: 'Stephen Hemminger' ; > 'tho...@monjalon.net' ; 'dev@dpdk.org' > > Subject: Re: [dpdk-dev] [PATCH 1/2] timer: fix nu

Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference

2019-07-15 Thread Carrillo, Erik G
> -Original Message- > From: Carrillo, Erik G > Sent: Monday, July 15, 2019 11:04 AM > To: Stephen Hemminger > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference > > Hi Stephen, >

Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference

2019-07-15 Thread Carrillo, Erik G
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Monday, July 15, 2019 10:49 AM > To: Carrillo, Erik G > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference > > On M

Re: [dpdk-dev] [PATCH 2/2] timer: fix resource leak in finalize

2019-06-27 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 11:12 AM > To: dev@dpdk.org > Cc: Robert Sanford ; Carrillo, Erik G > > Subject: [PATCH 2/2] timer: fix resource leak in finalize > > Currently, whenever timer library is initia

Re: [dpdk-dev] [PATCH 1/2] eal: add internal locks for timer lib into EAL

2019-06-27 Thread Carrillo, Erik G
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 11:12 AM > To: dev@dpdk.org > Cc: Carrillo, Erik G > Subject: [PATCH 1/2] eal: add internal locks for timer lib into EAL > > Currently, timer library has a memory leak be

Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks

2019-06-12 Thread Carrillo, Erik G
Hi Stephen, This looks like a useful addition. Some comments in-line: > -Original Message- > From: Stephen Hemminger > Sent: Monday, June 10, 2019 5:45 PM > To: rsanf...@akamai.com; Carrillo, Erik G > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [R

Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in eventmode

2019-06-10 Thread Carrillo, Erik G
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:32 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Narayana Prasad > ; dev@dpdk.

Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers

2019-06-10 Thread Carrillo, Erik G
Hi Anoob, One other observation in-line: > -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:33 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Ano

Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers

2019-06-10 Thread Carrillo, Erik G
Hi Anoob, I've listed a few notes in-line. > -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:33 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc

Re: [dpdk-dev] Hugepages not being deleted

2019-05-20 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, May 20, 2019 6:45 AM > To: David Marchand > Cc: Michael Santana ; dev ; > Carrillo, Erik G > Subject: Re: [dpdk-dev] Hugepages not being deleted > > On 20-May-19 12:09 PM, David Marchand wrote: >

Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary

2019-05-09 Thread Carrillo, Erik G
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 9, 2019 3:13 PM > To: Carrillo, Erik G > Cc: Burakov, Anatoly ; rsanf...@akamai.com; > dev@dpdk.org > Subject: Re: [PATCH v2] timer: allow first subsystem init from seconda

Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary

2019-05-09 Thread Carrillo, Erik G
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 9, 2019 2:52 PM > To: Carrillo, Erik G > Cc: Burakov, Anatoly ; rsanf...@akamai.com; > dev@dpdk.org > Subject: Re: [PATCH v2] timer: allow first subsystem init from seconda

Re: [dpdk-dev] [PATCH] timer: allow first subsystem init from secondary

2019-05-09 Thread Carrillo, Erik G
<...snipped...> > > > > @@ -155,40 +156,41 @@ rte_timer_subsystem_init_v1905(void) > > struct rte_timer_data *data; > > int i, lcore_id; > > static const char *mz_name = "rte_timer_mz"; > > + const size_t data_arr_size = > > + RTE_MAX_DATA_ELS * > sizeof(*rt

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-08 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, May 8, 2019 3:50 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] timer: fix resource leak in finalize > > On 07-May-19 11:04

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-07 Thread Carrillo, Erik G
Hi Anatoly, Thanks for the review. Comments in-line: <...snipped...> > > #define RTE_MAX_DATA_ELS 64 > > +static const struct rte_memzone *rte_timer_data_mz; static > > +rte_atomic16_t *rte_timer_mz_refcnt; > > static struct rte_timer_data *rte_timer_data_arr; > > static const uint32_t de

Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize

2019-05-02 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, May 2, 2019 8:04 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize > > On 02-May-1

Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize

2019-05-02 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, May 2, 2019 4:18 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize > > On 01-M

Re: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter

2019-04-26 Thread Carrillo, Erik G
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, April 26, 2019 1:51 PM > To: Carrillo, Erik G ; > jerin.ja...@caviumnetworks.com > Cc: mattias.ronnb...@ericsson.com; pbhagavat...@caviumnetworks.com; > d

Re: [dpdk-dev] [PATCH] eventdev: promote adapter functions as stable

2019-04-18 Thread Carrillo, Erik G
> -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Thursday, April 18, 2019 7:06 AM > To: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Mattias Rönnblom > ; Van Haaren, Harry > ; Gujjar, Abhinandan S > ; Rao, Nikhil ; Carrillo, &

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-04-15 Thread Carrillo, Erik G
3 AM > To: Carrillo, Erik G ; tho...@monjalon.net; > dev@dpdk.org > Cc: nhor...@tuxdriver.com > Subject: Re: [PATCH v4 1/2] timer: allow timer management in shared > memory > > Hi Erik, > > I have a few questions and comments on this patch series. > > 1. Don

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-28 Thread Carrillo, Erik G
> On Mar 27, 2019, at 9:03 AM, Thomas Monjalon wrote: > > 21/03/2019 02:01, Carrillo, Erik G: >> Hi Robert, >> >> Thanks for the review and suggestions. I’m out of the office on bonding >> leave for the next few weeks, but I’ll update the patch to address yo

Re: [dpdk-dev] [PATCH 2/2] test/event_timer: improve unit test compatability

2019-03-25 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Saturday, March 16, 2019 3:28 PM > To: Jerin Jacob Kollanukkaran ; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH 1/2] eventdev: check timer adapter status before start

2019-03-25 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Saturday, March 16, 2019 3:28 PM > To: Jerin Jacob Kollanukkaran ; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-20 Thread Carrillo, Erik G
Hi Robert, Thanks for the review and suggestions. I’m out of the office on bonding leave for the next few weeks, but I’ll update the patch to address your points below when I return. Thanks, Erik > On Mar 20, 2019, at 8:53 AM, Sanford, Robert wrote: > > Hi Erik, > > I have a few questions

Re: [dpdk-dev] [PATCH v3 3/3] doc: add notes about eventdev producer consumer dependency

2019-03-13 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Tuesday, March 12, 2019 3:41 PM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > ; Rao, Nikhil ; Carrillo, > Erik G ; Gujjar, Abhinandan S > ; Mcnamara, John

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 0/2] Timer library changes

2019-03-06 Thread Carrillo, Erik G
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, March 5, 2019 4:59 PM > To: Carrillo, Erik G > Cc: techbo...@dpdk.org; rsanf...@akamai.com; dev@dpdk.org > Subject: Re: [dpdk-techboard] [dpdk-dev] [PATCH v3 0/2] Timer library &g

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2019-03-06 Thread Carrillo, Erik G
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, March 5, 2019 8:39 PM > To: Carrillo, Erik G ; rsanf...@akamai.com > Cc: dev@dpdk.org; techbo...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 0/2] Timer library changes > > Hi Erik, > > Apolog

Re: [dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency

2019-03-05 Thread Carrillo, Erik G
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Tuesday, March 5, 2019 9:16 AM > To: Pavan Nikhilesh Bhagavatula > Cc: Mcnamara, John ; Rao, Nikhil > ; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org > Subject: R

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2019-03-05 Thread Carrillo, Erik G
Hi all, I'd like to bring this patch proposal up again and see if I can get any more feedback from the maintainer or others. I need to update the map file to reflect the next release, so I'll add those changes in if any other modifications are suggested. Thanks, Erik ML: https://mails.dpdk.o

Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-19 Thread Carrillo, Erik G
> > > However, if a timer expires quickly enough, there exists the > > > following race condition that causes the timer_manage() routine to > > > misinterpret a timer in CONFIG state, resulting in lost timers: > > > > > > - Thread A: > > > - starts a timer with rte_timer_reset() > > > - the tim

Re: [dpdk-dev] [EXT] [PATCH v4 0/1] New software event timer adapter

2018-12-18 Thread Carrillo, Erik G
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Tuesday, December 18, 2018 2:12 PM > To: Jerin Jacob Kollanukkaran ; Carrillo, Erik G > > Cc: rsanf...@akamai.com; mattias.ronnb...@ericsson.com; > pbhagavat...@caviumnetwo

Re: [dpdk-dev] [PATCH v3 1/1] eventdev: add new software event timer adapter

2018-12-14 Thread Carrillo, Erik G
> > lib/librte_eventdev/rte_event_timer_adapter.c | 688 +++-- > - > > 1 file changed, 276 insertions(+), 412 deletions(-) > > > > diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c > > b/lib/librte_eventdev/rte_event_timer_adapter.c > > index 79070d4..029a45a 100644

Re: [dpdk-dev] [PATCH v2 1/1] eventdev: add new software event timer adapter

2018-12-10 Thread Carrillo, Erik G
Hi Mattias, Thanks for the review. Responses in-line: > -Original Message- > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Sunday, December 9, 2018 1:17 PM > To: Carrillo, Erik G ; > jerin.ja...@caviumnetworks.com > Cc: pbhagavat...@caviumn

Re: [dpdk-dev] [PATCH v2 1/2] timer: allow timer management in shared memory

2018-12-07 Thread Carrillo, Erik G
Hi Stephen, Thanks for the review. Some responses in-line: > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, December 7, 2018 12:10 PM > To: Carrillo, Erik G > Cc: rsanf...@akamai.com; jerin.ja...@caviumnetworks.c

Re: [dpdk-dev] [PATCH 0/3] new software event timer adapter

2018-11-30 Thread Carrillo, Erik G
Hi Pavan, Thanks for the feedback. Response inline: > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Friday, November 30, 2018 1:26 AM > To: Carrillo, Erik G ; Jacob, Jerin > ; rsanf...@akamai.com > Cc: step...@netwo

Re: [dpdk-dev] [PATCH] eventdev: fix resetting software timer

2018-05-22 Thread Carrillo, Erik G
> -Original Message- > From: Dan Gora [mailto:dan.g...@gmail.com] On Behalf Of Dan Gora > Sent: Monday, May 21, 2018 7:14 PM > To: Carrillo, Erik G ; Jerin Jacob > > Cc: dev@dpdk.org; Dan Gora > Subject: [PATCH] eventdev: fix resetting software timer

Re: [dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs

2018-05-09 Thread Carrillo, Erik G
> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, May 9, 2018 10:19 AM > To: Carrillo, Erik G > Cc: jerin.ja...@caviumnetworks.com; Vangati, Narender > ; Eads, Gage ; > dev@dpdk.org > Subject: RE: [PATCH v1 1/1] service: Add service lcore attr A

Re: [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5

2018-05-07 Thread Carrillo, Erik G
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, May 4, 2018 11:55 PM > To: Carrillo, Erik G > Cc: jerin.ja...@caviumnetworks.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5 &

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Carrillo, Erik G
Great, thanks Thomas. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 26, 2018 9:55 AM > To: Carrillo, Erik G > Cc: Burakov, Anatoly ; dev@dpdk.org; Neil > Horman ; Mcnamara, John > ; Kovacevic, Marko > ; Robe

  1   2   >