rs = atoi(pair->value);
> > - if (qpairs < 1 ||
> > - qpairs > RTE_PMD_AF_PACKET_MAX_RINGS) {
> > + if (qpairs < 1) {
> > PMD_LOG(ERR,
> >
name);
> @@ -1019,6 +1028,8 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev)
> rte_free(internals->tx_queue[q].rd);
> }
> free(internals->if_name);
> + rte_free(internals->rx_queue);
> + rte_free(internals->tx_queue);
>
> rte_eth_dev_release_port(eth_dev);
>
> --
> 2.20.1
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
commit fixes the issue by calling munmap
> from rte_pmd_af_packet_remove().
>
> Bugzilla ID: 339
> Cc: sta...@dpdk.org
>
> Signed-off-by: Abhishek Sachan
> Reviewed-by: John W. Linville
Confirmed...
Reviewed-by: John W. Linville
John
--
John W. LinvilleS
On Tue, Dec 13, 2016 at 02:28:34AM +0100, Michał Mirosław wrote:
>
> Signed-off-by: Michał Mirosław
Acked-by: John W. Linville
> ---
> drivers/net/af_packet/rte_eth_af_packet.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/
On Tue, Dec 13, 2016 at 02:28:34AM +0100, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław
Acked-by: John W. Linville
> ---
> drivers/net/af_packet/rte_eth_af_packet.c | 20 +++-
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/dri
Some(?) compilers will treat the unmarked constant 1 as a 32-bit
integer, but the shift operation is in a loop that could run up to
63 times -- undefined behavior!
Coverity issue: 127546
Fixes: 778b759ba10e ("net/bnxt: add MAC address")
Signed-off-by: John W. Linville
---
v2: fix-up
Coverity issue: 127556
Fixes: 440499cf5376 ("net/i40e: support floating VEB")
Signed-off-by: John W. Linville
Acked-by: Ferruh Yigit
---
v2: fix-up changelog entries based-on comments from Ferruh Yigit
drivers/net/i40e/i40e_ethdev.c | 4 +++-
1 file changed, 3 insertions(+),
Otherwise, the inherent cast when multiplying entry_length by max_vnics
in the call to rte_memzone_reserve could promote max_vnics to a signed
value, causing hilarity to ensue...
Coverity issue: 127557
Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs")
Signed-off-
Use sizeof dest rather than sizeof src for limiting copy length,
and replace strncpy with snprintf to ensure NULL termination.
Coverity issue: 127795
Fixes: 372c1af5ed8f ("net/ena: add dedicated memory area for extra device info")
Signed-off-by: John W. Linville
---
v2: fix-up changel
Today I attempted to exercise my brain between meetings by handling
a few bugs identified by Coverity.
All of the fixes are simple and (hopefully) obvious. They are
compile-tested only.
v2: fix-up changelog entries based-on comments from Ferruh Yigit
John
--
John W. Linville
Some(?) compilers will treat the unmarked constant 1 as a 32-bit
integer, but the shift operation is in a loop that could run up to
63 times -- undefined behavior!
Coverity: 127546
Signed-off-by: John W. Linville
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1
Coverity: 127556
Signed-off-by: John W. Linville
---
drivers/net/i40e/i40e_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index b04c833b2e04..d1f0f762b04c 100644
--- a/drivers/net/i40e/i40e_ethdev.c
Otherwise, the inherent cast when multiplying entry_length by max_vnics
in the call to rte_memzone_reserve could promote max_vnics to a signed
value, causing hilarity to ensue...
Coverity: 127557
Signed-off-by: John W. Linville
---
drivers/net/bnxt/bnxt_vnic.c | 2 +-
1 file changed, 1
Use sizeof dest rather than sizeof src for limiting copy length,
and replace strncpy with snprintf to ensure NULL termination.
Coverity: 127795
Signed-off-by: John W. Linville
---
drivers/net/ena/ena_ethdev.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a
Today I attempted to exercise my brain between meetings by handling
a few bugs identified by Coverity.
All of the fixes are simple and (hopefully) obvious. They are
compile-tested only.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com
On Thu, May 26, 2016 at 03:47:59PM +0100, Ferruh Yigit wrote:
> On 5/25/2016 10:03 PM, Rich Lane wrote:
> > Signed-off-by: Rich Lane
>
> Reviewed-by: Ferruh Yigit
Acked-by: John W. Linville
--
John W. LinvilleSomeday the world will need a hero, and
d.
Long story, short -- I think you can remove the comment and add the
static modifier and everything will be fine.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Fri, Oct 30, 2015 at 03:08:50PM +, Bernard Iremonger wrote:
> Signed-off-by: Bernard Iremonger
> Acked-by: Bruce Richardson
Acked-by: John W. Linville
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com
On Fri, Oct 30, 2015 at 03:08:42PM +, Bernard Iremonger wrote:
> initialise dev_flags, driver, kdrv, drv_name and numa_node fields in eth_dev
> data.
>
> Signed-off-by: Bernard Iremonger
> Acked-by: Bruce Richardson
Acked-by: John W. Linville
--
John W. Linville
On Fri, Aug 28, 2015 at 08:15:47AM +, Iremonger, Bernard wrote:
> Hi John,
>
> > -Original Message-
> > From: John W. Linville [mailto:linville at tuxdriver.com]
> > Sent: Thursday, August 27, 2015 6:44 PM
> > To: Iremonger, Bernard
> > Cc: dev at
Coverity CID # 13200
If sendto fails, the packets will not get transmitted. Return 0 as
the number of packets transmitted.
Signed-off-by: John W. Linville
---
drivers/net/af_packet/rte_eth_af_packet.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/af_packet
brte_ether/rte_ethdev.c | 34 ---
> lib/librte_ether/rte_ethdev.h | 10 ++-
> 8 files changed, 83 insertions(+), 128 deletions(-)
>
> --
> 1.9.1
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
e can
refactor the error exit to avoid the issue entirely...
Signed-off-by: John W. Linville
---
drivers/net/af_packet/rte_eth_af_packet.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/driver
uot;.
> I know I'm not alone in that thinking.
GitHub -- the SourceForge of the 21st century!
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Tue, May 05, 2015 at 06:30:48PM +, Wiles, Keith wrote:
>
> Sent from my iPhone
>
> > On May 5, 2015, at 10:58 AM, John W. Linville
> > wrote:
> >
> >> On Tue, May 05, 2015 at 04:43:08PM +, Wiles, Keith wrote:
> >>
> >> Plea
many of those
Go, Ruby, Python, and Swift developers are going to be contributing to
DPDK and all those future NFV projects? And how many significant,
existing DPDK contributors (like Neil) are you isolating in the
process? Do you even care?
Old-school IBM had the right motto -- THINK.
Jo
fine exit point;
> > >
> > > Change in v5:
> > > - Initialize qsockfd with -1;
> > >
> > > Change in v4:
> > > - Check sockfd in internals->rx_queue against 0;
> > >
> > > Change in v3:
> > > - Also
This patch adds finalization code to free resources allocated by
the PMD. This is based on earlier patches for other PMDs by Tetsuya
Mukawa , with corrections related to data->name.
Signed-off-by: John W. Linville
Cc: Tetsuya Mukawa
---
lib/librte_pmd_af_packet/rte_eth_af_packet.c |
rom_packet(name, &sockfd, numa_node, kvlist);
close(sockfd); /* no longer needed */
- if (ret < 0)
- return -1;
-
- return 0;
+exit:
+ rte_kvargs_free(kvlist);
+ return ret;
}
static struct rte_driver pmd_af_packet_drv = {
Does this seem OK to you?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
struct pkt_rx_queue *rx_queue;
> > struct pkt_tx_queue *tx_queue;
> > int rc, qsockfd, tpver, discard;
> > unsigned int i, q, rdsize;
> > int fanout_arg __rte_unused, bypass __rte_unused;
> >
> > + *internals = NULL;
> > +
> >
Signed-off-by: John W. Linville
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1f7d04a9ec2b..5fccdbb1618c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -174,6 +174,7 @@ F: examples/kni/
F: doc/guides/sample_app_ug/kernel_nic_interface.rst
/librte_pmd_af_packet/rte_eth_af_packet.c | 7 +++
> 1 file changed, 7 insertions(+)
Acked-by: John W. Linville
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote:
> Hi John,
>
> 2014-12-04 16:42, John W. Linville:
> > This allows the PMD to compile with kernels that don't support the
> > options in question. The "#if defined(...)" lines are a bit ugly,
&g
This allows the PMD to compile with kernels that don't support the
options in question. The "#if defined(...)" lines are a bit ugly,
but I don't know of any better way to accomplish the task.
Signed-off-by: John W. Linville
---
lib/librte_pmd_af_packet/rte_
P frame count set by "framecnt" (optional, default: 512)
Signed-off-by: John W. Linville
---
This PMD is intended to provide a means for using DPDK on a broad
range of hardware without hardware-specific PMDs and (hopefully)
with better performance than what PCAP offers in Linux. This mig
And I'll be glad to help
> > > >
> > > > Do you have time in coming days to rebase and rename this PMD for
> > > > inclusion
> > > > in 1.8.0 release?
> >
> > Do you think a sub-tree with pull request model would help you for
>
10 PM
> > > To: Zhou, Danny
> > > Cc: John W. Linville; dev at dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for
> > > AF_PACKET-based virtual devices
> > >
> > > On Fri, Sep 12, 2014 at 08:35:47PM +
On Mon, Sep 15, 2014 at 11:09:46AM -0400, Neil Horman wrote:
> On Fri, Sep 12, 2014 at 08:35:47PM +, Zhou, Danny wrote:
> > > -Original Message-
> > > From: John W. Linville [mailto:linville at tuxdriver.com]
> > > Sent: Saturday, September 13, 2014
t; From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John W. Linville
> > Sent: Saturday, September 13, 2014 2:05 AM
> > To: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for
> > AF_PACKET-based virtual devices
> >
> > Pi
Ping? Are there objections to this patch from mid-July?
John
On Mon, Jul 14, 2014 at 02:24:50PM -0400, John W. Linville wrote:
> This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> socket. This implementation uses mmap'ed ring buffers to limit copying
> a
On Thu, Jul 31, 2014 at 01:20:42PM -0700, Bruce Richardson wrote:
> On Thu, Jul 31, 2014 at 03:58:30PM -0400, John W. Linville wrote:
> > On Thu, Jul 31, 2014 at 11:36:32AM -0700, Bruce Richardson wrote:
> >
> > > With regards to the general approach for runti
that. It probably
is possible, but I imagine that it would provoke a lot of debate
and consternation in FESCO...
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Tue, Jul 15, 2014 at 11:27:45PM +0200, Thomas Monjalon wrote:
> 2014-07-14 09:46, John W. Linville:
> > On Sat, Jul 12, 2014 at 12:34:46AM +0200, Thomas Monjalon wrote:
> > > 2014-07-11 13:40, John W. Linville:
> > > > Is there an example of code in DPDK
On Tue, Jul 15, 2014 at 03:40:56PM +, Zhou, Danny wrote:
>
> > -Original Message-
> > From: John W. Linville [mailto:linville at tuxdriver.com]
> > Sent: Tuesday, July 15, 2014 10:01 PM
> > To: Neil Horman
> > Cc: Zhou, Danny; dev at dpdk.org
>
management to work directly
out of the mmap'ed AF_PACKET buffers. But at this point I don't
have enough knowledge of DPDK internals to know if that is at all
reasonable...
John
P.S. Danny, have you run any performance tests on the PCAP driver?
--
John W. LinvilleSo
P frame count set by "framecnt" (optional, default: 512)
Signed-off-by: John W. Linville
---
This PMD is intended to provide a means for using DPDK on a broad
range of hardware without hardware-specific PMDs and (hopefully)
with better performance than what PCAP offers in Linux. This might
be
ifr.ifr_name[ifnamelen]='\0';
OK. FWIW, at least the first two are slightly changed from what was
copied from the PCAP driver. The other probably was a cut-n-paste
error from another source.
I'll post a V2 shortly...
John
--
John W. LinvilleSomeday the world wil
On Mon, Jul 14, 2014 at 09:48:33AM -0400, John W. Linville wrote:
> On Fri, Jul 11, 2014 at 11:51:08PM +0100, Bruce Richardson wrote:
> > On Thu, Jul 10, 2014 at 04:32:49PM -0400, John W. Linville wrote:
> > > This is a Linux-specific virtual PMD driver backed by an AF_PACKET
&
On Fri, Jul 11, 2014 at 11:51:08PM +0100, Bruce Richardson wrote:
> On Thu, Jul 10, 2014 at 04:32:49PM -0400, John W. Linville wrote:
> > This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> > socket. This implementation uses mmap'ed ring buffers to limit
On Sat, Jul 12, 2014 at 12:34:46AM +0200, Thomas Monjalon wrote:
> 2014-07-11 13:40, John W. Linville:
> > Is there an example of code in DPDK that requires specific kernel
> > versions? What is the preferred method for coding such dependencies?
>
> No there is no userspace
l
the queues? If not, you probably should use the qpairs option to
limit the number of queues created by the eth_packet PMD.
John
>
> > -----Original Message-
> > From: John W. Linville [mailto:linville at tuxdriver.com]
> > Sent: Saturday, July 12, 2014 2:47 AM
> > To
et0,iface=p786p1
> --vdev=eth_packet1,iface=p786p2 -- -p 0x3
>
> > -Original Message-
> > From: Shaw, Jeffrey B
> > Sent: Saturday, July 12, 2014 4:32 AM
> > To: Zhou, Danny; John W. Linville
> > Cc: dev at dpdk.org
> > Subject: RE: [dpdk-dev] [
e option
> like "--vdev=eth_packet0,iface=..."? Say "iface=eth0,eth1,eth2...", tried but
> it doesn't work.
>
> > -Original Message-
> > From: Zhou, Danny
> > Sent: Saturday, July 12, 2014 2:01 AM
> > To: 'John
nce it could achieve.
>
> > -Original Message-
> > From: John W. Linville [mailto:linville at tuxdriver.com]
> > Sent: Saturday, July 12, 2014 1:41 AM
> > To: Zhou, Danny
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: ad
On Fri, Jul 11, 2014 at 05:38:17PM +, Richardson, Bruce wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Friday, July 11, 2014 9:48 AM
> > To: John W. Linville
> > Cc: dev at dpdk.org
>
3ff1
v3.14-rc1~94^2~564
Is there an example of code in DPDK that requires specific kernel
versions? What is the preferred method for coding such dependencies?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Fri, Jul 11, 2014 at 03:29:17PM +, Venkatesan, Venky wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John W. Linville
> > Sent: Friday, July 11, 2014 7:49 AM
> > To: Stephen Hemminger
> > Cc: dev at dpdk.
On Fri, Jul 11, 2014 at 05:04:04PM +0200, Thomas Monjalon wrote:
> 2014-07-11 10:51, John W. Linville:
> > On Fri, Jul 11, 2014 at 03:26:39PM +0200, Thomas Monjalon wrote:
> > > 2014-07-10 16:32, John W. Linville:
> > > > This is a Linux-specific virtual PMD
On Fri, Jul 11, 2014 at 03:26:39PM +0200, Thomas Monjalon wrote:
> 2014-07-10 16:32, John W. Linville:
> > This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> > socket. This implementation uses mmap'ed ring buffers to limit copying
> > and use
On Fri, Jul 11, 2014 at 06:11:47AM -0700, Stephen Hemminger wrote:
> On Thu, 10 Jul 2014 16:32:49 -0400
> "John W. Linville" wrote:
>
> > This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> > socket. This implementation uses mmap'ed ring b
P frame count set by "framecnt" (optional, default: 512)
Signed-off-by: John W. Linville
---
This PMD is intended to provide a means for using DPDK on a broad
range of hardware without hardware-specific PMDs and (hopefully)
with better performance than what PCAP offers in Linux. This might
be
On Fri, Jun 06, 2014 at 04:30:50PM -0400, Neil Horman wrote:
> On Fri, Jun 06, 2014 at 03:25:54PM -0400, John W. Linville wrote:
> > This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> > socket. The current implementation uses mmap'ed ring buffers to
> &
tself. If
> you have some suggestions as to how consistency can be better achieved
> as the community grows and develops that would be great.
Something just like what you said above added to a LICENSE file in
the root directory of the project source would go a long way towards
clarifying the licensing issues for the distributions that may want
to package DPDK.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Fri, Jun 06, 2014 at 12:47:48PM -0700, Chris Wright wrote:
> * John W. Linville (linville at tuxdriver.com) wrote:
> > This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> > socket. The current implementation uses mmap'ed ring buffers to
> > lim
ff-by: John W. Linville
---
I've been toying with this for a while without a lot of progress.
I was about to post the original RFC patch just as the PMD
initialization flows got rewritten. I set this down while that was
settling-out, and only just recently got back to it.
Anyway, I figure it is
led at initialization that registers a driver
> structure.
>
> With the second, we're tempted to check what this macro does...
Which you will do once, and then forever be thankful that ever after
you will only have to read the simple macro rather than all that
nasty boilerplate and __attribute__ gorp...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
break;\
> > + };\
>
> Are you sure this switch is needed?
> You are removing it in patch 7.
>
> If someone else think this macro is a good idea, or not, speak now :)
I don't understand your objection to it? It makes for a nice clean
declara
On Mon, Apr 14, 2014 at 03:45:31PM +0200, Thomas Monjalon wrote:
> Hi John,
>
> 2014-04-14 09:20, John W. Linville:
> > On Sat, Apr 12, 2014 at 08:05:22AM +0200, Thomas Monjalon wrote:
> > > 11/04/2014 20:08, Richardson, Bruce :
> > > > The ring PMD is proba
t of having an abstraction that looks like
a hardware device is so that applications can use either hardware
or that abstraction without having to know the difference. Forcing
applications to be vdev-aware defeats the whole purpose of wrapping
those constructs inside a PMD in the first place.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
On Fri, Apr 11, 2014 at 03:23:27PM +0200, Thomas Monjalon wrote:
> Hi John,
>
> 2014-04-10 10:41, John W. Linville:
> > These PMDs were being initialized by the EAL layer, but many apps were
> > relying on the return value of rte_pmd_init_all to indicate that
> &g
.
Signed-off-by: John W. Linville
---
lib/librte_eal/bsdapp/eal/eal.c| 3 ---
lib/librte_eal/common/eal_common_nonpci_devs.c | 2 +-
lib/librte_eal/common/include/eal_private.h| 7 ---
lib/librte_eal/common/include/rte_common.h | 7 +++
lib/librte_eal/linuxapp/eal
71 matches
Mail list logo
