[dpdk-dev] [PATCH] af_packet: add byte counters

2016-05-26 Thread John W. Linville
On Thu, May 26, 2016 at 03:47:59PM +0100, Ferruh Yigit wrote: > On 5/25/2016 10:03 PM, Rich Lane wrote: > > Signed-off-by: Rich Lane > > Reviewed-by: Ferruh Yigit Acked-by: John W. Linville -- John W. LinvilleSomeday the world will need a hero, a

[dpdk-dev] [PATCH v2] af_packet: make the device detachable

2016-02-10 Thread John W. Linville
. Long story, short -- I think you can remove the comment and add the static modifier and everything will be fine. John -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] [PATCH v7 25/28] af_packet: remove pci device

2015-10-30 Thread John W. Linville
On Fri, Oct 30, 2015 at 03:08:50PM +, Bernard Iremonger wrote: > Signed-off-by: Bernard Iremonger > Acked-by: Bruce Richardson Acked-by: John W. Linville -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com

[dpdk-dev] [PATCH v7 17/28] af_packet: copy device info to eth_dev data

2015-10-30 Thread John W. Linville
On Fri, Oct 30, 2015 at 03:08:42PM +, Bernard Iremonger wrote: > initialise dev_flags, driver, kdrv, drv_name and numa_node fields in eth_dev > data. > > Signed-off-by: Bernard Iremonger > Acked-by: Bruce Richardson Acked-by: John W. Linville -- John W. Linville

[dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs

2015-08-28 Thread John W. Linville
On Fri, Aug 28, 2015 at 08:15:47AM +, Iremonger, Bernard wrote: > Hi John, > > > -Original Message- > > From: John W. Linville [mailto:linville at tuxdriver.com] > > Sent: Thursday, August 27, 2015 6:44 PM > > To: Iremonger, Bernard > > Cc: dev at

[dpdk-dev] [PATCH] rte_eth_af_packet: check return value from sendto call

2015-08-27 Thread John W. Linville
Coverity CID # 13200 If sendto fails, the packets will not get transmitted. Return 0 as the number of packets transmitted. Signed-off-by: John W. Linville --- drivers/net/af_packet/rte_eth_af_packet.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/af_packet

[dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs

2015-08-27 Thread John W. Linville
| 34 --- > lib/librte_ether/rte_ethdev.h | 10 ++- > 8 files changed, 83 insertions(+), 128 deletions(-) > > -- > 1.9.1 > > -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] GitHub sandbox for the DPDK community

2015-05-07 Thread John W. Linville
uot;. > I know I'm not alone in that thinking. GitHub -- the SourceForge of the 21st century! -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] GitHub sandbox for the DPDK community

2015-05-05 Thread John W. Linville
On Tue, May 05, 2015 at 06:30:48PM +, Wiles, Keith wrote: > > Sent from my iPhone > > > On May 5, 2015, at 10:58 AM, John W. Linville > > wrote: > > > >> On Tue, May 05, 2015 at 04:43:08PM +, Wiles, Keith wrote: > >> > >>

[dpdk-dev] GitHub sandbox for the DPDK community

2015-05-05 Thread John W. Linville
uby, Python, and Swift developers are going to be contributing to DPDK and all those future NFV projects? And how many significant, existing DPDK contributors (like Neil) are you isolating in the process? Do you even care? Old-school IBM had the right motto -- THINK. John -- John W. Linvi

[dpdk-dev] [PATCH v7] af_packet: Fix some klocwork errors

2015-03-12 Thread John W. Linville
point; > > > > > > Change in v5: > > > - Initialize qsockfd with -1; > > > > > > Change in v4: > > > - Check sockfd in internals->rx_queue against 0; > > > > > > Change in v3: > > > - Also close sock

[dpdk-dev] [RFC] af_packet: support port hotplug

2015-03-10 Thread John W. Linville
This patch adds finalization code to free resources allocated by the PMD. This is based on earlier patches for other PMDs by Tetsuya Mukawa , with corrections related to data->name. Signed-off-by: John W. Linville Cc: Tetsuya Mukawa --- lib/librte_pmd_af_packet/rte_eth_af_packet.c |

[dpdk-dev] [PATCH v5] af_packet: Fix some klocwork errors

2015-03-09 Thread John W. Linville
ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG, _packet_iface, ); if (ret < 0) - return -1; + goto exit; } ret = rte_eth_from_packet(name, , numa_node, kvlist);

[dpdk-dev] [PATCH] MAINTAINERS: claim responsibility for Linux AF_PACKET PMD

2015-01-23 Thread John W. Linville
Signed-off-by: John W. Linville --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f7d04a9ec2b..5fccdbb1618c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -174,6 +174,7 @@ F: examples/kni/ F: doc/guides/sample_app_ug/kernel_nic_interface.rst

[dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options

2014-12-05 Thread John W. Linville
On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote: > Hi John, > > 2014-12-04 16:42, John W. Linville: > > This allows the PMD to compile with kernels that don't support the > > options in question. The "#if defined(...)" lines are a bit ugly, > &g

[dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options

2014-12-04 Thread John W. Linville
This allows the PMD to compile with kernels that don't support the options in question. The "#if defined(...)" lines are a bit ugly, but I don't know of any better way to accomplish the task. Signed-off-by: John W. Linville --- lib/librte_pmd_af_packet/rte_eth_af_pac

[dpdk-dev] [PATCH v3] librte_pmd_af_packet: add PMD for AF_PACKET-based virtual devices

2014-11-17 Thread John W. Linville
me count set by "framecnt" (optional, default: 512) Signed-off-by: John W. Linville --- This PMD is intended to provide a means for using DPDK on a broad range of hardware without hardware-specific PMDs and (hopefully) with better performance than what PCAP offers in Linux. This might be

[dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-11-14 Thread John W. Linville
help > > > > > > > > Do you have time in coming days to rebase and rename this PMD for > > > > inclusion > > > > in 1.8.0 release? > > > > Do you think a sub-tree with pull request model would help you for > > maintenance of

[dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-09-15 Thread John W. Linville
10 PM > > > To: Zhou, Danny > > > Cc: John W. Linville; dev at dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for > > > AF_PACKET-based virtual devices > > > > > > On Fri, Sep 12, 2014 at 08:35:47PM +

[dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-09-15 Thread John W. Linville
On Mon, Sep 15, 2014 at 11:09:46AM -0400, Neil Horman wrote: > On Fri, Sep 12, 2014 at 08:35:47PM +, Zhou, Danny wrote: > > > -Original Message- > > > From: John W. Linville [mailto:linville at tuxdriver.com] > > > Sent: Saturday, September 13, 2014

[dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-09-12 Thread John W. Linville
; > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John W. Linville > > Sent: Saturday, September 13, 2014 2:05 AM > > To: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for > > AF_PACKET-based virtual devices > > > > Pi

[dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-09-12 Thread John W. Linville
Ping? Are there objections to this patch from mid-July? John On Mon, Jul 14, 2014 at 02:24:50PM -0400, John W. Linville wrote: > This is a Linux-specific virtual PMD driver backed by an AF_PACKET > socket. This implementation uses mmap'ed ring buffers to limit copying > and us

[dpdk-dev] [PATCH 0/2] dpdk: Allow for dynamic enablement of some isolated features

2014-07-31 Thread John W. Linville
On Thu, Jul 31, 2014 at 01:20:42PM -0700, Bruce Richardson wrote: > On Thu, Jul 31, 2014 at 03:58:30PM -0400, John W. Linville wrote: > > On Thu, Jul 31, 2014 at 11:36:32AM -0700, Bruce Richardson wrote: > > > > > With regards to the general approach for runti

[dpdk-dev] [PATCH 0/2] dpdk: Allow for dynamic enablement of some isolated features

2014-07-31 Thread John W. Linville
probably is possible, but I imagine that it would provoke a lot of debate and consternation in FESCO... -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-16 Thread John W. Linville
On Tue, Jul 15, 2014 at 11:27:45PM +0200, Thomas Monjalon wrote: > 2014-07-14 09:46, John W. Linville: > > On Sat, Jul 12, 2014 at 12:34:46AM +0200, Thomas Monjalon wrote: > > > 2014-07-11 13:40, John W. Linville: > > > > Is there an example of code in DPDK

[dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-14 Thread John W. Linville
me count set by "framecnt" (optional, default: 512) Signed-off-by: John W. Linville --- This PMD is intended to provide a means for using DPDK on a broad range of hardware without hardware-specific PMDs and (hopefully) with better performance than what PCAP offers in Linux. This might be usef

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-14 Thread John W. Linville
0'; OK. FWIW, at least the first two are slightly changed from what was copied from the PCAP driver. The other probably was a cut-n-paste error from another source. I'll post a V2 shortly... John -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdr

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-14 Thread John W. Linville
On Mon, Jul 14, 2014 at 09:48:33AM -0400, John W. Linville wrote: > On Fri, Jul 11, 2014 at 11:51:08PM +0100, Bruce Richardson wrote: > > On Thu, Jul 10, 2014 at 04:32:49PM -0400, John W. Linville wrote: > > > This is a Linux-specific virtual PMD driver backed by an AF_PACKET &

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-14 Thread John W. Linville
On Fri, Jul 11, 2014 at 11:51:08PM +0100, Bruce Richardson wrote: > On Thu, Jul 10, 2014 at 04:32:49PM -0400, John W. Linville wrote: > > This is a Linux-specific virtual PMD driver backed by an AF_PACKET > > socket. This implementation uses mmap'ed ring buffers to limit copyi

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-14 Thread John W. Linville
queues? If not, you probably should use the qpairs option to limit the number of queues created by the eth_packet PMD. John > > > -Original Message----- > > From: John W. Linville [mailto:linville at tuxdriver.com] > > Sent: Saturday, July 12, 2014 2:47 AM > > To: Zho

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
et0,iface=p786p1 > --vdev=eth_packet1,iface=p786p2 -- -p 0x3 > > > -Original Message- > > From: Shaw, Jeffrey B > > Sent: Saturday, July 12, 2014 4:32 AM > > To: Zhou, Danny; John W. Linville > > Cc: dev at dpdk.org > > Subject: RE: [dpdk-dev] [

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
ion > like "--vdev=eth_packet0,iface=..."? Say "iface=eth0,eth1,eth2...", tried but > it doesn't work. > > > -Original Message- > > From: Zhou, Danny > > Sent: Saturday, July 12, 2014 2:01 AM > > To: 'John W. Linville' &g

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
rmance it could achieve. > > > -Original Message- > > From: John W. Linville [mailto:linville at tuxdriver.com] > > Sent: Saturday, July 12, 2014 1:41 AM > > To: Zhou, Danny > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: ad

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
On Fri, Jul 11, 2014 at 05:38:17PM +, Richardson, Bruce wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Friday, July 11, 2014 9:48 AM > > To: John W. Linville > > Cc: dev at dpdk.org >

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
3ff1 v3.14-rc1~94^2~564 Is there an example of code in DPDK that requires specific kernel versions? What is the preferred method for coding such dependencies? John -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
On Fri, Jul 11, 2014 at 03:29:17PM +, Venkatesan, Venky wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John W. Linville > > Sent: Friday, July 11, 2014 7:49 AM > > To: Stephen Hemminger > > Cc: dev at dpdk.

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
On Fri, Jul 11, 2014 at 05:04:04PM +0200, Thomas Monjalon wrote: > 2014-07-11 10:51, John W. Linville: > > On Fri, Jul 11, 2014 at 03:26:39PM +0200, Thomas Monjalon wrote: > > > 2014-07-10 16:32, John W. Linville: > > > > This is a Linux-specific virtual PMD

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-11 Thread John W. Linville
On Fri, Jul 11, 2014 at 06:11:47AM -0700, Stephen Hemminger wrote: > On Thu, 10 Jul 2014 16:32:49 -0400 > "John W. Linville" wrote: > > > This is a Linux-specific virtual PMD driver backed by an AF_PACKET > > socket. This implementation uses mmap'ed ring buffer

[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-07-10 Thread John W. Linville
me count set by "framecnt" (optional, default: 512) Signed-off-by: John W. Linville --- This PMD is intended to provide a means for using DPDK on a broad range of hardware without hardware-specific PMDs and (hopefully) with better performance than what PCAP offers in Linux. This might be usef

[dpdk-dev] [RFC] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-06-06 Thread John W. Linville
On Fri, Jun 06, 2014 at 04:30:50PM -0400, Neil Horman wrote: > On Fri, Jun 06, 2014 at 03:25:54PM -0400, John W. Linville wrote: > > This is a Linux-specific virtual PMD driver backed by an AF_PACKET > > socket. The current implementation uses mmap'ed ring buffers to > > l

[dpdk-dev] Licensing consistency

2014-06-06 Thread John W. Linville
. If > you have some suggestions as to how consistency can be better achieved > as the community grows and develops that would be great. Something just like what you said above added to a LICENSE file in the root directory of the project source would go a long way towards clarifying the licensing issues for the distributions that may want to package DPDK. John -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] [RFC] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

2014-06-06 Thread John W. Linville
On Fri, Jun 06, 2014 at 12:47:48PM -0700, Chris Wright wrote: > * John W. Linville (linville at tuxdriver.com) wrote: > > This is a Linux-specific virtual PMD driver backed by an AF_PACKET > > socket. The current implementation uses mmap'ed ring buffers to > > limit co

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread John W. Linville
lization that registers a driver > structure. > > With the second, we're tempted to check what this macro does... Which you will do once, and then forever be thankful that ever after you will only have to read the simple macro rather than all that nasty boilerplate and __attribute__ gorp... John -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread John W. Linville
break;\ > > + };\ > > Are you sure this switch is needed? > You are removing it in patch 7. > > If someone else think this macro is a good idea, or not, speak now :) I don't understand your objection to it? It makes for a nice clean declaration, rat

[dpdk-dev] [PATCH v2 07/11 1/2] vdev: new registration API

2014-04-14 Thread John W. Linville
are device is so that applications can use either hardware or that abstraction without having to know the difference. Forcing applications to be vdev-aware defeats the whole purpose of wrapping those constructs inside a PMD in the first place. John -- John W. LinvilleSomeday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.

[dpdk-dev] [PATCH] rte_pmd_init_all: initialize non-PCI PMDs provided by EAL

2014-04-11 Thread John W. Linville
On Fri, Apr 11, 2014 at 03:23:27PM +0200, Thomas Monjalon wrote: > Hi John, > > 2014-04-10 10:41, John W. Linville: > > These PMDs were being initialized by the EAL layer, but many apps were > > relying on the return value of rte_pmd_init_all to indicate that > &g