Re: [dpdk-dev] [PATCH v1] doc: update abi version references

2020-10-26 Thread Kinsella, Ray
Good catch :-). On 23/10/2020 17:51, David Marchand wrote: > On Fri, Oct 23, 2020 at 6:11 PM Ray Kinsella wrote: >> >> Updated references to abi versions in the contributors guide. > > Thanks for looking at it. > > I would keep the dpdk release version aligned with updated ABI ver. > Caught 3 r

Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-29 Thread Kinsella, Ray
On 28/10/2020 15:22, Honnappa Nagarahalli wrote: > + Ray for ABI > > > >> >> On Wed, Oct 28, 2020 at 02:28:43PM +, Akhil Goyal wrote: >>> >>> Hi Konstantin, >>> >> Hi Tech board members, >> >> I have a doubt about the ABI breakage in below addition of field. >> Could you p

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotter first half

2020-10-29 Thread Kinsella, Ray
On 29/10/2020 09:27, Thomas Monjalon wrote: > The mempool pointer in the mbuf struct is moved > from the second to the first half. > It should increase performance on most systems having 64-byte cache line, > i.e. mbuf is split in two cache lines. > On such system, the first half (also called fi

Re: [dpdk-dev] [PATCH 14/15] mbuf: remove deprecated timestamp field

2020-10-29 Thread Kinsella, Ray
On 29/10/2020 09:27, Thomas Monjalon wrote: > As announced in the deprecation note, the field timestamp > is removed to allow giving more space to the dynamic fields. > The related offload flag PKT_RX_TIMESTAMP is also removed. > > Signed-off-by: Thomas Monjalon > --- > app/test/test_mbuf.c

Re: [dpdk-dev] [PATCH v7 0/4] devtools: abi breakage checks

2020-11-03 Thread Kinsella, Ray
Hi David, Came across an issue with this. Essentially what is happening is that an ABI dump file generated with a newer versions of libabigail is not guaranteed to be 100% compatible with a older versions. That then adds a wrinkle that we need may need to look at maintaining abi dump archives

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

2021-06-29 Thread Kinsella, Ray
On 29/06/2021 17:28, Tyler Retzlaff wrote: > On Tue, Jun 29, 2021 at 05:00:31PM +0100, Ray Kinsella wrote: >> Clarifying the ABI policy on the promotion of experimental APIS to stable. >> We have a fair number of APIs that have been experimental for more than >> 2 years. This policy ammendment i

Re: [dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum

2021-06-29 Thread Kinsella, Ray
Please mark [PATCH v2], and record changes under the --- Ray K > -Original Message- > From: Mohsin Kazmi > Sent: Tuesday 29 June 2021 18:07 > To: dev@dpdk.org > Cc: Kinsella, Ray ; Mohsin Kazmi > ; sta...@dpdk.org; Olivier Matz > ; Ananyev, Konstantin > ; Th

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

2021-07-01 Thread Kinsella, Ray
On 30/06/2021 20:56, Tyler Retzlaff wrote: > On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: >> >> >>>> +Promotion to stable >>>> +~~~ >>>> + >>>> +Ordinarily APIs marked as ``experimental`` will be

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

2021-07-01 Thread Kinsella, Ray
On 01/07/2021 16:09, Tyler Retzlaff wrote: > On Thu, Jul 01, 2021 at 11:19:27AM +0100, Kinsella, Ray wrote: >> >> >> On 30/06/2021 20:56, Tyler Retzlaff wrote: >>> On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: >>

Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-12 Thread Kinsella, Ray
; > Doherty, Declan ; ma...@nvidia.com; > g.si...@nxp.com; Zhang, Roy Fan ; > jianjay.z...@huawei.com; asoma...@amd.com; ruifeng.w...@arm.com; > Ananyev, Konstantin ; Nicolau, Radu > ; ajit.khapa...@broadcom.com; Nagadheeraj > Rottela ; Ankur Dwivedi > ; Power, Ciara ; Kinsella, > Ra

Re: [dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields

2021-10-12 Thread Kinsella, Ray
On 08/10/2021 21:45, Akhil Goyal wrote: > In struct rte_security_ipsec_sa_options, for every new option > added, there is an ABI breakage, to avoid, a reserved_opts > bitfield is added to for the remaining bits available in the > structure. > Now for every new sa option, these reserved_opts can

Re: [dpdk-dev] [PATCH v2 2/3] security: hide internal API

2021-10-12 Thread Kinsella, Ray
On 08/10/2021 21:45, Akhil Goyal wrote: > rte_security_dynfield_register() is an internal > API to be used by the driver, hence moving it to internal. > > Signed-off-by: Akhil Goyal > Acked-by: Konstantin Ananyev > --- > v2: no change > > lib/security/rte_security_driver.h | 2 +- > lib/sec

Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 07:59, Thomas Monjalon wrote: > 11/10/2021 18:58, Akhil Goyal: >>> 08/10/2021 22:45, Akhil Goyal: In struct rte_security_ipsec_sa_options, for every new option added, there is an ABI breakage, to avoid, a reserved_opts bitfield is added to for the remaining bits avai

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Kinsella, Ray
On 08/10/2021 21:45, Akhil Goyal wrote: > Remove *_LIST_END enumerators from asymmetric crypto > lib to avoid ABI breakage for every new addition in > enums. > > Signed-off-by: Akhil Goyal > --- > v2: no change > > app/test/test_cryptodev_asym.c | 4 ++-- > drivers/crypto/qat/qat_asym.c |

Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 10:26, Jerin Jacob wrote: > On Tue, Oct 12, 2021 at 2:40 PM Thomas Monjalon wrote: >> >> 12/10/2021 10:47, Jerin Jacob: >>> On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati >>> wrote: From: Jerin Jacob >> --- a/lib/eventdev/rte_event_eth_rx_adapter.h >> +++ b/lib

Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 08:28, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > --- Acked-by: Ray Kinsella

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 11:50, Anoob Joseph wrote: > Hi Ray, Akhil, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Akhil Goyal >> Sent: Tuesday, October 12, 2021 3:49 PM >> To: Kinsella, Ray ; dev@dpdk.org >>

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 15:18, Anoob Joseph wrote: > Hi Thomas, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Thomas Monjalon >> Sent: Tuesday, October 12, 2021 7:25 PM >> To: Kinsella, Ray ; Akhil Goyal ; >

Re: [dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields and flags

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 20:39, David Marchand wrote: > As stated in the API, dynamic field and flags should be created with no > additional flag (simply in the API for future changes). > > Fix the dynamic flag register helper which was not enforcing it and add > unit tests. > > Fixes: 4958ca3a443a ("mbu

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 08:04, Anoob Joseph wrote: > Hi Akhil, Ray, Thomas, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Thomas Monjalon >> Sent: Wednesday, October 13, 2021 12:32 PM >> To: Akhil Goyal ; dev@dpd

Re: [dpdk-dev] [PATCH v3 04/10] common/sfc_efx/base: add RECIRC ID match in action rules API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 01:24, Ivan Malov wrote: > Currently, there is an API for setting recirculation ID in > outer rules. Add an API to let action rules match on it. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > drivers/common/sfc_efx/base/efx.h | 13 ++ > driver

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 22:52, Thomas Monjalon wrote: > 12/10/2021 22:34, Dumitrescu, Cristian: >> From: Thomas Monjalon >>> 01/09/2021 14:20, Jasvinder Singh: These APIs were introduced in 18.05, therefore removing experimental tag to promote them to stable state. Signed-off-by: Jasv

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 21:34, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Singh, Jasvinder >> Sent: Wednesday, September 1, 2021 1:20 PM >> To: dev@dpdk.org >> Cc: Dumitrescu, Cristian ; m...@ashroe.eu; >> Zhang, Roy Fan >> Subject: [PATCH] pipeline: remove experimental tag

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-10-13 Thread Kinsella, Ray
On 01/09/2021 13:20, Jasvinder Singh wrote: > This API was introduced in 18.08, therefore removing > experimental tag to promote it to stable state. > > Signed-off-by: Jasvinder Singh > --- > drivers/net/softnic/rte_eth_softnic.h | 1 - > drivers/net/softnic/version.map | 7 +-- > 2

Re: [dpdk-dev] [PATCH] sched: remove experimental tag from the API

2021-10-13 Thread Kinsella, Ray
On 01/09/2021 13:19, Jasvinder Singh wrote: > This API was introduced in 18.05, therefore removing > experimental tag to promote it to stable state > > Signed-off-by: Jasvinder Singh > --- > lib/sched/rte_sched.h | 4 > lib/sched/version.map | 2 +- > 2 files changed, 1 insertion(+), 5 d

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 13:29, Gregory Etelson wrote: > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allow to > creat

Re: [dpdk-dev] [PATCH] memzone: enforce valid flags when reserving

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 20:39, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > --- > app/test/test_memzone.c | 24 >

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 10:40, Thomas Monjalon wrote: > 13/10/2021 10:51, Kinsella, Ray: >> >> On 12/10/2021 22:52, Thomas Monjalon wrote: >>> 12/10/2021 22:34, Dumitrescu, Cristian: >>>> From: Thomas Monjalon >>>>> 01/09/2021 14:20, Jasvinder Singh: &g

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 10:49, Thomas Monjalon wrote: > 13/10/2021 11:43, Kinsella, Ray: >> On 13/10/2021 10:40, Thomas Monjalon wrote: >>> 13/10/2021 10:51, Kinsella, Ray: >>>> On 12/10/2021 22:52, Thomas Monjalon wrote: >>>>> 12/10/2021 22:34, Dumit

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 12:11, Bruce Richardson wrote: > On Wed, Oct 13, 2021 at 11:02:02AM +0100, Kinsella, Ray wrote: >> >> >> On 13/10/2021 10:49, Thomas Monjalon wrote: >>> 13/10/2021 11:43, Kinsella, Ray: >>>> On 13/10/2021 10:40, Thomas Monjalon wr

Re: [dpdk-dev] [PATCH v3 08/18] eal: fix typos in comments

2021-10-20 Thread Kinsella, Ray
On 14/10/2021 22:56, Stephen Hemminger wrote: Minor spelling errors. Signed-off-by: Stephen Hemminger Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH v5 1/4] mempool: add event callbacks

2021-10-20 Thread Kinsella, Ray
On 15/10/2021 17:02, Dmitry Kozlyuk wrote: Data path performance can benefit if the PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes fr

Re: [dpdk-dev] [PATCH v5 3/4] common/mlx5: add mempool registration facilities

2021-10-20 Thread Kinsella, Ray
On 15/10/2021 17:02, Dmitry Kozlyuk wrote: Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own data

Re: [dpdk-dev] [PATCH v2 02/13] common/mlx5: support receive memory pool

2021-10-20 Thread Kinsella, Ray
On 16/10/2021 10:12, Xueming Li wrote: Adds DevX supports of PRM shared receive memory pool(RMP) object. RMP is used to support shared Rx queue. Multiple RQ could share same RMP. Memory buffers are supplied to RMP. This patch makes RMP RQ optional, created only if mlx5_devx_rq.rmp is set. Si

Re: [dpdk-dev] [PATCH] ip_frag: promote APIs to stable

2021-10-20 Thread Kinsella, Ray
On 18/10/2021 16:36, Konstantin Ananyev wrote: Promote rte_frag_table_del_expired_entries() function to stable. It was around for few years by now without any changes. Signed-off-by: Konstantin Ananyev --- lib/ip_frag/rte_ip_frag.h | 1 - lib/ip_frag/version.map | 7 +-- 2 files ch

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-10-20 Thread Kinsella, Ray
On 13/10/2021 13:12, Thomas Monjalon wrote: +Cc Cristian, the maintainer 10/09/2021 15:40, Kinsella, Ray: On 10/09/2021 08:36, David Marchand wrote: On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: On 09/09/2021 17:40, Rahul Shah wrote: rte_port_eventdev_reader_ops

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See https://github.com/pcapng/pcapng/ Signed-off-by: Stephen Hemminger Acked-by:

Re: [dpdk-dev] [PATCH v15 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the

Re: [dpdk-dev] [PATCH v15 05/12] bpf: add function to dump eBPF instructions

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meso

Re: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version numbe

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

2021-10-28 Thread Kinsella, Ray
On 28/10/2021 09:34, Thomas Monjalon wrote: The port ownership concept was introduced in ethdev in DPDK 18.02. Not sure it is used by applications except those using failsafe or netvsc. It can also be used by libraries or applications to sort out how ports are controlled. Hiding sub-ports con

Re: [dpdk-dev] [PATCH] ethdev: promote device removal check function as stable

2021-10-28 Thread Kinsella, Ray
On 28/10/2021 09:35, Thomas Monjalon wrote: The function rte_eth_dev_is_removed() was introduced in DPDK 18.02, and is integrated in error checks of ethdev library. It is promoted as stable ABI. Signed-off-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.h | 4 lib/ethdev/version.map

Re: [dpdk-dev] Doubt regarding DPDK hash Library implementation

2021-11-04 Thread Kinsella, Ray
I would guess it - I would say it is related to cache alignment. Assuming each entry is 8 bytes 😊 Ray K > -Original Message- > From: Thomas Monjalon > Sent: Thursday 4 November 2021 14:12 > To: Syam Prasad N Pearson > Cc: us...@dpdk.org; dev@dpdk.org; Wang, Yipeng1 > ; Gobriel, Sameh ;

Re: [dpdk-dev] [PATCH] devtools: script to track map symbols

2021-06-21 Thread Kinsella, Ray
> > pylint reports some things that should be fixed. Don't worry about the naming > style > and docstring but others should be addressed. [SNIP] Ah, rookie mistake, I ran checkpatch and thought that I was all good. I will sort it out thanks. Ray K

[dpdk-dev] Experimental symbols in security lib

2021-06-24 Thread Kinsella, Ray
Hi Declan and Goyal, The following security experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_security_get_userd

[dpdk-dev] Experimental symbols in net lib

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following net experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_net_make_rarp_packet * rte_net_s

[dpdk-dev] Experimental symbols in mbuf lib

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following mbuf experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mbuf_check * rte_mbuf_dynfield_

[dpdk-dev] Experimental symbols in vhost lib

2021-06-24 Thread Kinsella, Ray
Hi Maxime and Chenbo, The following vhost experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_vhost_driver_get_pro

[dpdk-dev] Experimental symbols in flow_classify lib

2021-06-24 Thread Kinsella, Ray
Hi Bernard, The following flow_classify experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_flow_classifier_create

[dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread Kinsella, Ray
Hi Anatoly & Thomas, The following eal experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mp_action_register * r

[dpdk-dev] Experimental symbols in port lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian The following port experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_port_eventdev_writer_nodrop_ops

[dpdk-dev] Experimental symbols in compressdev lib

2021-06-24 Thread Kinsella, Ray
Hi Fiona & Ashish, The following compressdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_compressdev_capabi

[dpdk-dev] Experimental symbols in sched lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian & Jasvinder, The following sched experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_sched_subport_pipe

[dpdk-dev] Experimental symbols in cryptodev lib

2021-06-24 Thread Kinsella, Ray
Hi Declan, The following cryptodev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_cryptodev_asym_capability_ge

[dpdk-dev] Experimental symbols in rib lib

2021-06-24 Thread Kinsella, Ray
Hi Vladimir The following rib experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_rib_create, * rte_rib_find_existin

[dpdk-dev] Experimental symbols in pipeline lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian, The following pipeline experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_port_in_action_create * rte_

[dpdk-dev] Experimental symbols in ip_frag

2021-06-24 Thread Kinsella, Ray
Hi Konstantin The following ip_frag experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_frag_table_del_expired_entri

[dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Kinsella, Ray
Hi Nicolas The following bbdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_bbdev_allocate * rte_bbdev_callba

[dpdk-dev] Experimental Symbols in ethdev lib

2021-06-24 Thread Kinsella, Ray
Hi Thomas, Ferruh and Andrew, The following ethdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mtr_capabili

[dpdk-dev] Experimental Symbols in kvargs

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following kvargs experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_kvargs_parse_delim * rte_kvargs_

[dpdk-dev] Experimental symbols in power lib

2021-06-24 Thread Kinsella, Ray
Hi David, The following power experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_empty_poll_detection * rte_power

[dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Kinsella, Ray
Hi Ferruh, The following kni experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_kni_update_link Ray K

[dpdk-dev] Experimental symbols in metrics lib

2021-06-24 Thread Kinsella, Ray
Hi Thomas, The following metrics experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_metrics_deinit Ray K

[dpdk-dev] Experimental symbols in fib lib

2021-06-24 Thread Kinsella, Ray
Hi Vladimir, The following fib experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_fib_add * rte_fib_create * rt

Re: [dpdk-dev] Experimental symbols in hash lib

2021-06-24 Thread Kinsella, Ray
+ dpdk dev (missed the dev list the first time, apologies). On 24/06/2021 11:41, Kinsella, Ray wrote: > Hi Yipeng, Sameh, Bruce and Vladimir, > > The following hash experimental symbols are present in both v21.05 and v19.11 > release. These symbols should be considered for promoti

Re: [dpdk-dev] Experimental symbols in security lib

2021-06-24 Thread Kinsella, Ray
(correcting Goyals address, apologies for the resend) On 24/06/2021 11:28, Kinsella, Ray wrote: > Hi Declan and Goyal, > > The following security experimental symbols are present in both v21.05 and > v19.11 release. These symbols should be considered for promotion to stable as &

Re: [dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread Kinsella, Ray
Good point, that one is very up to the lib maintainer to make that call. Ray K On 24/06/2021 13:14, David Marchand wrote: > On Thu, Jun 24, 2021 at 12:31 PM Kinsella, Ray wrote: >> >> Hi Anatoly & Thomas, >> >> The following eal experimental symbols are pr

Re: [dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Kinsella, Ray
Sounds more than reasonable, +1 from me. Ray K On 24/06/2021 14:24, Ferruh Yigit wrote: > On 6/24/2021 11:42 AM, Kinsella, Ray wrote: >> Hi Ferruh, >> >> The following kni experimental symbols are present in both v21.05 and v19.11 >> release. These symbols should be

Re: [dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Kinsella, Ray
at request was considered for 20.11. But this was deferred by the community > while waiting for other vendors who may be willing to contribute their own > PMDs. > Any specific concern with this not being on a tracked ABI? > > Thanks > Nic > > >> -----Original

Re: [dpdk-dev] Experimental symbols in compressdev lib

2021-06-25 Thread Kinsella, Ray
On 25/06/2021 08:49, David Marchand wrote: > On Thu, Jun 24, 2021 at 12:33 PM Kinsella, Ray wrote: >> >> Hi Fiona & Ashish, >> >> The following compressdev experimental symbols are present in both v21.05 >> and v19.11 release. These symbols should be cons

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-09-03 Thread Kinsella, Ray
On 01/09/2021 13:20, Jasvinder Singh wrote: > These APIs were introduced in 18.05, therefore removing > experimental tag to promote them to stable state. > > Signed-off-by: Jasvinder Singh > --- > lib/pipeline/rte_port_in_action.h | 10 -- > lib/pipeline/rte_table_action.h | 18

Re: [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API

2021-09-03 Thread Kinsella, Ray
On 03/09/2021 14:08, Harman Kalra wrote: > Remove experimental flag from rte_metrics_deinit(). > This API was introduced in 19.11 release. > > Signed-off-by: Harman Kalra > --- > lib/metrics/rte_metrics.h | 4 > lib/metrics/version.map | 2 +- > 2 files changed, 1 insertion(+), 5 delet

Re: [dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-09-03 Thread Kinsella, Ray
Hi David, On 01/09/2021 14:01, David Marchand wrote: > Hello Ray, > > On Tue, Aug 31, 2021 at 4:51 PM Ray Kinsella wrote: >> >> Use this script with the output of the DPDK symbol tool, to notify >> maintainers of expired symbols by email. You need to define the environment >> variable DPDK_GETM

Re: [dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-09-03 Thread Kinsella, Ray
On 01/09/2021 13:46, Aaron Conole wrote: > Ray Kinsella writes: > >> Use this script with the output of the DPDK symbol tool, to notify >> maintainers of expired symbols by email. You need to define the environment >> variable DPDK_GETMAINTAINER_PATH for this tool to work. >> >> Use terminal o

Re: [dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-09-03 Thread Kinsella, Ray
On 01/09/2021 14:01, David Marchand wrote: > Hello Ray, > > On Tue, Aug 31, 2021 at 4:51 PM Ray Kinsella wrote: >> >> Use this script with the output of the DPDK symbol tool, to notify >> maintainers of expired symbols by email. You need to define the environment >> variable DPDK_GETMAINTAINER

Re: [dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

2021-09-08 Thread Kinsella, Ray
On 06/09/2021 15:19, Andrew Rybchenko wrote: > On 9/6/21 4:02 PM, David Marchand wrote: >> This API saw no update since its introduction and will help applications >> like OVS ([1] and [2]) that currently look at rte_eth_devices[] to >> achieve the same. >> >> 1: https://github.com/openvswitch/o

Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable

2021-09-08 Thread Kinsella, Ray
On 07/09/2021 03:58, Chenbo Xia wrote: > As reported by symbol bot, APIs listed in this patch have been > experimental for more than two years. This patch promotes these > 18 APIs to stable. > > Signed-off-by: Chenbo Xia > --- > lib/vhost/rte_vhost.h| 13 - > lib/vhost/rte

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-08 Thread Kinsella, Ray
> > So there won't be symbol versioning but only new API, which means no > deprecation > notice is required, please update this patch's status accordingly. > > Thanks for keep working on the issue to find a better solution. > +1, good work

Re: [dpdk-dev] [RFC 04/15] eventdev: move inline APIs into separate structure

2021-09-08 Thread Kinsella, Ray
On 23/08/2021 20:40, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Move fastpath inline function pointers from rte_eventdev into a > separate structure accessed via a flat array. > The intension is to make rte_eventdev and related structures private > to avoid future API/ABI brea

Re: [dpdk-dev] [RFC 05/15] eventdev: add helper functions for new driver API

2021-09-08 Thread Kinsella, Ray
On 23/08/2021 20:40, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add helper functions and macros to help drivers to transition to new > fastpath interface. > > Signed-off-by: Pavan Nikhilesh > --- > lib/eventdev/eventdev_pmd.h | 396 > li

Re: [dpdk-dev] [RFC 13/15] eventdev: promote event vector API to stable

2021-09-08 Thread Kinsella, Ray
On 23/08/2021 20:40, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Promote event vector configuration APIs to stable. > > Signed-off-by: Pavan Nikhilesh > --- > lib/eventdev/rte_event_eth_rx_adapter.h | 2 -- > lib/eventdev/rte_eventdev.h | 1 - > lib/eventdev/vers

Re: [dpdk-dev] [RFC 15/15] eventdev: promote trace variables to stable

2021-09-08 Thread Kinsella, Ray
On 23/08/2021 20:40, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Promote rte_trace global variables to stable i.e. remove them > from experimental section of version map. Minor niggle - they are being made INTERNAL, not promoted to stable. > > Signed-off-by: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH 2/4] cryptodev: promote asym APIs to stable

2021-09-08 Thread Kinsella, Ray
Folks, On 07/09/2021 12:45, Akhil Goyal wrote: >>> Do you think all the asym APIs are not eligible for promoting it to stable >> APIs? >>> I haven't seen any changes for quite some time and we cannot have it >>> experimental Forever. >>> The APIs which you think are expected to change, we can leav

Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable

2021-09-09 Thread Kinsella, Ray
On 09/09/2021 03:13, Xia, Chenbo wrote: > Hi Kevin, > >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, September 8, 2021 8:01 PM >> To: Xia, Chenbo ; dev@dpdk.org; >> maxime.coque...@redhat.com >> Cc: Liu, Changpeng ; m...@ashroe.eu >> Subject: Re: [dpdk-dev] [PATCH] vh

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-09-10 Thread Kinsella, Ray
On 09/09/2021 17:40, Rahul Shah wrote: > rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, > rte_port_eventdev_writer_ops symbols promoted > > Signed-off-by: Rahul Shah > --- > lib/port/version.map | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > Hi Rahul,

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 08:36, David Marchand wrote: > On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: >> On 09/09/2021 17:40, Rahul Shah wrote: >>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, >>> rte_port_eventdev_writer_ops symbols promoted &

Re: [dpdk-dev] [PATCH v1 1/7] eal: promote IPC API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_eal.h | 24 > lib/eal/version.map | 14 ++ > 2 files changed

Re: [dpdk-dev] [PATCH v1 2/7] fbarray: promote API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_fbarray.h | 26 -- > lib/eal/version.map | 52 +--

Re: [dpdk-dev] [PATCH v1 3/7] eal: promote malloc API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_malloc.h | 10 -- > lib/eal/version.map | 20 ++-- > 2 files changed,

Re: [dpdk-dev] [PATCH v1 4/7] mem: promote memseg API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_memory.h | 17 - > lib/eal/version.map | 34 +-

Re: [dpdk-dev] [PATCH v1 5/7] mem: promote extmem API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH v1 6/7] mem: promote DMA mask API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_memory.h | 12 > lib/eal/version.map | 6 +++--- > 2 files changed, 3 insertions

Re: [dpdk-dev] [PATCH v1 7/7] eal: promote mcfg API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_eal_memconfig.h | 12 > lib/eal/version.map | 8 +++- > 2 files chang

Re: [dpdk-dev] [PATCH 1/8] bus/pci: add new memory resource access APIs

2021-09-13 Thread Kinsella, Ray
On 10/09/2021 03:23, Chenbo Xia wrote: > Some applications wants to access PCI memory resource. Currently > applications use struct rte_pci_device to access it. Since the > structure will be made internal later, this patch adds two APIs > for memory resource access. > > Signed-off-by: Chenbo Xi

Re: [dpdk-dev] [PATCH 8/8] bus/pci: remove ABIs in PCI bus

2021-09-13 Thread Kinsella, Ray
On 10/09/2021 03:24, Chenbo Xia wrote: > As announced in the deprecation note, most of ABIs in PCI bus are > removed in this patch. Only the function rte_pci_dump is still ABI > and experimental APIs are kept for future promotion. > > This patch creates a new file named pci_driver.h and moves m

Re: [dpdk-dev] [RFC 1/1] net/mlx5: set txq affinity in round-robin

2021-09-13 Thread Kinsella, Ray
On 10/09/2021 05:23, Rongwei Liu wrote: > Previously, we set txq affinity to 0 and let firmware > to perform round-robin when bonding. Firmware uses a > global counter to assign txq affinity to different > physical ports accord to remainder after division. > > There are three dis-advantages: >

Re: [dpdk-dev] [PATCH] efd: change data type of parameter

2021-09-14 Thread Kinsella, Ray
On 14/09/2021 08:10, David Marchand wrote: > On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara > wrote: >> >> rte_efd_create() function was using uint8_t for a socket bitmask, >> for one of its parameters. >> This limits the maximum of NUMA sockets to be 8. >> Changing to to uint64_t increases it t

Re: [dpdk-dev] [PATCH v14] eventdev: simplify Rx adapter event vector config

2021-09-15 Thread Kinsella, Ray
On 15/09/2021 14:15, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Include vector configuration into the structure > ``rte_event_eth_rx_adapter_queue_conf`` that is used to configure > Rx adapter ethernet device Rx queue parameters. > This simplifies event vector configuration as

Re: [PATCH v4 08/18] eal: fix typos in comments

2021-11-12 Thread Kinsella, Ray
On 12/11/2021 00:02, Stephen Hemminger wrote: Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte

Re: [dpdk-dev] [PATCH v2] doc: fix CI typo warnings

2021-11-26 Thread Kinsella, Ray
On 26/11/2021 13:34, David Marchand wrote: On Fri, Nov 26, 2021 at 2:18 PM David Marchand wrote: On Tue, Aug 10, 2021 at 4:36 PM Ray Kinsella wrote: Fix documentation typos that are generating spurious CI warnings. Cc: sta...@dpdk.org ^^^ Actually, no, dropped Cc. This patch o

  1   2   3   4   >