RE: [PATCH v8 2/3] ethdev: add VXLAN last reserved field

2024-06-11 Thread rongwei liu
BR Rongwei > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 11, 2024 22:53 > To: rongwei liu ; dev@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; Suanming Mou ; NBU- > Contact-Thomas Monjalon (EXTERNAL) > Cc: Dariusz Sosnowski ; Ama

[PATCH v8 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-07 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v8 2/3] ethdev: add VXLAN last reserved field

2024-06-07 Thread Rongwei Liu
Add "uint8_t last_rsvd" as union with origin rsvd1. Add RTE_FLOW_FIELD_VXLAN_LAST_RSVD into rte flow packet field. The new union is used by testpmd matching item VXLAN "last_rsvd" and modify target RTE_FLOW_FIELD_VXLAN_LAST_RSVD. Signed-off-by: Rongwei Liu Acked-by: Dariusz

[PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-07 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdl

[PATCH v8 0/3] support VXLAN last reserved byte modification

2024-06-07 Thread Rongwei Liu
atch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last reserved field net/mlx5: implement VXLAN last reserved modification app/test-pmd/cmdline_flow.c | 9 + doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5/mlx5_flow

RE: [PATCH v7 2/3] ethdev: add VXLAN last reserved field

2024-06-07 Thread rongwei liu
BR Rongwei > -Original Message- > From: Thomas Monjalon > Sent: Friday, June 7, 2024 21:26 > To: rongwei liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Dariusz Sosnowski ; > Aman Singh ; Yuying Zhang > ; Ferruh

[PATCH v7 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Rongwei Liu
Add "uint8_t last_rsvd" as union with origin rsvd1. Add RTE_FLOW_FIELD_VXLAN_LAST_RSVD into rte flow packet field. The new union is used by testpmd matching item VXLAN "last_rsvd" and modify target "vxlan_last_rsvd". Signed-off-by: Rongwei Liu Acked-by: Darius

[PATCH v7 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-05 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v7 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-05 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdl

[PATCH v7 0/3] support VXLAN last reserved byte modification

2024-06-05 Thread Rongwei Liu
v7: squash, add more commit logs. v6: add union into vxlan header. v5: change the field enumeration naming. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence

RE: [PATCH v6 2/4] net: add new union into VXLAN header

2024-06-05 Thread rongwei liu
BR Rongwei > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 5, 2024 18:42 > To: rongwei liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Subject: Re: [PATCH v6 2/4] net: add new union into VXLAN header

[PATCH v6 4/4] net/mlx5: implement VXLAN last reserved modification

2024-06-05 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v6 3/4] ethdev: add VXLAN last reserved field

2024-06-05 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff -

[PATCH v6 2/4] net: add new union into VXLAN header

2024-06-05 Thread Rongwei Liu
Add "uint8_t last_rsvd" as union with origin rsvd1. Signed-off-by: Rongwei Liu --- lib/net/rte_vxlan.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/net/rte_vxlan.h b/lib/net/rte_vxlan.h index 997fc784fc..57300fb442 100644 --- a/lib/net/rte_vxlan.h +++

[PATCH v6 1/4] app/testpmd: fix the testpmd field string sequence

2024-06-05 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdl

[PATCH v6 0/4] support VXLAN last reserved byte modification

2024-06-05 Thread Rongwei Liu
Support to modify VXLAN last reserved byte. v6: add union into vxlan header. v5: change the field enumeration naming. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (4): app/testpmd: fix the testpmd field string

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Wednesday, June 5, 2024 17:35 To: rongwei liu Cc: Dariusz Sosnowski ; dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re

[PATCH v5 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-05 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v5 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff -

[PATCH v5 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-05 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdl

[PATCH v5 0/3] support VXLAN last reserved byte modification

2024-06-05 Thread Rongwei Liu
Support to modify VXLAN last reserved byte. v5: change the field enumeration naming. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Wednesday, June 5, 2024 15:13 To: Dariusz Sosnowski ; rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-04 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Wednesday, June 5, 2024 2:37 To: rongwei liu ; Dariusz Sosnowski Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-04 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Tuesday, June 4, 2024 23:03 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re

[PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-04 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff -

[PATCH v4 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-04 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdl

[PATCH v4 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-04 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v4 0/3] support VXLAN rsvd1 modification

2024-06-04 Thread Rongwei Liu
Support to modify VXLAN the last byte reserved field. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last reserved field net/mlx5

Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification

2024-06-04 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Tuesday, June 4, 2024 20:19 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved

[PATCH v3 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-04 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v3 2/3] ethdev: add VXLAN last reserved field

2024-06-04 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff -

[PATCH v3 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-04 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdl

[PATCH v3 0/3] support VXLAN rsvd1 modification

2024-06-04 Thread Rongwei Liu
Support to modify VXLAN the last byte reserved field. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last reserved field net/mlx5: implement VXLAN last reserved modification app/test

Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field

2024-06-04 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Tuesday, June 4, 2024 19:59 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski ; Ferruh Yigit ; Andrew Rybchenko Subject: Re: [PATCH v2 2/4] ethdev: add

Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field

2024-06-04 Thread rongwei liu
Thanks BR Rongwei ____________ From: Rongwei Liu Sent: Monday, May 27, 2024 10:47 To: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: Dariusz Sosnowski ; Ferruh Yigit ; Andrew Rybchenko Subject: [PATCH v2 2/4] ethdev: add V

Re: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

2024-05-30 Thread rongwei liu
Hi @Dariusz Sosnowski<mailto:dsosnow...@nvidia.com> Can you comment on this patch? Thanks. BR Rongwei From: Rongwei Liu Sent: Monday, May 27, 2024 10:47 To: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; NBU-Contact-

Re: [PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command

2024-05-26 Thread rongwei liu
Hi BR Rongwei From: Dariusz Sosnowski Sent: Friday, May 24, 2024 23:53 To: rongwei liu ; dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: Aman Singh ; Yuying Zhang Subject: RE: [PATCH v1

[PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification

2024-05-26 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v2 2/4] ethdev: add VXLAN last reserved field

2024-05-26 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- lib/ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 6e8ab1d4c7..b807713cec 100644 --- a/lib/ethdev

[PATCH v2 3/4] app/testpmd: add VXLAN last reserved modification command

2024-05-26 Thread Rongwei Liu
Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index

[PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

2024-05-26 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 4 ++-- 1 file

[PATCH v2 0/4] support VXLAN rsvd1 modification

2024-05-26 Thread Rongwei Liu
Support to modify VXLAN the last byte reserved field. v2: patch split. Rongwei Liu (4): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last reserved field app/testpmd: add VXLAN last reserved modification command net/mlx5: implement VXLAN last reserved modification

[PATCH v1 3/3] net/mlx5: implement VXLAN last reserved modification

2024-05-23 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/

[PATCH v1 1/3] ethdev: add VXLAN last reserved field

2024-05-23 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- lib/ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 6e8ab1d4c7..b807713cec 100644 --- a/lib/ethdev

[PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command

2024-05-23 Thread Rongwei Liu
Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index

[PATCH v1 0/3] support VXLAN rsvd1 modification

2024-05-23 Thread Rongwei Liu
Support to modify VXLAN the last byte reserved field. Rongwei Liu (3): ethdev: add VXLAN last reserved field app/testpmd: add VXLAN last reserved modification command net/mlx5: implement VXLAN last reserved modification app/test-pmd/cmdline_flow.c | 4 ++-- doc/guides/nics/mlx5.rst

[PATCH v1] net/mlx5/hws: match VXLAN all fields

2024-05-13 Thread Rongwei Liu
Support VxLAN all fields support. To match GBP or GPE extension, the user needs to set the right UDP destination port plus the desired VxLAN flag bits. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst | 18

[RFC] ethdev: add VXLAN last reserved field

2024-04-23 Thread Rongwei Liu
Add VxLAN last reserved bytes in rte flow packet fields. Signed-off-by: Rongwei Liu --- lib/ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 6e8ab1d4c7..5aaa0dc96f 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev

[PATCH v2 2/2] net/mlx5: fix modify flex item error

2024-02-22 Thread Rongwei Liu
In the rte_flow_field_data structure, the flex item handle is part of union with other members like level/tag_index. If the user wants to modify the flex item as source or destination, there should not be any checking against zero. Signed-off-by: Rongwei Liu Fixes: c23626f27b09 ("ethdev

[PATCH v2 1/2] app/testpmd: fix modify tag typo

2024-02-22 Thread Rongwei Liu
Update the name to the right one: "src_tag_index" Signed-off-by: Rongwei Liu Fixes: c23626f27b09 ("ethdev: add MPLS header modification") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 inse

[PATCH v2 0/2] Fix modify flex item error

2024-02-22 Thread Rongwei Liu
v2: rebase. Rongwei Liu (2): app/testpmd: fix modify tag typo net/mlx5: fix modify flex item error app/test-pmd/cmdline_flow.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 -- 3 files changed, 6 insertions(+), 4 deletions(-) -- 2.27.0

Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo

2024-02-21 Thread rongwei liu
February 22, 2024 0:42 To: rongwei liu ; dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: Michael Baum ; sta...@dpdk.org ; Dariusz Sosnowski ; Aman Singh ; Yuying Zhang Subject: Re: [PATCH v1 1/2] app/testpmd: fix mod

[PATCH v1 2/2] net/mlx5: fix modify flex item error

2024-02-20 Thread Rongwei Liu
In the rte_flow_field_data structure, the flex item handle is part of union with other members like level/tag_index. If the user wants to modify the flex item as source or destination, there should not be any checking against zero. Signed-off-by: Rongwei Liu Fixes: 7ea38955b ("ethdev: u

[PATCH v1 1/2] app/testpmd: fix modify tag typo

2024-02-20 Thread Rongwei Liu
Update the name to the right one: "src_tag_index" Signed-off-by: Rongwei Liu Fixes: 7ea38955b ("ethdev: update MPLS header modification API") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 2 +- 1 file change

[PATCH v1 0/2] fix flex item modify error

2024-02-20 Thread Rongwei Liu
Fix flex item modification typo and wrong checking. Rongwei Liu (2): app/testpmd: fix modify tag typo net/mlx5: fix modify flex item error app/test-pmd/cmdline_flow.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 -- 3 files changed, 6

[PATCH v1] net/mlx5: fix secondary process query stats segfault

2024-01-21 Thread Rongwei Liu
ocess' heap. Return ENOTSUP as workaround. Signed-off-by: Rongwei Liu Acked-by: Matan Azrad Fixes: 750e48c7d ("common/mlx5: add DevX commands for queue counters") Cc: ma...@nvidia.com Cc: sta...@dpdk.org --- drivers/net/mlx5/linux/mlx5_os.c | 8 +++- 1 file changed, 7 inserti

[PATCH v1] doc/mlx5: update IPv6 routing extension matching limitation

2023-11-22 Thread Rongwei Liu
Due to hardware limitations, the relaxed mode is not supported, otherwise, packets may mismatch. Signed-off-by: Rongwei Liu Acked-by: Suanming Mou Acked-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides

[PATCH v1 2/2] net/mlx5/hws: fix srv6 mismatching

2023-11-09 Thread Rongwei Liu
When matching srv6 packets, the IPv6 protocol is set to 0x2b by srv6 callback in fc[IP_PROTO]. In the next layer, TCP/UDP callback reset the fc again to the corresponding values: 0x11/0x6. Signed-off-by: Rongwei Liu Fixes: 00e579166cc0 ("net/mlx5: support IPv6 routing extension matching

[PATCH v1 1/2] net/mlx5/hws: disable IPv6 routing extension relaxed mode

2023-11-09 Thread Rongwei Liu
(sport=100,dport=100) Packet hit. Hardware cached the IPv6 routing extension information in the 1st packet and plus the UDP dport in the 2nd packet, it matches the rule by mistake. Signed-off-by: Rongwei Liu Cc: sta...@dpdk.org Reviewed-by: Erez Shitrit Acked-by: Suanming Mou ---

[PATCH v1 0/2] fix IPv6 routing extension mismatching

2023-11-09 Thread Rongwei Liu
Fix potential mismatching when IPv6 routing extension item enabled. Rongwei Liu (2): net/mlx5/hws: disable IPv6 routing extension relaxed mode net/mlx5/hws: fix srv6 mismatching drivers/net/mlx5/hws/mlx5dr_definer.c | 24 drivers/net/mlx5/hws/mlx5dr_definer.h | 1

[21.11 PATCH v1] net/mlx5: fix matcher layout size calculation

2023-11-02 Thread Rongwei Liu
. The matching mask should be checked instead. Fixes: 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field") Cc: rongw...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 18 +- 1

[PATCH v4 13/13] net/mlx5/hws: add stc reparse support for srv6 push pop

2023-10-31 Thread Rongwei Liu
Only pop action can work well. Signed-off-by: Rongwei Liu Reviewed-by: Erez Shitrit Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 115 +++ drivers/net/mlx5/hws/mlx5dr_action.h | 7 ++ 2 files changed, 87 insertions(+), 35 deletions(-) diff --git a/dr

[PATCH v4 12/13] net/mlx5/hws: fix srv6 push compilation failure

2023-10-31 Thread Rongwei Liu
address when creating dr_action. This is a false alert. Initialize it to NULL to fix the warning. Fixes: a50f6d3fe58d ("net/mlx5/hws: add IPv6 routing extension push remove actions") Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_ac

[PATCH v4 11/13] net/mlx5: implement IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
Reserve the push data buffer for each job and the maximum length is set to 128 for now. Only supports type IPPROTO_ROUTING when translating the rte flow action. Remove actions must be shared globally and only supports next layer as TCP or UDP. Signed-off-by: Rongwei Liu Acked-by: Ori Kam

[PATCH v4 10/13] net/mlx5/hws: add setter for IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
. Setter which requires no reparse can't share the same one with the one has reparse enabled even if there is spare space. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 174 +++ drivers/net/mlx

[PATCH v4 09/13] net/mlx5/hws: add IPv6 routing extension push remove actions

2023-10-31 Thread Rongwei Liu
Add two dr_actions to implement IPv6 routing extension push and remove, the new actions are multiple actions combination instead of new types. Basically, there are two modify headers plus one reformat action. Action order is the same as encap and decap actions. Signed-off-by: Rongwei Liu

[PATCH v4 07/13] net/mlx5: sample the srv6 last segment

2023-10-31 Thread Rongwei Liu
When removing the IPv6 routing extension header from the packets, the destination address should be updated to the last one in the segment list. Enlarge the hardware sample scope to cover the last segment. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou --- drivers/net

[PATCH v4 08/13] net/mlx5/hws: fix potential wrong rte_errno value

2023-10-31 Thread Rongwei Liu
A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: 0a2657c4ff4d ("net/mlx5/hws: support insert header action") Cc: hamd...@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam -

[PATCH v4 05/13] net/mlx5/hws: dynamic re-parse for modify header

2023-10-31 Thread Rongwei Liu
From: Alex Vesker With dynamic re-parse we would always require re-parse but this is not always necessary. Re-parse is only needed when the packet structure is changed. This support will allow dynamically deciding based on the action pattern if re-parse is required or no. Signed-off-by: Alex Ves

[PATCH v4 06/13] net/mlx5/hws: fix incorrect re-parse on complex rules

2023-10-31 Thread Rongwei Liu
From: Alex Vesker The re-parse value when jumping to action STEs was set to NEVER leading to cases in which 2 STCs accessed the re-parse bit causing hw_syndrome (0x3d). The solution is to use set re-parse mode to IGNORE in such case. Fixes: 2b3d3097a10a ("net/mlx5/hws: support dynamic re-parse")

[PATCH v4 04/13] net/mlx5/hws: support dynamic re-parse

2023-10-31 Thread Rongwei Liu
From: Alex Vesker Each steering entry (STE) has a bit called re-parse used for re-parsing the packet in HW, re-parsing is needed after reformat (e.g. push/pop/encapsulate/...) or when modifying the packet headers requiring structure change (e.g. TCP to UDP). Until now we re-parsed the packet in e

[PATCH v4 03/13] net/mlx5/hws: allow jump to TIR over FDB

2023-10-31 Thread Rongwei Liu
From: Alex Vesker Current TIR action is allowed to be used only for NIC RX, this will allow TIR action over FDB for RX traffic in case of TX traffic packets will be dropped. Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h |

[PATCH v4 02/13] net/mlx5/hws: support remove header action

2023-10-31 Thread Rongwei Liu
From: Hamdan Igbaria Support remove header action, this action will allow the user to execute dynamic decaps by choosing to decap by providing a start anchor and number of words to remove, or providing a start anchor and end anchor. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-

[PATCH v4 01/13] net/mlx5/hws: support insert header action

2023-10-31 Thread Rongwei Liu
From: Hamdan Igbaria Support insert header action, this will allow encap at a specific anchor and offset selected by the user. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr.h | 36 drivers/net/mlx5/hws/mlx5dr_actio

[PATCH v4 00/13] support IPv6 push remove action

2023-10-31 Thread Rongwei Liu
: dynamic re-parse for modify header net/mlx5/hws: fix incorrect re-parse on complex rules Hamdan Igbaria (2): net/mlx5/hws: support insert header action net/mlx5/hws: support remove header action Rongwei Liu (7): net/mlx5: sample the srv6 last segment net/mlx5/hws: fix potential wrong

[PATCH v3 6/6] net/mlx5/hws: add stc reparse support for srv6 push pop

2023-10-31 Thread Rongwei Liu
Only pop action can work well. Signed-off-by: Rongwei Liu Reviewed-by: Erez Shitrit Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 115 +++ drivers/net/mlx5/hws/mlx5dr_action.h | 7 ++ 2 files changed, 87 insertions(+), 35 deletions(-) diff --git a/dr

[PATCH v3 5/6] net/mlx5: implement IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
Reserve the push data buffer for each job and the maximum length is set to 128 for now. Only supports type IPPROTO_ROUTING when translating the rte flow action. Remove actions must be shared globally and only supports next layer as TCP or UDP. Signed-off-by: Rongwei Liu Acked-by: Ori Kam

[PATCH v3 2/6] net/mlx5/hws: fix potential wrong errno value

2023-10-31 Thread Rongwei Liu
A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: a318b3d54772 ("net/mlx5/hws: support insert header action") Cc: hamd...@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam -

[PATCH v3 4/6] net/mlx5/hws: add setter for IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
. Setter which requires no reparse can't share the same one with the one has reparse enabled even if there is spare space. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 174 +++ drivers/net/mlx

[PATCH v3 3/6] net/mlx5/hws: add IPv6 routing extension push remove actions

2023-10-31 Thread Rongwei Liu
Add two dr_actions to implement IPv6 routing extension push and remove, the new actions are multiple actions combination instead of new types. Basically, there are two modify headers plus one reformat action. Action order is the same as encap and decap actions. Signed-off-by: Rongwei Liu

[PATCH v3 0/6] support IPv6 extension push remove

2023-10-31 Thread Rongwei Liu
Support IPv6 extension push/remove actions in MLX5 PMD. Routing extension is the only supported type. v3: rebase. v2: add reparse control and rebase. Rongwei Liu (6): net/mlx5: sample the srv6 last segment net/mlx5/hws: fix potential wrong errno value net/mlx5/hws: add IPv6 routing

[PATCH v3 1/6] net/mlx5: sample the srv6 last segment

2023-10-31 Thread Rongwei Liu
When removing the IPv6 routing extension header from the packets, the destination address should be updated to the last one in the segment list. Enlarge the hardware sample scope to cover the last segment. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou --- drivers/net

[PATCH v2 5/6] net/mlx5: implement IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
Reserve the push data buffer for each job and the maximum length is set to 128 for now. Only supports type IPPROTO_ROUTING when translating the rte flow action. Remove actions must be shared globally and only supports next layer as TCP or UDP. Signed-off-by: Rongwei Liu Acked-by: Ori Kam

[PATCH v2 4/6] net/mlx5/hws: add setter for IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
. Setter which requires no reparse can't share the same one with the one has reparse enabled even if there is spare space. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 174 +++ drivers/net/mlx

[PATCH v2 6/6] net/mlx5/hws: add stc reparse support for srv6 push pop

2023-10-31 Thread Rongwei Liu
Only pop action can work well. Signed-off-by: Rongwei Liu Reviewed-by: Erez Shitrit Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 115 +++ drivers/net/mlx5/hws/mlx5dr_action.h | 7 ++ 2 files changed, 87 insertions(+), 35 deletions(-) diff --git a/dr

[PATCH v2 2/6] net/mlx5/hws: fix potential wrong errno value

2023-10-31 Thread Rongwei Liu
A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: 890db3e2b90 ("net/mlx5/hws: support insert header action") Cc: hamd...@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam -

[PATCH v2 3/6] net/mlx5/hws: add IPv6 routing extension push remove actions

2023-10-31 Thread Rongwei Liu
Add two dr_actions to implement IPv6 routing extension push and remove, the new actions are multiple actions combination instead of new types. Basically, there are two modify headers plus one reformat action. Action order is the same as encap and decap actions. Signed-off-by: Rongwei Liu

[PATCH v2 0/6] support IPv6 extension push remove

2023-10-31 Thread Rongwei Liu
Support IPv6 extension push/remove in MLX5 PMD. Routing extension is the only supported type. v2: add reparse control and rebase. Rongwei Liu (6): net/mlx5: sample the srv6 last segment net/mlx5/hws: fix potential wrong errno value net/mlx5/hws: add IPv6 routing extension push remove

[PATCH v2 1/6] net/mlx5: sample the srv6 last segment

2023-10-31 Thread Rongwei Liu
When removing the IPv6 routing extension header from the packets, the destination address should be updated to the last one in the segment list. Enlarge the hardware sample scope to cover the last segment. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou --- drivers/net

[PATCH v4] net/mlx5: add indirect encap decap support

2023-10-29 Thread Rongwei Liu
  Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou v4, v3: add macro to fix build failure v2: rebase --- drivers/net/mlx5/mlx5_flow.c| 7 + drivers/net/mlx5/mlx5_flow.h| 16 ++ drivers/net/mlx5/mlx5_flow_hw.c | 323 3 files changed

[PATCH v3] net/mlx5: add indirect encap decap support

2023-10-29 Thread Rongwei Liu
  Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou v3: Protect with macro to fix warning. v2: Code rebase --- drivers/net/mlx5/mlx5_flow.c| 5 + drivers/net/mlx5/mlx5_flow.h| 16 ++ drivers/net/mlx5/mlx5_flow_hw.c | 323 3 files

[PATCH v2] net/mlx5: add indirect encap decap support

2023-10-29 Thread Rongwei Liu
  Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou v2: Code rebase --- drivers/net/mlx5/mlx5_flow.c| 5 + drivers/net/mlx5/mlx5_flow.h| 16 ++ drivers/net/mlx5/mlx5_flow_hw.c | 323 3 files changed, 344 insertions(+) diff --git a

[PATCH v7] net/mlx5: add test for live migration

2023-10-25 Thread Rongwei Liu
This patch adds testpmd app a runtime function to test the live migration API. testpmd> mlx5 set flow_engine [] Flag is optional. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst| 15 drivers/net/mlx5/mlx5_testpm

RE: [PATCH v5] net/mlx5: add test for live migration

2023-10-25 Thread Rongwei Liu
BR Rongwei > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 25, 2023 17:42 > To: Rongwei Liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Subject: Re: [PATCH v5] net/mlx5: add test for live migration

[PATCH v6] net/mlx5: add test for live migration

2023-10-25 Thread Rongwei Liu
This patch adds testpmd app a runtime function to test the live migration API. testpmd> mlx5 set flow_engine [] Flag is optional. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst| 15 drivers/net/mlx5/mlx5_testpm

[PATCH v5] net/mlx5: add test for live migration

2023-10-25 Thread Rongwei Liu
This patch adds testpmd app a runtime function to test the live migration API. testpmd> mlx5 set flow_engine [] Flag is optional. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst| 15 drivers/net/mlx5/mlx5_testpm

RE: [PATCH v3] net/mlx5: add test for live migration

2023-10-25 Thread Rongwei Liu
BR Rongwei > -Original Message- > From: Rongwei Liu > Sent: Monday, October 16, 2023 17:30 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Subject: RE: [PATCH v3

[PATCH v1] net/mlx5: add indirect encap decap support

2023-10-17 Thread Rongwei Liu
  Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou Depends on the preceding series: https://inbox.dpdk.org/dev/20231017073117.23738-1-getel...@nvidia.com/ --- drivers/net/mlx5/mlx5_flow.c| 5 + drivers/net/mlx5/mlx5_flow.h| 15 ++ drivers/net/mlx5/mlx5_flow_hw.c

RE: [PATCH v3] net/mlx5: add test for live migration

2023-10-16 Thread Rongwei Liu
Hi BR Rongwei > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 16, 2023 17:27 > To: Rongwei Liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Subject: Re: [PATCH v3] net/mlx5: add

RE: [PATCH v3] net/mlx5: add test for live migration

2023-10-16 Thread Rongwei Liu
BR Rongwei > -Original Message- > From: Rongwei Liu > Sent: Monday, October 16, 2023 16:26 > To: Thomas Monjalon > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Subject: RE: [PATCH v3] net/mlx5: add test fo

  1   2   3   4   5   >