[dpdk-dev] [PATCH] l3fwd-power: remove the dead codes.

2017-10-13 Thread Tonghao Zhang
Signed-off-by: Tonghao Zhang --- examples/l3fwd-power/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 8a8f34b..c08a775 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -752,8 +752,6 @@ static

Re: [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-09 Thread Tonghao Zhang
Thanks for your review. On Tue, Jan 9, 2018 at 9:40 PM, Yuanhan Liu wrote: > On Tue, Jan 09, 2018 at 09:12:43PM +0800, Yuanhan Liu wrote: >> On Fri, Jan 05, 2018 at 06:10:39AM -0800, Tonghao Zhang wrote: >> > This patch adds the name for vhost-user reconnect thread. >>

[dpdk-dev] vhost-user performance.

2018-01-10 Thread Tonghao Zhang
hi, I tested the vhost-user, but i dont get a better performance. The test case is VM2VM which are in the same host. if we use the vhost-net in kernel, we get a 20 Gbits/sec throughput, but vhost-user is only 5Gits/sec. vhost-net: qemu-system-x86_64 -enable-kvm -m 1G -smp 4 \ -cpu host \ -netdev

Re: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-11 Thread Tonghao Zhang
On Thu, Jan 11, 2018 at 2:55 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> S

Re: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-01-11 Thread Tonghao Zhang
On Thu, Jan 11, 2018 at 3:26 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> Subject: [

Re: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-11 Thread Tonghao Zhang
On Thu, Jan 11, 2018 at 3:06 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> Subjec

Re: [dpdk-dev] [PATCH v2 1/4] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-13 Thread Tonghao Zhang
't agree it now. > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of >> xiangxia.m@gmail.com >> Sent: Friday, January 12, 2018 12:40 AM >> To: Xing, Beilei ; dev@dpdk.org >> Cc: Tonghao Zhang >> Subject:

Re: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-13 Thread Tonghao Zhang
un...@dpdk.org] On Behalf Of Xing, Beilei >> Sent: Thursday, January 11, 2018 3:06 PM >> To: Tonghao Zhang ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for >> rte_intr_enable. >> >> >> >> > -Original Message- >&

Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-15 Thread Tonghao Zhang
On Mon, Jan 15, 2018 at 12:57 PM, Dai, Wei wrote: >> -Original Message- >> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >> Sent: Sunday, January 14, 2018 6:04 PM >> To: Dai, Wei ; Xing, Beilei >> Cc: dev@dpdk.org; Tonghao Zhang >>

Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-16 Thread Tonghao Zhang
On Mon, Jan 15, 2018 at 4:57 PM, Tonghao Zhang wrote: > On Mon, Jan 15, 2018 at 12:57 PM, Dai, Wei wrote: >>> -Original Message- >>> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >>> Sent: Sunday, January 14, 2018 6:04 PM >>> T

Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.

2018-04-08 Thread Tonghao Zhang
On Wed, Apr 4, 2018 at 10:48 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Thursday, March 8, 2018 6:57 PM >> To: Xing, Beilei ; Dai, Wei ; >> Zhang, >> Helin ;

Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.

2018-04-11 Thread Tonghao Zhang
On Wed, Apr 11, 2018 at 8:21 PM, Zhang, Qi Z wrote: > Hi tonghao: > >> -Original Message----- >> From: Tonghao Zhang [mailto:xiangxia.m@gmail.com] >> Sent: Monday, April 9, 2018 8:53 AM >> To: Zhang, Qi Z >> Cc: Xing, Beilei ; Dai, Wei ; >&

Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-04-17 Thread Tonghao Zhang
On Tue, Apr 17, 2018 at 7:00 PM, Ferruh Yigit wrote: > On 3/22/2018 1:01 PM, xiangxia.m@gmail.com wrote: >> From: Tonghao Zhang >> >> Set EITR interval as default. This patch can improve the >> performance when we enable the rx-intrrupt to process the >> pa

Re: [dpdk-dev] [PATCH 1/2] vhost: make sure vhost fdset-thread created successfully

2018-03-22 Thread Tonghao Zhang
On Fri, Mar 23, 2018 at 9:30 AM, Tan, Jianfeng wrote: > Hi Xiangxia, > >> -Original Message- >> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >> Sent: Thursday, March 22, 2018 8:40 PM >> To: Tan, Jianfeng >> Cc: dev@dpdk.org; Tonghao

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-29 Thread Tonghao Zhang
On Thu, Mar 29, 2018 at 3:32 PM, Tan, Jianfeng wrote: > Hi Xiangxia, > >> -Original Message- >> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >> Sent: Wednesday, March 28, 2018 1:49 PM >> To: Tan, Jianfeng >> Cc: dev@dpdk.org; Tonghao

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 3:57 PM, Maxime Coquelin wrote: > Hi Xiangxia, > > > On 03/29/2018 01:24 PM, Tonghao Zhang wrote: >> >> On Thu, Mar 29, 2018 at 3:32 PM, Tan, Jianfeng >> wrote: >>> >>> Hi Xiangxia, >>> >>>> -Origina

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: > On 3/30/2018 2:27 PM, Maxime Coquelin wrote: >> Hi Andrew, >> >> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >>> Hi all, >>> >>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >>> >>> lib/librte_vhost/fd_man.c: In function ‘fd

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644 --- a/lib/librte_vhost/fd_man.c +++ b/lib/librte_vhost/fd_man.c @@ -279,7 +279,8 @@ fdset_pipe_read_cb(int readfd, voi

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:59 PM, Maxime Coquelin wrote: > Thanks Xiangxia, > > I can post it, do you agree if I add below comments? yes, thanks. > On 03/30/2018 04:47 PM, Tonghao Zhang wrote: >> >> I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED

[dpdk-dev] [PATCH] igb_uio: use the UIO_IRQ_NONE instead of 0.

2017-09-18 Thread Tonghao Zhang
From: Tonghao Zhang This is not bugfix, but it's convenient to help developer to review and maintain the igbuio codes. Signed-off-by: Tonghao Zhang --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/ig

[dpdk-dev] [PATCH] ethdev: fix the comment for rte_eth_conf.

2017-09-18 Thread Tonghao Zhang
We have change the type of rx_adv_conf, so change the comment for it. Signed-off-by: Tonghao Zhang --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 99cdd54..e079daa 100644

[dpdk-dev] [PATCH 3/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-01-05 Thread Tonghao Zhang
If dpdk APPs call the rte_eth_dev_rx_intr_enable or rte_eth_dev_rx_intr_disable frequently, and ixgbe vf will read the IXGBE_VTEIMS register everytime. We can optimize the driver function. The patch save the IXGBE_VTEIMS to mask to avoid read frequently. Signed-off-by: Tonghao Zhang --- drivers

[dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-05 Thread Tonghao Zhang
. Any suggestion will be welcome. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index e929235..79e4097 100644 --- a/drivers/net/ixgbe

[dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-05 Thread Tonghao Zhang
t;eal-intr-thread" thread will process the rx interrupt, and then rte_epoll_wait can't get the event any more, and the packets may be lost. We should unregister the status interrupt handler in "eal-intr-thread" thread and the ixgbe pf is in the same case. Signed-off-by: Tonghao

[dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-05 Thread Tonghao Zhang
This patch adds the name for vhost-user reconnect thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang Signed-off-by: Tonghao Zhang --- lib/librte_vhost/socket.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_vhost/socket.c b/lib

[dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-05 Thread Tonghao Zhang
t;eal-intr-thread" thread will process the rx interrupt, and then rte_epoll_wait can't get the event any more, and the packets may be lost. We should unregister the status interrupt handler in "eal-intr-thread" thread and the ixgbe pf is in the same case. Signed-off-by: Tonghao

[dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-01-05 Thread Tonghao Zhang
Set EITR interval as default. This patch can improve the performance when we enable the rx-intrrupt to process the packets because we hope rx-intrrupt reduce CPU. The 200us value of EITR makes the performance better with the low CPU. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe

[dpdk-dev] [PATCH 3/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-01-05 Thread Tonghao Zhang
If dpdk APPs call the rte_eth_dev_rx_intr_enable or rte_eth_dev_rx_intr_disable frequently, and ixgbe vf will read the IXGBE_VTEIMS register everytime. We can optimize the driver function. The patch save the IXGBE_VTEIMS to mask to avoid read frequently. Signed-off-by: Tonghao Zhang --- drivers

[dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-05 Thread Tonghao Zhang
. Any suggestion will be welcome. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index e929235..79e4097 100644 --- a/drivers/net/ixgbe

[dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-05 Thread Tonghao Zhang
This patch adds the name for vhost-user reconnect thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang --- lib/librte_vhost/socket.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index

Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.

2018-03-08 Thread Tonghao Zhang
ping On Mon, Feb 5, 2018 at 8:51 AM, wrote: > From: Tonghao Zhang > > The patches in the patchset have no dependency. But all of them > is about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration > for ixgbe and ixgbevf, the user and developer can configure

[dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

2017-05-08 Thread Tonghao Zhang
The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. It is good to see more checking for valid values. Signed-off-by: Tonghao Zhang --- lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

2017-05-08 Thread Tonghao Zhang
The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. It is good to see more checking for valid values. Signed-off-by: Tonghao Zhang --- lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

2017-05-09 Thread Tonghao Zhang
The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. It is good to see more checking for valid values. Signed-off-by: Tonghao Zhang --- lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-05-10 Thread Tonghao Zhang
The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. It is good to see more checking for valid values. Signed-off-by: Tonghao Zhang --- lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH] memzone: Check socket_id value when creating memzone.

2017-05-11 Thread Tonghao Zhang
If the socket_id is invalid (e.g. -2, -3), the memzone_reserve_aligned_thread_unsafe should return the EINVAL and not ENOMEM. To avoid it, we should check the socket_id before calling malloc_heap_alloc. Signed-off-by: Tonghao Zhang --- lib/librte_eal/common/eal_common_memzone.c | 3 ++- 1 file

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2019-12-15 Thread Tonghao Zhang
On Fri, Dec 13, 2019 at 10:21 PM wrote: > > From: Tonghao Zhang > > When offloading the meter, should check the action > conf and make sure it is valid. > > Fixes: f46bf7488705 ("net/mlx5: support meter flow action") > Cc: Suanming Mou > > Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: allow install more meter actions

2019-12-19 Thread Tonghao Zhang
ping On Tue, Dec 17, 2019 at 3:29 PM wrote: > > From: Tonghao Zhang > > When creating the dr rule of meter, the matcher which > struct is "struct mlx5dv_dr_matcher" should not be > shared, if shared, mlx5dv_dr_rule_create will return > NULL. We can't i

Re: [dpdk-dev] [PATCH] net/mlx5: allow install more meter actions

2020-01-05 Thread Tonghao Zhang
ate 0 group 1 priority 3 ingress pattern eth / ipv4 / tcp dst is 80 / end actions meter mtr_id 101 / queue index 1 / end Caught error type 1 (cause unspecified): hardware refuses to create flow: Invalid argument And with this patch, it works fine. > Thanks > SuanmingMou > > > -Ori

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2020-01-06 Thread Tonghao Zhang
On Mon, Dec 16, 2019 at 2:50 PM Suanming Mou wrote: > > > > -Original Message- > > From: Tonghao Zhang > > Sent: Monday, December 16, 2019 9:29 AM > > To: Matan Azrad ; Shahaf Shuler > > > > Cc: dev@dpdk.org; Suanming Mou > > Subject:

[dpdk-dev] mlx5 offload: decapsulation and encapsulation + meter action

2020-01-21 Thread Tonghao Zhang
Hi Suanming When I try to offload decapsulation + meter action, there is an error. So one question, mlx5 support that actions ? "Flow can't be created 1 message: hardware refuses to create flow" OFED: 4.7-3.2.9 FW: 16.26.4012 DPDK 19.11 ConnectX-5

Re: [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq

2019-11-27 Thread Tonghao Zhang
Wednesday, November 27, 2019 4:19 PM > > To: dev@dpdk.org > > Cc: Tonghao Zhang ; Ori Kam > > > > Subject: [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq > > > > From: Tonghao Zhang > > > > The mlx5_rxq_obj_hairpin_new doesn't alloc

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-26 Thread Tonghao Zhang
On Thu, Apr 23, 2020 at 9:38 PM Andrew Rybchenko wrote: > > On 4/13/20 5:21 PM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > The order of mempool initiation affects mempool index in the > > rte_mempool_ops_table. For example, when bui

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-27 Thread Tonghao Zhang
On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon wrote: > > 13/04/2020 16:21, xiangxia.m@gmail.com: > > The order of mempool initiation affects mempool index in the > > rte_mempool_ops_table. For example, when building APPs with: > > > > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... > > > >

Re: [dpdk-dev] [ovs-dev] OvS DPDK crash when HPET timer enabled

2020-04-27 Thread Tonghao Zhang
ommit/?id=9b41c276fd35fe3c0ed3fb0d9cf98a83a58b31b2 > Thanks, > Ravi > > > On Mon, Apr 13, 2020 at 5:33 PM Tonghao Zhang > wrote: >> >> On Tue, Apr 14, 2020 at 7:20 AM Ilya Maximets wrote: >> > >> > On 4/13/20 5:27 PM, Ravi Kerur wrote: >> > > On Sun, Apr 12, 2020

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-27 Thread Tonghao Zhang
On Mon, Apr 27, 2020 at 7:40 PM Thomas Monjalon wrote: > > 27/04/2020 10:03, Tonghao Zhang: > > On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon wrote: > > > > > > 13/04/2020 16:21, xiangxia.m@gmail.com: > > > > The order of mempo

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-28 Thread Tonghao Zhang
On Mon, Apr 27, 2020 at 8:51 PM Tonghao Zhang wrote: > > On Mon, Apr 27, 2020 at 7:40 PM Thomas Monjalon wrote: > > > > 27/04/2020 10:03, Tonghao Zhang: > > > On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon > > > wrote: > > > > > > > &g

Re: [dpdk-dev] [PATCH dpdk-dev 1/2] eal: introduce last-init queue for libraries initialization

2020-04-09 Thread Tonghao Zhang
On Thu, Apr 9, 2020 at 7:31 PM Jerin Jacob wrote: > > On Thu, Apr 9, 2020 at 4:24 PM wrote: > > > > From: Tonghao Zhang > > > > This patch introduces last-init queue, user can register a > > callback for theirs initialization. Running rte_last_init_run(),

Re: [dpdk-dev] [PATCH dpdk-dev v2 1/2] eal: introduce rte-init queue for libraries initialization

2020-04-11 Thread Tonghao Zhang
ch 2? > 3) Update the .map file > > > > On Thu, Apr 9, 2020 at 8:33 PM wrote: > > > > > > From: Tonghao Zhang > > > > > > This patch introduces last-init queue, user can register a > > > callback for theirs initialization. Runn

Re: [dpdk-dev] [PATCH dpdk-dev v2 1/2] eal: introduce rte-init queue for libraries initialization

2020-04-11 Thread Tonghao Zhang
On Sun, Apr 12, 2020 at 11:20 AM Tonghao Zhang wrote: > > On Fri, Apr 10, 2020 at 9:11 PM Jerin Jacob wrote: > > > > On Fri, Apr 10, 2020 at 11:48 AM Jerin Jacob wrote: > > > > > > > Three more items are missing in this patch Can I add "Co-authored-

Re: [dpdk-dev] [ovs-dev] OvS DPDK crash when HPET timer enabled

2020-04-13 Thread Tonghao Zhang
On Tue, Apr 14, 2020 at 7:20 AM Ilya Maximets wrote: > > On 4/13/20 5:27 PM, Ravi Kerur wrote: > > On Sun, Apr 12, 2020 at 5:05 AM Tonghao Zhang > > wrote: > > > >> On Sun, Apr 12, 2020 at 7:57 AM Ravi Kerur wrote: > >>> > >>> Hello O

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-13 Thread Tonghao Zhang
On Tue, Apr 14, 2020 at 12:07 PM Stephen Hemminger wrote: > > On Sun, 12 Apr 2020 16:27:53 +0800 > xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > When rte_rand_init is invoked, and the kernel > > (kernel version < 3.17) running dpdk does

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-14 Thread Tonghao Zhang
On Tue, Apr 14, 2020 at 11:37 PM Mattias Rönnblom wrote: > > On 2020-04-14 15:35, David Marchand wrote: > > On Tue, Apr 14, 2020 at 3:20 PM Mattias Rönnblom > > wrote: > >> On 2020-04-14 06:43, Tonghao Zhang wrote: > >>> On Tue, Apr 14, 2020 at 12:07 PM St

Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error

2020-03-01 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 1:09 AM Ali Alnubani wrote: > > Hi Tonghao, > > > -Original Message- > > From: dev On Behalf Of > > xiangxia.m@gmail.com > > Sent: Saturday, February 29, 2020 12:27 PM > > To: Matan Azrad ; dev@dpdk.org > > Cc: Tongh

Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error

2020-03-02 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 3:35 PM Ali Alnubani wrote: > > > -Original Message- > > From: Tonghao Zhang > > Sent: Monday, March 2, 2020 2:23 AM > > To: Ali Alnubani > > Cc: sta...@dpdk.org; Matan Azrad ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [d

Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error

2020-03-02 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 5:47 PM Ali Alnubani wrote: > > > > Do you mind sharing which OS are you using, which gcc/clang version, > > whether you have MLNX_OFED or rdma-core installed, and which version? > > 1. CentOS Linux release 7.6.1810 (Core) > > 2. kernel 3.10.0-957.1.3.el7.x86_64 > > 3. OFED

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob wrote: > > On Mon, Mar 2, 2020 at 7:27 AM wrote: > > > > From: Tonghao Zhang > > > > The order of mempool initiation affects mempool index in the > > rte_mempool_ops_table. For example, when building APPs with

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Tonghao Zhang
On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad wrote: > > > Hi > > From: xiangxia.m@gmail.com > > From: Tonghao Zhang > > > > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 > > pmd, there is a building error. > > To fix it, ad

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Tonghao Zhang
On Wed, Mar 4, 2020 at 9:33 PM Jerin Jacob wrote: > > On Wed, Mar 4, 2020 at 6:48 PM Tonghao Zhang wrote: > > > > On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob wrote: > > > > > > On Mon, Mar 2, 2020 at 7:27 AM wrote: > > > > > > > &g

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Tonghao Zhang
On Wed, Mar 4, 2020 at 10:25 PM Matan Azrad wrote: > > > > From: Tonghao Zhang > > On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad wrote: > > > > > > > > > Hi > > > > > > From: xiangxia.m@gmail.com > > > > From: Tonghao Zh

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Tonghao Zhang
On Wed, Mar 4, 2020 at 11:14 PM Jerin Jacob wrote: > > On Wed, Mar 4, 2020 at 8:17 PM Tonghao Zhang wrote: > > > > On Wed, Mar 4, 2020 at 9:33 PM Jerin Jacob wrote: > > > > > > On Wed, Mar 4, 2020 at 6:48 PM Tonghao Zhang > > > wrote: > > >

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Tonghao Zhang
On Thu, Mar 5, 2020 at 12:03 AM Matan Azrad wrote: > > > > From: Tonghao Zhang > > On Wed, Mar 4, 2020 at 10:25 PM Matan Azrad > > wrote: > > > > > > > > > > > > From: Tonghao Zhang > > > > On Tue, Mar 3,

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-08 Thread Tonghao Zhang
On Sat, Mar 7, 2020 at 8:54 PM Andrew Rybchenko wrote: > > On 3/7/20 3:51 PM, Andrew Rybchenko wrote: > > On 3/6/20 4:37 PM, Jerin Jacob wrote: > >> On Fri, Mar 6, 2020 at 7:06 PM wrote: > >>> From: Tonghao Zhang > >>> > >>> The

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-09 Thread Tonghao Zhang
On Mon, Mar 9, 2020 at 4:27 PM Olivier Matz wrote: > > Hi, > > On Mon, Mar 09, 2020 at 11:01:25AM +0800, Tonghao Zhang wrote: > > On Sat, Mar 7, 2020 at 8:54 PM Andrew Rybchenko > > wrote: > > > > > > On 3/7/20 3:51 PM, Andrew Rybchenko wrote: &g

Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

2020-05-24 Thread Tonghao Zhang
ion. Thanks. > With best regards, > Slava > > > -Original Message- > > From: xiangxia.m@gmail.com > > Sent: Wednesday, May 20, 2020 4:33 > > To: Slava Ovsiienko ; dev@dpdk.org > > Cc: Tonghao Zhang > > Subject: [PATCH dpdk-dev] net/mlx5:

Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

2020-05-27 Thread Tonghao Zhang
On Sun, May 24, 2020 at 6:47 PM Tonghao Zhang wrote: > > On Sat, May 23, 2020 at 1:17 AM Slava Ovsiienko > wrote: > > > > Hi, Tonghao Hi maintainers, one question, as doc said: dv_xmeta_en 2, this engages extensive metadata mode, the MARK and META related actions and ite

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-16 Thread Tonghao Zhang
On Mon, Mar 9, 2020 at 9:15 PM David Marchand wrote: > > On Mon, Mar 9, 2020 at 9:56 AM Tonghao Zhang wrote: > > On Mon, Mar 9, 2020 at 4:27 PM Olivier Matz wrote: > > > The fact that the ops index changes during mempool driver lifetime is > > > indeed frightening,

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-24 Thread Tonghao Zhang
On Tue, Mar 24, 2020 at 5:36 PM Andrew Rybchenko wrote: > > On 3/9/20 11:27 AM, Olivier Matz wrote: > > Hi, > > > > On Mon, Mar 09, 2020 at 11:01:25AM +0800, Tonghao Zhang wrote: > >> On Sat, Mar 7, 2020 at 8:54 PM Andrew Rybchenko > >> wrote: >

Re: [dpdk-dev] [PATCH] eal/linux: add operation LOCK_NB to flock()

2021-04-13 Thread Tonghao Zhang
On Thu, Mar 25, 2021 at 4:25 PM wrote: > > From: Tonghao Zhang ping > The hugepage of different size, 2MB, 1GB may be mounted on > the same directory (e.g /dev/hugepages). Then dpdk > primary process will be blocked. To address this issue, > add the LOCK_NB flags to flock(

[dpdk-dev] [PATCH 2/2] sched: fix possible mem leak on initialize

2018-11-28 Thread Tonghao Zhang
In some case, we may create sched port dynamically, if err when creating so memory will leak. Signed-off-by: Tonghao Zhang --- lib/librte_sched/rte_sched.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 17de6e6..a3adcca

[dpdk-dev] [PATCH 1/2] sched: refine get base helper function

2018-11-28 Thread Tonghao Zhang
use switch instead of if, and it is more easy reading. Signed-off-by: Tonghao Zhang --- lib/librte_sched/rte_sched.c | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index

Re: [dpdk-dev] [PATCH 2/2] sched: fix possible mem leak on initialize

2018-12-10 Thread Tonghao Zhang
ping On Wed, Nov 28, 2018 at 9:56 PM Tonghao Zhang wrote: > > In some case, we may create sched port dynamically, > if err when creating so memory will leak. > > Signed-off-by: Tonghao Zhang > --- > lib/librte_sched/rte_sched.c | 1 + > 1 file changed, 1 insertion

Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-04-26 Thread Tonghao Zhang
rruh Yigit >> Sent: Thursday, April 19, 2018 12:10 AM >> To: Tonghao Zhang >> Cc: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Xing, Beilei ; Dai, >> Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt >> interval f

Re: [dpdk-dev] [PATCH net-next v4 0/4] set ixgbe/ixgbevf EITR for performance

2018-05-07 Thread Tonghao Zhang
Hi Ferruh, Qi: This version is ok ? On Sat, Apr 28, 2018 at 11:03 AM, wrote: > From: Tonghao Zhang > > v4: for reducing config options, remove the config option and use the > default value defined in header file. Remove the patch: > http://dpdk.org/dev/patchw

Re: [dpdk-dev] [PATCH v2] doc: update release notes.

2018-05-09 Thread Tonghao Zhang
On Thu, May 10, 2018 at 12:22 PM, Qi Zhang wrote: > Add updates for runtime queue setup. > > Signed-off-by: Qi Zhang > --- > > v2: > - fix typo. > > doc/guides/rel_notes/release_18_05.rst | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_