Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 11:02 AM Bruce Richardson wrote: > On Wed, Feb 16, 2022 at 10:41:43AM +0100, David Marchand wrote: > > On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson > > wrote: > > > > > I see that we have other telemetry callbacks for stats, link status > > > > > which might already h

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 10:41:43AM +0100, David Marchand wrote: > On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson > wrote: > > > > I see that we have other telemetry callbacks for stats, link status > > > > which might already have the issue. > > > > > > You mean there is no lock protection? Ne

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson wrote: > > > I see that we have other telemetry callbacks for stats, link status > > > which might already have the issue. > > > > You mean there is no lock protection? > > Neither in the API, nor in telemetry? > > > For reporting out stats or link

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 09:45:33AM +0100, Thomas Monjalon wrote: > 16/02/2022 09:03, David Marchand: > > On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX > > wrote: > > > The idea behind this is to monitor the quality of the link in the field > > > during testpmd operations. > > > It is supported i

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread Thomas Monjalon
16/02/2022 09:03, David Marchand: > On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX wrote: > > The idea behind this is to monitor the quality of the link in the field > > during testpmd operations. > > It is supported in Linux driver with ethtool command "ethtool -m xxx", but > > missing in DPDK.

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX wrote: > The idea behind this is to monitor the quality of the link in the field > during testpmd operations. > It is supported in Linux driver with ethtool command "ethtool -m xxx", but > missing in DPDK. > > This feature is requested by customer 6W

RE: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-15 Thread Zhang, RobinX
teveX > ; David Marchand > Subject: Re: [PATCH] app/testpmd: format dump information of module > EEPROM > > 15/02/2022 14:28, Ferruh Yigit: > > On 2/15/2022 10:18 AM, Robin Zhang wrote: > > > This patch add a format specific information of different module eeprom. > >

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-15 Thread Thomas Monjalon
15/02/2022 14:28, Ferruh Yigit: > On 2/15/2022 10:18 AM, Robin Zhang wrote: > > This patch add a format specific information of different module eeprom. > > The format support for SFP(Small Formfactor Pluggable)/SFP+ > > /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on > > SFF(Small

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 10:18 AM, Robin Zhang wrote: This patch add a format specific information of different module eeprom. The format support for SFP(Small Formfactor Pluggable)/SFP+ /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on SFF(Small Form Factor) Committee specifications SFF-8079/S

[PATCH] app/testpmd: format dump information of module EEPROM

2022-02-15 Thread Robin Zhang
This patch add a format specific information of different module eeprom. The format support for SFP(Small Formfactor Pluggable)/SFP+ /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on SFF(Small Form Factor) Committee specifications SFF-8079/SFF-8472/SFF-8024/SFF-8636. Signed-off-by: R