Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:31, Bruce Richardson: > On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > > 30/01/2019 12:17, Ferruh Yigit: > > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > > The contributing guide does indicate you are supposed to run both > > > > checkpatches.sh and check-gi

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:35, Bruce Richardson: > On Wed, Jan 30, 2019 at 12:31:21PM +0100, Thomas Monjalon wrote: > > 30/01/2019 12:29, Bruce Richardson: > > > On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > > > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > > > 29/01/2019 16:30, Ferruh

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 12:31:21PM +0100, Thomas Monjalon wrote: > 30/01/2019 12:29, Bruce Richardson: > > On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > > 29/01/2019 16:30, Ferruh Yigit: > > > >> Fixes line commit id length de

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > 30/01/2019 12:17, Ferruh Yigit: > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > The contributing guide does indicate you are supposed to run both > > > checkpatches.sh and check-git-log.sh. > > > I am pretty sure I missed this

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:29, Bruce Richardson: > On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > 29/01/2019 16:30, Ferruh Yigit: > > >> Fixes line commit id length defined as 12 in fixline alias: > > >> fixline = log -1 --abbrev=12 --format=

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > 29/01/2019 16:30, Ferruh Yigit: > >> Fixes line commit id length defined as 12 in fixline alias: > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > >> > >> Check

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:17, Ferruh Yigit: > On 1/30/2019 9:58 AM, David Marchand wrote: > > The contributing guide does indicate you are supposed to run both > > checkpatches.sh and check-git-log.sh. > > I am pretty sure I missed this second step in the past.. > > > > How about calling check-git-log.sh from

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 11:17:00AM +, Ferruh Yigit wrote: > On 1/30/2019 9:58 AM, David Marchand wrote: > > On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > > > >> On 1/29/2019 5:34 PM, David Marchand wrote: > >>> On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit > >> wrote: > >>> > Fix

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Ferruh Yigit
On 1/30/2019 9:58 AM, David Marchand wrote: > On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > >> On 1/29/2019 5:34 PM, David Marchand wrote: >>> On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit >> wrote: >>> Fixes line commit id length defined as 12 in fixline alias: fixline = log -1

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Ferruh Yigit
On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > 29/01/2019 16:30, Ferruh Yigit: >> Fixes line commit id length defined as 12 in fixline alias: >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' >> >> Check if the Fixes line commit id length matches the defined value. > > This ch

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread David Marchand
On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > On 1/29/2019 5:34 PM, David Marchand wrote: > > On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit > wrote: > > > >> Fixes line commit id length defined as 12 in fixline alias: > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-29 Thread Thomas Monjalon
29/01/2019 16:30, Ferruh Yigit: > Fixes line commit id length defined as 12 in fixline alias: > fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > > Check if the Fixes line commit id length matches the defined value. This check was missing on purpose, in order to not be too str

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-29 Thread Ferruh Yigit
On 1/29/2019 5:34 PM, David Marchand wrote: > On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit wrote: > >> Fixes line commit id length defined as 12 in fixline alias: >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' >> >> Check if the Fixes line commit id length matches the defi

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-29 Thread David Marchand
On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit wrote: > Fixes line commit id length defined as 12 in fixline alias: > fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > > Check if the Fixes line commit id length matches the defined value. > Can't git decide to report a longer st

[dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-29 Thread Ferruh Yigit
Fixes line commit id length defined as 12 in fixline alias: fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' Check if the Fixes line commit id length matches the defined value. Signed-off-by: Ferruh Yigit --- Cc: Qi Zhang --- devtools/check-git-log.sh | 5 + 1 file chang