Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-17 Thread Neil Horman
On Mon, Feb 17, 2020 at 02:23:15PM +, Ray Kinsella wrote: > > > On 14/02/2020 20:48, Neil Horman wrote: > > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > >> On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > >>> On Thu, Feb 13, 2020 at 05:40:43PM +, Ray K

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-17 Thread Ray Kinsella
On 14/02/2020 20:48, Neil Horman wrote: > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: >> On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: >>> On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: On 05/02/2020 11:32, Neil Horman wrote: >>>

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-15 Thread Neil Horman
On Fri, Feb 14, 2020 at 09:52:53PM +, Bruce Richardson wrote: > On Fri, Feb 14, 2020 at 03:48:48PM -0500, Neil Horman wrote: > > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > > > On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > > > > On Thu, Feb 13, 2020 at 0

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-14 Thread Bruce Richardson
On Fri, Feb 14, 2020 at 03:48:48PM -0500, Neil Horman wrote: > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > > On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > > > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > > > > > > > > > > On 05/02/20

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-14 Thread Neil Horman
On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > > > > > > > On 05/02/2020 11:32, Neil Horman wrote: > > > > On Wed, Feb 05, 2020 at 11:04:29AM +

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-14 Thread Bruce Richardson
On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > > > > On 05/02/2020 11:32, Neil Horman wrote: > > > On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote: > > >> On Tue, 2020-02-04 at 07:02 -0500, Neil Horm

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-13 Thread Neil Horman
On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: > > > On 05/02/2020 11:32, Neil Horman wrote: > > On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote: > >> On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote: > But if we can do the versioning in the master, LTS can b

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-13 Thread Ray Kinsella
On 05/02/2020 11:32, Neil Horman wrote: > On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote: >> On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote: But if we can do the versioning in the master, LTS can backport it and can have mature version of that API in LTS witho

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-05 Thread Neil Horman
On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote: > On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote: > > > But if we can do the versioning in the master, LTS can backport it > > > and can have > > > mature version of that API in LTS without breaking the existing > > > users. > > >

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-05 Thread Luca Boccassi
On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote: > > But if we can do the versioning in the master, LTS can backport it > > and can have > > mature version of that API in LTS without breaking the existing > > users. > > > > But why bother? The only thing you've changed is the version > tagg

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-04 Thread Neil Horman
On Mon, Feb 03, 2020 at 12:53:28PM +, Ferruh Yigit wrote: > On 2/2/2020 6:53 PM, Neil Horman wrote: > > On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: > >> Duplicated the existing symbol and versioned one as experimental and > >> other as stable. > >> > >> Created VERSION_SYMBOL_

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-03 Thread Ferruh Yigit
On 2/2/2020 6:53 PM, Neil Horman wrote: > On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: >> Duplicated the existing symbol and versioned one as experimental and >> other as stable. >> >> Created VERSION_SYMBOL_EXPERIMENTAL helper macro. >> >> Updated the 'check-experimental-syms.sh'

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-02 Thread Neil Horman
On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: > Duplicated the existing symbol and versioned one as experimental and > other as stable. > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-experimental-syms.sh' buildtool, which was > complaining that the sy

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
On 1/29/2020 4:30 PM, Andrzej Ostruszka wrote: > On 1/29/20 5:25 PM, Ferruh Yigit wrote: >> On 1/29/2020 2:57 PM, Andrzej Ostruszka wrote: > [...] >>> I've now noticed that LPM, Distributor and Timer libraries no longer use >>> function versioning but have it still set in their meson.build. >> >> R

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Andrzej Ostruszka
On 1/29/20 5:25 PM, Ferruh Yigit wrote: > On 1/29/2020 2:57 PM, Andrzej Ostruszka wrote: [...] >> I've now noticed that LPM, Distributor and Timer libraries no longer use >> function versioning but have it still set in their meson.build. > > Right, I can remove them. Bruce was kind enough to give

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
On 1/29/2020 2:57 PM, Andrzej Ostruszka wrote: > On 1/29/20 1:29 PM, Ferruh Yigit wrote: > [...] >> Updated meson build system to allow the versioning, >> 'use_function_versioning = true', not sure why it was disabled by >> default. > > AFAIR this is to save build time with meson. By default stat

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Andrzej Ostruszka
On 1/29/20 1:29 PM, Ferruh Yigit wrote: [...] > Updated meson build system to allow the versioning, > 'use_function_versioning = true', not sure why it was disabled by > default. AFAIR this is to save build time with meson. By default static build is made and from the objects from the static buil

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Bruce Richardson
On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: > Duplicated the existing symbol and versioned one as experimental and > other as stable. > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-experimental-syms.sh' buildtool, which was > complaining that the sy

[dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
Duplicated the existing symbol and versioned one as experimental and other as stable. Created VERSION_SYMBOL_EXPERIMENTAL helper macro. Updated the 'check-experimental-syms.sh' buildtool, which was complaining that the symbol is in EXPERIMENTAL tag in .map file but it is not in the .experimental