Re: [dpdk-dev] [PATCH v4] doc: update mlx5 flow count limitations

2017-10-19 Thread Nélio Laranjeiro
On Thu, Oct 19, 2017 at 09:09:26AM +0300, Ori Kam wrote: > Signed-off-by: Ori Kam > Acked-by: Shahaf Shuler > --- > v4: > * Clarify which OFED versionis required. > > v3: > * Remove unnecessary line. > > doc/guides/nics/mlx5.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > d

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Li, Xiaoyun
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 19, 2017 14:59 > To: Li, Xiaoyun > Cc: Ananyev, Konstantin ; Richardson, > Bruce ; dev@dpdk.org; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1

Re: [dpdk-dev] DPDK 1705 on libpcap drivers has drops?

2017-10-19 Thread Kuusisaari, Juhamatti
Hi, > We are testing on 1705 over libpcap driver and unfortunately we are seeing > surprisingly large drops. They are seen with low rate/ping randomly and with > high rate the throughput is very limited (even 30 % drops seen) compared to > our reference system on DPDK 1.7.1. The only thing change

Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, October 17, 2017 2:59 PM > To: Richardson, Bruce ; De Lara Guarch, > Pablo > Cc: dev@dpdk.org; mstolarchuk > Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key > > 18/08/2017 22

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Thomas Monjalon
19/10/2017 09:51, Li, Xiaoyun: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 19/10/2017 04:45, Li, Xiaoyun: > > > Hi > > > > > > > > > > > > The significant change of this patch is to call a function > > > > > > pointer for packet size > 128 (RTE_X86_MEMCPY_THRESH). > > > > > The perf dr

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-19 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 09:21:52PM +0200, Thomas Monjalon wrote: > 18/10/2017 21:13, Aaron Conole: > > Luca Boccassi writes: > > > On Wed, 2017-10-18 at 15:20 +0100, Bruce Richardson wrote: > > >> On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: > > >> > On Wed, Oct 18, 2017 at 11

Re: [dpdk-dev] [PATCH 0/8] Support sample applications with new build system

2017-10-19 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 06:11:51PM +0100, Luca Boccassi wrote: > On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote: > > This patchset enables sample apps to be used with the new meson build > > system. The work is really three-fold: > > > > * fix issues and pre-requisites to get the sample

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Li, Xiaoyun
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 19, 2017 16:34 > To: Li, Xiaoyun > Cc: Ananyev, Konstantin ; Richardson, > Bruce ; dev@dpdk.org; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1

[dpdk-dev] [PATCH] eal: avoid error for non-existent default PMD path

2017-10-19 Thread Bruce Richardson
If the default location for the PMD .so files does not exist, it should not be treated as a fatal error condition like an incorrect path on the command line. Therefore check that the path exists and is a directory before adding it to the list of paths to check for PMDs. Signed-off-by: Bruce Richar

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Li, Xiaoyun > Sent: Thursday, October 19, 2017 9:51 AM > To: Thomas Monjalon > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; dev@dpdk.org; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@mellanox.com > Subject: RE: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dis

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Thomas Monjalon
19/10/2017 10:50, Li, Xiaoyun: > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, October 19, 2017 16:34 > > To: Li, Xiaoyun > > Cc: Ananyev, Konstantin ; Richardson, > > Bruce ; dev@dpdk.org; Lu, Wenzhuo > > ; Zhang, Helin ; > > ophi...@me

[dpdk-dev] [PATCH] net/i40e: add support for packet template to flow director

2017-10-19 Thread Kirill Rybalchenko
For complex packets use raw flow type with pre-constructed packet buffer instead of creating a packet internally in PMD. Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/i40e_ethdev.h| 9 + drivers/net/i40e/i40e_fdir.c | 56 - drive

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 14b9c53..fcabd5e 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -61,6 +61,7 @@ > #include > #include > #include > +#include > > #include "ixgbe_log

[dpdk-dev] [PATCH] net/failsafe: fix PCI devices init

2017-10-19 Thread Raslan Darawsheh
When trying to attach a port as a sub-device, the ethdev port was compared with devargs. In the case of a PCI device, the name in devargs is the PCI address. And since DPDK 17.08, the devargs name of the underlying device was used to match an ethdev port: a1e7c17555e8 ("ethdev: use device n

[dpdk-dev] [PATCH v2] doc: update release note for DPAA PMD support

2017-10-19 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- v2: Changed the location of the message. It was earlier between other Crypto PMDs. As suggested by Pablo. doc/guides/rel_notes/release_17_11.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guid

Re: [dpdk-dev] [PATCH v4 06/12] ethdev: support security APIs

2017-10-19 Thread Ananyev, Konstantin
Hi guys, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Saturday, October 14, 2017 11:17 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > Nicolau, Radu ; bor...@mellanox.com; > avia...@mellanox.com; tho...@mo

[dpdk-dev] [PATCH] app/testpmd: fix integer overflow

2017-10-19 Thread Jasvinder Singh
Fixed integer overflow by casting link_params.link_speed to uint64_t type. CID 195016 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Signed-off-by: Jasvinder Singh --- app/test-pmd/tm.c | 2 +- 1 fil

[dpdk-dev] [PATCH] net/softnic: fix integer overflow

2017-10-19 Thread Jasvinder Singh
Fixed integer overflow by casting hard_rate to uint64_t type. CID 195020 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Fixes: 8316b9816b79 ("net/softnic: support traffic management") Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_tm.c | 2 +- 1 file

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Bruce Richardson
On Thu, Oct 19, 2017 at 11:00:33AM +0200, Thomas Monjalon wrote: > 19/10/2017 10:50, Li, Xiaoyun: > > > > > -Original Message- > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Thursday, October 19, 2017 16:34 > > > To: Li, Xiaoyun > > > Cc: Ananyev, Konstantin ; Richar

Re: [dpdk-dev] [PATCH v4 01/12] lib/rte_security: add security library

2017-10-19 Thread Ananyev, Konstantin
> + > +/** > + * Security context for crypto/eth devices > + * > + * Security instance for each driver to register security operations. > + * The application can get the security context from the crypto/eth device id > + * using the APIs rte_cryptodev_get_sec_ctx()/rte_eth_dev_get_sec_ctx() > + *

[dpdk-dev] [PATCH] examples/power: add turbo commands to help text

2017-10-19 Thread Marko Kovacevic
From: David Hunt Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI") Signed-off-by: Marko Kovacevic --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/vm_power_manager/guest_cli/vm

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Ananyev, Konstantin
Hi Jia, > > Hi > > > On 10/13/2017 9:02 AM, Jia He Wrote: > > Hi Jerin > > > > > > On 10/13/2017 1:23 AM, Jerin Jacob Wrote: > >> -Original Message- > >>> Date: Thu, 12 Oct 2017 17:05:50 + > >>> > [...] > >> On the same lines, > >> > >> Jia He, jie2.liu, bing.zhao, > >> > >> Is thi

Re: [dpdk-dev] [PATCH] example: add new service cores sample application

2017-10-19 Thread Van Haaren, Harry
> From: Eads, Gage > Sent: Monday, September 25, 2017 5:32 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] example: add new service cores sample > application > > Neat example. Looks good overall, I just have a few questions. > > > +#define PROFILE_SERVICE_PER_C

Re: [dpdk-dev] [PATCH] example: add new service cores sample application

2017-10-19 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 13, 2017 11:24 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH] example: add new service cores sample > application > > 14/10/2017 00:20, Thomas Monjalon: > > 25/09/2017 15

[dpdk-dev] [PATCH 0/2] flow rules example

2017-10-19 Thread Ori Kam
The rte flow is a relative new issue and is missing an example. This patch set, adds a simple example application for generating a basic ipv4 rule. Ori Kam (2): examples/flow_filtering: demo of simple rte flow doc: add flow_filtering example documentation doc/guides/sample_app_ug/flow_filte

Re: [dpdk-dev] [PATCH] doc: add basic howto for flow API

2017-10-19 Thread Mcnamara, John
> -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Thursday, October 19, 2017 7:56 AM > To: adrien.mazarg...@6wind.com; Mcnamara, John > Cc: dev@dpdk.org; or...@mellanox.com > Subject: [PATCH] doc: add basic howto for flow API > > As the rte flow is a new complex m

[dpdk-dev] [PATCH 1/2] examples/flow_filtering: demo of simple rte flow

2017-10-19 Thread Ori Kam
This application shows a simple usage of the rte_flow API for hardware filtering offloading. In this demo we are filtering specific IP to specific target queue, while sending all the rest of the packets to other queue. Signed-off-by: Ori Kam --- examples/flow_filtering/Makefile | 17 +++

[dpdk-dev] [PATCH 2/2] doc: add flow_filtering example documentation

2017-10-19 Thread Ori Kam
Signed-off-by: Ori Kam --- doc/guides/sample_app_ug/flow_filtering.rst | 539 1 file changed, 539 insertions(+) create mode 100644 doc/guides/sample_app_ug/flow_filtering.rst diff --git a/doc/guides/sample_app_ug/flow_filtering.rst b/doc/guides/sample_app_ug/flow_f

Re: [dpdk-dev] [PATCH] net/failsafe: fix PCI devices init

2017-10-19 Thread Gaëtan Rivet
Hello Raslan, Thanks for spotting the issue and fixing it. Small nit below. On Thu, Oct 19, 2017 at 12:11:52PM +0300, Raslan Darawsheh wrote: > When trying to attach a port as a sub-device, the ethdev port > was compared with devargs. > In the case of a PCI device, the name in devargs is the PCI

[dpdk-dev] [PATCH v2] example: add new service cores sample application

2017-10-19 Thread Harry van Haaren
This commit adds a new sample app, which showcases the value of running services. In particular it allows the application to dynamically schedule services to service-cores. The sample app itself registers a number of dummy services, and applies different profiles to them at runtime. Note that this

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
Hi, Comments inline On 10/18/2017 10:29 PM, Ananyev, Konstantin wrote: Hi Radu, Few comments from me below. Konstantin +#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms)\ +{ \ + uint32_t cnt =

Re: [dpdk-dev] [PATCH v2] doc: update release note for DPAA PMD support

2017-10-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Thursday, October 19, 2017 10:34 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net; De Lara > Guarch, Pablo ; Shreyansh Jain > > Subject: [dpdk-dev] [PATCH v2] doc: update rel

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Wednesday, October 18, 2017 10:49 PM > To: Ivan Malov ; Daly, Lee ; > tho...@monjalon.net > Cc: dev@dpdk.org; Kozak, KubaX > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API > > On 10/18/2017 4:10

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> > > >> > >> + > >> +static int > >> +ixgbe_crypto_update_mb(void *device __rte_unused, > >> + struct rte_security_session *session, > >> + struct rte_mbuf *m, void *params __rte_unused) > >> +{ > >> + struct ixgbe_crypto_session *ic_session = > >> + g

[dpdk-dev] [PATCH] pci: fix check uio bind

2017-10-19 Thread Jianfeng Tan
When checking if any devices bound to uio, we did not exclud those which are blacklisted (or in the case that a whitelist is specified). This patch fixes it by only checking whitelisted devices. Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") Signed-off-by: Jianfeng Tan --- lib/librte_ea

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Zhao, Bing
Hi, On 2017/10/19 18:02, Ananyev, Konstantin wrote: Hi Jia, Hi On 10/13/2017 9:02 AM, Jia He Wrote: Hi Jerin On 10/13/2017 1:23 AM, Jerin Jacob Wrote: -Original Message- Date: Thu, 12 Oct 2017 17:05:50 + [...] On the same lines, Jia He, jie2.liu, bing.zhao, Is this pa

Re: [dpdk-dev] [PATCH] pci: fix check uio bind

2017-10-19 Thread Gaëtan Rivet
Hi Jianfeng, On Thu, Oct 19, 2017 at 11:18:29AM +, Jianfeng Tan wrote: > When checking if any devices bound to uio, we did not exclud > those which are blacklisted (or in the case that a whitelist > is specified). > > This patch fixes it by only checking whitelisted devices. > > Fixes: 815c7

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Nicolau, Radu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 12:04 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > san

Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Wednesday, October 18, 2017 5:19 PM > To: Nicolau, Radu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw > > On 18/10/2017 13:06, Radu Nicolau wro

[dpdk-dev] [PATCH v9 1/2] doc: add generic compilation doc for all sample apps

2017-10-19 Thread Marko Kovacevic
From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

[dpdk-dev] [PATCH v9 2/2] doc: add new introduction to sample app guides

2017-10-19 Thread Marko Kovacevic
Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic --- doc/guides/sample_app_ug/intro.rst | 153 +++-- 1 file changed, 113 insertions(+), 40 deletions(-) diff --git a/doc/guides/sample_app_ug/intro.rst b/doc/guides/sample_app

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 12:57 PM > To: Ananyev, Konstantin ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; >

Re: [dpdk-dev] [PATCH] examples/power: add turbo commands to help text

2017-10-19 Thread Hunt, David
Hi Marko, On 19/10/2017 10:34 AM, Marko Kovacevic wrote: From: David Hunt Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI") Signed-off-by: Marko Kovacevic --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, October 19, 2017 1:17 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com;

Re: [dpdk-dev] [PATCH] ipsec_secgw: added cmdline option for jumbo frames and switched to the new offload API.

2017-10-19 Thread De Lara Guarch, Pablo
Hi Radu, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Wednesday, October 18, 2017 12:55 PM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; > Nicolau, Radu > Subject: [dpdk-dev] [PATCH] ipsec_secgw: added cmdline option for jumbo > fra

[dpdk-dev] [PATCH 0/6] net/mlx5: fixes

2017-10-19 Thread Nelio Laranjeiro
Some fixes on bugs and wrong behaviors. This series applies on top of: http://dpdk.org/patch/30351 Nelio Laranjeiro (6): net/mlx5: fix segfault on flow creation net/mlx5: fix work queue array size net/mlx5: fix drop flows when port is stopped net/mlx5: fix flow director drop action net/

[dpdk-dev] [PATCH 6/6] net/mlx5: fix allmulti mode

2017-10-19 Thread Nelio Laranjeiro
All multi is not adding unicast flows which cause unicast packets to be dropped by the NIC. Fixes: 6a6b6828fe6a ("net/mlx5: use flow to enable all multi mode") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 131 1 file changed, 66

[dpdk-dev] [PATCH 3/6] net/mlx5: fix drop flows when port is stopped

2017-10-19 Thread Nelio Laranjeiro
Fix the drop queue rule creation when the port is stopped. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH 4/6] net/mlx5: fix flow director drop action

2017-10-19 Thread Nelio Laranjeiro
Flow director drop action as not been brought back with the new implementation on top of rte flow. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 25 - 1 file changed, 16

[dpdk-dev] [PATCH 2/6] net/mlx5: fix work queue array size

2017-10-19 Thread Nelio Laranjeiro
Indirection table size must be in log to communicate with verbs when the number of queue is not a power of two, the maximum indirection table size is use, but not converted to log2. This makes a memory corruption. Fixes: 4c7a0f5ff876 ("net/mlx5: make indirection tables shareable") Signed-off-by:

[dpdk-dev] [PATCH 5/6] net/mlx5: fix mark action with drop action

2017-10-19 Thread Nelio Laranjeiro
Marking a packet which will not be received by the NIC is useless, even if this action remains possible, it blocks the creation of the flow counter which embed a mark action to a drop queue to be created. Fixes: 31ba9997f11a ("net/mlx5: fully convert a flow to verbs in validate") Signed-off-by: N

[dpdk-dev] [PATCH 1/6] net/mlx5: fix segfault on flow creation

2017-10-19 Thread Nelio Laranjeiro
When ports are stopped, the hash Rx queue should not be created. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
On 10/19/2017 1:16 PM, Ananyev, Konstantin wrote: -Original Message- From: Nicolau, Radu Sent: Thursday, October 19, 2017 12:57 PM To: Ananyev, Konstantin ; Akhil Goyal ; dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agra...@nxp.com; bor...@mellanox.com; avia...@

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
On 10/19/2017 1:29 PM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin Sent: Thursday, October 19, 2017 1:17 PM To: Nicolau, Radu ; Akhil Goyal ; dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 2:14 PM > To: Ananyev, Konstantin ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > s

[dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails

2017-10-19 Thread Aaron Conole
From: Michał Mirosław Signed-off-by: Michał Mirosław Reviewed-by: Jingjing Wu --- This is cherry picked from commit d75547718c87 ("net/i40e: return errno when interrupt setup fails") and applies cleanly. This is just a backport request. drivers/net/i40e/i40e_ethdev.c | 5 +++--

[dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

2017-10-19 Thread luca . boccassi
From: Luca Boccassi When VF reset will be supported by drivers, the API will most likely have to return -EAGAIN to avoid blocking when the VF cannot be reset because the PF is down. Document it immediately even if it's not yet supported, so that users and developers can already take into account

[dpdk-dev] [PATCH 1/2] ethdev: document rte_eth_dev_reset return codes

2017-10-19 Thread luca . boccassi
From: Luca Boccassi This new function returns 0 on success and various error codes on different failures. Attempt to document them. Signed-off-by: Luca Boccassi --- lib/librte_ether/rte_ethdev.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/lib

Re: [dpdk-dev] [PATCH] net/virtio: fix an incorrect behavior of device stop/start

2017-10-19 Thread Yuanhan Liu
On Fri, Sep 01, 2017 at 03:14:26PM +0800, Tiwei Bie wrote: > > > > On Tue, Aug 29, 2017 at 04:26:01PM +0800, Tiwei Bie wrote: > > > > > After starting a device, the driver shouldn't deliver the > > > > > packets that already existed in the device before it is > > > > > started to the applications.

Re: [dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails

2017-10-19 Thread Yuanhan Liu
On Thu, Oct 19, 2017 at 09:22:30AM -0400, Aaron Conole wrote: > From: Michał Mirosław > > Signed-off-by: Michał Mirosław > Reviewed-by: Jingjing Wu > --- > This is cherry picked from commit d75547718c87 ("net/i40e: return errno > when interrupt setup fails") and applies cleanly. This is just a

[dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates

2017-10-19 Thread Xueming Li
The target is to make testpmd flexible to generate all kinds of packet in just one line. Examples: # send UDP packet to port 0 queue 0 testpmd> scapy 0 Ether()/IP()/UDP()/"hello_world" # send 4 L3 VXLAN packets with inner UDP dport 1-4 to port 1 queue 1-4, one packet per queue testpmd> scapy 1

[dpdk-dev] [RFC PATCH 1/2] app/testpmd: add packet template

2017-10-19 Thread Xueming Li
Txonly forwarding mode will check templates, if avaialbe, use templates for each queue. Signed-off-by: Xueming Li --- app/test-pmd/testpmd.c | 3 +++ app/test-pmd/testpmd.h | 1 + app/test-pmd/txonly.c | 42 ++ 3 files changed, 30 insertions(+), 16 dele

[dpdk-dev] [RFC PATCH 2/2] app/testpmd: add scapy command as pkt template

2017-10-19 Thread Xueming Li
Invoke scapy to generate packet templates for each queue of specific port, command format: scapy Example: scapy 0 Ether()/IP()/GRE()/IP()/UDP(dport=(2,5))/"cool" Signed-off-by: Xueming Li --- app/test-pmd/Makefile | 5 +++ app/test-pmd/cmdline.c | 99 +

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Ananyev, Konstantin
> > Hi, > > On 2017/10/19 18:02, Ananyev, Konstantin wrote: > > > > Hi Jia, > > > >> > >> Hi > >> > >> > >> On 10/13/2017 9:02 AM, Jia He Wrote: > >>> Hi Jerin > >>> > >>> > >>> On 10/13/2017 1:23 AM, Jerin Jacob Wrote: > -Original Message- > > Date: Thu, 12 Oct 2017 17:05:50 +00

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Nicolau, Radu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 2:23 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > sand

Re: [dpdk-dev] [PATCH v8 1/4] librte_flow_classify: add flow classify library

2017-10-19 Thread Singh, Jasvinder
> + > +struct acl_keys { > + struct rte_table_acl_rule_add_params key_add; /**< add key */ > + struct rte_table_acl_rule_delete_params key_del; /**< delete > key */ > +}; > + > +struct rte_flow_classify_rule { > + uint32_t id; /**< unique ID of classify rule */ > + enum rte_flow_

[dpdk-dev] [PATCH v2] net/failsafe: improve stats accuracy

2017-10-19 Thread Matan Azrad
The stats_get API was changed to signal a potential failure to read stats. Furthermore, some PMDs are able to provide statistics even after a removal event occurred. Considering this, the fail-safe can try to access the latest statistics of a PMD to improve statistics accuracy. Attempt an ultimat

Re: [dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails

2017-10-19 Thread Aaron Conole
Yuanhan Liu writes: > On Thu, Oct 19, 2017 at 09:22:30AM -0400, Aaron Conole wrote: >> From: Michał Mirosław >> >> Signed-off-by: Michał Mirosław >> Reviewed-by: Jingjing Wu >> --- >> This is cherry picked from commit d75547718c87 ("net/i40e: return errno >> when interrupt setup fails") and a

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> > > > > > >>> > > > >>> + > > > >>> +static int > > > >>> +ixgbe_crypto_update_mb(void *device __rte_unused, > > > >>> + struct rte_security_session *session, > > > >>> +struct rte_mbuf *m, void *params __rte_unused) > > { > > > > > > > > > >

Re: [dpdk-dev] Does cxgbe support multiple processes mode

2017-10-19 Thread Rahul Lakkireddy
On Tuesday, October 10/17/17, 2017 at 23:26:19 -0700, He JianJun wrote: > Does cxgbe support multiple processes mode? If not, how can we implement it? > > I tried with 17.08 code, secondary process will crash at sge.c line 1098. > t4_eth_xmit() > because txq->eth_dev->data is NULL. > > I am guess

Re: [dpdk-dev] [PATCH 1/2] ethdev: document rte_eth_dev_reset return codes

2017-10-19 Thread Remy Horton
On 19/10/2017 14:48, luca.bocca...@gmail.com wrote: From: Luca Boccassi This new function returns 0 on success and various error codes on different failures. Attempt to document them. Signed-off-by: Luca Boccassi --- lib/librte_ether/rte_ethdev.h | 8 1 file changed, 8 insertions(+

Re: [dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

2017-10-19 Thread Remy Horton
On 19/10/2017 14:48, luca.bocca...@gmail.com wrote: Document it immediately even if it's not yet supported, so that users and developers can already take into account about this use case, and thus avoid an API-incompatible change later on. I'm not sure about documenting unimplemented features,

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Ivan Malov
On Thu, Oct 19, 2017 at 11:06:37AM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Wednesday, October 18, 2017 10:49 PM > > To: Ivan Malov ; Daly, Lee ; > > tho...@monjalon.net > > Cc: dev@dpdk.org; Kozak, KubaX > > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH v2] net/failsafe: improve stats accuracy

2017-10-19 Thread Gaëtan Rivet
Hello Matan, Adding the time delta should have been done in a separate commit. Can you please divide this patch in two? The first one will only attempt the ultimate stat read, the second one would add the delay warning. Small nit below for your v3. On Thu, Oct 19, 2017 at 02:31:54PM +, Mata

Re: [dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates

2017-10-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li > Sent: Thursday, October 19, 2017 3:07 PM > To: Wu, Jingjing > Cc: Xueming Li ; dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates Hi, First off - cool to make DPDK more dynamic with Scapy

[dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Radu Nicolau
Added cmdline option for jumbo frames. Switched port initialization to the new offload API. Signed-off-by: Radu Nicolau --- v2: updated commit message doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 32 +--- 2 files ch

Re: [dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread De Lara Guarch, Pablo
Hi Radu, > -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 4:26 PM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; De Lara > Guarch, Pablo ; Nicolau, Radu > > Subject: [PATCH v2] examples/ipsec_secgw: support jumbo frames > > Added cmdline option for jumbo

Re: [dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Nicolau, Radu
Hi, I did, sorry :) Working on them now. > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, October 19, 2017 4:40 PM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Gonzalez Monroy, Sergio > Subject: RE: [PATCH v2] examples/ipsec_secgw: support jumbo frames > > Hi Radu, > > >

[dpdk-dev] [PATCH v3] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Radu Nicolau
Added cmdline option for jumbo frames. Switched port initialization to the new offload API. Signed-off-by: Radu Nicolau --- v2: updated commit message v3: addressed feedback doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 35 +

[dpdk-dev] [PATCH v1 0/4] net/mlx4: RSS fixes

2017-10-19 Thread Adrien Mazarguil
This series enforces WQ creation order to make sure WQNs are assigned sequentially to Rx queues and fixes a few minor issues related to initialization code. This addresses l3fwd-power startup issues. Adrien Mazarguil (4): net/mlx4: use dedicated list iterator net/mlx4: fix useless flow rules

[dpdk-dev] [PATCH v1 1/4] net/mlx4: use dedicated list iterator

2017-10-19 Thread Adrien Mazarguil
Dumb unconditional iteration on flow rules should be performed using the dedicated macro. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net

[dpdk-dev] [PATCH v1 2/4] net/mlx4: fix useless flow rules synchronization

2017-10-19 Thread Adrien Mazarguil
According to the original commit, Rx queues cannot be created nor destroyed while the device is started. Synchronizing flow rules during such events is unnecessary as it occurs later when starting the device. Fixes: 79770826499b ("net/mlx4: drop live queue reconfiguration support") Signed-off-by:

[dpdk-dev] [PATCH v1 3/4] net/mlx4: fix indirection table error rollback

2017-10-19 Thread Adrien Mazarguil
In case of error occurring while setting up indirection table and related RSS context resources, intermediate objects are not cleaned up. Moreover although unlikely, an error other than EINVAL (e.g. ENOMEM) may be returned. A description of mlx4_rss_attach()'s return value is also missing. Fixes

[dpdk-dev] [PATCH v1 4/4] net/mlx4: relax Rx queue configuration order

2017-10-19 Thread Adrien Mazarguil
Various hardware limitations apply to RSS indirection tables, one of them being they must be an exact 1:1 mapping of the configured Rx queue indices. While this restriction is enforced when creating RSS flow rules, it is not the case when Rx queues themselves are created; underlying WQ numbers are

Re: [dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

2017-10-19 Thread Luca Boccassi
On Thu, 2017-10-19 at 15:53 +0100, Remy Horton wrote: > On 19/10/2017 14:48, luca.bocca...@gmail.com wrote: > > Document it immediately even if it's not yet supported, so that > > users > > and developers can already take into account about this use case, > > and > > thus avoid an API-incompatible

Re: [dpdk-dev] [PATCH v3] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Aviad Yehezkel
On 10/19/2017 6:58 PM, Radu Nicolau wrote: Added cmdline option for jumbo frames. Switched port initialization to the new offload API. Signed-off-by: Radu Nicolau --- v2: updated commit message v3: addressed feedback doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-sec

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Ivan Malov
On 10/12/2017 2:31 PM, Lee Daly wrote: > From: Lee > > Fix xstats functions, rte_eth_xstats_get_names_by_id() > and rte_eth_xstats_get_by_id(), in current implementation > ethdev level reads all xstat values and filters out > the ones requested by the application. This behavior doesn't > benefit f

Re: [dpdk-dev] DPDK 1705 on libpcap drivers has drops?

2017-10-19 Thread Ferruh Yigit
On 10/19/2017 1:03 AM, Kuusisaari, Juhamatti wrote: > > Hi, > >> We are testing on 1705 over libpcap driver and unfortunately we are seeing >> surprisingly large drops. They are seen with low rate/ping randomly and with >> high rate the throughput is very limited (even 30 % drops seen) compared t

[dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files

2017-10-19 Thread Bruce Richardson
Both Linux and BSD EALs should provide exactly the same set of functions to the user, even if in some cases the function is a stub returning ENOTSUP. Because of this we should only need a single version.map file for all of EAL - not one each for Linux and FreeBSD. Unfortunately, there was some inc

[dpdk-dev] [PATCH 3/5] eal: merge bsdapp and linuxapp interrupt headers

2017-10-19 Thread Bruce Richardson
The linuxapp and bsdapp interrupt header files are now identical, so merge them into a common file in common/include. Signed-off-by: Bruce Richardson --- lib/librte_eal/bsdapp/eal/Makefile | 2 +- lib/librte_eal/common/Makefile | 3 +- .../include/rte_eal_

[dpdk-dev] [PATCH 2/5] eal/bsdapp: fix missing interrupt stub functions

2017-10-19 Thread Bruce Richardson
A number of interrupt functions only existed on Linux. Adding in stubs for these functions corrects this omission, and allows the map files for both Linux and FreeBSD to be identical. CC: sta...@dpdk.org Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") Signed-off-by: Bruce Richardson --- l

[dpdk-dev] [PATCH 4/5] eal: mark internal interrupts file as such to doxygen

2017-10-19 Thread Bruce Richardson
Put a file-level comment on rte_eal_interrupts.h to mark it as an internal only header. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_eal_interrupts.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/include/rte_eal_interrupts.h b/lib/lib

[dpdk-dev] [PATCH 1/5] eal/bsdapp: align interrupt include file with Linux version

2017-10-19 Thread Bruce Richardson
The bsdapp-specific rte_interrupts.h file does not need to be different from the linuxapp one, as there is nothing Linux specific in the APIs or data structures. This will then allow us to merge the files in a common location to avoid duplication. Signed-off-by: Bruce Richardson --- .../bsdapp/e

[dpdk-dev] [PATCH 5/5] eal: use a single version map file

2017-10-19 Thread Bruce Richardson
Since the functions exported by DPDK EAL on all OS's should be identical, we should not need separate function version files for each OS. Therefore move existing version files to the top-level EAL directory. Signed-off-by: Bruce Richardson --- lib/librte_eal/bsdapp/eal/Makefile |

Re: [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files

2017-10-19 Thread Bruce Richardson
On Thu, Oct 19, 2017 at 05:36:24PM +0100, Bruce Richardson wrote: > Both Linux and BSD EALs should provide exactly the same set of functions > to the user, even if in some cases the function is a stub returning > ENOTSUP. Because of this we should only need a single version.map file for > all of EA

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Ferruh Yigit
On 10/19/2017 8:03 AM, Ivan Malov wrote: > On Thu, Oct 19, 2017 at 11:06:37AM +, Van Haaren, Harry wrote: >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >>> Sent: Wednesday, October 18, 2017 10:49 PM >>> To: Ivan Malov ; Daly, Lee ; >>> tho...@monjalon.net >>> Cc: dev@dpd

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] > Sent: Monday, October 16, 2017 11:42 AM > To: Gonzalez Monroy, Sergio ; > dev@dpdk.org; De Lara Guarch, Pablo ; > avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...@nxp.com

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-19 Thread Aviad Yehezkel
Yes, just finished my testing. Will send v2 in a moment and Akhil will send v5 rebased above them for rte_security. Thanks! On 10/19/2017 9:16 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] Sent: Monday, October 16, 201

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-19 Thread Aviad Yehezkel
Solved that issue, this was an issue with mlx5 PMD with the new inline ipsec code. The PMD wasn't updating mbuf->data_len correctly. Thanks! On 10/16/2017 3:03 PM, Sergio Gonzalez Monroy wrote: On 16/10/2017 12:44, Aviad Yehezkel wrote: On 10/16/2017 12:43 PM, Sergio Gonzalez Monroy wrote:

[dpdk-dev] [PATCH v2 4/6] examples/ipsec-secgw: add correct padding to tunnel mode

2017-10-19 Thread aviadye
From: Aviad Yehezkel Issue: None Signed-off-by: Aviad Yehezkel -- v2: * Fix commit message --- examples/ipsec-secgw/esp.c | 51 ++ 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c

  1   2   >