[dpdk-dev] [PATCH v2 0/6] Introduce AF_XDP PMD

2019-03-19 Thread Xiaolong Ye
Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support i

[dpdk-dev] [PATCH v2 2/6] lib/mbuf: introduce helper to create mempool with flags

2019-03-19 Thread Xiaolong Ye
This allows applications to create mbuf mempool with specific flags such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mbuf/rte_mbuf.c | 29 +++- lib/librte_mbuf/rte_mbuf.h | 45 ++

[dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

[dpdk-dev] [PATCH v2 3/6] lib/mempool: allow page size aligned mempool

2019-03-19 Thread Xiaolong Ye
Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mempool/rte_mempool.c | 3 +++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 4 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempo

[dpdk-dev] [PATCH v2 4/6] net/af_xdp: use mbuf mempool for buffer management

2019-03-19 Thread Xiaolong Ye
Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be allocated from rte_mempool can be convert to xdp_desc's address and vice versa. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 127 +--- 1 file changed, 78 insertions(+), 49 dele

[dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter

2019-03-19 Thread Xiaolong Ye
When create rte_mempool, flags can be parsed from command line. Now, it is possible for testpmd to create a af_xdp friendly mempool (which enable zero copy). Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- app/test-pmd/parameters.c | 12 app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v2 5/6] net/af_xdp: enable zero copy

2019-03-19 Thread Xiaolong Ye
Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 128 1 file ch

[dpdk-dev] [RFC] cryptodev/asymm: propose changes to RSA API

2019-03-19 Thread Kusztal, ArkadiuszX
Hi all, I would like to propose some changes to RSA API, I will put in this mail API comments I initially created and I will try additionally to elaborate about some of them too (with [AK]). Any comments, critique or ideas are much appreciated :). 1) Crypto op: @@ -395,9 +414,28 @@ struct rte_c

Re: [dpdk-dev] [PATCH] raw/ifpga: modify log output.

2019-03-19 Thread Pei, Andy
Hi, Rosen: Yes. Original code just print "ifpga:>>". After the patch, function name will be printed out ,like "ifpga:()", and every log info will goes in a new line. -Original Message- From: Xu, Rosen Sent: Tuesday, March 19, 2019 11:09 AM To: Pei, Andy ; dev@dpdk.org Cc: sta...@dpd

Re: [dpdk-dev] [PATCH v2 5/6] net/af_xdp: enable zero copy

2019-03-19 Thread Mattias Rönnblom
On 2019-03-19 08:12, Xiaolong Ye wrote: Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c |

Re: [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic builtins

2019-03-19 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 15, 2019 7:41 PM > To: Joyce Kong (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; Gavin Hu (Arm Technology China) > ; jer...@marvell.com; chao...@linux.vnet.ibm.com; > Richardson, Bruce ; tho...@monj

Re: [dpdk-dev] [PATCH 01/10] net/virtio: fix typo in packed ring init

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:03PM +0800, Tiwei Bie wrote: The pointer to event structure should be cast to uintptr_t first. Fixes: f803734b0f2e ("net/virtio: vring init for packed queues") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ring.h | 2 +- 1 file changed,

Re: [dpdk-dev] [PATCH v2 5/6] net/af_xdp: enable zero copy

2019-03-19 Thread Ye Xiaolong
Hi, Mattias Thanks for the review. On 03/19, Mattias Rönnblom wrote: >On 2019-03-19 08:12, Xiaolong Ye wrote: >> Try to check if external mempool (from rx_queue_setup) is fit for >> af_xdp, if it is, it will be registered to af_xdp socket directly and >> there will be no packet data copy on Rx an

Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:06PM +0800, Tiwei Bie wrote: Cache the AVAIL, USED and WRITE bits to avoid calculating them as much as possible. Note that, the WRITE bit isn't cached for control queue. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 35 ++

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Mattias Rönnblom
On 2019-03-19 08:12, Xiaolong Ye wrote: Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.or

[dpdk-dev] [PATCH v4 0/5] Supported VXLAN-GPE in i40e

2019-03-19 Thread Qiming Yang
This patch set supported new packet type VXLAN-GPE and add support for VXLAN-GPE packet classification. Acked-by: Qi Zhang --- V4: 1. rebased to the latest code. 2. deleted misleading statement. V3: 1. fixed issue in release note. 2. fixed check patch issue. 3. spilted eal related change to a ne

[dpdk-dev] [PATCH v4 3/5] net/i40e: support VXLAN-GPE classification

2019-03-19 Thread Qiming Yang
Added VXLAN-GPE tunnel filter, supported filter to queue. Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 0debee5..dbcacb0 100644 --- a/drivers/net/i40e/i40e

[dpdk-dev] [PATCH v4 2/5] net/i40e: add support for VXLAN-GPE

2019-03-19 Thread Qiming Yang
Add new protocol type VXLAN-GPE support for UDP tunnel. inner IP/TCP/UDP checksum and RSS configuration shared the same implementation of VXLAN. Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_ethdev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type

2019-03-19 Thread Qiming Yang
This patch added new item "vxlan-gpe" to tunnel_type to support new VXLAN-GPE packet type, and its clasification. Signed-off-by: Qiming Yang --- app/test-pmd/cmdline.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c i

[dpdk-dev] [PATCH v4 1/5] eal: add VXLAN-GPE macro

2019-03-19 Thread Qiming Yang
This patch added VXLAN-GPE macro in rte_eth_tunnel_type. Signed-off-by: Qiming Yang --- lib/librte_ethdev/rte_eth_ctrl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_eth_ctrl.h b/lib/librte_ethdev/rte_eth_ctrl.h index 5ea8ae2..b341634 100644 --- a/lib/librte_ethdev/r

[dpdk-dev] [PATCH v4 5/5] doc: add release note for VXLAN-GPE support

2019-03-19 Thread Qiming Yang
Updated release note. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_19_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 610c4cd..ab184df 100644 --- a/doc/guides/rel_notes/release_

Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED version

2019-03-19 Thread Tom Barbette
Hi Ali, Ubuntu 18.04 Linux XXX 4.15.0-46-generic #49-Ubuntu SMP Wed Feb 6 09:33:07 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux MLNX_OFED_LINUX-4.5-1.0.1.0-ubuntu18.04-x86_64 mft-4.11.0-103-x86_64-deb Device Type: ConnectX5 Part Number: MCX556A-ECA_Ax Description: ConnectX-5 V

Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 09:54:03AM +0100, Jens Freimann wrote: > On Tue, Mar 19, 2019 at 02:43:06PM +0800, Tiwei Bie wrote: > > Cache the AVAIL, USED and WRITE bits to avoid calculating > > them as much as possible. Note that, the WRITE bit isn't > > cached for control queue. > > > > Signed-off-by

Re: [dpdk-dev] [PATCH v6 2/4] meson: add infra to support machine specific flags

2019-03-19 Thread Bruce Richardson
On Mon, Mar 18, 2019 at 04:50:16PM +, Jerin Jacob Kollanukkaran wrote: > From: Pavan Nikhilesh > > Currently, RTE_* flags are set based on the implementer ID but there might > be some micro arch specific differences from the same vendor > eg. CACHE_LINESIZE. Add support to set micro arch spec

[dpdk-dev] 8023ad bond tx crashed if one port has 2 more tx queues

2019-03-19 Thread hfli
Hi Guys, I found a bug in dpdk bond code, while one port has 2 more tx queues, 8023ad bond port will be crashed in tx burst. Just analyzed the code below, if 2 more CPU cores send packets on a port by different tx queue, the arrays like slave_port_ids/ dist_slave_port_ids/ slave_tx_fail_c

[dpdk-dev] [PATCH v2 0/1] fips_validation: Add plain SHA support

2019-03-19 Thread Damian Nowak
This patch enables plain SHA algorithm CAVP test support in fips_validation sample application. --- v2: fix checkpatches issues Damian Nowak (1): fips_validation: Add plain SHA support examples/fips_validation/Makefile | 1 + examples/fips_validation/fips_validation.c | 17

[dpdk-dev] [PATCH v2 1/1] fips_validation: Add plain SHA support

2019-03-19 Thread Damian Nowak
This patch enables plain SHA algorithm CAVP test support in fips_validation sample application. Signed-off-by: Damian Nowak Acked-by: Fan Zhang Acked-by: Marko Kovacevic --- examples/fips_validation/Makefile | 1 + examples/fips_validation/fips_validation.c | 17 examp

Re: [dpdk-dev] [PATCH v6 1/2] eal/ticketlock: ticket based to improve fairness

2019-03-19 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 15, 2019 8:56 PM > To: Joyce Kong (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; step...@networkplumber.org; > jerin.ja...@caviumnetworks.com; tho...@monjalon.net; Honnappa > Nagarahalli ; Gavin Hu

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the same time. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 71 +--

Re: [dpdk-dev] [PATCH] app/eventdev: add option to set global dequeue tmo

2019-03-19 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-19 at 06:21 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Add option to provide a global dequeue timeout that is used to create > the eventdev. > The dequeue timeout provided will be common across all the worker > ports. If the eventdev hardware supports po

[dpdk-dev] [PATCH v2] cryptodev: make xform key pointer constant

2019-03-19 Thread Fan Zhang
This patch changes the key pointer data types in cipher, auth, and aead xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and safe sessionn creation. Signed-off-by: Fan Zhang --- v2: - fixed a missed memory free for ixgbe ipsec drivers/common/cpt/cpt_ucode.h | 1

Re: [dpdk-dev] [PATCH 06/10] net/virtio: drop redundant suffix in packed ring structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:08PM +0800, Tiwei Bie wrote: Drop redundant suffix (_packed and _event) from the fields in packed ring structure. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c| 2 +- drivers/net/virtio/virtio_ring.h | 15 ++--- dri

Re: [dpdk-dev] [PATCH] meson: remove build warnings

2019-03-19 Thread Bruce Richardson
On Mon, Mar 18, 2019 at 05:15:25PM +, Luca Boccassi wrote: > On Mon, 2019-03-18 at 16:28 +, Jerin Jacob Kollanukkaran wrote: > > From: Jerin Jacob > > > > Remove the following meson build warnings > > > > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1' > > but uses fea

Re: [dpdk-dev] [PATCH 07/10] net/virtio: drop unused field in Tx region structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:09PM +0800, Tiwei Bie wrote: Drop the unused field tx_indir_pq from virtio_tx_region structure. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 10 +- drivers/net/virtio/virtqueue.h | 8 ++-- 2 files changed, 3 insertions(+), 15 del

Re: [dpdk-dev] checklist for DPDK on Windows

2019-03-19 Thread Thomas Monjalon
Any feedback? Could we try to give a work estimation for these items? 15/03/2019 00:04, Thomas Monjalon: > Hi, > > Below is a list of directories, files or functions which we > need to check to make basic DPDK works on Windows. > If something is missing, please complete. > > The goal of this lis

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
Hi, Mattias Thanks for your comments. On 03/19, Mattias Rönnblom wrote: >On 2019-03-19 08:12, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla

Re: [dpdk-dev] [PATCH 09/10] net/virtio: add ctrl vq helper for split ring

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:11PM +0800, Tiwei Bie wrote: Add a helper for sending commands in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 76 +- 1 file changed,

Re: [dpdk-dev] [PATCH 08/10] net/virtio: add interrupt helper for split ring

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:10PM +0800, Tiwei Bie wrote: Add a helper for disabling interrupts in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtqueue.h | 13 +++-- 1 file changed, 11 insertions(+),

Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote: This patch improves descriptors refill by using the same batching strategy as done in in-order and mergeable path. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 60 ++-- 1 file changed, 34 in

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-19 Thread Dekel Peled
Hi, For ppc, rte_io_mb() is defined as rte_mb(), which is defined as asm sync. According to comments in arch/ppc_64/rte_atomic.h, rte_wmb() and rte_rmb() are the same as rte_mb(), for store and load respectively. My patch propose to define rte_wmb() and rte_rmb() as asm sync, like rte_mb(), sinc

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: > > Put split ring and packed ring specific fields into separate > > sub-structures, and also union them as they won't be available > > at the same time. > > > > Signed-off-b

Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 05:37:34PM +0800, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 09:54:03AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:06PM +0800, Tiwei Bie wrote: > Cache the AVAIL, USED and WRITE bits to avoid calculating > them as much as possible. Note that, the WRITE bit is

Re: [dpdk-dev] [PATCH v6 1/2] eal/ticketlock: ticket based to improve fairness

2019-03-19 Thread Ananyev, Konstantin
Hi Gavin, > > > > > diff --git a/lib/librte_eal/common/include/generic/rte_ticketlock.h > > b/lib/librte_eal/common/include/generic/rte_ticketlock.h > > > new file mode 100644 > > > index 000..d63 > > > --- /dev/null > > > +++ b/lib/librte_eal/common/include/generic/rte_ticketlock.h > >

Re: [dpdk-dev] [PATCH v2 2/2] vhost: support requests only handled by external backend

2019-03-19 Thread Maxime Coquelin
Hi Ilya, On 3/13/19 5:09 PM, Ilya Maximets wrote: On 13.03.2019 18:55, Maxime Coquelin wrote: External backends may have specific requests to handle, and so we don't want the vhost-user lib to handle these requests as errors. This patch also changes the experimental API by introducing RTE_VHOS

Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 11:04:24AM +0100, Jens Freimann wrote: > On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote: > > This patch improves descriptors refill by using the same > > batching strategy as done in in-order and mergeable path. > > > > Signed-off-by: Tiwei Bie > > --- > > drive

Re: [dpdk-dev] [PATCH] raw/ifpga: modify log output.

2019-03-19 Thread Xu, Rosen
Hi Andy, Get your point, and my reply is online. > -Original Message- > From: Pei, Andy > Sent: Tuesday, March 19, 2019 15:56 > To: Xu, Rosen ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] raw/ifpga: modify log output. > > Hi, Rosen: > > Yes. > Original code just print "ifp

[dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests

2019-03-19 Thread Maxime Coquelin
The goals of this series is to provide more flexibility to external backends to implement their specific vhost-user request handling without having to patch vhost-user library. First patch implements a new API for external backend to advertize its specific protocol features to vhost-user master.

[dpdk-dev] [PATCH v3 1/2] vhost: add API to set protocol features flags

2019-03-19 Thread Maxime Coquelin
rte_vhost_driver_set_protocol_features API is to be used by external backends to advertize vhost-user protocol features it supports. It has to be called after rte_vhost_driver_register() and before rte_vhost_driver_start(). Example of usage to advertize VHOST_USER_PROTOCOL_F_FOOBAR protocol featu

[dpdk-dev] [PATCH v3 2/2] vhost: support requests only handled by external backend

2019-03-19 Thread Maxime Coquelin
External backends may have specific requests to handle, and so we don't want the vhost-user lib to handle these requests as errors. This patch also changes the experimental API by introducing RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib can report an error if a message is handled neithe

Re: [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification

2019-03-19 Thread Burakov, Anatoly
On 18-Mar-19 11:56 AM, Hajkowski wrote: From: Marcin Hajkowski Due to lack of thread safety in exisiting solution use spinlock mechanism for atomic modification of power environment related data. Fixes: 445c6528b5 ("power: common interface for guest and host") Cc: sta...@dpdk.org Signed-off-b

Re: [dpdk-dev] [PATCH v2 2/4] power: return error in set env when power env already set

2019-03-19 Thread Burakov, Anatoly
On 18-Mar-19 11:56 AM, Hajkowski wrote: From: Marcin Hajkowski On attempt to set_env in already initialized state notify user by returning error that operation cannot be performed. Signed-off-by: Marcin Hajkowski --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 3/4] power: reset function pointers on unset env

2019-03-19 Thread Burakov, Anatoly
On 18-Mar-19 11:56 AM, Hajkowski wrote: From: Marcin Hajkowski Set all power environment related function pointers to NULL when unset is being made. Signed-off-by: Marcin Hajkowski --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2] lib/librte_meter: fix divide by zero for RFC4115 meter

2019-03-19 Thread Eelco Chaudron
On 28 Feb 2019, at 19:50, Dumitrescu, Cristian wrote: Hi Eelco, Sorry for my delayed reply No problem I was OOO also so hence my late reply ;) -Original Message- From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Friday, February 1, 2019 4:07 PM To: Dumitrescu, Cristian Cc:

Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path

2019-03-19 Thread Maxime Coquelin
On 3/19/19 11:28 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 11:04:24AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote: This patch improves descriptors refill by using the same batching strategy as done in in-order and mergeable path. Signed-off-by: T

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-19 Thread Thomas Monjalon
Guys, please let's avoid top-post. You are both not replying to each other: 1/ Dekel mentioned the IBM doc but Chao did not argue about the lack of IO protection with lwsync. We assume that rte_mb should protect any access including IO. 2/ Chao asked about the semantic of the barrier used in mlx

Re: [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types

2019-03-19 Thread Burakov, Anatoly
On 18-Mar-19 11:56 AM, Hajkowski wrote: From: Marcin Hajkowski Test all existing power environment configuration to verify if related data is properly initialized and clean in set/unset scenarios. Signed-off-by: Marcin Hajkowski --- + rte_power_unset_env(); + + /* Perform t

[dpdk-dev] [PATCH v3] lib/librte_meter: fix divide by zero for RFC4115 meter

2019-03-19 Thread Eelco Chaudron
RFC 4115 allows a meter with either cir and/or eir configured. When only one is configured a divide by zero would occur. Fixes: 655796d2b5fb ("meter: support RFC4115 trTCM") Cc: echau...@redhat.com Signed-off-by: Eelco Chaudron --- v3 - Rather than using a 0 check, set up profile data such tha

Re: [dpdk-dev] [PATCH 01/10] net/virtio: fix typo in packed ring init

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: The pointer to event structure should be cast to uintptr_t first. Fixes: f803734b0f2e ("net/virtio: vring init for packed queues") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ring.h | 2 +- 1 file changed, 1 insertion(+)

Re: [dpdk-dev] [PATCH 02/10] net/virtio: fix interrupt helper for packed ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: When disabling interrupt, the shadow event flags should also be updated accordingly. The unnecessary wmb is also dropped. Fixes: e9f4feb7e622 ("net/virtio: add packed virtqueue helpers") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virt

Re: [dpdk-dev] [PATCH 03/10] net/virtio: add missing barrier in interrupt enable

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Typically, after enabling Rx interrupt, a check should be done to make sure that there is no new incoming packets before going to sleep. So a barrier is needed to make sure that any following check won't happen before the interrupt is actually enabled. Fix

Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 11:11 AM, Jens Freimann wrote: same here. it's not really cached, it's pre-calculated. And here we could also use a pre-calculated constand/define. For pre-calculated constant/define, do you mean VRING_DESC_F_AVAIL(1) and VRING_DESC_F_USED(1)? There is still little code in virtio

Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Cache the AVAIL, USED and WRITE bits to avoid calculating them as much as possible. Note that, the WRITE bit isn't cached for control queue. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 35 ++ drivers/ne

Re: [dpdk-dev] [PATCH v4 0/5] Supported VXLAN-GPE in i40e

2019-03-19 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, March 20, 2019 12:37 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v4 0/5] Supported VXLAN-GPE in i40e > > This patch set supported new packet type VXLAN-GPE and add support for > VXLAN-GPE packet c

[dpdk-dev] Ask help for mlx5 pmd driver

2019-03-19 Thread benli ye
Hi, Could you please help me on mlx5 pmd driver? I have two mlx5 driver powered NICs (eth0 and eth1) and one is conneted to internet and the other is connected to intranet. I want to use linux kernel net stack tool like bird app to send ospf packets and use ssh to login. But when I run the dpdk

[dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error

2019-03-19 Thread Shreyansh Jain
Until now, DPAA2 driver was configured to drop any packet which was marked as malformed by hardware - which included those with wrong checksum. With this patch, that configuration has been removed - hereafter, all packets arriving on a DPMAC link would be forwarded to a DPNI and further processing

Re: [dpdk-dev] [RFC v3] ethdev: claim device reset as async

2019-03-19 Thread Ferruh Yigit
On 10/4/2018 4:58 PM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, October 4, 2018 7:30 PM >> To: Zhang, Qi Z ; tho...@monjalon.net; Doherty, >> Declan >> Cc: ktray...@redhat.com; dev@dpdk.org; Shelton, Benjamin H >> ; Vangati, Narender >> >> Su

Re: [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU

2019-03-19 Thread Yigit, Ferruh
On 2/18/2019 6:01 PM, Yigit, Ferruh wrote: > On 11/28/2018 1:12 PM, Lam, Tiago wrote: >> On 27/11/2018 17:43, Ferruh Yigit wrote: >>> On 11/20/2018 10:26 AM, Tiago Lam wrote: Use the underlying MTU to calculate the framsize to be used for the mmap RINGs. This is to make it more flexible o

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

2019-03-19 Thread Yigit, Ferruh
On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > The patch series tries to improve documentation of what is retained > across default restart. > > Andrew Rybchenko (3): > ethdev: advertise MTU as retained across device stop/start > ethdev: advertise default MAC as retained on device restart >

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the s

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the same time. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 71 +- drivers/net

Re: [dpdk-dev] [PATCH 06/10] net/virtio: drop redundant suffix in packed ring structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Drop redundant suffix (_packed and _event) from the fields in packed ring structure. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c| 2 +- drivers/net/virtio/virtio_ring.h | 15 ++--- drivers/net/virt

Re: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment and layout

2019-03-19 Thread Akhil Goyal
Hi Konstantin, On 3/7/2019 7:43 PM, Konstantin Ananyev wrote: > in 18.08 new cache-aligned structure rte_crypto_asym_op was introduced. > As it also was included into rte_crypto_op, it caused implicit change > in rte_crypto_op layout and alignment: now rte_crypto_op is cahce-line > aligned has a h

Re: [dpdk-dev] [PATCH 07/10] net/virtio: drop unused field in Tx region structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Drop the unused field tx_indir_pq from virtio_tx_region structure. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 10 +- drivers/net/virtio/virtqueue.h | 8 ++-- 2 files changed, 3 insertions(+), 15 deletions(-)

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-19 Thread Yigit, Ferruh
On 1/8/2019 11:30 AM, Tom Barbette wrote: > Ferruh Yigit wrote: >> Why timestamp offloading become useless? When timestamp offloading enabled, >> device fills 'mbuf.timestamp' and you can use it. > But the frequency is unknown, and the reference time neither. So it can be > used only to know that

Re: [dpdk-dev] [PATCH 08/10] net/virtio: add interrupt helper for split ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Add a helper for disabling interrupts in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtqueue.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [RFC v3] ethdev: claim device reset as async

2019-03-19 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 19, 2019 9:14 PM > To: Zhang, Qi Z ; tho...@monjalon.net; Doherty, Declan > > Cc: ktray...@redhat.com; dev@dpdk.org; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [RFC v3] ethdev: claim device reset as async

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-19 Thread Akhil Goyal
On 3/11/2019 11:25 AM, Anoob Joseph wrote: > The string compare to the length of driver name might give false > positives when there are drivers with similar names (one being the > subset of another). > > Following is such a naming which could result in false positive. > 1. crypto_driver > 2. cry

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app

2019-03-19 Thread Akhil Goyal
On 3/8/2019 9:05 PM, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Iremonger, Bernard >> Sent: Thursday, March 7, 2019 10:35 AM >> To: dev@dpdk.org; Ananyev, Konstantin ; >> akhil.go...@nxp.com >> Cc: Iremonger, Bernard ; sta...@dpdk.org >> Subject: [PATCH] examples/ipsec-s

Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

2019-03-19 Thread Akhil Goyal
On 3/5/2019 8:10 PM, Fan Zhang wrote: > This patch fixes the incorrect block size for AES-CTR in > legacy mode. Originally, wrong block size will cause > esp_inbound() drop AES-CTR encrypted packets if the payload > sizes not equal to multiple times of 16. > > Fixes: 4470c22de2e1 ("examples/ipsec

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-st

Re: [dpdk-dev] [PATCH v4 1/5] eal: add VXLAN-GPE macro

2019-03-19 Thread David Marchand
eal: in the title ? we are in ethdev. On Tue, Mar 19, 2019 at 10:14 AM Qiming Yang wrote: > This patch added VXLAN-GPE macro in rte_eth_tunnel_type. > > Signed-off-by: Qiming Yang > --- > lib/librte_ethdev/rte_eth_ctrl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ethde

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 2:47 PM, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and pac

Re: [dpdk-dev] [PATCH] EAL: count nr_overcommit_hugepages as available

2019-03-19 Thread Burakov, Anatoly
On 25-Feb-19 8:57 PM, Michał Mirosław wrote: From: Michał Mirosław With nr_overcommit_hugepages > 0 application may be able to allocate hugepages even when free_hugepages == 0. Take this into account when counting available hugepages. Signed-off-by: Michał Mirosław --- Surplus pages go back

Re: [dpdk-dev] [PATCH 09/10] net/virtio: add ctrl vq helper for split ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Add a helper for sending commands in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 76 +- 1 file changed, 43 insertions(+

Re: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment and layout

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:03 PM, Akhil Goyal wrote: > Hi Konstantin, > > On 3/7/2019 7:43 PM, Konstantin Ananyev wrote: >> in 18.08 new cache-aligned structure rte_crypto_asym_op was introduced. >> As it also was included into rte_crypto_op, it caused implicit change >> in rte_crypto_op layout and alignment

Re: [dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

2019-03-19 Thread Akhil Goyal
On 2/8/2019 4:43 PM, Arek Kusztal wrote: > This patchset adds result field to modular exponentiation and modular > inverse operations > > This patchset depends on following patches: > > [1] - "[v3] cryptodev: rework mod exp and mod inv comments" > (http://patchwork.dpdk.org/patch/50139/) > [2] -

Re: [dpdk-dev] [PATCH] qat/compress: fix qat comp setup inter_buffers

2019-03-19 Thread Akhil Goyal
On 1/30/2019 5:44 PM, Trahe, Fiona wrote: > >> -Original Message- >> From: Kovacevic, Marko >> Sent: Thursday, January 24, 2019 3:03 PM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Yigit, Ferruh ; >> ktray...@redhat.com; Kovacevic, Marko >> ; Trahe, Fiona >> Subject: [PATCH] qat/compress

Re: [dpdk-dev] [PATCH] compress/isal: add ISA-L lib version display

2019-03-19 Thread Akhil Goyal
On 2/11/2019 3:12 PM, Daly, Lee wrote: > Hi Tomasz, > Looks good to me. >> -Original Message- >> From: Cel, TomaszX >> Sent: Monday, February 11, 2019 9:19 AM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Trahe, Fiona ; Daly, Lee >> ; De Lara Guarch, Pablo >> ; Jozwiak, TomaszX >> ; C

Re: [dpdk-dev] [PATCH] compress/qat: add fallback to fixed compression

2019-03-19 Thread Akhil Goyal
On 2/15/2019 10:31 PM, Trahe, Fiona wrote: > >> -Original Message- >> From: Jozwiak, TomaszX >> Sent: Friday, February 15, 2019 9:45 AM >> To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX >> >> Subject: [PATCH] compress/qat: add fallback to fixed compression >> >> This patch adds fallba

[dpdk-dev] [PATCH] doc: fix abi check script examples

2019-03-19 Thread David Marchand
The doc examples are not aligned on the script following the incriminated commit. Fixes: c4a5fe3bf832 ("devtools: rework ABI checker script") Cc: sta...@dpdk.org Cc: Olivier Matz Cc: Neil Horman Signed-off-by: David Marchand --- doc/guides/contributing/versioning.rst | 19 +++

Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:15 PM, Akhil Goyal wrote: > > On 3/5/2019 8:10 PM, Fan Zhang wrote: >> This patch fixes the incorrect block size for AES-CTR in >> legacy mode. Originally, wrong block size will cause >> esp_inbound() drop AES-CTR encrypted packets if the payload >> sizes not equal to multiple time

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:13 PM, Akhil Goyal wrote: > > On 3/8/2019 9:05 PM, Ananyev, Konstantin wrote: >>> -Original Message- >>> From: Iremonger, Bernard >>> Sent: Thursday, March 7, 2019 10:35 AM >>> To: dev@dpdk.org; Ananyev, Konstantin ; >>> akhil.go...@nxp.com >>> Cc: Iremonger, Bernard ; sta

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:12 PM, Akhil Goyal wrote: > > On 3/11/2019 11:25 AM, Anoob Joseph wrote: >> The string compare to the length of driver name might give false >> positives when there are drivers with similar names (one being the >> subset of another). >> >> Following is such a naming which could res

Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: This patch improves descriptors refill by using the same batching strategy as done in in-order and mergeable path. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 60 ++-- 1 file changed, 34 insertions(+), 26

Re: [dpdk-dev] [PATCH v2 1/4] ipsec: add AES-CTR algorithm support

2019-03-19 Thread Akhil Goyal
Hi Fan, title should be ipsec: support aes-ctr On 2/19/2019 9:02 PM, Fan Zhang wrote: > This patch adds AES-CTR cipher algorithm support to ipsec > library. > > Signed-off-by: Fan Zhang > --- > lib/librte_ipsec/crypto.h | 17 ++ > lib/librte_ipsec/sa.c | 133 > ++

Re: [dpdk-dev] [PATCH v2 3/4] ipsec: add 3DES-CBC algorithm support

2019-03-19 Thread Akhil Goyal
On 2/19/2019 9:02 PM, Fan Zhang wrote: > This patch adds triple-des CBC mode cipher algorithm to ipsec > library. > > Signed-off-by: Fan Zhang > --- > lib/librte_ipsec/sa.c | 10 ++ > lib/librte_ipsec/sa.h | 6 ++ > 2 files changed, 16 insertions(+) > > diff --git a/lib/librte_i

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Kevin Traynor
On 19/03/2019 13:50, Maxime Coquelin wrote: > > > On 3/19/19 2:47 PM, Jens Freimann wrote: >> On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: >>> >>> >>> On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > On Tue, Mar 19

Re: [dpdk-dev] [PATCH v2 2/4] power: extend guest channel api for reading

2019-03-19 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > --- > diff --git a/lib/librte_power/channel_commands.h > +#define CPU_POWER_CMD_NAK 2 Instead of NAK , NACK would be better I guess. > + if (global_fds[lcore_id] == 0) { Is this now < 0

Re: [dpdk-dev] 8023ad bond tx crashed if one port has 2 more tx queues

2019-03-19 Thread Chas Williams
On 3/19/19 5:41 AM, h...@netitest.com wrote: Hi Guys, I found a bug in dpdk bond code, while one port has 2 more tx queues, 8023ad bond port will be crashed in tx burst. Just analyzed the code below, if 2 more CPU cores send packets on a port by different tx queue, the arrays like slave_po

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Ferruh Yigit
On 2/20/2019 10:10 PM, Thomas Monjalon wrote: > If multiple ports share the same hardware device (rte_device), > they are siblings and can be found thanks to the new functions > and loop macros. > One iterator takes a port id as reference, > while the other one directly refers to the parent device.

  1   2   >